Hi Stanislav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    
https://github.com/0day-ci/linux/commits/Stanislav-Fomichev/bpf-add-BPF_CGROUP_INET-4-6-_SOCK_RELEASE-hooks/20190118-141334
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-randconfig-x005-201902 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-14) 8.2.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   net//ipv4/af_inet.c: In function 'inet_release':
>> net//ipv4/af_inet.c:439:3: error: implicit declaration of function 
>> 'BPF_CGROUP_RUN_PROG_INET4_SOCK_RELEASE'; did you mean 
>> 'BPF_CGROUP_RUN_PROG_INET_SOCK'? [-Werror=implicit-function-declaration]
      BPF_CGROUP_RUN_PROG_INET4_SOCK_RELEASE(sk);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      BPF_CGROUP_RUN_PROG_INET_SOCK
   cc1: some warnings being treated as errors
--
   net//ipv6/af_inet6.c: In function 'inet6_release':
>> net//ipv6/af_inet6.c:468:3: error: implicit declaration of function 
>> 'BPF_CGROUP_RUN_PROG_INET6_SOCK_RELEASE'; did you mean 
>> 'BPF_CGROUP_RUN_PROG_INET_SOCK'? [-Werror=implicit-function-declaration]
      BPF_CGROUP_RUN_PROG_INET6_SOCK_RELEASE(sock->sk);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      BPF_CGROUP_RUN_PROG_INET_SOCK
   cc1: some warnings being treated as errors

vim +439 net//ipv4/af_inet.c

   433  
   434  int inet_release(struct socket *sock)
   435  {
   436          struct sock *sk = sock->sk;
   437  
   438          if (sk && !sk->sk_kern_sock)
 > 439                  BPF_CGROUP_RUN_PROG_INET4_SOCK_RELEASE(sk);
   440  
   441          return __inet_release(sock);
   442  }
   443  EXPORT_SYMBOL(inet_release);
   444  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to