On 01.01.2019 09:42, Murali Krishna Policharla wrote:
> Store newly configured mtu settings in the netdevice after mtu
> configuration is successful to the dsa switch.
>
> Fixes: 2315dc91a5 ("net: make dev_set_mtu() honor notification return code")
> Signed-off-by: Murali Krishna Policharla
> Rev
When strict checking is enabled the kernel expects to receive the
ifindex of the bridge device using 'NDA_MASTER', but iproute2 currently
uses 'IFLA_MASTER' which the kernel expects when strict checking is
disabled. Therefore, using iproute2 on current kernels while filtering
on bridge results in t
Store newly configured mtu settings in the netdevice after mtu
configuration is successful to the dsa switch.
Fixes: 2315dc91a5 ("net: make dev_set_mtu() honor notification return code")
Signed-off-by: Murali Krishna Policharla
Reviewed-by: Florian Fainelli
---
net/core/dev.c | 9 ++---
1 f
On Mon, 24 Dec 2018 16:49:44 +0800
we...@ucloud.cn wrote:
> From: wenxu
>
> ip rule add from all iif gretap tun_id 2000 lookup 200
>
> Signed-off-by: wenxu
Applied, thanks for fixing man page as well.
On Fri, 28 Dec 2018 10:32:11 -0500
Matt Ellison wrote:
> Support for new (4.19+) xfrm virtual interfaces.
>
> Interfaces take a 'if_id' which is an interface id which can be set on
> an xfrm policy as its interface lookup key (XFRMA_IF_ID).
>
> Signed-off-by: Matt Ellison
Wanted to apply this
On Thu, 27 Dec 2018 15:18:51 +0200
Firas Khalil Khana wrote:
I want to take this patch, but it is missing the Signed-Off-by: required
for this project.
Also please add:
Fixes: 377a09902a57 ("configure: Minor code cleanup")
On Mon, Dec 31, 2018 at 08:25:38PM -0800, Stephen Hemminger wrote:
> On Sun, 30 Dec 2018 18:03:47 -0700
> David Ahern wrote:
>
> > On 12/30/18 10:14 AM, Ido Schimmel wrote:
> > > Since commit aea41afcfd6d ("ip bridge: Set NETLINK_GET_STRICT_CHK on
> > > socket") iproute2 uses strict checking on k
On Fri, 21 Dec 2018 22:53:35 -0800
Eric Dumazet wrote:
> A recent change reduced max line length from 4096 to 2048 bytes,
> but we already have lines above the 2048 threshold, and we keep
> adding more SNMP counters in linux.
>
> Switch to getline() and do not worry about future kernel changes.
On Fri, 21 Dec 2018 16:18:54 +0800
we...@ucloud.cn wrote:
> +
> + if (tb[LWTUNNEL_IP_FLAGS]) {
> + flags = rta_getattr_u16(tb[LWTUNNEL_IP_FLAGS]);
> + if (flags & TUNNEL_KEY)
> + print_string(PRINT_ANY, NULL, "%s ", "key");
> + if (flags
On Sun, 30 Dec 2018 18:03:47 -0700
David Ahern wrote:
> On 12/30/18 10:14 AM, Ido Schimmel wrote:
> > Since commit aea41afcfd6d ("ip bridge: Set NETLINK_GET_STRICT_CHK on
> > socket") iproute2 uses strict checking on kernels that support it. This
> > causes FDB dumping to fail [1], as iproute2 us
On Mon, 31 Dec 2018 16:32:13 +0200, Eran Ben Elisha wrote:
> +Once an error is reported, devlink health will do the following actions:
> + * A log is being send to the kernel trace events buffer
> + * Health status and statistics are being updated for the reporter instance
> + * Object dump is b
On Mon, 31 Dec 2018 16:31:54 +0200, Eran Ben Elisha wrote:
> The health mechanism is targeted for Real Time Alerting, in order to know when
> something bad had happened to a PCI device
> - Provide alert debug information
> - Self healing
> - If problem needs vendor support, provide a way to gather
Add tests for newly added dead code elimination. Both verifier
and BTF tests are added. BTF test infrastructure has to be
extended to be able to account for line info which is eliminated
during dead code removal.
Signed-off-by: Jakub Kicinski
---
tools/testing/selftests/bpf/test_btf.c | 3
Let offload JITs know when instructions are replaced and optimized
out, so they can update their state appropriately. The optimizations
are best effort, if JIT returns an error from any callback verifier
will stop notifying it as state may now be out of sync, but the
verifier continues making prog
Instead of passing env->prog->len around, and trying to adjust
for optimized out instructions just save the initial number
of instructions in struct nfp_prog.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/net/ethernet/netronome/nfp/bpf/jit.c | 4 ++--
drivers/net/et
Instruction number is meaningless at code gen phase. The target
of the instruction is overwritten by nfp_fixup_branches(). The
convention is to put the raw offset in target address as a place
holder. See cmp_* functions.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/n
Add a verifier callback to the nfp JIT to remove the instructions
the verifier deemed to be dead.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/net/ethernet/netronome/nfp/bpf/main.h | 6 -
.../net/ethernet/netronome/nfp/bpf/offload.c | 5
.../net/ethernet/net
Loading programs with dead code becomes more and more
common, as people begin to patch constants at load time.
Turn conditional jumps to unconditional ones, to avoid
potential branch misprediction penalty.
This optimization is enabled for privileged users only.
For branches which just fall throug
We fail program loading if jump lands on a skipped instruction.
This is for historical reasons, it used to be that we only skipped
instructions optimized out based on prior context, and therefore
the optimization would be buggy if we jumped directly to such
instruction (because the context would be
Instead of overwriting dead code with jmp -1 instructions
remove it completely for root. Adjust verifier state and
line info appropriately.
v2:
- adjust func_info (Alexei);
- make sure first instruction retains line info (Alexei).
v4: (Yonghong)
- remove unnecessary if (!insn to remove) checks
Verifier will now optimize out branches to dead code, implement
the replace_insn callback to take advantage of that optimization.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/net/ethernet/netronome/nfp/bpf/main.h | 14
.../net/ethernet/netronome/nfp/bpf/offload
Unconditional branches by 0 instructions are basically noops
but they can result from earlier optimizations, e.g. a conditional
jumps which would never be taken or a conditional jump around
dead code.
Remove those branches.
v0.2:
- s/opt_remove_dead_branches/opt_remove_nops/ (Jiong).
Signed-off
The communication between the verifier and advanced JITs is based
on instruction indexes. We have to keep them stable throughout
the optimizations otherwise referring to a particular instruction
gets messy quickly.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
include/linux/bpf
In preparation for code removal change parameters to branch
and call adjustment functions to be more universal. The
current parameters assume we are patching a single instruction
with a longer set.
A diagram may help reading the change, this is for the patch
single case, patching instruction 1 wi
Hi!
This set adds support for complete removal of dead code.
Patch 3 contains all the code removal logic, patches 2 and 4
additionally optimize branches around and to dead code.
Patches 6 and 7 allow offload JITs to take advantage of the
optimization. After a few small clean ups (8, 9, 10) nfp
On Mon, Nov 26, 2018 at 06:43:00PM +, Salil Mehta wrote:
> From: Peng Li
>
> Port 0/1 of HiP08 supports 10G and 25G. This patch adds a
> change to configure NIC port speed same as that of optical
> module(SFP/QFSP). Driver gets the optical module speed and
> sets NIC port speed accordingly.
Am 31.12.18 um 18:50 schrieb Mark Brown:
> On Sun, Dec 30, 2018 at 11:55:46AM +0100, Andreas Färber wrote:
>> Given that observed symptoms were CPU stalls, workqueue hangs and RCU
>> problems, requiring a power-cycle to recover, I wonder whether we are
>> running into some atomic/locking issue with
On Mon, 31 Dec 2018 21:41:22 +, Yonghong Song wrote:
> > func2 after func adjust will start at off and there is no line info for
> > off + cnt (insn4), so we will preserve line_info2.
>
> Thanks for verification, I missed that
> >>> +/* count lines to be removed */
> >>> +l
Hello,
syzbot found the following crash on:
HEAD commit:90cadbbf341d Merge git://git.kernel.org/pub/scm/linux/kern..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=17127500c0
kernel config: https://syzkaller.appspot.com/x/.config?x=f9a32c9a4aef9af7
da
Witam
Working setup (driver e1000e):
# ethtool -k eth1 | grep vlan
rx-vlan-offload: on
tx-vlan-offload: on
rx-vlan-filter: on [fixed]
vlan-challenged: off [fixed]
tx-vlan-stag-hw-insert: off [fixed]
rx-vlan-stag-hw-parse: off [fixed]
rx-vlan-stag-filter: off [fixed]
Broken setup (driver e1000e):
On Sat, 29 Dec 2018 13:52:23 +0100, Bartek Kois wrote:
> Hi,
> I`ve got problem while queuing with HFSC vlan tagged packets after
> migrating my tc scripts from Debian 8.2 (3.16.0-4-amd64) to Debian 9.5
> (4.9.0-6-amd64). tc filters added to eth1 do not classify correctly src
> and dst ip addres
Commit 33a48ab105a7 ("ibmveth: Fix DMA unmap error") fixed an issue in the
normal code path of ibmveth_xmit_start() that was originally introduced by
Commit 6e8ab30ec677 ("ibmveth: Add scatter-gather support"). This original
fix missed the error path where dma_unmap_page is wrongly called on the
he
On 12/31/18 12:31 PM, Jakub Kicinski wrote:
> On Sun, 30 Dec 2018 22:02:10 +, Yonghong Song wrote:
>> On 12/28/18 7:09 PM, Jakub Kicinski wrote:
>>> +static int bpf_adj_linfo_after_remove(struct bpf_verifier_env *env, u32
>>> off,
>>> + u32 cnt)
>>> +{
>>> +
Hello,
syzbot found the following crash on:
HEAD commit:fc2fd5f0f1aa Merge branch 'x86-platform-for-linus' of git:..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=172a9e5340
kernel config: https://syzkaller.appspot.com/x/.config?x=9a98287508be3ff9
da
On Sun, 30 Dec 2018 22:02:10 +, Yonghong Song wrote:
> On 12/28/18 7:09 PM, Jakub Kicinski wrote:
> > +static int bpf_adj_linfo_after_remove(struct bpf_verifier_env *env, u32
> > off,
> > + u32 cnt)
> > +{
> > + struct bpf_subprog_info *need_first_linfo;
> > +
Name: 冷井武
Email: netdev@vger.kernel.org
Comments: 2018年相约【太阳城】：2220859.com 共享激情联赛，注册申请28。首存赠送100%。 客服QQ：624916091
接待群：755067656 万岑深积翠，路向此中难。欲暮多羁思，因高莫远看。
烟水依泉谷，川陆散樵渔。忽念故园日，复忆骊山居。
Hi,
I tested 4.20 and the problem remains (it is not possible to classify
tagged packets if the root filter is on physical interface).
Best regards
Bartek Kois
W dniu 30.12.2018 o 22:14, Bartek Kois pisze:
Hi
I haven`t tested any newer kernels cause I thought that something
related to packet
On Sun, Dec 30, 2018 at 11:55:46AM +0100, Andreas Färber wrote:
> + linux-spi, LAKML
> Given that observed symptoms were CPU stalls, workqueue hangs and RCU
> problems, requiring a power-cycle to recover, I wonder whether we are
> running into some atomic/locking issue with clk_enable()? Is it val
On Mon, Dec 31, 2018 at 12:24:18PM +0100, Klaus Kudielka wrote:
> On 30.12.18 10:51, Andrew Lunn wrote:
>
> >Some of the Marvell Ethernet switches have a similar setup. Some ports
> >have both an internal PHY and a SERDES port which can be connected to an
> >SFP cage. Whichever gets link first is
This patch add support for the following commands:
Devlink health show [DEV reporter REPORTE_NAME],
Devlink health recover DEV reporter REPORTER_NAME,
Devlink health diagnose DEV reporter REPORTER_NAME,
Devlink health objdump show DEV reporter REPORTER_NAME,
Devlink health objdump clear DEV reporte
On 2018-12-30 14:26, Colin King wrote:
> From: Colin Ian King
>
> Don't populate the const array 'data' on the stack but instead
> make it static. Makes the object code smaller by 78 bytes:
>
> Before:
>textdata bss dec hex filename
>54381080 065181976 m
From: Moshe Shemesh
Add support of objdump callback for mlx5 FW reporter.
Once we trigger FW dump, the FW will write the core dump to its raw data
buffer. The tracer translates the raw data to traces and save it to a
buffer. Once dump is done, the saved traces data is filled as objects
into the o
Devlink health buffer is a mechanism to pass descriptors between drivers
and devlink. The API allows the driver to add objects, object pair,
value array (nested attributes), value and name.
Driver can use this API to fill the buffers in a format which can be
translated by the devlink to the netlin
From: Moshe Shemesh
Report devlink health on FW fatal issues via FW_fatal_reporter. The
driver recover flow for FW fatal error is now being handled by the
devlink health.
Having the recovery controlled by devlink health, the user has the
ability to cancel the auto-recovery for debug session and
Add devlink health objdump commands, in order to run an objdump operation
over a specific reporter.
The supported operations are objdump_get in order to get last saved
objdump (if not exist, dump now) and objdump_clear to clear last saved
objdump.
It is expected from driver's callback for diagnos
From: Moshe Shemesh
Use devlink_health_report() to report any symptom of FW issue as FW
counter miss or new health syndrom.
Signed-off-by: Moshe Shemesh
---
.../net/ethernet/mellanox/mlx5/core/devlink.c | 21 +++
.../net/ethernet/mellanox/mlx5/core/devlink.h | 1 +
.../net/eth
The health mechanism is targeted for Real Time Alerting, in order to know when
something bad had happened to a PCI device
- Provide alert debug information
- Self healing
- If problem needs vendor support, provide a way to gather all needed debugging
information.
The main idea is to unify and ce
Add devlink health recover command to the uapi, in order to allow the user
to execute a recover operation over a specific reporter.
Signed-off-by: Eran Ben Elisha
---
include/uapi/linux/devlink.h | 1 +
net/core/devlink.c | 20
2 files changed, 21 insertions(+)
d
From: Moshe Shemesh
Add access functions to core dump register to enable trigger FW core
dump.
Signed-off-by: Moshe Shemesh
---
.../mellanox/mlx5/core/diag/fw_tracer.c | 31 +++
include/linux/mlx5/driver.h | 1 +
include/linux/mlx5/mlx5_ifc.h
Add mlx5e tx reporter to devlink health reporters. This reporter will be
responsible for diagnosing, reporting and recovering of TX errors.
This patch declares the TX reporter operations and allocate it using the
devlink health API. Currently, this reporter supports reporting and
recovering from se
Add devlink health diagnose command, in order to run a diagnose
operation over a specific reporter.
It is expected from driver's callback for diagnose command to fill it via the
buffer descriptors API. Devlink will parse it and convert isto netlink nla API
in order to pass it to the user.
Signed-
From: Aya Levin
This patch adds a new file to add information about devlink health
mechanism.
Signed-off-by: Aya Levin
---
Documentation/networking/devlink-health.txt | 86 +
1 file changed, 86 insertions(+)
create mode 100644 Documentation/networking/devlink-health.txt
d
With this patch, ndo_tx_timeout callback will be redirected to the TX
reporter in order to detect a TX timeout error and report it to the
devlink health. (The watchdog detects TX timeouts, but the driver verify
the issue still exists before launching any recover method).
In addition, recover from
From: Moshe Shemesh
Refactor print health info code, split to two functions:
1. mlx5_get_health_info() - writes the health info into a buffer.
2. mlx5_print_health_info() - prints the health info to kernel log.
This refactoring is done to enable using the health info data by devlink
health repo
From: Moshe Shemesh
Create mlx5_devlink_health_reporter for FW fatal reporter.
The FW fatal reporter is added in addition to the fw reporter and
implements only the recover callback.
The point of having two reporters for FW issues, is that we
don't want to run FW recover on any issue, but only fa
Add devlink health get command to provide reporter/s data for user space.
Add the ability to get data per reporter or dump data from all available
reporters.
Signed-off-by: Eran Ben Elisha
---
include/uapi/linux/devlink.h | 12 +++
net/core/devlink.c | 151
Add devlink health set command, in order to set configuration parameters
for a specific reporter.
Supported parameters are:
- graceful_period: Time interval between auto recoveries (in msec)
- auto_recover: Determines if the devlink shall execute recover upon receiving
error for the
Upon error discover, every driver can report it to the devlink health
mechanism via devlink_health_report function, using the appropriate
reporter registered to it. Driver can pass error specific context which
will be delivered to it as part of the objdump / recovery callbacks.
Once an error is re
From: Moshe Shemesh
Create mlx5_devlink_health_reporter for FW reporter. The FW reporter
implements devlink_health_reporter diagnose callback.
Signed-off-by: Moshe Shemesh
---
.../net/ethernet/mellanox/mlx5/core/devlink.c | 115 ++
.../net/ethernet/mellanox/mlx5/core/devlink.h
Centralize all devlink related callbacks in one file.
In the downstream patch, some more functionality will be added, this
patch is preparing the driver infrastructure for it.
Currently, move devlink un/register functions calls into this file.
Signed-off-by: Eran Ben Elisha
Reviewed-by: Moshe Sh
Devlink health reporter is an instance for reporting, diagnosing and
recovering from run time errors discovered by the reporters.
Define it's data structure and supported operations.
In addition, expose devlink API to create and destroy a reporter.
Each devlink instance will hold it's own reporters
Am 30.12.18 um 11:55 schrieb Andreas Färber:
> Am 29.12.18 um 21:16 schrieb Andreas Färber:
>> `sudo ip link set lora2 up` froze my system, with both
>> lora1 and lora2 being sx1301. [...]
>>
>> Investigating...
>
> I've bisected and confirmed that it was indeed this patch that regresses
> for one
On 30.12.18 10:51, Andrew Lunn wrote:
Some of the Marvell Ethernet switches have a similar setup. Some
ports have both an internal PHY and a SERDES port which can be
connected to an SFP cage. Whichever gets link first is connected to
the MAC.
This decision is taken by hardware? I am just won
> >Having so many front end drivers for a chipset should be done in a
> >more modular manner, so that in fact they could all coexist if
> >necessary.
>
> Not sure I follow your meaning ... are you suggesting to allow the back end
> driver to use run-time selectable IO accessors and other generic h
On Sun, Sep 23, 2018 at 10:14 AM Dmitry Vyukov wrote:
>
> On Sun, Sep 23, 2018 at 9:42 AM, syzbot
> wrote:
> > Hello,
> >
> > syzbot found the following crash on:
> >
> > HEAD commit:474ff2600889 net-ethtool: ETHTOOL_GUFO did not and should ..
> > git tree: net
> > console output: https
Hi MST and Jason,
Could you please take a look at this? This bug is caused by a thread
resizing the tun-queue (via tun_queue_resize -> ptr_ring_resize_multiple).
And error happens in tun_net_xmit -> ptr_ring_produce. My guess is bug
happens when reading r->queue in ptr_ring_produce.
I've look a
Hi Dave,
Am 29.12.2018 um 09:43 schrieb David Miller:
From: Michael Schmitz
Date: Sat, 22 Dec 2018 10:30:58 +1300
Am 21.12.2018 um 13:10 schrieb David Miller:
And in particular this huge complicated Kconfig construct is not
maintainable at all.
We can trim this down a bit (for reasons I've
Hello,
syzbot found the following crash on:
HEAD commit:f346b0becb1b Merge branch 'akpm' (patches from Andrew)
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10f0bbdd40
kernel config: https://syzkaller.appspot.com/x/.config?x=c255c77ba370fe7c
dashboar
On Mon, Dec 31, 2018 at 9:17 AM Tetsuo Handa
wrote:
>
> On 2018/12/31 16:49, Dmitry Vyukov wrote:
> > On Mon, Dec 31, 2018 at 8:42 AM syzbot
> > wrote:
> >>
> >> Hello,
> >>
> >> syzbot found the following crash on:
> >>
> >> HEAD commit:ef4ab8447aa2 selftests: bpf: install script with_addr.s
On 2018/12/31 16:49, Dmitry Vyukov wrote:
> On Mon, Dec 31, 2018 at 8:42 AM syzbot
> wrote:
>>
>> Hello,
>>
>> syzbot found the following crash on:
>>
>> HEAD commit:ef4ab8447aa2 selftests: bpf: install script with_addr.sh
>> git tree: bpf-next
>> console output: https://syzkaller.appspo
Hello,
syzbot found the following crash on:
HEAD commit:24894bc6eabc Merge branch 'neigh-get-support'
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=13ee4ddb40
kernel config: https://syzkaller.appspot.com/x/.config?x=1f6442435a55ea09
dashboard link: h
Hello,
syzbot found the following crash on:
HEAD commit:38355a5f9a22 bnx2x: Fix NULL pointer dereference in bnx2x_..
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=15fe167740
kernel config: https://syzkaller.appspot.com/x/.config?x=a91d685acb971514
dashboa
Hello,
syzbot found the following crash on:
HEAD commit:90cadbbf341d Merge git://git.kernel.org/pub/scm/linux/kern..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1018bf6740
kernel config: https://syzkaller.appspot.com/x/.config?x=f9a32c9a4aef9af7
da
73 matches
Mail list logo
