[PATCH] Fix mm->owner point to a task that does not exists

2018-12-08 Thread gchen . guomin
From: guominchen Under normal circumstances,When do_exit exits, mm->owner will be updated, but when the kernel process calls unuse_mm and exits, mm->owner cannot be updated. And will point to a task that has been released. Below is my issue on vhost_net: A, B are two kernel process

[PATCH net-next v2] netfilter: ebtables: avoid resetting limit rule state

2018-12-08 Thread Linus Lüssing
So far any changes with ebtables will reset the state of limit rules, leading to spikes in traffic. This is especially noticeable if changes are done frequently, for instance via a daemon. This patch fixes this by bailing out from (re)setting if the limit rule was initialized before. When sending

Re: [PATCH net-next] net: dsa: Restore MTU on master device on unload

2018-12-08 Thread David Miller
From: Andrew Lunn Date: Sat, 8 Dec 2018 17:05:18 +0100 > A previous change tries to set the MTU on the master device to take > into account the DSA overheads. This patch tries to reset the master > device back to the default MTU. > > Signed-off-by: Andrew Lunn Applied.

Re: [PATCH net-next] net: dsa: Make dsa_master_set_mtu() static

2018-12-08 Thread David Miller
From: Andrew Lunn Date: Sat, 8 Dec 2018 17:06:31 +0100 > Add the missing static keyword. > > Signed-off-by: Andrew Lunn Applied.

Re: [PATCH v2 net-next 0/2] platform data controls for mdio-gpio

2018-12-08 Thread David Miller
From: Andrew Lunn Date: Sat, 8 Dec 2018 16:12:11 +0100 > Soon to be mainlined is an x86 platform with a Marvell switch, and a > bit-banging MDIO bus. In order to make this work, the phy_mask of the > MDIO bus needs to be set to prevent scanning for PHYs, and the > phy_ignore_ta_mask needs to be

Re: [PATCH] net/mlx4_core: Correctly set PFC param if global pause is turned off.

2018-12-08 Thread David Miller
From: Tarick Bedeir Date: Fri, 7 Dec 2018 00:30:26 -0800 > rx_ppp and tx_ppp can be set between 0 and 255, so don't clamp to 1. > > Fixes: 6e8814ceb7e8 ("net/mlx4_en: Fix mixed PFC and Global pause user > control requests") > Signed-off-by: Tarick Bedeir Applied and queued up for -stable.

Re: [PATCH] vhost/vsock: fix reset orphans race with close timeout

2018-12-08 Thread David Miller
From: Stefan Hajnoczi Date: Thu, 6 Dec 2018 19:14:34 + > If a local process has closed a connected socket and hasn't received a > RST packet yet, then the socket remains in the table until a timeout > expires. > > When a vhost_vsock instance is released with the timeout still pending, > the

Re: [PATCH bpf-next 1/3] bpf: pass struct btf pointer to the map_check_btf() callback

2018-12-08 Thread Martin Lau
On Fri, Dec 07, 2018 at 04:53:13PM -0800, Roman Gushchin wrote: > If key_type or value_type are of non-trivial data types > (e.g. structure or typedef), it's not possible to check them without > the additional information, which can't be obtained without a pointer > to the btf structure. > > So, l

Re: [PATCH bpf-next 2/3] bpf: add bpffs pretty print for cgroup local storage maps

2018-12-08 Thread Martin Lau
On Fri, Dec 07, 2018 at 04:53:14PM -0800, Roman Gushchin wrote: > Implement bpffs pretty printing for cgroup local storage maps > (both shared and per-cpu). > Output example (captured for tools/testing/selftests/bpf/netcnt_prog.c): > > Shared: > $ cat /sys/fs/bpf/map_2 > # WARNING!! The output

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Eric Dumazet
On 12/08/2018 12:14 PM, Ilias Apalodimas wrote: > On Sat, Dec 08, 2018 at 09:11:53PM +0100, Jesper Dangaard Brouer wrote: >>> >>> I want to make sure you guys thought about splice() stuff, and >>> skb_try_coalesce(), and GRO, and skb cloning, and ... >> >> Thanks for the pointers. To Ilias, we

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Willy Tarreau
On Sat, Dec 08, 2018 at 10:14:47PM +0200, Ilias Apalodimas wrote: > On Sat, Dec 08, 2018 at 09:11:53PM +0100, Jesper Dangaard Brouer wrote: > > > > > > I want to make sure you guys thought about splice() stuff, and > > > skb_try_coalesce(), and GRO, and skb cloning, and ... > > > > Thanks for th

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Andrew Lunn
> That is not how XDP works. XDP must run on the "master" physical driver > interface, as the "slave" interface is a virtual DSA interface. I did > mention DSA because I'm handling that on the EspressoBin implementation. Hi Jesper It is going to be interesting to see how you do that. As a user,

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Jesper Dangaard Brouer
On Sat, 8 Dec 2018 19:43:38 +0100 Björn Töpel wrote: > Den lör 8 dec. 2018 kl 15:52 skrev Jesper Dangaard Brouer : > > > > On Fri, 7 Dec 2018 15:01:55 +0100 > > Björn Töpel wrote: > > > > > Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer > > > : > > > > > > > > On Fri, 7 Dec 2018

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Jesper Dangaard Brouer
On Sat, 8 Dec 2018 17:55:05 +0100 Andrew Lunn wrote: > On Sat, Dec 08, 2018 at 04:12:12PM +0100, Jesper Dangaard Brouer wrote: > > On Fri, 7 Dec 2018 13:21:08 -0800 > > Alexei Starovoitov wrote: > > > > > for production I suspect the users would want > > > an easy way to stay safe when they'r

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Ilias Apalodimas
On Sat, Dec 08, 2018 at 12:21:10PM -0800, David Miller wrote: > From: Ilias Apalodimas > Date: Sat, 8 Dec 2018 16:57:28 +0200 > > > The patchset speeds up the mvneta driver on the default network > > stack. The only change that was needed was to adapt the driver to > > using the page_pool API. Th

Re: [PATCH net-next] ip: silence udp zerocopy smatch false positive

2018-12-08 Thread David Miller
From: Willem de Bruijn Date: Sat, 8 Dec 2018 06:22:46 -0500 > From: Willem de Bruijn > > extra_uref is used in __ip(6)_append_data only if uarg is set. > > Smatch sees that the variable is passed to sock_zerocopy_put_abort. > This function accesses it only when uarg is set, but smatch cannot

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread David Miller
From: Ilias Apalodimas Date: Sat, 8 Dec 2018 16:57:28 +0200 > The patchset speeds up the mvneta driver on the default network > stack. The only change that was needed was to adapt the driver to > using the page_pool API. The speed improvements we are seeing on > specific workloads (i.e 256b < pac

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Ilias Apalodimas
On Sat, Dec 08, 2018 at 09:11:53PM +0100, Jesper Dangaard Brouer wrote: > > > > I want to make sure you guys thought about splice() stuff, and > > skb_try_coalesce(), and GRO, and skb cloning, and ... > > Thanks for the pointers. To Ilias, we need to double check skb_try_coalesce() > code path,

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Jesper Dangaard Brouer
On Sat, 8 Dec 2018 11:26:56 -0800 Eric Dumazet wrote: > On 12/08/2018 06:57 AM, Ilias Apalodimas wrote: > > Hi Eric, > This patch is changing struct sk_buff, and is thus per-definition > controversial. > > Place a new member 'mem_info' of type struct xdp_mem_info, just afte

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread David Miller
From: Jesper Dangaard Brouer Date: Sat, 8 Dec 2018 12:36:10 +0100 > The annoying part is actually that depending on the kernel config > options CONFIG_XFRM, CONFIG_NF_CONNTRACK and CONFIG_BRIDGE_NETFILTER, > whether there is a cache-line split, where mem_info gets moved into the > next cacheline.

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Eric Dumazet
On 12/08/2018 06:57 AM, Ilias Apalodimas wrote: > Hi Eric, This patch is changing struct sk_buff, and is thus per-definition controversial. Place a new member 'mem_info' of type struct xdp_mem_info, just after members (flags) head_frag and pfmemalloc, And not in between

Fw: [Bug 201933] New: r8169 hangs with Oops/null pointer deref on shutdown

2018-12-08 Thread Stephen Hemminger
Begin forwarded message: Date: Sat, 08 Dec 2018 18:20:01 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 201933] New: r8169 hangs with Oops/null pointer deref on shutdown https://bugzilla.kernel.org/show_bug.cgi?id=201933 Bug ID: 20193

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Björn Töpel
Den lör 8 dec. 2018 kl 16:12 skrev Jesper Dangaard Brouer : > > On Fri, 7 Dec 2018 13:21:08 -0800 > Alexei Starovoitov wrote: > > > for production I suspect the users would want > > an easy way to stay safe when they're playing with AF_XDP. > > So another builtin program that redirects ssh and pin

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Björn Töpel
Den lör 8 dec. 2018 kl 15:52 skrev Jesper Dangaard Brouer : > > On Fri, 7 Dec 2018 15:01:55 +0100 > Björn Töpel wrote: > > > Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer > > : > > > > > > On Fri, 7 Dec 2018 12:44:24 +0100 > > > Björn Töpel wrote: > > > > > > > The rationale behind

Re: [PATCH v2 perf,bpf 1/3] perf, bpf: Introduce PERF_RECORD_BPF_EVENT

2018-12-08 Thread kbuild test robot
Hi Song, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/perf/core] [also build test ERROR on v4.20-rc5 next-20181207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/co

Re: [PATCH] wil6210: remove set but not used variable 'wdev'

2018-12-08 Thread merez
On 2018-12-05 09:59, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/wireless/ath/wil6210/main.c: In function '_wil6210_disconnect': drivers/net/wireless/ath/wil6210/main.c:407:23: warning: variable 'wdev' set but not used [-Wunused-but-set-variable] It never use

linux-next: BUG: KASAN: use-after-free in neigh_mark_dead+0x192/0x1c0

2018-12-08 Thread Andrei Vagin
Hi David, Our tests detected a new problem on net-next (v4.20-rc4-1241-g83af01ba1c2d). [ 92.949574] == [ 92.949794] BUG: KASAN: use-after-free in neigh_mark_dead+0x192/0x1c0 [ 92.949950] Write of size 8 at addr 8881d9bc943

Re: [PATCH] net: dsa: ksz: Increase the tag alignment

2018-12-08 Thread Florian Fainelli
Le 12/7/18 à 8:25 PM, Marek Vasut a écrit : > On 12/08/2018 01:52 AM, tristram...@microchip.com wrote: >>> - padlen = (skb->len >= ETH_ZLEN) ? 0 : ETH_ZLEN - skb->len; >>> + padlen = (skb->len >= VLAN_ETH_ZLEN) ? 0 : VLAN_ETH_ZLEN - skb- len; >> >> The requirement is the tail tag should be

Re: [PATCH net-next,v5 11/12] qede: place ethtool_rx_flow_spec after code after TC flower codebase

2018-12-08 Thread Jiri Pirko
Thu, Dec 06, 2018 at 11:40:01PM CET, pa...@netfilter.org wrote: >This is a preparation patch to reuse the existing TC flower codebase >from ethtool_rx_flow_spec. > >This patch is merely moving the core ethtool_rx_flow_spec parser after >tc flower offload driver code so we can skip a few forward fun

Re: [PATCH net-next,v5 10/12] dsa: bcm_sf2: use flow_rule infrastructure

2018-12-08 Thread Jiri Pirko
Thu, Dec 06, 2018 at 11:40:00PM CET, pa...@netfilter.org wrote: >Update this driver to use the flow_rule infrastructure, hence we can use >the same code to populate hardware IR from ethtool_rx_flow and the >cls_flower interfaces. > >Signed-off-by: Pablo Neira Ayuso Acked-by: Jiri Pirko

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Andrew Lunn
> I got other concerns on the patchset though. Like how much memory is > it 'ok' to keep mapped keeping in mind we are using the streaming > DMA API. Are we going to affect anyone else negatively by doing so ? For mvneta, you can expect the target to have between 512Mbyte to 3G. You can take a loo

Re: [PATCH v5 00/13] TCP transport binding for NVMe over Fabrics

2018-12-08 Thread Christoph Hellwig
Thanks, applied to nvme-4.21.

Re: [PATCH v2 net-next 0/2] platform data controls for mdio-gpio

2018-12-08 Thread Florian Fainelli
Le 12/8/18 à 7:12 AM, Andrew Lunn a écrit : > Soon to be mainlined is an x86 platform with a Marvell switch, and a > bit-banging MDIO bus. In order to make this work, the phy_mask of the > MDIO bus needs to be set to prevent scanning for PHYs, and the > phy_ignore_ta_mask needs to be set because th

Re: [PATCH v2 net-next 2/2] net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data

2018-12-08 Thread Florian Fainelli
Le 12/8/18 à 7:12 AM, Andrew Lunn a écrit : > The Marvell 6390 Ethernet switch family does not perform MDIO > turnaround correctly. Many hardware MDIO bus masters don't care about > this, but the bitbangging implementation in Linux does by default. Add > phy_ignore_ta_mask to the platform data so t

Re: [PATCH v2 net-next 1/2] net: phy: mdio-gpio: Add platform_data support for phy_mask

2018-12-08 Thread Florian Fainelli
Le 12/8/18 à 7:12 AM, Andrew Lunn a écrit : > It is sometimes necessary to instantiate a bit-banging MDIO bus as a > platform device, without the aid of device tree. > > When device tree is being used, the bus is not scanned for devices, > only those devices which are in device tree are probed. Wi

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Andrew Lunn
On Sat, Dec 08, 2018 at 04:12:12PM +0100, Jesper Dangaard Brouer wrote: > On Fri, 7 Dec 2018 13:21:08 -0800 > Alexei Starovoitov wrote: > > > for production I suspect the users would want > > an easy way to stay safe when they're playing with AF_XDP. > > So another builtin program that redirects

[PATCH net-next] net: dsa: Make dsa_master_set_mtu() static

2018-12-08 Thread Andrew Lunn
Add the missing static keyword. Signed-off-by: Andrew Lunn --- net/dsa/master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/master.c b/net/dsa/master.c index a25242e71fb2..d7d5145aa235 100644 --- a/net/dsa/master.c +++ b/net/dsa/master.c @@ -158,7 +158,7 @@ static

[PATCH net-next] net: dsa: Restore MTU on master device on unload

2018-12-08 Thread Andrew Lunn
A previous change tries to set the MTU on the master device to take into account the DSA overheads. This patch tries to reset the master device back to the default MTU. Signed-off-by: Andrew Lunn --- net/dsa/master.c | 13 + 1 file changed, 13 insertions(+) diff --git a/net/dsa/mast

[PATCH v2 net-next 0/2] platform data controls for mdio-gpio

2018-12-08 Thread Andrew Lunn
Soon to be mainlined is an x86 platform with a Marvell switch, and a bit-banging MDIO bus. In order to make this work, the phy_mask of the MDIO bus needs to be set to prevent scanning for PHYs, and the phy_ignore_ta_mask needs to be set because the switch has broken turnaround. Add a platform_data

[PATCH v2 net-next 2/2] net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data

2018-12-08 Thread Andrew Lunn
The Marvell 6390 Ethernet switch family does not perform MDIO turnaround correctly. Many hardware MDIO bus masters don't care about this, but the bitbangging implementation in Linux does by default. Add phy_ignore_ta_mask to the platform data so that the bitbangging code can be told which devices a

[PATCH v2 net-next 1/2] net: phy: mdio-gpio: Add platform_data support for phy_mask

2018-12-08 Thread Andrew Lunn
It is sometimes necessary to instantiate a bit-banging MDIO bus as a platform device, without the aid of device tree. When device tree is being used, the bus is not scanned for devices, only those devices which are in device tree are probed. Without device tree, by default, all addresses on the bu

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Jesper Dangaard Brouer
On Fri, 7 Dec 2018 13:21:08 -0800 Alexei Starovoitov wrote: > for production I suspect the users would want > an easy way to stay safe when they're playing with AF_XDP. > So another builtin program that redirects ssh and ping traffic > back to the kernel would be a nice addition. Are you saying

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Ilias Apalodimas
Hi Eric, > >> This patch is changing struct sk_buff, and is thus per-definition > >> controversial. > >> > >> Place a new member 'mem_info' of type struct xdp_mem_info, just after > >> members (flags) head_frag and pfmemalloc, And not in between > >> headers_start/end to ensure skb_copy() and pskb

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Jesper Dangaard Brouer
On Fri, 7 Dec 2018 15:01:55 +0100 Björn Töpel wrote: > Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer : > > > > On Fri, 7 Dec 2018 12:44:24 +0100 > > Björn Töpel wrote: > > > > > The rationale behind attach is performance and ease of use. Many XDP > > > socket users just need a sim

Re: [RFC 3/3] virtio_ring: use new vring flags

2018-12-08 Thread Tiwei Bie
On Fri, Dec 07, 2018 at 01:10:48PM -0500, Michael S. Tsirkin wrote: > On Fri, Dec 07, 2018 at 04:48:42PM +0800, Tiwei Bie wrote: > > Switch to using the _SPLIT_ and _PACKED_ variants of vring flags > > in split ring and packed ring respectively. > > > > Signed-off-by: Tiwei Bie > > --- > > @@ -50

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Jesper Dangaard Brouer
On Sat, 8 Dec 2018 04:29:17 -0800 Eric Dumazet wrote: > On 12/08/2018 01:57 AM, Florian Westphal wrote: > > Jesper Dangaard Brouer wrote: > >> From: Ilias Apalodimas > >> > >> This patch is changing struct sk_buff, and is thus per-definition > >> controversial. > >> > >> Place a new member 'm

Re: [RFC 2/3] virtio_ring: add VIRTIO_RING_NO_LEGACY

2018-12-08 Thread Tiwei Bie
On Fri, Dec 07, 2018 at 01:05:35PM -0500, Michael S. Tsirkin wrote: > On Fri, Dec 07, 2018 at 04:48:41PM +0800, Tiwei Bie wrote: > > Introduce VIRTIO_RING_NO_LEGACY to support disabling legacy > > macros and layout definitions. > > > > Suggested-by: Michael S. Tsirkin > > Signed-off-by: Tiwei Bie

Re: [RFC 0/3] virtio_ring: define flags as shifts consistently

2018-12-08 Thread Tiwei Bie
On Fri, Dec 07, 2018 at 01:11:42PM -0500, Michael S. Tsirkin wrote: > On Fri, Dec 07, 2018 at 04:48:39PM +0800, Tiwei Bie wrote: > > This is a follow up of the discussion in this thread: > > https://patchwork.ozlabs.org/patch/1001015/#2042353 > > How was this tested? I'd suggest building virtio >

Re: [PATCH net-next,v5 09/12] ethtool: add ethtool_rx_flow_spec to flow_rule structure translator

2018-12-08 Thread Jiri Pirko
Thu, Dec 06, 2018 at 11:39:59PM CET, pa...@netfilter.org wrote: >This patch adds a function to translate the ethtool_rx_flow_spec >structure to the flow_rule representation. > >This allows us to reuse code from the driver side given that both flower >and ethtool_rx_flow interfaces use the same repr

Re: [PATCH net-next,v5 08/12] flow_offload: add wake-up-on-lan and queue to flow_action

2018-12-08 Thread Jiri Pirko
Thu, Dec 06, 2018 at 11:39:58PM CET, pa...@netfilter.org wrote: >These actions need to be added to support the ethtool_rx_flow interface. >The queue action includes a field to specify the RSS context, that is >set via FLOW_RSS flow type flag and the rss_context field in struct >ethtool_rxnfc, plus

Re: [PATCH net-next,v5 06/12] drivers: net: use flow action infrastructure

2018-12-08 Thread Jiri Pirko
Thu, Dec 06, 2018 at 11:39:56PM CET, pa...@netfilter.org wrote: >This patch updates drivers to use the new flow action infrastructure. > >Signed-off-by: Pablo Neira Ayuso Acked-by: Jiri Pirko

Re: [PATCH net-next,v5 07/12] cls_flower: don't expose TC actions to drivers anymore

2018-12-08 Thread Jiri Pirko
Thu, Dec 06, 2018 at 11:39:57PM CET, pa...@netfilter.org wrote: >Now that drivers have been converted to use the flow action >infrastructure, remove this field from the tc_cls_flower_offload >structure. > >Signed-off-by: Pablo Neira Ayuso Acked-by: Jiri Pirko

Re: [PATCH net-next,v5 05/12] flow_offload: add statistics retrieval infrastructure and use it

2018-12-08 Thread Jiri Pirko
Thu, Dec 06, 2018 at 11:39:55PM CET, pa...@netfilter.org wrote: >This patch provides the flow_stats structure that acts as container for >tc_cls_flower_offload, then we can use to restore the statistics on the >existing TC actions. Hence, tcf_exts_stats_update() is not used from >drivers anymore. >

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Eric Dumazet
On 12/08/2018 04:29 AM, Eric Dumazet wrote: > > But I do not get why the patch is needed. > > Adding extra cost for each skb destruction is costly. > > I though XDP was all about _not_ having skbs. > > Please let's do not slow down the non XDP stack only to make XDP more > appealing. > I

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Eric Dumazet
On 12/08/2018 01:57 AM, Florian Westphal wrote: > Jesper Dangaard Brouer wrote: >> From: Ilias Apalodimas >> >> This patch is changing struct sk_buff, and is thus per-definition >> controversial. >> >> Place a new member 'mem_info' of type struct xdp_mem_info, just after >> members (flags) hea

Re: [PATCH 5/5] net: dsa: ksz: Add Microchip KSZ8795 DSA driver

2018-12-08 Thread Andrew Lunn
> +static int ksz8795_valid_dyn_entry(struct ksz_device *dev, u8 *data) > +{ > + int timeout = 100; > + > + do { > + ksz_read8(dev, REG_IND_DATA_CHECK, data); > + timeout--; > + } while ((*data & DYNAMIC_MAC_TABLE_NOT_READY) && timeout); readx_poll_timeout()? >

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Jesper Dangaard Brouer
On Sat, 8 Dec 2018 10:57:58 +0100 Florian Westphal wrote: > Jesper Dangaard Brouer wrote: > > From: Ilias Apalodimas > > > > This patch is changing struct sk_buff, and is thus per-definition > > controversial. > > > > Place a new member 'mem_info' of type struct xdp_mem_info, just after > > m

Re: [PATCH 3/5] net: dsa: ksz: Factor out common tag code

2018-12-08 Thread Andrew Lunn
On Fri, Dec 07, 2018 at 07:18:43PM +0100, Marek Vasut wrote: > From: Tristram Ha > > Factor out common code from the tag_ksz , so that the code can be used > with other KSZ family switches which use differenly sized tags. I prefer this implementation over what Tristram recently submitted. It is

[PATCH net-next] ip: silence udp zerocopy smatch false positive

2018-12-08 Thread Willem de Bruijn
From: Willem de Bruijn extra_uref is used in __ip(6)_append_data only if uarg is set. Smatch sees that the variable is passed to sock_zerocopy_put_abort. This function accesses it only when uarg is set, but smatch cannot infer this. Make this dependency explicit. Fixes: 52900d22288e ("udp: eli

Re: [PATCH 1/5] net: dsa: ksz: Add MIB counter reading support

2018-12-08 Thread Andrew Lunn
> +static void ksz9477_phy_setup(struct ksz_device *dev, int port, > + struct phy_device *phy) > +{ > + if (port < dev->phy_port_cnt) { > + /* SUPPORTED_Asym_Pause and SUPPORTED_Pause can be removed to > + * disable flow control when rate limit

Re: [PATCH V2] net: dsa: ksz: Add reset GPIO handling

2018-12-08 Thread Andrew Lunn
> This actually is an individual patch, it doesn't depend on anything. > Or do you mean a series with the DT documentation change ? Yes, i mean together with the DT documentation change. Those two belong together, they are one functional change. Part of this is also to do with scalability. It tak

Re: [PATCH] net: dsa: ksz: Fix port membership

2018-12-08 Thread Andrew Lunn
On Sat, Dec 08, 2018 at 05:23:25AM +0100, Marek Vasut wrote: > On 12/08/2018 01:13 AM, tristram...@microchip.com wrote: > >> Do you have a git tree with all the KSZ patches based on -next > >> somewhere, so I don't have to look for them in random MLs ? > > > > I just sent it this Monday and the su

RE: [PATCH bpf-next 7/7] samples: bpf: add support for XDP_ATTACH to xdpsock

2018-12-08 Thread Zhang, Qi Z
Hi: Seems there are only 6 patches of the patch set in patchwork https://patchwork.ozlabs.org/project/netdev/list/?submitter=70569 https://patchwork.ozlabs.org/project/netdev/list/?series=80389 Anyone can help to check why patch 7/7 is missing? Thanks Qi > -Original Message- > From: Bj

Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-08 Thread Florian Westphal
Jesper Dangaard Brouer wrote: > From: Ilias Apalodimas > > This patch is changing struct sk_buff, and is thus per-definition > controversial. > > Place a new member 'mem_info' of type struct xdp_mem_info, just after > members (flags) head_frag and pfmemalloc, And not in between > headers_start/

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-08 Thread Björn Töpel
Den fre 7 dec. 2018 kl 22:21 skrev Alexei Starovoitov : > > On Fri, Dec 07, 2018 at 12:44:24PM +0100, Björn Töpel wrote: > > From: Björn Töpel > > > > Hi! > > > > This patch set adds support for a new XDP socket bind option, > > XDP_ATTACH. > > > > The rationale behind attach is performance and ea

Re: [PATCH net-next,v5 04/12] cls_api: add translator to flow_action representation

2018-12-08 Thread Jiri Pirko
Thu, Dec 06, 2018 at 11:39:54PM CET, pa...@netfilter.org wrote: >This patch implements a new function to translate from native TC action >to the new flow_action representation. Moreover, this patch also updates >cls_flower to use this new function. > >Signed-off-by: Pablo Neira Ayuso Acked-by: Ji

Re: [PATCH net-next,v5 03/12] flow_offload: add flow action infrastructure

2018-12-08 Thread Jiri Pirko
Thu, Dec 06, 2018 at 11:39:53PM CET, pa...@netfilter.org wrote: >This new infrastructure defines the nic actions that you can perform >from existing network drivers. This infrastructure allows us to avoid a >direct dependency with the native software TC action representation. > >Signed-off-by: Pabl

Re: [PATCH net-next,v5 02/12] net/mlx5e: support for two independent packet edit actions

2018-12-08 Thread Jiri Pirko
Thu, Dec 06, 2018 at 11:39:52PM CET, pa...@netfilter.org wrote: >This patch adds pedit_headers_action structure to store the result of >parsing tc pedit actions. Then, it calls alloc_tc_pedit_action() to >populate the mlx5e hardware intermediate representation once all actions >have been parsed. >

Re: [PATCH] net/mlx4_core: Correctly set PFC param if global pause is turned off.

2018-12-08 Thread Eran Ben Elisha
On 12/7/2018 10:30 AM, Tarick Bedeir wrote: > rx_ppp and tx_ppp can be set between 0 and 255, so don't clamp to 1. > > Fixes: 6e8814ceb7e8 ("net/mlx4_en: Fix mixed PFC and Global pause user > control requests") > Signed-off-by: Tarick Bedeir > --- > drivers/net/ethernet/mellanox/mlx4/en_etht

Re: [PATCH net-next,v5 01/12] flow_offload: add flow_rule and flow_match structures and use them

2018-12-08 Thread Jiri Pirko
Thu, Dec 06, 2018 at 11:39:51PM CET, pa...@netfilter.org wrote: >This patch wraps the dissector key and mask - that flower uses to >represent the matching side - around the flow_match structure. > >To avoid a follow up patch that would edit the same LoCs in the drivers, >this patch also wraps this