On 12/08/2018 12:14 PM, Ilias Apalodimas wrote: > On Sat, Dec 08, 2018 at 09:11:53PM +0100, Jesper Dangaard Brouer wrote: >>> >>> I want to make sure you guys thought about splice() stuff, and >>> skb_try_coalesce(), and GRO, and skb cloning, and ... >> >> Thanks for the pointers. To Ilias, we need to double check skb_try_coalesce() >> code path, as it does look like we don't handle this correctly. >> > > Noted. We did check skb cloning, but not this one indeed There is also TCP RX zero copy to consider ( tcp_zerocopy_receive() ) but more generally all paths that can grab pages from skbs.
- Re: [net-next, RFC, 4/8] net: core: add re... Eric Dumazet
- Re: [net-next, RFC, 4/8] net: core: ad... Eric Dumazet
- Re: [net-next, RFC, 4/8] net: core: ad... Jesper Dangaard Brouer
- Re: [net-next, RFC, 4/8] net: core: ad... Ilias Apalodimas
- Re: [net-next, RFC, 4/8] net: core... Andrew Lunn
- Re: [net-next, RFC, 4/8] net: core... Eric Dumazet
- Re: [net-next, RFC, 4/8] net:... Jesper Dangaard Brouer
- Re: [net-next, RFC, 4/8] ... Ilias Apalodimas
- Re: [net-next, RFC, 4/8] ... Willy Tarreau
- Re: [net-next, RFC, 4/8] ... Ilias Apalodimas
- Re: [net-next, RFC, 4/8] ... Eric Dumazet
- Re: [net-next, RFC, 4/8] net: core... David Miller
- Re: [net-next, RFC, 4/8] net:... Ilias Apalodimas
- Re: [net-next, RFC, 4/8] net:... Saeed Mahameed
- [net-next PATCH RFC 7/8] xdp: bpf: cpumap redirect ... Jesper Dangaard Brouer
- [net-next PATCH RFC 2/8] net: mvneta: use page pool... Jesper Dangaard Brouer
- [net-next PATCH RFC 1/8] page_pool: add helper func... Jesper Dangaard Brouer
- Re: [net-next PATCH RFC 1/8] page_pool: add he... David Miller
- Re: [net-next PATCH RFC 1/8] page_pool: ad... Ilias Apalodimas
- [net-next PATCH RFC 6/8] mvneta: activate page recy... Jesper Dangaard Brouer
- [net-next PATCH RFC 5/8] net: mvneta: remove copybr... Jesper Dangaard Brouer