Hi Claudiu,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Claudiu-Manoil/Introduce-ENETC-ethernet-drivers/20181124-111823
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian
Commit 838e96904ff3 ("bpf: Introduce bpf_func_info")
added bpf func info support. The userspace is able
to get better ksym's for bpf programs with jit, and
is able to print out func prototypes.
For a program containing func-to-func calls, the existing
implementation returns user specified number o
Commit 838e96904ff3 ("bpf: Introduce bpf_func_info")
added bpf func info support. The userspace is able
to get better ksym's for bpf programs with jit, and
is able to print out func prototypes.
For a program containing func-to-func calls, the existing
implementation returns user specified number o
The selftest test_btf is changed to test both jit and non-jit.
The test result should be the same regardless of whether jit
is enabled or not.
Signed-off-by: Yonghong Song
---
tools/testing/selftests/bpf/test_btf.c | 33 +++---
1 file changed, 3 insertions(+), 30 deletions(-)
A couple of comments I missed:
> > > > /*
> > > > * called from sock_recv_timestamp() if sock_flag(sk, SOCK_RCVTSTAMP)
> > > > * or sock_flag(sk, SOCK_RCVTSTAMPNS)
> > > > @@ -719,19 +751,8 @@ void __sock_recv_timestamp(struct msghdr *msg,
> > > > struct sock *sk,
> > > > fal
> > > + if (type == SO_TIMESTAMP_NEW || type == SO_TIMESTAMPNS_NEW)
> > > + sock_set_flag(sk, SOCK_TSTAMP_NEW);
> > > + else
> > > + sock_reset_flag(sk, SOCK_TSTAMP_NEW);
> > > +
> >
> > if adding a boolean whether the socket uses new or old-style
> > timesta
> > + new_tstamp = sock_flag(sk, SOCK_TSTAMP_NEW);
> > + if (new_tstamp)
>
> nit: no need for explicit variable
Sure, will drop it.
-Deepa
On Sat, Nov 24, 2018 at 7:59 PM Willem de Bruijn
wrote:
>
> On Sat, Nov 24, 2018 at 3:59 AM Deepa Dinamani wrote:
> >
> > SOCK_RCVTSTAMPNS is never set alone. SOCK_RCVTSTAMP
> > is always set along with SOCK_RCVTSTAMPNS. This leads to
> > checking for two flag states whenever we need to check for
On Sat, Nov 24, 2018 at 11:38 AM Willem de Bruijn
wrote:
>
> On Sat, Nov 24, 2018 at 4:00 AM Deepa Dinamani wrote:
> >
> > The new type is meant to be used as a y2038 safe structure
> > to be used as part of cmsg data.
> > Presently the SO_TIMESTAMP socket option uses struct timeval
> > for times
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: 25 November 2018 07:02
To: Kalluru, Sudarsana
Cc: netdev@vger.kernel.org; Elior, Ariel ; Kalderon,
Michal
Subject: Re: [PATCH net-next v2 0/4] qed* enhancements series
External Email
From: Sudarsana Reddy Kallu
On Sat, Nov 24, 2018 at 10:59 PM Willem de Bruijn
wrote:
>
> On Sat, Nov 24, 2018 at 3:58 AM Deepa Dinamani wrote:
> >
> > Add SO_TIMESTAMP_NEW and SO_TIMESTAMPNS_NEW variants of
> > socket timestamp options.
> > These are the y2038 safe versions of the SO_TIMESTAMP_OLD
> > and SO_TIMESTAMPNS_OLD
On Sat, Nov 24, 2018 at 3:58 AM Deepa Dinamani wrote:
>
> Add SO_TIMESTAMPING_NEW variant of socket timestamp options.
> This is the y2038 safe versions of the SO_TIMESTAMPING_OLD
> for all architectures.
>
> Signed-off-by: Deepa Dinamani
> Cc: ch...@zankel.net
> Cc: fenghua...@intel.com
> Cc: r.
On Sat, Nov 24, 2018 at 3:58 AM Deepa Dinamani wrote:
>
> Add SO_TIMESTAMP_NEW and SO_TIMESTAMPNS_NEW variants of
> socket timestamp options.
> These are the y2038 safe versions of the SO_TIMESTAMP_OLD
> and SO_TIMESTAMPNS_OLD for all architectures.
>
> Note that the format of scm_timestamping.ts[
On Sat, Nov 24, 2018 at 3:58 AM Deepa Dinamani wrote:
>
> SO_TIMESTAMP, SO_TIMESTAMPNS and SO_TIMESTAMPING options, the
> way they are currently defined, are not y2038 safe.
> Subsequent patches in the series add new y2038 safe versions
> of these options which provide 64 bit timestamps on all
> a
On Sat, Nov 24, 2018 at 3:59 AM Deepa Dinamani wrote:
>
> SOCK_RCVTSTAMPNS is never set alone. SOCK_RCVTSTAMP
> is always set along with SOCK_RCVTSTAMPNS. This leads to
> checking for two flag states whenever we need to check for
> SOCK_RCVTSTAMPS.
>
> Also SOCK_RCVTSTAMPS was the only flag that n
From: Willem de Bruijn
Date: Sat, 24 Nov 2018 21:09:26 -0500
> From: Willem de Bruijn
>
> Packet sockets with PACKET_TX_RING send skbs with user data in frags.
>
> Before commit 5cd8d46ea156 ("packet: copy user buffers before orphan
> or clone") ring slots could be released prematurely, possib
On Sat, Nov 24, 2018 at 8:58 PM David Miller wrote:
>
> From: Willem de Bruijn
> Date: Sat, 24 Nov 2018 14:24:30 -0500
>
> > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
> > index c09219e7f230..2d1e4b67a1e8 100644
> > --- a/net/ipv4/ip_output.c
> > +++ b/net/ipv4/ip_output.c
> > @@ -8
From: Willem de Bruijn
Packet sockets with PACKET_TX_RING send skbs with user data in frags.
Before commit 5cd8d46ea156 ("packet: copy user buffers before orphan
or clone") ring slots could be released prematurely, possibly allowing
a process to overwrite data still in flight.
This test opens t
From: Willem de Bruijn
Date: Sat, 24 Nov 2018 14:37:42 -0500
> On Sat, Nov 24, 2018 at 4:00 AM Deepa Dinamani wrote:
>> diff --git a/include/uapi/linux/time.h b/include/uapi/linux/time.h
>> index 04d5587f30d3..106f9398c285 100644
>> --- a/include/uapi/linux/time.h
>> +++ b/include/uapi/linux/tim
From: Nikolay Aleksandrov
Date: Sat, 24 Nov 2018 14:21:07 +0200
> I was contacted recently about this privately and this was my reply:
> "Checking new_nbp() and del_nbp() it should not be possible to reach that code
> with p->dev or p->br as NULL. The cap check code has always been there, I just
From: Willem de Bruijn
Date: Sat, 24 Nov 2018 14:24:29 -0500
> From: Willem de Bruijn
>
> Enable MSG_ZEROCOPY for udp sockets
>
> Patch 1/2 is the main patch, a rebase from RFC patch
> http://patchwork.ozlabs.org/patch/899630/
> more details in the patch commit message
>
> Patch 2/2 runs
From: Willem de Bruijn
Date: Sat, 24 Nov 2018 14:24:30 -0500
> diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
> index c09219e7f230..2d1e4b67a1e8 100644
> --- a/net/ipv4/ip_output.c
> +++ b/net/ipv4/ip_output.c
> @@ -868,6 +868,7 @@ static int __ip_append_data(struct sock *sk,
> {
>
From: Heiner Kallweit
Date: Sun, 25 Nov 2018 00:14:58 +0100
> Make use of xmit_more and add the functionality introduced with
> 3e59020abf0f ("net: bql: add __netdev_tx_sent_queue()").
> I used the mlx4 driver as template.
>
> Signed-off-by: Heiner Kallweit
Series looks great, but please fix t
On Sat, Nov 24, 2018 at 09:44:36PM +, Al Viro wrote:
> No point, IMO - the fix isn't hard and bisect hazard created by the whole
> thing
> is both mild (spurious WARN() in case that used to fail anyway) _and_ won't
> disappear from reverting, obviously. I'll post a fix later tonight...
FWIW
On Sat, Nov 24, 2018 at 8:43 PM David Miller wrote:
>
> From: Willem de Bruijn
> Date: Sat, 24 Nov 2018 14:21:16 -0500
>
> > From: Willem de Bruijn
> >
> > In ip packet generation, pagedlen is initialized for each skb at the
> > start of the loop in __ip(6)_append_data, before label alloc_new_sk
Signed-off-by: Eric Dumazet
---
man/man8/tc-fq.8 | 37 ++---
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/man/man8/tc-fq.8 b/man/man8/tc-fq.8
index
f058a05a531716093d5b3d7d6f2fe4d41577078d..1febe62bb3a6cc1e47b9116881d22986dfa16806
100644
--- a/
From: Willem de Bruijn
Date: Sat, 24 Nov 2018 14:21:16 -0500
> From: Willem de Bruijn
>
> In ip packet generation, pagedlen is initialized for each skb at the
> start of the loop in __ip(6)_append_data, before label alloc_new_skb.
>
> Depending on compiler options, code can be generated that j
From: Eric Dumazet
Date: Sat, 24 Nov 2018 09:12:24 -0800
> When a qdisc setup including pacing FQ is dismantled and recreated,
> some TCP packets are sent earlier than instructed by TCP stack.
>
> TCP can be fooled when ACK comes back, because the following
> operation can return a negative valu
From: Colin King
Date: Sat, 24 Nov 2018 15:03:02 +
> From: Colin Ian King
>
> Currently dev is dereferenced by the call dev_net(dev) before dev is null
> checked. Fix this by null checking dev before the potential null
> pointer dereference.
>
> Detected by CoverityScan, CID#1462955 ("Der
From: YueHaibing
Date: Sat, 24 Nov 2018 18:36:21 +0800
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:5883:6:
> warning: variable 'multitrc' set but not used [-Wunused-but-set-variable]
>
> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:8585:32:
>
On 11/24/18 6:25 PM, David Miller wrote:
> From: David Ahern
> Date: Sat, 24 Nov 2018 17:12:48 -0700
>
>> IPX was moved to staging at the end of last year. Can decnet follow
>> suit? git log seems to indicate no active development in a very long time.
>
> Last time I tried to do that someone imm
From: Alexey Dobriyan
Date: Sat, 24 Nov 2018 12:01:41 +0300
> Return code should be formally "netdev_tx_t".
>
> Signed-off-by: Alexey Dobriyan
Applied to net-next.
From: Sudarsana Reddy Kalluru
Date: Fri, 23 Nov 2018 23:42:29 -0800
> v2: Use __set_bit()/__clear_bit() where data access doesn't need to be
> atomic.
Wait.
How does this interact with the clear_bit_unlock() used by the qede PTP code?
You can't really mix atomic and non-atomic accesses to e
From: David Ahern
Date: Sat, 24 Nov 2018 17:12:48 -0700
> IPX was moved to staging at the end of last year. Can decnet follow
> suit? git log seems to indicate no active development in a very long time.
Last time I tried to do that someone immediately said on the list
"Don't, we're using that!"
IPX was moved to staging at the end of last year. Can decnet follow
suit? git log seems to indicate no active development in a very long time.
David
Similar to netdev_sent_queue add helper __netdev_sent_queue as variant
of __netdev_tx_sent_queue.
Signed-off-by: Heiner Kallweit
---
include/linux/netdevice.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 1dcc0628b..a417fa
Make use of xmit_more and add the functionality introduced with
3e59020abf0f ("net: bql: add __netdev_tx_sent_queue()").
I used the mlx4 driver as template.
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/realtek/r8169.c | 19 +--
1 file changed, 9 insertions(+), 10 delet
This series adds helper __netdev_sent_queue to the core and makes use
of it in the r8169 driver.
Heiner Kallweit (2):
net: core: add __netdev_sent_queue as variant of __netdev_tx_sent_queue
r8169: make use of xmit_more and __netdev_sent_queue
drivers/net/ethernet/realtek/r8169.c | 19 +++
I ended up tracking down some rather nasty issues with f2fs (and other
filesystem modules) constantly crashing on my kernel down to a
combination of out of bounds memory accesses, one of which was coming
from brcmfmac during module load:
[ 30.891382] brcmfmac: brcmf_fw_alloc_request: using brcm/
On Fri, Nov 23, 2018 at 11:25:11PM +0100, Daniel Borkmann wrote:
> On 11/22/2018 03:09 PM, Lorenz Bauer wrote:
> > Add a new function, which encourages safe usage of the test interface.
> > bpf_prog_test_run continues to work as before, but should be considered
> > unsafe.
> >
> > Signed-off-by: L
On 11/21/18 3:11 PM, Alexei Starovoitov wrote:
> On Wed, Nov 21, 2018 at 11:55:02AM -0800, Song Liu wrote:
>> This patch enables perf-record to listen to bpf_event and generate
>> bpf_prog_info_event for bpf programs loaded and unloaded during
>> perf-record run.
>>
>> To minimize latency between b
On 11/23/18 9:56 AM, Ioana Ciocoi Radulescu wrote:
> @@ -215,6 +255,7 @@ static void dpaa2_eth_rx(struct dpaa2_eth_priv *priv,
> struct dpaa2_fas *fas;
> void *buf_data;
> u32 status = 0;
> + u32 xdp_act;
>
> /* Tracing point */
> trace_dpaa2_rx_fd(priv->net_dev,
On Sat, Nov 24, 2018 at 11:20:14PM +0200, Slavomir Kaslev wrote:
> On Sat, Nov 24, 2018 at 08:03:57PM +, Al Viro wrote:
> > On Sat, Nov 24, 2018 at 11:40:03AM -0800, syzbot wrote:
> > > Hello,
> > >
> > > syzbot found the following crash on:
> > >
> > > HEAD commit:edeca3a769ad Merge tag
On Sat, Nov 24, 2018 at 08:03:57PM +, Al Viro wrote:
> On Sat, Nov 24, 2018 at 11:40:03AM -0800, syzbot wrote:
> > Hello,
> >
> > syzbot found the following crash on:
> >
> > HEAD commit:edeca3a769ad Merge tag 'sound-4.20-rc4' of git://git.kerne..
> > git tree: upstream
> > console
Add the two 1000BaseLX enum values to the X550's check for 1Gbps modules,
allowing the core driver code to establish a link over this SFP type.
This is done by the out-of-tree driver but the fix wasn't in mainline.
Fixes: 6a14ee0cfb19 ("ixgbe: Add X550 support function pointers")
Signed-off-by: J
On Freitag, 23. November 2018 17:13:51 CET Sven Eckelmann wrote:
> + /** @BATADV_GW_MODE_CLIENT: announce itself as gatway server */
> + BATADV_GW_MODE_SERVER,
The kernel-doc should actually be for BATADV_GW_MODE_SERVER.
[...]
> + if (sel_class < 1 || sel_class > sel_cla
On Sat, Nov 24, 2018 at 11:40:03AM -0800, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:edeca3a769ad Merge tag 'sound-4.20-rc4' of git://git.kerne..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=12bee26d40
> kernel
Hello,
syzbot found the following crash on:
HEAD commit:edeca3a769ad Merge tag 'sound-4.20-rc4' of git://git.kerne..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12bee26d40
kernel config: https://syzkaller.appspot.com/x/.config?x=73e2bc0cb6463446
da
On Sat, Nov 24, 2018 at 4:00 AM Deepa Dinamani wrote:
>
> The new type is meant to be used as a y2038 safe structure
> to be used as part of cmsg data.
> Presently the SO_TIMESTAMP socket option uses struct timeval
> for timestamps. This is not y2038 safe.
> Subsequent patches in the series add ne
From: Willem de Bruijn
Enable MSG_ZEROCOPY for udp sockets
Patch 1/2 is the main patch, a rebase from RFC patch
http://patchwork.ozlabs.org/patch/899630/
more details in the patch commit message
Patch 2/2 runs the already existing udp zerocopy tests
as part of kselftest
See also recent L
From: Willem de Bruijn
Extend zerocopy to udp sockets. Allow setting sockopt SO_ZEROCOPY and
interpret flag MSG_ZEROCOPY.
This patch was previously part of the zerocopy RFC patchsets. Zerocopy
is not effective at small MTU. With segmentation offload building
larger datagrams, the benefit of page
From: Willem de Bruijn
Both msg_zerocopy and udpgso_bench have udp zerocopy variants.
Exercise these as part of the standard kselftest run.
With udp, msg_zerocopy has no control channel. Ensure that the
receiver exits after the sender by accounting for the initial
delay in starting them (in msg_
From: Willem de Bruijn
In ip packet generation, pagedlen is initialized for each skb at the
start of the loop in __ip(6)_append_data, before label alloc_new_skb.
Depending on compiler options, code can be generated that jumps to
this label, triggering use of an an uninitialized variable.
In pra
Hi.
On 12.11.2018 03:01, Steven Rostedt wrote:
On Sun, 11 Nov 2018 21:16:00 +0100
Oleksandr Natalenko wrote:
Oh, I see that write_msg() calls netpoll_send_udp() under
spin_lock_irqsave(), but in PREEMPT_RT this, AFAIK, does not disable
interrupts.
So, the real question here is whether the int
The pull request you sent on Fri, 23 Nov 2018 22:58:55 -0800 (PST):
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/857fa628bbe93017c72ddd0d5304962a2608db07
Thank you!
--
Deet-doot-dot, I am a bot.
On Freitag, 23. November 2018 17:13:56 CET Sven Eckelmann wrote:
> + if (info->attrs[BATADV_ATTR_ORIG_INTERVAL]) {
> + u32 orig_interval;
> +
> + attr = info->attrs[BATADV_ATTR_ISOLATION_MASK];
This should have been BATADV_ATTR_ORIG_INTERVAL
Kind regards,
On Sat, Nov 24, 2018 at 2:11 AM syzbot
wrote:
>
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:92b419289cee Merge tag 'riscv-for-linus-4.20-rc4' of git:/..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=1224309340
> kernel config:
When a qdisc setup including pacing FQ is dismantled and recreated,
some TCP packets are sent earlier than instructed by TCP stack.
TCP can be fooled when ACK comes back, because the following
operation can return a negative value.
tcp_time_stamp(tp) - tp->rx_opt.rcv_tsecr;
Some paths in TCP
On 24 November 2018 18:25:41 EET, Andrew Lunn wrote:
>On Sat, Nov 24, 2018 at 06:18:33PM +0200, niko...@cumulusnetworks.com
>wrote:
>> On 24 November 2018 18:10:41 EET, Andrew Lunn wrote:
>> >> +int br_boolopt_toggle(struct net_bridge *br, enum br_boolopt_id
>opt,
>> >bool on,
>> >> +
On Sat, Nov 24, 2018 at 04:34:21AM +0200, Nikolay Aleksandrov wrote:
> Use the new boolopt API to add an option which disables learning from
> link-local packets. The default is kept as before and learning is
> enabled. This is a simple map from a boolopt bit to a bridge private
> flag that is test
On Sat, Nov 24, 2018 at 04:34:22AM +0200, Nikolay Aleksandrov wrote:
> Now that we have at least one bool option, we can export all of the
> supported bool options via optmask when dumping them.
>
> v2: new patch
>
> Signed-off-by: Nikolay Aleksandrov
Reviewed-by: Andrew Lunn
Andrew
On Sat, Nov 24, 2018 at 06:18:33PM +0200, niko...@cumulusnetworks.com wrote:
> On 24 November 2018 18:10:41 EET, Andrew Lunn wrote:
> >> +int br_boolopt_toggle(struct net_bridge *br, enum br_boolopt_id opt,
> >bool on,
> >> +struct netlink_ext_ack *extack)
> >> +{
> >> + switch (o
On 24 November 2018 18:16:47 EET, Andrew Lunn wrote:
>On Sat, Nov 24, 2018 at 04:34:22AM +0200, Nikolay Aleksandrov wrote:
>> Now that we have at least one bool option, we can export all of the
>> supported bool options via optmask when dumping them.
>>
>Hi Nik
>
>That answers my question then...
On 24 November 2018 18:10:41 EET, Andrew Lunn wrote:
>> +int br_boolopt_toggle(struct net_bridge *br, enum br_boolopt_id opt,
>bool on,
>> + struct netlink_ext_ack *extack)
>> +{
>> +switch (opt) {
>> +default:
>> +/* shouldn't be called with unsupported option
On Sat, Nov 24, 2018 at 04:34:22AM +0200, Nikolay Aleksandrov wrote:
> Now that we have at least one bool option, we can export all of the
> supported bool options via optmask when dumping them.
>
Hi Nik
That answers my question then...
I'm assuming this means there is no easy way to generate a
> +int br_boolopt_toggle(struct net_bridge *br, enum br_boolopt_id opt, bool on,
> + struct netlink_ext_ack *extack)
> +{
> + switch (opt) {
> + default:
> + /* shouldn't be called with unsupported options */
> + WARN_ON(1);
> + break;
On 11/22/18 3:22 PM, Nicolas Dichtel wrote:
> Like the previous patch, the goal is to ease to convert nsids from one
> netns to another netns.
> A new attribute (NETNSA_CURRENT_NSID) is added to the kernel answer when
> NETNSA_TARGET_NSID is provided, thus the user can easily convert nsids.
>
> Si
Hi Claudiu,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Claudiu-Manoil/Introduce-ENETC-ethernet-drivers/20181124-111823
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC
On 11/23/18 11:37 PM, Eric Dumazet wrote:
> Kernel commit 48872c11b772 ("net_sched: sch_fq: add dctcp-like marking")
> added support for TCA_FQ_CE_THRESHOLD attribute.
>
> This patch adds iproute2 support for it.
>
> It also makes sure fq_print_xstats() can deal with smaller tc_fq_qd_stats
> stru
On 11/19/18 4:03 PM, Jakub Kicinski wrote:
> Hi!
>
> This set brings GRED support up to date with recent kernel changes.
> In particular the new netlink attributes for more fine-grained stats
> and per-virtual queue flags.
>
> To make GRED usable in modern deployments the patch set starts with
>
From: Colin Ian King
Currently dev is dereferenced by the call dev_net(dev) before dev is null
checked. Fix this by null checking dev before the potential null
pointer dereference.
Detected by CoverityScan, CID#1462955 ("Dereference before null check")
Fixes: 23790ef12082 ("net: qualcomm: rmne
Hi
DEBENHAMS RETAIL PLC is a retailer shop furnished by European products. We
are looking to buy ( Fashion items, Perfumes, Lighters, Tiles
Marbles,Wooden Floors, Smart-phones, Tablets, Laptops, TVs, Air
conditioner etc...)and find a new partnership with companies dealing with
different produc
On 23-11-18, 15:24, Anshuman Khandual wrote:
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -386,7 +386,8 @@ EXPORT_SYMBOL(dma_issue_pending_all);
> static bool dma_chan_is_local(struct dma_chan *chan, int cpu)
> {
> int node = dev_to_node(chan->device->dev);
> -
On 24/11/2018 14:15, Colin King wrote:
> From: Colin Ian King
>
> A recent change added a null check on p->dev after p->dev was being
> dereferenced by the ns_capable check on p->dev. Fix this by performing
> the p->dev sanity check before it is dereferenced.
>
> Detected by CoverityScan, CID#7
From: Colin Ian King
A recent change added a null check on p->dev after p->dev was being
dereferenced by the ns_capable check on p->dev. Fix this by performing
the p->dev sanity check before it is dereferenced.
Detected by CoverityScan, CID#751490 ("Dereference before null check")
Fixes: a5f3e
On 11/24/2018 05:14 AM, Andrew Morton wrote:
> On Fri, 23 Nov 2018 15:24:16 +0530 Anshuman Khandual
> wrote:
>
>> At present there are multiple places where invalid node number is encoded
>> as -1. Even though implicitly understood it is always better to have macros
>> in there. Replace these
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:5883:6:
warning: variable 'multitrc' set but not used [-Wunused-but-set-variable]
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:8585:32:
warning: variable 'speed' set but not used [-Wunused-but-set-variable]
Sat, Nov 24, 2018 at 10:44:18AM CET, s...@narfation.org wrote:
>On Samstag, 24. November 2018 10:29:55 CET Jiri Pirko wrote:
>[...]
>> This looks great. Nice job!
>>
>> Do you have a userspace app to communicate with this? Would be nice to
>> play with it or at least to see examples of usage.
>
>I
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c:260:7:
warning: variable 'err' set but not used [-Wunused-but-set-variable]
'err' should be returned while set MPI_DEINIT state fails
in hw_atl_utils_soft_reset.
Fixes: cce96d1883da ("net
On Samstag, 24. November 2018 10:29:55 CET Jiri Pirko wrote:
[...]
> This looks great. Nice job!
>
> Do you have a userspace app to communicate with this? Would be nice to
> play with it or at least to see examples of usage.
I have only published the the mcast parsing portion [1] because the
app
Fri, Nov 23, 2018 at 05:13:40PM CET, s...@narfation.org wrote:
>Hi,
>
>Jiri Pirko called the batman-adv configuration interface a while back "a
>huge mistake" [1] and suggested genl as alternative. The first
>reimplementation [2] (based on the team/devlink design) was rejected. This
>second impleme
Return code should be formally "netdev_tx_t".
Signed-off-by: Alexey Dobriyan
---
include/linux/netdevice.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -4373,7 +4373,7 @@ static inline netdev_tx_t netdev_start_xmit(
> From: Lorenzo Bianconi
> Date: Fri, 23 Nov 2018 18:28:01 +0100
>
> > Reset snd_queue tso_hdrs pointer to NULL in nicvf_free_snd_queue routine
> > since it is used to check if tso dma descriptor queue has been previously
> > allocated. The issue can be triggered with the following reproducer:
> >
On Tue, 2018-11-20 at 19:14 -0800, Cody Schuffelen wrote:
>
> +config VIRT_WIFI
> + bool "Wifi wrapper for ethernet drivers"
The built bot complaint is most likely because of this being bool rather
than tristate (CFG80211=m, VIRT_WIFI=y, I guess, didn't check), I
thought this was because of t
84 matches
Mail list logo
