-----Original Message----- From: David Miller [mailto:da...@davemloft.net] Sent: 25 November 2018 07:02 To: Kalluru, Sudarsana <sudarsana.kall...@cavium.com> Cc: netdev@vger.kernel.org; Elior, Ariel <ariel.el...@cavium.com>; Kalderon, Michal <michal.kalde...@cavium.com> Subject: Re: [PATCH net-next v2 0/4] qed* enhancements series
External Email From: Sudarsana Reddy Kalluru <sudarsana.kall...@cavium.com> Date: Fri, 23 Nov 2018 23:42:29 -0800 > v2: Use __set_bit()/__clear_bit() where data access doesn't need to be > atomic. Wait. How does this interact with the clear_bit_unlock() used by the qede PTP code? You can't really mix atomic and non-atomic accesses to edev->flags . Hi Dave, I missed this point, thanks a lot for your help/info. Will revert it to use set/clear_bit() respectively and, send the V3 version of the series. Thanks, Sudarsana