Wed, Oct 24, 2018 at 05:32:49PM CEST, dsah...@kernel.org wrote:
>From: David Ahern
>
>Marco reported an error with hfsc:
>root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
>Error: Attribute failed policy validation.
>
>Apparently a few implementations pass TCA_OPTIONS as a bina
On Thu, Oct 25, 2018 at 7:02 AM Wei Yongjun wrote:
>
> The function nix_update_mce_list() is called from
> nix_update_bcast_mce_list(), and a spin lock is held
> here, so we should use GFP_ATOMIC instead.
>
> Fixes: 4b05528ebf0c ("octeontx2-af: Update bcast list upon NIXLF alloc/free")
> Signed-of
The function nix_update_mce_list() is called from
nix_update_bcast_mce_list(), and a spin lock is held
here, so we should use GFP_ATOMIC instead.
Fixes: 4b05528ebf0c ("octeontx2-af: Update bcast list upon NIXLF alloc/free")
Signed-off-by: Wei Yongjun
---
drivers/net/ethernet/marvell/octeontx2/af
On Wed, Oct 24, 2018 at 3:08 PM Daniel Borkmann wrote:
>
> On 10/24/2018 11:42 PM, Song Liu wrote:
> > On Wed, Oct 24, 2018 at 1:06 PM Daniel Borkmann
> > wrote:
> >>
> >> Given this seems to be quite fragile and can easily slip through the
> >> cracks, lets make direct packet write more robust
From: Jeff Kirsher
Date: Wed, 24 Oct 2018 14:47:24 -0700
> This series contains fixes for the ice driver.
>
> Anirudh fixes a namespace issue which was introduced with a previous
> patch to remove ice_netpoll. Fixed up the device ID define names to
> align with the branding string names. Use t
On 10/24/18 3:05 PM, Daniel Borkmann wrote:
Commit f1a2e44a3aec ("bpf: add queue and stack maps") probably just
copy-pasted .pkt_access for bpf_map_{pop,peek}_elem() helpers, but
this is buggy in this context since it would allow writes into cloned
skbs which is invalid. Therefore, disable .pkt
On 10/24/18 3:05 PM, Daniel Borkmann wrote:
Commit f1a2e44a3aec ("bpf: add queue and stack maps") added helpers
with ARG_PTR_TO_UNINIT_MAP_VALUE. Meaning, the helper is supposed to
fill the map value buffer with data instead of reading from it like
in other helpers such as map update. However, gi
On 10/24/2018 11:42 PM, Song Liu wrote:
> On Wed, Oct 24, 2018 at 1:06 PM Daniel Borkmann wrote:
>>
>> Given this seems to be quite fragile and can easily slip through the
>> cracks, lets make direct packet write more robust by requiring that
>> future program types which allow for such write must
From: Tristram Ha
Socket buffer is not re-created when headroom is 2 and tailroom is 1.
Signed-off-by: Tristram Ha
---
drivers/net/ethernet/cadence/macb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c
b/drivers/net/ethernet/c
On 24.10.2018 23:22, David Miller wrote:
> From: Shawn Lin
> Date: Wed, 24 Oct 2018 09:46:47 +0800
>
>> It's found my r8169 ethernet card at hand has a device ID
>> of 0x which wasn't on the list of rtl8169_pci_tbl. Add
>> a new entry to make it work:
>>
>> [2.165785] r8169 Gigabit Ethernet d
From: Anirudh Venkataramanan
The firmware now returns the capability count in the command buffer.
Use it.
Signed-off-by: Anirudh Venkataramanan
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ice/ice_common.c | 4 +---
1 file changed, 1 insertion(+), 3 del
From: Anirudh Venkataramanan
Basically remove references to C810 and use E810C (from the branding
string) instead.
Signed-off-by: Anirudh Venkataramanan
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ice/ice_devids.h | 6 +++---
drivers/net/ethernet/intel
On Wed, Oct 24, 2018 at 1:08 PM Daniel Borkmann wrote:
>
> Several fixes to get direct packet access in order from verifier
> side. Also test suite fix to run cg_skb as unpriv and an improvement
> to make direct packet write less error prone in future.
>
> Thanks!
>
> Daniel Borkmann (7):
> bpf:
From: Anirudh Venkataramanan
Allocate VF interrupts using VPINT_ALLOC_PCI. Multiple interrupts are
specified as a range from "first" to "last".
Also, according to the spec, the queue mapping for a VF needs to be set
in both contig and scatter queue modes. So make this change as well.
Signed-off
From: Anirudh Venkataramanan
Update to the current firmware major and minor version which are
1 and 3 respectively.
Also remove an empty comment line.
Signed-off-by: Anirudh Venkataramanan
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ice/ice_controlq.h
From: Anirudh Venkataramanan
ice_dev_onetime_setup contains a couple of driver workarounds for current
firmware limitations. These workarounds are expected to go away once
these limitations are fixed in the firmware.
On a firmware release that has these issues addressed, these workarounds
(while
From: Anirudh Venkataramanan
When the physical link goes up or down, the driver is supposed to
receive a link status event (LSE). The driver currently has the code
to handle LSEs but there is no firmware support for this feature yet.
So this patch adds the ability for the driver to poll for link
From: Anirudh Venkataramanan
commit 158a08a694c4e ("ice: remove ndo_poll_controller") removed
ice_netpoll and introduced a namespace warning for ice_msix_clean_rings.
Fix the namespace warning by making ice_msix_clean_rings static.
Signed-off-by: Anirudh Venkataramanan
Tested-by: Andrew Bowers
This series contains fixes for the ice driver.
Anirudh fixes a namespace issue which was introduced with a previous
patch to remove ice_netpoll. Fixed up the device ID define names to
align with the branding string names. Use the capability count returned
by the firmware, instead of calculating
On Wed, Oct 24, 2018 at 1:06 PM Daniel Borkmann wrote:
>
> Given this seems to be quite fragile and can easily slip through the
> cracks, lets make direct packet write more robust by requiring that
> future program types which allow for such write must provide a prologue
> callback. In case of XDP
From: David Ahern
Date: Wed, 24 Oct 2018 13:58:39 -0700
> From: David Ahern
>
> The intent of ip6_route_check_nh_onlink is to make sure the gateway
> given for an onlink route is not actually on a connected route for
> a different interface (e.g., 2001:db8:1::/64 is on dev eth1 and then
> an on
From: David Ahern
Date: Wed, 24 Oct 2018 08:32:49 -0700
> From: David Ahern
>
> Marco reported an error with hfsc:
> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
> Error: Attribute failed policy validation.
>
> Apparently a few implementations pass TCA_OPTIONS as a bin
From: Dan Carpenter
Date: Wed, 24 Oct 2018 11:32:21 +0300
> This is a copy and paste bug where we copied the sizeof() from the chunk
> before. We're copying more data than intended but the destination is a
> union so it doesn't cause memory corruption.
>
> Fixes: ffb0abd7e9cb ("octeontx2-af: NI
On Tue, Oct 23, 2018 at 09:28:03AM +0200, Paolo Abeni wrote:
> Hi,
>
> On Mon, 2018-10-22 at 21:49 -0700, Alexei Starovoitov wrote:
> > On Mon, May 15, 2017 at 11:01:42AM +0200, Paolo Abeni wrote:
> > > And update __sk_queue_drop_skb() to work on the specified queue.
> > > This will help the udp p
From: Shawn Lin
Date: Wed, 24 Oct 2018 09:46:47 +0800
> It's found my r8169 ethernet card at hand has a device ID
> of 0x which wasn't on the list of rtl8169_pci_tbl. Add
> a new entry to make it work:
>
> [2.165785] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
> [2.165863] r8169 :01:
From: Sean Tranchetti
Date: Tue, 23 Oct 2018 16:04:31 -0600
> Current handling of CHECKSUM_COMPLETE packets by the UDP stack is
> incorrect for any packet that has an incorrect checksum value.
>
> udp4/6_csum_init() will both make a call to
> __skb_checksum_validate_complete() to initialize/vali
From: David Ahern
Date: Wed, 24 Oct 2018 12:58:58 -0700
> Li RongQing noted that tgt_net is leaked in ipv4 due to the recent change
> to handle address dumps for a specific device. The report also applies to
> ipv6 and other error paths. Patches 1 and 2 fix those leaks.
>
> Patch 3 stops route d
From: Holger Hoffstätte
Date: Wed, 24 Oct 2018 21:36:02 +0200
Adding Heiner to CC:
> Since 4.19 r8169 depends on phylib:
>
> $lsmod | grep r8169
> r8169 81920 0
> libphy 57344 2 r8169,realtek
>
> Unfortunately this now gives me the following sysfs error:
>
>
From: David Ahern
The intent of ip6_route_check_nh_onlink is to make sure the gateway
given for an onlink route is not actually on a connected route for
a different interface (e.g., 2001:db8:1::/64 is on dev eth1 and then
an onlink route has a via 2001:db8:1::1 dev eth2). If the gateway
lookup hi
On Wed, Oct 24, 2018 at 09:36:02PM +0200, Holger Hoffstätte wrote:
> Hi,
>
> Since 4.19 r8169 depends on phylib:
>
> $lsmod | grep r8169
> r8169 81920 0
> libphy 57344 2 r8169,realtek
>
> Unfortunately this now gives me the following sysfs error:
>
> $cd /sys/
Given BPF_PROG_TYPE_CGROUP_SKB program types are also valid in an
unprivileged setting, lets not omit these tests and potentially
have issues fall through the cracks. Make this more obvious by
adding a small test_as_unpriv() helper.
Signed-off-by: Daniel Borkmann
Acked-by: Alexei Starovoitov
---
Commit f1a2e44a3aec ("bpf: add queue and stack maps") probably just
copy-pasted .pkt_access for bpf_map_{pop,peek}_elem() helpers, but
this is buggy in this context since it would allow writes into cloned
skbs which is invalid. Therefore, disable .pkt_access for the two.
Fixes: f1a2e44a3aec ("bpf:
Commit b39b5f411dcf ("bpf: add cg_skb_is_valid_access for
BPF_PROG_TYPE_CGROUP_SKB") added direct packet access for skbs in
cg_skb program types, however allowed access type was not added to
the may_access_direct_pkt_data() helper. Therefore the latter always
returns false. This is not directly an
Commit f1a2e44a3aec ("bpf: add queue and stack maps") added helpers
with ARG_PTR_TO_UNINIT_MAP_VALUE. Meaning, the helper is supposed to
fill the map value buffer with data instead of reading from it like
in other helpers such as map update. However, given the buffer is
allowed to be uninitialized
Given this seems to be quite fragile and can easily slip through the
cracks, lets make direct packet write more robust by requiring that
future program types which allow for such write must provide a prologue
callback. In case of XDP and sk_msg it's noop, thus add a generic noop
handler there. The
Commit d58e468b1112 ("flow_dissector: implements flow dissector BPF
hook") added direct packet access for skbs in may_access_direct_pkt_data()
function where this enables read and write access to the skb->data. This
is buggy because without a prologue generator such as bpf_unclone_prologue()
we wou
Commit b39b5f411dcf ("bpf: add cg_skb_is_valid_access for
BPF_PROG_TYPE_CGROUP_SKB") added support for returning pkt pointers
for direct packet access. Given this program type is allowed for both
unprivileged and privileged users, we shouldn't allow unprivileged
ones to use it, e.g. besides others
Several fixes to get direct packet access in order from verifier
side. Also test suite fix to run cg_skb as unpriv and an improvement
to make direct packet write less error prone in future.
Thanks!
Daniel Borkmann (7):
bpf: fix test suite to enable all unpriv program types
bpf: disallow direc
From: David Ahern
If an address, route or netconf dump request is sent for AF_UNSPEC, then
rtnl_dump_all is used to do the dump across all address families. If one
of the dumpit functions fails (e.g., invalid attributes in the dump
request) then rtnl_dump_all needs to propagate that error so the
From: David Ahern
When doing a route dump across all address families, do not error out
if the table does not exist. This allows a route dump for AF_UNSPEC
with a table id that may only exist for some of the families.
Do return the table does not exist error if dumping routes for a
specific fami
From: David Ahern
If tgt_net is set based on IFA_TARGET_NETNSID attribute in the dump
request, make sure all error paths call put_net.
Fixes: 6371a71f3a3b ("net/ipv6: Add support for dumping addresses for a
specific device")
Fixes: ed6eff11790a ("net/ipv6: Update inet6_dump_addr for strict data
From: David Ahern
Li RongQing noted that tgt_net is leaked in ipv4 due to the recent change
to handle address dumps for a specific device. The report also applies to
ipv6 and other error paths. Patches 1 and 2 fix those leaks.
Patch 3 stops route dumps from erroring out when dumping across addre
From: David Ahern
If tgt_net is set based on IFA_TARGET_NETNSID attribute in the dump
request, make sure all error paths call put_net.
Fixes: 5fcd266a9f64 ("net/ipv4: Add support for dumping addresses for a
specific device")
Fixes: c33078e3dfb1 ("net/ipv4: Update inet_dump_ifaddr for strict dat
On 21.10.2018 15:34, Andre Tomt wrote:
On 20.10.2018 00:25, Eric Dumazet wrote:
On 10/19/2018 02:58 PM, Eric Dumazet wrote:
On 10/16/2018 06:00 AM, Eric Dumazet wrote:
On Mon, Oct 15, 2018 at 11:30 PM Andre Tomt wrote:
I've seen similar on several systems with mlx4 cards when using
4.18.x -
Hi,
Since 4.19 r8169 depends on phylib:
$lsmod | grep r8169
r8169 81920 0
libphy 57344 2 r8169,realtek
Unfortunately this now gives me the following sysfs error:
$cd /sys/module/realtek/drivers
$ls -l
ls: cannot access 'mdio_bus:RTL8201F 10/100Mbps Ethernet':
On Wed, Oct 24, 2018 at 4:16 AM Taehee Yoo wrote:
>
> The dev_map_notification() removes interface in devmap if
> unregistering interface's ifindex is same.
> But only checking ifindex is not enough because other netns can have
> same ifindex. so that wrong interface selection could occurred.
> He
On Wed, 24 Oct 2018 14:29:34 +0800
Shawn Lin wrote:
> On 2018/10/24 13:54, David Miller wrote:
> > From: Shawn Lin
> > Date: Wed, 24 Oct 2018 13:48:55 +0800
> >
> >> Hi David,
> >>
> >> On 2018/10/24 10:19, David Miller wrote:
> >>> From: Shawn Lin
> >>> Date: Wed, 24 Oct 2018 09:46:47 +08
From: David Ahern
Marco reported an error with hfsc:
root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
Error: Attribute failed policy validation.
Apparently a few implementations pass TCA_OPTIONS as a binary instead
of nested attribute, so drop TCA_OPTIONS from the policy.
F
On 10/24/18 9:02 AM, David Ahern wrote:
> On 10/24/18 3:36 AM, Li RongQing wrote:
>> put net when input a invalid ifindex, otherwise it will be leaked
>>
>> Fixes: 5fcd266a9f64("net/ipv4: Add support for dumping addresses for a
>> specific device")
>> Cc: David Ahern
>> Signed-off-by: Zhang Yu
>
On 10/24/18 3:36 AM, Li RongQing wrote:
> put net when input a invalid ifindex, otherwise it will be leaked
>
> Fixes: 5fcd266a9f64("net/ipv4: Add support for dumping addresses for a
> specific device")
> Cc: David Ahern
> Signed-off-by: Zhang Yu
> Signed-off-by: Li RongQing
> ---
> net/ipv4/
On 10/24/18 7:07 AM, Florian Westphal wrote:
> Marco Berizzi wrote:
>
> [ CC David ]
>
>> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
>> Error: Attribute failed policy validation.
>
> caused by:
> commit 8b4c3cdd9dd8290343ce959a132d3b334062c5b9
> net: sched: Add policy
Hi All,
As per the device tree ePappr
https://elinux.org/images/c/cf/Power_ePAPR_APPROVED_v1.1.pdf
section 2.2.1
Each node in the device tree is named according to the following convention:
node-name@unit-address
The node-name shall start with a lower or uppercase character and should
describ
Marco Berizzi wrote:
[ CC David ]
> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
> Error: Attribute failed policy validation.
caused by:
commit 8b4c3cdd9dd8290343ce959a132d3b334062c5b9
net: sched: Add policy validation for tc attributes
Looks like TCA_OPTIONS is NLA_BI
Not sure if this was picked up when I originally posted it, or if this
feedback is useful but:
I noticed some rtl8169 driver changes in 4.18.15, pulled that from git
last friday and rolled it and did some bandwith intensive rsync tests
etc that would provoke the problem quite reliably before,
Commit a61bbcf28a8c ("[NET]: Store skb->timestamp as offset to a base
timestamp") introduces a neighbour control buffer and zeroes it out in
ndisc_rcv(), as ndisc_recv_ns() uses it.
Commit f2776ff04722 ("[IPV6]: Fix address/interface handling in UDP and
DCCP, according to the scoping architecture.
> Since 719655a14971 ("net: phy: Replace phy driver features u32
> with link_mode bitmap"), phy_probe() calls
> ethtool_convert_link_mode_to_legacy_u32() with phydrv->features
> as argument. Since features are NULL, we will get NULL pointer
> dereference.
Hi Jose
Thanks for pointing that out. I w
I am Mr Marc Joseph Hebert a I work in the Finance Risk control/Accounts Broker
Unit of a prestigious bank in London. Under varying state laws in United
Kingdom, financial institutions and other companies are required to turn over
any funds considered "abandoned," including uncashed paychecks
On 10/18/2018 20:15, Jakub Kicinski wrote:
On Wed, 17 Oct 2018 15:23:14 -0700, Jeff Kirsher wrote:
+/**
+ * igc_ioctl - I/O control method
+ * @netdev: network interface device structure
+ * @ifreq: frequency
Is it? :)
Ah... Good catch. I will fix that and submit patch.
+ * @cmd: command
+
The dev_map_notification() removes interface in devmap if
unregistering interface's ifindex is same.
But only checking ifindex is not enough because other netns can have
same ifindex. so that wrong interface selection could occurred.
Hence netdev pointer comparison code is added.
v2: compare netde
On Mon 2018-10-22 19:26:07, tristram...@microchip.com wrote:
> From: Tristram Ha
>
> Initialize mutex before use.
>
> Signed-off-by: Tristram Ha
> ---
> drivers/net/dsa/microchip/ksz_common.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/microchi
On Mon 2018-10-22 19:26:05, tristram...@microchip.com wrote:
> From: Tristram Ha
>
> Replace license with GPL.
>
> Signed-off-by: Tristram Ha
> Reviewed-by: Woojung Huh
> Reviewed-by: Andrew Lunn
Acked-by: Pavel Machek
> @@ -1,19 +1,20 @@
> /*
> * Microchip KSZ9477 register definitions
Hi Daniel!
On Wed, 24 Oct 2018 at 18:07, Daniel Borkmann wrote:
>
> [ +John ]
>
> On 10/22/2018 05:41 PM, Taehee Yoo wrote:
> > The dev_map_notification() removes interface in devmap if
> > unregistering interface's ifindex is same.
> > But only checking ifindex is not enough because other netns
On Tue, Oct 23, 2018 at 02:22:12PM +0200, Paolo Abeni wrote:
> On Tue, 2018-10-23 at 14:10 +0200, Steffen Klassert wrote:
>
> > Some quick benchmark numbers with UDP packet forwarding
> > (1460 byte packets) through two gateways:
> >
> > net-next: 16.4 Gbps
> >
> > net-next + UDP GRO: 20.3 Gbps
On 10/19/2018 21:16, Colin King wrote:
From: Colin Ian King
The call to netif_set_real_num_tx_queues is not assigning the error
return to variable err even though the next line checks err for an
error. Fix this by adding the missing err assignment.
Detected by CoverityScan, CID#1474551 ("Logi
On 10/19/2018 15:40, YueHaibing wrote:
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/intel/igc/igc_base.c: In function
'igc_init_phy_params_base':
drivers/net/ethernet/intel/igc/igc_base.c:240:6: warning:
variable 'ctrl_ext' set but not used [-Wunused-but-set-variable]
Hi Folks,
I'm getting this message after the upgrade from linux 4.18
to 4.19
root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
Error: Attribute failed policy validation.
root@Calimero:~# lsmod | grep hfsc
sch_hfsc 24576 0
root@Calimero:~# tc -V
tc utility,
On 10/19/2018 15:48, YueHaibing wrote:
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/intel/igc/igc_main.c: In function 'igc_probe':
drivers/net/ethernet/intel/igc/igc_main.c:3535:11: warning:
variable 'pci_using_dac' set but not used [-Wunused-but-set-variable]
It never
put net when input a invalid ifindex, otherwise it will be leaked
Fixes: 5fcd266a9f64("net/ipv4: Add support for dumping addresses for a specific
device")
Cc: David Ahern
Signed-off-by: Zhang Yu
Signed-off-by: Li RongQing
---
net/ipv4/devinet.c | 4 +++-
1 file changed, 3 insertions(+), 1 del
[ +John ]
On 10/22/2018 05:41 PM, Taehee Yoo wrote:
> The dev_map_notification() removes interface in devmap if
> unregistering interface's ifindex is same.
> But only checking ifindex is not enough because other netns can have
> same ifindex. so that wrong interface selection could occurred.
> He
On 10/18/2018 20:14, Jakub Kicinski wrote:
On Wed, 17 Oct 2018 15:23:12 -0700, Jeff Kirsher wrote:
From: Sasha Neftin
This patch adds the beginning framework onto which I am going to add
the igc driver which supports the Intel(R) I225-LM/I225-V 2.5G
Ethernet Controller.
Signed-off-by: Sasha N
This is a copy and paste bug where we copied the sizeof() from the chunk
before. We're copying more data than intended but the destination is a
union so it doesn't cause memory corruption.
Fixes: ffb0abd7e9cb ("octeontx2-af: NIX AQ instruction enqueue support")
Signed-off-by: Dan Carpenter
---
On 23-10-2018 11:58, Russell King - ARM Linux wrote:
> On Tue, Oct 23, 2018 at 11:28:09AM +0100, Jose Abreu wrote:
>> On 23-10-2018 11:20, Russell King - ARM Linux wrote:
>>> I have no idea what you're proposing there - your patches weren't copied
>>> to me.
>> They just set / unset MDIO_CTRL1_
72 matches
Mail list logo
