Re: [PATCH] net/mlx5: allocate enough space in

2018-10-21 Thread Dan Carpenter
On Mon, Oct 22, 2018 at 09:18:43AM +0300, Or Gerlitz wrote: > On Mon, Oct 22, 2018 at 8:23 AM Dan Carpenter > wrote: > > > > On Sun, Oct 21, 2018 at 01:56:26PM +0300, Or Gerlitz wrote: > > > I will re-post your patch, this time to netdev since the original > > > commit is there > > > and so shoul

Re: [PATCH] net/mlx5: Allocate enough space for the FDB sub-namespaces

2018-10-21 Thread Or Gerlitz
On Sun, Oct 21, 2018 at 2:47 PM Or Gerlitz wrote: > > From: Dan Carpenter > > FDB_MAX_CHAIN is three. We wanted to allocate enough memory to hold four > structs but there are missing parentheses so we only allocate enough > memory for three structs and the first byte of the fourth one. > > Fixes

Re: [PATCH] net/mlx5: allocate enough space in

2018-10-21 Thread Or Gerlitz
On Mon, Oct 22, 2018 at 8:23 AM Dan Carpenter wrote: > > On Sun, Oct 21, 2018 at 01:56:26PM +0300, Or Gerlitz wrote: > > I will re-post your patch, this time to netdev since the original > > commit is there > > and so should be the fix, thanks for reporting/fixing! > > I didn't realize it had been

Re: [PATCH] net/mlx5: allocate enough space in

2018-10-21 Thread Dan Carpenter
On Sun, Oct 21, 2018 at 01:56:26PM +0300, Or Gerlitz wrote: > I will re-post your patch, this time to netdev since the original > commit is there > and so should be the fix, thanks for reporting/fixing! I didn't realize it had been posted to netdev already so I deliberately left that off the CC.

Re: [rtnetlink] Potential bug in Linux (rt)netlink code

2018-10-21 Thread Henning Rogge
Does anyone else have an idea how to debug this problem? Henning Rogge Am 15.10.2018 um 07:25 schrieb Henning Rogge: Am 12.10.2018 um 20:51 schrieb Stephen Hemminger: On Fri, 12 Oct 2018 09:30:40 +0200 Henning Rogge wrote: Hi, I am working on a self-written routing agent (https://github.co

RE: [PATCH v2 1/2] dt-bindings: net: add MDIO bus multiplexer driven by a regmap device

2018-10-21 Thread Pankaj Bansal
> -Original Message- > From: Pankaj Bansal > Sent: Thursday, October 18, 2018 10:00 AM > To: Florian Fainelli ; Andrew Lunn > Cc: netdev@vger.kernel.org > Subject: RE: [PATCH v2 1/2] dt-bindings: net: add MDIO bus multiplexer driven > by > a regmap device > > Hi Florian > > > -Orig

Re: pull-request: bpf-next 2018-10-21

2018-10-21 Thread David Miller
From: Daniel Borkmann Date: Sun, 21 Oct 2018 21:24:26 +0200 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git Pulled, than

RE: [PATCH] net: ethernet:fec: Consistently use SPEED_ prefix

2018-10-21 Thread Andy Duan
From: netdev-ow...@vger.kernel.org > All other calls to phy_set_max_speed() use the SPEED_ prefix. Make the > FEC driver follow this common pattern. This makes no different to > generated code since SPEED_1000 is 1000, and SPEED_100 is 100. > Please also add more information that was introduced

Re: [PATCH net] r8169: fix NAPI handling under high load

2018-10-21 Thread Jonathan Woithe
On Fri, 19 Oct 2018 17:59:21 +1030, Jonathan Woithe wrote: > On 10/18/18 08:15, Jonathan Woithe wrote: > > On Thu, Oct 18, 2018 at 08:03:32AM +0200, Heiner Kallweit wrote: > > > Proposed fix is here: > > > https://patchwork.ozlabs.org/patch/985014/ > > > Would be good if you could test it. Thanks!

Re: [PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-10-21 Thread Jesper Dangaard Brouer
On Sun, 21 Oct 2018 16:37:08 +0100 Quentin Monnet wrote: > 2018-10-21 11:57 UTC+0200 ~ Jesper Dangaard Brouer > > On Sat, 20 Oct 2018 23:00:24 +0100 > > Quentin Monnet wrote: > > > > [...] > > >> --- a/tools/testing/selftests/bpf/test_libbpf.sh > >> +++ b/tools/testing/selftests/bpf/test_l

Re: [RFC PATCH v2 10/10] selftests: add functionals test for UDP GRO

2018-10-21 Thread Willem de Bruijn
On Fri, Oct 19, 2018 at 10:31 AM Paolo Abeni wrote: > > Extends the existing udp programs to allow checking for proper > GRO aggregation/GSO size, and run the tests via a shell script, using > a veth pair with XDP program attached to trigger the GRO code path. > > Signed-off-by: Paolo Abeni > ---

Re: [RFC PATCH v2 08/10] selftests: conditionally enable XDP support in udpgso_bench_rx

2018-10-21 Thread Willem de Bruijn
On Fri, Oct 19, 2018 at 10:31 AM Paolo Abeni wrote: > > XDP support will be used by a later patch to test the GRO path > in a net namespace, leveraging the veth XDP implementation. > To avoid breaking existing setup, XDP support is conditionally > enabled and build only if llc is locally available

Re: [RFC PATCH v2 07/10] selftests: add GRO support to udp bench rx program

2018-10-21 Thread Willem de Bruijn
On Fri, Oct 19, 2018 at 10:31 AM Paolo Abeni wrote: > > And fix a couple of buglets (port option processing, > clean termination on SIGINT). This is preparatory work > for GRO tests. > > Signed-off-by: Paolo Abeni > --- > tools/testing/selftests/net/udpgso_bench_rx.c | 37 +++ >

Re: [RFC PATCH v2 06/10] udp: cope with UDP GRO packet misdirection

2018-10-21 Thread Willem de Bruijn
On Fri, Oct 19, 2018 at 10:31 AM Paolo Abeni wrote: > > In some scenarios, the GRO engine can assemble an UDP GRO packet > that ultimately lands on a non GRO-enabled socket. > This patch tries to address the issue explicitly checking for the UDP > socket features before enqueuing the packet, and e

Re: [RFC PATCH v2 03/10] udp: add support for UDP_GRO cmsg

2018-10-21 Thread Willem de Bruijn
On Fri, Oct 19, 2018 at 10:30 AM Paolo Abeni wrote: > > When UDP GRO is enabled, the UDP_GRO cmsg will carry the ingress > datagram size. User-space can use such info to compute the original > packets layout. > > Signed-off-by: Paolo Abeni > --- > CHECK: should we use a separate setsockopt to exp

Re: [RFC PATCH v2 02/10] udp: implement GRO for plain UDP sockets.

2018-10-21 Thread Willem de Bruijn
On Fri, Oct 19, 2018 at 10:30 AM Paolo Abeni wrote: > > This is the RX counterpart of commit bec1f6f69736 ("udp: generate gso > with UDP_SEGMENT"). When UDP_GRO is enabled, such socket is also > eligible for GRO in the rx path: UDP segments directed to such socket > are assembled into a larger GSO

Re: [RFC PATCH v2 00/10] udp: implement GRO support

2018-10-21 Thread Willem de Bruijn
On Fri, Oct 19, 2018 at 10:30 AM Paolo Abeni wrote: > > This series implements GRO support for UDP sockets, as the RX counterpart > of commit bec1f6f69736 ("udp: generate gso with UDP_SEGMENT"). > The core functionality is implemented by the second patch, introducing a new > sockopt to enable UDP_

bpf-next is CLOSED

2018-10-21 Thread Daniel Borkmann
Given the merge window is opening shortly, please only submit bug fixes to bpf tree at this time, thank you!

pull-request: bpf-next 2018-10-21

2018-10-21 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Implement two new kind of BPF maps, that is, queue and stack map along with new peek, push and pop operations, from Mauricio. 2) Add support for MSG_PEEK flag when redirecting into an

Re: [PATCH iproute2-next 3/3] rdma: Add an option to rename IB device interface

2018-10-21 Thread David Ahern
On 10/18/18 5:51 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > Enrich rdmatool with an option to rename IB devices, > the command interface follows Iproute2 convention: > "rdma dev set [OLD-DEVNAME] name NEW-DEVNAME" > > Signed-off-by: Leon Romanovsky > --- > rdma/dev.c | 35 +

Re: [PATCHv2 iproute2-next] ip/geneve: fix ttl inherit behavior

2018-10-21 Thread David Ahern
On 10/18/18 1:01 AM, Hangbin Liu wrote: > Currently when we add geneve with "ttl inherit", we only set ttl to 0, which > is actually use whatever default value instead of inherit the inner protocol's > ttl value. > > To make a difference with ttl inherit and ttl == 0, we add an attribute > IFLA_GE

Re: [PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-10-21 Thread Quentin Monnet
2018-10-21 11:57 UTC+0200 ~ Jesper Dangaard Brouer > On Sat, 20 Oct 2018 23:00:24 +0100 > Quentin Monnet wrote: > [...] >> --- a/tools/testing/selftests/bpf/test_libbpf.sh >> +++ b/tools/testing/selftests/bpf/test_libbpf.sh >> @@ -33,17 +33,11 @@ trap exit_handler 0 2 3 6 9 >> >> libbpf_o

[PATCH V1 net-next] net: ena: fix compilation error in xtensa architecture

2018-10-21 Thread akiyano
From: Arthur Kiyanovski linux/prefetch.h is never explicitly included in ena_com, although functions from it, such as prefetchw(), are used throughout ena_com. This is an inclusion bug, and we fix it here by explicitly including linux/prefetch.h. The bug was exposed when the driver was compiled f

Re: Fw: [Bug 201423] New: eth0: hw csum failure

2018-10-21 Thread Andre Tomt
On 20.10.2018 00:25, Eric Dumazet wrote: On 10/19/2018 02:58 PM, Eric Dumazet wrote: On 10/16/2018 06:00 AM, Eric Dumazet wrote: On Mon, Oct 15, 2018 at 11:30 PM Andre Tomt wrote: I've seen similar on several systems with mlx4 cards when using 4.18.x - that is hw csum failure followed by some

[PATCH] net/mlx5: Allocate enough space for the FDB sub-namespaces

2018-10-21 Thread Or Gerlitz
From: Dan Carpenter FDB_MAX_CHAIN is three. We wanted to allocate enough memory to hold four structs but there are missing parentheses so we only allocate enough memory for three structs and the first byte of the fourth one. Fixes: 328edb499f99 ("net/mlx5: Split FDB fast path prio to multiple

Re: [PATCH] net/mlx5: allocate enough space in

2018-10-21 Thread Or Gerlitz
On Sat, Oct 20, 2018 at 11:37 PM Or Gerlitz wrote: > On Fri, Oct 19, 2018 at 11:08 PM Dan Carpenter > wrote: > > FDB_MAX_CHAIN is 3. We wanted to allocate enough memory to hold four > > structs but there are missing parentheses so we only allocate enough > > memory for three structs and the fir

I NEED YOUR HELP URGENTLY!!!

2018-10-21 Thread GEN KELVIN
Compliment of the day to you. I am Gen.Kelvin W Howard, I am sending this brief letter to solicit your partnership of Sixteen Million Two Hundred Thousand United States Dollars ($16,200,000). I shall send you more information and procedures when I receive positive response from you.Best Regards

Re: [PATCH net-next] octeontx2-af: Remove set but not used variable 'block'

2018-10-21 Thread YueHaibing
On 2018/10/19 21:36, Sunil Kovvuri wrote: > On Fri, Oct 19, 2018 at 6:11 PM YueHaibing wrote: >> >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c: In function >> 'rvu_npa_init': >> drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c:446:2

Re: [PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-10-21 Thread Jesper Dangaard Brouer
On Sat, 20 Oct 2018 23:00:24 +0100 Quentin Monnet wrote: > libbpf is now able to load successfully test_l4lb_noinline.o and > samples/bpf/tracex3_kern.o, so we can uncomment related tests from > test_libbpf.c and remove the associated "TODO"s. Thanks for working on this, comments below. > It is

r8169: changed rx buffer alignment requirement

2018-10-21 Thread Heiner Kallweit
Hi Eric, when working on the r8169 driver I came across an old patch from you: 6f0333b8fde4 ("r8169: use 50% less ram for RX ring") As part of this patch the alignment requirement for rx buffers was silently changed from 8 to 16 bytes. Can you remember (well, after eight years) why you did this?

Re: [PATCH] net: ethernet:fec: Consistently use SPEED_ prefix

2018-10-21 Thread Sergei Shtylyov
On 20.10.2018 23:48, Andrew Lunn wrote: All other calls to phy_set_max_speed() use the SPEED_ prefix. Make the FEC driver follow this common pattern. This makes no different to Difference. generated code since SPEED_1000 is 1000, and SPEED_100 is 100. Reported-by: Corentin Labbe Signed-

Re: [PATCH net-next] net: phy: phy_support_sym_pause: Clear Asym Pause

2018-10-21 Thread Sergei Shtylyov
Hello! On 20.10.2018 23:41, Andrew Lunn wrote: When indicating the MAC supports Symmetric Pause, clear the Asymmetric Pause bit, which could of been already set is the PHY supports it. Could've been, s/is/if/. Reported-by: Labbe Corentin Fixes: c306ad36184f ("net: ethernet: Add helper f