Re: [PATCH next-queue 3/8] ixgbe: add VF ipsec management

2018-08-13 Thread kbuild test robot
Hi Shannon, Thank you for the patch! Yet something to improve: [auto build test ERROR on jkirsher-next-queue/dev-queue] [also build test ERROR on v4.18 next-20180813] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: lock recursion - was: Re: [4.18 rc7] BUG: sleeping function called from invalid context at mm/slab.h:421

2018-08-13 Thread Mikhail Gavrilov
That's all? Issue happens everytime when I paired computer with bluetooth peripherals. And this is not dependent on the bluetooth adapter used. I see this on three different systems. -- Best Regards, Mike Gavrilov. On Wed, 8 Aug 2018 at 16:36, Petr Mladek wrote: > > On Wed 2018-08-08 11:05:00, Vl

[PATCH v2 iproute2-next] Add SKB Priority qdisc support in tc(8)

2018-08-13 Thread Nishanth Devarajan
sch_skbprio is a qdisc that prioritizes packets according to their skb->priority field. Under congestion, it drops already-enqueued lower priority packets to make space available for higher priority packets. Skbprio was conceived as a solution for denial-of-service defenses that need to route packe

Re: [PATCH net 0/2] net_sched: Fix two tc_index filter init issues

2018-08-13 Thread David Miller
From: Hangbin Liu Date: Mon, 13 Aug 2018 18:44:02 +0800 > These two patches fix two tc_index filter init issues. The first one fixes > missing exts info in new filter, which will cause NULL pointer dereference > when delete tcindex filter. The second one fixes missing res info when create > new f

Re: [PATCH net] nfp: clean up return types in kdoc comments

2018-08-13 Thread David Miller
From: Jakub Kicinski Date: Mon, 13 Aug 2018 18:31:05 -0700 > Remove 'Return:' information from functions which no longer > return a value. Also update name and return types of nfp_nffw_info > access functions. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Dirk van der Merwe Applied, thank

Re: [PATCH net 2/2] net_sched: Fix missing res info when create new tc_index filter

2018-08-13 Thread Cong Wang
On Mon, Aug 13, 2018 at 3:44 AM Hangbin Liu wrote: > This is because we didn't update f->result.res when create new filter. Then in > tcindex_delete() -> tcf_unbind_filter(), we will failed to find out the res > and unbind filter, which will trigger the WARN_ON() in cbq_destroy_class(). > > Fix it

Re: [PATCH net 1/2] net_sched: fix NULL pointer dereference when delete tcindex filter

2018-08-13 Thread Cong Wang
On Mon, Aug 13, 2018 at 3:44 AM Hangbin Liu wrote: > > This is because in tcindex_set_parms, when there is no old_r, we set new > exts to cr.exts. And we didn't set it to filter when r == &new_filter_result. > > Then in tcindex_delete() -> tcf_exts_get_net(), we will get NULL pointer > dereference

[PATCH net] nfp: clean up return types in kdoc comments

2018-08-13 Thread Jakub Kicinski
Remove 'Return:' information from functions which no longer return a value. Also update name and return types of nfp_nffw_info access functions. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 -- drivers/net/ethernet/

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread Cong Wang
Hi, Vlad, Could you help to test my fixes? I just pushed them into my own git repo: https://github.com/congwang/linux/commits/net-sched-fixes Particularly, this is the revert: https://github.com/congwang/linux/commit/b3f51c4ab8272cc8d3244848e528fce1426c4659 and this is my fix for the lockdep war

Re: [pull request][net-next V2 00/12] Mellanox, mlx5e updates 2018-08-10

2018-08-13 Thread David Miller
From: Saeed Mahameed Date: Mon, 13 Aug 2018 13:44:08 -0700 > This series provides some updates to mlx5e netdevice driver. > > For more information please see tag log below. > > Please pull and let me know if there's any problem. > > v1->v2: > - Use l4_mask local function variable in validate_

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread Cong Wang
On Mon, Aug 13, 2018 at 3:53 PM David Miller wrote: > > From: Cong Wang > Date: Mon, 13 Aug 2018 12:16:52 -0700 > > > Your fix doesn't make sense, because what ife_mod_lock protects > > is absolutely not touched in BH context, they have no race. > > It does make sense, the problem is if you acqui

Re: [PATCH net-next v6 08/11] net: sched: don't release reference on action overwrite

2018-08-13 Thread Cong Wang
On Thu, Jul 5, 2018 at 7:24 AM Vlad Buslov wrote: > diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c > index 89a761395c94..acea3feae762 100644 > --- a/net/sched/act_ife.c > +++ b/net/sched/act_ife.c ... > @@ -548,6 +546,8 @@ static int tcf_ife_init(struct net *net, struct nlattr > *nla, > >

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread David Miller
From: Cong Wang Date: Mon, 13 Aug 2018 12:16:52 -0700 > Your fix doesn't make sense, because what ife_mod_lock protects > is absolutely not touched in BH context, they have no race. It does make sense, the problem is if you acquire ife_mod_lock and take a software interrupt while you hold it. I

[RFC/PATCH]] net: nixge: Add support for 64-bit ZynqMP platform

2018-08-13 Thread Moritz Fischer
Add support for 64-bit (ZynqMP) platform to driver. The hardware only supports 32-bit register accesses so the accesses need to be split up into two writes when setting the current and tail descriptor values. Signed-off-by: Moritz Fischer Cc: Florian Fainelli --- Hi all, I'm working on making

[net-next V2 08/12] net/mlx5e: Move flow steering declarations into en/fs.h

2018-08-13 Thread Saeed Mahameed
Move flow steering declarations and definitions into the dedicated en/fs.h header file Signed-off-by: Saeed Mahameed Reviewed-by: Moshe Shemesh --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 126 - .../net/ethernet/mellanox/mlx5/core/en/fs.h | 129 ++ 2 fi

[net-next V2 09/12] net/mlx5e: vxlan.c depends on CONFIG_VXLAN

2018-08-13 Thread Saeed Mahameed
When vxlan is not enabled by kernel, no need to enable it in mlx5. Compile out lib/vxlan.c if CONFIG_VXLAN is not selected. Signed-off-by: Saeed Mahameed Reviewed-by: Moshe Shemesh Reviewed-by: Eran Ben Elisha --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 + drivers/net/ethernet

[net-next V2 11/12] net/mlx5: Reorganize the makefile

2018-08-13 Thread Saeed Mahameed
Reorganize the Makefile and group files together according to their functionality and importance. Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/Makefile | 57 +-- 1 file changed, 40 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/mellano

[net-next V2 12/12] net/mlx5: Improve argument name for add flow API

2018-08-13 Thread Saeed Mahameed
From: Eli Cohen The last argument to mlx5_add_flow_rules passes the number of destinations in the struct pointed to by the dest arg. Change the name to better reflect this fact. Signed-off-by: Eli Cohen Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/m

[net-next V2 10/12] net/mlx5e: clock.c depends on CONFIG_PTP_1588_CLOCK

2018-08-13 Thread Saeed Mahameed
From: Moshe Shemesh lib/clock.c includes clock related functions which require ptp support. Thus compile out lib/clock.c and add the needed function stubs in case kconfig CONFIG_PTP_1588_CLOCK is off. Signed-off-by: Moshe Shemesh Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx

[net-next V2 06/12] net/mlx5e: Add CONFIG_MLX5_EN_RXNFC for ethtool rx nfc

2018-08-13 Thread Saeed Mahameed
Add new mlx5 Kconfig flag to allow selecting ethtool rx nfc support, and compile out en_fs_ehtool.c if not selected. Add en/fs.h header file to host all steering declarations and definitions. Signed-off-by: Saeed Mahameed Reviewed-by: Moshe Shemesh --- .../net/ethernet/mellanox/mlx5/core/Kconf

[net-next V2 02/12] net/mlx5e: Ethtool steering flow parsing refactoring

2018-08-13 Thread Saeed Mahameed
Have a parsing function per flow type, that converts from ethtool rx flow spec to mlx5 flow spec. Will be useful to add support for ip6 ethtool flow steering in the next patch. Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/en_fs_ethtool.c| 230 ++ 1 file chang

[net-next V2 05/12] net/mlx5e: Ethtool steering, move ethtool callbacks

2018-08-13 Thread Saeed Mahameed
Move ethool rxnfc callback into en_fs_etthool file where they belong. This will allow us to make many ethtool fs related helper functions static. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 11 +-- .../ethernet/mellanox/mlx5/core/en_ethtool.c | 48 -

[net-next V2 01/12] net/mlx5e: Ethtool steering flow validation refactoring

2018-08-13 Thread Saeed Mahameed
Have a ethtool rx flow spec validation helper function per flow type. Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/en_fs_ethtool.c| 164 +++--- 1 file changed, 100 insertions(+), 64 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c

[net-next V2 07/12] net/mlx5e: Add CONFIG_MLX5_EN_ARFS for accelerated flow steering support

2018-08-13 Thread Saeed Mahameed
Add new mlx5 Kconfig flag to allow selecting accelerated flow steering support, and compile out en_arfs.c if not selected. Move arfs declarations and definitions to en/fs.h header file. Signed-off-by: Saeed Mahameed Reviewed-by: Moshe Shemesh --- .../net/ethernet/mellanox/mlx5/core/Kconfig |

[net-next V2 03/12] net/mlx5e: Ethtool steering, ip6 support

2018-08-13 Thread Saeed Mahameed
Add ip6 support for ethtool flow steering. New supported flow types: ip6|tcp6|udp6| Supported fields: src-ip|dst-ip|src-port|dst-port Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/en_fs_ethtool.c| 129 ++ 1 file changed, 129 insertions(+) diff --git a/drivers

[pull request][net-next V2 00/12] Mellanox, mlx5e updates 2018-08-10

2018-08-13 Thread Saeed Mahameed
Hi Dave, This series provides some updates to mlx5e netdevice driver. For more information please see tag log below. Please pull and let me know if there's any problem. v1->v2: - Use l4_mask local function variable in validate_tcpudp4 rather than the passed paramter - Use ipv6_addr_any ins

[net-next V2 04/12] net/mlx5e: Ethtool steering, l4 proto support

2018-08-13 Thread Saeed Mahameed
Add support for l4 proto ip field in ethtool flow steering. Example: Redirect icmpv6 to rx queue #2 ethtool -U eth0 flow-type ip6 l4proto 58 action 2 Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/en_fs_ethtool.c| 19 --- 1 file changed, 16 insertions(+), 3 de

Re: TJA1100 100Base-T1 PHY features via ethtool?

2018-08-13 Thread Florian Fainelli
On 08/13/2018 12:35 PM, Michael Grzeschik wrote: > Hi David, > > I use a special 100Base-T1 phy (NXP TJA1100 [1]) that has some features > like: > > - enabling/disabling test modes > - fault detection > - switching managed/autonomous mode > - signal quality indication > - ... > > I already imple

Re: [PATCH net-next] openvswitch: Derive IP protocol number for IPv6 later frags

2018-08-13 Thread Yi-Hung Wei
On Mon, Aug 13, 2018 at 10:48 AM William Tu wrote: > > > --- a/net/openvswitch/flow.c > > > +++ b/net/openvswitch/flow.c > > > @@ -297,7 +297,13 @@ static int parse_ipv6hdr(struct sk_buff *skb, struct > > > sw_flow_key *key) > > > > > > nh_len = payload_ofs - nh_ofs; > > > skb_set

Re: [net-next,v2] cpumask: make cpumask_next_wrap available without smp

2018-08-13 Thread Willem de Bruijn
On Mon, Aug 13, 2018 at 6:01 PM Krzysztof Kozlowski wrote: > > On Sun, Aug 12, 2018 at 09:14:03AM -0400, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > The kbuild robot shows build failure on machines without CONFIG_SMP: > > If this was reported by kbuild robot, then could you credit

TJA1100 100Base-T1 PHY features via ethtool?

2018-08-13 Thread Michael Grzeschik
Hi David, I use a special 100Base-T1 phy (NXP TJA1100 [1]) that has some features like: - enabling/disabling test modes - fault detection - switching managed/autonomous mode - signal quality indication - ... I already implemented the support of the features with the ethtool --get/set-phy-tunable

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread Cong Wang
On Mon, Aug 13, 2018 at 12:16 PM Cong Wang wrote: > > On Mon, Aug 13, 2018 at 10:20 AM Vlad Buslov wrote: > > > > Lockdep reports deadlock for following locking scenario in ife action: > > > > Task one: > > 1) Executes ife action update. > > 2) Takes tcfa_lock. > > 3) Waits on ife_mod_lock which

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread Cong Wang
On Mon, Aug 13, 2018 at 10:20 AM Vlad Buslov wrote: > > Lockdep reports deadlock for following locking scenario in ife action: > > Task one: > 1) Executes ife action update. > 2) Takes tcfa_lock. > 3) Waits on ife_mod_lock which is already taken by task two. > > Task two: > > 1) Executes any path

Re: [Query]: DSA Understanding

2018-08-13 Thread Florian Fainelli
On 08/13/2018 08:58 AM, Lad, Prabhakar wrote: > Hi Andrew/Florain, > > On Mon, Aug 13, 2018 at 2:38 PM Andrew Lunn wrote: >> I agree, this should be padding packets correctly, can you still instrument cpsw to make sure that what comes to its ndo_start_xmit() is ETH_ZLEN + tag_len o

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread David Miller
From: Vlad Buslov Date: Mon, 13 Aug 2018 20:20:11 +0300 > Lockdep reports deadlock for following locking scenario in ife action: > > Task one: > 1) Executes ife action update. > 2) Takes tcfa_lock. > 3) Waits on ife_mod_lock which is already taken by task two. > > Task two: > > 1) Executes any

[PATCH next-queue 0/8] ixgbe/ixgbevf: IPsec offload support for VFs

2018-08-13 Thread Shannon Nelson
This set of patches implements IPsec hardware offload for VF devices in Intel's 10Gbe x540 family of Ethernet devices. The IPsec HW offload feature has been in the x540/Niantic family of network devices since their release in 2009, but there was no Linux kernel support for the offload until 2017.

[PATCH next-queue 3/8] ixgbe: add VF ipsec management

2018-08-13 Thread Shannon Nelson
Add functions to translate VF IPsec offload add and delete requests into something the existing code can work with. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 256 - drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.h | 13 ++ 2 files c

[PATCH next-queue 1/8] ixgbe: reload ipsec ip table after sa tables

2018-08-13 Thread Shannon Nelson
Restore the ipsec hardware IP table after reloading the SA tables. This doesn't make much difference now, but will matter when we add support for VF ipsec offloads. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 16 1 file changed, 8 insertion

[PATCH next-queue 2/8] ixgbe: prep ipsec constants for later use

2018-08-13 Thread Shannon Nelson
Pull out a couple of values from a function so they can be used later elsewhere. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/

[PATCH next-queue 6/8] ixgbevf: add defines for IPsec offload request

2018-08-13 Thread Shannon Nelson
Fix up the register definitions for using IPsec offloads and add the new mailbox message IDs. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbevf/defines.h | 8 drivers/net/ethernet/intel/ixgbevf/mbx.h | 5 + 2 files changed, 13 insertions(+) diff --git a/drive

[PATCH next-queue 5/8] ixgbe: add VF IPsec offload request message handling

2018-08-13 Thread Shannon Nelson
Add an add and a delete message for IPsec offload requests from the VF. These call into the ipsec functions that can translate the message buffer into a useful IPsec offload. These new messages bump the mbox API version to 1.4. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe

[PATCH next-queue 4/8] ixgbe: add VF IPsec offload enable flag

2018-08-13 Thread Shannon Nelson
Add a private flag to expressly enable support for VF IPsec offload. The VF will have to be "trusted" in order to use the hardware offload, but because of the general concerns of managing VF access, we want to be sure the user specifically is enabling the feature. This is likely a candidate for be

[PATCH next-queue 7/8] ixgbevf: add VF ipsec offload code

2018-08-13 Thread Shannon Nelson
Add the ipsec offload support code. This is based off of the similar code in ixgbe, but instead of writing the SA registers, the VF asks the PF to setup the offload by sending the offload information to the PF via the standard mailbox. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/inte

[PATCH next-queue 8/8] ixgbevf: enable VF ipsec offload operations

2018-08-13 Thread Shannon Nelson
Add the ipsec initialization into the driver startup and add the Rx and Tx processing hooks. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbevf/defines.h | 2 +- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 2 + drivers/net/ethernet/intel/ixgbevf/ixgbevf.h |

Re: pull request: bluetooth-next 2018-08-13

2018-08-13 Thread David Miller
From: Johan Hedberg Date: Mon, 13 Aug 2018 18:00:19 +0300 > There was one pretty bad bug that slipped into the MediaTek HCI driver > in the last bluetooth-next pull request. Would it be possible to get > this one-liner fix pulled to net-next before you make your first 4.19 > pull request for Linu

Re: [PATCH iproute2-next 1/3] tc: support conversions to or from 64 bit nanosecond-based time

2018-08-13 Thread Dave Taht
On Sun, Aug 12, 2018 at 3:09 PM David Ahern wrote: > > On 8/6/18 11:09 AM, Yousuk Seung wrote: > > diff --git a/tc/tc_core.h b/tc/tc_core.h > > index 1dfa9a4f773b..a0fe0923d171 100644 > > --- a/tc/tc_core.h > > +++ b/tc/tc_core.h > > @@ -7,6 +7,10 @@ > > > > #define TIME_UNITS_PER_SEC 100 >

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread Vlad Buslov
On Mon 13 Aug 2018 at 17:23, Jamal Hadi Salim wrote: > On 2018-08-13 1:20 p.m., Vlad Buslov wrote: >> Lockdep reports deadlock for following locking scenario in ife action: >> >> Task one: >> 1) Executes ife action update. >> 2) Takes tcfa_lock. >> 3) Waits on ife_mod_lock which is already take

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread David Miller
From: Vlad Buslov Date: Mon, 13 Aug 2018 20:26:40 +0300 > Is it okay to submit a fix for issue I uncovered when testing actions > with estimators, or I should resubmit to net when net-next is moved? Yes, this is fine.

Re: [PATCH net-next] openvswitch: Derive IP protocol number for IPv6 later frags

2018-08-13 Thread William Tu
On Sun, Aug 12, 2018 at 6:09 PM Pravin Shelar wrote: > > On Fri, Aug 10, 2018 at 10:19 AM, Yi-Hung Wei wrote: > > Currently, OVS only parses the IP protocol number for the first > > IPv6 fragment, but sets the IP protocol number for the later fragments > > to be NEXTHDF_FRAGMENT. This patch trie

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread Vlad Buslov
Hi David, Is it okay to submit a fix for issue I uncovered when testing actions with estimators, or I should resubmit to net when net-next is moved? Thanks, Vlad

Re: [PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread Jamal Hadi Salim
On 2018-08-13 1:20 p.m., Vlad Buslov wrote: Lockdep reports deadlock for following locking scenario in ife action: Task one: 1) Executes ife action update. 2) Takes tcfa_lock. 3) Waits on ife_mod_lock which is already taken by task two. Task two: 1) Executes any path that obtains ife_mod_lock

[PATCH net-next] net: sched: act_ife: disable bh when taking ife_mod_lock

2018-08-13 Thread Vlad Buslov
Lockdep reports deadlock for following locking scenario in ife action: Task one: 1) Executes ife action update. 2) Takes tcfa_lock. 3) Waits on ife_mod_lock which is already taken by task two. Task two: 1) Executes any path that obtains ife_mod_lock without disabling bh (any path that takes ife_

Re: [PATCH 0/3] net, IB/ipoib: Use dev_port to disambiguate

2018-08-13 Thread Jason Gunthorpe
On Mon, Aug 13, 2018 at 02:42:21PM +0300, Arseny Maslennikov wrote: > Pre-3.15 userspace had trouble distinguishing different ports of a NIC > on a single PCI bus/device/function. To solve this, a sysfs field `dev_port' > was introduced quite a while ago (commit v3.14-rc3-739-g3f85944fe207), and >

net-next is CLOSED...

2018-08-13 Thread David Miller
Please only submit bug fixes at this time, thank you.

Re: pull-request: bpf-next 2018-08-13

2018-08-13 Thread David Miller
From: Daniel Borkmann Date: Mon, 13 Aug 2018 01:49:22 +0200 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git Pulled, than

Re: [PATCH net-next] lan743x: lan743x: Remove duplicated include from lan743x_ptp.c

2018-08-13 Thread David Miller
From: Yue Haibing Date: Mon, 13 Aug 2018 06:39:21 + > Remove duplicated include. > > Signed-off-by: Yue Haibing Applied.

Re: [PATCH net-next] virtio_net: remove duplicated include from virtio_net.c

2018-08-13 Thread David Miller
From: YueHaibing Date: Mon, 13 Aug 2018 14:13:15 +0800 > Remove duplicated include linux/netdevice.h > > Signed-off-by: YueHaibing Applied.

Re: [PATCH v2 iproute2-next] sch_cake: Make gso-splitting configurable

2018-08-13 Thread Toke Høiland-Jørgensen
David Ahern writes: > On 8/13/18 5:36 AM, Toke Høiland-Jørgensen wrote: >> This patch makes sch_cake's gso/gro splitting configurable >> from userspace. >> >> To disable breaking apart superpackets in sch_cake: >> >> tc qdisc replace dev whatever root cake no-split-gso >> >> to enable: >> >>

Re: [PATCH][net-next][v2] packet: switch kvzalloc to allocate memory

2018-08-13 Thread David Miller
From: Li RongQing Date: Mon, 13 Aug 2018 10:42:46 +0800 > The patches includes following change: > > *Use modern kvzalloc()/kvfree() instead of custom allocations. > > *Remove order argument for alloc_pg_vec, it can get from req. > > *Remove order argument for free_pg_vec, free_pg_vec now uses

Re: [net-next,v2] cpumask: make cpumask_next_wrap available without smp

2018-08-13 Thread Krzysztof Kozlowski
On Sun, Aug 12, 2018 at 09:14:03AM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > The kbuild robot shows build failure on machines without CONFIG_SMP: If this was reported by kbuild robot, then could you credit him with Reported-by? > > drivers/net/virtio_net.c:1916:10: error: >

Re: [PATCH net-next 00/13] net: sched: actions rename for grep-ability and consistency

2018-08-13 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 12 Aug 2018 09:34:48 -0400 > Having a structure (example tcf_mirred) and a function with the same name is > not good for readability or grepability. > > This long overdue patchset improves it and make sure there is consistency > across all actions Series applie

Re: [Query]: DSA Understanding

2018-08-13 Thread Lad, Prabhakar
Hi Andrew/Florain, On Mon, Aug 13, 2018 at 2:38 PM Andrew Lunn wrote: > > > > I agree, this should be padding packets correctly, can you still > > > instrument cpsw to make sure that what comes to its ndo_start_xmit() is > > > ETH_ZLEN + tag_len or more? > > > > > Yes I can confirm the skb->len i

Re: [PATCH net-next v2] cpumask: make cpumask_next_wrap available without smp

2018-08-13 Thread David Miller
From: Willem de Bruijn Date: Sun, 12 Aug 2018 09:14:03 -0400 > From: Willem de Bruijn > > The kbuild robot shows build failure on machines without CONFIG_SMP: > > drivers/net/virtio_net.c:1916:10: error: > implicit declaration of function 'cpumask_next_wrap' > > cpumask_next_wrap is exp

Re: [PATCH net] r8169: don't use MSI-X on RTL8168g

2018-08-13 Thread David Miller
From: Heiner Kallweit Date: Sun, 12 Aug 2018 13:26:26 +0200 > There have been two reports that network doesn't come back on resume > from suspend when using MSI-X. Both cases affect the same chip version > (RTL8168g - version 40), on different systems. Falling back to MSI > fixes the issue. > Eve

Re: [PATCH net v2] l2tp: use sk_dst_check() to avoid race on sk->sk_dst_cache

2018-08-13 Thread David Miller
From: Wei Wang Date: Fri, 10 Aug 2018 11:14:56 -0700 > From: Wei Wang > > In l2tp code, if it is a L2TP_UDP_ENCAP tunnel, tunnel->sk points to a > UDP socket. User could call sendmsg() on both this tunnel and the UDP > socket itself concurrently. As l2tp_xmit_skb() holds socket lock and call >

Re: [PATCH net-next v3 1/1] net/tls: Combined memory allocation for decryption request

2018-08-13 Thread David Miller
From: Vakul Garg Date: Fri, 10 Aug 2018 20:46:41 +0530 > For preparing decryption request, several memory chunks are required > (aead_req, sgin, sgout, iv, aad). For submitting the decrypt request to > an accelerator, it is required that the buffers which are read by the > accelerator must be dma

Re: [PATCH bpf-next 1/4] bpf: Introduce bpf_skb_ancestor_cgroup_id helper

2018-08-13 Thread Andrey Ignatov
Tejun Heo [Mon, 2018-08-13 07:47 -0700]: > Hello, Andrey. Hey Tejun! > On Fri, Aug 10, 2018 at 10:35:23PM -0700, Andrey Ignatov wrote: > > +static inline struct cgroup *cgroup_ancestor(struct cgroup *cgrp, > > +int ancestor_level) > > +{ > > + struct cgr

pull request: bluetooth-next 2018-08-13

2018-08-13 Thread Johan Hedberg
Hi Dave, There was one pretty bad bug that slipped into the MediaTek HCI driver in the last bluetooth-next pull request. Would it be possible to get this one-liner fix pulled to net-next before you make your first 4.19 pull request for Linus? Thanks. Johan --- The following changes since commit

Re: [PATCH bpf-next 1/4] bpf: Introduce bpf_skb_ancestor_cgroup_id helper

2018-08-13 Thread Tejun Heo
Hello, Andrey. On Fri, Aug 10, 2018 at 10:35:23PM -0700, Andrey Ignatov wrote: > +static inline struct cgroup *cgroup_ancestor(struct cgroup *cgrp, > + int ancestor_level) > +{ > + struct cgroup *ptr; > + > + if (cgrp->level < ancestor_level) > +

Re: [PATCH v2 iproute2-next] sch_cake: Make gso-splitting configurable

2018-08-13 Thread David Ahern
On 8/13/18 5:36 AM, Toke Høiland-Jørgensen wrote: > This patch makes sch_cake's gso/gro splitting configurable > from userspace. > > To disable breaking apart superpackets in sch_cake: > > tc qdisc replace dev whatever root cake no-split-gso > > to enable: > > tc qdisc replace dev whatever root

Re: [PATCH 2/3] IB/ipoib: Stop using dev_id to expose port numbers

2018-08-13 Thread Arseny Maslennikov
On Mon, Aug 13, 2018 at 03:40:20PM +0300, Yuval Shaia wrote: > On Mon, Aug 13, 2018 at 02:42:23PM +0300, Arseny Maslennikov wrote: > > Some InfiniBand network devices have multiple ports on the same PCI > > function. Prior to this the kernel erroneously used the `dev_id' sysfs > > field of those ne

Re: [Query]: DSA Understanding

2018-08-13 Thread Andrew Lunn
> > I agree, this should be padding packets correctly, can you still > > instrument cpsw to make sure that what comes to its ndo_start_xmit() is > > ETH_ZLEN + tag_len or more? > > > Yes I can confirm the skb->len is always >= 62 (ETH_ZLEN + 2) Which switch are you using? Marvell switches use eit

Re: [PATCH 2/3] IB/ipoib: Stop using dev_id to expose port numbers

2018-08-13 Thread Yuval Shaia
On Mon, Aug 13, 2018 at 02:42:23PM +0300, Arseny Maslennikov wrote: > Some InfiniBand network devices have multiple ports on the same PCI > function. Prior to this the kernel erroneously used the `dev_id' sysfs > field of those network interfaces to convey the port number to userspace. > > `dev_id

Re: [PATCH net 2/2] net/mlx5e: Cleanup of dcbnl related fields

2018-08-13 Thread Yuval Shaia
On Wed, Aug 08, 2018 at 03:48:08PM -0700, Saeed Mahameed wrote: > From: Huy Nguyen > > Remove unused netdev_registered_init/remove in en.h > Return ENOSUPPORT if the check MLX5_DSCP_SUPPORTED fails. > Remove extra white space > > Fixes: 2a5e7a1344f4 ("net/mlx5e: Add dcbnl dscp to priority suppor

Re: [PATCH bpf-next V3] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Daniel Borkmann
On 08/13/2018 02:02 PM, Jesper Dangaard Brouer wrote: > On Mon, 13 Aug 2018 13:57:04 +0300 > Tariq Toukan wrote: >> On 13/08/2018 1:31 PM, Jesper Dangaard Brouer wrote: >>> On Mon, 13 Aug 2018 12:21:58 +0300 >>> Tariq Toukan wrote: [...] >>> In the example[1], the sequence is wrapped in rcu_read_

[PATCH 0/3] net, IB/ipoib: Use dev_port to disambiguate

2018-08-13 Thread Arseny Maslennikov
Pre-3.15 userspace had trouble distinguishing different ports of a NIC on a single PCI bus/device/function. To solve this, a sysfs field `dev_port' was introduced quite a while ago (commit v3.14-rc3-739-g3f85944fe207), and some relevant device drivers were fixed to use it, but not in case of IPoIB.

[PATCH 1/3] IB/ipoib: Use dev_port to expose network interface port numbers

2018-08-13 Thread Arseny Maslennikov
Some InfiniBand network devices have multiple ports on the same PCI function. This initializes the `dev_port' sysfs field of those network interfaces with their port number. The use of `dev_id' was considered correct until Linux 3.15, when another field, `dev_port', was defined for this particular

[PATCH 2/3] IB/ipoib: Stop using dev_id to expose port numbers

2018-08-13 Thread Arseny Maslennikov
Some InfiniBand network devices have multiple ports on the same PCI function. Prior to this the kernel erroneously used the `dev_id' sysfs field of those network interfaces to convey the port number to userspace. `dev_id' is currently reserved for distinguishing stacked ifaces (e.g: VLANs) with th

[PATCH 3/3] Documentation/ABI: document /sys/class/net/*/dev_port

2018-08-13 Thread Arseny Maslennikov
The sysfs field was introduced 4 years ago along with fixes to various drivers that erroneously used `dev_id' for that purpose, but it was not properly documented anywhere. See commit v3.14-rc3-739-g3f85944fe207. Signed-off-by: Arseny Maslennikov --- Documentation/ABI/testing/sysfs-class-net | 1

Re: [PATCH bpf-next V3] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Jesper Dangaard Brouer
On Mon, 13 Aug 2018 13:57:04 +0300 Tariq Toukan wrote: > On 13/08/2018 1:31 PM, Jesper Dangaard Brouer wrote: > > On Mon, 13 Aug 2018 12:21:58 +0300 > > Tariq Toukan wrote: > > > >> Fix the warning below by calling rhashtable_lookup_fast. > >> Also, make some code movements for better quality

[PATCH v2 iproute2-next] sch_cake: Make gso-splitting configurable

2018-08-13 Thread Toke Høiland-Jørgensen
This patch makes sch_cake's gso/gro splitting configurable from userspace. To disable breaking apart superpackets in sch_cake: tc qdisc replace dev whatever root cake no-split-gso to enable: tc qdisc replace dev whatever root cake split-gso Signed-off-by: Toke Høiland-Jørgensen Signed-off-by:

Re: [Query]: DSA Understanding

2018-08-13 Thread Lad, Prabhakar
Hi Florian, On Fri, Aug 10, 2018 at 6:36 PM Florian Fainelli wrote: > > On 08/10/2018 04:26 AM, Lad, Prabhakar wrote: > > Hi Andrew, > > > > On Thu, Aug 9, 2018 at 6:23 PM Andrew Lunn wrote: > >> > >>> Its coming from the switch lan4 I have attached the png, where > >>> C4:F3:12:08:FE:7F is > >>

Re: [PATCH bpf-next V3] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Tariq Toukan
On 13/08/2018 1:31 PM, Jesper Dangaard Brouer wrote: On Mon, 13 Aug 2018 12:21:58 +0300 Tariq Toukan wrote: Fix the warning below by calling rhashtable_lookup_fast. Also, make some code movements for better quality and human readability. [ 342.450870] WARNING: suspicious RCU usage [ 342.

[PATCH net 0/2] net_sched: Fix two tc_index filter init issues

2018-08-13 Thread Hangbin Liu
These two patches fix two tc_index filter init issues. The first one fixes missing exts info in new filter, which will cause NULL pointer dereference when delete tcindex filter. The second one fixes missing res info when create new filter, which will make filter unbind failed. Hangbin Liu (2): n

[PATCH net 1/2] net_sched: fix NULL pointer dereference when delete tcindex filter

2018-08-13 Thread Hangbin Liu
Li Shuang reported the following crash: [ 71.267724] BUG: unable to handle kernel NULL pointer dereference at 0004 [ 71.276456] PGD 80085d9bd067 P4D 80085d9bd067 PUD 859a0b067 PMD 0 [ 71.284127] Oops: [#1] SMP PTI [ 71.288015] CPU: 12 PID: 2386 Comm: tc Not tainte

[PATCH net 2/2] net_sched: Fix missing res info when create new tc_index filter

2018-08-13 Thread Hangbin Liu
Li Shuang reported the following warn: [ 733.484610] WARNING: CPU: 6 PID: 21123 at net/sched/sch_cbq.c:1418 cbq_destroy_class+0x5d/0x70 [sch_cbq] [ 733.495190] Modules linked in: sch_cbq cls_tcindex sch_dsmark rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd grace fscache xt_CHECKSUM

Re: [PATCH bpf-next V3] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Jesper Dangaard Brouer
On Mon, 13 Aug 2018 12:21:58 +0300 Tariq Toukan wrote: > Fix the warning below by calling rhashtable_lookup_fast. > Also, make some code movements for better quality and human > readability. > > [ 342.450870] WARNING: suspicious RCU usage > [ 342.455856] 4.18.0-rc2+ #17 Tainted: G O

Re: [PATCH bpf-next V2] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Daniel Borkmann
On 08/13/2018 11:13 AM, Jesper Dangaard Brouer wrote: > On Mon, 13 Aug 2018 10:04:39 +0300 > Tariq Toukan wrote: > >> Fix the warning below by calling rhashtable_lookup_fast. >> Also, make some code movements for better quality and human >> readability. >> >> [ 342.450870] WARNING: suspicious RC

Re: [PATCH bpf-next V2] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Tariq Toukan
On 13/08/2018 12:13 PM, Jesper Dangaard Brouer wrote: On Mon, 13 Aug 2018 10:04:39 +0300 Tariq Toukan wrote: Fix the warning below by calling rhashtable_lookup_fast. Also, make some code movements for better quality and human readability. [ 342.450870] WARNING: suspicious RCU usage [ 342

[PATCH bpf-next V3] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Tariq Toukan
Fix the warning below by calling rhashtable_lookup_fast. Also, make some code movements for better quality and human readability. [ 342.450870] WARNING: suspicious RCU usage [ 342.455856] 4.18.0-rc2+ #17 Tainted: G O [ 342.462210] - [ 342.467202] ./include

Re: [PATCH bpf-next V2] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Jesper Dangaard Brouer
On Mon, 13 Aug 2018 10:04:39 +0300 Tariq Toukan wrote: > Fix the warning below by calling rhashtable_lookup_fast. > Also, make some code movements for better quality and human > readability. > > [ 342.450870] WARNING: suspicious RCU usage > [ 342.455856] 4.18.0-rc2+ #17 Tainted: G O

Re: [PATCH] net: macb: do not disable MDIO bus when closing interface

2018-08-13 Thread Claudiu Beznea
On 10.08.2018 09:22, Anssi Hannula wrote: > On 9.8.2018 18:14, Andrew Lunn wrote: >> Hi Anssi > > Hi! > >>> macb_reset_hw() is called in init path too, I only see it in macb_close() and macb_open() called from macb_init_hw(). though, so maybe clearing >>> all bits is intentional / wanted to

Re: [PATCH net-next v6 10/11] net: sched: atomically check-allocate action

2018-08-13 Thread Vlad Buslov
On Fri 10 Aug 2018 at 21:45, Cong Wang wrote: > On Fri, Aug 10, 2018 at 3:29 AM Vlad Buslov wrote: >> >> Approach you suggest is valid, but has its own trade-offs: >> >> - As you noted, lock granularity becomes coarse-grained due to per-netns >> scope. > > Sure, you acquire idrinfo->lock too, t

[PATCH bpf-next V2] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Tariq Toukan
Fix the warning below by calling rhashtable_lookup_fast. Also, make some code movements for better quality and human readability. [ 342.450870] WARNING: suspicious RCU usage [ 342.455856] 4.18.0-rc2+ #17 Tainted: G O [ 342.462210] - [ 342.467202] ./include