Re: [PATCH][net-next] net: increase MAX_GRO_SKBS to 64

On 7/2/18, David Miller wrote: > From: Li RongQing > Date: Mon, 2 Jul 2018 19:41:43 +0800 > >> After 07d78363dcffd [net: Convert NAPI gro list into a small hash table] >> there is 8 hash buckets, which allow more flows to be held for merging. >> >> keep each as original list length, so increase

Re: [PATCH ipsec-next] xfrm: Allow Set Mark to be Updated Using UPDSA

Hi Nathan, On Fri, 29 Jun 2018 15:07:10 -0700 Nathan Harold wrote: > Allow UPDSA to change "set mark" to permit > policy separation of packet routing decisions from > SA keying in systems that use mark-based routing. > > The set mark, used as a routing and firewall mark > for outbound packets,

Re: [PATCHv2 net-next 0/5] sctp: fully support for dscp and flowlabel per transport

On Mon, Jul 02, 2018 at 06:21:10PM +0800, Xin Long wrote: > Now dscp and flowlabel are set from sock when sending the packets, > but being multi-homing, sctp also supports for dscp and flowlabel > per transport, which is described in section 8.1.12 in RFC6458. > > v1->v2: > - define ip_queue_xmi

Re: [PATCH net] sctp: fix the issue that pathmtu may be set lower than MINSEGMENT

On Mon, Jul 02, 2018 at 07:45:12AM -0400, Neil Horman wrote: > On Mon, Jul 02, 2018 at 02:51:16PM +0800, Xin Long wrote: > > After commit b6c5734db070 ("sctp: fix the handling of ICMP Frag Needed > > for too small MTUs"), sctp_transport_update_pmtu would refetch pathmtu > > from the dst and set it

Re: [PATCH bpf v2 0/4] Bug fixes to the SKB TX path of AF_XDP

On Fri, Jun 29, 2018 at 09:48:16AM +0200, Magnus Karlsson wrote: > This patch set fixes three bugs in the SKB TX path of AF_XDP. > Details in the individual commits. > > The structure of the patch set is as follows: > > Patch 1: Fix for lost completion message > Patch 2-3: Fix for possible multip

Re: [PATCH net-next v2 0/2] tcp: fix high tail latencies in DCTCP

On Mon, Jul 2, 2018 at 5:39 PM Lawrence Brakmo wrote: > > When have observed high tail latencies when using DCTCP for RPCs as > compared to using Cubic. For example, in one setup there are 2 hosts > sending to a 3rd one, with each sender having 3 flows (1 stream, > 1 1MB back-to-back RPCs and 1 10

[PATCH ethtool] ethtool: ixgbe dump strings for security registers

Add the ixgbe's security configuration registers into the register dump. Signed-off-by: Shannon Nelson --- ixgbe.c | 26 ++ 1 file changed, 26 insertions(+) NOTE: Obviously this should wait until Intel accepts and pushes the related ixgbe patch and Dave accepts it

[PATCH next-queue] ixgbe: add ipsec security registers into ethtool register dump

Add the ixgbe's security configuration registers into the register dump. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/ne

Re: [PATCH net-next v2 1/2] tcp: notify when a delayed ack is sent

On Mon, Jul 2, 2018 at 2:39 PM, Lawrence Brakmo wrote: > > DCTCP depends on the CA_EVENT_NON_DELAYED_ACK and CA_EVENT_DELAYED_ACK > notifications to keep track if it needs to send an ACK for packets that > were received with a particular ECN state but whose ACK was delayed. > > Under some circumst

RE: [net] fq_codel: fix NULL pointer deref in fq_codel_reset

> -Original Message- > From: Cong Wang [mailto:xiyou.wangc...@gmail.com] > Sent: Monday, June 11, 2018 1:23 PM > To: Keller, Jacob E > Cc: Kirsher, Jeffrey T ; da...@davemloft.net; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > jogre...@redhat.com; Eric Dumazet > Sub

[PATCH v4,net-next] vlan: implement vlan id and protocol changes

vlan_changelink silently ignores attempts to change the vlan id or protocol id of an existing vlan interface. Implement by adding the new vlan id and protocol to the interface's vlan group and then removing the old vlan id and protocol from the vlan group. This avoids the netlink churn of deletin

[PATCH net] net/ipv6: Revert attempt to simplify route replace and append

From: David Ahern NetworkManager likes to manage linklocal prefix routes and does so with the NLM_F_APPEND flag, breaking attempts to simplify the IPv6 route code and by extension enable multipath routes with device only nexthops. Revert f34436a43092 and its followup 6eba08c3626b ("ipv6: Only em

Re: [PATCH net-next 08/10] r8169: remove rtl8169_set_speed_xmii

On 02.07.2018 23:21, Andrew Lunn wrote: >> -auto_nego |= ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM; > > This bit you probably want to keep. The PHY never says it support > Pause. The MAC needs to enable pause if the MAC supports pause. > Actually I assumed that phylib would do this f

[PATCH net-next v2 0/2] tcp: fix high tail latencies in DCTCP

When have observed high tail latencies when using DCTCP for RPCs as compared to using Cubic. For example, in one setup there are 2 hosts sending to a 3rd one, with each sender having 3 flows (1 stream, 1 1MB back-to-back RPCs and 1 10KB back-to-back RPCs). The following table shows the 99% and 99.9

[PATCH net-next v2 2/2] tcp: ack immediately when a cwr packet arrives

We observed high 99 and 99.9% latencies when doing RPCs with DCTCP. The problem is triggered when the last packet of a request arrives CE marked. The reply will carry the ECE mark causing TCP to shrink its cwnd to 1 (because there are no packets in flight). When the 1st packet of the next request a

[PATCH net-next v2 1/2] tcp: notify when a delayed ack is sent

DCTCP depends on the CA_EVENT_NON_DELAYED_ACK and CA_EVENT_DELAYED_ACK notifications to keep track if it needs to send an ACK for packets that were received with a particular ECN state but whose ACK was delayed. Under some circumstances, for example when a delayed ACK is sent with a data packet, D

Re: [PATCH net-next 07/10] r8169: migrate speed_down function to phylib

On 02.07.2018 23:20, Andrew Lunn wrote: > On Mon, Jul 02, 2018 at 09:37:08PM +0200, Heiner Kallweit wrote: >> Change rtl_speed_down() to use phylib. >> >> Signed-off-by: Heiner Kallweit >> --- >> drivers/net/ethernet/realtek/r8169.c | 33 +--- >> 1 file changed, 15 insert

Re: [PATCH net-next 02/10] r8169: use phy_resume/phy_suspend

On 02.07.2018 23:06, Andrew Lunn wrote: >> static void r8168_pll_power_down(struct rtl8169_private *tp) >> { >> if (r8168_check_dash(tp)) >> @@ -4510,7 +4469,8 @@ static void r8168_pll_power_down(struct >> rtl8169_private *tp) >> if (rtl_wol_pll_power_down(tp)) >> return;

Re: [PATCH net-next 2/2] tcp: ack immediately when a cwr packet arrives

On 7/2/18, 7:57 AM, "Neal Cardwell" wrote: On Sat, Jun 30, 2018 at 9:47 PM Lawrence Brakmo wrote: > I see two issues, one is that entering quickack mode as you > mentioned does not insure that it will still be on when the CWR > arrives. The second issue is that the problem occurs

Re: [PATCH net-next 01/10] r8169: add basic phylib support

On 02.07.2018 23:02, Andrew Lunn wrote: >> +static int r8169_mdio_read_reg(struct mii_bus *mii_bus, int phyaddr, int >> phyreg) >> +{ >> +struct rtl8169_private *tp = mii_bus->priv; >> + >> +return rtl_readphy(tp, phyreg); > > So there is no support for phyaddr? > Right, the chip can acc

Re: [PATCH net-next 1/2] tcp: notify when a delayed ack is sent

On 7/2/18, 8:18 AM, "netdev-ow...@vger.kernel.org on behalf of Neal Cardwell" wrote: On Fri, Jun 29, 2018 at 9:48 PM Lawrence Brakmo wrote: > > DCTCP depends on the CA_EVENT_NON_DELAYED_ACK and CA_EVENT_DELAYED_ACK > notifications to keep track if it needs to send an ACK for pac

Re: [PATCH net-next 0/7] net/ipv6: Fix route append and replace use cases

On 5/22/18 2:44 PM, David Ahern wrote: > On 5/22/18 12:46 PM, David Miller wrote: >> >> Ok, I'll apply this series. >> >> But if this breaks things for anyone in a practical way, I am unfortunately >> going to have to revert no matter how silly the current behavior may be. >> > > Understood. I hav

Re: [PATCH net-next 08/10] r8169: remove rtl8169_set_speed_xmii

> - auto_nego |= ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM; This bit you probably want to keep. The PHY never says it support Pause. The MAC needs to enable pause if the MAC supports pause. Andrew

Re: [PATCH net-next 07/10] r8169: migrate speed_down function to phylib

On Mon, Jul 02, 2018 at 09:37:08PM +0200, Heiner Kallweit wrote: > Change rtl_speed_down() to use phylib. > > Signed-off-by: Heiner Kallweit > --- > drivers/net/ethernet/realtek/r8169.c | 33 +--- > 1 file changed, 15 insertions(+), 18 deletions(-) > > diff --git a/driv

Re: [PATCH net-next 06/10] r8169: use phy_mii_ioctl

On Mon, Jul 02, 2018 at 09:37:05PM +0200, Heiner Kallweit wrote: > Switch to using phy_mii_ioctl(). > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew

Re: [PATCH bpf 3/3] bpf: undo prog rejection on read-only lock failure

On 07/02/2018 08:48 PM, Kees Cook wrote: > On Fri, Jun 29, 2018 at 4:47 PM, Daniel Borkmann wrote: >> On 06/29/2018 08:42 PM, Kees Cook wrote: >>> On Thu, Jun 28, 2018 at 2:34 PM, Daniel Borkmann >>> wrote: Kees suggested that if set_memory_*() can fail, we should annotate it with __mu

Re: [PATCH net-next 05/10] r8169: use phy_ethtool_nway_reset

On Mon, Jul 02, 2018 at 09:37:03PM +0200, Heiner Kallweit wrote: > Switch to using phy_ethtool_nway_reset(). > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 03/10] r8169: replace open-coded PHY soft reset with genphy_soft_reset

On Mon, Jul 02, 2018 at 09:36:58PM +0200, Heiner Kallweit wrote: > Use genphy_soft_reset() instead of open-coding a PHY soft reset. We have > to do an explicit PHY soft reset because some chips use the genphy driver > which uses a no-op as soft_reset callback. > > Signed-off-by: Heiner Kallweit

Re: [PATCH net-next 02/10] r8169: use phy_resume/phy_suspend

> static void r8168_pll_power_down(struct rtl8169_private *tp) > { > if (r8168_check_dash(tp)) > @@ -4510,7 +4469,8 @@ static void r8168_pll_power_down(struct rtl8169_private > *tp) > if (rtl_wol_pll_power_down(tp)) > return; > > - r8168_phy_power_down(tp); > +

Re: [PATCH net-next 01/10] r8169: add basic phylib support

> +static int r8169_mdio_read_reg(struct mii_bus *mii_bus, int phyaddr, int > phyreg) > +{ > + struct rtl8169_private *tp = mii_bus->priv; > + > + return rtl_readphy(tp, phyreg); So there is no support for phyaddr? It would be better to trap the phyaddr which are not supported and return

[PATCH net] r8169: fix mac address change

Network core refuses to change mac address because flag IFF_LIVE_ADDR_CHANGE isn't set. Set this missing flag. Fixes: 1f7aa2bc268e ("r8169: simplify rtl_set_mac_address") Reported-by: Corinna Vinschen Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 1 + 1 file changed,

Re: Regression introduced by "r8169: simplify rtl_set_mac_address"

On 02.07.2018 21:48, Corinna Vinschen wrote: > Hi, > > the patch 1f7aa2bc268e, "r8169: simplify rtl_set_mac_address", > introduced a regression found by trying to team a r8169 NIC. > Thanks for reporting! > Try the following (assuming the r8169 NIC is eth0): > > $ nmcli con add type team con-na

[PATCH wpan 2/2] net: mac802154: tx: expand tailroom if necessary

This patch is necessary if case of AF_PACKET or other socket interface which I am aware of it and didn't allocated the necessary room. Reported-by: David Palma Reported-by: Rabi Narayan Sahoo Signed-off-by: Alexander Aring --- net/mac802154/tx.c | 15 ++- 1 file changed, 14 inserti

[PATCH wpan 1/2] net: 6lowpan: fix reserved space for single frames

This patch fixes patch add handling to take care tail and headroom for single 6lowpan frames. We need to be sure we have a skb with the right head and tailroom for single frames. This patch do it by using skb_copy_expand() if head and tailroom is not enough allocated by upper layer. Bugzilla: http

[PATCH v2 net-next] openvswitch: kernel datapath clone action

Add 'clone' action to kernel datapath by using existing functions. When actions within clone don't modify the current flow, the flow key is not cloned before executing clone actions. This is a follow up patch for this incomplete work: https://patchwork.ozlabs.org/patch/722096/ v1 -> v2: Refactor

Regression introduced by "r8169: simplify rtl_set_mac_address"

Hi, the patch 1f7aa2bc268e, "r8169: simplify rtl_set_mac_address", introduced a regression found by trying to team a r8169 NIC. Try the following (assuming the r8169 NIC is eth0): $ nmcli con add type team con-name team0 ifname nm-team config \ '{"runner": {"name": "lacp"}, "link_watch": {"nam

[PATCH net-next 02/10] r8169: use phy_resume/phy_suspend

Use phy_resume() / phy_suspend() instead of open coding this functionality. The chip version specific differences are handled by the respective PHY drivers. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 48 +++- 1 file changed, 5 insertions(+),

[PATCH net-next 04/10] r8169: use phy_ethtool_(g|s)et_link_ksettings

Use phy_ethtool_(g|s)et_link_ksettings() for the respective ethtool_ops callbacks. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 35 +++- 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/dri

[PATCH net-next 09/10] r8169: remove mii_if_info member from struct rtl8169_private

The only remaining usage of the struct mii_if_info member is to store the information whether the chip is GMII-capable. So we can replace it with a simple flag. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 38 +--- 1 file changed, 7 insertions

[PATCH net-next 06/10] r8169: use phy_mii_ioctl

Switch to using phy_mii_ioctl(). Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 6006676b..311

[PATCH net-next 10/10] r8169: don't read chip phy status register

Instead of accessing the PHYstatus register we can use the information phylib stores in the phy_device structure. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/realtek/r816

[PATCH net-next 07/10] r8169: migrate speed_down function to phylib

Change rtl_speed_down() to use phylib. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 33 +--- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 311

[PATCH net-next 08/10] r8169: remove rtl8169_set_speed_xmii

We can remove rtl8169_set_speed_xmii() now that phylib handles all this. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 90 1 file changed, 90 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r

[PATCH net-next 05/10] r8169: use phy_ethtool_nway_reset

Switch to using phy_ethtool_nway_reset(). Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/Kconfig | 1 - drivers/net/ethernet/realtek/r8169.c | 9 + 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/ethernet/realtek/Kconfig b/drivers/net/ethernet/

[PATCH net-next 03/10] r8169: replace open-coded PHY soft reset with genphy_soft_reset

Use genphy_soft_reset() instead of open-coding a PHY soft reset. We have to do an explicit PHY soft reset because some chips use the genphy driver which uses a no-op as soft_reset callback. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 27 +--

[PATCH net-next 01/10] r8169: add basic phylib support

Add basic phylib support to r8169. All now unneeded old PHY handling code will be removed in subsequent patches. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/Kconfig | 1 + drivers/net/ethernet/realtek/r8169.c | 146 +-- 2 files changed, 115 insertion

Re: [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw

On Sat, Jun 30, 2018 at 3:13 AM Jiri Pirko wrote: > Okay. So that would allow either create a chain or "chain with > template". Once that is done, there would be no means to manipulate the > template. One can only remove the chain. > > What about refounting? I think it would make sense that this i

[PATCH net-next 00/10] r8169: add phylib support

Now that all the basic refactoring has been done we can add phylib support. This patch series was successfully tested on: RTL8168h RTL8168evl RTL8169sb Heiner Kallweit (10): r8169: add basic phylib support r8169: use phy_resume/phy_suspend r8169: replace open-coded PHY soft reset with genphy

Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

On 7/2/2018 6:32 PM, Alexander Duyck wrote: On Mon, Jul 2, 2018 at 7:46 AM Willem de Bruijn > wrote: On Mon, Jul 2, 2018 at 9:34 AM Willem de Bruijn mailto:willemdebruijn.ker...@gmail.com>> wrote: > > On Mon, Jul 2, 2018 at 1:30 AM

Re: KASAN: use-after-free Read in bpf_tcp_close

On 05/26/2018 01:54 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:    3fb48d881dbe Merge branch 'bpf-fib-mtu-check' > git tree:   bpf-next > console output: https://syzkaller.appspot.com/x/log.txt?x=15fc197780 > kernel config:  https://syzkaller.appsp

Re: KASAN: use-after-free Write in bpf_tcp_close

On 05/27/2018 01:06 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:    ff4fb475cea8 Merge branch 'btf-uapi-cleanups' > git tree:   bpf-next > console output: https://syzkaller.appspot.com/x/log.txt?x=12b3d57780 > kernel config:  https://syzkaller.appsp

Re: possible deadlock in bpf_tcp_close

On 05/28/2018 07:47 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:    7a1a98c171ea Merge branch 'bpf-sendmsg-hook' > git tree:   bpf-next > console output: https://syzkaller.appspot.com/x/log.txt?x=10fd82d780 > kernel config:  https://syzkaller.appspo

Re: [PATCH bpf 3/3] bpf: undo prog rejection on read-only lock failure

On Fri, Jun 29, 2018 at 4:47 PM, Daniel Borkmann wrote: > On 06/29/2018 08:42 PM, Kees Cook wrote: >> On Thu, Jun 28, 2018 at 2:34 PM, Daniel Borkmann >> wrote: >>> Kees suggested that if set_memory_*() can fail, we should annotate it with >>> __must_check, and all callers need to deal with it g

Re: [PATCH v4 net-next 0/9] Handle multiple received packets at each stage

On 02/07/18 16:40, David Ahern wrote: > Nice work. Have you looked at IPv6 support yet? I hadn't looked at it yet, no.  After a quick glance at ip6_rcv() and  ip6_rcv_finish(), it looks like it'd be basically the same as the IPv4  code in patches 7 and 8.  I'll probably add it in a followup when (

[PATCH net-next 1/2] selftests: forwarding: Test mirror-to-gretap w/ UL 802.1d

Test for "tc action mirred egress mirror" that mirrors to gretap when the underlay route points at a VLAN-unaware bridge (802.1d). Signed-off-by: Petr Machata --- .../net/forwarding/mirror_gre_bridge_1d.sh | 132 + 1 file changed, 132 insertions(+) create mode 100755

[PATCH net-next 2/2] selftests: forwarding: Test mirror-to-gretap w/ UL 802.1q

Test for "tc action mirred egress mirror" that mirrors to gretap when the underlay route points at a VLAN-aware bridge (802.1q). Signed-off-by: Petr Machata --- .../net/forwarding/mirror_gre_bridge_1q.sh | 126 + 1 file changed, 126 insertions(+) create mode 100755

[PATCH net-next 0/2] More mirror-to-gretap tests with bridge in UL

This patchset adds two more tests where the mirror-to-gretap has a bridge in underlay packet path, without a VLAN above or below that bridge. In patch #1, a non-VLAN-filtering bridge is tested. In patch #2, a VLAN-filtering bridge is tested. Petr Machata (2): selftests: forwarding: Test mirror

[PATCH net] tls: fix skb_to_sgvec returning unhandled error.

The current code does not inspect the return value of skb_to_sgvec. This can cause a nullptr kernel panic when the malformed sgvec is passed into the crypto request. Checking the return value of skb_to_sgvec and skipping decryption if it is negative fixes this problem. Fixes: c46234ebb4d1 ("tls:

[PATCH] lib: rhashtable: Correct self-assignment in rhashtable.c

In file lib/rhashtable.c line 777, skip variable is assigned to itself. The following error was observed: lib/rhashtable.c:777:41: warning: explicitly assigning value of variable of type 'int' to itself [-Wself-assign] error, forbidden warning: rhashtable.c:777 This error was found when compiling

RE: [External] Re: incomplete firmware-version shown in ethtool -i

Hi John, Thanks for your answer! -Original Message- From: John W. Linville [mailto:linvi...@tuxdriver.com] Sent: Monday, July 2, 2018 11:07 PM To: Gang Gang10 Liu Cc: netdev@vger.kernel.org Subject: [External] Re: incomplete firmware-version shown in ethtool -i On Wed, Jun 27, 2018

Re: [PATCH v4 net-next 0/9] Handle multiple received packets at each stage

On 7/2/18 9:11 AM, Edward Cree wrote: > This patch series adds the capability for the network stack to receive a > list of packets and process them as a unit, rather than handling each > packet singly in sequence. This is done by factoring out the existing > datapath code at each layer and wrap

Re: Compiler warnings in kernel 4.14.51

On 7/1/18 2:35 PM, Enrico Mioso wrote: > Hello! > > While compiling kernel 4.14.51 I got the following warnings: > CC net/core/dev.o > net/core/dev.c: In function 'validate_xmit_skb_list': > net/core/dev.c:3121:15: warning: 'tail' may be used uninitialized in this > function [-Wmaybe-uniniti

Re: [PATCH net-next 1/2] tcp: notify when a delayed ack is sent

On Fri, Jun 29, 2018 at 9:48 PM Lawrence Brakmo wrote: > > DCTCP depends on the CA_EVENT_NON_DELAYED_ACK and CA_EVENT_DELAYED_ACK > notifications to keep track if it needs to send an ACK for packets that > were received with a particular ECN state but whose ACK was delayed. > > Under some circumst

Re: incomplete firmware-version shown in ethtool -i

On Wed, Jun 27, 2018 at 07:54:39AM +, Gang Gang10 Liu wrote: > Dear, > > I study that the ethtool only can show 31 characters firmware version, is it > NIC driver not followed ethtool spec or > Can we have any other way to get the full firmware version? > I think the bnxt team is doing what

[PATCH v4 net-next 9/9] net: don't bother calling list RX functions on empty lists

Generally the check should be very cheap, as the sk_buff_head is in cache. Signed-off-by: Edward Cree --- net/core/dev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 4c5ebfab9bc8..d6084b0cd9ce 100644 --- a/net/core/dev.c +++ b/

[PATCH v4 net-next 8/9] net: ipv4: listify ip_rcv_finish

ip_rcv_finish_core(), if it does not drop, sets skb->dst by either early demux or route lookup. The last step, calling dst_input(skb), is left to the caller; in the listified case, we split to form sublists with a common dst, but then ip_sublist_rcv_finish() just calls dst_input(skb) in a loop.

[PATCH v4 net-next 7/9] net: ipv4: listified version of ip_rcv

Also involved adding a way to run a netfilter hook over a list of packets. Rather than attempting to make netfilter know about lists (which would be a major project in itself) we just let it call the regular okfn (in this case ip_rcv_finish()) for any packets it steals, and have it give us back

[PATCH v4 net-next 6/9] net: core: propagate SKB lists through packet_type lookup

__netif_receive_skb_core() does a depressingly large amount of per-packet work that can't easily be listified, because the another_round looping makes it nontrivial to slice up into smaller functions. Fortunately, most of that work disappears in the fast path: * Hardware devices generally don't

[PATCH v4 net-next 5/9] net: core: another layer of lists, around PF_MEMALLOC skb handling

First example of a layer splitting the list (rather than merely taking individual packets off it). Involves new list.h function, list_cut_before(), like list_cut_position() but cuts on the other side of the given entry. Signed-off-by: Edward Cree --- include/linux/list.h | 30 +

[PATCH v4 net-next 2/9] sfc: batch up RX delivery

Improves packet rate of 1-byte UDP receives by up to 10%. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/efx.c| 12 drivers/net/ethernet/sfc/net_driver.h | 3 +++ drivers/net/ethernet/sfc/rx.c | 7 ++- 3 files changed, 21 insertions(+), 1 deletion(-)

[PATCH v4 net-next 4/9] net: core: Another step of skb receive list processing

netif_receive_skb_list_internal() now processes a list and hands it on to the next function. Signed-off-by: Edward Cree --- net/core/dev.c | 61 +- 1 file changed, 56 insertions(+), 5 deletions(-) diff --git a/net/core/dev.c b/net/core/de

[PATCH v4 net-next 1/9] net: core: trivial netif_receive_skb_list() entry point

Just calls netif_receive_skb() in a loop. Signed-off-by: Edward Cree --- include/linux/netdevice.h | 1 + net/core/dev.c| 19 +++ 2 files changed, 20 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index c6b377a15869..e104b2e4a735 10

[PATCH v4 net-next 3/9] net: core: unwrap skb list receive slightly further

Signed-off-by: Edward Cree --- include/trace/events/net.h | 7 +++ net/core/dev.c | 4 +++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/trace/events/net.h b/include/trace/events/net.h index 9c886739246a..00aa72ce0e7c 100644 --- a/include/trace/events/net

Re: [PATCHv2 net-next 2/2] selftests: add a selftest for directed broadcast forwarding

On 7/2/18 12:30 AM, Xin Long wrote: > +ping_ipv4() > +{ > + sysctl_set net.ipv4.icmp_echo_ignore_broadcasts 0 > + bc_forwarding_disable > + ping_test $h1 198.51.100.255 > + > + iptables -A INPUT -i vrf-r1 -p icmp -j DROP > + bc_forwarding_restore > + bc_forwarding_enable > +

[PATCH v4 net-next 0/9] Handle multiple received packets at each stage

This patch series adds the capability for the network stack to receive a list of packets and process them as a unit, rather than handling each packet singly in sequence. This is done by factoring out the existing datapath code at each layer and wrapping it in list handling code. The motivation

Re: [PATCHv2 net-next 1/2] route: add support for directed broadcast forwarding

On 7/2/18 12:30 AM, Xin Long wrote: > @@ -2143,6 +2149,10 @@ static int devinet_conf_proc(struct ctl_table *ctl, > int write, > if ((new_value == 0) && (old_value != 0)) > rt_cache_flush(net); > > + if (i == IPV4_DEVCONF_BC_FORWARDI

Re: [PATCH v3 net-next 7/9] net: ipv4: listified version of ip_rcv

On 29/06/18 23:08, kbuild test robot wrote: >net//ipv4/ip_input.c: In function 'ip_sublist_rcv': >>> net//ipv4/ip_input.c:524:14: warning: passing argument 6 of 'NF_HOOK_LIST' >>> from incompatible pointer type >head, dev, NULL, ip_rcv_finish); > ^ >In file inc

Re: [PATCH net-next 2/2] tcp: ack immediately when a cwr packet arrives

On Sat, Jun 30, 2018 at 9:47 PM Lawrence Brakmo wrote: > I see two issues, one is that entering quickack mode as you > mentioned does not insure that it will still be on when the CWR > arrives. The second issue is that the problem occurs right after the > receiver sends a small reply which results

答复: [PATCH][net-next] net: increase MAX_GRO_SKBS to 64

发件人: David Miller [da...@davemloft.net] 发送时间: 2018年7月2日 19:44 收件人: Li,Rongqing 抄送: netdev@vger.kernel.org; eric.duma...@gmail.com 主题: Re: [PATCH][net-next] net: increase MAX_GRO_SKBS to 64 From: Li RongQing Date: Mon, 2 Jul 2018 19:41:43 +0800 >> After

Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

On Mon, Jul 2, 2018 at 9:34 AM Willem de Bruijn wrote: > > On Mon, Jul 2, 2018 at 1:30 AM Boris Pismenny wrote: > > > > > > > > On 7/2/2018 4:45 AM, Willem de Bruijn wrote: > > >>> I've noticed that we could get cleaner code in our driver if we remove > > >>> these two lines from net/ipv4/udp_off

[PATCH net-next v3 5/5] net: aquantia: bump driver version

Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/ver.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h b/drivers/net/ethernet/aquantia/atlantic/ver.h index a445de6..94efc64 100644 --- a/drivers/net/ethern

[PATCH net-next v3 3/5] net: aquantia: Implement rx/tx flow control ethtools callback

Runtime change of pause frame configuration (rx/tx flow control) via ethtool. Signed-off-by: Igor Russkikh --- .../net/ethernet/aquantia/atlantic/aq_ethtool.c| 42 ++ drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 6 +++- .../aquantia/atlantic/hw_atl/hw_atl_utils.c

[PATCH net-next v3 2/5] net: aquantia: Improve adapter init/deinit logic

We now pass link drop status to FW on init/deinit. This is required to inform FW that driver took/released a control on link. FW then will manage its own state and device power profile based on this information. To improve management we remove mpi_set function which ambiguously took both state and

[PATCH net-next v3 1/5] net: aquantia: Ethtool based ring size configuration

From: Anton Mikaev Implemented ring size setup, min/max validation and reconfiguration in runtime. Signed-off-by: Anton Mikaev Signed-off-by: Igor Russkikh --- .../net/ethernet/aquantia/atlantic/aq_ethtool.c| 61 ++ drivers/net/ethernet/aquantia/atlantic/aq_hw.h |

[PATCH net-next v3 0/5] net: aquantia: various ethtool ops implementation

In this patchset Anton Mikaev and I added some useful ethtool operations: - ring size changes - link renegotioation - flow control management The patch also improves init/deinit sequence. V3 changes: - After review and analysis it is clear that rtnl lock (which is captured by default on ethtoo

[PATCH net-next v3 4/5] net: aquantia: Add renegotiate ethtool operation support

From: Anton Mikaev Adds ethtool -r|--negotiate operation support. It triggers special control bit on FW interface causing FW to restart link negotiation. Signed-off-by: Igor Russkikh Signed-off-by: Anton Mikaev --- .../net/ethernet/aquantia/atlantic/aq_ethtool.c| 14 + drivers/net

Re: [PATCH net-next] net: phy: realtek: add support for RTL8211C

From: Heiner Kallweit Date: Mon, 2 Jul 2018 08:08:13 +0200 > RTL8211C has an issue when operating in Gigabit slave mode, therefore > genphy driver can't be used. See also this U-boot change. > https://lists.denx.de/pipermail/u-boot/2016-March/249712.html > > Add a PHY driver for this chip with t

Re: [PATCH net-next 1/1] net sched actions: add extack messages in pedit action

From: Roman Mashak Date: Mon, 2 Jul 2018 00:02:02 -0400 > Signed-off-by: Roman Mashak Applied.

Re: [PATCH] net: expose sk wmem in sock_exceed_buf_limit tracepoint

From: Yafang Shao Date: Sun, 1 Jul 2018 23:31:30 +0800 > Currently trace_sock_exceed_buf_limit() only show rmem info, > but wmem limit may also be hit. > So expose wmem info in this tracepoint as well. > > Regarding memcg, I think it is better to introduce a new tracepoint(if > that is needed),

Re: [PATCH net-next] net: phy: realtek: add missing entry for RTL8211 to mdio_device_id table

From: Heiner Kallweit Date: Sun, 1 Jul 2018 19:14:58 +0200 > When adding support for RTL8211 I forgot to update the mdio_device_id > table. > > Signed-off-by: Heiner Kallweit > Fixes: d241d4aac93f ("net: phy: realtek: add support for RTL8211") Applied.

Re: [PATCH net-next] r8169: remove old PHY reset hack

From: Heiner Kallweit Date: Sun, 1 Jul 2018 00:25:19 +0200 > This hack (affecting the non-PCIe models only) was introduced in 2004 > to deal with link negotiation failures in 1GBit mode. Based on a > comment in the r8169 vendor driver I assume the issue affects RTL8169sb > in combination with par

Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

On Mon, Jul 2, 2018 at 1:30 AM Boris Pismenny wrote: > > > > On 7/2/2018 4:45 AM, Willem de Bruijn wrote: > >>> I've noticed that we could get cleaner code in our driver if we remove > >>> these two lines from net/ipv4/udp_offload.c: > >>> if (skb_is_gso(segs)) > >>>mss *= skb_shin

Re: [PATCH net] sctp: fix the issue that pathmtu may be set lower than MINSEGMENT

On Mon, Jul 02, 2018 at 02:51:16PM +0800, Xin Long wrote: > After commit b6c5734db070 ("sctp: fix the handling of ICMP Frag Needed > for too small MTUs"), sctp_transport_update_pmtu would refetch pathmtu > from the dst and set it to transport's pathmtu without any check. > > The new pathmtu may be

Re: [PATCH][net-next] net: increase MAX_GRO_SKBS to 64

From: Li RongQing Date: Mon, 2 Jul 2018 19:41:43 +0800 > After 07d78363dcffd [net: Convert NAPI gro list into a small hash table] > there is 8 hash buckets, which allow more flows to be held for merging. > > keep each as original list length, so increase MAX_GRO_SKBS to 64 > > Signed-off-by: L

[PATCH][net-next] net: increase MAX_GRO_SKBS to 64

After 07d78363dcffd [net: Convert NAPI gro list into a small hash table] there is 8 hash buckets, which allow more flows to be held for merging. keep each as original list length, so increase MAX_GRO_SKBS to 64 Signed-off-by: Li RongQing --- net/core/dev.c | 3 +-- 1 file changed, 1 insertion(+

Re: [PATCHv2 net] ipvlan: call dev_change_flags when ipvlan mode is reset

From: Hangbin Liu Date: Sun, 1 Jul 2018 16:21:21 +0800 > After we change the ipvlan mode from l3 to l2, or vice versa, we only > reset IFF_NOARP flag, but don't flush the ARP table cache, which will > cause eth->h_dest to be equal to eth->h_source in ipvlan_xmit_mode_l2(). > Then the message wil

Re: [PATCH net] net: fix use-after-free in GRO with ESP

From: Sabrina Dubroca Date: Sat, 30 Jun 2018 17:38:55 +0200 > Since the addition of GRO for ESP, gro_receive can consume the skb and > return -EINPROGRESS. In that case, the lower layer GRO handler cannot > touch the skb anymore. > > Commit 5f114163f2f5 ("net: Add a skb_gro_flush_final helper.")

Re: [PATCH net] tcp: prevent bogus FRTO undos with non-SACK flows

On Sat, 30 Jun 2018, Neal Cardwell wrote: > As I mentioned, I ran your patch through all our team's TCP > packetdrill tests, and it passes all of the tests. One of our tests > needed updating, because if there is a non-SACK connection with a > spurious RTO due to a delayed flight of ACKs then the

[PATCHv2 net-next 5/5] sctp: check for ipv6_pinfo legal sndflow with flowlabel in sctp_v6_get_dst

The transport with illegal flowlabel should not be allowed to send packets. Other transport protocols already denies this. Signed-off-by: Xin Long --- net/sctp/ipv6.c | 9 + 1 file changed, 9 insertions(+) diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c index 772513d..d83ddc4 100644 ---

[PATCHv2 net-next 1/5] ipv4: add __ip_queue_xmit() that supports tos param

This patch introduces __ip_queue_xmit(), through which the callers can pass tos param into it without having to set inet->tos. For ipv6, ip6_xmit() already allows passing tclass parameter. It's needed when some transport protocol doesn't use inet->tos, like sctp's per transport dscp, which will be

  1   2   >