________________________________________ 发件人: David Miller [da...@davemloft.net] 发送时间: 2018年7月2日 19:44 收件人: Li,Rongqing 抄送: netdev@vger.kernel.org; eric.duma...@gmail.com 主题: Re: [PATCH][net-next] net: increase MAX_GRO_SKBS to 64
From: Li RongQing <lirongq...@baidu.com> Date: Mon, 2 Jul 2018 19:41:43 +0800 >> After 07d78363dcffd [net: Convert NAPI gro list into a small hash table] > > there is 8 hash buckets, which allow more flows to be held for merging. > > > > keep each as original list length, so increase MAX_GRO_SKBS to 64 > > > > Signed-off-by: Li RongQing <lirongq...@baidu.com> > I would like to hear some feedback from Eric, 64 might be too big. I think we should limit each list length to 8 skb , insteading of this change if there is only one flow, changing MAX_GRO_SKBS to 64 maybe generate large delay. if keep total 8 skb, for multiple flow, hash table maybe unable to improve the performance -RongQing
