On Wed, Jun 06, 2018 at 05:25:51PM -0700, Maciej Żenczykowski wrote:
> Yes, it does, we found this internally last night and been debating
> what to do about it.
>
> Fundamentally what it points out is that prior to this patch CRIU
> could get the host into an inconsistent state.
Yes, I understan
From: Xiangning Yu
There is a timing issue under active-standy mode, when bond_enslave() is
called, bond->params.primary might not be initialized yet.
Any time the primary slave string changes, bond->force_primary should be
set to true to make sure the primary becomes the active slave.
Signed-o
By passing a limit of 2 bytes to strncat, GCC 8 thinks that strncat is
limited to writing fewer bytes than what it's supposed to append to the
name here. However, strncat appends n+1 bytes to the destination, so this
is correct even though it doesn't look right.
Since the bounds are checked on the
Yes, it does, we found this internally last night and been debating
what to do about it.
Fundamentally what it points out is that prior to this patch CRIU
could get the host into an inconsistent state.
It inserts all the sockets into the hashtables with SO_REUSEADDR set,
and then (potentially) cle
This patch breaks CRIU tests:
= Run zdtm/transition/socket-tcp6 in h =
Start test
./socket-tcp6 --pidfile=socket-tcp6.pid --outfile=socket-tcp6.out
start time for zdtm/transition/socket-tcp6: 0.90
Run criu dump
Run criu restore
=[log]=> dump/zdtm/transition/
On 6/6/2018 12:13 PM, Willem de Bruijn wrote:
> On Wed, Jun 6, 2018 at 3:08 PM, Samudrala, Sridhar
> wrote:
>>
>> On 6/6/2018 11:56 AM, Willem de Bruijn wrote:
>>>
>>> On Tue, Jun 5, 2018 at 4:38 AM, Amritha Nambiar
>>> wrote:
This patch adds support to pick Tx queue based on the Rx que
By passing a limit of 2 bytes to strncat, strncat is limited to writing
fewer bytes than what it's supposed to append to the name here.
Since the bounds are checked on the line above this, just remove the string
bounds checks entirely since they're unneeded.
Signed-off-by: Sultan Alsawaf
---
ne
On 6/5/2018 10:57 AM, Tom Herbert wrote:
>
>
> On Tue, Jun 5, 2018 at 1:38 AM, Amritha Nambiar
> mailto:amritha.namb...@intel.com>> wrote:
>
> This patch adds support to pick Tx queue based on the Rx queue(s) map
> configuration set by the admin through the sysfs attribute
> for each
On Wed, 6 Jun 2018 15:19:30 +0300
"Michael S. Tsirkin" wrote:
> On Tue, Jun 05, 2018 at 08:51:18PM -0700, Stephen Hemminger wrote:
> > > I think the push back was with the usage of the delay, not bringing up
> > > the primary/standby
> > > device in the name change event handler.
> > > Can't net
On Wed, 6 Jun 2018 14:54:04 -0700
"Samudrala, Sridhar" wrote:
> On 6/6/2018 2:24 PM, Stephen Hemminger wrote:
> > On Wed, 6 Jun 2018 15:30:27 +0300
> > "Michael S. Tsirkin" wrote:
> >
> >> On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
> >>> Tue, Jun 05, 2018 at 05:42:31AM CEST,
On Thu, 7 Jun 2018 00:47:52 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Jun 06, 2018 at 02:24:47PM -0700, Stephen Hemminger wrote:
> > On Wed, 6 Jun 2018 15:30:27 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
> > > > Tue, Jun 05,
On Thu, 7 Jun 2018 00:30:21 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Jun 06, 2018 at 02:16:20PM -0700, Stephen Hemminger wrote:
> > On Tue, 5 Jun 2018 23:11:37 -0700
> > "Samudrala, Sridhar" wrote:
> >
> > > On 6/5/2018 11:00 PM, Stephen Hemminger wrote:
> > > > On Tue, 5 Jun 2018 22:39:
On 6/6/2018 2:24 PM, Stephen Hemminger wrote:
On Wed, 6 Jun 2018 15:30:27 +0300
"Michael S. Tsirkin" wrote:
On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
The net failover should be a simple library, not
On Wed, Jun 06, 2018 at 02:24:47PM -0700, Stephen Hemminger wrote:
> On Wed, 6 Jun 2018 15:30:27 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
> > > Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
> > > >The net fai
On Wed, Jun 06, 2018 at 02:16:20PM -0700, Stephen Hemminger wrote:
> On Tue, 5 Jun 2018 23:11:37 -0700
> "Samudrala, Sridhar" wrote:
>
> > On 6/5/2018 11:00 PM, Stephen Hemminger wrote:
> > > On Tue, 5 Jun 2018 22:39:12 -0700
> > > "Samudrala, Sridhar" wrote:
> > >
> > >> On 6/5/2018 8:51 PM,
On Wed, 6 Jun 2018 09:25:12 +0200
Jiri Pirko wrote:
> Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
> >The net failover should be a simple library, not a virtual
> >object with function callbacks (see callback hell).
>
> Why just a library? It should do a common thing
On Wed, 6 Jun 2018 15:30:27 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
> > Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
> > >The net failover should be a simple library, not a virtual
> > >object with function callb
On Tue, 5 Jun 2018 23:11:37 -0700
"Samudrala, Sridhar" wrote:
> On 6/5/2018 11:00 PM, Stephen Hemminger wrote:
> > On Tue, 5 Jun 2018 22:39:12 -0700
> > "Samudrala, Sridhar" wrote:
> >
> >> On 6/5/2018 8:51 PM, Stephen Hemminger wrote:
> >>> On Tue, 5 Jun 2018 16:52:22 -0700
> >>> "Samudrala
Begin forwarded message:
Date: Wed, 06 Jun 2018 18:39:54 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 199951] New: Packets send with libpcap via veth started to have
trailer, (incorrect) FCS and are dropped
https://bugzilla.kernel.org/show_bug.
On Wed, Jun 6, 2018 at 2:11 PM, David Miller wrote:
> From: Alexander Aring
> Date: Wed, 6 Jun 2018 14:09:20 -0400
>
>> okay, then you want to have this patch for net-next? As an optimization?
>>
>> Of course, when it's open again.
>
> Like you, I have questions about where this adjustment is app
On Wed, Jun 6, 2018 at 10:51 AM, Toke Høiland-Jørgensen wrote:
> Jakub Kicinski writes:
>
>> On Wed, 06 Jun 2018 14:43:39 +0200, Toke Høiland-Jørgensen wrote:
>>> Add two new helper functions to trace_helpers that supports polling
>>> multiple perf file descriptors for events. These are used to th
On Wed, Jun 6, 2018 at 3:08 PM, Samudrala, Sridhar
wrote:
>
> On 6/6/2018 11:56 AM, Willem de Bruijn wrote:
>>
>> On Tue, Jun 5, 2018 at 4:38 AM, Amritha Nambiar
>> wrote:
>>>
>>> This patch adds support to pick Tx queue based on the Rx queue(s) map
>>> configuration set by the admin through the
On 6/6/2018 11:56 AM, Willem de Bruijn wrote:
On Tue, Jun 5, 2018 at 4:38 AM, Amritha Nambiar
wrote:
This patch adds support to pick Tx queue based on the Rx queue(s) map
configuration set by the admin through the sysfs attribute
for each Tx queue. If the user configuration for receive queue(
On Wed, Jun 6, 2018 at 6:50 PM, Jakub Kicinski wrote:
> On Wed, 6 Jun 2018 08:12:20 +0300, Or Gerlitz wrote:
>> On Tue, Jun 5, 2018 at 9:59 PM, Jakub Kicinski wrote:
>> > But the correct fix is to remove egdev crutch completely IMO.
>> Not against it, sometimes designs should change and be repl
On Tue, Jun 5, 2018 at 4:38 AM, Amritha Nambiar
wrote:
> This patch adds support to pick Tx queue based on the Rx queue(s) map
> configuration set by the admin through the sysfs attribute
> for each Tx queue. If the user configuration for receive queue(s) map
> does not apply, then the Tx queue se
My Dear Friend.
I am Mr. Mohammed Ahmed, a banker in Bank of Africa Burkina Faso West
Africa, Please i need your assistance to transfer an abandoned sum of
13.5 Millions USD into your account if you can permit and after the
transaction is over 50% will be for you and 50% for me.
No risk involved
From: Alexander Aring
Date: Wed, 6 Jun 2018 14:09:20 -0400
> okay, then you want to have this patch for net-next? As an optimization?
>
> Of course, when it's open again.
Like you, I have questions about where this adjustment is applied and
why. So I'm not sure yet.
For example, only IPV6 rea
Hi,
On Wed, Jun 06, 2018 at 01:53:39PM -0400, David Miller wrote:
> From: Alexander Aring
> Date: Tue, 5 Jun 2018 18:04:04 -0400
>
> > This patch adds care about tailroom length for allocate a skb from ipv6
> > level stack. In case of 6lowpan we had the problem the skb runs into a
> > skb_over_
From: Doron Roberts-Kedes
Date: Wed, 6 Jun 2018 09:33:28 -0700
> strp_unpause queues strp_work in order to parse any messages that
> arrived while the strparser was paused. However, the process invoking
> strp_unpause could eagerly parse a buffered message itself if it held
> the sock lock.
>
>
Add an example program showing how to sample packets from XDP using the
perf event buffer. The example userspace program just prints the ethernet
header for every packet sampled.
Reviewed-by: Jakub Kicinski
Signed-off-by: Toke Høiland-Jørgensen
---
samples/bpf/Makefile |4 +
s
On Wednesday, June 6, 2018 12:58:29 PM EDT Richard Guy Briggs wrote:
> Create a new audit record AUDIT_CONTAINER to document the audit
> container identifier of a process if it is present.
>
> Called from audit_log_exit(), syscalls are covered.
>
> A sample raw event:
> type=SYSCALL msg=audit(151
Add two new helper functions to trace_helpers that supports polling
multiple perf file descriptors for events. These are used to the XDP
perf_event_output example, which needs to work with one perf fd per CPU.
Reviewed-by: Jakub Kicinski
Signed-off-by: Toke Høiland-Jørgensen
---
tools/testing/s
From: Xiangning Yu
Date: Wed, 6 Jun 2018 03:18:23 -0700
> diff --git a/drivers/net/bonding/bond_options.c
> b/drivers/net/bonding/bond_options.c
> index 58c705f..b594bae 100644
> --- a/drivers/net/bonding/bond_options.c
> +++ b/drivers/net/bonding/bond_options.c
> @@ -1142,6 +1142,7 @@ static int
From: Jakub Kicinski
Date: Tue, 5 Jun 2018 14:27:00 -0700
> On Tue, 05 Jun 2018 15:06:40 -0400 (EDT), David Miller wrote:
>> From: Jakub Kicinski
>> Date: Tue, 5 Jun 2018 11:57:47 -0700
>>
>> > Do we still care about correctness and not breaking backward
>> > compatibility?
>>
>> Jakub let m
From: Alexander Aring
Date: Tue, 5 Jun 2018 18:04:04 -0400
> This patch adds care about tailroom length for allocate a skb from ipv6
> level stack. In case of 6lowpan we had the problem the skb runs into a
> skb_over_panic() in some special length cases. The root was there was no
> tailroom allo
Jakub Kicinski writes:
> On Wed, 06 Jun 2018 14:43:39 +0200, Toke Høiland-Jørgensen wrote:
>> Add two new helper functions to trace_helpers that supports polling
>> multiple perf file descriptors for events. These are used to the XDP
>> perf_event_output example, which needs to work with one perf
On Wed, Jun 6, 2018 at 1:13 PM Felix Manlunas wrote:
>
> On Mon, May 21, 2018 at 10:39:20AM -0700, Felix Manlunas wrote:
> > The following changes since commit 2a9b2cf50fb32e36e4fc1586c2f6f1421913b553:
> >
> > Merge branch 'for-upstreaming-v1.7.2' of
> > https://github.com/felix-cavium/linux-fi
On Mon, May 21, 2018 at 10:39:20AM -0700, Felix Manlunas wrote:
> The following changes since commit 2a9b2cf50fb32e36e4fc1586c2f6f1421913b553:
>
> Merge branch 'for-upstreaming-v1.7.2' of
> https://github.com/felix-cavium/linux-firmware (2018-05-18 08:35:22 -0400)
>
> are available in the git
On Wed, 06 Jun 2018 14:43:39 +0200, Toke Høiland-Jørgensen wrote:
> Add two new helper functions to trace_helpers that supports polling
> multiple perf file descriptors for events. These are used to the XDP
> perf_event_output example, which needs to work with one perf fd per CPU.
>
> Signed-off-b
On Wed, 06 Jun 2018 14:43:39 +0200, Toke Høiland-Jørgensen wrote:
> Add an example program showing how to sample packets from XDP using the
> perf event buffer. The example userspace program just prints the ethernet
> header for every packet sampled.
>
> Signed-off-by: Toke Høiland-Jørgensen
Loo
strp_unpause queues strp_work in order to parse any messages that
arrived while the strparser was paused. However, the process invoking
strp_unpause could eagerly parse a buffered message itself if it held
the sock lock.
__strp_unpause is an alternative to strp_pause that avoids the scheduling
ove
Hi all,
The patch "xen-netfront: Fix race between device setup and open" seems
to have introduced a regression preventing setting MTU's larger than
1500. We experienced this downstream with Container Linux and
confirmed with Fedora 28 as well.
It's commit f599c64fdf7d9c108e8717fb04bc41c680120da4
Hi,
On Wed, Jun 06, 2018 at 12:41:53PM +0200, Kristian Evensen wrote:
> Hi,
>
> I am experiencing the same issue on a PC Engines APU2 running kernel
> 4.14.34, both with and without hardware encryption. With hw.
> encryption, the crash occurs within 2-4 hours. Without hw. encryption,
> it takes 7
Commit f269099a7e7a ("tools/bpf: add a selftest for
bpf_get_current_cgroup_id() helper") added a test
for bpf_get_current_cgroup_id() helper. The bpf program
is attached to tracepoint syscalls/sys_enter_nanosleep
and will record the cgroup id if the tracepoint is hit.
The test program creates a cgr
On Wed, 6 Jun 2018 10:59:30 +0300, Paul Blakey wrote:
> Maybe we can apply my patch logic of still trying the egress dev if the
> block has a single device, and not shared. Is that ok with you?
I don't remember that patch but sounds pretty bad.
> You're patch seems good as an add on, but the egr
On Wed, 6 Jun 2018 08:12:20 +0300, Or Gerlitz wrote:
> On Tue, Jun 5, 2018 at 9:59 PM, Jakub Kicinski wrote:
> > On Tue, 5 Jun 2018 11:57:47 -0700, Jakub Kicinski wrote:
> >> On Tue, 5 Jun 2018 11:04:03 +0300, Paul Blakey wrote:
> >> > When using a vxlan device as the ingress dev, we count it
On Wed, 6 Jun 2018 08:15:27 +0300, Or Gerlitz wrote:
> On Wed, Jun 6, 2018 at 12:27 AM, Jakub Kicinski wrote:
> > On Tue, 05 Jun 2018 15:06:40 -0400 (EDT), David Miller wrote:
> >> From: Jakub Kicinski
> >> Date: Tue, 5 Jun 2018 11:57:47 -0700
> >>
> >> > Do we still care about correctness an
net/sched: add skbprio scheduler
Skbprio (SKB Priority Queue) is a queuing discipline that prioritizes IPv4
and IPv6 packets according to their skb->priority field. Although Skbprio can
be employed in any scenario in which a higher skb->priority field means a
higher priority packet, Skbprio was co
From: Willem de Bruijn
Tun, tap, virtio, packet and uml vector all use struct virtio_net_hdr
to communicate packet metadata to userspace.
For skbuffs with vlan, the first two return the packet as it may have
existed on the wire, inserting the VLAN tag in the user buffer. Then
virtio_net_hdr.csu
On Mon, Jun 04, 2018 at 11:06:40AM -0400, David Miller wrote:
> From: Tejaswi Tanikella
> Date: Fri, 1 Jun 2018 19:35:41 +0530
>
> > On receiving a IGMPv2/v3 query, based on max_delay set in the header a
> > timer is started to send out a response after a random time within
> > max_delay. If the
On Wed, 2018-06-06 at 16:28 +0300, Kirill Tkhai wrote:
> On 06.06.2018 16:16, Paolo Abeni wrote:
> > KCM removes the packets from sk_receive_queue in requeue_rx_msgs()
> >
> > without acquiring any lock. Moreover, in R() when the MSG_PEEK
> > flag is not present, the skb is peeked and dequeued wit
On 06.06.2018 16:16, Paolo Abeni wrote:
> KCM removes the packets from sk_receive_queue in requeue_rx_msgs()
>
> without acquiring any lock. Moreover, in R() when the MSG_PEEK
> flag is not present, the skb is peeked and dequeued with two
> separate, non-atomic, calls.
>
> The above create room f
KCM removes the packets from sk_receive_queue in requeue_rx_msgs()
without acquiring any lock. Moreover, in R() when the MSG_PEEK
flag is not present, the skb is peeked and dequeued with two
separate, non-atomic, calls.
The above create room for races, which SYZBOT has been able to
exploit, causi
Add two new helper functions to trace_helpers that supports polling
multiple perf file descriptors for events. These are used to the XDP
perf_event_output example, which needs to work with one perf fd per CPU.
Signed-off-by: Toke Høiland-Jørgensen
---
tools/testing/selftests/bpf/trace_helpers.c
Add an example program showing how to sample packets from XDP using the
perf event buffer. The example userspace program just prints the ethernet
header for every packet sampled.
Signed-off-by: Toke Høiland-Jørgensen
---
samples/bpf/Makefile |4 +
samples/bpf/xdp_sample_pkts_ke
Em Tue, Jun 05, 2018 at 02:25:48PM -0700, Martin KaFai Lau escreveu:
> On Thu, Apr 19, 2018 at 04:40:34PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Apr 18, 2018 at 03:55:56PM -0700, Martin KaFai Lau escreveu:
> > > This patch introduces BPF Type Format (BTF).
> > >
> > > BTF (BPF Type For
On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
> Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
> >The net failover should be a simple library, not a virtual
> >object with function callbacks (see callback hell).
>
> Why just a library? It should do a common t
David Beckett writes:
> On 04/06/18 17:33, Toke Høiland-Jørgensen wrote:
>> +
>> +#define SAMPLE_SIZE 64ul
>> +
> The program currently cannot sample minimum sized packets, as the 4 Byte
> crc checksum isnt present in ctx,
> may be better to use 60ul sample size to allow for these packets to be
Hi,
On Wed, 2018-06-06 at 13:25 +0300, Kirill Tkhai wrote:
> Hi, Paolo,
>
> below is couple my thoughts about this.
>
> On 06.06.2018 12:44, Paolo Abeni wrote:
> > On Tue, 2018-06-05 at 18:06 +0200, Paolo Abeni wrote:
> > > On Tue, 2018-06-05 at 08:35 -0700, Tom Herbert wrote:
> > > > Paolo, tha
On Tue, Jun 05, 2018 at 08:51:18PM -0700, Stephen Hemminger wrote:
> > I think the push back was with the usage of the delay, not bringing up the
> > primary/standby
> > device in the name change event handler.
> > Can't netvsc use this mechanism instead of depending on the delay?
> >
> >
>
> T
On 04/06/18 17:33, Toke Høiland-Jørgensen wrote:
+
+#define SAMPLE_SIZE 64ul
+
The program currently cannot sample minimum sized packets, as the 4 Byte
crc checksum isnt present in ctx,
may be better to use 60ul sample size to allow for these packets to be
processed?
+ if (data + SAMPLE_
On Wed, 06 Jun 2018 13:01:52 +0200
Toke Høiland-Jørgensen wrote:
> Jakub Kicinski writes:
>
> > On Tue, 05 Jun 2018 16:50:00 +0200, Toke Høiland-Jørgensen wrote:
> >> Add an example program showing how to sample packets from XDP using the
> >> perf event buffer. The example userspace program
Jakub Kicinski writes:
> On Tue, 05 Jun 2018 16:50:00 +0200, Toke Høiland-Jørgensen wrote:
>> Add an example program showing how to sample packets from XDP using the
>> perf event buffer. The example userspace program just prints the ethernet
>> header for every packet sampled.
>>
>> Signed-off-
On Wed, Jun 6, 2018 at 12:41 PM, Kristian Evensen
wrote:
> Hi,
>
> I am experiencing the same issue on a PC Engines APU2 running kernel
> 4.14.34, both with and without hardware encryption. With hw.
> encryption, the crash occurs within 2-4 hours. Without hw. encryption,
> it takes 7-8 hours. My s
Hi,
I am experiencing the same issue on a PC Engines APU2 running kernel
4.14.34, both with and without hardware encryption. With hw.
encryption, the crash occurs within 2-4 hours. Without hw. encryption,
it takes 7-8 hours. My setup is nothing crazy, between 7 and 20
tunnels with heavy RX/TX.
On
Hi, Paolo,
below is couple my thoughts about this.
On 06.06.2018 12:44, Paolo Abeni wrote:
> On Tue, 2018-06-05 at 18:06 +0200, Paolo Abeni wrote:
>> On Tue, 2018-06-05 at 08:35 -0700, Tom Herbert wrote:
>>> Paolo, thanks for looking into this! Can you try replacing
>>> __skb_dequeue in requeue_r
Hi netdev folks,
While playing with bonding active-standby mode, we found a possible
timing issue that the primary might not initialized in bond_enslave():
if (bond_uses_primary(bond) && bond->params.primary[0]) {
/* if there is a primary slave, remember it */
On Tue, 2018-06-05 at 18:06 +0200, Paolo Abeni wrote:
> On Tue, 2018-06-05 at 08:35 -0700, Tom Herbert wrote:
> > Paolo, thanks for looking into this! Can you try replacing
> > __skb_dequeue in requeue_rx_msgs with skb_dequeue to see if that is
> > the fix.
>
> Sure, I'll retrigger the test, and r
On Tue, Jun 05, 2018 at 06:23:45PM -0500, Grygorii Strashko wrote:
On 06/02/2018 07:26 PM, Andrew Lunn wrote:
*After this patch set*: goal keep things working the same as max as
possible and get rid of TI custom tool.
We are happy to keep things the same, if they fit with the switchdev
model
On 06/06/2018 00:27, Jakub Kicinski wrote:
On Tue, 05 Jun 2018 15:06:40 -0400 (EDT), David Miller wrote:
From: Jakub Kicinski
Date: Tue, 5 Jun 2018 11:57:47 -0700
Do we still care about correctness and not breaking backward
compatibility?
Jakub let me know if you want me to revert this c
Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
>The net failover should be a simple library, not a virtual
>object with function callbacks (see callback hell).
Why just a library? It should do a common things. I think it should be a
virtual object. Looks like your patch ag
Le 05/06/2018 à 18:52, Stephen Hemminger a écrit :
> On Tue, 5 Jun 2018 15:08:30 +0200
> Nicolas Dichtel wrote:
>
>>
>> +char *get_name_from_nsid(int nsid)
>> +{
>> +struct nsid_cache *c;
>> +
>> +netns_nsid_socket_init();
>> +netns_map_init();
>> +
>> +c = netns_map_get_by_nsi
72 matches
Mail list logo
