[PATCH RESEND rdma-next] net/mlx5: Use flow counter pointer as input to the query function

2018-05-29 Thread Or Gerlitz
This allows to un-expose the details of struct mlx5_fc and keep it internal to the core driver as it used to be. Signed-off-by: Or Gerlitz --- Jason, As you asked, I am sending a fixup in case you intend to apply V2 of the flow counter series [1], if there's going to be V3, Leon, please apply i

[PATCH rdma-next] net/mlx5: Use flow counter pointer as input to the query function

2018-05-29 Thread Or Gerlitz
This allows to un-expose the details of struct mlx5_fc and keep it internal to the core driver as it used to be. Change-Id: I780cd74863fa2beccdd52e7d0cdd1e117a5aa353 Signed-off-by: Or Gerlitz --- Jason, As you asked, I am sending a fixup in case you intend to apply V2 of the flow counter series

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-29 Thread Jakub Kicinski
On Tue, 29 May 2018 23:08:11 -0700, Michael Chan wrote: > On Tue, May 29, 2018 at 10:56 PM, Jakub Kicinski wrote: > > On Tue, 29 May 2018 20:19:54 -0700, Michael Chan wrote: > >> On Tue, May 29, 2018 at 1:46 PM, Samudrala, Sridhar wrote: > >> > Isn't ndo_set_vf_xxx() considered a legacy interface a

Re: [PATCH v5 net] stmmac: 802.1ad tag stripping fix

2018-05-29 Thread Toshiaki Makita
On 2018/05/30 15:16, Elad Nachman wrote: > Interesting question. That's the way the driver was originally written and I > tried to minimize the changes in the patch. > Anyway, common.h (included by stmmac_main.c) contains the following: > > #if IS_ENABLED(CONFIG_VLAN_8021Q) > #define STMMAC_VLAN_

Re: [PATCH v5 net] stmmac: 802.1ad tag stripping fix

2018-05-29 Thread Elad Nachman
Interesting question. That's the way the driver was originally written and I tried to minimize the changes in the patch. Anyway, common.h (included by stmmac_main.c) contains the following: #if IS_ENABLED(CONFIG_VLAN_8021Q) #define STMMAC_VLAN_TAG_USED #include #endif So the define in question

Re: [PATCH v5 net] stmmac: 802.1ad tag stripping fix

2018-05-29 Thread Toshiaki Makita
On 2018/05/30 14:48, Elad Nachman wrote: > stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before > calling napi_gro_receive(). > > The function assumes VLAN tagged frames are always tagged with 802.1Q > protocol, > and assigns ETH_P_8021Q to the skb by hard-coding the paramete

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-29 Thread Michael Chan
On Tue, May 29, 2018 at 10:56 PM, Jakub Kicinski wrote: > On Tue, 29 May 2018 20:19:54 -0700, Michael Chan wrote: >> On Tue, May 29, 2018 at 1:46 PM, Samudrala, Sridhar wrote: >> > Isn't ndo_set_vf_xxx() considered a legacy interface and not planned to be >> > extended? > > +1 it's painful to see

[PATCH bpf v3 3/5] selftests/bpf: test_sockmap, fix test timeout

2018-05-29 Thread Prashant Bhole
In order to reduce runtime of tests, recently timout for select() call was reduced from 1sec to 10usec. This was causing many tests failures. It was caught with failure handling commits in this series. Restoring the timeout from 10usec to 1sec Fixes: a18fda1a62c3 ("bpf: reduce runtime of test_soc

[PATCH bpf v3 4/5] selftests/bpf: test_sockmap, fix data verification

2018-05-29 Thread Prashant Bhole
When data verification is enabled, some tests fail because verification is done incorrectly. Following changes fix it. - Identify the size of data block to be verified - Reset verification counter when data block size is reached - Fixed the value printed in case of verfication failure Fixes: 1696

[PATCH bpf v3 5/5] selftests/bpf: test_sockmap, print additional test options

2018-05-29 Thread Prashant Bhole
Print values of test options like apply, cork, start, end so that individual failed tests can be identified for manual run Acked-by: John Fastabend Signed-off-by: Prashant Bhole --- tools/testing/selftests/bpf/test_sockmap.c | 28 +++--- 1 file changed, 19 insertions(+), 9 delet

[PATCH bpf v3 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode

2018-05-29 Thread Prashant Bhole
In case of selftest mode, temporary cgroup environment is created but cgroup is not joined. It causes test failures. Fixed by joining the cgroup Fixes: 16962b2404ac ("bpf: sockmap, add selftests") Acked-by: John Fastabend Signed-off-by: Prashant Bhole --- tools/testing/selftests/bpf/test_sockma

[PATCH bpf v3 0/5] fix test_sockmap

2018-05-29 Thread Prashant Bhole
This series fixes error handling, timeout and data verification in test_sockmap. Previously it was not able to detect failure/timeout in RX/TX thread because error was not notified to the main thread. Also slightly improved test output by printing parameter values (cork, apply, start, end) so that

[PATCH bpf v3 1/5] selftests/bpf: test_sockmap, check test failure

2018-05-29 Thread Prashant Bhole
Test failures are not identified because exit code of RX/TX threads is not checked. Also threads are not returning correct exit code. - Return exit code from threads depending on test execution status - In main thread, check the exit code of RX/TX threads - Skip error checking for corked tests as

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-29 Thread Jakub Kicinski
On Tue, 29 May 2018 20:19:54 -0700, Michael Chan wrote: > On Tue, May 29, 2018 at 1:46 PM, Samudrala, Sridhar wrote: > > Isn't ndo_set_vf_xxx() considered a legacy interface and not planned to be > > extended? +1 it's painful to see this feature being added to the legacy API :( Another duplicated

[PATCH v5 net] stmmac: 802.1ad tag stripping fix

2018-05-29 Thread Elad Nachman
stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before calling napi_gro_receive(). The function assumes VLAN tagged frames are always tagged with 802.1Q protocol, and assigns ETH_P_8021Q to the skb by hard-coding the parameter on call to __vlan_hwaccel_put_tag() . This causes

Re: [PATCH bpf v2 0/5] fix test_sockmap

2018-05-29 Thread Prashant Bhole
On 5/30/2018 2:12 PM, John Fastabend wrote: On 05/29/2018 05:44 PM, Prashant Bhole wrote: On 5/30/2018 12:48 AM, John Fastabend wrote: On 05/27/2018 09:37 PM, Prashant Bhole wrote: This series fixes error handling, timeout and data verification in test_sockmap. Previously it was not able

Re: [PATCH bpf v2 0/5] fix test_sockmap

2018-05-29 Thread John Fastabend
On 05/29/2018 05:44 PM, Prashant Bhole wrote: > > > On 5/30/2018 12:48 AM, John Fastabend wrote: >> On 05/27/2018 09:37 PM, Prashant Bhole wrote: >>> This series fixes error handling, timeout and data verification in >>> test_sockmap. Previously it was not able to detect failure/timeout in >>> RX

[PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-29 Thread Eric Dumazet
Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") brought a regression caught in our regression suite, thanks to KASAN. Note that mlx4_alloc_icm() is already able to try high order allocations and fallback to low-order allocations under high memory pressure. We only have

Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks

2018-05-29 Thread Eric Dumazet
On 05/29/2018 11:44 PM, Eric Dumazet wrote: > > And I will add this simple fix, this really should address your initial > concern much better. > > @@ -99,6 +100,8 @@ static int mlx4_alloc_icm_pages(struct scatterlist *mem, > int order, > { > struct page *page; > > + if (ord

Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks

2018-05-29 Thread Eric Dumazet
On 05/29/2018 11:34 PM, Eric Dumazet wrote: > I will test : > > diff --git a/drivers/net/ethernet/mellanox/mlx4/icm.c > b/drivers/net/ethernet/mellanox/mlx4/icm.c > index > 685337d58276fc91baeeb64387c52985e1bc6dda..4d2a71381acb739585d662175e86caef72338097 > 100644 > --- a/drivers/net/ethern

Re: [net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-05-29 Thread Guenter Roeck
On 05/29/2018 08:01 PM, Michael S. Tsirkin wrote: On Tue, May 29, 2018 at 03:19:08PM -0700, Guenter Roeck wrote: On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: The struct vhost_msg within struct vhost_msg_node is copied to userspace, so it should be allocated with kzalloc() to en

Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks

2018-05-29 Thread Eric Dumazet
On 05/25/2018 10:23 AM, David Miller wrote: > From: Qing Huang > Date: Wed, 23 May 2018 16:22:46 -0700 > >> When a system is under memory presure (high usage with fragments), >> the original 256KB ICM chunk allocations will likely trigger kernel >> memory management to enter slow path doing me

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-29 Thread Michael Chan
On Tue, May 29, 2018 at 1:46 PM, Samudrala, Sridhar wrote: > > Isn't ndo_set_vf_xxx() considered a legacy interface and not planned to be > extended? I didn't know about that. > Shouldn't we enable this via ethtool on the port representor netdev? > > We discussed about this. ethtool on the VF

Re: [PATCH mlx5-next 2/2] net/mlx5: Add FPGA QP error event

2018-05-29 Thread Andrew Lunn
On Tue, May 29, 2018 at 05:19:54PM -0700, Saeed Mahameed wrote: > From: Ilan Tayari > > The FPGA QP event fires whenever a QP on the FPGA trasitions > to the error state. FPGA i know, field programmable gate array. Could you offer some clue as to what QP means? Thanks Andrew

Re: [PATCH mlx5-next 1/2] net/mlx5: Add temperature warning event to log

2018-05-29 Thread Andrew Lunn
On Tue, May 29, 2018 at 05:19:53PM -0700, Saeed Mahameed wrote: > From: Ilan Tayari > > Temperature warning event is sent by FW to indicate high temperature > as detected by one of the sensors on the board. > Add handling of this event by writing the numbers of the alert sensors > to the kernel l

Re: [PATCH bpf v2 0/5] fix test_sockmap

2018-05-29 Thread Prashant Bhole
On 5/30/2018 12:48 AM, John Fastabend wrote: On 05/27/2018 09:37 PM, Prashant Bhole wrote: This series fixes error handling, timeout and data verification in test_sockmap. Previously it was not able to detect failure/timeout in RX/TX thread because error was not notified to the main thread.

[net-next 6/7] net/mlx5: FPGA, Call DMA unmap with the right size

2018-05-29 Thread Saeed Mahameed
From: Ilya Lesokhin When mlx5_fpga_conn_unmap_buf is called buf->sg[0].size should equal the actual buffer size, not the message size. Otherwise we will trigger the following dma debug warning "DMA-API: device driver frees DMA memory with different size" Fixes: 537a50574175 ('net/mlx5: FPGA, Add

[net-next 5/7] net/mlx5: FPGA, Properly initialize dma direction on fpga conn send

2018-05-29 Thread Saeed Mahameed
From: Ilya Lesokhin Properly initialize dma direction on fpga conn send. Do not rely on dma_dir == 0 (DMA_BIDIRECTIONAL). Signed-off-by: Ilya Lesokhin Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/driv

[net-next 7/7] net/mlx5e: Get the number of offloaded TC rules from the correct table

2018-05-29 Thread Saeed Mahameed
From: Or Gerlitz As we keep the offloaded TC rules for NIC and e-switch in two different places, make sure to return the number of offloaded flows according to the use-case and not blindly from the priv. Fixes: 655dc3d2b91b ('net/mlx5e: Use shared table for offloaded TC eswitch flows') Signed-o

[net-next 3/7] net/mlx5: FPGA, print SBU identification on init

2018-05-29 Thread Saeed Mahameed
From: Ilan Tayari Add print of the following values on init: 1. ieee vendor id 2. sandbox product id 3. sandbox product version Signed-off-by: Ilan Tayari Signed-off-by: Adi Nissim Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c | 7 +-- 1 file chang

[net-next 2/7] net/mlx5: FPGA, Add device name

2018-05-29 Thread Saeed Mahameed
From: Ilan Tayari Add device name for Mellanox FPGA devices. Signed-off-by: Ilan Tayari Signed-off-by: Adi Nissim Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/fpga/cmd.h| 7 ++ .../ethernet/mellanox/mlx5/core/fpga/core.c | 24 --- 2 files chang

[net-next 4/7] net/mlx5: FPGA, Abort FPGA init if the device reports no QP capability

2018-05-29 Thread Saeed Mahameed
From: Yevgeny Kliteynik In the case that the reported max number of QPs capability equals to zero, abort FPGA init. Signed-off-by: Yevgeny Kliteynik Signed-off-by: Adi Nissim Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c | 6 ++ 1 file changed, 6 i

[net-next 1/7] net/mlx5: FPGA, Add doxygen for access type enum

2018-05-29 Thread Saeed Mahameed
From: Ilan Tayari Add doxygen comments for enum mlx5_fpga_access_type. Signed-off-by: Ilan Tayari Signed-off-by: Adi Nissim Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fpga/sdk.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/mell

[pull request][net-next 0/7] Mellanox, mlx5e & FPGA updates 2018-05-29

2018-05-29 Thread Saeed Mahameed
Hi Dave, The following series includes some minor FPGA and mlx5e netdev updates, for more information please see tag log below. Please pull and let me know if there's any problem. Note: This series doesn't include nor require any mlx5-next shared code and can be applied as is to net-next tree.

[PATCH] ixgbe: check ipsec ip addr against mgmt filter

2018-05-29 Thread Shannon Nelson
Make sure we don't try to offload the decryption of an incoming packet that should get delivered to the management engine. This is a corner case that will likely be very seldom seen, but could really confuse someone if they were to hit it. Suggested-by: Jesse Brandeburg Signed-off-by: Shannon Ne

[PATCH mlx5-next 0/2] Mellanox, mlx5 new device events

2018-05-29 Thread Saeed Mahameed
Hi, The following series is for mlx5-next tree [1], it adds the support of two new device events, from Ilan Tayari: 1. High temperature warnings. 2. FPGA QP error event. In case of no objection this series will be applied to mlx5-next tree and will be sent later as a pull request to both rdma a

[PATCH mlx5-next 2/2] net/mlx5: Add FPGA QP error event

2018-05-29 Thread Saeed Mahameed
From: Ilan Tayari The FPGA QP event fires whenever a QP on the FPGA trasitions to the error state. At this stage, this event is unrecoverable, it may become recoverable in the future. Signed-off-by: Ilan Tayari Signed-off-by: Adi Nissim Signed-off-by: Saeed Mahameed --- drivers/net/ethernet

[PATCH mlx5-next 1/2] net/mlx5: Add temperature warning event to log

2018-05-29 Thread Saeed Mahameed
From: Ilan Tayari Temperature warning event is sent by FW to indicate high temperature as detected by one of the sensors on the board. Add handling of this event by writing the numbers of the alert sensors to the kernel log. Signed-off-by: Ilan Tayari Signed-off-by: Adi Nissim Signed-off-by: S

Re: [PATCH bpf-next 11/11] bpf, doc: add missing patchwork url and libbpf to maintainers

2018-05-29 Thread Song Liu
On Sun, May 27, 2018 at 5:43 PM, Daniel Borkmann wrote: > Add missing bits under tools/lib/bpf/ and also Q: entry in order to > make it easier for people to retrieve current patch queue. > > Signed-off-by: Daniel Borkmann > Acked-by: Alexei Starovoitov Acked-by: Song Liu > --- > MAINTAINERS

Re: [PATCH bpf-next] bpftool: Support sendmsg{4,6} attach types

2018-05-29 Thread Song Liu
On Tue, May 29, 2018 at 2:20 PM, Jakub Kicinski wrote: > On Tue, 29 May 2018 13:29:31 -0700, Andrey Ignatov wrote: >> Add support for recently added BPF_CGROUP_UDP4_SENDMSG and >> BPF_CGROUP_UDP6_SENDMSG attach types to bpftool, update documentation >> and bash completion. >> >> Signed-off-by: And

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-29 Thread Jiri Pirko
Tue, May 29, 2018 at 04:08:48PM CEST, john.hur...@netronome.com wrote: >On Sat, May 26, 2018 at 3:47 AM, Jakub Kicinski > wrote: >> On Fri, 25 May 2018 08:48:09 +0200, Jiri Pirko wrote: >>> Thu, May 24, 2018 at 04:22:47AM CEST, jakub.kicin...@netronome.com wrote: >>> >Hi! >>> > >>> >This series fro

Re: [PATCH mlx5-next 1/3] net/mlx5: Exposing a new mini-CQE format

2018-05-29 Thread Jason Gunthorpe
On Tue, May 29, 2018 at 03:01:27PM -0600, Saeed Mahameed wrote: > On Sun, 2018-05-27 at 13:42 +0300, Leon Romanovsky wrote: > > From: Yonatan Cohen > > > > The new mini-CQE format includes byte-count, checksum > > and stride index. > > > > Reviewed-by: Yishai Hadas > > Reviewed-by: Guy Levi >

Re: [PATCH bpf-next] bpftool: Support sendmsg{4,6} attach types

2018-05-29 Thread Jakub Kicinski
On Tue, 29 May 2018 13:29:31 -0700, Andrey Ignatov wrote: > Add support for recently added BPF_CGROUP_UDP4_SENDMSG and > BPF_CGROUP_UDP6_SENDMSG attach types to bpftool, update documentation > and bash completion. > > Signed-off-by: Andrey Ignatov Reviewed-by: Jakub Kicinski > I'm not sure abo

Re: [PATCH net-next 0/7] net/ipv6: Fix route append and replace use cases

2018-05-29 Thread Thomas Winter
The only thing this breaks is adding IPv6 routes via ioctl. Previously they would be automatically appended to form multipath routes but this no longer occurs. Changing to netlink or use iproute2 and using NLM_F_APPEND gets around this. This basically what David Ahern said earlier but I wanted t

Re: [PATCH mlx5-next 1/3] net/mlx5: Exposing a new mini-CQE format

2018-05-29 Thread Saeed Mahameed
On Sun, 2018-05-27 at 13:42 +0300, Leon Romanovsky wrote: > From: Yonatan Cohen > > The new mini-CQE format includes byte-count, checksum > and stride index. > > Reviewed-by: Yishai Hadas > Reviewed-by: Guy Levi > Signed-off-by: Yonatan Cohen > Signed-off-by: Leon Romanovsky Applied to mlx

Re: [PATCH rdma-next v2 01/13] IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure

2018-05-29 Thread Jason Gunthorpe
On Tue, May 29, 2018 at 08:49:58PM +, Ruhl, Michael J wrote: > >From: Jason Gunthorpe [mailto:j...@mellanox.com] > >Sent: Tuesday, May 29, 2018 4:21 PM > >To: Ruhl, Michael J > >Cc: Leon Romanovsky ; Doug Ledford > >; Leon Romanovsky ; RDMA > >mailing list ; Boris Pismenny > >; Matan Barak ; R

RE: [PATCH rdma-next v2 01/13] IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure

2018-05-29 Thread Ruhl, Michael J
>-Original Message- >From: Jason Gunthorpe [mailto:j...@mellanox.com] >Sent: Tuesday, May 29, 2018 4:21 PM >To: Ruhl, Michael J >Cc: Leon Romanovsky ; Doug Ledford >; Leon Romanovsky ; RDMA >mailing list ; Boris Pismenny >; Matan Barak ; Raed >Salem ; Yishai Hadas ; Saeed >Mahameed ; linux

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-29 Thread Samudrala, Sridhar
On 5/29/2018 1:18 AM, Michael Chan wrote: VF Queue resources are always limited and there is currently no infrastructure to allow the admin. on the host to add or reduce queue resources for any particular VF. With ever increasing number of VFs being supported, it is desirable to allow the admin.

[PATCH bpf-next] bpftool: Support sendmsg{4,6} attach types

2018-05-29 Thread Andrey Ignatov
Add support for recently added BPF_CGROUP_UDP4_SENDMSG and BPF_CGROUP_UDP6_SENDMSG attach types to bpftool, update documentation and bash completion. Signed-off-by: Andrey Ignatov --- I'm not sure about "since 4.18" in Documentation part. I can follow-up when the next kernel version is known. ---

Re: [PATCH rdma-next v2 01/13] IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure

2018-05-29 Thread Jason Gunthorpe
On Tue, May 29, 2018 at 07:31:22PM +, Ruhl, Michael J wrote: > >-struct ib_uverbs_destroy_cq_resp resp; > > struct ib_uobject *uobj = > >-uverbs_attr_get(attrs, > >UVERBS_ATTR_DESTROY_CQ_HANDLE)->obj_attr.uobject; > >-struct ib_ucq_object *obj = container_of(uobj, struct

Re: [PATCH rdma-next 0/3] Introduce new mlx5 CQE format

2018-05-29 Thread Jason Gunthorpe
On Sun, May 27, 2018 at 01:42:31PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Introduce new internal to mlx5 CQE format - mini-CQE. It is a CQE in > compressed form that holds data needed to extra a single full CQE. > > It stride index, byte count and packet checksum. > > Thanks

Re: [PATCH] net: sched: split tc_ctl_tfilter into three handlers

2018-05-29 Thread David Miller
From: Vlad Buslov Date: Sun, 27 May 2018 22:55:03 +0300 > tc_ctl_tfilter handles three netlink message types: RTM_NEWTFILTER, > RTM_DELTFILTER, RTM_GETTFILTER. However, implementation of this function > involves a lot of branching on specific message type because most of the > code is message-spe

Re: [PATCH mlx5-next v2 11/13] IB/mlx5: Add flow counters binding support

2018-05-29 Thread Jason Gunthorpe
On Tue, May 29, 2018 at 04:09:15PM +0300, Leon Romanovsky wrote: > diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h > index 508ea8c82da7..ef3f430a7050 100644 > +++ b/include/uapi/rdma/mlx5-abi.h > @@ -443,4 +443,18 @@ enum { > enum { > MLX5_IB_CLOCK_INFO_V1

Re: [PATCH bpf-next 04/11] bpf: show prog and map id in fdinfo

2018-05-29 Thread Daniel Borkmann
On 05/29/2018 07:27 PM, Jesper Dangaard Brouer wrote: > On Mon, 28 May 2018 02:43:37 +0200 > Daniel Borkmann wrote: > >> Its trivial and straight forward to expose it for scripts that can >> then use it along with bpftool in order to inspect an individual >> application's used maps and progs. Rig

Re: [PATCH bpf-next] bpf: Drop mpls from bpf_fib_lookup

2018-05-29 Thread Daniel Borkmann
On 05/29/2018 07:58 PM, dsah...@kernel.org wrote: > From: David Ahern > > MPLS support will not be submitted this dev cycle, but in working on it > I do see a few changes are needed to the API. For now, drop mpls from the > API. Since the fields in question are unions, the mpls fields can be adde

Re: [PATCH bpf-next] bpf: Verify flags in bpf_fib_lookup

2018-05-29 Thread Daniel Borkmann
On 05/29/2018 08:59 PM, dsah...@kernel.org wrote: > From: David Ahern > > Verify flags argument contains only known flags. Allows programs to probe > for support as more are added. > > Signed-off-by: David Ahern Applied to bpf-next, thanks David!

Re: [PATCH bpf-next] bpf: clean up eBPF helpers documentation

2018-05-29 Thread Daniel Borkmann
On 05/29/2018 08:27 PM, Song Liu wrote: > On Tue, May 29, 2018 at 4:27 AM, Quentin Monnet > wrote: >> These are minor edits for the eBPF helpers documentation in >> include/uapi/linux/bpf.h. >> >> The main fix consists in removing "BPF_FIB_LOOKUP_", because it ends >> with a non-escaped underscore

RE: [PATCH rdma-next v2 01/13] IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure

2018-05-29 Thread Ruhl, Michael J
>-Original Message- >From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- >ow...@vger.kernel.org] On Behalf Of Leon Romanovsky >Sent: Tuesday, May 29, 2018 9:09 AM >To: Doug Ledford ; Jason Gunthorpe > >Cc: Leon Romanovsky ; RDMA mailing list r...@vger.kernel.org>; Boris Pismenny ; Ma

Re: [PATCH net-next 1/5] net: aquantia: Ethtool based ring size configuration

2018-05-29 Thread Jakub Kicinski
On Tue, 29 May 2018 15:56:58 +0300, Igor Russkikh wrote: > +static int aq_set_ringparam(struct net_device *ndev, > + struct ethtool_ringparam *ring) > +{ > + int err = 0; > + struct aq_nic_s *aq_nic = netdev_priv(ndev); > + struct aq_nic_cfg_s *aq_nic_cfg = aq_ni

[PATCH bpf-next] bpf: Verify flags in bpf_fib_lookup

2018-05-29 Thread dsahern
From: David Ahern Verify flags argument contains only known flags. Allows programs to probe for support as more are added. Signed-off-by: David Ahern --- net/core/filter.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/core/filter.c b/net/core/filter.c index 24e6ce8be567..4cff6d

Re: [pull request][for-next 00/12] Mellanox, mlx5e updates 2018-05-25

2018-05-29 Thread Saeed Mahameed
On Tue, 2018-05-29 at 09:47 -0400, David Miller wrote: > From: Saeed Mahameed > Date: Fri, 25 May 2018 17:01:55 -0700 > > > This is a mlx5e only pull request, for more information please see > > tag > > log below. > > > > Please pull and let me know if there's any problem. > > Pulled, thanks Sa

Re: [PATCH bpf-next] bpf: clean up eBPF helpers documentation

2018-05-29 Thread Song Liu
On Tue, May 29, 2018 at 4:27 AM, Quentin Monnet wrote: > These are minor edits for the eBPF helpers documentation in > include/uapi/linux/bpf.h. > > The main fix consists in removing "BPF_FIB_LOOKUP_", because it ends > with a non-escaped underscore that gets interpreted by rst2man and > produces

Re: [PATCH bpf-next 03/11] bpf: fixup error message from gpl helpers on license mismatch

2018-05-29 Thread Song Liu
On Tue, May 29, 2018 at 10:16 AM, Jesper Dangaard Brouer wrote: > On Mon, 28 May 2018 02:43:36 +0200 > Daniel Borkmann wrote: > >> Stating 'proprietary program' in the error is just silly since it >> can also be a different open source license than that which is just >> not compatible. >> >> Refe

Re: [PATCH bpf-next 02/11] bpf: add also cbpf long jump test cases with heavy expansion

2018-05-29 Thread Song Liu
On Sun, May 27, 2018 at 5:43 PM, Daniel Borkmann wrote: > We have one triggering on eBPF but lets also add a cBPF example to > make sure we keep tracking them. Also add anther cBPF test running > max number of MSH ops. > > Signed-off-by: Daniel Borkmann > Acked-by: Alexei Starovoitov Acked-by:

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Marcelo Ricardo Leitner
On Wed, May 30, 2018 at 01:45:08AM +0800, Xin Long wrote: > If we're counting on max_t to fix this CPU stuck. It should not that > matter if min rto < the value causing that stuck. Yes but putting a floor to rto_{min,max} now is to protect the rtx timer now, not the heartbeat one. > > > > > Anyw

Re: [PATCH bpf-next 01/11] bpf: test case for map pointer poison with calls/branches

2018-05-29 Thread Song Liu
On Sun, May 27, 2018 at 5:43 PM, Daniel Borkmann wrote: > Add several test cases where the same or different map pointers > originate from different paths in the program and execute a map > lookup or tail call at a common location. > > Signed-off-by: Daniel Borkmann > Acked-by: Alexei Starovoitov

[PATCH bpf-next] bpf: Drop mpls from bpf_fib_lookup

2018-05-29 Thread dsahern
From: David Ahern MPLS support will not be submitted this dev cycle, but in working on it I do see a few changes are needed to the API. For now, drop mpls from the API. Since the fields in question are unions, the mpls fields can be added back later without affecting the uapi. Signed-off-by: Dav

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Xin Long
On Wed, May 30, 2018 at 1:06 AM, Marcelo Ricardo Leitner wrote: > On Tue, May 29, 2018 at 12:03:46PM -0400, Neal Cardwell wrote: >> On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo Leitner < >> marcelo.leit...@gmail.com> wrote: >> > - patch2 - fix rtx attack vector >> >- Add the floor value to

Re: [PATCH bpf-next 04/11] bpf: show prog and map id in fdinfo

2018-05-29 Thread Jesper Dangaard Brouer
On Mon, 28 May 2018 02:43:37 +0200 Daniel Borkmann wrote: > Its trivial and straight forward to expose it for scripts that can > then use it along with bpftool in order to inspect an individual > application's used maps and progs. Right now we dump some basic > information in the fdinfo file but

Re: [PATCH bpf-next 05/11] bpf: avoid retpoline for lookup/update/delete calls on maps

2018-05-29 Thread Jesper Dangaard Brouer
On Mon, 28 May 2018 02:43:38 +0200 Daniel Borkmann wrote: > While some of the BPF map lookup helpers provide a ->map_gen_lookup() > callback for inlining the map lookup altogether it is not available > for every map, so the remaining ones have to call bpf_map_lookup_elem() > helper which does a d

Re: [PATCH bpf-next 03/11] bpf: fixup error message from gpl helpers on license mismatch

2018-05-29 Thread Jesper Dangaard Brouer
On Mon, 28 May 2018 02:43:36 +0200 Daniel Borkmann wrote: > Stating 'proprietary program' in the error is just silly since it > can also be a different open source license than that which is just > not compatible. > > Reference: https://twitter.com/majek04/status/998531268039102465 > Signed-off-

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Marcelo Ricardo Leitner
On Tue, May 29, 2018 at 12:03:46PM -0400, Neal Cardwell wrote: > On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo Leitner < > marcelo.leit...@gmail.com> wrote: > > - patch2 - fix rtx attack vector > >- Add the floor value to rto_min to HZ/20 (which fits the values > > that Michael shared o

[PATCH v2 net-next] net: remove bypassed check in sch_direct_xmit()

2018-05-29 Thread Song Liu
Checking netif_xmit_frozen_or_stopped() at the end of sch_direct_xmit() is being bypassed. This is because "ret" from sch_direct_xmit() will be either NETDEV_TX_OK or NETDEV_TX_BUSY, and only ret == NETDEV_TX_OK == 0 will reach the condition: if (ret && netif_xmit_frozen_or_stopped(txq))

Re: [PATCH net-next] net: remove bypassed check in sch_direct_xmit()

2018-05-29 Thread Song Liu
> On May 29, 2018, at 1:58 AM, Sergei Shtylyov > wrote: > > Hello! > > On 5/29/2018 12:36 AM, Song Liu wrote: > >> Check sch_direct_xmit() at the end of sch_direct_xmit() will be bypassed. > > "Checking netif_xmit_frozen_or_stopped()", perhaps? Else it doesn't make > much sense... Than

Re: [PATCH net] net: sched: check netif_xmit_frozen_or_stopped() in sch_direct_xmit()

2018-05-29 Thread Song Liu
> On May 29, 2018, at 7:02 AM, David Miller wrote: > > From: Song Liu > Date: Fri, 25 May 2018 11:11:44 -0700 > >> Summary: >> >> At the end of sch_direct_xmit(), we are in the else path of >> !dev_xmit_complete(ret), which means ret == NETDEV_TX_OK. The following >> condition will always f

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Neal Cardwell
On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo Leitner < marcelo.leit...@gmail.com> wrote: > - patch2 - fix rtx attack vector >- Add the floor value to rto_min to HZ/20 (which fits the values > that Michael shared on the other email) I would encourage allowing minimum RTO values down to

Re: [PATCH bpf v2 0/5] fix test_sockmap

2018-05-29 Thread John Fastabend
On 05/27/2018 09:37 PM, Prashant Bhole wrote: > This series fixes error handling, timeout and data verification in > test_sockmap. Previously it was not able to detect failure/timeout in > RX/TX thread because error was not notified to the main thread. > > Also slightly improved test output by pri

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Marcelo Ricardo Leitner
On Tue, May 29, 2018 at 03:06:06PM +0200, Michael Tuexen wrote: > > On 29. May 2018, at 13:41, Neil Horman wrote: > > > > On Mon, May 28, 2018 at 04:43:15PM -0300, Marcelo Ricardo Leitner wrote: > >> On Sat, May 26, 2018 at 09:01:00PM -0400, Neil Horman wrote: > >>> On Sat, May 26, 2018 at 05:50:

Re: STMMAC driver with TSO enabled issue

2018-05-29 Thread Bhadram Varka
Hi Jose, On 5/28/2018 4:26 PM, Jose Abreu wrote: Hi Bhadram, On 28-05-2018 10:15, Bhadram Varka wrote: Hi Jose, On 5/25/2018 8:02 PM, Jose Abreu wrote: On 25-05-2018 15:25, Bhadram Varka wrote: Hi Jose, On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram Vark

Re: [PATCH bpf-next 06/11] bpf: add bpf_skb_cgroup_id helper

2018-05-29 Thread Daniel Borkmann
On 05/29/2018 02:15 PM, Quentin Monnet wrote: > Hi Daniel, > > 2018-05-28 02:43 UTC+0200 ~ Daniel Borkmann >> Add a new bpf_skb_cgroup_id() helper that allows to retrieve the >> cgroup id from the skb's socket. This is useful in particular to >> enable bpf_get_cgroup_classid()-like behavior for c

Re: [PATCH bpf v2 1/5] selftests/bpf: test_sockmap, check test failure

2018-05-29 Thread John Fastabend
On 05/27/2018 09:37 PM, Prashant Bhole wrote: > Test failures are not identified because exit code of RX/TX threads > is not checked. Also threads are not returning correct exit code. > > - Return exit code from threads depending on test execution status > - In main thread, check the exit code of

Re: [PATCH v2 net] tun: Fix NULL pointer dereference in XDP redirect

2018-05-29 Thread David Miller
From: Toshiaki Makita Date: Mon, 28 May 2018 19:37:49 +0900 > Calling XDP redirection requires bh disabled. Softirq can call another > XDP function and redirection functions, then the percpu static variable > ri->map can be overwritten to NULL. ... > v2: > - Removed preempt_disable/enable since

Re: [PATCH net] be2net: Fix error detection logic for BE3

2018-05-29 Thread David Miller
From: Suresh Reddy Date: Mon, 28 May 2018 01:26:06 -0400 > Check for 0xE00 (RECOVERABLE_ERR) along with ARMFW UE (0x0) > in be_detect_error() to know whether the error is valid error or not > > Fixes: 673c96e5a ("be2net: Fix UE detection logic for BE3") > Signed-off-by: Suresh Reddy Applied an

[PATCH iproute2 v2] ipaddress: strengthen check on 'label' input

2018-05-29 Thread Patrick Talbert
As mentioned in the ip-address man page, an address label must be equal to the device name or prefixed by the device name followed by a colon. Currently the only check on this input is to see if the device name appears at the beginning of the label string. This commit adds an additional check to e

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-29 Thread Don Dutile
On 05/25/2018 05:05 PM, Jakub Kicinski wrote: On Fri, 25 May 2018 09:02:23 -0500, Bjorn Helgaas wrote: On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: Some

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-29 Thread Don Dutile
On 05/25/2018 04:46 PM, Bjorn Helgaas wrote: On Fri, May 25, 2018 at 03:27:52PM -0400, Don Dutile wrote: On 05/25/2018 10:02 AM, Bjorn Helgaas wrote: On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: Hi Bjorn! On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: On Mon, Apr

Re: [PATCH net-next 0/7] net: Add address attribute to control metric of prefix route

2018-05-29 Thread David Miller
From: dsah...@kernel.org Date: Sun, 27 May 2018 08:09:52 -0700 > For use cases such as VRR (Virtual Router Redundancy) interface managers > want efficient control over the order of prefix routes when multiple > interfaces have addresses with overlapping/duplicate subnets. > > Currently, if two in

Re: [PATCH net-next 0/3] mlxsw: use MRSR register for FW reset

2018-05-29 Thread David Miller
From: Ido Schimmel Date: Sun, 27 May 2018 09:56:12 +0300 > Jiri says: > > Introduce a MRSR register definition and use it to do FW reset instead > of existing mechanism using PCI BAR0 register. Series applied to net-next.

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-29 Thread John Hurley
On Sat, May 26, 2018 at 3:47 AM, Jakub Kicinski wrote: > On Fri, 25 May 2018 08:48:09 +0200, Jiri Pirko wrote: >> Thu, May 24, 2018 at 04:22:47AM CEST, jakub.kicin...@netronome.com wrote: >> >Hi! >> > >> >This series from John adds bond offload to the nfp driver. Patch 5 >> >exposes the hash type

Re: [PATCH net] mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG

2018-05-29 Thread David Miller
From: Ido Schimmel Date: Sun, 27 May 2018 09:48:41 +0300 > From: Petr Machata > > VLAN 1 is internally used for untagged traffic. Prevent creation of > explicit netdevice for that VLAN, because that currently isn't supported > and leads to the NULL pointer dereference cited below. > > Fix by p

Re: [PATCH] net: qcom/emac: fix device tree initialization

2018-05-29 Thread David Miller
From: Timur Tabi Date: Sat, 26 May 2018 20:29:14 -0500 > Commit "net: qcom/emac: Encapsulate sgmii ops under one structure" > introduced the sgmii_ops structure, but did not correctly initialize > it on device tree platforms. This resulted in compiler warnings when > ACPI is not enabled. > > Re

Re: [PATCH net] net: sched: check netif_xmit_frozen_or_stopped() in sch_direct_xmit()

2018-05-29 Thread David Miller
From: Song Liu Date: Fri, 25 May 2018 11:11:44 -0700 > Summary: > > At the end of sch_direct_xmit(), we are in the else path of > !dev_xmit_complete(ret), which means ret == NETDEV_TX_OK. The following > condition will always fail and netif_xmit_frozen_or_stopped() is not > checked at all. > >

Re: [PATCH net-next 00/14] nfp: abm: RED/MQ qdisc offload

2018-05-29 Thread David Miller
From: Jakub Kicinski Date: Fri, 25 May 2018 21:53:24 -0700 > This is second batch of advanced buffer management nfp driver > changes. This series adds the qdisc offload. Support for > a very simple subset of RED qdisc offload is added as needed > for DCTCP ECN marking (min and max thresholds se

Re: [pull request][for-next 00/12] Mellanox, mlx5e updates 2018-05-25

2018-05-29 Thread David Miller
From: Saeed Mahameed Date: Fri, 25 May 2018 17:01:55 -0700 > This is a mlx5e only pull request, for more information please see tag > log below. > > Please pull and let me know if there's any problem. Pulled, thanks Saeed. There was a minor conflict to resolve (simple overlapping changes).

[PATCH mlx5-next v2 02/13] net/mlx5: Export flow counter related API

2018-05-29 Thread Leon Romanovsky
From: Raed Salem Exports counters API to be used in both IB and EN. Tested-by: Michael Guralnik Reviewed-by: Yishai Hadas Signed-off-by: Raed Salem Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.h | 23 -- .../net/ethernet/mellanox/ml

[PATCH rdma-next v2 08/13] IB/core: Add support for flow counters

2018-05-29 Thread Leon Romanovsky
From: Raed Salem A counters object could be attached to flow on creation by providing the counter specification action. General counters description which count packets and bytes are introduced, downstream patches from this series will use them as part of flow counters binding. In addition, inc

[PATCH rdma-next v2 05/13] IB/core: Introduce counters read verb

2018-05-29 Thread Leon Romanovsky
From: Raed Salem The user supplies counters instance and a reference to an output array of uint64_t. The driver reads the hardware counters values and writes them to the output index location in the user supplied array. All counters values are represented as uint64_t types. To be able to success

[PATCH rdma-next v2 13/13] IB/mlx5: Add counters read support

2018-05-29 Thread Leon Romanovsky
From: Raed Salem This patch implements the uverbs counters read API, it will use the specific read counters function to the given type to accomplish its task. Tested-by: Michael Guralnik Reviewed-by: Yishai Hadas Signed-off-by: Raed Salem Signed-off-by: Leon Romanovsky --- drivers/infiniban

[PATCH rdma-next v2 09/13] IB/uverbs: Add support for flow counters

2018-05-29 Thread Leon Romanovsky
From: Raed Salem The struct ib_uverbs_flow_spec_action_count associates a counters object with the flow. Post this association the flow counters can be read via the counters object. Tested-by: Michael Guralnik Reviewed-by: Yishai Hadas Signed-off-by: Raed Salem Signed-off-by: Leon Romanovsky

[PATCH rdma-next v2 12/13] IB/mlx5: Add flow counters read support

2018-05-29 Thread Leon Romanovsky
From: Raed Salem Implements the flow counters read wrapper. Tested-by: Michael Guralnik Reviewed-by: Yishai Hadas Signed-off-by: Raed Salem Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c| 15 +++ drivers/infiniband/hw/mlx5/mlx5_ib.h | 13 -

  1   2   >