On Tue, 29 May 2018 20:19:54 -0700, Michael Chan wrote: > On Tue, May 29, 2018 at 1:46 PM, Samudrala, Sridhar wrote: > > Isn't ndo_set_vf_xxx() considered a legacy interface and not planned to be > > extended?
+1 it's painful to see this feature being added to the legacy API :( Another duplicated configuration knob. > I didn't know about that. > > > Shouldn't we enable this via ethtool on the port representor netdev? > > We discussed about this. ethtool on the VF representor will only work > in switchdev mode and also will not support min/max values. Ethtool channel API may be overdue a rewrite in devlink anyway, but I feel like implementing switchdev mode and rewriting features in devlink may be too much to ask.