In divasmain.c, the function divas_write() firstly invokes the function
diva_xdi_open_adapter() to open the adapter that matches with the adapter
number provided by the user, and then invokes the function diva_xdi_write()
to perform the write operation using the matched adapter. The two functions
d
immdlen field of FW_ETH_TX_PKT_WR is filled in a wrong way,
we must copy the length of all the cpls encapsulated in fw
work request. In the xmit path we missed adding the length
of CPL_TX_PKT_CORE but we added the length of WR_HDR and it
worked because WR_HDR and CPL_TX_PKT_CORE are of same length.
On Sun, May 20, 2018 at 5:37 PM, David Miller wrote:
> From: Wenwen Wang
> Date: Fri, 18 May 2018 16:33:47 -0500
>
>> In divasmain.c, the function divas_write() firstly invokes the function
>> diva_xdi_open_adapter() to open the adapter that matches with the adapter
>> number provided by the user
FYI, we noticed the following commit (built with gcc-6):
commit: 3416099d53d9593ab1d374180e9cd2a71fa2f4d5 ("net: Refactor XPS for CPUs
and Rx queues")
url:
https://github.com/0day-ci/linux/commits/Amritha-Nambiar/net-Refactor-XPS-for-CPUs-and-Rx-queues/20180518-053915
in testcase: boot
on te
On 5/19/2018 1:54 AM, Shuah Khan wrote:
On 05/18/2018 01:17 AM, Prashant Bhole wrote:
This series fixes bugs in test_sockmap code. They weren't caught
previously because failure in RX/TX thread was not notified to the
main thread.
Also fixed data verification logic and slightly improved test
On 5/19/2018 1:45 AM, John Fastabend wrote:
On 05/18/2018 12:17 AM, Prashant Bhole wrote:
In case of selftest mode, temporary cgroup environment is created but
cgroup is not joined. It causes test failures. Fixed by joining the
cgroup
Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
Signed
On 5/19/2018 1:42 AM, John Fastabend wrote:
On 05/18/2018 12:17 AM, Prashant Bhole wrote:
This series fixes bugs in test_sockmap code. They weren't caught
previously because failure in RX/TX thread was not notified to the
main thread.
Also fixed data verification logic and slightly improved t
On 5/19/2018 1:47 AM, John Fastabend wrote:
On 05/18/2018 12:17 AM, Prashant Bhole wrote:
In order to reduce runtime of tests, recently timout for select() call
was reduced from 1sec to 10usec. This was causing many tests failures.
It was caught with failure handling commits in this series.
R
On Sun, May 20, 2018 at 6:54 PM, Marcelo Ricardo Leitner
wrote:
> On Sun, May 20, 2018 at 08:50:59PM -0400, Neil Horman wrote:
>> On Sat, May 19, 2018 at 03:44:40PM +0800, Xin Long wrote:
>> > This feature is actually already supported by sk->sk_reuse which can be
>> > set by SO_REUSEADDR. But it'
A number of entries were not alphabetically sorted, remedy that.
Signed-off-by: Florian Fainelli
---
drivers/net/ethernet/Kconfig | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
index 54d71e1c48d5..a
If CONFIG_GPIOLIB is disabled, gpiod_put() becomes a stub that produces a
warning, this helped identify that we could be attempting to release a NULL
pl->link_gpio GPIO descriptor, so guard against that.
Fixes: daab3349ad1a ("net: phy: phylink: Release link GPIO")
Signed-off-by: Florian Fainelli
Hi,
I found this hung for several times these days, and seems syzbot already
reported a similar problem. Is there any patch(es) for that?
Successfully initialized wpa_supplicant
[ 240.091941] INFO: task kworker/u8:1:39 blocked for more than 120 seconds.
[ 240.092004] Not tainted 4.4.126
From: AceLan Kao
Date: Mon, 21 May 2018 11:14:00 +0800
> We are willing to fix the issue, but we don't have a machine to
> reproduce it, and the WoL feature has been removed 5 years ago, it's
> hard to find those buggy machines.
Have you bothered to ask the person who did the revert?
> WoL is a
Hi David,
We are willing to fix the issue, but we don't have a machine to reproduce it,
and the WoL feature has been removed 5 years ago, it's hard to find
those buggy machines.
WoL is a feature that is only used by a very small group of people,
and the wake up issue
looks like only happens on so
On Mon, May 21, 2018 at 10:30:51AM +0800, Jason Wang wrote:
> On 2018年05月19日 10:29, Tiwei Bie wrote:
> > > I don't hope so.
> > >
> > > > I agreed driver should track the DMA addrs or some
> > > > other necessary things from the very beginning. And
> > > > I also repeated the spec to emphasize tha
On 2018年05月18日 17:24, Jason Wang wrote:
On 2018年05月17日 21:45, DaeRyong Jeong wrote:
We report the crash: KASAN: use-after-free Read in vhost_chr_write_iter
This crash has been found in v4.17-rc1 using RaceFuzzer (a modified
version of Syzkaller), which we describe more at the end of this
re
On 2018年05月21日 00:25, Wei Xu wrote:
On Wed, May 16, 2018 at 08:32:13PM +0800, Jason Wang wrote:
Hi all:
This RFC implement packed ring layout. The code were tested with
Tiwei's RFC V3 ahttps://lkml.org/lkml/2018/4/25/34. Some fixups and
tweaks were needed on top of Tiwei's code to make it run
On 2018年05月19日 10:29, Tiwei Bie wrote:
I don't hope so.
I agreed driver should track the DMA addrs or some
other necessary things from the very beginning. And
I also repeated the spec to emphasize that it does
make sense. And I'd like to do that.
What I was saying is that, to support OOO, we
On Sun, May 20, 2018 at 08:50:59PM -0400, Neil Horman wrote:
> On Sat, May 19, 2018 at 03:44:40PM +0800, Xin Long wrote:
> > This feature is actually already supported by sk->sk_reuse which can be
> > set by SO_REUSEADDR. But it's not working exactly as RFC6458 demands in
> > section 8.1.27, like:
From: Fabio Estevam Sent: 2018年5月21日 0:55
> Adopt the SPDX license identifier headers to ease license compliance
> management.
>
> Signed-off-by: Fabio Estevam
Acked-by: Fugang Duan
> ---
> drivers/net/ethernet/freescale/fec_ptp.c | 14 +-
> 1 file changed, 1 insertion(+), 13 del
From: Fabio Estevam Sent: 2018年5月21日 0:55
> From: Fabio Estevam
>
> Currently there is no license information in the header of this file.
>
> The MODULE_LICENSE field contains ("GPL"), which means GNU Public
> License v2 or later, so add a corresponding SPDX license identifier.
>
> Signed-off
On Sat, May 19, 2018 at 03:44:40PM +0800, Xin Long wrote:
> This feature is actually already supported by sk->sk_reuse which can be
> set by SO_REUSEADDR. But it's not working exactly as RFC6458 demands in
> section 8.1.27, like:
>
> - This option only supports one-to-one style SCTP sockets
>
Hi Wenwen,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc5 next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/c
Sorry, no drug fuelled pull request this time. As for the commits
themselves, I can't say for sure :-)
1) Fix refcounting bug for connections in on-packet scheduling
mode of IPVS, from Julian Anastasov.
2) Set network header properly in AF_PACKET's packet_snd, from
Willem de Bruijn.
On Sun, May 20, 2018 at 6:51 PM, Willem de Bruijn
wrote:
> On Sat, May 19, 2018 at 8:07 AM, Jon Rosen wrote:
>> Fix PACKET_RX_RING bug for versions TPACKET_V1 and TPACKET_V2 which
>> casues the ring to get corrupted by allowing multiple kernel threads
>> to claim ownership of the same ring entry.
On Fri, May 18, 2018 at 2:59 PM, Willem de Bruijn
wrote:
> On Fri, May 18, 2018 at 2:46 PM, Willem de Bruijn
> wrote:
>> On Fri, May 18, 2018 at 2:44 PM, Willem de Bruijn
>> wrote:
>>> On Fri, May 18, 2018 at 1:09 PM, Willem de Bruijn
>>> wrote:
On Fri, May 18, 2018 at 11:44 AM, David Mill
>
> -static void sock_disable_timestamp(struct sock *sk, unsigned long flags)
> +static void sock_disable_timestamp(struct sock *sk, unsigned long flag)
> {
> - if (sk->sk_flags & flags) {
> - sk->sk_flags &= ~flags;
> - if (sock_needs_netstamp(sk) &&
> -
On Fri, May 18, 2018 at 4:30 PM, Willem de Bruijn
wrote:
> On Fri, May 18, 2018 at 4:03 AM, DaeRyong Jeong wrote:
>> We report the crash: WARNING in __static_key_slow_dec
>>
>> This crash has been found in v4.8 using RaceFuzzer (a modified
>> version of Syzkaller), which we describe more at the e
In mv88e6xxx_probe(), ("np" or "pdata") might be an invariant
but GCC can't see that, therefore:
drivers/net/dsa/mv88e6xxx/chip.c: In function ‘mv88e6xxx_probe’:
drivers/net/dsa/mv88e6xxx/chip.c:4420:13: warning: ‘compat_info’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
From: Florian Fainelli
Date: Sun, 20 May 2018 08:56:30 -0700
> The b53 driver already defines and internally uses platform data to let the
> glue drivers specify parameters such as the chip id. What we were missing was
> a way to tell the core DSA layer about the ports and their type.
>
> Place
From: Andrew Lunn
Date: Sat, 19 May 2018 22:31:32 +0200
> There are a few Intel based platforms making use of the mv88exxx.
> These don't easily have access to device tree in order to instantiate
> the switch driver. These patches allow the use of platform data to
> hold the configuration.
Serie
From: Sergei Shtylyov
Date: Sat, 19 May 2018 23:57:50 +0300
> Here's a set of 3 patches against DaveM's 'net-next.git' repo plus the
> R8A77980
> support patches posted earlier. They fix the comments typos/grammar and
> another
> typo in the EESR bit...
Series applied.
From: Salil Mehta
Date: Sat, 19 May 2018 16:53:14 +0100
> This patch-set presents miscellaneous bug fixes and cleanups found
> during internal review, system testing and cleanup.
Series applied, thank you.
On Sat, May 19, 2018 at 8:07 AM, Jon Rosen wrote:
> Fix PACKET_RX_RING bug for versions TPACKET_V1 and TPACKET_V2 which
> casues the ring to get corrupted by allowing multiple kernel threads
> to claim ownership of the same ring entry. Track ownership in a shadow
> ring structure to prevent other
On Mon, May 21, 2018 at 12:40:54AM +0300, Or Gerlitz wrote:
> On Mon, May 21, 2018 at 12:33 AM, Marcelo Ricardo Leitner
> wrote:
> > On Mon, May 21, 2018 at 12:13:06AM +0300, Or Gerlitz wrote:
> >> On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner
> >> wrote:
> >> > On Mon, May 14, 2018 at
From: Heiner Kallweit
Date: Sat, 19 May 2018 10:29:33 +0200
> This commit removed calls to rtl_set_rx_mode(). This is ok for the
> standard path if the link is brought up, however it breaks system
> resume from suspend. Link comes up but no network traffic.
>
> Meanwhile common code from rtl_hw_
From: Wenwen Wang
Date: Fri, 18 May 2018 16:33:47 -0500
> In divasmain.c, the function divas_write() firstly invokes the function
> diva_xdi_open_adapter() to open the adapter that matches with the adapter
> number provided by the user, and then invokes the function diva_xdi_write()
> to perform
From: William Tu
Date: Fri, 18 May 2018 19:41:01 -0700
> Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not
> handled. BSO has 4 possible values:
> 00 --> Good frame with no error, or unknown integrity
> 11 --> Payload is a Bad Frame with CRC or Alignment Error
> 01 --> Payl
From: Johan Hedberg
Date: Fri, 18 May 2018 22:51:05 +0300
> Here's the first bluetooth-next pull request for the 4.18 kernel:
>
> - Refactoring of the btbcm driver
> - New USB IDs for QCA_ROME and LiteOn controllers
> - Buffer overflow fix if the controller sends invalid advertising data leng
From: Jeff Kirsher
Date: Fri, 18 May 2018 11:58:30 -0700
> This reverts commit 6710f970d9979d8f03f6e292bb729b2ee1526d0e.
>
> Gotta love when developers have offline discussions, thinking everyone
> is reading their responses/dialog.
>
> The change had the potential for a number of race conditio
From: Hemanth Puranik
Date: Fri, 18 May 2018 08:59:29 +0530
> Currently we use non-NUMA aware allocation for TPD and RRD buffers,
> this patch modifies to use NUMA friendly allocation.
>
> Signed-off-by: Hemanth Puranik
> ---
> Change since v1:
> - Addressed comments related to ordering
Applie
On Mon, May 21, 2018 at 12:33 AM, Marcelo Ricardo Leitner
wrote:
> On Mon, May 21, 2018 at 12:13:06AM +0300, Or Gerlitz wrote:
>> On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner
>> wrote:
>> > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote:
>> >> Substitute calls to action i
On Mon, May 21, 2018 at 12:13:06AM +0300, Or Gerlitz wrote:
> On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner
> wrote:
> > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote:
> >> Substitute calls to action insert function with calls to action insert
> >> unique function that war
On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner
wrote:
> On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote:
>> Substitute calls to action insert function with calls to action insert
>> unique function that warns if insertion overwrites index in idr.
>
> I know this patch may be
On Sat, May 19, 2018 at 12:44 AM, Xin Long wrote:
> This feature is actually already supported by sk->sk_reuse which can be
> set by SO_REUSEADDR. But it's not working exactly as RFC6458 demands in
> section 8.1.27, like:
>
> - This option only supports one-to-one style SCTP sockets
> - This s
On Sat 19 May 2018 at 21:52, Marcelo Ricardo Leitner
wrote:
> On Mon, May 14, 2018 at 05:27:10PM +0300, Vlad Buslov wrote:
>> Return from action init function with reference to action taken,
>> even when overwriting existing action.
>
> Isn't this patch necessary before patch 7, to not break thin
On Sun, May 20, 2018 at 08:33:39AM +0100, Al Viro wrote:
> > ... get buggered on attempt to dereference a pointer fetched from freed and
> > reused object.
>
> FWIW, how painful would it be to pull the following trick:
> * insert into wait queue under ->ctx_lock
> * have wakeup do sche
From: Fabio Estevam
Currently there is no license information in the header of
this file.
The MODULE_LICENSE field contains ("GPL"), which means
GNU Public License v2 or later, so add a corresponding
SPDX license identifier.
Signed-off-by: Fabio Estevam
---
drivers/net/ethernet/freescale/fec
From: Fabio Estevam
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Fabio Estevam
---
drivers/net/ethernet/freescale/fec_ptp.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_p
On Wed, May 16, 2018 at 08:32:13PM +0800, Jason Wang wrote:
> Hi all:
>
> This RFC implement packed ring layout. The code were tested with
> Tiwei's RFC V3 ahttps://lkml.org/lkml/2018/4/25/34. Some fixups and
> tweaks were needed on top of Tiwei's code to make it run for event
> index.
Could you
The b53 driver already defines and internally uses platform data to let the
glue drivers specify parameters such as the chip id. What we were missing was
a way to tell the core DSA layer about the ports and their type.
Place a dsa_chip_data structure at the beginning of b53_platform_data for
dsa_
On 05/20/2018 07:06 AM, Andrew Lunn wrote:
> On Sat, May 19, 2018 at 08:14:41PM -0700, Florian Fainelli wrote:
>> On May 19, 2018 6:42:50 PM PDT, Andrew Lunn wrote:
>>> On Sat, May 19, 2018 at 03:55:10PM -0700, Florian Fainelli wrote:
Provide a means for !OF platforms to supply their DSA pl
On Sat, May 19, 2018 at 08:14:41PM -0700, Florian Fainelli wrote:
> On May 19, 2018 6:42:50 PM PDT, Andrew Lunn wrote:
> >On Sat, May 19, 2018 at 03:55:10PM -0700, Florian Fainelli wrote:
> >> Provide a means for !OF platforms to supply their DSA platform data
> >> configuration using the dsa_plat
The function lookup_nexthop is essential to implement most of the seg6local
actions. As we want to provide a BPF helper allowing to apply some of these
actions on the packet being processed, the helper should be able to call
this function, hence the need to make it public.
Moreover, if one argumen
This patch adds the End.BPF action to the LWT seg6local infrastructure.
This action works like any other seg6local End action, meaning that an IPv6
header with SRH is needed, whose DA has to be equal to the SID of the
action. It will also advance the SRH to the next segment, the BPF program
does no
Add a new test for the seg6local End.BPF action. The following helpers
are also tested:
- bpf_lwt_push_encap within the LWT BPF IN hook
- bpf_lwt_seg6_action
- bpf_lwt_seg6_adjust_srh
- bpf_lwt_seg6_store_bytes
A chain of End.BPF actions is built. The SRH is injected through a LWT
BPF IN hook bef
The new bpf_lwt_push_encap helper should only be accessible within the
LWT BPF IN hook, and not the OUT one, as this may lead to a skb under
panic.
At the moment, both LWT BPF IN and OUT share the same list of helpers,
whose calls are authorized by the verifier. This patch separates the
verifier o
The BPF seg6local hook should be powerful enough to enable users to
implement most of the use-cases one could think of. After some thinking,
we figured out that the following actions should be possible on a SRv6
packet, requiring 3 specific helpers :
- bpf_lwt_seg6_store_bytes: Modify non-sensi
include/net/seg6.h cannot be included in a source file if CONFIG_IPV6 is
not enabled:
include/net/seg6.h: In function 'seg6_pernet':
>> include/net/seg6.h:52:14: error: 'struct net' has no member named
'ipv6'; did you mean 'ipv4'?
return net->ipv6.seg
As of Linux 4.14, it is possible to define advanced local processing for
IPv6 packets with a Segment Routing Header through the seg6local LWT
infrastructure. This LWT implements the network programming principles
defined in the IETF “SRv6 Network Programming” draft.
The implemented operations are
2018-05-18 21:24 GMT+01:00 Daniel Borkmann :
>> +#define MAX_PROG_NAME 256
>> +static const struct nla_policy bpf_prog_policy[LWT_BPF_PROG_MAX + 1] = {
>> + [LWT_BPF_PROG_FD] = { .type = NLA_U32, },
>
> From UAPI point of view, I wouldn't name it LWT_BPF_PROG_FD but rather
> something like
>
Hi David,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/David-Ahern/bpf-Add-MTU-check-to-fib-lookup-helper/20180520-103417
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
In bpf_parse_prog, if bpf_prog_get_type fails, the function is
immediately terminated without freeing the previously allocated
prog->name.
This patch adds a kfree before the return.
Signed-off-by: Mathieu Xhonneux
---
net/core/lwt_bpf.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
d
In commit 47b7e7f82802, this bit was removed at the same time the
RT6_LOOKUP_F_IFACE flag was removed. However, it is needed when
link-local addresses are used, which is a very common case: when
packets are routed, neighbor solicitations are done using link-local
addresses. For example, the followi
On Sun 20 May 2018 at 06:22, Jiri Pirko wrote:
> Sat, May 19, 2018 at 11:43:27PM CEST, marcelo.leit...@gmail.com wrote:
>>On Mon, May 14, 2018 at 05:27:07PM +0300, Vlad Buslov wrote:
>>...
>>> @@ -1052,6 +1088,36 @@ static int tca_action_flush(struct net *net, struct
>>> nlattr *nla,
>>> ret
On Sat 19 May 2018 at 21:04, Marcelo Ricardo Leitner
wrote:
> On Mon, May 14, 2018 at 05:27:03PM +0300, Vlad Buslov wrote:
>> Change type of action reference counter to refcount_t.
>>
>> Change type of action bind counter to atomic_t.
>> This type is used to allow decrementing bind counter witho
Now sctp uses inet_dgram_connect as its proto_ops .connect, and the flags
param can't be passed into its proto .connect where this flags is really
needed.
sctp works around it by getting flags from socket file in __sctp_connect.
It works for connecting from userspace, as inherently the user sock h
On Sat, May 19, 2018 at 11:57 PM, Eric Dumazet wrote:
> SCTP experts, please take a look.
>
> On 05/19/2018 08:55 AM, syzbot wrote:
>> Hello,
>>
>> syzbot found the following crash on:
>>
>> HEAD commit:73fcb1a370c7 Merge branch 'akpm' (patches from Andrew)
>> git tree: upstream
>> conso
From: Jiri Pirko
Signed-off-by: Jiri Pirko
---
devlink/devlink.c| 6 ++
include/uapi/linux/devlink.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index df2c66dac1c7..b0ae17767dab 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink
From: Jiri Pirko
Signed-off-by: Jiri Pirko
---
devlink/devlink.c| 20
include/uapi/linux/devlink.h | 12
2 files changed, 32 insertions(+)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index fa33684cb20a..df2c66dac1c7 100644
--- a/devlink/devl
From: Jiri Pirko
Jiri Pirko (2):
devlink: introduce support for showing port flavours
devlink: introduce support for showing port number and split subport
number
devlink/devlink.c| 26 ++
include/uapi/linux/devlink.h | 14 ++
2 files chang
Lieber Freund,
Ich bin Herr Richard Wahl der Mega-Gewinner von $ 533M In Mega Millions Jackpot
spende ich an 5 zufällige Personen, wenn Sie diese E-Mail erhalten, dann wurde
Ihre E-Mail nach einem Spinball ausgewählt. Ich habe den größten Teil meines
Vermögens auf eine Reihe von Wohltätigkeits
On Sun, May 20, 2018 at 06:32:25AM +0100, Al Viro wrote:
> > + spin_lock_irqsave(&ctx->ctx_lock, flags);
> > + list_add_tail(&aiocb->ki_list, &ctx->delayed_cancel_reqs);
> > + spin_unlock(&ctx->ctx_lock);
>
> ... and io_cancel(2) comes, finds it and inhume^Wcompletes it, leaving us
> to...
73 matches
Mail list logo
