Hi Wenwen, Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc5 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Wenwen-Wang/isdn-eicon-fix-a-missing-check-bug/20180521-034229 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): In file included from drivers/isdn/hardware/eicon/divasfunc.c:18:0: >> drivers/isdn/hardware/eicon/diva.h:23:18: error: unknown type name >> 'diva_xdi_um_cfg_cmd_t'; did you mean 'diva_xdi_capi_cfg_t'? int length, diva_xdi_um_cfg_cmd_t *msg, ^~~~~~~~~~~~~~~~~~~~~ diva_xdi_capi_cfg_t drivers/isdn/hardware/eicon/diva.h:27:20: error: unknown type name 'diva_xdi_um_cfg_cmd_t'; did you mean 'diva_xdi_capi_cfg_t'? int length, diva_xdi_um_cfg_cmd_t *msg, ^~~~~~~~~~~~~~~~~~~~~ diva_xdi_capi_cfg_t -- In file included from drivers/isdn/hardware/eicon/divasmain.c:30:0: >> drivers/isdn/hardware/eicon/diva.h:23:18: error: unknown type name >> 'diva_xdi_um_cfg_cmd_t' int length, diva_xdi_um_cfg_cmd_t *msg, ^~~~~~~~~~~~~~~~~~~~~ drivers/isdn/hardware/eicon/diva.h:27:20: error: unknown type name 'diva_xdi_um_cfg_cmd_t' int length, diva_xdi_um_cfg_cmd_t *msg, ^~~~~~~~~~~~~~~~~~~~~ drivers/isdn/hardware/eicon/divasmain.c: In function 'divas_write': >> drivers/isdn/hardware/eicon/divasmain.c:598:24: error: implicit declaration >> of function 'diva_xdi_open_adapter'; did you mean 'diva_xdi_close_adapter'? >> [-Werror=implicit-function-declaration] file->private_data = diva_xdi_open_adapter(file, buf, ^~~~~~~~~~~~~~~~~~~~~ diva_xdi_close_adapter >> drivers/isdn/hardware/eicon/divasmain.c:598:22: warning: assignment makes >> pointer from integer without a cast [-Wint-conversion] file->private_data = diva_xdi_open_adapter(file, buf, ^ >> drivers/isdn/hardware/eicon/divasmain.c:603:9: error: implicit declaration >> of function 'diva_xdi_write'; did you mean 'divas_write'? >> [-Werror=implicit-function-declaration] ret = diva_xdi_write(file->private_data, file, ^~~~~~~~~~~~~~ divas_write drivers/isdn/hardware/eicon/divasmain.c: In function 'divas_read': drivers/isdn/hardware/eicon/divasmain.c:632:22: warning: assignment makes pointer from integer without a cast [-Wint-conversion] file->private_data = diva_xdi_open_adapter(file, buf, ^ cc1: some warnings being treated as errors vim +23 drivers/isdn/hardware/eicon/diva.h 12 13 typedef int (*divas_xdi_copy_to_user_fn_t) (void *os_handle, void __user *dst, 14 const void *src, int length); 15 16 typedef int (*divas_xdi_copy_from_user_fn_t) (void *os_handle, void *dst, 17 const void __user *src, int length); 18 19 int diva_xdi_read(void *adapter, void *os_handle, void __user *dst, 20 int max_length, divas_xdi_copy_to_user_fn_t cp_fn); 21 22 int diva_xdi_write(void *adapter, void *os_handle, const void __user *src, > 23 int length, diva_xdi_um_cfg_cmd_t *msg, 24 divas_xdi_copy_from_user_fn_t cp_fn); 25 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
