Re: [bpf-next v3 8/9] bpf: Provide helper to do forwarding lookups in kernel FIB table

On 5/10/18 12:27 PM, Mathieu Xhonneux wrote: > I'm quite interested in this helper to implement OAM features (through > other hooks, e.g. the BPF LWT hook). Do you have an idea about how it > behaves with ECMP routes (with IPv4 and/or IPv6) ? In IPv6, I'm > guessing that the returned gateway addres

Re:Re: [PATCH net] net: Correct wrong skb_flow_limit check when enable RPS

At 2018-05-11 11:54:55, "Willem de Bruijn" wrote: >On Thu, May 10, 2018 at 4:28 AM, wrote: >> From: Gao Feng >> >> The skb flow limit is implemented for each CPU independently. In the >> current codes, the function skb_flow_limit gets the softnet_data by >> this_cpu_ptr. But the target cpu of

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

On Fri, 11 May 2018, Michael Schmitz wrote: > > I'm afraid using platform_device_register() (which you already use for > the SCC devices) is the only option handling this on a per-device basis > without touching platform core code, while at the same time keeping the > DMA mask setup out of dev

KASAN: null-ptr-deref Read in rds_ib_get_mr

We report the crash: KASAN: null-ptr-deref Read in rds_ib_get_mr Note that this bug is previously reported by syzkaller. https://syzkaller.appspot.com/bug?id=0bb56a5a48b000b52aa2b0d8dd20b1f545214d91 Nonetheless, this bug has not fixed yet, and we hope that this report and our analysis, which gets

Re: [RFC bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

On Wed, May 09, 2018 at 02:07:05PM -0700, Joe Stringer wrote: > This patch adds a new BPF helper function, sk_lookup() which allows BPF > programs to find out if there is a socket listening on this host, and > returns a socket pointer which the BPF program can then access to > determine, for instan

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

Hi Finn, Am 11.05.2018 um 15:28 schrieb Finn Thain: > On Fri, 11 May 2018, Michael Schmitz wrote: > Which begs the question: why can' you set up all Nubus bus devices' DMA masks in nubus_device_register(), or nubus_add_board()? >>> >>> I am expecting to see the same WARNING from the nu

Re: [PATCH net] net: Correct wrong skb_flow_limit check when enable RPS

On Thu, May 10, 2018 at 4:28 AM, wrote: > From: Gao Feng > > The skb flow limit is implemented for each CPU independently. In the > current codes, the function skb_flow_limit gets the softnet_data by > this_cpu_ptr. But the target cpu of enqueue_to_backlog would be not > the current cpu when ena

Re: [PATCH net-next] udp: avoid refcount_t saturation in __udp_gso_segment()

On Thu, May 10, 2018 at 10:07 PM, Eric Dumazet wrote: > For some reason, Willem thought that the issue we fixed for TCP > in commit 7ec318feeed1 ("tcp: gso: avoid refcount_t warning from > tcp_gso_segment()") was not relevant for UDP GSO. > > But syzbot found its way. [..] > Fixes: ad405857b174

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

On Fri, 11 May 2018, Michael Schmitz wrote: > > > Which begs the question: why can' you set up all Nubus bus devices' > > > DMA masks in nubus_device_register(), or nubus_add_board()? > > > > I am expecting to see the same WARNING from the nubus sonic driver but > > it hasn't happened yet, so I

[PATCH] dt-bindings: net: ravb: Add support for r8a77990 SoC

Add documentation for r8a77990 compatible string to renesas ravb device tree bindings documentation. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.

[PATCH net V2] tun: fix use after free for ptr_ring

We used to initialize ptr_ring during TUNSETIFF, this is because its size depends on the tx_queue_len of netdevice. And we try to clean it up when socket were detached from netdevice. A race were spotted when trying to do uninit during a read which will lead a use after free for pointer ring. Solvi

Re: [PATCH] coredump: rename umh_pipe_setup() to coredump_pipe_setup()

On Thu, May 10, 2018 at 11:32:47PM +, Luis R. Rodriguez wrote: > I think net-next makes sense if Al Viro is OK with that. This way it could go > in regardless of the state of your series, but it also lines up with your > work. Fine by me...

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

Hi Finn, On Fri, May 11, 2018 at 11:55 AM, Finn Thain wrote: >> > What's worse, if you do pass a dma_mask in struct >> > platform_device_info, you end up with this problem in >> > platform_device_register_full(): >> > >> > if (pdevinfo->dma_mask) { >> > /* >> >

[PATCH net-next] udp: avoid refcount_t saturation in __udp_gso_segment()

For some reason, Willem thought that the issue we fixed for TCP in commit 7ec318feeed1 ("tcp: gso: avoid refcount_t warning from tcp_gso_segment()") was not relevant for UDP GSO. But syzbot found its way. refcount_t: saturated; leaking memory. WARNING: CPU: 0 PID: 10261 at lib/refcount.c:78 refc

[PATCH bpf-next] samples/bpf: xdp_monitor, accept short options

updated optstring accept short options Signed-off-by: Prashant Bhole --- samples/bpf/xdp_monitor_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf/xdp_monitor_user.c b/samples/bpf/xdp_monitor_user.c index 894bc64c2cac..668511c77aaf 100644 --- a/samples/bpf/xd

Re: [PATCH] mlx4_core: allocate 4KB ICM chunks

Thank you for reviewing it! On 5/10/2018 6:23 PM, Yanjun Zhu wrote: On 2018/5/11 9:15, Qing Huang wrote: On 5/10/2018 5:13 PM, Yanjun Zhu wrote: On 2018/5/11 7:31, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk alloca

Re:Re: [PATCH net] net: Correct wrong skb_flow_limit check when enable RPS

At 2018-05-11 08:55:47, "Eric Dumazet" wrote: > > >On 05/10/2018 05:18 PM, Gao Feng wrote: >> At 2018-05-10 21:02:55, "Eric Dumazet" wrote: >>> >>> >>> On 05/10/2018 01:28 AM, gfree.w...@vip.163.com wrote: From: Gao Feng

Re: linux-next: Signed-off-by missing for commit in the net tree

On Fri, May 11, 2018 at 07:17:16AM +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > 0e8411e426e2 ("ipv4: reset fnhe_mtu_locked after cache route flushed") > > is missing a Signed-off-by from its author. Opps, My bad. > After route cache is flushed via ipv4_sysctl_rtcache_flush(), we f

Re: [PATCH net] tun: fix use after free for ptr_ring

On 2018年05月11日 02:08, Cong Wang wrote: On Tue, May 8, 2018 at 11:59 PM, Jason Wang wrote: We used to initialize ptr_ring during TUNSETIFF, this is because its size depends on the tx_queue_len of netdevice. And we try to clean it up when socket were detached from netdevice. A race were spotted

Re: [PATCH net] net: Correct wrong skb_flow_limit check when enable RPS

On 05/10/2018 05:18 PM, Gao Feng wrote: > At 2018-05-10 21:02:55, "Eric Dumazet" wrote: >> >> >> On 05/10/2018 01:28 AM, gfree.w...@vip.163.com wrote: >>> From: Gao Feng >>> >>> The skb flow limit is implemented for each CPU independently. In the >>> current codes, the function skb_flow_limit g

Re: [PATCH net-next] udp: Fix kernel panic in UDP GSO path

On 05/10/2018 05:38 PM, Sean Tranchetti wrote: > Using GSO in the UDP path on a device with > scatter-gather netdevice feature disabled will result in a kernel > panic with the following call stack: > > This panic is the result of allocating SKBs with small size > for the newly segmented SKB. If

[PATCH net-next] udp: Fix kernel panic in UDP GSO path

Using GSO in the UDP path on a device with scatter-gather netdevice feature disabled will result in a kernel panic with the following call stack: kernel BUG at net/core/skbuff.c:104! Internal error: Oops - BUG: 0 [#1] PREEMPT SMP PC is at skb_panic+0x4c/0x54 LR is at skb_panic+0x4c/0x54 Process ud

Re: [PATCH v6 6/6] MIPS: Boston: Adjust DT for pch_gbe PHY support

> eg20t_mac@2,0,1 { > compatible = "pci8086,8802"; > reg = <0x00020100 0 0 0 0>; > - phy-reset-gpios = <&eg20t_gpio 6 > -

Re: [PATCH v6 6/6] MIPS: Boston: Adjust DT for pch_gbe PHY support

> + ethernet-phy@0 { > + compatible = > "ethernet-phy-id001c.c915"; You only need to specify the compatible string like this if the PHY has its own ID wrong. The AT802x gets this right, so you don't need this.

Re: [PATCH v6 1/6] net: phy: at803x: Export at803x_debug_reg_mask()

On Thu, May 10, 2018 at 04:16:52PM -0700, Paul Burton wrote: > From: Andrew Lunn > > On some boards, this PHY has a problem when it hibernates. Export this > function to a board can register a PHY fixup to disable hibernation. What do you know about the problem? https://patchwork.ozlabs.org/pat

Re:Re: [PATCH net] net: Correct wrong skb_flow_limit check when enable RPS

At 2018-05-10 21:02:55, "Eric Dumazet" wrote: > > >On 05/10/2018 01:28 AM, gfree.w...@vip.163.com wrote: >> From: Gao Feng >> >> The skb flow limit is implemented for each CPU independently. In the >> current codes, the function skb_flow_limit gets the softnet_data by >> this_cpu_ptr. But the ta

Re: [PATCH] mlx4_core: allocate 4KB ICM chunks

On 2018/5/11 7:31, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory allocations.

Re: [PATCH bpf-next 0/7] bpf: add perf event reading loop and move samples closer to libbpf

On 05/10/2018 07:24 PM, Jakub Kicinski wrote: > Hi! > > This series started out as a follow up to the bpftool perf event dumping > patches. > > As suggested by Daniel patch 1 makes use of PERF_SAMPLE_TIME to simplify > code and improve accuracy of timestamps. > > Remaining patches are trying to

[RFC PATCH] ipv6: sr: lwt_seg6local_verifier_ops can be static

Fixes: e7d82c64d15a ("ipv6: sr: Add seg6local action End.BPF") Signed-off-by: Fengguang Wu --- filter.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index ce10f20..9e47c86 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @

Re: [PATCH bpf-next v4 5/6] ipv6: sr: Add seg6local action End.BPF

Hi Mathieu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Mathieu-Xhonneux/ipv6-sr-introduce-seg6local-End-BPF-action/20180511-032546 base: https://git.kernel.org/pub/scm/linux/kernel/git/bp

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

On Fri, 11 May 2018, Michael Schmitz wrote: > > > Perhaps you can add a new helper > > > (platform_device_register_simple_dma()?) that takes the DMA mask, > > > too? ... > > > > So far, it looks like macmace and macsonic would be the only callers > > of this new API call. > > > > What's worse,

[PATCH v6 6/6] MIPS: Boston: Adjust DT for pch_gbe PHY support

The pch_gbe driver support for PHY reset GPIOs is now provided by the standard phylib infrastructure, using a standard PHY binding. Adjust the Boston devicetree to make use of the standard PHY binding. This is possible because we bundle the DT along with the kernel binary into a Flattened Image Tr

Re: [PATCH bpf-next] selftests/bpf: Fix bash reference in Makefile

On 05/11/2018 12:26 AM, Joe Stringer wrote: > '|& ...' is a bash 4.0+ construct which is not guaranteed to be available > when using '$(shell ...)' in a Makefile. Fall back to the more portable > '2>&1 | ...'. > > Fixes the following warning during compilation: > > /bin/sh: 1: Syntax error:

Re: [PATCH] coredump: rename umh_pipe_setup() to coredump_pipe_setup()

On Thu, May 10, 2018 at 04:19:09PM -0700, Alexei Starovoitov wrote: > On Mon, May 07, 2018 at 04:30:02PM -0700, Luis R. Rodriguez wrote: > > This makes it clearer this code is part of the coredump code, and > > is not an exported generic helper from kernel/umh.c. > > > > Signed-off-by: Luis R. Rod

[PATCH v6 5/6] net: pch_gbe: Allow build on MIPS platforms

Allow the pch_gbe driver to be built on MIPS platforms, allowing its use on the MIPS Boston development board. Signed-off-by: Paul Burton Cc: Andrew Lunn Cc: David S. Miller Cc: linux-m...@linux-mips.org Cc: netdev@vger.kernel.org --- Changes in v6: - None. Changes in v5: - None. Changes in

[PATCH] mlx4_core: allocate 4KB ICM chunks

When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory allocations. When that happens, user processes calli

Re: [bpf-next v3 0/9] bpf: Add helper to do FIB lookups

On 05/10/2018 05:34 AM, David Ahern wrote: > Provide a helper for doing a FIB and neighbor lookup in the kernel > tables from an XDP program. The helper provides a fastpath for forwarding > packets. If the packet is a local delivery or for any reason is not a > simple lookup and forward, the packet

[PATCH v6 4/6] ptp: pch: Allow build on MIPS platforms

Allow the ptp_pch driver to be built on MIPS platforms in preparation for use on the MIPS Boston board. Signed-off-by: Paul Burton Acked-by: Richard Cochran Cc: Andrew Lunn Cc: David S. Miller Cc: linux-m...@linux-mips.org Cc: netdev@vger.kernel.org Signed-off-by: Paul Burton --- Changes in

[net 2/3] net/mlx5: E-Switch, Include VF RDMA stats in vport statistics

From: Adi Nissim The host side reporting of VF vport statistics didn't include the VF RDMA traffic. Fixes: 3b751a2a418a ("net/mlx5: E-Switch, Introduce get vf statistics") Signed-off-by: Adi Nissim Reported-by: Ariel Almog Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/ne

[PATCH v6 3/6] net: pch_gbe: Support DeviceTree for MDIO/PHY description

When running on a system which uses device tree, use of_mdiobus_register() rather than plain mdiobus_register() in order to support parsing PHY information from the DT. On systems without CONFIG_OF_MDIO set of_mdiobus_register() falls back to mdiobus_register() anyway, but here we check for a non-

[net 3/3] net/mlx5e: Err if asked to offload TC match on frag being first

From: Roi Dayan The HW doesn't support matching on frag first/later, return error if we are asked to offload that. Fixes: 3f7d0eb42d59 ("net/mlx5e: Offload TC matching on packets being IP fragments") Signed-off-by: Roi Dayan Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/

[PATCH v6 1/6] net: phy: at803x: Export at803x_debug_reg_mask()

From: Andrew Lunn On some boards, this PHY has a problem when it hibernates. Export this function to a board can register a PHY fixup to disable hibernation. Signed-off-by: Andrew Lunn Signed-off-by: Paul Burton Cc: David S. Miller Cc: linux-m...@linux-mips.org Cc: netdev@vger.kernel.org ---

[net 1/3] net/mlx5: Free IRQs in shutdown path

From: Daniel Jurgens Some platforms require IRQs to be free'd in the shutdown path. Otherwise they will fail to be reallocated after a kexec. Fixes: 8812c24d28f4 ("net/mlx5: Add fast unload support in shutdown flow") Signed-off-by: Daniel Jurgens Signed-off-by: Saeed Mahameed --- drivers/net/

Re: [PATCH] coredump: rename umh_pipe_setup() to coredump_pipe_setup()

On Mon, May 07, 2018 at 04:30:02PM -0700, Luis R. Rodriguez wrote: > This makes it clearer this code is part of the coredump code, and > is not an exported generic helper from kernel/umh.c. > > Signed-off-by: Luis R. Rodriguez > --- > fs/coredump.c | 9 + > 1 file changed, 5 insertions(+

[pull request][net 0/3] Mellanox, mlx5 fixes 2018-05-10

on frag being first") Thanks, Saeed. --- The following changes since commit ca3943c4aaff083bc25419f04e549e293590258e: Merge tag 'linux-can-fixes-for-4.17-20180510' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can (2018-05-10 17:57:11 -0400) are availab

[PATCH v6 2/6] net: ethernet: pch_gbe: Convert to mdiobus and phylib

From: Andrew Lunn Convert this driver to use the mdio bus and phylib infrastructure. It will then use the common AT803X PHY driver, rather than use its own code. Have the shared code also handle the GPIO used to reset the PHY. To implement disabling PHY hibernation, which appears to cause issues

[PATCH v6 0/6] net: pch_gbe: MIPS support

The Intel EG20T Platform Controller Hub is used on the MIPS Boston development board to provide various peripherals including ethernet. This series migrates the pch_gbe driver's PHY support to use phylib, implements support for device tree which we use to provide the PHY reset GPIO, and allows the

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Thu, May 10, 2018 at 03:27:24PM -0700, Kees Cook wrote: > On Fri, May 4, 2018 at 12:56 PM, Luis R. Rodriguez wrote: > > What a mighty short list of reviewers. Adding some more. My review below. > > I'd appreciate a Cc on future versions of these patches. > > Me too, please. And likely linux-se

[PATCH net 0/5] rxrpc: Fixes

re so that we can find out if transmission failure occurred on the UDP socket. The patches are tagged here: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-fixes-20180510 and can also be found on the following branch: http://git.kernel.org

[PATCH net 1/5] rxrpc: Fix missing start of call timeout

The expect_rx_by call timeout is supposed to be set when a call is started to indicate that we need to receive a packet by that point. This is currently put back every time we receive a packet, but it isn't started when we first send a packet. Without this, the call may wait forever if the server

[PATCH net 2/5] rxrpc: Fix error reception on AF_INET6 sockets

AF_RXRPC tries to turn on IP_RECVERR and IP_MTU_DISCOVER on the UDP socket it just opened for communications with the outside world, regardless of the type of socket. Unfortunately, this doesn't work with an AF_INET6 socket. Fix this by turning on IPV6_RECVERR and IPV6_MTU_DISCOVER instead if the

[PATCH net 3/5] rxrpc: Fix the min security level for kernel calls

Fix the kernel call initiation to set the minimum security level for kernel initiated calls (such as from kAFS) from the sockopt value. Fixes: 19ffa01c9c45 ("rxrpc: Use structs to hold connection params and protocol info") Signed-off-by: David Howells --- net/rxrpc/af_rxrpc.c |2 +- 1 file

[PATCH net 4/5] rxrpc: Add a tracepoint to log ICMP/ICMP6 and error messages

Add a tracepoint to log received ICMP/ICMP6 events and other error messages. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 30 +++ net/rxrpc/peer_event.c | 46 +- 2 files changed, 53 insertions(+), 23 de

[PATCH net 5/5] rxrpc: Trace UDP transmission failure

Add a tracepoint to log transmission failure from the UDP transport socket being used by AF_RXRPC. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 55 ++ net/rxrpc/conn_event.c | 11 ++-- net/rxrpc/local_event.c |3 +

Re: [PATCH v6 0/5] PCI: Improve PCIe link status reporting

On Thu, May 03, 2018 at 03:00:07PM -0500, Bjorn Helgaas wrote: > This is based on Tal's recent work to unify the approach for reporting PCIe > link speed/width and whether the device is being limited by a slower > upstream link. > > The new pcie_print_link_status() interface appeared in v4.17-rc1;

Re: [PATCH] bpf, doc: clarification for the meaning of 'id'

On 05/10/2018 05:09 AM, Wang YanQing wrote: > For me, as a reader whose mother language isn't English, the > old words bring a little difficulty to catch the meaning, this > patch rewords the subsection in a more clarificatory way. > > This patch also add blank lines as separator at two places > t

Re: [PATCH bpf] tools: bpf: handle NULL return in bpf_prog_load_xattr()

On 05/10/2018 07:09 PM, Jakub Kicinski wrote: > bpf_object__open() can return error pointer as well as NULL. > Fix error handling in bpf_prog_load_xattr() (and indirectly > bpf_prog_load()). > > Fixes: 6f6d33f3b3d0 ("bpf: selftests add sockmap tests") > Signed-off-by: Jakub Kicinski > Reviewed-by

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Fri, May 4, 2018 at 12:56 PM, Luis R. Rodriguez wrote: > What a mighty short list of reviewers. Adding some more. My review below. > I'd appreciate a Cc on future versions of these patches. Me too, please. And likely linux-security-module@ and Jessica too. > On Wed, May 02, 2018 at 09:36:01PM

[PATCH bpf-next] selftests/bpf: Fix bash reference in Makefile

'|& ...' is a bash 4.0+ construct which is not guaranteed to be available when using '$(shell ...)' in a Makefile. Fall back to the more portable '2>&1 | ...'. Fixes the following warning during compilation: /bin/sh: 1: Syntax error: "&" unexpected Signed-off-by: Joe Stringer --- tools

[PATCH net v2] rps: Correct wrong skb_flow_limit check when enable RPS

From: Gao Feng The skb flow limit is implemented for each CPU independently. In the current codes, the function skb_flow_limit gets the softnet_data by this_cpu_ptr. But the target cpu of enqueue_to_backlog would be not the current cpu when enable RPS. As the result, the skb_flow_limit checks the

Re: [PATCH net-next] tcp: switch pacing timer to softirq based hrtimer

From: Eric Dumazet Date: Thu, 10 May 2018 13:55:00 -0700 > > > On 05/10/2018 12:49 PM, Eric Dumazet wrote: >> linux-4.16 got support for softirq based hrtimers. >> TCP can switch its pacing hrtimer to this variant, since this >> avoids going through a tasklet and some atomic operations. >> >

[PATCH v2 net-next] tcp: switch pacing timer to softirq based hrtimer

linux-4.16 got support for softirq based hrtimers. TCP can switch its pacing hrtimer to this variant, since this avoids going through a tasklet and some atomic operations. pacing timer logic looks like other (jiffies based) tcp timers. v2: use hrtimer_try_to_cancel() in tcp_clear_xmit_timers()

Re: pull-request: can 2018-05-10

From: Marc Kleine-Budde Date: Thu, 10 May 2018 18:47:47 +0200 > this is a pull request for net/master consisting of 2 patches. > > Both patches are from Lukas Wunner and fix two problems found in the hi311x > CAN > driver under high load situations. Applied.

Re: [PATCH] qed: fix spelling mistake: "taskelt" -> "tasklet"

From: Colin King Date: Thu, 10 May 2018 15:03:27 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in DP_VERBOSE message text > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH net-next] rocker: Postpone filtering of !added_by_user FDB

From: Petr Machata Date: Thu, 10 May 2018 15:29:46 +0200 > Breaking out of the switch in rocker_switchdev_event() still ends up > scheduling work, except an ill-defined one. This leads to an OOPS cited > below. Fix by postponing the check until rocker_switchdev_event_work(). ... > Fixes: 816a3be

Re: [PATCH net-next] tls: Fix tls_device initialization

From: Boris Pismenny Date: Thu, 10 May 2018 16:27:25 +0300 > Add sg table initialization to fix a BUG_ON encountered when enabling > CONFIG_DEBUG_SG. > > Signed-off-by: Boris Pismenny Applied.

Re: [PATCH][next] net: aquantia: fix unsigned numvecs comparison with less than zero

From: Colin King Date: Thu, 10 May 2018 13:52:01 +0100 > From: Colin Ian King > > The comparison of numvecs < 0 is always false because numvecs is a u32 > and hence the error return from a failed call to pci_alloc_irq_vectores > is never detected. Fix this by using the signed int ret to handle

Re: [PATCH net-next] cxgb4: fix the wrong conversion of Mbps to Kbps

From: Ganesh Goudar Date: Thu, 10 May 2018 16:07:23 +0530 > fix the wrong conversion where 1 Mbps was converted to > 1024 Kbps. > > Signed-off-by: Ganesh Goudar Applied, thanks.

Re: [PATCH net-next 0/4] mlxsw: Support VLAN devices in mirroring offloads

From: Ido Schimmel Date: Thu, 10 May 2018 13:13:02 +0300 > Petr says: > > When offloading "tc action mirred mirror", there are several scenarios > where VLAN devices can show up, that mlxsw can offload on Spectrum > machines. > > I) A direct mirror to a VLAN device on top of a front-panel port

Re: KASAN: use-after-free Read in __dev_queue_xmit

On Wed, May 9, 2018 at 5:05 PM, Willem de Bruijn wrote: > On Wed, May 9, 2018 at 3:36 PM, Eric Dumazet wrote: >> >> >> On 05/09/2018 12:21 PM, Willem de Bruijn wrote: >> >>> Indeed. The skb shared info struct is zeroed by dev_validate_header >>> as a result of dev->hard_header_len exceeding skb->

Re: [PATCH net] sctp: remove sctp_chunk_put from fail_mark err path in sctp_ulpevent_make_rcvmsg

From: Xin Long Date: Thu, 10 May 2018 17:34:13 +0800 > In Commit 1f45f78f8e51 ("sctp: allow GSO frags to access the chunk too"), > it held the chunk in sctp_ulpevent_make_rcvmsg to access it safely later > in recvmsg. However, it also added sctp_chunk_put in fail_mark err path, > which is only tr

Re: [PATCH v2] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

From: Christophe JAILLET Date: Thu, 10 May 2018 09:06:04 +0200 > If an error occurs, 'mlx4_en_destroy_netdev()' is called. > It then calls 'mlx4_en_free_resources()' which does the needed resources > cleanup. > > So, doing some explicit kfree in the error handling path would lead to > some doubl

Re: [PATCH net-next v2] tcp: Add mark for TIMEWAIT sockets

From: Jon Maxwell Date: Thu, 10 May 2018 16:53:51 +1000 > This version has some suggestions by Eric Dumazet: > > - Use a local variable for the mark in IPv6 instead of ctl_sk to avoid SMP > races. > - Use the more elegant "IP4_REPLY_MARK(net, skb->mark) ?: sk->sk_mark" > statement. > - Factor

Re: [PATCH] net: ipv4: remove define INET_CSK_DEBUG and unnecessary EXPORT_SYMBOL

From: Joe Perches Date: Wed, 9 May 2018 23:24:07 -0700 > INET_CSK_DEBUG is always set and only is used for 2 pr_debug calls. > > EXPORT_SYMBOL(inet_csk_timer_bug_msg) is only used by these 2 > pr_debug calls and is also unnecessary as the exported string can > be used directly by these calls. >

Re: [PATCH net-next] net/core: correct the variable name in dev_ioctl() comment

From: Sun Lianwen Date: Thu, 10 May 2018 11:01:20 +0800 > The variable name is not "arg" but "ifr" in dev_ioctl() > > Signed-off-by: Sun Lianwen If you are going to touch this, fix it full by adding the need_copyout variable to the comment as well.

Re: [PATCH net] hv_netvsc: set master device

From: Stephen Hemminger Date: Wed, 9 May 2018 14:09:04 -0700 > The hyper-v transparent bonding should have used master_dev_link. > The netvsc device should look like a master bond device not > like the upper side of a tunnel. > > This makes the semantics the same so that userspace applications

Re: pull-request: mac80211 2018-05-09

From: Johannes Berg Date: Wed, 9 May 2018 21:36:12 +0200 > We just have a few fixes this time around. > > Please pull and let me know if there's any problem. Pulled, thank you!

Re: pull-request: mac80211-next 2018-05-09

From: Johannes Berg Date: Wed, 09 May 2018 23:29:37 +0200 > Hi, > > Sorry, scratch that. > > I forgot that this commit: > >> Toke Høiland-Jørgensen (3): > >> cfg80211: Expose TXQ stats and parameters to userspace > > caused a bunch of "too much stack" warnings - I should put in at leas

Re: [PATCH net-next] liquidio: bump up driver version to 1.7.2 to match newer NIC firmware

From: Felix Manlunas Date: Wed, 9 May 2018 11:49:38 -0700 > Signed-off-by: Felix Manlunas Applied.

Re: [PATCH net-next] liquidio: monitor all of Octeon's cores in watchdog thread

From: Felix Manlunas Date: Wed, 9 May 2018 11:31:31 -0700 > The liquidio_watchdog kernel thread is watching over only 12 cores of the > Octeon CN23XX; it's neglecting the other 4 cores that are present in the > CN2360. Fix it by defining LIO_MAX_CORES as 16. > > Signed-off-by: Felix Manlunas

Re: [net-next v2 0/6][pull request] 100GbE Intel Wired LAN Driver Updates 2018-05-09

From: Jeff Kirsher Date: Wed, 9 May 2018 11:10:05 -0700 > This series contains updates to fm10k only. > > Jake provides all the changes in the series, starting with adding > support for accelerated MACVLAN devices. Reduced code duplication by > implementing a macro to be used when setting up t

Re: [PATCH net] net/ipv6: fix lock imbalance in ip6_route_del()

From: Eric Dumazet Date: Wed, 9 May 2018 10:05:46 -0700 > WARNING: lock held when returning to user space! > 4.17.0-rc3+ #37 Not tainted ... > Fixes: 23fb93a4d3f1 ("net/ipv6: Cleanup exception and cache route handling") > Signed-off-by: Eric Dumazet > Cc: David Ahern > Reported-by: syzbot A

Re: [PATCH net] tipc: fix one byte leak in tipc_sk_set_orig_addr()

From: Eric Dumazet Date: Wed, 9 May 2018 09:50:22 -0700 > sysbot/KMSAN reported an uninit-value in recvmsg() that > I tracked down to tipc_sk_set_orig_addr(), missing > srcaddr->member.scope initialization. > > This patches moves srcaddr->sock.scope init to follow > fields order and ease future

Re: [PATCH net] tc-testing: fix tdc tests for 'bpf' action

From: Davide Caratti Date: Wed, 9 May 2018 18:45:42 +0200 > - correct a typo in the value of 'matchPattern' of test 282d, potentially > causing false negative > - allow errors when 'teardown' executes '$TC action flush action bpf' in > test 282d, to fix false positive when it is run with act_b

Re: [PATCH ghak81 RFC V1 5/5] audit: collect audit task parameters

On 2018-05-09 11:46, Paul Moore wrote: > On Fri, May 4, 2018 at 4:54 PM, Richard Guy Briggs wrote: > > The audit-related parameters in struct task_struct should ideally be > > collected together and accessed through a standard audit API. > > > > Collect the existing loginuid, sessionid and audit_c

Re: [PATCH net-next 0/4] Misc bug fixes for HNS3 Ethernet Driver

From: Salil Mehta Date: Wed, 9 May 2018 17:24:37 +0100 > Fixes to some of the bugs found during system test, internal review > and clean-up Series applied, thank you.

Re: [PATCH net-next] hv_netvsc: typo in NDIS RSS parameters structure

From: Stephen Hemminger Date: Wed, 9 May 2018 09:00:07 -0700 > Fix simple misspelling kashkey_offset should be hashkey_offset. > > Signed-off-by: Stephen Hemminger Applied.

Re: [PATCH v3 next-next] drivers: net: davinci_mdio: prevent spurious timeout

From: Sekhar Nori Date: Wed, 9 May 2018 21:15:15 +0530 > A well timed kernel preemption in the time_after() loop > in wait_for_idle() can result in a spurious timeout > error to be returned. > > Fix it by using readl_poll_timeout() which takes care of > this issue. > > Reviewed-by: Andrew Lunn

Re: [PATCH ghak81 RFC V1 1/5] audit: normalize loginuid read access

On 2018-05-09 11:13, Paul Moore wrote: > On Fri, May 4, 2018 at 4:54 PM, Richard Guy Briggs wrote: > > Recognizing that the loginuid is an internal audit value, use an access > > function to retrieve the audit loginuid value for the task rather than > > reaching directly into the task struct to ge

Re: [PATCH ghak81 RFC V1 3/5] audit: use inline function to get audit context

On 2018-05-09 11:28, Paul Moore wrote: > On Fri, May 4, 2018 at 4:54 PM, Richard Guy Briggs wrote: > > Recognizing that the audit context is an internal audit value, use an > > access function to retrieve the audit context pointer for the task > > rather than reaching directly into the task struct

linux-next: Signed-off-by missing for commit in the net tree

Hi all, Commit 0e8411e426e2 ("ipv4: reset fnhe_mtu_locked after cache route flushed") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgp2hPLk4JDiD.pgp Description: OpenPGP digital signature

Re: [PATCH net] sctp: remove sctp_chunk_put from fail_mark err path in sctp_ulpevent_make_rcvmsg

On Thu, May 10, 2018 at 05:34:13PM +0800, Xin Long wrote: > In Commit 1f45f78f8e51 ("sctp: allow GSO frags to access the chunk too"), > it held the chunk in sctp_ulpevent_make_rcvmsg to access it safely later > in recvmsg. However, it also added sctp_chunk_put in fail_mark err path, > which is only

Re: [PATCH net-next] tcp: switch pacing timer to softirq based hrtimer

On 05/10/2018 12:49 PM, Eric Dumazet wrote: > linux-4.16 got support for softirq based hrtimers. > TCP can switch its pacing hrtimer to this variant, since this > avoids going through a tasklet and some atomic operations. > I need to send a V2, adding a test of hrtimer_cancel() return value in

Re: [PATCH v6 4/5] ixgbe: Report PCIe link properties with pcie_print_link_status()

On Thu, 2018-05-03 at 15:00 -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Previously the driver used pcie_get_minimum_link() to warn when the > NIC > is in a slot that can't supply as much bandwidth as the NIC could > use. > > pcie_get_minimum_link() can be misleading because it finds th

Re: [PATCH v6 5/5] PCI: Remove unused pcie_get_minimum_link()

On Thu, 2018-05-10 at 11:33 -0500, Bjorn Helgaas wrote: > On Thu, May 03, 2018 at 03:00:43PM -0500, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > In some cases pcie_get_minimum_link() returned misleading > > information > > because it found the slowest link and the narrowest link without >

Re: [PATCH net-next v2 3/9] net: phy: phylink: Poll link GPIOs

On 05/10/2018 01:29 PM, Russell King - ARM Linux wrote: > On Thu, May 10, 2018 at 01:17:31PM -0700, Florian Fainelli wrote: >> From: Russell King >> >> When using a fixed link with a link GPIO, we need to poll that GPIO to >> determine link state changes. This is consistent with what fixed_phy.c d

Re: [PATCH net-next v2 3/9] net: phy: phylink: Poll link GPIOs

On Thu, May 10, 2018 at 01:17:31PM -0700, Florian Fainelli wrote: > From: Russell King > > When using a fixed link with a link GPIO, we need to poll that GPIO to > determine link state changes. This is consistent with what fixed_phy.c does. > > Signed-off-by: Florian Fainelli I'd like this to

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

Hi Finn, On Thu, May 10, 2018 at 1:25 PM, Finn Thain wrote: > On Thu, 3 May 2018, Geert Uytterhoeven wrote: > >> >> Perhaps you can add a new helper >> (platform_device_register_simple_dma()?) that takes the DMA mask, too? [...] > To actually hoist the dma mask setup out of existing platform driv

[PATCH net-next v2 5/9] net: dsa: bcm_sf2: Implement phylink_mac_ops

Make the bcm_sf2 driver implement phylink_mac_ops since it needs to support a wide variety of network interfaces: internal & external MDIO PHYs, fixed PHYs, MoCA with MMIO link status. A large amount of what needs to be done already exists under bcm_sf2_sw_adjust_link() so we are essentially break

[PATCH net-next v2 4/9] net: dsa: Add PHYLINK switch operations

In preparation for adding support for PHYLINK within DSA, define a number of operations that we will need and that switch drivers can start implementing. Proper integration with PHYLINK will follow in subsequent patches. We start selecting PHYLINK (which implies PHYLIB) in net/dsa/Kconfig such tha

  1   2   3   >