On Fri, 11 May 2018, Michael Schmitz wrote: > > > Which begs the question: why can' you set up all Nubus bus devices' > > > DMA masks in nubus_device_register(), or nubus_add_board()? > > > > I am expecting to see the same WARNING from the nubus sonic driver but > > it hasn't happened yet, so I don't have a patch for it yet. In > > anycase, the nubus fix would be a lot like the zorro bus fix, so I > > don't see a problem. > > That's odd. But what I meant to say is that by setting up > dma_coherent_mask in nubus_add_board(), and pointing dma_mask to that, > ypu won't need any patches to Nubus device drivers.
Right. I think I've already acknowledged that. But it's off-topic, because the patches under review are for platform drivers. Those patches fix an actual bug that I've observed. Whereas, the nubus driver dma mask issue that you raised is purely theoretical at this stage. --
