Re: [PATCH] isdn: eicon: fix a missing-check bug

2018-05-08 Thread Tobin C. Harding
On Wed, May 09, 2018 at 12:30:18AM -0500, Wenwen Wang wrote: > Hello > > Could you please review this patch? We need a confirmation because we > are working on an approaching deadline. I didn't know 'we' had deadlines :) Tobin

Re: linux-next: manual merge of the bpf-next tree with the s390 tree

2018-05-08 Thread Daniel Borkmann
On 05/09/2018 06:21 AM, Stephen Rothwell wrote: > Hi all, > > On Tue, 8 May 2018 10:26:38 +1000 Stephen Rothwell > wrote: >> >> Today's linux-next merge of the bpf-next tree got a conflict in: >> >> arch/s390/net/bpf_jit.S >> >> between commit: >> >> de5cb6eb514e ("s390: use expoline thunks

Re: BUG: please report to d...@vger.kernel.org => prev = 0, last = 0 at net/dccp/ccids/lib/packet_history.c:LINE/tfrc_rx_his

2018-05-08 Thread Eric Biggers
On Wed, May 09, 2018 at 07:23:41AM +0200, 'Dmitry Vyukov' via syzkaller-bugs wrote: > On Wed, May 9, 2018 at 7:05 AM, Eric Biggers wrote: > > On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit:c1c07416cdd4 M

Re: [PATCH] isdn: eicon: fix a missing-check bug

2018-05-08 Thread Wenwen Wang
Hello Could you please review this patch? We need a confirmation because we are working on an approaching deadline. Thanks! Wenwen On Sat, May 5, 2018 at 2:32 PM, Wenwen Wang wrote: > In divasmain.c, the function divas_write() firstly invokes the function > diva_xdi_open_adapter() to open the a

Re: BUG: please report to d...@vger.kernel.org => prev = 0, last = 0 at net/dccp/ccids/lib/packet_history.c:LINE/tfrc_rx_his

2018-05-08 Thread Dmitry Vyukov
On Wed, May 9, 2018 at 7:05 AM, Eric Biggers wrote: > On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:c1c07416cdd4 Merge tag 'kbuild-fixes-v4.17' of git://git.k.. >> git tree: upstream >> console output: https

Re: BUG: please report to d...@vger.kernel.org => prev = 0, last = 0 at net/dccp/ccids/lib/packet_history.c:LINE/tfrc_rx_his

2018-05-08 Thread Eric Biggers
On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:c1c07416cdd4 Merge tag 'kbuild-fixes-v4.17' of git://git.k.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=13d5de4780 > kernel

linux-next: build warning after merge of the bpf-next tree

2018-05-08 Thread Stephen Rothwell
Hi all, After merging the bpf-next tree, today's linux-next build (x86_64 allmodconfig) produced this warning: In file included from include/linux/dma-mapping.h:5:0, from include/linux/skbuff.h:34, from include/linux/if_ether.h:23, from include/u

Re: KASAN: out-of-bounds Read in ip6_xmit

2018-05-08 Thread Eric Biggers
On Sun, Jan 28, 2018 at 11:24:01AM -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > 6bb46bc57c8e9ce947cc605e555b7204b44d2b10 (Fri Jan 26 16:00:23 2018 +) > Merge branch 'cxgb4-fix-dump-collection-when-firmware-crashed' > > Unfortunately, I don't have any r

Re: KASAN: use-after-free Read in ip6_xmit

2018-05-08 Thread Eric Biggers
On Thu, Jan 04, 2018 at 02:58:01AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 0e08c463db387a2adcb0243b15ab868a73f87807 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console o

Re: linux-next: manual merge of the bpf-next tree with the s390 tree

2018-05-08 Thread Stephen Rothwell
Hi all, On Tue, 8 May 2018 10:26:38 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the bpf-next tree got a conflict in: > > arch/s390/net/bpf_jit.S > > between commit: > > de5cb6eb514e ("s390: use expoline thunks in the BPF JIT") > > from the s390 tree and commit: > > e

linux-next: manual merge of the net-next tree with the net tree

2018-05-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: tools/testing/selftests/net/Makefile between commit: 1751eb42ddb5 ("selftests: net: use TEST_PROGS_EXTENDED") from the net tree and commits: a7b15ab887e5 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/

linux-next: manual merge of the net-next tree with the net tree

2018-05-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/tls/tls_main.c between commit: 98f0a39529e5 ("tls: fix use after free in tls_sk_proto_close") from the net tree and commit: f66de3ee2c16 ("net/tls: Split conf to rx + tx") from the net-next tree. I fixed it u

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

2018-05-08 Thread Jason Wang
On 2018年05月08日 17:44, Tiwei Bie wrote: On Tue, May 08, 2018 at 05:34:40PM +0800, Jason Wang wrote: On 2018年05月08日 17:16, Tiwei Bie wrote: On Tue, May 08, 2018 at 03:16:53PM +0800, Jason Wang wrote: On 2018年05月08日 14:44, Tiwei Bie wrote: On Tue, May 08, 2018 at 01:40:40PM +0800, Jason Wang w

Re: BUG: spinlock bad magic in tun_do_read

2018-05-08 Thread Jason Wang
On 2018年05月09日 10:50, Cong Wang wrote: On Mon, May 7, 2018 at 11:04 PM, Eric Dumazet wrote: On 05/07/2018 10:54 PM, Cong Wang wrote: Yeah, we should return early before hitting this uninitialized ptr ring... Something like: diff --git a/drivers/net/tun.c b/drivers/net/tun.c index ef33950a4

[PATCH net-next] net: dsa: fix added_by_user switchdev notification

2018-05-08 Thread Vivien Didelot
Commit 161d82de1ff8 ("net: bridge: Notify about !added_by_user FDB entries") causes the below oops when bringing up a slave interface, because dsa_port_fdb_add is still scheduled, but with a NULL address. To fix this, keep the dsa_slave_switchdev_event function agnostic of the notified info struct

Re: [PATCH net] r8169: fix powering up RTL8168h

2018-05-08 Thread David Miller
From: Heiner Kallweit Date: Mon, 7 May 2018 21:11:21 +0200 > Since commit a92a08499b1f "r8169: improve runtime pm in general and > suspend unused ports" interfaces w/o link are runtime-suspended after > 10s. On systems where drivers take longer to load this can lead to the > situation that the in

Re: BUG: spinlock bad magic in tun_do_read

2018-05-08 Thread Cong Wang
On Mon, May 7, 2018 at 11:04 PM, Eric Dumazet wrote: > > > On 05/07/2018 10:54 PM, Cong Wang wrote: >> >> Yeah, we should return early before hitting this uninitialized ptr ring... >> Something like: >> >> diff --git a/drivers/net/tun.c b/drivers/net/tun.c >> index ef33950a45d9..638c87a95247 10064

Re: KASAN: use-after-free Read in work_is_static_object

2018-05-08 Thread Eric Biggers
On Mon, Jan 08, 2018 at 12:58:11PM +0100, 'Dmitry Vyukov' via syzkaller-bugs wrote: > On Mon, Jan 8, 2018 at 12:55 PM, Dmitry Vyukov wrote: > > On Mon, Jan 8, 2018 at 12:43 PM, syzbot > > wrote: > >> Hello, > >> > >> syzkaller hit the following crash on > >> f66faae2f80a45feafc04ce63ef744ac4b6e8

Re: ICMP redirect and VRF

2018-05-08 Thread David Ahern
On 5/8/18 3:27 PM, Ben Greear wrote: > While debugging some other problem today on a system using ip rules > instead of > VRF, I ran into a case where the remote router was sending back ICMP > redirects. > > That got me thinking...where would these routes get stored in a VRF > scenario? > > Would

[PATCH bpf] nfp: bpf: allow zero-length capabilities

2018-05-08 Thread Jakub Kicinski
Some BPF capabilities carry no value, they simply indicate feature is present. Our capability parsing loop will exit early if last capability is zero-length because it's looking for more than 8 bytes of data (8B is our TLV header length). Allow the last capability to be zero-length. This bug wou

Re: [PATCH bpf-next 0/2] nfp: bpf: add programmable RSS support

2018-05-08 Thread Alexei Starovoitov
On Tue, May 08, 2018 at 07:37:05PM -0700, Jakub Kicinski wrote: > Hi! > > This small series adds a feature which extends BPF offload beyond > a pure host processing offload and firmly into the realm of > heterogeneous processing. Allowing offloaded XDP programs to set > the RX queue index opens t

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-05-08 Thread AceLan Kao
Hi, I didn't get any response around one month. I'm still here hoping you can consider accepting the WoL patch. Without that patch, people have no chance to bump into the issue and have no chance to fix it. Moreover, it leads to the dkms package be spreaded around, and it'll become a more annoyin

[PATCH bpf-next 0/2] nfp: bpf: add programmable RSS support

2018-05-08 Thread Jakub Kicinski
Hi! This small series adds a feature which extends BPF offload beyond a pure host processing offload and firmly into the realm of heterogeneous processing. Allowing offloaded XDP programs to set the RX queue index opens the door for defining fully programmable RSS/n-tuple filter replacement. In

[PATCH bpf-next 1/2] bpf: xdp: allow offloads to store into rx_queue_index

2018-05-08 Thread Jakub Kicinski
It's fairly easy for offloaded XDP programs to select the RX queue packets go to. We need a way of expressing this in the software. Allow write to the rx_queue_index field of struct xdp_md for device-bound programs. Skip convert_ctx_access callback entirely for offloads. Signed-off-by: Jakub Kic

[PATCH bpf-next 2/2] nfp: bpf: support setting the RX queue index

2018-05-08 Thread Jakub Kicinski
BPF has access to all internal FW datapath structures. Including the structure containing RX queue selection. With little coordination with the datapath we can let the offloaded BPF select the RX queue. We just need a way to tell the datapath that queue selection has already been done and it shou

Re: [net-next PATCH v3 0/6] UDP GSO Segmentation clean-ups

2018-05-08 Thread David Miller
From: Alexander Duyck Date: Mon, 7 May 2018 13:03:47 -0700 > On Mon, May 7, 2018 at 11:08 AM, Alexander Duyck > wrote: >> This patch set addresses a number of issues I found while sorting out >> enabling UDP GSO Segmentation support for ixgbe/ixgbevf. Specifically there >> were a number of issue

Re: [PATCH v2 net-next 2/4] net: add skeleton of bpfilter kernel module

2018-05-08 Thread Alexei Starovoitov
On Mon, May 07, 2018 at 06:51:24PM +, Luis R. Rodriguez wrote: > > Notice that _binary_net_bpfilter_bpfilter_umh_start - end > > is placed into .init.rodata section, so it's freed as soon as __init > > function of bpfilter.ko is finished. > > As part of __init the bpfilter.ko does first request

Re: [PATCH net-next v10 3/4] netdev: octeon-ethernet: Add Cavium Octeon III support.

2018-05-08 Thread David Miller
From: "Steven J. Hill" Date: Mon, 7 May 2018 12:22:10 -0500 > +static atomic_t request_mgmt_once; > +static atomic_t load_driver_once; > +static atomic_t pki_id; ... > + /* One time request driver module */ > + if (is_mix) { > + if (atomic_cmpxchg(&re

[PATCH bpf-next] bpf: sync tools bpf.h uapi header

2018-05-08 Thread Prashant Bhole
sync the header from include/uapi/linux/bpf.h which was updated to add fib lookup helper function. This fixes selftests/bpf build failure Signed-off-by: Prashant Bhole --- tools/include/uapi/linux/bpf.h | 84 +- 1 file changed, 83 insertions(+), 1 deletion

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-08 Thread Cong Wang
On Tue, May 8, 2018 at 6:29 AM, Jamal Hadi Salim wrote: > Have you considered using skb->prio instead of peeking into the packet > header. > Also have you looked at the dsmark qdisc? > dsmark modifies ds fields, while this one just maps ds fields into different queues.

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

2018-05-08 Thread Alexei Starovoitov
On Mon, May 07, 2018 at 06:39:31PM +, Luis R. Rodriguez wrote: > > > Are you saying make 'static struct vfsmount *shm_mnt;' > > global and use it here? so no init_tmpfs() necessary? > > I think that can work, but feels that having two > > tmpfs mounts (one for shmem and one for umh) is cleaner

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-08 Thread Cong Wang
On Tue, May 8, 2018 at 5:59 AM, Michel Machado wrote: >>> Overall it looks good to me, just one thing below: >>> +struct Qdisc_ops gkprio_qdisc_ops __read_mostly = { + .id = "gkprio", + .priv_size = sizeof(struct gkprio_sched_data), +

pull-request Cavium liquidio firmware v1.7.2

2018-05-08 Thread Felix Manlunas
The following changes since commit 8fc2d4e55685bf73b6f7752383da9067404a74bb: Merge git://git.marvell.com/mwifiex-firmware (2018-05-07 09:09:40 -0400) are available in the git repository at: https://github.com/felix-cavium/linux-firmware.git for-upstreaming-v1.7.2 for you to fetch changes up

Re: [PATCH ghak81 RFC V1 4/5] audit: use inline function to set audit context

2018-05-08 Thread Tobin C. Harding
On Fri, May 04, 2018 at 04:54:37PM -0400, Richard Guy Briggs wrote: > Recognizing that the audit context is an internal audit value, use an > access function to set the audit context pointer for the task > rather than reaching directly into the task struct to set it. > > Signed-off-by: Richard Guy

Re: [PATCH bpf-next v3 3/6] bpf: Add IPv6 Segment Routing helpers

2018-05-08 Thread Alexei Starovoitov
On Mon, May 07, 2018 at 11:21:11PM +0100, Mathieu Xhonneux wrote: > I'm not sure what would be the best approach here. These errors appear > when CONFIG_IPV6=m and CONFIG_IPV6_SEG6_LWTUNNEL=y (which is bool and > depends on IPv6, hence it is also modularized in this case), then > IS_ENABLED(CONFIG_

Re: [PATCH ghak81 RFC V1 2/5] audit: convert sessionid unset to a macro

2018-05-08 Thread Richard Guy Briggs
On 2018-05-04 16:54, Richard Guy Briggs wrote: > Use a macro, "AUDIT_SID_UNSET", to replace each instance of > initialization and comparison to an audit session ID. > > Signed-off-by: Richard Guy Briggs There's a minor issue with this patch, adding a header include to init/init_task.c in this pa

[net-next 1/1] tipc: clean up removal of binding table items

2018-05-08 Thread Jon Maloy
In commit be47e41d77fb ("tipc: fix use-after-free in tipc_nametbl_stop") we fixed a problem caused by premature release of service range items. That fix is correct, and solved the problem. However, it doesn't address the root of the problem, which is that we don't lookup the tipc_service -> servi

Re: [net-next 0/6][pull request] 100GbE Intel Wired LAN Driver Updates 2018-05-07

2018-05-08 Thread David Miller
From: Jeff Kirsher Date: Mon, 7 May 2018 07:45:15 -0700 > This series contains updates to fm10k only. Waiting for a respin after patch #2 is updated based upon feedback. Thanks.

Re: [PATCH net-next] dt-bindings: dsa: Remove unnecessary #address/#size-cells

2018-05-08 Thread David Miller
From: Fabio Estevam Date: Mon, 7 May 2018 09:17:51 -0300 > From: Fabio Estevam > > If the example binding is used on a real dts file, the following DTC > warning is seen with W=1: > > arch/arm/boot/dts/imx6q-b450v3.dtb: Warning (avoid_unnecessary_addr_size): > /mdio-gpio/switch@0: unnece

Re: [RFC bpf-next 00/10] initial control flow support for eBPF verifier

2018-05-08 Thread David Miller
From: Jiong Wang Date: Mon, 7 May 2018 06:22:36 -0400 > This infrastructure comes with some memory usage and execution time cost. > Memory pool based allocation is used to avoid frequently calling of > kmalloc/free. Singly linked list and compact pointer are used to reduce > various cfg node siz

Re: [PATCH] selinux: add AF_UNSPEC and INADDR_ANY checks to selinux_socket_bind()

2018-05-08 Thread Paul Moore
On Tue, May 8, 2018 at 2:40 PM, Stephen Smalley wrote: > On 05/08/2018 01:05 PM, Paul Moore wrote: >> On Tue, May 8, 2018 at 10:05 AM, Alexey Kodanev >> wrote: >>> Commit d452930fd3b9 ("selinux: Add SCTP support") breaks compatibility >>> with the old programs that can pass sockaddr_in with AF_UN

Re: [PATCH net-next 0/9] net: dsa: Plug in PHYLINK support

2018-05-08 Thread Florian Fainelli
Le 05/08/18 à 17:17, David Miller a écrit : > From: Florian Fainelli > Date: Sat, 5 May 2018 12:04:16 -0700 > >> This patch series adds PHYLINK support to DSA which is necessary to >> support more complex PHY and pluggable modules setups. > > The regression Andrew reported with patch #7 is hold

Re: [PATCH net-next 0/9] net: dsa: Plug in PHYLINK support

2018-05-08 Thread David Miller
From: Florian Fainelli Date: Sat, 5 May 2018 12:04:16 -0700 > This patch series adds PHYLINK support to DSA which is necessary to > support more complex PHY and pluggable modules setups. The regression Andrew reported with patch #7 is holding up my applying this series. How would you like this

Re: [PATCH net-next] net: phy: sfp: handle cases where neither BR,min nor BR,max is given

2018-05-08 Thread David Miller
From: Antoine Tenart Date: Fri, 4 May 2018 17:21:03 +0200 > When computing the bitrate using values read from an SFP module EEPROM, > we use the nominal BR plus BR,min and BR,max to determine the > boundaries. But in some cases BR,min and BR,max aren't provided, which > led the SFP code to end u

Re: pull-request: ieee802154 2018-05-08

2018-05-08 Thread David Miller
From: Stefan Schmidt Date: Tue, 8 May 2018 21:55:37 +0200 > On 05/08/2018 04:18 PM, David Miller wrote: >> Please submit the -stable fix directly, you can feel free to CC: me. > > Will do when the patch hits Linus git tree. > > I have a quick question on the process here. From the netdev-faq do

Re: Failed to clone net-next.git

2018-05-08 Thread David Miller
From: Song Liu Date: Tue, 8 May 2018 17:46:23 + > We are seeing the following error on multiple different systems while > cloning net-next tree. > > $ git clone > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > Cloning into 'net-next'... Regardless of the failure

Re: [bpf-next v2 0/9] bpf: Add helper to do FIB lookups

2018-05-08 Thread Daniel Borkmann
On 05/04/2018 04:54 AM, David Ahern wrote: > Provide a helper for doing a FIB and neighbor lookup in the kernel > tables from an XDP program. The helper provides a fastpath for forwarding > packets. If the packet is a local delivery or for any reason is not a > simple lookup and forward, the packet

Re: [PATCH] hv_netvsc: Fix net device attach on older Windows hosts

2018-05-08 Thread Stephen Hemminger
On Tue, 08 May 2018 20:17:51 +0200 Mohammed Gamal wrote: > On Tue, 2018-05-08 at 11:13 -0700, Stephen Hemminger wrote: > > On Tue,  8 May 2018 19:40:47 +0200 > > Mohammed Gamal wrote: > > > > > On older windows hosts the net_device instance is returned to > > > the caller of rndis_filter_devi

Re: The SO_BINDTODEVICE was set to the desired interface, but packets are received from all interfaces.

2018-05-08 Thread David Ahern
On 5/7/18 6:41 AM, Paolo Abeni wrote: > Hi, > On Mon, 2018-05-07 at 13:19 +0300, Damir Mansurov wrote: >> After successful call of the setsockopt(SO_BINDTODEVICE) function to set >> data reception from only one interface, the data is still received from >> all interfaces. Function setsockopt() re

Re: [PATCH v6 00/13] firmware_loader changes for v4.18

2018-05-08 Thread Kees Cook
one ahead > and also queued up a few minor fixes for the firmware loader documentation > which have come up recently. These changes are available on my git tree > both based on linux-next [0] and Linus' latest tree [1]. Folks working > on new developments for the firmware loader ca

Re: [PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER

2018-05-08 Thread Kees Cook
On Tue, May 8, 2018 at 11:12 AM, Luis R. Rodriguez wrote: > If you try to read FW_LOADER today it speaks of old riddles and > unless you have been following development closely you will loose Typo: lose > track of what is what. Even the documentation for PREVENT_FIRMWARE_BUILD > is a bit fuzzy a

[PATCH] sctp: fix spelling mistake: "max_retans" -> "max_retrans"

2018-05-08 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in error string Signed-off-by: Colin Ian King --- net/sctp/sm_make_chunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c index 4d7b3ccea078..4a4fd1971255 100644 --- a/

[PATCH] [ATM] firestream: fix spelling mistake: "reseverd" -> "reserved"

2018-05-08 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in res_strings string array Signed-off-by: Colin Ian King --- drivers/atm/firestream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index d97c05690faa..4e46dc9e41ad 1

Re: [RFC PATCH 1/3] arcnet: com20020: Add memory map of com20020

2018-05-08 Thread Tobin C. Harding
On Tue, May 08, 2018 at 11:36:51AM +0200, Andrea Greco wrote: > On 05/07/2018 04:55 AM, Tobin C. Harding wrote: > >On Sat, May 05, 2018 at 11:34:45PM +0200, Andrea Greco wrote: > >>From: Andrea Greco > > > >Hi Andrea, > > > >Here are some (mostly stylistic) suggestions to help you get your driver

ICMP redirect and VRF

2018-05-08 Thread Ben Greear
While debugging some other problem today on a system using ip rules instead of VRF, I ran into a case where the remote router was sending back ICMP redirects. That got me thinking...where would these routes get stored in a VRF scenario? Would it magically go to the correct VRF routing table base

Re: [PATCH bpf-next 5/6] bpf: btf: Update tools/include/uapi/linux/btf.h with BTF ID

2018-05-08 Thread Song Liu
> On May 4, 2018, at 2:49 PM, Martin KaFai Lau wrote: > > This patch sync the tools/include/uapi/linux/btf.h with > the newly introduced BTF ID support. > > Signed-off-by: Martin KaFai Lau > Acked-by: Alexei Starovoitov > --- > tools/include/uapi/linux/bpf.h | 11 +++ > 1 file changed

Re: [PATCH bpf-next 6/6] bpf: btf: Tests for BPF_OBJ_GET_INFO_BY_FD and BPF_BTF_GET_FD_BY_ID

2018-05-08 Thread Song Liu
> On May 4, 2018, at 2:49 PM, Martin KaFai Lau wrote: > > This patch adds test for BPF_BTF_GET_FD_BY_ID and the new > btf_id/btf_key_id/btf_value_id in the "struct bpf_map_info". > > It also modifies the existing BPF_OBJ_GET_INFO_BY_FD test > to reflect the new "struct bpf_btf_info". > > Sign

Re: [PATCH bpf-next 4/6] bpf: btf: Some test_btf clean up

2018-05-08 Thread Song Liu
> On May 4, 2018, at 2:49 PM, Martin KaFai Lau wrote: > > This patch adds a CHECK() macro for condition checking > and error report purpose. Something similar to test_progs.c > > It also counts the number of tests passed/skipped/failed and > print them at the end of the test run. > > Signed-

Re: [PATCH bpf-next 1/6] bpf: btf: Avoid WARN_ON when CONFIG_REFCOUNT_FULL=y

2018-05-08 Thread Song Liu
> On May 4, 2018, at 2:49 PM, Martin KaFai Lau wrote: > > If CONFIG_REFCOUNT_FULL=y, refcount_inc() WARN when refcount is 0. > When creating a new btf, the initial btf->refcnt is 0 and > triggered the following: > > [ 34.855452] refcount_t: increment on 0; use-after-free. > [ 34.856252] WA

Re: [PATCH bpf-next 3/6] bpf: btf: Add struct bpf_btf_info

2018-05-08 Thread Song Liu
> On May 4, 2018, at 2:49 PM, Martin KaFai Lau wrote: > > During BPF_OBJ_GET_INFO_BY_FD on a btf_fd, the current bpf_attr's > info.info is directly filled with the BTF binary data. It is > not extensible. In this case, we want to add BTF ID. > > This patch adds "struct bpf_btf_info" which ha

Re: [PATCH bpf-next 2/6] bpf: btf: Introduce BTF ID

2018-05-08 Thread Song Liu
> On May 4, 2018, at 2:49 PM, Martin KaFai Lau wrote: > > This patch gives an ID to each loaded BTF. The ID is allocated by > the idr like the existing prog-id and map-id. > > The bpf_put(map->btf) is moved to __bpf_map_put() so that the > userspace can stop seeing the BTF ID ASAP when the la

Re: [PATCH net-next] dt-bindings: dsa: Remove unnecessary #address/#size-cells

2018-05-08 Thread Florian Fainelli
On 05/07/2018 05:17 AM, Fabio Estevam wrote: > From: Fabio Estevam > > If the example binding is used on a real dts file, the following DTC > warning is seen with W=1: > > arch/arm/boot/dts/imx6q-b450v3.dtb: Warning (avoid_unnecessary_addr_size): > /mdio-gpio/switch@0: unnecessary #address-

Re: pull-request: ieee802154 2018-05-08

2018-05-08 Thread Stefan Schmidt
Hello. On 05/08/2018 04:18 PM, David Miller wrote: > From: Stefan Schmidt > Date: Tue, 8 May 2018 10:29:27 +0200 > >> An update from ieee802154 for your *net* tree. >> >> Two fixes for the mcr20a driver, which was being added in the 4.17 merge >> window, >> by Gustavo and myself. >> The atusb

Re: KASAN: use-after-free Read in sctp_do_sm

2018-05-08 Thread Marcelo Ricardo Leitner
On Wed, May 09, 2018 at 01:41:03AM +0800, Xin Long wrote: ... > > sctp_chunk_destroy net/sctp/sm_make_chunk.c:1481 [inline] > > sctp_chunk_put+0x321/0x440 net/sctp/sm_make_chunk.c:1504 > > sctp_ulpevent_make_rcvmsg+0x955/0xd40 net/sctp/ulpevent.c:718 > There's no reason to put the chunk in sctp_

Re: [PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module

2018-05-08 Thread Andres Rodriguez
On 2018-05-08 02:12 PM, Luis R. Rodriguez wrote: Clarify the provenance of the firmware loader firmware_class module name and why we cannot rename the module in the future. Signed-off-by: Luis R. Rodriguez --- .../driver-api/firmware/fallback-mechanisms.rst | 9 ++--- 1 file c

Re: [PATCH] selinux: add AF_UNSPEC and INADDR_ANY checks to selinux_socket_bind()

2018-05-08 Thread Stephen Smalley
On 05/08/2018 01:05 PM, Paul Moore wrote: > On Tue, May 8, 2018 at 10:05 AM, Alexey Kodanev > wrote: >> Commit d452930fd3b9 ("selinux: Add SCTP support") breaks compatibility >> with the old programs that can pass sockaddr_in with AF_UNSPEC and >> INADDR_ANY to bind(). As a result, bind() returns

Re: Failed to clone net-next.git

2018-05-08 Thread Song Liu
> On May 8, 2018, at 11:06 AM, Konstantin Ryabitsev > wrote: > > On 05/08/18 13:46, Song Liu wrote: >> We are seeing the following error on multiple different systems while >> cloning net-next tree. >> >> $ git clone >> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git >>

[PATCH net 2/2] qede: Fix gfp flags sent to rdma event node allocation

2018-05-08 Thread Michal Kalderon
A previous commit 4609adc27175 ("qede: Fix qedr link update") added a flow that could allocate rdma event objects from an interrupt path (link notification). Therefore the kzalloc call should be done with GFP_ATOMIC. fixes: 4609adc27175 ("qede: Fix qedr link update") Signed-off-by: Michal Kalderon

[PATCH net 1/2] qed: Fix l2 initializations over iWARP personality

2018-05-08 Thread Michal Kalderon
If qede driver was loaded on a device configured for iWARP the l2 mutex wouldn't be allocated, and some l2 related resources wouldn't be freed. fixes: c851a9dc4359 ("qed: Introduce iWARP personality") Signed-off-by: Michal Kalderon Signed-off-by: Sudarsana Kalluru --- drivers/net/ethernet/qlogi

[PATCH net 0/2] qed*: Rdma fixes

2018-05-08 Thread Michal Kalderon
This patch series include two fixes for bugs related to rdma. The first has to do with loading the driver over an iWARP device. The second fixes a previous commit that added proper link indication for iWARP / RoCE. Signed-off-by: Michal Kalderon Signed-off-by: Sudarsana Kalluru Michal Kalderon

[PATCH v6 00/13] firmware_loader changes for v4.18

2018-05-08 Thread Luis R. Rodriguez
ation which have come up recently. These changes are available on my git tree both based on linux-next [0] and Linus' latest tree [1]. Folks working on new developments for the firmware loader can use my linux-next branch 20180508-firmware_loader_for-v4.18-try2 for now. 0-day sends its bless

[PATCH v6 01/13] firmware: wrap FW_OPT_* into an enum

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez This should let us associate enum kdoc to these values. While at it, kdocify the fw_opt. Signed-off-by: Andres Rodriguez Acked-by: Luis R. Rodriguez [mcgrof: coding style fixes, merge kdoc with enum move] Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loade

[PATCH v6 02/13] firmware: use () to terminate kernel-doc function names

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez Acked-by: Randy Dunlap Acked-by: Luis R. Rodriguez [mcgrof: adjust since the wide API rename is not yet merged] Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader/f

[PATCH v6 04/13] firmware_loader: document firmware_sysfs_fallback()

2018-05-08 Thread Luis R. Rodriguez
This also sets the expecations for future fallback interfaces, even if they are not exported. Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader/fallback.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/

[PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER

2018-05-08 Thread Luis R. Rodriguez
If you try to read FW_LOADER today it speaks of old riddles and unless you have been following development closely you will loose track of what is what. Even the documentation for PREVENT_FIRMWARE_BUILD is a bit fuzzy and how it fits into this big picture. Give the FW_LOADER kconfig documentation

[PATCH v6 03/13] firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez This is done since this call is now exposed through kernel-doc, and since this also paves the way for different future types of fallback mechanims. Signed-off-by: Andres Rodriguez Acked-by: Luis R. Rodriguez [mcgrof: small coding style changes] Signed-off-by: Luis R. Rod

Re: [PATCH] hv_netvsc: Fix net device attach on older Windows hosts

2018-05-08 Thread Mohammed Gamal
On Tue, 2018-05-08 at 11:13 -0700, Stephen Hemminger wrote: > On Tue,  8 May 2018 19:40:47 +0200 > Mohammed Gamal wrote: > > > On older windows hosts the net_device instance is returned to > > the caller of rndis_filter_device_add() without having the presence > > bit set first. This would cause

[PATCH v6 06/13] firmware_loader: move kconfig FW_LOADER entries to its own file

2018-05-08 Thread Luis R. Rodriguez
This will make it easier to track and easier to understand what components and features are part of the FW_LOADER. There are some components related to firmware which have *nothing* to do with the FW_LOADER, souch as PREVENT_FIRMWARE_BUILD. Signed-off-by: Luis R. Rodriguez --- drivers/base/Kconf

[PATCH v6 09/13] ath10k: use firmware_request_nowarn() to load firmware

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez Acked-by: Kalle Valo Signed-off-by: Luis R. Rodriguez --- drivers/net/wireless/ath/ath10k/core.c | 2 +- 1 file

[PATCH v6 10/13] ath10k: re-enable the firmware fallback mechanism for testmode

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez The ath10k testmode uses request_firmware_direct() in order to avoid producing firmware load warnings. Disabling the fallback mechanism was a side effect of disabling warnings. We now have a new API that allows us to avoid warnings while keeping the fallback mechanism enab

[PATCH v6 07/13] firmware_loader: make firmware_fallback_sysfs() print more useful

2018-05-08 Thread Luis R. Rodriguez
If we resort to using the sysfs fallback mechanism we don't print the filename. This can be deceiving given we could have a series of callers intertwined and it'd be unclear exactly for what firmware this was meant for. Additionally, although we don't currently use FW_OPT_NO_WARN when dealing with

[PATCH v6 11/13] Documentation: fix few typos and clarifications for the firmware loader

2018-05-08 Thread Luis R. Rodriguez
Fix a few typos, and clarify a few sentences. Signed-off-by: Luis R. Rodriguez --- Documentation/driver-api/firmware/fallback-mechanisms.rst | 5 +++-- Documentation/driver-api/firmware/firmware_cache.rst | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Documentation

[PATCH v6 08/13] firmware: add firmware_request_nowarn() - load firmware without warnings

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez Currently the firmware loader only exposes one silent path for querying optional firmware, and that is firmware_request_direct(). This function also disables the sysfs fallback mechanism, which might not always be the desired behaviour [0]. This patch introduces a variatio

Re: [PATCH] hv_netvsc: Fix net device attach on older Windows hosts

2018-05-08 Thread Stephen Hemminger
On Tue, 8 May 2018 19:40:47 +0200 Mohammed Gamal wrote: > On older windows hosts the net_device instance is returned to > the caller of rndis_filter_device_add() without having the presence > bit set first. This would cause any subsequent calls to network device > operations (e.g. MTU change, ch

[PATCH v6 12/13] Documentation: remove stale firmware API reference

2018-05-08 Thread Luis R. Rodriguez
It refers to a pending patch, but this was merged eons ago. Signed-off-by: Luis R. Rodriguez --- Documentation/dell_rbu.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/dell_rbu.txt b/Documentation/dell_rbu.txt index 0fdb6aa2704c..077fdc29a0d0 100644 --- a/Documentation/de

[PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module

2018-05-08 Thread Luis R. Rodriguez
Clarify the provenance of the firmware loader firmware_class module name and why we cannot rename the module in the future. Signed-off-by: Luis R. Rodriguez --- .../driver-api/firmware/fallback-mechanisms.rst | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/D

Re: Failed to clone net-next.git

2018-05-08 Thread Konstantin Ryabitsev
On 05/08/18 13:46, Song Liu wrote: > We are seeing the following error on multiple different systems while > cloning net-next tree. > > $ git clone > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > Cloning into 'net-next'... > remote: Counting objects: 6017287, done.

Re: [net-next PATCH 0/3] Symmetric queue selection using XPS for Rx queues

2018-05-08 Thread Nambiar, Amritha
On 5/8/2018 10:19 AM, Alexander Duyck wrote: > On Tue, May 8, 2018 at 10:07 AM, Eric Dumazet wrote: >> >> >> On 05/08/2018 09:02 AM, Alexander Duyck wrote: >>> On Tue, May 8, 2018 at 8:15 AM, Tom Herbert wrote: On Thu, Apr 19, 2018 at 7:41 PM, Eric Dumazet wrote: > On Thu, Apr 19, 2018

Failed to clone net-next.git

2018-05-08 Thread Song Liu
We are seeing the following error on multiple different systems while cloning net-next tree. $ git clone https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git Cloning into 'net-next'... remote: Counting objects: 6017287, done. remote: Compressing objects: 100% (2458/2458), d

Re: general protection fault in encode_rpcb_string

2018-05-08 Thread Bruce Fields
On Tue, May 08, 2018 at 12:34:48PM -0400, Chuck Lever wrote: > > > > On May 8, 2018, at 12:15 PM, bfie...@fieldses.org wrote: > > > > On Tue, Apr 17, 2018 at 09:54:36PM +, Trond Myklebust wrote: > >> Yes, and we can probably convert it, and the other GFP_ATOMIC > >> allocations in the rpcbin

[PATCH] hv_netvsc: Fix net device attach on older Windows hosts

2018-05-08 Thread Mohammed Gamal
On older windows hosts the net_device instance is returned to the caller of rndis_filter_device_add() without having the presence bit set first. This would cause any subsequent calls to network device operations (e.g. MTU change, channel change) to fail after the device is detached once, returning

Re: KASAN: use-after-free Read in sctp_do_sm

2018-05-08 Thread Xin Long
On Tue, May 8, 2018 at 9:58 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:f142f08bf7ec Fix typo in comment. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1159ade780 > kernel config: https://syzkaller.appspot.co

RE: [net-next 2/6] fm10k: reduce duplicate fm10k_stat macro code

2018-05-08 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Joe Perches > Sent: Tuesday, May 08, 2018 10:00 AM > To: Kirsher, Jeffrey T ; da...@davemloft.net > Cc: Keller, Jacob E ; netdev@vger.kernel.org; > nhor...@redhat.com; sassm...@red

Re: [PATCH] net: phy: DP83811: Add support for the phy

2018-05-08 Thread Dan Murphy
Florian On 05/08/2018 12:14 PM, Florian Fainelli wrote: > On 05/08/2018 10:13 AM, Dan Murphy wrote: >> Andrew >> >> On 05/08/2018 11:49 AM, Andrew Lunn wrote: >>> On Tue, May 08, 2018 at 10:56:55AM -0500, Dan Murphy wrote: All On 05/08/2018 09:11 AM, Dan Murphy wrote: > Add supp

Re: [net-next PATCH 0/3] Symmetric queue selection using XPS for Rx queues

2018-05-08 Thread Alexander Duyck
On Tue, May 8, 2018 at 10:07 AM, Eric Dumazet wrote: > > > On 05/08/2018 09:02 AM, Alexander Duyck wrote: >> On Tue, May 8, 2018 at 8:15 AM, Tom Herbert wrote: >>> On Thu, Apr 19, 2018 at 7:41 PM, Eric Dumazet wrote: On Thu, Apr 19, 2018 at 6:07 PM Amritha Nambiar wrote: > Th

Re: [PATCH] net: phy: DP83811: Add support for the phy

2018-05-08 Thread Florian Fainelli
On 05/08/2018 10:13 AM, Dan Murphy wrote: > Andrew > > On 05/08/2018 11:49 AM, Andrew Lunn wrote: >> On Tue, May 08, 2018 at 10:56:55AM -0500, Dan Murphy wrote: >>> All >>> >>> On 05/08/2018 09:11 AM, Dan Murphy wrote: Add support for the DP83811 phy by extending the DP83822 driver to re

Re: [PATCH] net: phy: DP83811: Add support for the phy

2018-05-08 Thread Dan Murphy
Andrew On 05/08/2018 11:49 AM, Andrew Lunn wrote: > On Tue, May 08, 2018 at 10:56:55AM -0500, Dan Murphy wrote: >> All >> >> On 05/08/2018 09:11 AM, Dan Murphy wrote: >>> Add support for the DP83811 phy by extending >>> the DP83822 driver to recognize the PHY IDs. >>> >>> The DP83811 supports both

Re: Performance regression between 4.13 and 4.14

2018-05-08 Thread Eric Dumazet
On 05/08/2018 09:44 AM, Ben Greear wrote: > Hello, > > I am trying to track down a performance regression that appears to be between > 4.13 > and 4.14. > > I first saw the problem with a hacked version of pktgen on some ixgbe NICs.  > 4.13 can do > right at 10G bi-directional on two ports, an

Re: [net-next PATCH 0/3] Symmetric queue selection using XPS for Rx queues

2018-05-08 Thread Eric Dumazet
On 05/08/2018 09:02 AM, Alexander Duyck wrote: > On Tue, May 8, 2018 at 8:15 AM, Tom Herbert wrote: >> On Thu, Apr 19, 2018 at 7:41 PM, Eric Dumazet wrote: >>> On Thu, Apr 19, 2018 at 6:07 PM Amritha Nambiar >>> wrote: >>> This patch series implements support for Tx queue selection based

Re: [PATCH] selinux: add AF_UNSPEC and INADDR_ANY checks to selinux_socket_bind()

2018-05-08 Thread Paul Moore
On Tue, May 8, 2018 at 10:05 AM, Alexey Kodanev wrote: > Commit d452930fd3b9 ("selinux: Add SCTP support") breaks compatibility > with the old programs that can pass sockaddr_in with AF_UNSPEC and > INADDR_ANY to bind(). As a result, bind() returns EAFNOSUPPORT error. > It was found with LTP/asapi

  1   2   3   >