Re: [PATCH bpf-next v6 05/11] bpf: Adds field bpf_sock_ops_cb_flags to tcp_sock

2018-01-19 Thread Lawrence Brakmo
On 1/19/18, 7:52 PM, "Alexei Starovoitov" wrote: On Fri, Jan 19, 2018 at 05:45:42PM -0800, Lawrence Brakmo wrote: > Adds field bpf_sock_ops_cb_flags to tcp_sock and bpf_sock_ops. Its primary > use is to determine if there should be calls to sock_ops bpf program at > various points

[net-next:master 308/357] ERROR: "devm_ioremap_resource" [drivers/net/ethernet/cortina/gemini.ko] undefined!

2018-01-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 8565d26bcb2ff6df646e946d2913fcf706d46b66 commit: 4d5ae32f5e1e13f7f36d6439ec3257993b9f5b88 [308/357] net: ethernet: Add a driver for Gemini gigabit ethernet config: um-allmodconfig (attached as .config) compi

pull-request: bpf-next 2018-01-19

2018-01-19 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) bpf array map HW offload, from Jakub. 2) support for bpf_get_next_key() for LPM map, from Yonghong. 3) test_verifier now runs loaded programs, from Alexei. 4) xdp cpumap monitoring, fr

net merged into net-next

2018-01-19 Thread David Miller
Cong, please check my conflict resolution of drivers/net/tun.c, thank you.

Re: [PATCH bpf-next v6 11/11] bpf: add selftest for tcpbpf

2018-01-19 Thread Alexei Starovoitov
On Fri, Jan 19, 2018 at 05:45:48PM -0800, Lawrence Brakmo wrote: > Added a selftest for tcpbpf (sock_ops) that checks that the appropriate > callbacks occured and that it can access tcp_sock fields and that their > values are correct. > > Run with command: ./test_tcpbpf_user > > Signed-off-by: La

Re: [PATCH bpf-next v6 03/11] bpf: Add write access to tcp_sock and sock fields

2018-01-19 Thread Alexei Starovoitov
On Fri, Jan 19, 2018 at 05:45:40PM -0800, Lawrence Brakmo wrote: > This patch adds a macro, SOCK_OPS_SET_FIELD, for writing to > struct tcp_sock or struct sock fields. This required adding a new > field "temp" to struct bpf_sock_ops_kern for temporary storage that > is used by sock_ops_convert_ctx_

Re: [PATCH bpf-next v6 05/11] bpf: Adds field bpf_sock_ops_cb_flags to tcp_sock

2018-01-19 Thread Alexei Starovoitov
On Fri, Jan 19, 2018 at 05:45:42PM -0800, Lawrence Brakmo wrote: > Adds field bpf_sock_ops_cb_flags to tcp_sock and bpf_sock_ops. Its primary > use is to determine if there should be calls to sock_ops bpf program at > various points in the TCP code. The field is initialized to zero, > disabling the

Re: [PATCH bpf-next 0/9] BPF misc improvements

2018-01-19 Thread Alexei Starovoitov
On Sat, Jan 20, 2018 at 01:24:28AM +0100, Daniel Borkmann wrote: > This series adds various misc improvements to BPF: detection > of BPF helper definition misconfiguration for mem/size argument > pairs, csum_diff helper also for XDP, various test cases, > removal of the recently added pure_initcall

Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support

2018-01-19 Thread Alexei Starovoitov
On Sat, Jan 20, 2018 at 03:00:37AM +0100, Daniel Borkmann wrote: > On 01/19/2018 12:43 AM, Eric Leblond wrote: > > Hello, > > > > This patchset rebases the libbpf code on latest bpf-next code and addresses > > remarks by Daniel. > > Ok, I think it's a good start. We should later on clean up the >

Re: [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

2018-01-19 Thread Richard Cochran
On Fri, Jan 19, 2018 at 04:15:46PM -0500, Willem de Bruijn wrote: > > + if (cmsg->cmsg_len != CMSG_LEN(sizeof(ktime_t))) > > + return -EINVAL; > > I don't see any existing reference to ktime_t in include/uapi. Just use a s64? Agreed. I didn't see the point of

Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support

2018-01-19 Thread Daniel Borkmann
On 01/19/2018 12:43 AM, Eric Leblond wrote: > Hello, > > This patchset rebases the libbpf code on latest bpf-next code and addresses > remarks by Daniel. Ok, I think it's a good start. We should later on clean up the netlink handling code a bit, but that's all internal and can be done in a second

[PATCH net-next] nfp: flower: prioritize stats updates

2018-01-19 Thread Jakub Kicinski
From: Pieter Jansen van Vuuren Previously it was possible to interrupt processing stats updates because they were handled in a work queue. Interrupting the stats updates could lead to a situation where we backup the control message queue. This patch moves the stats update processing out of the wo

[PATCH bpf-next v6 08/11] bpf: Add sock_ops R/W access to tclass & sk_txhash

2018-01-19 Thread Lawrence Brakmo
Adds direct R/W access to sk_txhash and access to tclass for ipv6 flows through getsockopt and setsockopt. Sample usage for tclass: bpf_getsockopt(skops, SOL_IPV6, IPV6_TCLASS, &v, sizeof(v)) where skops is a pointer to the ctx (struct bpf_sock_ops). Signed-off-by: Lawrence Brakmo --- includ

[PATCH bpf-next v6 09/11] bpf: Add BPF_SOCK_OPS_RETRANS_CB

2018-01-19 Thread Lawrence Brakmo
Adds support for calling sock_ops BPF program when there is a retransmission. Two arguments are used; one for the sequence number and other for the number of segments retransmitted. Does not include syn-ack retransmissions. New op: BPF_SOCK_OPS_RETRANS_CB. Signed-off-by: Lawrence Brakmo --- inc

[PATCH bpf-next v6 10/11] bpf: Add BPF_SOCK_OPS_STATE_CB

2018-01-19 Thread Lawrence Brakmo
Adds support for calling sock_ops BPF program when there is a TCP state change. Two arguments are used; one for the old state and another for the new state. There is a new enum in include/uapi/linux/bpf.h that exports the TCP states that prepends BPF_ to the current TCP state names. If it is ever

[PATCH bpf-next v6 07/11] bpf: Add support for reading sk_state and more

2018-01-19 Thread Lawrence Brakmo
Add support for reading many more tcp_sock fields state,same as sk->sk_state rtt_min same as sk->rtt_min.s[0].v (current rtt_min) snd_ssthresh rcv_nxt snd_nxt snd_una mss_cache ecn_flags rate_delivered rate_interval_us packets_out retrans_out total_retrans

[PATCH bpf-next v6 11/11] bpf: add selftest for tcpbpf

2018-01-19 Thread Lawrence Brakmo
Added a selftest for tcpbpf (sock_ops) that checks that the appropriate callbacks occured and that it can access tcp_sock fields and that their values are correct. Run with command: ./test_tcpbpf_user Signed-off-by: Lawrence Brakmo --- tools/include/uapi/linux/bpf.h | 74 ++

[PATCH bpf-next v6 06/11] bpf: Add sock_ops RTO callback

2018-01-19 Thread Lawrence Brakmo
Adds an optional call to sock_ops BPF program based on whether the BPF_SOCK_OPS_RTO_CB_FLAG is set in bpf_sock_ops_flags. The BPF program is passed 2 arguments: icsk_retransmits and whether the RTO has expired. Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 5 + include/uapi/l

[PATCH bpf-next v6 02/11] bpf: Make SOCK_OPS_GET_TCP struct independent

2018-01-19 Thread Lawrence Brakmo
Changed SOCK_OPS_GET_TCP to SOCK_OPS_GET_FIELD and added 2 arguments so now it can also work with struct sock fields. The first argument is the name of the field in the bpf_sock_ops struct, the 2nd argument is the name of the field in the OBJ struct. Previous: SOCK_OPS_GET_TCP(FIELD_NAME) New:

[PATCH net-next v4 7/8] nfp: bpf: plumb extack into functions related to XDP offload

2018-01-19 Thread Jakub Kicinski
From: Quentin Monnet Pass a pointer to an extack object to nfp_app_xdp_offload() in order to prepare for extack usage in the nfp driver. Next step will be to forward this extack pointer to nfp_net_bpf_offload(), once this function is able to use it for printing error messages. Signed-off-by: Que

[PATCH bpf-next v6 05/11] bpf: Adds field bpf_sock_ops_cb_flags to tcp_sock

2018-01-19 Thread Lawrence Brakmo
Adds field bpf_sock_ops_cb_flags to tcp_sock and bpf_sock_ops. Its primary use is to determine if there should be calls to sock_ops bpf program at various points in the TCP code. The field is initialized to zero, disabling the calls. A sock_ops BPF program can set it, per connection and as necessar

[PATCH bpf-next v6 03/11] bpf: Add write access to tcp_sock and sock fields

2018-01-19 Thread Lawrence Brakmo
This patch adds a macro, SOCK_OPS_SET_FIELD, for writing to struct tcp_sock or struct sock fields. This required adding a new field "temp" to struct bpf_sock_ops_kern for temporary storage that is used by sock_ops_convert_ctx_access. It is used to store and recover the contents of a register, so th

[PATCH net-next v4 6/8] net: sched: create tc_can_offload_extack() wrapper

2018-01-19 Thread Jakub Kicinski
From: Quentin Monnet Create a wrapper around tc_can_offload() that takes an additional extack pointer argument in order to output an error message if TC offload is disabled on the device. In this way, the error message is handled by the core and can be the same for all drivers. Signed-off-by: Q

[PATCH net-next v4 5/8] net: sched: add extack support for offload via tc_cls_common_offload

2018-01-19 Thread Jakub Kicinski
From: Quentin Monnet Add extack support for hardware offload of classifiers. In order to achieve this, a pointer to a struct netlink_ext_ack is added to the struct tc_cls_common_offload that is passed to the callback for setting up the classifier. Function tc_cls_common_offload_init() is updated

[PATCH net-next v4 2/8] net: sched: cls_matchall: propagate extack support for filter offload

2018-01-19 Thread Jakub Kicinski
From: Quentin Monnet Propagate the extack pointer from the `->change()` classifier operation to the function used for filter replacement in cls_matchall. This makes it possible to use netlink extack messages in the future at replacement time for this filter, although it is not used at this point.

[PATCH bpf-next v6 04/11] bpf: Support passing args to sock_ops bpf function

2018-01-19 Thread Lawrence Brakmo
Adds support for passing up to 4 arguments to sock_ops bpf functions. It reusues the reply union, so the bpf_sock_ops structures are not increased in size. Signed-off-by: Lawrence Brakmo --- include/linux/filter.h | 1 + include/net/tcp.h| 64 ++

[PATCH net-next v4 8/8] nfp: bpf: use extack support to improve debugging

2018-01-19 Thread Jakub Kicinski
From: Quentin Monnet Use the recently added extack support for eBPF offload in the driver. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/bpf/main.c| 31 ++-- drivers/net/ethernet/netronome/nfp/bpf/main.h| 2 +- dr

[PATCH net-next v4 0/8] net: sched: add extack support for cls offloads

2018-01-19 Thread Jakub Kicinski
Hi! I've dropped the tests from the series because test_offloads.py changes will conflict with bpf-next patches. I will send four more patches with tests once bpf-next is merged back, hopefully still making it into 4.16 :) v4: - rebase on top of Alex's changes. --- Quentin says: This series

[PATCH bpf-next v6 01/11] bpf: Make SOCK_OPS_GET_TCP size independent

2018-01-19 Thread Lawrence Brakmo
Make SOCK_OPS_GET_TCP helper macro size independent (before only worked with 4-byte fields. Signed-off-by: Lawrence Brakmo --- net/core/filter.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index 30fafaa..5d6f121 100644 -

[PATCH net-next v4 1/8] net: sched: cls_flower: propagate extack support for filter offload

2018-01-19 Thread Jakub Kicinski
From: Quentin Monnet Propagate the extack pointer from the `->change()` classifier operation to the function used for filter replacement in cls_flower. This makes it possible to use netlink extack messages in the future at replacement time for this filter, although it is not used at this point.

[PATCH bpf-next v6 00/11] bpf: More sock_ops callbacks

2018-01-19 Thread Lawrence Brakmo
This patchset adds support for: - direct R or R/W access to many tcp_sock fields - passing up to 4 arguments to sock_ops BPF functions - tcp_sock field bpf_sock_ops_cb_flags for controlling callbacks - optionally calling sock_ops BPF program when RTO fires - optionally calling sock_ops BPF program

[PATCH net-next v4 3/8] net: sched: cls_u32: propagate extack support for filter offload

2018-01-19 Thread Jakub Kicinski
From: Quentin Monnet Propagate the extack pointer from the `->change()` classifier operation to the function used for filter replacement in cls_u32. This makes it possible to use netlink extack messages in the future at replacement time for this filter, although it is not used at this point. Sig

[PATCH net-next v4 4/8] net: sched: cls_bpf: plumb extack support in filter for hardware offload

2018-01-19 Thread Jakub Kicinski
From: Quentin Monnet Pass the extack pointer obtained in the `->change()` filter operation to cls_bpf_offload() and then to cls_bpf_offload_cmd(). This makes it possible to use this extack pointer in drivers offloading BPF programs in a future patch. Signed-off-by: Quentin Monnet Reviewed-by: J

Re: [bpf-next PATCH] samples/bpf: xdp_monitor include cpumap tracepoints in monitoring

2018-01-19 Thread Daniel Borkmann
On 01/19/2018 05:15 PM, Jesper Dangaard Brouer wrote: > The xdp_redirect_cpu sample have some "builtin" monitoring of the > tracepoints for xdp_cpumap_*, but it is practical to have an external > tool that can monitor these transpoint as an easy way to troubleshoot > an application using XDP + cpum

Re: [PATCH bpf-next 0/2] bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE map

2018-01-19 Thread Daniel Borkmann
On 01/19/2018 12:08 AM, Yonghong Song wrote: > This patch set implements MAP_GET_NEXT_KEY command for LPM_TRIE map. > This command is really useful for key enumeration, and for key deletion > if what keys in the trie are unknown. > > Patch #1 implements the functionality in the kernel and patch #2

[PATCH bpf-next 8/9] bpf: add upper complexity limit to verifier log

2018-01-19 Thread Daniel Borkmann
Given the limit could potentially get further adjustments in the future, add it to the log so it becomes obvious what the current limit is w/o having to check the source first. This may also be helpful for debugging complexity related issues on kernels that backport from upstream. Signed-off-by: D

[PATCH bpf-next 5/9] bpf: get rid of pure_initcall dependency to enable jits

2018-01-19 Thread Daniel Borkmann
Having a pure_initcall() callback just to permanently enable BPF JITs under CONFIG_BPF_JIT_ALWAYS_ON is unnecessary and could leave a small race window in future where JIT is still disabled on boot. Since we know about the setting at compilation time anyway, just initialize it properly there. Also

[PATCH bpf-next 4/9] bpf: add couple of test cases for div/mod by zero

2018-01-19 Thread Daniel Borkmann
Add couple of missing test cases for eBPF div/mod by zero to the new test_verifier prog runtime feature. Also one for an empty prog and only exit. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- tools/testing/selftests/bpf/test_verifier.c | 87 + 1 fi

[PATCH bpf-next 6/9] bpf: restrict access to core bpf sysctls

2018-01-19 Thread Daniel Borkmann
Given BPF reaches far beyond just networking these days, it was never intended to allow setting and in some cases reading those knobs out of a user namespace root running without CAP_SYS_ADMIN, thus tighten such access. Also the bpf_jit_enable = 2 debugging mode should only be allowed if kptr_rest

[PATCH bpf-next 3/9] bpf: add couple of test cases for signed extended imms

2018-01-19 Thread Daniel Borkmann
Add a couple of test cases for interpreter and JIT that are related to an issue we faced some time ago in Cilium [1], which is fixed in LLVM with commit e53750e1e086 ("bpf: fix bug on silently truncating 64-bit immediate"). Test cases were run-time checking kernel to behave as intended which shoul

[PATCH bpf-next 7/9] bpf, x86: small optimization in alu ops with imm

2018-01-19 Thread Daniel Borkmann
For the BPF_REG_0 (BPF_REG_A in cBPF, respectively), we can use the short form of the opcode as dst mapping is on eax/rax and thus save a byte per such operation. Added to add/sub/and/or/xor for 32/64 bit when K immediate is used. There may be more such low-hanging fruit to add in future as well.

[PATCH bpf-next 1/9] bpf, verifier: detect misconfigured mem,size argument pair

2018-01-19 Thread Daniel Borkmann
I've seen two patch proposals now for helper additions that used ARG_PTR_TO_MEM or similar in reg_X but no corresponding ARG_CONST_SIZE in reg_X+1. Verifier won't complain in such case, but it will omit verifying the memory passed to the helper thus ending up badly. Detect such buggy helper functio

[PATCH bpf-next 2/9] bpf: add csum_diff helper to xdp as well

2018-01-19 Thread Daniel Borkmann
Useful for porting cls_bpf programs w/o increasing program complexity limits much at the same time, so add the helper to XDP as well. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- net/core/filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/filter.c b/net/c

[PATCH bpf-next 9/9] bpf: move event_output to const_size_or_zero for xdp/skb as well

2018-01-19 Thread Daniel Borkmann
Similar rationale as in a60dd35d2e39 ("bpf: change bpf_perf_event_output arg5 type to ARG_CONST_SIZE_OR_ZERO"), change the type to CONST_SIZE_OR_ZERO such that we can better deal with optimized code. No changes needed in bpf_event_output() as it can also deal with 0 size entirely (e.g. as only wake

[PATCH bpf-next 0/9] BPF misc improvements

2018-01-19 Thread Daniel Borkmann
This series adds various misc improvements to BPF: detection of BPF helper definition misconfiguration for mem/size argument pairs, csum_diff helper also for XDP, various test cases, removal of the recently added pure_initcall(), restriction of the jit sysctls to cap_sys_admin for initns, a minor s

Re: net: r8169: a question of memory barrier in the r8169 driver

2018-01-19 Thread Francois Romieu
Jia-Ju Bai : > > On 2018/1/19 9:11, Francois Romieu wrote: > > Jia-Ju Bai : > > [...] > > > The function rtl8169_start_xmit reads tp->dirty_tx in TX_FRAGS_READY_FOR: > > > if (unlikely(!TX_FRAGS_READY_FOR(tp, skb_shinfo(skb)->nr_frags))) { > > > netif_err(tp, drv, dev, "BUG! Tx Rin

Re: net: r8169: a question of memory barrier in the r8169 driver

2018-01-19 Thread Francois Romieu
Peter Zijlstra : > On Fri, Jan 19, 2018 at 02:11:18AM +0100, Francois Romieu wrote: > > Peter Zijlstra : > > [...] > > > There is only 1 variable afaict. Memory barriers need at least 2 in > > > order to be able to do _anything_. > > > > I don't get your point: why don't {cur_tx, dirty_tx} quali

Re: [PATCH iproute2] devlink: Ignore unknown attributes

2018-01-19 Thread David Ahern
On 1/19/18 3:40 PM, Stephen Hemminger wrote: >> mnl_attr_type_valid calls mnl_attr_get_type which does attr->nla_type & >> NLA_TYPE_MASK. Since you are no longer acknowledging the return code of >> mnl_attr_type_valid, you don't care about its checks so you might as >> well not call it. I don't see

Re: [PATCH iproute2] devlink: Ignore unknown attributes

2018-01-19 Thread Stephen Hemminger
On Fri, 19 Jan 2018 14:27:06 -0800 David Ahern wrote: > On 1/19/18 2:02 PM, Stephen Hemminger wrote: > > On Thu, 18 Jan 2018 20:42:44 -0800 > > David Ahern wrote: > > > >> On 1/17/18 5:28 AM, Arkadi Sharshevsky wrote: > >>> In case of extending the UAPI old packages would break. > >>> > >>>

[Patch net-next 2/3] net_sched: plug in qdisc ops change_tx_queue_len

2018-01-19 Thread Cong Wang
Introduce a new qdisc ops ->change_tx_queue_len() so that each qdisc could decide how to implement this if it wants. Previously we simply read dev->tx_queue_len, after pfifo_fast switches to skb array, we need this API to resize the skb array when we change dev->tx_queue_len. To avoid handling rac

[Patch net-next 1/3] net: introduce helper dev_change_tx_queue_len()

2018-01-19 Thread Cong Wang
This patch promotes the local change_tx_queue_len() to a core helper function, dev_change_tx_queue_len(), so that rtnetlink and net-sysfs could share the code. This also prepares for the following patch. Note, the -EFAULT in the original code doesn't make sense, we should propagate the errno from

[Patch net-next 3/3] net_sched: implement ->change_tx_queue_len() for pfifo_fast

2018-01-19 Thread Cong Wang
pfifo_fast used to drop based on qdisc_dev(qdisc)->tx_queue_len, so we have to resize skb array when we change tx_queue_len. Other qdiscs which read tx_queue_len are fine because they all save it to sch->limit or somewhere else in qdisc during init. They don't have to implement this, it is nicer i

[Patch net-next 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

2018-01-19 Thread Cong Wang
This pathcset restores the pfifo_fast qdisc behavior of dropping packets based on latest dev->tx_queue_len. Patch 1 introduces a helper, patch 2 introduces a new Qdisc ops which is called when we modify tx_queue_len, patch 3 implements this ops for pfifo_fast. Please see each patch for details. -

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-19 Thread Benjamin Poirier
On 2018/01/20 07:45, Benjamin Poirier wrote: [...] > > > > I'm of the mind that we need to cut down on the code thrash. This > > driver is supposed to have been in a "maintenance" mode for the last > > year or so as there aren't being any new parts added is my > > understanding. As-is I don't see

Re: flow cache removed = xfrm doesnt work

2018-01-19 Thread Tomas Charvat
> Ok I have tried 4.14.14 and got following after 1 hour or so. It was > not fatal, system kept going. [ 2833.840452] BUG: unable to handle kernel NULL pointer dereference at 0018 [ 2833.840549] IP: xfrm_output_resume+0x20a/0x460 [ 2833.840618] PGD 0 P4D 0 [ 2833.840682] Oops:

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-19 Thread Benjamin Poirier
On 2018/01/19 08:22, Alexander Duyck wrote: > On Fri, Jan 19, 2018 at 5:36 AM, Benjamin Poirier > wrote: > > On 2018/01/19 17:59, Benjamin Poirier wrote: > >> On 2018/01/18 07:51, Alexander Duyck wrote: > >> > On Wed, Jan 17, 2018 at 10:50 PM, Benjamin Poirier > >> > wrote: > >> > > It was repor

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-19 Thread Florian Fainelli
On 01/19/2018 02:06 PM, kbuild test robot wrote: > Hi Florian, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-stmmac-Fix-reception-of-Broadcom-switches-tags/2018012

[net-next:master 1587/1624] drivers/net/ethernet/chelsio/cxgb4/cudbg_zlib.c:43:47: sparse: Using plain integer as NULL pointer

2018-01-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 85831e56a1d0c75a1560e61acbb8591e9f11c6b7 commit: 91c1953de38725d41cf9a677569a8cc280065064 [1587/1624] cxgb4: use zlib deflate to compress firmware dump reproduce: # apt-get install sparse git

Re: [PATCH iproute2] devlink: Ignore unknown attributes

2018-01-19 Thread David Ahern
On 1/19/18 2:02 PM, Stephen Hemminger wrote: > On Thu, 18 Jan 2018 20:42:44 -0800 > David Ahern wrote: > >> On 1/17/18 5:28 AM, Arkadi Sharshevsky wrote: >>> In case of extending the UAPI old packages would break. >>> >>> Signed-off-by: Arkadi Sharshevsky >>> --- >>> devlink/devlink.c | 2 +- >>

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

2018-01-19 Thread Jakub Kicinski
On Fri, 19 Jan 2018 14:17:45 +, Roman Gushchin wrote: > > Looks good, thanks Roman! > > Would you mind updating the map names as well? It seems the > > BPF_MAP_TYPE_CPUMAP is missing from the list in map.c. > > Hello, Quentin! > > Here is the patch. Thank you for following up, would you al

Re: [PATCH] selftests: bpf: update .gitignore with missing generated files

2018-01-19 Thread Daniel Borkmann
On 01/19/2018 01:36 AM, Shuah Khan wrote: > Update .gitignore with missing generated files. > > Signed-off-by: Shuah Khan Applied to bpf-next, thanks Shuah!

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

2018-01-19 Thread Daniel Borkmann
On 01/19/2018 03:37 PM, Quentin Monnet wrote: > 2018-01-19 14:17 UTC+ ~ Roman Gushchin >> On Mon, Jan 15, 2018 at 07:32:01PM +, Quentin Monnet wrote: > > [...] > >>> Looks good, thanks Roman! >>> Would you mind updating the map names as well? It seems the >>> BPF_MAP_TYPE_CPUMAP is missi

Re: [PATCH net] ipv6: don't let tb6_root node share routes with other node

2018-01-19 Thread Ido Schimmel
On Fri, Jan 19, 2018 at 01:46:02PM -0800, Wei Wang wrote: > On Fri, Jan 19, 2018 at 1:36 PM, Wei Wang wrote: > > > > > > On Fri, Jan 19, 2018 at 1:13 PM, Ido Schimmel wrote: > >> Hi Wei, Martin, > >> > >> On Thu, Jan 18, 2018 at 03:31:29PM -0800, Wei Wang wrote: > >>> On Thu, Jan 18, 2018 at 2:47

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-19 Thread kbuild test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-stmmac-Fix-reception-of-Broadcom-switches-tags/20180120-044006 config: x86_64-randconfig-x002-201802 (attached as .conf

Re: [PATCH iproute2] devlink: Ignore unknown attributes

2018-01-19 Thread Stephen Hemminger
On Thu, 18 Jan 2018 20:42:44 -0800 David Ahern wrote: > On 1/17/18 5:28 AM, Arkadi Sharshevsky wrote: > > In case of extending the UAPI old packages would break. > > > > Signed-off-by: Arkadi Sharshevsky > > --- > > devlink/devlink.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-19 Thread Pravin Shelar
On Fri, Jan 19, 2018 at 3:58 AM, Daniel Axtens wrote: > Pravin Shelar writes: > >> On Thu, Jan 18, 2018 at 5:28 PM, Daniel Axtens wrote: >>> Pravin Shelar writes: >>> On Thu, Jan 18, 2018 at 5:08 AM, Daniel Axtens wrote: > Pravin Shelar writes: > >> On Mon, Jan 15, 2018 at 6:

MPLS-TP From Linux

2018-01-19 Thread Алексей Болдырев
Please tell me if the MPLS-TP implementation in Linux is being implemented? RFC: https://tools.ietf.org/html/rfc5654

Re: [PATCH net] ipv6: don't let tb6_root node share routes with other node

2018-01-19 Thread Wei Wang
On Fri, Jan 19, 2018 at 1:36 PM, Wei Wang wrote: > > > On Fri, Jan 19, 2018 at 1:13 PM, Ido Schimmel wrote: >> Hi Wei, Martin, >> >> On Thu, Jan 18, 2018 at 03:31:29PM -0800, Wei Wang wrote: >>> On Thu, Jan 18, 2018 at 2:47 PM, Martin KaFai Lau wrote: >>> > On Thu, Jan 18, 2018 at 10:40:03AM -08

[net-next 13/15] net/mlx5e: Merge per priority stats groups

2018-01-19 Thread Saeed Mahameed
From: Kamal Heib Merge the per priority traffic and pfc groups into one group, because both groups share the same update_stats() callback which will be introduced in the upcoming patch. Signed-off-by: Kamal Heib Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_stat

[net-next 07/15] net/mlx5: Enable setting hairpin queue size

2018-01-19 Thread Saeed Mahameed
From: Or Gerlitz Allow to specify the size of the hairpin queues along with the packet buffer data size from the core setup code. If the driver doesn't provide this, the FW applies proper value that matches the provided data size and a FW chosen RQ stride size. Signed-off-by: Or Gerlitz Signed

[net-next 15/15] net/mlx5e: Add likely to the common RX checksum flow

2018-01-19 Thread Saeed Mahameed
From: Gal Pressman Most of the packets return true for is_last_ethertype_ip, surround it with likely compiler hint. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[net-next 05/15] net/mlx5: Vectorize the low level core hairpin object

2018-01-19 Thread Saeed Mahameed
From: Or Gerlitz Enhance the hairpin setup code at the core to support a set of N (RQ,SQ) pairs. This will be later used by the caller to set RSS spreading among the different RQs. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c|

[net-next 14/15] net/mlx5e: Extend the stats group API to have update_stats()

2018-01-19 Thread Saeed Mahameed
From: Kamal Heib Extend the stats group API to have an update_stats() callback which will be used to fetch the hardware or software counters data. Signed-off-by: Kamal Heib Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- .../net/ethernet/mellanox

[net-next 06/15] net/mlx5e: Add RSS support for hairpin

2018-01-19 Thread Saeed Mahameed
From: Or Gerlitz Support RSS for hairpin traffic. We create multiple hairpin RQ/SQ pairs and RSS TTC table per hairpin instance and steer the related flows through that table so they are spread between the pairs. We open one pair per 50Gbs link speed, for all speeds <= 50Gbs, there is one pair a

[net-next 08/15] net/mlx5e: Set hairpin queue size

2018-01-19 Thread Saeed Mahameed
From: Or Gerlitz For a given hairpin packet buffer size, different queue sizes (values of log_hairpin_num_packets) determine how the data is broken to strides on the RQ. Currently the chosen value is set to 64B strides. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/e

[net-next 09/15] net/mlx5e: Print delta since last transmit per SQ upon TX timeout

2018-01-19 Thread Saeed Mahameed
From: Eran Ben Elisha When driver callback for TX timeout is being called, it handles all stopped xmit queues (not only the ones which their timeout expired). Add usecs since last transmit to TX timeout logs per send queue in order to monitor if the queue timeout expired. Signed-off-by: Eran Ben

[net-next 11/15] net/mlx5e: Poll event queue upon TX timeout before performing full channels recovery

2018-01-19 Thread Saeed Mahameed
From: Eran Ben Elisha Up until this patch, on every TX timeout we would try to do channels recovery. However, in case of a lost interrupt for an EQ, the channel associated to it cannot be recovered if reopened as it would never get another interrupt on sent/received traffic, and eventually ends

[net-next 01/15] net/mlx5e: Use vhca id as the hairpin peer identifier

2018-01-19 Thread Saeed Mahameed
From: Or Gerlitz The peer vhca id spans less bits vs the ifindex and can well serve for the hairpin hash key, move to use that. This is a pre-step to put more info into the hairpin hash key in downstream patch while keeping it at 32 bits. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed

[net-next 12/15] net/mlx5e: Add per-channel counters infrastructure, use it upon TX timeout

2018-01-19 Thread Saeed Mahameed
From: Eran Ben Elisha Add per-channel counter ch#_eq_rearm to monitor how many lost interrupt recovery actions happened upon TX timeouts. Signed-off-by: Eran Ben Elisha Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 + driv

[net-next 02/15] net/mlx5e: Set per priority hairpin pairs

2018-01-19 Thread Saeed Mahameed
From: Or Gerlitz As part of the QoS model, on xmit, the HW mandates that all packets going through a given SQ have the same priority. To align hairpin SQs with that, we use the priority given as part of the matching for the hairpin hash key. This ensures that flows/packets mapped to different HW

[net-next 04/15] net/mlx5e: Enlarge the NIC TC offload steering prio to support two levels

2018-01-19 Thread Saeed Mahameed
From: Or Gerlitz This will allow to be able and set TC rule whose steering dest is RSS TTC steering table. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/driv

[net-next 10/15] net/mlx5e: Add Event Queue meta data info for TX timeout logs

2018-01-19 Thread Saeed Mahameed
From: Eran Ben Elisha When TX timeout occurs, EQ consumer index and irqn can help in debug for understanding the SW state of EQ. Add them to the logger prints for the relevant EQ only. Signed-off-by: Eran Ben Elisha Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethe

[net-next 03/15] net/mlx5e: Refactor RSS related objects and code

2018-01-19 Thread Saeed Mahameed
From: Or Gerlitz In order to use RSS for hairpin, we refactor the code that deals with setup of the TTC steering tables. This is done using an interim ttc params object that has the flow table attributes, TIR numbers, etc. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/ne

[pull request][net-next 00/15] Mellanox, mlx5 updates 2018-01-19

2018-01-19 Thread Saeed Mahameed
Hi Dave, The following series includes updates for mlx5e netdev driver, for more information please see tag log below. Please pull and let me know if there's any problem. Thanks, Saeed. --- The following changes since commit 60c2530696320ee6ffe4491c17079fa403790c98: tipc: fix race between p

[net-next:master 1587/1613] drivers/net/ethernet/chelsio/cxgb4/cudbg_zlib.c:39:5: error: redefinition of 'cudbg_compress_buff'

2018-01-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: fd5204cdfb34c8b1e265d09791eb5dd4bacce642 commit: 91c1953de38725d41cf9a677569a8cc280065064 [1587/1613] cxgb4: use zlib deflate to compress firmware dump config: i386-randconfig-i1-201802 (attached as .config)

Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

2018-01-19 Thread Willem de Bruijn
On Wed, Jan 17, 2018 at 6:06 PM, Jesus Sanchez-Palencia wrote: > From: Vinicius Costa Gomes > > TBS (Time Based Scheduler) uses the information added earlier in this > series (the socket option SO_TXTIME and the new role of > sk_buff->tstamp) to schedule traffic transmission based on absolute > t

[PATCH v2] smc: return booleans instead of integers

2018-01-19 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true/false instead of 1/0. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Fix function using_ipsec as suggested by Ursula Braun. - Update subject line. net/smc/smc.h | 4 ++-

Re: [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

2018-01-19 Thread Willem de Bruijn
On Wed, Jan 17, 2018 at 6:06 PM, Jesus Sanchez-Palencia wrote: > From: Richard Cochran > > This patch introduces SO_TXTIME. User space enables this option in > order to pass a desired future transmit time in a CMSG when calling > sendmsg(2). > > A new field is added to struct sockcm_cookie, and

Re: [PATCH net] ipv6: don't let tb6_root node share routes with other node

2018-01-19 Thread Ido Schimmel
Hi Wei, Martin, On Thu, Jan 18, 2018 at 03:31:29PM -0800, Wei Wang wrote: > On Thu, Jan 18, 2018 at 2:47 PM, Martin KaFai Lau wrote: > > On Thu, Jan 18, 2018 at 10:40:03AM -0800, Wei Wang wrote: > >> From: Wei Wang > >> > >> After commit 4512c43eac7e, if we add a route to the subtree of tb6_root

Re: [PATCH] smc: return boolean instead of integer in using_ipsec

2018-01-19 Thread Gustavo A. R. Silva
Hi Ursula, Quoting Ursula Braun : On 01/19/2018 12:33 AM, Gustavo A. R. Silva wrote: Return statements in functions returning bool should use true/false instead of 1/0. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/smc/smc.h | 2 +- 1 file

Re: [PATCH v2 net-next 0/2] ATU and VTU irq fixes

2018-01-19 Thread David Miller
From: Andrew Lunn Date: Thu, 18 Jan 2018 17:42:48 +0100 > Further testing and code review found two sets of bugs. > > Core review found a cut/paste error in the irq setup code. > > A board which does not have an interrupt line from the switch to the > SoC, and experiancing an EPROBE_DEFER throw

Re: [PATCHv3 net-next 0/7] net: sched: cls: add extack support

2018-01-19 Thread David Miller
From: Alexander Aring Date: Thu, 18 Jan 2018 11:20:48 -0500 > this patch adds extack support for TC classifier subsystem. The first > patch fixes some code style issues for this patch series pointed out > by checkpatch. The other patches until the last one prepares extack > handling for the TC cl

Re: [patch iproute2 net-next v11 4/4] tc: implement ingress/egress block index attributes for qdiscs

2018-01-19 Thread David Ahern
On 1/17/18 2:48 AM, Jiri Pirko wrote: > diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c > index 3f91558..9f06d37 100644 > --- a/tc/tc_qdisc.c > +++ b/tc/tc_qdisc.c > @@ -31,6 +31,7 @@ static int usage(void) > fprintf(stderr, " [ handle QHANDLE ] [ root | ingress | clsact | > parent CLASSID

Re: [patch iproute2 net-next v11 3/4] tc: introduce support for block-handle for filter operations

2018-01-19 Thread David Ahern
On 1/17/18 2:48 AM, Jiri Pirko wrote: > @@ -89,7 +93,21 @@ static int tc_filter_modify(int cmd, unsigned int flags, > int argc, char **argv, > NEXT_ARG(); > if (d[0]) > duparg("dev", *argv); > + if (block

Re: [PATCH net-next 00/12] nfp: devlink, capabilities extensions and updates

2018-01-19 Thread David Miller
From: Jakub Kicinski Date: Wed, 17 Jan 2018 18:50:54 -0800 > This series starts with an improvement to the usability of the device > memory accessors (CPP transactions). Next few patches are devoted to > fixing the devlink locking. After recent patches for mlxsw the locking > scheme of devlink

Re: [patch net-next] mlxsw: spectrum: Upper-bound supported FW version

2018-01-19 Thread David Miller
From: Jiri Pirko Date: Thu, 18 Jan 2018 12:55:23 +0100 > From: Yuval Mintz > > During initialization the driver checks whether the flashed FW image > suits its requirements by checking that it's sufficiently new. > However, there's only a weak backward compatibility scheme that is > actually gu

Re: [patch iproute2 net-next v11 2/4] tc: introduce tc_qdisc_block_exists helper

2018-01-19 Thread David Ahern
On 1/17/18 2:48 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This hepler used qdisc dump to list all qdisc and find if block index in > question is used by any of them. That means the block with specified > index exists. > > Signed-off-by: Jiri Pirko > --- > tc/tc_qdisc.c | 61 > +

Re: [PATCH 0/2 net-next] tcp: do not use RTT from delayed ACKs for min-RTT

2018-01-19 Thread David Miller
From: Yuchung Cheng Date: Wed, 17 Jan 2018 12:10:59 -0800 > This patch set prevents TCP sender from using RTT samples from > (suspected) delayed ACKs as the minimum RTT, to avoid unbounded > over-estimation of the network path delay. This issue is common > when a connection has extended periods o

[PATCH net-next] hv_netvsc: Use the num_online_cpus() for channel limit

2018-01-19 Thread Haiyang Zhang
From: Haiyang Zhang Since we no longer localize channel/CPU affiliation within one NUMA node, num_online_cpus() is used as the number of channel cap, instead of the number of processors in a NUMA node. This patch allows a bigger range for tuning the number of channels. Signed-off-by: Haiyang Zh

Re: [PATCH iproute2-next] tc: red: allow setting th_min and th_max to the same value

2018-01-19 Thread David Ahern
On 1/16/18 3:08 PM, Jakub Kicinski wrote: > Setting th_min and th_max to the same value may be useful for DCTCP > deployments. The original DCTCP paper describes it as a simplest way > of achieving simple ECN threshold marking. Indeed, there doesn't seem > to be any simpler qdisc in Linux which w

  1   2   3   >