Hi,
I have a question about __netif_receive_skb_core(),
1. create a macvlan device on a real ethernet device and configure a mac
address to this macvlan device
2. create a AF_PACKET socket and bind to the real ethernet device in step 1
3. user application will receive packet which destination mac
> On Jan 4, 2018, at 10:42 PM, Yafang Shao wrote:
>
> sk->sk_protocol and sk->sk_family are exposed as tracepoint arguments.
> Then we can conveniently use these two arguments to do the filter.
>
> Suggested-by: Brendan Gregg
> Signed-off-by: Yafang Shao
> ---
> include/trace/events/sock.h |
On Fri, Jan 05, 2018 at 01:41:46AM +0900, Lorenzo Colitti wrote:
> On Wed, Jan 3, 2018 at 9:10 PM, Steffen Klassert
> wrote:
> > The fact that you need new keyed VTIs looks a bit like a workaround
> > of the design limitations the VTI interfaces have. Unfortunately
> > this is not the only limitat
sk->sk_protocol and sk->sk_family are exposed as tracepoint arguments.
Then we can conveniently use these two arguments to do the filter.
Suggested-by: Brendan Gregg
Signed-off-by: Yafang Shao
---
include/trace/events/sock.h | 24 ++--
net/ipv4/af_inet.c | 6 --
Hi,
I am quite new to IPv6.
I ran to one problem hope you guys can help me.
I have multiple ethernet port box which runs by Altera's Cyclone 5.
I am using source based policy routing for ipv6.
The problem is when there is "default via " entry in per interface
routing table then ping to a link loca
.map_alloc callbacks contain a number of checks validating user-
-provided map attributes against constraints of a particular map
type. For offloaded maps we will need to check map attributes
without actually allocating any memory on the host. Add a new
callback for validating attributes before a
Add a helper to check if netdev could be found and whether it
has .ndo_bpf callback. There is no need to check the callback
every time it's invoked, ndos can't reasonably be swapped for
a set without .ndp_bpf while program is loaded.
bpf_dev_offload_check() will also be used by map offload.
Sign
BPF map offload follow similar path to program offload. At creation
time users may specify ifindex of the device on which they want to
create the map. Map will be validated by the kernel's
.map_alloc_check callback and device driver will be called for the
actual allocation. Map will have an empt
Instead of having an app callback per message type hand off
all offload-related handling to apps with one "rest of ndo_bpf"
callback.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/net/ethernet/netronome/nfp/bpf/main.c | 5 +--
drivers/net/ethernet/netronome/nfp/bpf
Verify our current constraints on the location of the key
are met and generate the code for calling map lookup on
the datapath.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/net/ethernet/netronome/nfp/bpf/jit.c | 51 +++
drivers/net/ethernet/netr
Use the new callback to perform allocation checks for hash maps.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
kernel/bpf/hashtab.c | 55 +---
1 file changed, 39 insertions(+), 16 deletions(-)
diff --git a/kernel/bpf/hashtab.c b/k
Number of attribute checks are currently performed after hashtab
is already allocated. Move them to be able to split them out to
the check function later on. Checks have to now be performed on
the attr union directly instead of the members of bpf_map, since
bpf_map will be allocated later. No fu
Implement calls for FW map communication.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/net/ethernet/netronome/nfp/bpf/cmsg.c | 210 +-
drivers/net/ethernet/netronome/nfp/bpf/fw.h | 65
drivers/net/ethernet/netronome/nfp/bpf/main.h |
Plug in to the stack's map offload callbacks for BPF map offload.
Get next call needs some special handling on the FW side, since
we can't send a NULL pointer to the FW there is a get first entry
FW command.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/net/ethernet/netr
With map offload coming, we need to call program offload structure
something less ambiguous. Pure rename, no functional changes.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/net/ethernet/netronome/nfp/bpf/offload.c | 2 +-
include/linux/bpf.h
Map memory needs to use 40 bit addressing. Add handling of such
accesses. Since 40 bit addresses are formed by using both 32 bit
operands we need to pre-calculate the actual address instead of
adding in the offset inside the instruction, like we did in 32 bit
mode.
Signed-off-by: Jakub Kicinski
For map support we will need to send and receive control messages.
Add basic support for sending a message to FW, and waiting for a
reply.
Control messages are tagged with a 16 bit ID. Add a simple ID
allocator and make sure we don't allow too many messages in flight,
to avoid request <> reply mi
All map types reimplement the field-by-field copy of union bpf_attr
members into struct bpf_map. Add a helper to perform this operation.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
Acked-by: Alexei Starovoitov
---
include/linux/bpf.h | 1 +
kernel/bpf/arraymap.c | 7 +--
Parse helper function and supported map FW TLV capabilities.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/net/ethernet/netronome/nfp/bpf/fw.h | 16 +
drivers/net/ethernet/netronome/nfp/bpf/main.c | 47 +++
drivers/net/ethernet/netronome
To be able to split code into reasonable chunks we need to add
the map data structures already. Later patches will add code
piece by piece.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/net/ethernet/netronome/nfp/bpf/main.c | 7 ++-
drivers/net/ethernet/netronome/n
Use the new callback to perform allocation checks for array maps.
The fd maps don't need a special allocation callback, they only
need a special check callback.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
kernel/bpf/arraymap.c | 40 +++-
1 f
Hi!
This set adds support for creating maps on networking devices. BPF is
programs+maps, the pure program offload has been around for quite some
time, this patchset adds the map part of the equation.
Maps are allocated on the target device from the start. There is no
host copy when map is creat
From: Alexei Starovoitov
Under speculation, CPUs may mis-predict branches in bounds checks. Thus,
memory accesses under a bounds check may be speculated even if the
bounds check fails, providing a primitive for building a side channel.
To avoid leaking kernel data round up array-based maps and m
On 01/03/2018 02:25 AM, Jesper Dangaard Brouer wrote:
> This patch only introduce the core data structures and API functions.
> All XDP enabled drivers must use the API before this info can used.
>
> There is a need for XDP to know more about the RX-queue a given XDP
> frames have arrived on. For
On Wed, Jan 3, 2018 at 2:25 AM, Jesper Dangaard Brouer
wrote:
> Driver hook points for xdp_rxq_info:
> * reg : bnxt_alloc_rx_rings
> * unreg: bnxt_free_rx_rings
>
> This driver should be updated to re-register when changing
> allocation mode of RX rings.
>
> Tested on actual hardware.
>
> Cc: A
On 01/03/2018 02:26 AM, Jesper Dangaard Brouer wrote:
> Now all XDP driver have been updated to setup xdp_rxq_info and assign
> this to xdp_buff->rxq. Thus, it is now safe to enable access to some
> of the xdp_rxq_info struct members.
>
> This patch extend xdp_md and expose UAPI to userspace for
On 01/03/2018 02:25 AM, Jesper Dangaard Brouer wrote:
> The i40e driver has a special "FDIR" RX-ring (I40E_VSI_FDIR) which is
> a sideband channel for configuring/updating the flow director tables.
> This (i40e_vsi_)type does not invoke XDP-ebpf code.
>
> As suggested by Björn (V2): Instead of mar
On 01/03/2018 02:25 AM, Jesper Dangaard Brouer wrote:
> Driver hook points for xdp_rxq_info:
> * reg : ixgbe_setup_rx_resources()
> * unreg: ixgbe_free_rx_resources()
>
> Tested on actual hardware.
>
> V2: Fix ixgbe_set_ringparam, clear xdp_rxq_info in temp_ring
>
> Cc: intel-wired-...@lists.
Since both first_rx and rx_ring are the head of rx ring, it not
necessary to use two structure members to statically indicate
the head of rx ring. So first_rx is removed.
CC: Srinivas Eeda
CC: Joe Jin
CC: Junxiao Bi
Signed-off-by: Zhu Yanjun
---
drivers/net/ethernet/nvidia/forcedeth.c | 17 ++
Add psock NULL check to handle a racing sock event that can get the
sk_callback_lock before this case but after xchg happens causing the
refcnt to hit zero and sock user data (psock) to be null and queued
for garbage collection.
Also add a comment in the code because this is a bit subtle and
not o
To be reused by other eBPF program other than queue selection.
Signed-off-by: Jason Wang
---
drivers/net/tun.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index e367d631..0853829 100644
--- a/drivers
This patch allows userspace to attach eBPF filter to tun. This will
allow to implement VM dataplane filtering in a more efficient way
compared to cBPF filter by allowing either qemu or libvirt to
attach eBPF filter to tun.
Signed-off-by: Jason Wang
---
drivers/net/tun.c | 39 ++
Hi all:
This series tries to implement eBPF socket filter for tun. This could
be used for implementing efficient virtio-net receive filter for
vhost-net.
Thanks
Changes from V1:
- trim more bytes if vlan tag is existed to make sure the packet
length does not exceed what is allowed by the filte
On Wed, Jan 3, 2018 at 7:49 PM, Ed Swierk wrote:
> On Fri, Dec 22, 2017 at 3:31 PM, Pravin Shelar wrote:
>> On Thu, Dec 21, 2017 at 7:17 AM, Ed Swierk
>> wrote:
>>> IPv4 and IPv6 packets may arrive with lower-layer padding that is not
>>> included in the L3 length. For example, a short IPv4 pac
On 1/4/18 12:01 AM, Leon Romanovsky wrote:
> diff --git a/rdma/utils.c b/rdma/utils.c
> index af2b374d..446c23da 100644
> --- a/rdma/utils.c
> +++ b/rdma/utils.c
> @@ -114,6 +114,225 @@ static void dev_map_cleanup(struct rd *rd)
> }
> }
>
> +static int add_filter(struct rd *rd, char *key,
On Thu, Jan 4, 2018 at 10:38 AM, David Miller wrote:
> From: Pravin B Shelar
> Date: Tue, 2 Jan 2018 20:14:42 -0800
>
>> Signed-off-by: Pravin Shelar
>
> Applied, but please take Joe's feedback into consideration.
I was bit busy so could not send update soon. I am planing on updating mailmap.
Masahiro Yamada (2):
genl_magic: remove own BUILD_BUG_ON*() defines
build_bug.h: remove BUILD_BUG_ON_NULL()
include/linux/build_bug.h | 2 --
include/linux/genl_magic_func.h | 12 +---
net/ipv6/mcast.c| 8
3 files changed, 5 insertions(+), 17 deletions
This macro is only used by net/ipv6/mcast.c, but there is no reason
why it must be BUILD_BUG_ON_NULL().
Replace it with BUILD_BUG_ON_ZERO(), and remove BUILD_BUG_ON_NULL()
definition from .
Signed-off-by: Masahiro Yamada
---
include/linux/build_bug.h | 2 --
net/ipv6/mcast.c | 8 -
Thank you for your time,
We are looking for clients in your country with good business or project that
requires financing to execute.
Please get back to me if you are interested in this or you know anybody who has
good business ideas but lack the necessary capital to fund his projects so we
ca
On Wed, Dec 20, 2017 at 4:41 PM, Chris Chiu wrote:
> Hi,
> We've hit a suspend/resume issue on a Acer desktop caused by r8169
> driver. The dmseg
> https://gist.github.com/mschiu77/b741849b5070281daaead8dfee312d1a
> shows it's still in msleep() within a mutex lock.
> After looking into the
On Tue, Jan 02, 2018 at 08:23:45PM +0100, Pali Rohár wrote:
> On Friday 10 November 2017 00:38:22 Pali Rohár wrote:
> > This patch series fix processing MAC address for wl1251 chip found in Nokia
> > N900.
> >
> > Changes since v1:
> > * Added Acked-by for Pavel Machek
> > * Fixed grammar
> > * M
On 12/26/2017 10:22 PM, David Miller wrote:
> From: Joao Martins
> Date: Thu, 21 Dec 2017 17:24:28 +
>
>> Commit eb1723a29b9a ("xen-netback: refactor guest rx") refactored Rx
>> handling and as a result decreased max grant copy ops from 4352 to 64.
>> Before this commit it would drain the rx_
On 2018/1/4 23:17, Faiz Abbas wrote:
Hi,
On Wednesday 03 January 2018 08:47 PM, Marc Kleine-Budde wrote:
On 01/03/2018 04:06 PM, Faiz Abbas wrote:
Hi,
On Wednesday 03 January 2018 07:55 PM, Marc Kleine-Budde wrote:
On 01/03/2018 01:39 PM, Faiz Abbas wrote:
On Tuesday 02 January 2018 09:37
Hello Mat,
On 02/01/18 - 11:39:23, Mat Martineau wrote:
>
> Hi Christoph -
>
> On Mon, 18 Dec 2017, Christoph Paasch wrote:
>
> > This is all just copy-pasting the TCP_MD5-code into functions that are
> > placed in net/ipv4/tcp_md5.c.
> >
> > Signed-off-by: Christoph Paasch
> > Reviewed-by: M
On Fri, Jan 05, 2018 at 02:44:07AM +0200, Ivan Khoronzhuk wrote:
> + G.Strashko
> The below change also brokes phy connect for am572x..
>
> int genphy_restart_aneg(struct phy_device *phydev)
> {
> - int ctl = phy_read(phydev, MII_BMCR);
> -
> - if (ctl < 0)
> - return c
+ G.Strashko
The below change also brokes phy connect for am572x..
int genphy_restart_aneg(struct phy_device *phydev)
{
- int ctl = phy_read(phydev, MII_BMCR);
-
- if (ctl < 0)
- return ctl;
-
- ctl |= BMCR_ANENABLE | BMCR_ANRESTART;
-
/* Don't isolate the
Begin forwarded message:
Date: Fri, 05 Jan 2018 00:21:42 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 198353] New: Generic netlink family bug when multicast groups are
greater than 13
https://bugzilla.kernel.org/show_bug.cgi?id=198353
Add support for reading many more tcp_sock fields
state,same as sk->sk_state
rtt_min same as sk->rtt_min.s[0].v (current rtt_min)
snd_ssthresh
rcv_nxt
snd_nxt
snd_una
mss_cache
ecn_flags
rate_delivered
rate_interval_us
packets_out
retrans_out
total_retrans
Adds direct R/W access to sk_txhash and access to tclass for ipv6 flows
through getsockopt and setsockopt. Sample usage for tclass:
bpf_getsockopt(skops, SOL_IPV6, IPV6_TCLASS, &v, sizeof(v))
where skops is a pointer to the ctx (struct bpf_sock_ops).
Signed-off-by: Lawrence Brakmo
---
includ
Adds support for passing up to 4 arguments to sock_ops bpf functions. It
reusues the reply union, so the bpf_sock_ops structures are not
increased in size.
Signed-off-by: Lawrence Brakmo
---
include/linux/filter.h | 1 +
include/net/tcp.h| 64 ++
Adds field bpf_sock_ops_flags to tcp_sock and bpf_sock_ops. Its primary
use is to determine if there should be calls to sock_ops bpf program at
various points in the TCP code. The field is initialized to zero,
disabling the calls. A sock_ops BPF program can set, per connection and
as necessary, whe
This patch adds a macro, SOCK_OPS_SET_FIELD, for writing to
struct tcp_sock or struct sock fields. This required adding a new
field "temp" to struct bpf_sock_ops_kern for temporary storage that
is used by sock_ops_convert_ctx_access. It is used to store and recover
the contents of a register, so th
This patchset adds support for:
- direct R or R/W access to many tcp_sock fields
- passing up to 4 arguments to sock_ops BPF functions
- tcp_sock field bpf_sock_ops_flags for controlling callbacks
- optionally calling sock_ops BPF program when RTO fires
- optionally calling sock_ops BPF program wh
Adds support for calling sock_ops BPF program when there is a
retransmission. Two arguments are used; one for the sequence number and
other for the number of segments retransmitted. Does not include syn-ack
retransmissions.
New op: BPF_SOCK_OPS_RETRANS_CB.
Signed-off-by: Lawrence Brakmo
---
inc
Adds an optional call to sock_ops BPF program based on whether the
BPF_SOCK_OPS_RTO_CB_FLAG is set in bpf_sock_ops_flags.
The BPF program is passed 2 arguments: icsk_retransmits and whether the
RTO has expired.
Signed-off-by: Lawrence Brakmo
---
include/uapi/linux/bpf.h | 5 +
include/uapi/l
Make SOCK_OPS_GET_TCP helper macro size independent (before only worked
with 4-byte fields.
Signed-off-by: Lawrence Brakmo
---
net/core/filter.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/net/core/filter.c b/net/core/filter.c
index 130b842..099ff9fd 100644
Adds support for calling sock_ops BPF program when there is a TCP state
change. Two arguments are used; one for the old state and another for
the new state.
There is a new enum in include/uapi/linux/bpf.h that exports the TCP
states that prepends BPF_ to the current TCP state names. If it is ever
Changed SOCK_OPS_GET_TCP to SOCK_OPS_GET_FIELD and added 2
arguments so now it can also work with struct sock fields.
The first argument is the name of the field in the bpf_sock_ops
struct, the 2nd argument is the name of the field in the OBJ struct.
Previous: SOCK_OPS_GET_TCP(FIELD_NAME)
New:
Added a selftest for tcpbpf (sock_ops) that checks that the appropriate
callbacks occured and that it can access tcp_sock fields and that their
values are correct.
Run with command: ./test_tcpbpf_user
Signed-off-by: Lawrence Brakmo
---
tools/include/uapi/linux/bpf.h | 70 ++
The first one fixes the TC Flower flow parameter passed to firmware. The
2nd one fixes the VF index range checking for iproute2 SRIOV related commands.
Sunil Challa (1):
bnxt_en: Fix population of flow_type in bnxt_hwrm_cfa_flow_alloc()
Venkat Duvvuru (1):
bnxt_en: Fix the 'Invalid VF' id ch
From: Venkat Duvvuru
In bnxt_vf_ndo_prep (which is called by bnxt_get_vf_config ndo), there is a
check for "Invalid VF id". Currently, the check is done against max_vfs.
However, the user doesn't always create max_vfs. So, the check should be
against the created number of VFs. The number of bnxt_
From: Sunil Challa
flow_type in HWRM_FLOW_ALLOC is not being populated correctly due to
incorrect passing of pointer and size of l3_mask argument of is_wildcard().
Fixed this.
Fixes: db1d36a27324 ("bnxt_en: add TC flower offload flow_alloc/free FW cmds")
Signed-off-by: Sunil Challa
Reviewed-by:
The two conditions triggering BUG_ON() are somewhat unrelated:
the tcp_skb_pcount() check is meant to catch TSO flaws, the
second one checks sanity of congestion window bookkeeping.
Split them into two separate BUG_ON() assertions on two lines,
so that we know which one actually triggers, when the
On Thu, Jan 4, 2018 at 1:59 AM, Quentin Monnet
wrote:
> Hi Cong,
>
> 2018-01-03 18:08 UTC-0800 ~ Cong Wang
>> On Wed, Jan 3, 2018 at 5:30 PM, Jakub Kicinski
>> wrote:
>>> From: Quentin Monnet
>>>
>>> The definition of functions tcf_block_get() and tcf_block_get_ext()
>>> depends of CONFIG_NET_C
Hi David,
I'm not sure if CAIF is still maintained by Dmitry Tarnyagin. Do you
have any comment on this one?
Thanks,
Yang
On 12/7/17 11:13 AM, Yang Shi wrote:
Hi folks,
Any comment on this one?
Thanks,
Yang
On 11/17/17 3:02 PM, Yang Shi wrote:
Preempt counter APIs have been split out,
Hi David,
Any comment is appreciated.
Thanks,
Yang
On 12/7/17 11:27 AM, Pravin Shelar wrote:
On Fri, Nov 17, 2017 at 3:02 PM, Yang Shi wrote:
Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by openvswitch at all.
So, remov
On 01/01/2018 01:36 PM, Alexander Alemayhu wrote:
> The relative path can be wrong and prevents the build.
You mean if you move the files from tools/lib/bpf/ to a different
location, and then specify srctree var pointing to a kernel tree?
I think this would also break various other assumptions in
Hi David,
Any more comment on this change?
Thanks,
Yang
On 12/7/17 5:40 PM, Ying Xue wrote:
On 11/18/2017 07:02 AM, Yang Shi wrote:
Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by TIPC at all.
So, remove the unused hardi
On Thu, Jan 04, 2018 at 10:37:37PM +0200, Or Gerlitz wrote:
> > net/mlx5e: move interrupt moderation structs to new file
> > net/mlx5e: move interrupt moderation forward declarations
> > net/mlx5e: remove rq references in mlx5e_rx_am
> > net/mlx5e: move AM logic enums
> > net/mlx5e: move
On Thu, Jan 04, 2018 at 02:36:54PM -0800, Stephen Hemminger wrote:
> On Thu, 4 Jan 2018 15:21:30 -0500
> Andy Gospodarek wrote:
>
> > +DYNAMIC INTERRUPT MODERATION
> > +M: Tal Gilboa
> > +S: Mainained
>
> s/Mainained/Maintained/
Ugh. Thanks for noticing that, Stephen!
The real device over which the rmnet devices are installed also
aggregate multiple IP packets and sends them as a single large
aggregate
frame to the hardware.
It would be nice to give some details about this in the changelog.
Also what results you get with different values for the shift (10,
On Thu, 4 Jan 2018 15:21:30 -0500
Andy Gospodarek wrote:
> +DYNAMIC INTERRUPT MODERATION
> +M: Tal Gilboa
> +S: Mainained
s/Mainained/Maintained/
On 01/04/2018 02:57 AM, John Fastabend wrote:
> This was added for some work that was eventually factored out but the
> helper call was missed. Remove it now and add it back later if needed.
>
> Signed-off-by: John Fastabend
Both applied to bpf-next, thanks John!
On Thu, Jan 4, 2018 at 12:21 PM, Andy Gospodarek wrote:
> From: Andy Gospodarek
>
> This implements the changes needed for the bnxt_en driver to add support
> for dynamic interrupt moderation per ring.
>
> This does add additional counters in the receive path, but testing shows
> that any additio
Allow a process bound to a VRF to connect to a linklocal address.
Currently, this fails because of a mismatch between the scope of the
linklocal address and the sk_bound_dev_if inherited by the VRF binding:
$ ssh -6 fe80::70b8:cff:fedd:ead8%eth1
ssh: connect to host fe80::70b8:cff:fedd:ead8
The patch set implements bpf syscall command BPF_MAP_GET_NEXT_KEY
for stacktrace map. Patch #1 is the core implementation
and Patch #2 implements a bpf test at tools/testing/selftests/bpf
directory. Please see individual patch comments for details.
Changelog:
v1 -> v2:
- For invalid key (key
Added a bpf selftest in test_progs at tools directory for stacktrace.
The test will populate a hashtable map and a stacktrace map
at the same time with the same key, stackid.
The user space will compare both maps, using BPF_MAP_LOOKUP_ELEM
command and BPF_MAP_GET_NEXT_KEY command, to ensure that bo
Currently, bpf syscall command BPF_MAP_GET_NEXT_KEY is not
supported for stacktrace map. However, there are use cases where
user space wants to enumerate all stacktrace map entries where
BPF_MAP_GET_NEXT_KEY command will be really helpful.
In addition, if user space wants to delete all map entries
>>> If you see 8 out of 9 call sites in this file ignore the return value.
>>
>> How do you think about to fix error detection and corresponding
>> exception handling then?
>>
> If I understand your question correctly - not having memory is not a
> correctable error
I am unsure if it would be feas
On 1/4/2018 12:21 PM, Andy Gospodarek wrote:
From: Andy Gospodarek
This converts the dynamic interrupt moderation library from the mlx5_en driver
into a library so it can be used by any driver. The penultimatepatch in this
set adds support for interrupt moderation in the bnxt_en driver and t
On 1/4/18 1:08 PM, Jakub Kicinski wrote:
On Wed, 3 Jan 2018 23:27:45 -0800, Yonghong Song wrote:
Currently, bpf syscall command BPF_MAP_GET_NEXT_KEY is not
supported for stacktrace map. However, there are use cases where
user space wants to enumerate all stacktrace map entries where
BPF_MAP_GE
Since the commit 888cc8c20cf ("sh_eth: remove EDMAC_BIG_ENDIAN") (geez,
I didn't realize that was 2 years ago!) the initializers in the SuperH
platform code for the 'sh_eth_plat_data::edmac_endian' stopped to matter,
so we can remove that field for good (not sure if it was ever useful --
SH7786 E
On Wed, 3 Jan 2018 23:27:45 -0800, Yonghong Song wrote:
> Currently, bpf syscall command BPF_MAP_GET_NEXT_KEY is not
> supported for stacktrace map. However, there are use cases where
> user space wants to enumerate all stacktrace map entries where
> BPF_MAP_GET_NEXT_KEY command will be really help
> Hi Andrew,
>
> Isn't the serdes interface just a normal PHY - the register set in
> Viviens debugfs patch certainly looks like an 88e1545 in one of the
> switches I've here (I think on the dev rev B). Is there a reason why
> this PHY isn't visible as a normal PHY, just like we export the other
On 01/03/2018 06:40 AM, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
I applied this to my ps3-queue branch.
As I mentioned to you several times before, please keep
the commit subject line to less than 50 characters.
Also, in this case the pref
> net/mlx5e: move interrupt moderation structs to new file
> net/mlx5e: move interrupt moderation forward declarations
> net/mlx5e: remove rq references in mlx5e_rx_am
> net/mlx5e: move AM logic enums
> net/mlx5e: move generic functions to new file
> net/mlx5e: change Mellanox reference
From: Andy Gospodarek
Create new header file to prepare to move code that handles irq
moderation to a library that lives in a header file.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 33 +--
drivers/net/ethernet/mellanox/m
From: Andy Gospodarek
This makes mlx5e_am_sample more generic so that it can be called easily
from a driver that does not use the same data structure to store these
values in a single structure.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
---
drivers/net/ethernet/mellanox/mlx5/core/en
From: Andy Gospodarek
Change all mlx5_am* and MLX_AM* references to net_dim and NET_DIM,
respectively, in code that handles dynamic interrupt moderation. Also
change all references from 'am' to 'dim' when used as local variables.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
---
driver
From: Andy Gospodarek
These functions were identified as ones that could be made generic and
used by multiple drivers. Most of the contents of en_rx_am.c are moved
to net_dim.c.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
---
drivers/net/ethernet/mellanox/mlx5/core/Makefile | 4 +
From: Andy Gospodarek
Simplify the arguments net_dim() by formatting them into a struct
net_dim_sample before calling the function.
Signed-off-by: Andy Gospodarek
Suggested-by: Tal Gilboa
Acked-by: Tal Gilboa
---
drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c | 13 -
include/l
From: Andy Gospodarek
This implements the changes needed for the bnxt_en driver to add support
for dynamic interrupt moderation per ring.
This does add additional counters in the receive path, but testing shows
that any additional instructions are offset by throughput gain when the
default confi
From: Andy Gospodarek
Signed-off-by: Andy Gospodarek
Signed-off-by: Tal Gilboa
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 753799d..769857b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4944,6 +4944,11 @@ S: Maintained
F:
From: Andy Gospodarek
More movement to help make this code more generic.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
---
drivers/net/ethernet/mellanox/mlx5/core/en_dim.h | 26 ++
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c | 25 -
2 fil
From: Andy Gospodarek
Move these to newly created file to prepare to move these functions to a
library.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 4
drivers/net/ethernet/mellanox/mlx5/core/en_dim.h | 5 +
2 files change
From: Andy Gospodarek
This converts the dynamic interrupt moderation library from the mlx5_en driver
into a library so it can be used by any driver. The penultimatepatch in this
set adds support for interrupt moderation in the bnxt_en driver and the last
patch creates an entry in the MAINTAINERS
From: Andy Gospodarek
This move allows drivers to add private structure elements to track the
number of packets, bytes, and interrupts events per ring. A driver
also defines a workqueue handler to act on this collected data once per
poll and modify the coalescing parameters per ring.
Signed-off
On 12/26/2017 9:14 AM, Sagi Grimberg wrote:
Are you sure it won't get populated at all ? even if you manually set
IRQ affinity via sysfs ?
Yes, the msi_desc affinity is not initialized without the affinity
descriptor passed (which is what PCI_IRQ_AFFINITY is for).
Anyway we can implement
Commit 0dfb33a0d7e2 ("sch_red: report backlog information") copied
child's backlog into RED's backlog. Back then RED did not maintain
its own backlog counts. This has changed after commit 2f5fb43f
("net_sched: update hierarchical backlog too") and commit d7f4f332f082
("sch_red: update backlog
AFAICT struct gnet_stats_queue.qlen is not used in Qdiscs.
It may, however, be useful for offloads to report HW queue
length there. Add that value to the result of qdisc_qlen_sum().
Signed-off-by: Jakub Kicinski
---
include/net/sch_generic.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
1 - 100 of 261 matches
Mail list logo
