Fri, Oct 20, 2017 at 03:01:35AM CEST, f.faine...@gmail.com wrote:
>On 10/19/2017 02:43 PM, Jiri Pirko wrote:
>> Thu, Oct 19, 2017 at 11:39:55PM CEST, j...@resnulli.us wrote:
>>> Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com wrote:
> Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF per
From: Simon Horman
Date: Wed, 18 Oct 2017 09:21:25 +0200
> Add fallback compatibility strings for R-Car Gen 1 and 2.
Series applied to net-next, thanks.
From: David Miller
Date: Fri, 20 Oct 2017 07:04:58 +0100 (WEST)
> Much better, applied and queued up for -stable.
I take that back.
Please build test your changes more thoroughly.
In file included from ./arch/x86/include/asm/atomic.h:7:0,
from ./include/linux/atomic.h:4,
From: Mohammed Gamal
Date: Tue, 17 Oct 2017 16:33:43 +0200
> Currently the vmxnet3 driver has a minimum MTU value of 60. Which
> goes against the RFC791 spec which specifies it at 68.
>
> Setting MTU to values between 60 <= MTU <= 67 causes the network
> interface to lose its IP, and it fails to
From: Eric Dumazet
Date: Thu, 19 Oct 2017 15:24:49 -0700
> From: Eric Dumazet
>
> syzkaller found another bug in DCCP/TCP stacks [1]
>
> For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix
> ireq->pktopts race"), we need to make sure we do not access
> ireq->opt unless we own the
On Thu, 2017-10-19 at 22:06 -0700, Andrei Vagin wrote:
> Hi,
>
> We run criu tests on net-next/master regularly, and today tests
> triggered this warning:
>
> v4.14-rc4-1168-g7a0947e
>
> [ 23.922640] ==
> [ 23.922735] WARNING: possible circ
On Thu, Oct 19, 2017 at 8:13 PM, Wei Wei wrote:
> Sry. Here it is.
>
> Unable to handle kernel paging request at virtual address 80005bfb81ed
> Mem abort info:
> Exception class = DABT (current EL), IL = 32 bits
> SET = 0, FnV = 0
> EA = 0, S1PTW = 0
> Data abort info:
> ISV = 0, ISS = 0x0
Hi,
We run criu tests on net-next/master regularly, and today tests
triggered this warning:
v4.14-rc4-1168-g7a0947e
[ 23.922640] ==
[ 23.922735] WARNING: possible circular locking dependency detected
[ 23.922823] 4.14.0-rc4+ #1 Not tainte
On Tue, 17 Oct 2017, Richard Haines wrote:
> The SCTP security hooks are explained in:
> Documentation/security/LSM-sctp.txt
>
> Signed-off-by: Richard Haines
> ---
> Documentation/security/LSM-sctp.txt | 212
>
> include/linux/lsm_hooks.h | 37 +
On Wed, Oct 18, 2017 at 12:35 PM, Paul E. McKenney
wrote:
> On Wed, Oct 18, 2017 at 10:36:28AM -0700, Cong Wang wrote:
>> Hi, all
>>
>> Recently, the RCU callbacks used in TC filters and TC actions keep
>> drawing my attention, they introduce at least 4 race condition bugs:
>>
>> 1. A simple one f
On Thu, Oct 19, 2017 at 8:34 AM, John Fastabend
wrote:
>
> My take on this would be to stay with the current RCU callbacks and try
> to simplify the implementation. Falling back to sync operations seems
> like a step backwards to me. I know update/delete of filters is currently
> a pain point for
Sry. Here it is.
Unable to handle kernel paging request at virtual address 80005bfb81ed
Mem abort info:
Exception class = DABT (current EL), IL = 32 bits
SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x0033
CM = 0, WnR = 0
swapper pgtable: 4k pages, 48-bit VAs, pgd = f
On Thu, Oct 19, 2017 at 7:21 AM, Jamal Hadi Salim wrote:
> On 17-10-18 12:43 PM, Cong Wang wrote:
>>
>> On Tue, Oct 17, 2017 at 6:03 PM, Chris Mi wrote:
-Original Message-
>
>
>>
>> You listed 3 problems, and you think they are 3 different ones, here
>> I argue problem 3 (using
On Thu, Oct 19, 2017 at 7:16 PM, Wei Wei wrote:
> Hi all,
>
> I have fuzzed v4.14-rc3 using syzkaller and found a bug similar to that one
> [1].
> But the call trace isn’t the same. The atomic_inc() might handle a corrupted
> skb_buff.
>
> The logs and config have been uploaded to my github repo
Hi Alexei,
Thanks for your review!
On Thu, Oct 19, 2017 at 03:18:30PM -0700, Alexei Starovoitov wrote:
> On Thu, Oct 19, 2017 at 03:52:49PM +0100, David Howells wrote:
> > From: Chun-Yi Lee
> >
> > There are some bpf functions can be used to read kernel memory:
> > bpf_probe_read, bpf_probe_wr
On Thursday, October 19, 2017 7:11:33 PM EDT Aleksa Sarai wrote:
> >>> The registration is a pseudo filesystem (proc, since PID tree already
> >>> exists) write of a u8[16] UUID representing the container ID to a file
> >>> representing a process that will become the first process in a new
> >>> co
Hi all,
I have fuzzed v4.14-rc3 using syzkaller and found a bug similar to that one [1].
But the call trace isn’t the same. The atomic_inc() might handle a corrupted
skb_buff.
The logs and config have been uploaded to my github repo [2].
[1] https://lkml.org/lkml/2017/10/2/216
[2] https://githu
On 10/19/2017 08:27, David Miller wrote:
> From: Joshua Kinard
> Date: Tue, 17 Oct 2017 13:54:30 -0400
>
>> From: Joshua Kinard
>>
>> The below patch attempts to clean up the code for the in-tree driver
>> for IOC3 ethernet and serial console support, primarily used by SGI
>> MIPS platforms. No
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf
> Of Vinicius Costa Gomes
> Sent: Monday, October 16, 2017 6:01 PM
> To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org
> Cc: rodney.cummi...@ni.com; Guedes, Andre ;
> j...@resnulli.us; Briano, Ivan ;
> richardc
This patchset refactors the skb receiving and transmitting function
before adding mac loopback selftest support in hns3 driver.
Yunsheng Lin (2):
net: hns3: Refactor the skb receiving and transmitting function
net: hns3: Add mac loopback selftest support in hns3 driver
.../ethernet/hisilicon
This patch refactors the skb receiving and transmitting functions
and export them in order to support the ethtool's mac loopback
selftest.
Signed-off-by: Yunsheng Lin
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 17 -
drivers/net/ethernet/hisilicon/hns3/hns3pf/hns
This patch adds mac loopback selftest support for ethtool cmd
by checking if a transmitted packet can be received correctly
when mac loopback is enabled.
Signed-off-by: Yunsheng Lin
---
.../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 54
.../ethernet/hisilicon/hns3/hns3pf/hns3_ethtool
On Wed, 18 Oct 2017, Chenbo Feng wrote:
> From: Chenbo Feng
>
> Introduce a bpf object related check when sending and receiving files
> through unix domain socket as well as binder. It checks if the receiving
> process have privilege to read/write the bpf map or use the bpf program.
> This check
On 10/19/2017 02:43 PM, Jiri Pirko wrote:
> Thu, Oct 19, 2017 at 11:39:55PM CEST, j...@resnulli.us wrote:
>> Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com wrote:
Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent
config
parameter. Defines number of MSI-X vectors al
On Wed, 18 Oct 2017, Chenbo Feng wrote:
> From: Chenbo Feng
>
> Implement the actual checks introduced to eBPF related syscalls. This
> implementation use the security field inside bpf object to store a sid that
> identify the bpf object. And when processes try to access the object,
> selinux wi
On Wed, 18 Oct 2017, Chenbo Feng wrote:
> From: Chenbo Feng
>
> Introduce several LSM hooks for the syscalls that will allow the
> userspace to access to eBPF object such as eBPF programs and eBPF maps.
> The security check is aimed to enforce a per object security protection
> for eBPF object s
On Thu, Oct 19, 2017 at 03:46:18PM -0700, Jakub Kicinski wrote:
> Quentin says:
>
> The first seven patches of this series bring several minor fixes to
> bpftool. Please see individual commit logs for details.
>
> Last patch adds a "version" commands to bpftool, which is in fact the
> version of
Commit 9cab88726929605 ("net: ethtool: Add back transceiver type")
restores the transceiver type to struct ethtool_link_settings and
convert_link_ksettings_to_legacy_settings() but forgets to remove the
error check for the same in convert_legacy_settings_to_link_ksettings().
This prevents older ver
On 10/19/2017 04:32 PM, Niklas Söderlund wrote:
> Commit 9cab88726929605 ("net: ethtool: Add back transceiver type")
> restores the transceiver type to struct ethtool_link_settings and
> convert_link_ksettings_to_legacy_settings() but forgets to remove the
> error check for the same in convert_lega
On Thu, Oct 19, 2017 at 11:48:34PM +0100, David Howells wrote:
> Alexei Starovoitov wrote:
>
> > > @@ -65,6 +65,11 @@ BPF_CALL_3(bpf_probe_read, void *, dst, u32, size,
> > > const void *, unsafe_ptr)
> > > {
> > > int ret;
> > >
> > > + if (kernel_is_locked_down("BPF")) {
> > > + m
[CC-ing Linus because I quote him.]
On Fri, 2017-10-20 at 00:28 +0200, Thomas Gleixner wrote:
> Well, that does not explain why
>
> drivers->cs + i
>
> would be corrupted. That would require that this cs -> urb link points at
> driver magically and then wreckages that driver data structure
The registration is a pseudo filesystem (proc, since PID tree already
exists) write of a u8[16] UUID representing the container ID to a file
representing a process that will become the first process in a new
container. This write might place restrictions on mount namespaces
required to define a c
The registration is a pseudo filesystem (proc, since PID tree already
exists) write of a u8[16] UUID representing the container ID to a file
representing a process that will become the first process in a new
container. This write might place restrictions on mount namespaces
required to define a c
Hi all,
We have been running 4.9 kernels for several months on CentOS 7.3 and for few
weeks on CentOS 7.4,
and, after we replaced 10GbE cobber cards(X540-AT2 with ixgbe driver) with X710
10GbE SFP cards
using i40e driver, we noticed sever instabilities on our servers.
On several servers the lin
Alexei Starovoitov wrote:
> > @@ -65,6 +65,11 @@ BPF_CALL_3(bpf_probe_read, void *, dst, u32, size, const
> > void *, unsafe_ptr)
> > {
> > int ret;
> >
> > + if (kernel_is_locked_down("BPF")) {
> > + memset(dst, 0, size);
> > + return -EPERM;
> > + }
>
> That does
Quentin says:
The first seven patches of this series bring several minor fixes to
bpftool. Please see individual commit logs for details.
Last patch adds a "version" commands to bpftool, which is in fact the
version of the kernel from which it was compiled.
Quentin Monnet (8):
tools: bpftool:
From: Quentin Monnet
Make error messages and return codes more consistent. Specifically,
replace the use of info() macro with err() when too many eBPF
instructions are received to be dumped, given that bpftool returns with
a non-null exit value in that case.
Signed-off-by: Quentin Monnet
Signed
From: Quentin Monnet
Make error messages and return codes more consistent. Specifically, make
`bpftool prog help` a real command, instead of printing usage by default
for a non-recognized "help" command. Output is the same, but this makes
bpftool return with a success value instead of an error.
From: Quentin Monnet
This command can be used to print the version of the tool, which is in
fact the version from Linux taken from usr/include/linux/version.h.
Example usage:
$ bpftool version
bpftool v4.14.0
Signed-off-by: Quentin Monnet
Signed-off-by: Jakub Kicinski
---
tools/bpf/
From: Quentin Monnet
Make print_hex() able to print to any file instead of standard output
only, and rename it to fprint_hex(). The function can now be called with
the info() macro, for example, without splitting the output between
standard and error outputs.
Signed-off-by: Quentin Monnet
Signe
From: Quentin Monnet
For the `bpftool prog dump { jited | xlated } ...` command, adding
`opcodes` keyword (to request opcodes to be printed) will have no effect
if `file FILE` (to write binary output to FILE) is provided.
The manual page and the help message to be displayed in the terminal
shoul
From: Quentin Monnet
Make error messages more consistent. Specifically, when bpftool fails at
parsing map key bytes, make it print a single error message to stderr
and return from the function, instead of (always) printing a second
error message afterwards.
Signed-off-by: Quentin Monnet
Signed-
From: Quentin Monnet
The eBPF instruction permitting to load double words (8 bytes) into a
register need 8-byte long "immediate" field, and thus occupy twice the
space of other instructions. bpftool was aware of this and would
increment the instruction counter only once on meeting such instructio
From: Quentin Monnet
Change the program to have a more consistent return code. Specifically,
do not make bpftool return an error code simply because it reaches the
end of the list of the eBPF programs to show.
Signed-off-by: Quentin Monnet
Signed-off-by: Jakub Kicinski
---
tools/bpf/bpftool/p
On Thu, 19 Oct 2017, Paul Bolle wrote:
> On Thu, 2017-10-19 at 23:31 +0200, Thomas Gleixner wrote:
> > bas_gigaset_exit()
> > {
> > for (i = 0; i < driver->minors; i++) {
> > if (gigaset_shutdown(driver->cs + i) < 0)
> >
> > gigaset_shutdown(cs)
> > {
> > mutex_lock(&c
Hi all.
First of all I'm not familiar with kernel programming at all, so please excuse
me, if I don't understand everything at the first glance.
I did as you told me, and moved the mvneta folder from 4.10.10 to 4.13.7:
rm -rf linux-4.13.7-gentoo/drivers/net/ethernet/marvell
mv linux-4.10.10-g
From: Eric Dumazet
syzkaller found another bug in DCCP/TCP stacks [1]
For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix
ireq->pktopts race"), we need to make sure we do not access
ireq->opt unless we own the request sock.
[1]
BUG: KASAN: use-after-free in ip_queue_xmit+0x1687/0x1
On Thu, Oct 19, 2017 at 10:17 AM, Nikolay Aleksandrov
wrote:
> When vlan tunnels were introduced, vlan range errors got silently
> dropped and instead 0 was returned always. Restore the previous
> behaviour and return errors to user-space.
>
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata ne
On Thu, Oct 19, 2017 at 3:07 PM, David Miller wrote:
> From: Eric Dumazet
> Date: Thu, 19 Oct 2017 07:45:09 -0700
>
>> Can you send me this v2-net-dccp-tcp-fix-ireq--opt-races.patch file ?
>>
>> Here the patch applies fine.
>
> Sure, attached.
>
> I even just tried it again, same result:
>
Thank
On Thu, Oct 19, 2017 at 03:52:49PM +0100, David Howells wrote:
> From: Chun-Yi Lee
>
> There are some bpf functions can be used to read kernel memory:
> bpf_probe_read, bpf_probe_write_user and bpf_trace_printk. These allow
> private keys in kernel memory (e.g. the hibernation image signing key)
On Thu, 2017-10-19 at 14:31 -0700, Kees Cook wrote:
> What I did in many other non-trivial conversions was just add an
> explicit pointer back, since that's operationally identical to what
> struct timer_list was storing in its .data field.
>
> i.e.
>
> add:
>
> struct cardstate *cs;
>
> to s
On Thu, Oct 19, 2017 at 09:03:52AM -0700, John Fastabend wrote:
> An integer overflow is possible in dev_map_bitmap_size() when
> calculating the BITS_TO_LONG logic which becomes, after macro
> replacement,
>
> (((n) + (d) - 1)/ (d))
>
> where 'n' is a __u32 and 'd' is (8 * sizeof(long)). T
On Thu, Oct 19, 2017 at 03:41:18PM +0200, Jiri Benc wrote:
> On Thu, 19 Oct 2017 21:12:15 +0800, Yang, Yi wrote:
> > flow_key in set_nsh is got from netlink message which is set by
> > commit_nsh in user space, here is code.
>
> Isn't this the 'key' local variable that you're talking about, while
From: Eric Dumazet
Date: Thu, 19 Oct 2017 07:45:09 -0700
> Can you send me this v2-net-dccp-tcp-fix-ireq--opt-races.patch file ?
>
> Here the patch applies fine.
Sure, attached.
I even just tried it again, same result:
[davem@kkuri net]$ git am --signoff v2-net-dccp-tcp-fix-ireq--opt-races.pa
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case I placed a "fall through" comment on
its own line, which is what GCC is expecting to find.
Signed-off-by: Gustavo A. R. Silva
---
net/smc/smc_close.c
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
This code was tested by compilation only (GCC 7.2.0 was used).
Please, verify if the actual intention of the code is to fall through.
Changes in v2:
On Thu, 2017-10-19 at 23:31 +0200, Thomas Gleixner wrote:
> bas_gigaset_exit()
> {
> for (i = 0; i < driver->minors; i++) {
> if (gigaset_shutdown(driver->cs + i) < 0)
>
> gigaset_shutdown(cs)
> {
> mutex_lock(&cs->mutex); < Explodes here
>
> So driver->cs +
Quoting David Howells :
What is the reason?
Visual separation.
Thanks for clarifying.
--
Gustavo A. R. Silva
Gustavo A. R. Silva wrote:
> > No. Firstly, it should be 'F'; secondly, don't remove the blank line - it's
> > there for a reason.
> >
>
> What is the reason?
Visual separation.
David
Thu, Oct 19, 2017 at 11:39:55PM CEST, j...@resnulli.us wrote:
>Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com wrote:
>>> Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent
>>> config
>>> parameter. Defines number of MSI-X vectors allocated per VF.
>>> Value is permanent (stored in
Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com wrote:
>> Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent
>> config
>> parameter. Defines number of MSI-X vectors allocated per VF.
>> Value is permanent (stored in NVRAM), so becomes the new default
>> value for this device.
>
>So
On Thu, 19 Oct 2017, Paul Bolle wrote:
> On Thu, 2017-10-19 at 23:03 +0200, Paul Bolle wrote:
> > On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote:
> > > In preparation for unconditionally passing the struct timer_list pointer
> > > to
> > > all timer callbacks, switch to using the new timer_se
On Thu, Oct 19, 2017 at 2:20 PM, Paul Bolle wrote:
> On Thu, 2017-10-19 at 23:03 +0200, Paul Bolle wrote:
>> On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote:
>> > In preparation for unconditionally passing the struct timer_list pointer to
>> > all timer callbacks, switch to using the new timer_
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
This code was tested by compilation only (GCC 7.2.0 was used).
Please, verify if the actual intention of the code is to fall through.
net/sched/sch
Quoting David Howells :
Gustavo A. R. Silva wrote:
+ /* fall through */
All new comments in rxrpc should begin with a capital letter; I'm
switching to
this as I modify the lines with comments on. Fix checkpatch or gcc or
whatever takes -Wimplicit-fallthrough to stop being
On Thu, 2017-10-19 at 23:03 +0200, Paul Bolle wrote:
> On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote:
> > In preparation for unconditionally passing the struct timer_list pointer to
> > all timer callbacks, switch to using the new timer_setup() and from_timer()
> > to pass the timer pointer ex
Gustavo A. R. Silva wrote:
> + /* fall through */
All new comments in rxrpc should begin with a capital letter; I'm switching to
this as I modify the lines with comments on. Fix checkpatch or gcc or
whatever takes -Wimplicit-fallthrough to stop being silly.
> - /* Fall
On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
Acked-by: Paul Bolle
For the record: this patch
On Thu, Oct 19, 2017 at 02:07:11PM +, Paolo Abeni wrote:
> The commit 2b760fcf5cfb ("ipv6: hook up exception table to store
> dst cache") partially reverted the commit 1e2ea8ad37be ("ipv6: set
> dst.obsolete when a cached route has expired").
>
> As a result, RTF_CACHE dst referenced outside t
On Thu, Oct 19, 2017 at 02:07:10PM +, Paolo Abeni wrote:
> After the commit 2b760fcf5cfb ("ipv6: hook up exception table
> to store dst cache"), the fib6 gc is not started after the
> creation of a RTF_CACHE via a redirect or pmtu update, since
> fib6_add() isn't invoked anymore for such dsts.
From: Ben Greear
This makes it easier to properly handle errors when calling this
from scripts, etc.
Old behaviour:
$ ethtool -L eth3 combined 1
combined unmodified, ignoring
no channel parameters changed, aborting
current values: tx 0 rx 0 other 1 combined 1
[root@lf0313-6477 ethtool]# echo $?
From: Ben Greear
This makes it easier to properly handle errors when calling this
from scripts, etc.
Old behaviour:
combined unmodified, ignoring
no channel parameters changed, aborting
current values: tx 0 rx 0 other 1 combined 1
[root@lf0313-6477 ethtool]# echo $?
1
New behaviour:
combined
On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote:
> This replaces a kmalloc followed by a bunch of per-field zeroing with a
> single kzalloc call, reducing the lines of code.
Acked-by: Paul Bolle
Thanks,
Paul Bolle
On Wed, Oct 18, 2017 at 03:18:55PM -0700, Jesus Sanchez-Palencia wrote:
> This is great. Just out of curiosity, were you using vlans on your tests?
No, just raw packets. VLAN tags could be added trivially (in the
program), but that naturally avoids the kernel's VLAN code.
> I might try to reprod
On Thu, Oct 19, 2017 at 3:35 PM, Jiri Pirko wrote:
> Thu, Oct 19, 2017 at 09:17:10PM CEST, steven.l...@broadcom.com wrote:
>>Implements get and set of configuration parameters using new devlink
>>config get/set API.
>
> Please split this patch too. One to introduce the infra, one per each
> config
On Thu, Oct 19, 2017 at 3:33 PM, Jiri Pirko wrote:
> Thu, Oct 19, 2017 at 09:17:06PM CEST, steven.l...@broadcom.com wrote:
>>Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config
>>parameter. If value is 1, SR-IOV is enabled. If value is 0,
>>SR-IOV is disabled on this device. Value is perm
On Wed, Oct 18, 2017 at 03:37:35PM -0700, Jesus Sanchez-Palencia wrote:
> I also did some tests with when you don't set valid launch times, but here
> using
> your idea from above, so with the driver calculating a valid launch time (i.e.
> current NIC time + X ns, varying X across tests) for packe
> Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent
> config
> parameter. Defines number of MSI-X vectors allocated per VF.
> Value is permanent (stored in NVRAM), so becomes the new default
> value for this device.
Sounds like you're having this enforce the same configuration for all chil
Under LOCKDEP, the timer lock_class_key (set up in __setup_timer) needs
to be tied to the caller's context, so an inline for timer_setup()
won't work. We do, however, want to keep the inline version around for
argument type checking, though, so this provides macro wrappers in the
LOCKDEP case.
Thi
> Subject: [PATCH net-next v2 1/6] devlink: Add permanent config parameter
> get/set operations
>
> Add support for permanent config parameter get/set commands. Used
> for parameters held in NVRAM, persistent device configuration.
Given some of the attributes aren't Boolean, what about an API tha
On Thu, Oct 19, 2017 at 7:07 AM, Paolo Abeni wrote:
> The commit 2b760fcf5cfb ("ipv6: hook up exception table to store
> dst cache") partially reverted the commit 1e2ea8ad37be ("ipv6: set
> dst.obsolete when a cached route has expired").
>
> As a result, RTF_CACHE dst referenced outside the fib tr
On 10/19/2017 12:51 PM, Tom Herbert wrote:
> On Thu, Oct 19, 2017 at 10:42 AM, Eric Dumazet
> wrote:
>
>> On Fri, 2017-07-28 at 16:22 -0700, Tom Herbert wrote:
>>> Generalize strparser from more than just being used in conjunction
>>> with read_sock. strparser will also be used in the send path w
On 10/19/2017 09:54 PM, Mario Hüttel wrote:
On 10/19/2017 08:35 PM, Oliver Hartkopp wrote:
We already have this 'dsample-point' implemented in the ip tool:
$ ip link set vcan0 type can help
Usage: ip link set DEVICE type can
[ bitrate BITRATE [ sample-point SAMPLE-POINT] ] |
[ tq TQ
On Thu, Oct 19, 2017 at 7:07 AM, Paolo Abeni wrote:
> After the commit 2b760fcf5cfb ("ipv6: hook up exception table
> to store dst cache"), the fib6 gc is not started after the
> creation of a RTF_CACHE via a redirect or pmtu update, since
> fib6_add() isn't invoked anymore for such dsts.
>
> We n
On 2017-10-12 15:45, Steve Grubb wrote:
> On Thursday, October 12, 2017 10:14:00 AM EDT Richard Guy Briggs wrote:
> > Containers are a userspace concept. The kernel knows nothing of them.
> >
> > The Linux audit system needs a way to be able to track the container
> > provenance of events and act
On Thu, Oct 19, 2017 at 12:07 PM, Jean-Philippe Brucker
wrote:
> When the driver cannot map a TX buffer, instead of rolling back
> gracefully and retrying later, we currently get a panic:
>
> [ 159.885994] igb :00:00.0: TX DMA map failed
> [ 159.886588] Unable to handle kernel paging request
On 10/19/2017 08:35 PM, Oliver Hartkopp wrote:
> Hi Marc,
>
> On 10/19/2017 01:26 PM, Marc Kleine-Budde wrote:
>> On 10/19/2017 01:14 PM, Oliver Hartkopp wrote:
>>> Since we have a netlink socket interface to configure sample
>>> point, I
>>> wonder if that should be extended to config
Thu, Oct 19, 2017 at 09:17:10PM CEST, steven.l...@broadcom.com wrote:
>Implements get and set of configuration parameters using new devlink
>config get/set API.
Please split this patch too. One to introduce the infra, one per each
config option.
Thu, Oct 19, 2017 at 09:17:06PM CEST, steven.l...@broadcom.com wrote:
>Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config
>parameter. If value is 1, SR-IOV is enabled. If value is 0,
>SR-IOV is disabled on this device. Value is permanent (stored
>in NVRAM), so becomes the new default valu
On Thu, Oct 19, 2017 at 07:25:17PM +0200, Krzysztof Halasa wrote:
> David Miller writes:
>
> > We don't even know if whatever "as68k" is would be the same thing
> > as GNU as and generate the same binaries.
>
> It's GNU as, likewise ld68k, though I have no idea if recent versions
> would compile
Add support for permanent config parameter get/set commands. Used
for parameters held in NVRAM, persistent device configuration.
Signed-off-by: Steve Lin
Acked-by: Andy Gospodarek
---
include/net/devlink.h| 3 +
include/uapi/linux/devlink.h | 11 ++
net/core/devlink.c | 234
Adding DEVLINK_PERM_CONFIG_MAX_NUM_PF_MSIX_VECT permanent config
parameter. Sets the maximum number of PF MSI-X (Message
Signaled Interrupts) vectors. Value is permanent (stored in
NVRAM), so becomes the new default value for this device.
Signed-off-by: Steve Lin
Acked-by: Andy Gospodarek
---
Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config
parameter. If value is 1, SR-IOV is enabled. If value is 0,
SR-IOV is disabled on this device. Value is permanent (stored
in NVRAM), so becomes the new default value for this device.
Signed-off-by: Steve Lin
Acked-by: Andy Gospodarek
-
Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent config
parameter. Defines number of MSI-X vectors allocated per VF.
Value is permanent (stored in NVRAM), so becomes the new default
value for this device.
Signed-off-by: Steve Lin
Acked-by: Andy Gospodarek
---
include/uapi/linux/devlink
Changes since v1, based on the excellent feedback received:
* Implemented nested parameters correctly this time, I think.
* Submitting config get/set infrastructure separately from the
parameters themselves, and then submitting just the first four
parameters as separate patches. Once this app
Adding DEVLINK_PERM_CONFIG_NUM_VF_PER_PF permanent config
parameter, which sets the number of VFs per PF in SR-IOV
mode. Value is permanent (stored in NVRAM), so becomes the
new default value for this device.
Signed-off-by: Steve Lin
Acked-by: Andy Gospodarek
---
include/uapi/linux/devlink.h |
Implements get and set of configuration parameters using new devlink
config get/set API.
Signed-off-by: Steve Lin
Acked-by: Andy Gospodarek
---
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 245 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 17 ++
drivers/net
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
This code was tested by compilation only (GCC 7.2.0 was used).
Please, verify if the actual intention of the code is to fall through.
net/rxrpc/af_
When the driver cannot map a TX buffer, instead of rolling back
gracefully and retrying later, we currently get a panic:
[ 159.885994] igb :00:00.0: TX DMA map failed
[ 159.886588] Unable to handle kernel paging request at virtual address
0a08c7a8
...
[ 159.897031] P
From: Craig Gallek
Syzkaller stumbled upon a way to trigger
WARNING: CPU: 1 PID: 13881 at net/core/sock_reuseport.c:41
reuseport_alloc+0x306/0x3b0 net/core/sock_reuseport.c:39
There are two initialization paths for the sock_reuseport structure in a
socket: Through the udp/tcp bind paths of SO_RE
1 - 100 of 280 matches
Mail list logo
