On 2017/6/8 7:24, Alexander Duyck wrote:
> On Wed, Jun 7, 2017 at 2:16 AM, Ding Tianhong wrote:
>> From: Casey Leedom
>>
>> cxgb4 Ethernet driver now queries Root Complex Port to determine if it can
>> send TLPs to it with the Relaxed Ordering Attribute set.
>>
>> Signed-off-by: Casey Leedom
>
On Mon, Jun 12, 2017 at 02:37:22PM +0800, Dison River wrote:
> Hi:
> I've got the following error report while fuzzing the kernel with
> syzkaller on linux-4.11.0-rc3.
>
> log:
> WARNING: CPU: 2 PID: 0 at net/sched/sch_generic.c:316
> dev_watchdog+0x648/0x770 net/sched/sch_generic.c:315
> NETD
Hi:
I've got the following error report while fuzzing the kernel with
syzkaller on linux-4.11.0-rc3.
log:
WARNING: CPU: 2 PID: 0 at net/sched/sch_generic.c:316
dev_watchdog+0x648/0x770 net/sched/sch_generic.c:315
NETDEV WATCHDOG: eth0 (e1000): transmit queue 0 timed out
Kernel panic - not sync
On Mon, Jun 12, 2017 at 12:30 AM, Emil Lenngren wrote:
> 2017-06-11 22:48 GMT+02:00 Emmanuel Grumbach :
>> On Sun, Jun 11, 2017 at 4:36 PM, Kees Cook wrote:
>>>
>>> On Sun, Jun 11, 2017 at 1:13 AM, Kalle Valo wrote:
>>> > "Jason A. Donenfeld" writes:
>>> >
>>> >> Whenever you're comparing two M
Fix redefinition of struct ethhdr with a suitably patched musl libc
that suppresses the kernel if_ether.h.
Signed-off-by: Changhyeok Bae
---
ip/iplink_bridge.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
index cccdec1..f065b22 100644
--- a/ip/iplink
On 6/11/17 4:15 PM, David Miller wrote:
>
> Applied and queued up for -stable, thank you.
>
The backport will need bcfc7d33110b; that commit should have had the
same Fixes tag -- e58e41596811 ("net: Enable support for VRF with ipv4
multicast")
On Tue, Jun 6, 2017 at 12:47 PM, Shubham Bansal
wrote:
> Hi Russell, Alexei, David, Daniel, kees,
>
> Any update on this patch moving forward?
Since this has gotten testing by various people and passes the
existing self-tests, I think this can probably go in via the ARM patch
tracker? Russell doe
-for-key-lookup/20170611-184237
config: x86_64-randconfig-s2-06120830 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
net//ipv4/tcp_ipv4
I would argue that this is just an unintended side effect of the
original implementation. Shuffling interface vif's seems like a good
way to churn a significant number of mroutes to me. If you want to
use a interface it probably is going to be already be configured with
it's own vif, and as such
From: Roopa Prabhu
This patch fixes vxlan_snoop to not move permanent fdb entries
on learn events. This is consistent with the bridge fdb
handling of permanent entries.
Fixes: 26a41ae60438 ("vxlan: only migrate dynamic FDB entries")
Signed-off-by: Roopa Prabhu
---
v2 - added Fixes tag
drivers
On Sun, Jun 11, 2017 at 4:04 PM, David Miller wrote:
> From: Roopa Prabhu
> Date: Sun, 11 Jun 2017 15:51:22 -0700
>
>> From: Roopa Prabhu
>>
>> This patch fixes vxlan_snoop to not move permanent fdb entries
>> on learn events. This is consistent with the bridge fdb
>> handling of permanent entri
From: Roopa Prabhu
Date: Sun, 11 Jun 2017 15:51:22 -0700
> From: Roopa Prabhu
>
> This patch fixes vxlan_snoop to not move permanent fdb entries
> on learn events. This is consistent with the bridge fdb
> handling of permanent entries.
>
> Signed-off-by: Roopa Prabhu
Is there an appropriate
From: Roopa Prabhu
This patch fixes vxlan_snoop to not move permanent fdb entries
on learn events. This is consistent with the bridge fdb
handling of permanent entries.
Signed-off-by: Roopa Prabhu
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
From: Daniel Borkmann
Date: Sun, 11 Jun 2017 03:55:27 +0200
> Make use of recently implemented stack_depth tracking for arm64 JIT,
> so that stack usage can be reduced heavily for programs not using
> tail calls at least.
>
> Signed-off-by: Daniel Borkmann
> Acked-by: Alexei Starovoitov
Appli
From: Donald Sharp
Date: Sat, 10 Jun 2017 16:30:17 -0400
> This patch fixes two issues:
>
> 1) When forwarding on *,G mroutes that are in a vrf, the
> kernel was dropping information about the actual incoming
> interface when calling ip_mr_forward from ip_mr_input.
> This caused ip_mr_forward to
From: Saeed Mahameed
Date: Sun, 11 Jun 2017 17:55:44 +0300
> This series provides updates to mlx5 header rewrite feature, from Or Gerlitz.
> and three more small updates From Maor and Eran.
>
> For more details please see below.
Pulled, thanks.
> Please pull and let me know if there's any prob
2017-06-11 22:48 GMT+02:00 Emmanuel Grumbach :
> On Sun, Jun 11, 2017 at 4:36 PM, Kees Cook wrote:
>>
>> On Sun, Jun 11, 2017 at 1:13 AM, Kalle Valo wrote:
>> > "Jason A. Donenfeld" writes:
>> >
>> >> Whenever you're comparing two MACs, it's important to do this using
>> >> crypto_memneq instead
Hi Stephan,
On Sun, Jun 11, 2017 at 11:06 PM, Stephan Müller wrote:
> Are you planning to send an update to your patch set? If yes, there is another
> one which should be converted too: crypto/rsa-pkcs1pad.c.
I just sent an update to this thread patching that, per your
suggestion. Since these is
Am Samstag, 10. Juni 2017, 04:59:06 CEST schrieb Jason A. Donenfeld:
Hi Jason,
> Whenever you're comparing two MACs, it's important to do this using
> crypto_memneq instead of memcmp. With memcmp, you leak timing information,
> which could then be used to iteratively forge a MAC. This is far too
On Sun, Jun 11, 2017 at 4:36 PM, Kees Cook wrote:
>
> On Sun, Jun 11, 2017 at 1:13 AM, Kalle Valo wrote:
> > "Jason A. Donenfeld" writes:
> >
> >> Whenever you're comparing two MACs, it's important to do this using
> >> crypto_memneq instead of memcmp. With memcmp, you leak timing information,
>
From: Saeed Mahameed
Date: Sun, 11 Jun 2017 17:00:22 +0300
> This series contains some fixes for the mlx5 core and netdev driver.
>
> Please pull and let me know if there's any problem.
Pulled, thanks.
> For -stable:
> ("net/mlx5e: Added BW check for DIM decision mechanism") kerne
From:
Date: Sun, 11 Jun 2017 15:42:42 +0300
> This patchset contains fixes for the bugs that were discovered so far.
Series applied.
On 17-06-11 01:38 PM, Jamal Hadi Salim wrote:
On 17-06-11 09:49 AM, Jiri Pirko wrote:
Sun, Jun 11, 2017 at 01:53:43PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim
This patch also provides an extra feature: a validation callback
that could be speaciliazed for other types.
s/speac
On 17-06-11 10:13 AM, Jiri Pirko wrote:
Sun, Jun 11, 2017 at 01:53:45PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations allow
is inefficient.
With this chang
On 17-06-11 09:49 AM, Jiri Pirko wrote:
Sun, Jun 11, 2017 at 01:53:43PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim
This patch also provides an extra feature: a validation callback
that could be speaciliazed for other types.
s/speaciliazed/speciliazed/
Will fix.
[ATTR_GOO
I need your partnership in a transaction that will benefit you,
details will disclose to you once i receive your reply.
Kind regards
Saif.
Hi Andrew,
On Sun, Jun 11, 2017 at 5:21 PM, Andrew Lunn wrote:
>> Thank your for the suggestion, and thanks Martin to explaining me over
>> IRC what actually I should do.
>>
>> I recompiled mainline kernel 4.12-rc4 with the Amlogic driver:
>> replaced drivers/net/phy/meson-gxl.c with
>> https://g
On 11/06/17 11:55, Yotam Gigi wrote:
> I have been looking into some weird behavior, and I am not sure whether it is
> a bug or a feature.
>
> When a VIF with index v gets deleted, the MFC routes does not get updated,
> which
> means that there can be routes pointing to that VIF. On datapath, whe
> Thank your for the suggestion, and thanks Martin to explaining me over
> IRC what actually I should do.
>
> I recompiled mainline kernel 4.12-rc4 with the Amlogic driver:
> replaced drivers/net/phy/meson-gxl.c with
> https://github.com/khadas/linux/blob/ubuntu-4.9/drivers/amlogic/ethernet/phy/am
From: Or Gerlitz
Use the modify header ID cache for the header re-write part of offloading
TC eswitch flows.
Signed-off-by: Or Gerlitz
Reviewed-by: Paul Blakey
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 11 +++
1 file changed, 3 insertions(+),
From: Or Gerlitz
Instead of going through flow->nic/esw_attr for each usage, assign
an attr pointer per the context (nic or esw) and use that.
This patch doesn't add any functionality.
Signed-off-by: Or Gerlitz
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/me
From: Eran Ben Elisha
Translate hardware port connector type data into link mode supported and
advertised info instead of caching it in driver.
Signed-off-by: Eran Ben Elisha
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 90 ++
1 fi
From: Eran Ben Elisha
Read port connector type from the firmware instead of caching it in the
driver metadata.
Signed-off-by: Eran Ben Elisha
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 22 --
include/linux/mlx5/mlx5_ifc.h
From: Or Gerlitz
Using a per field mask field, the TC pedit action supports modifying
partial fields. E.g if using the TC tool, the following example would
make the kernel to only re-write two bytes of the src ip address:
tc filter add dev enp1s0 protocol ip parent : prio 30
flower s
From: Or Gerlitz
Remove the limitation that offloaded NIC filters can have only one
action. This allows us for example to provide flow tag as a note
to upper layers / apps that that HW header re-write was applied.
Signed-off-by: Or Gerlitz
Reviewed-by: Paul Blakey
Signed-off-by: Saeed Mahameed
From: Or Gerlitz
Use the modify header ID cache for the header re-write part of offloading
TC NIC flows.
Signed-off-by: Or Gerlitz
Reviewed-by: Paul Blakey
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 11 +++
1 file changed, 3 insertions(+), 8 d
From: Or Gerlitz
Packets belonging to flows which are different by matching may still need
to go through the same header re-write. Add a cache for header re-write IDs
keyed by the binary chain of modify header actions.
The caching is supported for both eswitch and NIC use-cases, where the
actual
From: Maor Gottlieb
Update struct mlx5_ifc_create(modify)_flow_table_bits according to
the last device specification.
Signed-off-by: Maor Gottlieb
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c | 32 ++---
include/linux/mlx5/mlx5_ifc.h
Hi Dave,
This series provides updates to mlx5 header rewrite feature, from Or Gerlitz.
and three more small updates From Maor and Eran.
For more details please see below.
Please pull and let me know if there's any problem.
*This series doesn't introduce any conflict with the ongoing net
pull req
Sun, Jun 11, 2017 at 01:53:45PM CEST, j...@mojatatu.com wrote:
>From: Jamal Hadi Salim
>
>When you dump hundreds of thousands of actions, getting only 32 per
>dump batch even when the socket buffer and memory allocations allow
>is inefficient.
>
>With this change, the user will get as many as poss
From: Mohamad Haj Yahia
The issue is that when we get an assert we will stop polling the health
and thus we cant enter error state when we have a real health issue.
Fixes: fd76ee4da55a ('net/mlx5_core: Fix internal error detection conditions')
Signed-off-by: Mohamad Haj Yahia
Reviewed-by: Danie
From: Mohamad Haj Yahia
Send vport number to the create flow table inner method instead of
ignoring the vport argument and sending always 0.
Fixes: b3ba51498bdd ('net/mlx5: Refactor create flow table method to accept
underlay QP')
Signed-off-by: Mohamad Haj Yahia
Signed-off-by: Saeed Mahameed
Hi Dave,
This series contains some fixes for the mlx5 core and netdev driver.
Please pull and let me know if there's any problem.
For -stable:
("net/mlx5e: Added BW check for DIM decision mechanism") kernels
>= 4.9
("net/mlx5e: Fix wrong indications in DIM due to counter wraparound
From: Tal Gilboa
DIM (Dynamically-tuned Interrupt Moderation) is a mechanism designed for
changing the channel interrupt moderation values in order to reduce CPU
overhead for all traffic types.
Until now only interrupt and packet rate were sampled.
We found a scenario on which we get a false indi
From: Huy Nguyen
Remove the following module event counters out of ethtool stats. The
reason for removing these event counters is that these events do not
occur without techinician's intervention.
module_pwr_budget_exd
module_long_range
module_no_eeprom
module_enforce_part
module_unknow
From: Majd Dibbiny
When the page size isn't bigger than 4K, there is no added value of enabling 4K
UAR feature in the Firmware.
Modified the condition of enabling the 4K UAR accordingly.
Fixes: f502d834950a ("net/mlx5: Activate support for 4K UARs")
Signed-off-by: Majd Dibbiny
Signed-off-by: S
From: Tal Gilboa
DIM (Dynamically-tuned Interrupt Moderation) is a mechanism designed for
changing the channel interrupt moderation values in order to reduce CPU
overhead for all traffic types.
Each iteration of the algorithm, DIM calculates the difference in
throughput, packet rate and interrupt
Sun, Jun 11, 2017 at 01:53:44PM CEST, j...@mojatatu.com wrote:
>From: Jamal Hadi Salim
>
>Bug fix for an issue which has been around for about a decade.
>We got away with it because the enumeration was larger than needed.
>
>Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new
On Sat, Jun 10, 2017 at 10:27 PM, Arend van Spriel
wrote:
> On 03-06-17 17:36, Andy Shevchenko wrote:
>> On Sat, Jun 3, 2017 at 1:29 AM, Peter S. Housel wrote:
The following looks good to me.
Feel free to add
Reviewed-by: Andy Shevchenko
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac
Sun, Jun 11, 2017 at 01:53:43PM CEST, j...@mojatatu.com wrote:
>From: Jamal Hadi Salim
>
>Generic bitflags attribute content sent to the kernel by user.
>With this type the user can either set or unset a flag in the
>kernel.
>
>The nla_flag_values is a bitmap that defines the values being set
>The
Hi Andrew
On Sat, Jun 10, 2017 at 5:27 PM, Andrew Lunn wrote:
>> Also what Martin Blumenstingl wrote is following which is also crucial
>> for fixing the issue:
>> Amlogic has given their ethernet PHY driver some updates [2], it now
>> includes wake-on-lan, and they now have an internal_phy_read_
Hi Salil,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Salil-Mehta/Hisilicon-Network-Subsystem-3-Ethernet-Driver/20170611-204908
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gnu-gcc (Debian 6.3.0-18) 6.3.0 20170516
Hi Salil,
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Salil-Mehta/Hisilicon-Network-Subsystem-3-Ethernet-Driver/20170611-204908
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gnu-gcc (Debian 6.3.0-18) 6.3.0 20170516
On Sun, Jun 11, 2017 at 1:13 AM, Kalle Valo wrote:
> "Jason A. Donenfeld" writes:
>
>> Whenever you're comparing two MACs, it's important to do this using
>> crypto_memneq instead of memcmp. With memcmp, you leak timing information,
>> which could then be used to iteratively forge a MAC.
>
> Do y
From: Netanel Belgazal
Signed-off-by: Netanel Belgazal
---
drivers/net/ethernet/amazon/ena/ena_netdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h
b/drivers/net/ethernet/amazon/ena/ena_netdev.h
index 88b5e5612338..a4d3d5e210
From: Netanel Belgazal
Fixes: 1738cd3ed342 ("Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Netanel Belgazal
---
drivers/net/ethernet/amazon/ena/ena_com.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c
b/drivers/ne
From: Netanel Belgazal
This patch also change the mapping functions to devm_ functions
Fixes: 1738cd3ed342 ("Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Netanel Belgazal
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 15 +++
1 file changed, 11 insert
From: Netanel Belgazal
For the rare case where the device runs out of free rx buffer
descriptors (in case of pressure on kernel memory),
and the napi handler continuously fail to refill new Rx descriptors
until device rx queue totally runs out of all free rx buffers
to post incoming packet, lead
From: Netanel Belgazal
check_for_missing_tx_completions() is called from a timer
task and looking for lost tx packets.
The old implementation accumulate all the lost tx packets
and did not check if those packets were retrieved on a later stage.
This cause to a situation where the driver reset
the
From: Netanel Belgazal
Fixing a bug that the driver does not unmask the IO interrupts
in ndo_open():
occasionally, the MSI-X interrupt (for one or more IO queues)
can be masked when ndo_close() was called.
If that is followed by ndo open(),
then the MSI-X will be still masked so no interrupt
will
From: Netanel Belgazal
Fixes: 1738cd3ed342 ("Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Netanel Belgazal
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
b/drivers/ne
From: Netanel Belgazal
This patchset contains fixes for the bugs that were discovered so far.
Netanel Belgazal (9):
net: ena: fix rare uncompleted admin command false alarm
net: ena: fix bug that might cause hang after consecutive open/close
interface.
net: ena: add missing return when
From: Netanel Belgazal
Bug:
"Completion context is occupied" error printout will be noticed in
dmesg.
This error will cause the admin command to fail, which will lead to
an ena_probe() failure or a watchdog reset (depends on which admin
command failed).
Root cause:
__ena_com_submit_admin_cmd() i
From: Netanel Belgazal
The current flow to detect admin completion is:
while (command_not_completed) {
if (timeout)
error
check_for_completion()
sleep()
}
So in case the sleep took more than the timeout
(in case the thread/workqueue was not sche
Ack.
resubmitting to net branch and adding "Fixes" mark.
From: David Miller
Sent: Saturday, June 10, 2017 11:11 PM
To: f.faine...@gmail.com
Cc: Belgazal, Netanel; netdev@vger.kernel.org; Woodhouse, David; Machulsky,
Zorik; Matushevsky, Alexander; BSHARA, S
Attached iproute2 used for testing these features..
cheers,
jamal
diff --git a/Makefile b/Makefile
index 18de7dc..ed3c10a 100644
--- a/Makefile
+++ b/Makefile
@@ -45,7 +45,7 @@ HOSTCC ?= $(CC)
DEFINES += -D_GNU_SOURCE
# Turn on transparent support for LFS
DEFINES += -D_FILE_OFFSET_BITS=64 -D_
On 17-06-10 07:02 PM, David Miller wrote:
@@ -173,7 +173,8 @@ int ip_build_and_send_pkt(struct sk_buff *skb, const struct
sock *sk,
}
skb->priority = sk->sk_priority;
- skb->mark = sk->sk_mark;
+ if (!skb->mark)
+ skb->mark = sk->sk_mark;
Maybe this sh
From: Jamal Hadi Salim
Bug fix for an issue which has been around for about a decade.
We got away with it because the enumeration was larger than needed.
Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new
netlink API")
Suggested-by: Jiri Pirko
Reviewed-by: Simon Horman
S
From: Jamal Hadi Salim
This adds support for filtering based on time since last used.
When we are dumping a large number of actions it is useful to
have the option of filtering based on when the action was last
used to reduce the amount of data crossing to user space.
With this patch the user sp
From: Jamal Hadi Salim
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations allow
is inefficient.
With this change, the user will get as many as possibly fitting
within the given constraints available to the kernel.
Th
From: Jamal Hadi Salim
Generic bitflags attribute content sent to the kernel by user.
With this type the user can either set or unset a flag in the
kernel.
The nla_flag_values is a bitmap that defines the values being set
The nla_flag_selector is a bitmask that defines which value is legit.
A c
From: Jamal Hadi Salim
Changes since v9:
-
1) General consensus:
- remove again the use of BIT() to maintain uapi consistency ;->
1) Jiri:
- Add a new netlink type NLA_FLAG_BITS to check for valid bits
and use it instead of inline vetting.
Changes since v8:
---
On Sun, Jun 11, 2017 at 9:44 AM, Hangbin Liu wrote:
> Now we will force to do garbage collection if any policy removed in
> xfrm_policy_flush(). But during xfrm_net_exit(). We call flow_cache_fini()
> first and set set fc->percpu to NULL. Then after we call xfrm_policy_fini()
> -> frxm_policy_flus
I have been looking into some weird behavior, and I am not sure whether it is
a bug or a feature.
When a VIF with index v gets deleted, the MFC routes does not get updated, which
means that there can be routes pointing to that VIF. On datapath, when packet
hits that route, the VIF validity will be
"Jason A. Donenfeld" writes:
> Whenever you're comparing two MACs, it's important to do this using
> crypto_memneq instead of memcmp. With memcmp, you leak timing information,
> which could then be used to iteratively forge a MAC.
Do you have any pointers where I could learn more about this?
--
On 11-06-17 02:18, Peter Housel wrote:
>
>> On Jun 10, 2017, at 12:27 PM, Arend van Spriel
>> wrote:
>>
>> On 03-06-17 17:36, Andy Shevchenko wrote:
>>> On Sat, Jun 3, 2017 at 1:29 AM, Peter S. Housel wrote:
An earlier change to this function (3bdae810721b) fixed a leak in the
case of
78 matches
Mail list logo
