Re: ARM GLX Khadas VIM Pro - Ethernet detected as only 10Mbps and stalled after some traffic

2017-06-10 Thread crow
Hi Andrew, On Sat, Jun 10, 2017 at 5:27 PM, Andrew Lunn wrote: >> Also what Martin Blumenstingl wrote is following which is also crucial >> for fixing the issue: >> Amlogic has given their ethernet PHY driver some updates [2], it now >> includes wake-on-lan, and they now have an internal_phy_read

Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in vrf's

2017-06-10 Thread Yotam Gigi
On 06/10/2017 11:30 PM, Donald Sharp wrote: > This patch fixes two issues: > > 1) When forwarding on *,G mroutes that are in a vrf, the > kernel was dropping information about the actual incoming > interface when calling ip_mr_forward from ip_mr_input. > This caused ip_mr_forward to send the multic

RE: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-06-10 Thread Ilan Tayari
> -Original Message- > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Subject: Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova > > > > This keep getting more ugly :( > > > > > > What about security? What if user space sends some raw packets to the > > >

Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-06-10 Thread Andrew Lunn
> > +int hclge_mac_mdio_config(struct hclge_dev *hdev) > > +{ > > + struct hclge_mac *mac = &hdev->hw.mac; > > + struct mii_bus *mdio_bus; > > + struct net_device *ndev = &mac->ndev; > > + struct phy_device *phy; > > + bool is_c45; > > + int ret; > > + > > + if (hdev->hw.mac.phy_addr

Re: [PATCH 08/44] xen-swiotlb: implement ->mapping_error

2017-06-10 Thread Konrad Rzeszutek Wilk
On Thu, Jun 08, 2017 at 03:25:33PM +0200, Christoph Hellwig wrote: > DMA_ERROR_CODE is going to go away, so don't rely on it. Reviewed-by: Konrad Rzeszutek Wilk

Re: [PATCH 07/44] xen-swiotlb: consolidate xen_swiotlb_dma_ops

2017-06-10 Thread Konrad Rzeszutek Wilk
On Thu, Jun 08, 2017 at 03:25:32PM +0200, Christoph Hellwig wrote: > ARM and x86 had duplicated versions of the dma_ops structure, the > only difference is that x86 hasn't wired up the set_dma_mask, > mmap, and get_sgtable ops yet. On x86 all of them are identical > to the generic version, so they

[PATCH net-next] bpf, arm64: take advantage of stack_depth tracking

2017-06-10 Thread Daniel Borkmann
Make use of recently implemented stack_depth tracking for arm64 JIT, so that stack usage can be reduced heavily for programs not using tail calls at least. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- arch/arm64/net/bpf_jit_comp.c | 22 +++--- 1 file changed,

[PATCHv3 net] xfrm: move xfrm_garbage_collect out of xfrm_policy_flush

2017-06-10 Thread Hangbin Liu
Now we will force to do garbage collection if any policy removed in xfrm_policy_flush(). But during xfrm_net_exit(). We call flow_cache_fini() first and set set fc->percpu to NULL. Then after we call xfrm_policy_fini() -> frxm_policy_flush() -> flow_cache_flush(), we will get NULL pointer dereferen

Re: [PATCHv2 net] net/flow: fix fc->percpu NULL pointer dereference

2017-06-10 Thread Hangbin Liu
On Sat, Jun 10, 2017 at 04:29:23PM +0800, Xin Long wrote: > It's a xfrm fix, pls also fix the title, like: >xfrm: move xfrm_garbage_collect out of xfrm_policy_flush > or >xfrm: fix ... Opps, sorry forgot that.

Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in vrf's

2017-06-10 Thread Nikolay Aleksandrov
On 10/06/17 23:30, Donald Sharp wrote: > This patch fixes two issues: > > 1) When forwarding on *,G mroutes that are in a vrf, the > kernel was dropping information about the actual incoming > interface when calling ip_mr_forward from ip_mr_input. > This caused ip_mr_forward to send the multicast

Re: [Intel-wired-lan] [PATCH] i40evf: remove redundant null check on key

2017-06-10 Thread Alexander Duyck
On Sat, Jun 10, 2017 at 4:33 AM, Dan Carpenter wrote: > > This patch isn't right... > > On Wed, Jun 07, 2017 at 12:54:07AM +0100, Colin King wrote: >> From: Colin Ian King >> >> key has previously been null checked so the subsequent null check >> is redundant as key can never be null at that poin

Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in vrf's

2017-06-10 Thread Thomas Winter
I don't think we've seen this issue but patch looks good. From: David Ahern Sent: 11 June 2017 11:33 To: David Miller; sha...@cumulusnetworks.com Cc: netdev@vger.kernel.org; Thomas Winter; niko...@cumulusnetworks.com; yot...@mellanox.com; ido...@mellanox.c

Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in vrf's

2017-06-10 Thread David Ahern
On 6/10/17 5:07 PM, David Miller wrote: > From: Donald Sharp > Date: Sat, 10 Jun 2017 16:30:17 -0400 > >> This patch fixes two issues: >> >> 1) When forwarding on *,G mroutes that are in a vrf, the >> kernel was dropping information about the actual incoming >> interface when calling ip_mr_forwar

Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in vrf's

2017-06-10 Thread David Ahern
On 6/10/17 2:30 PM, Donald Sharp wrote: > This patch fixes two issues: > > 1) When forwarding on *,G mroutes that are in a vrf, the > kernel was dropping information about the actual incoming > interface when calling ip_mr_forward from ip_mr_input. > This caused ip_mr_forward to send the multicast

Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in vrf's

2017-06-10 Thread David Miller
From: Donald Sharp Date: Sat, 10 Jun 2017 16:30:17 -0400 > This patch fixes two issues: > > 1) When forwarding on *,G mroutes that are in a vrf, the > kernel was dropping information about the actual incoming > interface when calling ip_mr_forward from ip_mr_input. > This caused ip_mr_forward to

Re: [PATCH net-next 0/8] Misc BPF updates

2017-06-10 Thread David Miller
From: Daniel Borkmann Date: Sun, 11 Jun 2017 00:50:39 +0200 > This set contains a couple of misc updates: stack usage reduction > for perf_sample_data in tracing progs, reduction of stale data in > verifier on register state transitions that I still had in my queue > and few selftest improvements

Re: [PATCH net-next 1/1] net: reflect mark on tcp syn ack packets

2017-06-10 Thread David Miller
From: Jamal Hadi Salim Date: Sat, 10 Jun 2017 09:31:01 -0400 > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c > index 7a3fd25..a8fd5f0 100644 > --- a/net/ipv4/ip_output.c > +++ b/net/ipv4/ip_output.c > @@ -173,7 +173,8 @@ int ip_build_and_send_pkt(struct sk_buff *skb, const > struct so

Re: [PATCH v2 2/2] tcp: md5: extend the tcp_md5sig struct to specify a key address prefix

2017-06-10 Thread David Miller
From: Ivan Delalande Date: Fri, 9 Jun 2017 19:14:49 -0700 > Add a flag field and address prefix length at the end of the tcp_md5sig > structure so users can configure an address prefix length along with a > key. Make sure shorter option values are still accepted in > tcp_v4_parse_md5_keys and tc

[PATCH net-next 4/8] bpf: reset id on spilled regs in clear_all_pkt_pointers

2017-06-10 Thread Daniel Borkmann
Right now, we don't reset the id of spilled registers in case of clear_all_pkt_pointers(). Given pkt_pointers are highly likely to contain an id, do so by reusing __mark_reg_unknown_value(). Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- kernel/bpf/verifier.c | 4 ++-- 1 file c

[PATCH net-next 8/8] bpf: add bpf_set_hash helper for tc progs

2017-06-10 Thread Daniel Borkmann
Allow for tc BPF programs to set a skb->hash, apart from clearing and triggering a recalc that we have right now. It allows for BPF to implement a custom hashing routine for skb_get_hash(). Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- include/uapi/linux/bpf.h | 8 +

[PATCH net-next 3/8] bpf: reset id on CONST_IMM transition

2017-06-10 Thread Daniel Borkmann
Whenever we set the register to the type CONST_IMM, we currently don't reset the id to 0. id member is not used in CONST_IMM case, so don't let it become stale, where pruning won't be able to match later on. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- kernel/bpf/verifier.c |

[PATCH net-next 0/8] Misc BPF updates

2017-06-10 Thread Daniel Borkmann
This set contains a couple of misc updates: stack usage reduction for perf_sample_data in tracing progs, reduction of stale data in verifier on register state transitions that I still had in my queue and few selftest improvements as well as bpf_set_hash() helper for tc programs. Thanks! Daniel Bo

[PATCH net-next 5/8] bpf, tests: add a test for htab lookup + update traversal

2017-06-10 Thread Daniel Borkmann
Add a test case to track behaviour when traversing and updating the htab map. We recently used such traversal, so it's quite useful to keep it as an example in selftests. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- tools/testing/selftests/bpf/test_maps.c | 50 +++

[PATCH net-next 2/8] bpf: don't check spilled reg state for non-STACK_SPILLed type slots

2017-06-10 Thread Daniel Borkmann
spilled_regs[] state is only used for stack slots of type STACK_SPILL, never for STACK_MISC. Right now, in states_equal(), even if we have old and current stack state of type STACK_MISC, we compare spilled_regs[] for that particular offset. Just skip these like we do everywhere else. Signed-off-by

[PATCH net-next 7/8] bpf: remove cg_skb_func_proto and use sk_filter_func_proto directly

2017-06-10 Thread Daniel Borkmann
Since cg_skb_func_proto() doesn't do anything else than just calling into sk_filter_func_proto(), remove it and set sk_filter_func_proto() directly for .get_func_proto callback. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- net/core/filter.c | 8 +--- 1 file changed, 1 ins

[PATCH net-next 1/8] bpf: avoid excessive stack usage for perf_sample_data

2017-06-10 Thread Daniel Borkmann
perf_sample_data consumes 386 bytes on stack, reduce excessive stack usage and move it to per cpu buffer. It's allowed due to preemption being disabled for tracing, xdp and tc programs, thus at all times only one program can run on a specific CPU and programs cannot run from interrupt. We similarly

[PATCH net-next 6/8] bpf, tests: set rlimit also for test_align, so it doesn't fail

2017-06-10 Thread Daniel Borkmann
When running all the tests, through 'make run_tests', I had test_align failing due to insufficient rlimit. Set it the same way as all other test cases from BPF selftests do, so that test case properly loads everything. [...] Summary: 7 PASSED, 1 FAILED selftests: test_progs [PASS] /home/fo

Re: [PATCH v2 0/2] net: mvpp2: driver fixes

2017-06-10 Thread David Miller
From: Thomas Petazzoni Date: Sat, 10 Jun 2017 23:18:20 +0200 > As requested, here is a series of patches containing only bug fixes > for the mvpp2 driver. It is based on the latest "net" branch. > > Changes since v1: > > - Fixed a build breakage that occurred when only PATCH 1 was only, >a

Re: [PATCH] net: caif: Fix a sleep-in-atomic bug in cfpkt_create_pfx

2017-06-10 Thread David Miller
From: Jia-Ju Bai Date: Sat, 10 Jun 2017 16:49:39 +0800 > The kernel may sleep under a rcu read lock in cfpkt_create_pfx, and the > function call path is: > cfcnfg_linkup_rsp (acquire the lock by rcu_read_lock) > cfctrl_linkdown_req > cfpkt_create > cfpkt_create_pfx > alloc_skb

Re: [PATCH] net: tipc: Fix a sleep-in-atomic bug in tipc_msg_reverse

2017-06-10 Thread David Miller
From: Jia-Ju Bai Date: Sat, 10 Jun 2017 17:03:35 +0800 > The kernel may sleep under a rcu read lock in tipc_msg_reverse, and the > function call path is: > tipc_l2_rcv_msg (acquire the lock by rcu_read_lock) > tipc_rcv > tipc_sk_rcv > tipc_msg_reverse > pskb_expand_head(GFP_KE

[PATCH v2 0/2] net: mvpp2: driver fixes

2017-06-10 Thread Thomas Petazzoni
Hello, As requested, here is a series of patches containing only bug fixes for the mvpp2 driver. It is based on the latest "net" branch. Changes since v1: - Fixed a build breakage that occurred when only PATCH 1 was only, and not later patches in the series. Was reported by the kbuild rep

[PATCH v2 2/2] net: mvpp2: use {get,put}_cpu() instead of smp_processor_id()

2017-06-10 Thread Thomas Petazzoni
smp_processor_id() should not be used in migration-enabled contexts. We originally thought it was OK in the specific situation of this driver, but it was wrong, and calling smp_processor_id() in a migration-enabled context prints a big fat warning when CONFIG_DEBUG_PREEMPT=y. Therefore, this commi

[PATCH v2 1/2] net: mvpp2: remove mvpp2_bm_cookie_{build,pool_get}

2017-06-10 Thread Thomas Petazzoni
This commit removes the useless remove mvpp2_bm_cookie_{build,pool_get} functions. All what mvpp2_bm_cookie_build() was doing is compute a 32-bit value by concatenating the pool number and the CPU number... only to get the pool number re-extracted by mvpp2_bm_cookie_pool_get() later on. Instead, j

Re: [PATCH] net: fec: Add a fec_enet_clear_ethtool_stats() stub for CONFIG_M5272

2017-06-10 Thread David Miller
From: Fabio Estevam Date: Sat, 10 Jun 2017 17:33:01 -0300 > On Sat, Jun 10, 2017 at 5:16 PM, David Miller wrote: >> From: Fabio Estevam >> Date: Fri, 9 Jun 2017 22:37:22 -0300 >> >>> From: Fabio Estevam >>> >>> Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on imx51") >>> intro

Re: [PATCH] net: fec: Add a fec_enet_clear_ethtool_stats() stub for CONFIG_M5272

2017-06-10 Thread Fabio Estevam
On Sat, Jun 10, 2017 at 5:16 PM, David Miller wrote: > From: Fabio Estevam > Date: Fri, 9 Jun 2017 22:37:22 -0300 > >> From: Fabio Estevam >> >> Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on imx51") >> introduced fec_enet_clear_ethtool_stats(), but missed to add a stub >> for

[PATCH net v3] net: ipmr: Fix some mroute forwarding issues in vrf's

2017-06-10 Thread Donald Sharp
This patch fixes two issues: 1) When forwarding on *,G mroutes that are in a vrf, the kernel was dropping information about the actual incoming interface when calling ip_mr_forward from ip_mr_input. This caused ip_mr_forward to send the multicast packet back out the incoming interface. Fix this b

Re: [PATCH net-next] Remove the redundant skb->dev initialization in ip6_fragment

2017-06-10 Thread David Miller
From: Chenbo Feng Date: Sat, 10 Jun 2017 12:35:38 -0700 > From: Chenbo Feng > > After moves the skb->dev and skb->protocol initialization into > ip6_output, setting the skb->dev inside ip6_fragment is unnecessary. > > Fixes: 97a7a37a7b7b("ipv6: Initial skb->dev and skb->protocol in ip6_output"

Re: [PATCHv2 net-next] sctp: no need to check assoc id before calling sctp_assoc_set_id

2017-06-10 Thread David Miller
From: Xin Long Date: Sat, 10 Jun 2017 15:27:12 +0800 > sctp_assoc_set_id does the assoc id check in the beginning when > processing dupcookie, no need to do the same check before calling > it. > > v1->v2: > fix some typo errs Marcelo pointed in changelog. > > Signed-off-by: Xin Long Also ap

Re: [PATCH net-next] sctp: fix recursive locking warning in sctp_do_peeloff

2017-06-10 Thread David Miller
From: Xin Long Date: Sat, 10 Jun 2017 14:56:56 +0800 > Dmitry got the following recursive locking report while running syzkaller > fuzzer, the Call Trace: ... > This warning is caused by the lock held by sctp_getsockopt() is on one > socket, while the other lock that sctp_close() is getting late

Re: [PATCH net-next] sctp: use read_lock_bh in sctp_eps_seq_show

2017-06-10 Thread David Miller
From: Xin Long Date: Sat, 10 Jun 2017 15:13:32 +0800 > This patch is to use read_lock_bh instead of local_bh_disable > and read_lock in sctp_eps_seq_show. > > Signed-off-by: Xin Long Applied.

Re: [PATCH net] sctp: disable BH in sctp_for_each_endpoint

2017-06-10 Thread David Miller
From: Xin Long Date: Sat, 10 Jun 2017 14:48:14 +0800 > Now sctp holds read_lock when foreach sctp_ep_hashtable without disabling > BH. If CPU schedules to another thread A at this moment, the thread A may > be trying to hold the write_lock with disabling BH. > > As BH is disabled and CPU cannot

Re: [PATCH] net: fec: Add a fec_enet_clear_ethtool_stats() stub for CONFIG_M5272

2017-06-10 Thread David Miller
From: Fabio Estevam Date: Fri, 9 Jun 2017 22:37:22 -0300 > From: Fabio Estevam > > Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on imx51") > introduced fec_enet_clear_ethtool_stats(), but missed to add a stub > for the CONFIG_M5272=y case, causing build failure for the > m5272

Re: [PATCH net-next] net/packet: remove unneeded declaraion of tpacket_snd().

2017-06-10 Thread David Miller
From: Rami Rosen Date: Sat, 10 Jun 2017 03:22:48 +0300 > This patch removes unneeded forward declaration of tpacket_snd() > in net/packet/af_packet.c. > > Signed-off-by: Rami Rosen Applied, thanks Rami.

Re: [PATCH] l2tp: cast l2tp traffic counter to unsigned

2017-06-10 Thread David Miller
From: Eric Dumazet Date: Fri, 09 Jun 2017 17:29:11 -0700 > On Fri, 2017-06-09 at 15:16 -0700, Stephen Hemminger wrote: >> On Fri, 9 Jun 2017 16:29:47 +0200 >> Dominik Heidler wrote: >> >> > This fixes a counter problem on 32bit systems: >> > When the rx_bytes counter reached 2 GiB, it jumpd to

Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver

2017-06-10 Thread David Miller
From: Florian Fainelli Date: Fri, 9 Jun 2017 15:19:54 -0700 > On 06/09/2017 03:13 PM, neta...@amazon.com wrote: >> From: Netanel Belgazal >> >> This patchset contains fixes for the bugs that were discovered so far. > > If these are all fixes you should submit them against the "net" tree. > net

Re: [PATCH] net: aquantia: atlantic: remove declaration of hw_atl_utils_hw_set_power

2017-06-10 Thread David Miller
From: Philippe Reynes Date: Fri, 9 Jun 2017 23:50:57 +0200 > This function is not defined, so no need to declare it. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes Applied, thanks.

Re: [PATCH net-next] bpf: Remove duplicate tcp_filter hook in ipv6

2017-06-10 Thread David Miller
From: Chenbo Feng Date: Fri, 9 Jun 2017 12:17:37 -0700 > From: Chenbo Feng > > There are two tcp_filter hooks in tcp_ipv6 ingress path currently. > One is at tcp_v6_rcv and another is in tcp_v6_do_rcv. It seems the > tcp_filter() call inside tcp_v6_do_rcv is redundent and some packet > will be

Re: [PATCH net-next v2] bonding: warn user when 802.3ad speed is unknown

2017-06-10 Thread David Miller
From: Nicolas Dichtel Date: Fri, 9 Jun 2017 17:58:08 +0200 > Goal is to advertise the user when ethtool speeds and 802.3ad speeds are > desynchronized. > When this case happens, the kernel needs to be patched. > > Suggested-by: Andrew Lunn > Signed-off-by: Nicolas Dichtel Applied, thanks Nic

Re: [PATCH net 0/2] bnx2x: Fix malicious VFs indication

2017-06-10 Thread David Miller
From: Yuval Mintz Date: Fri, 9 Jun 2017 17:17:00 +0300 > It was discovered that for a VF there's a simple [yet uncommon] scenario > which would cause device firmware to declare that VF as malicious - > Add a vlan interface on top of a VF and disable txvlan offloading for > that VF [causing VF to

Re: [PATCH net-next] bonding: warn user when 802.3ad speed is unknown

2017-06-10 Thread David Miller
From: Nicolas Dichtel Date: Fri, 9 Jun 2017 15:34:43 +0200 > Make it explicit in the log. > > Suggested-by: Andrew Lunn > Signed-off-by: Nicolas Dichtel I agree with others that we should rate limit this somehow given the context in which it is invoked.

Re: [PATCH net-next 2/2] netns: fix error code when the nsid is already used

2017-06-10 Thread David Miller
From: Nicolas Dichtel Date: Fri, 9 Jun 2017 14:41:57 +0200 > When the user tries to assign a specific nsid, idr_alloc() is called with > the range [nsid, nsid+1]. If this nsid is already used, idr_alloc() returns > ENOSPC (No space left on device). In our case, it's better to return > EEXIST to

Re: [PATCH net-next 1/2] netns: define extack error msg for nsis cmds

2017-06-10 Thread David Miller
From: Nicolas Dichtel Date: Fri, 9 Jun 2017 14:41:56 +0200 > It helps the user to identify errors. > > CC: Jamal Hadi Salim > Signed-off-by: Nicolas Dichtel Applied, but please in the future always provide a proper "[PATCH 0/N] " header posting with a patch series. Thank you.

Re: [PATCH v4.11 -stable] esp4: Fix udpencap for local TCP packets.

2017-06-10 Thread David Miller
From: Steffen Klassert Date: Fri, 9 Jun 2017 11:35:46 +0200 > Locally generated TCP packets are usually cloned, so we > do skb_cow_data() on this packets. After that we need to > reload the pointer to the esp header. On udpencap this > header has an offset to skb_transport_header, so take this >

Re: [PATCH net-next] Revert "ipv6: Initial skb->dev and skb->protocol in ip6_output"

2017-06-10 Thread Chenbo Feng
On 06/10/2017 07:55 AM, Eric Dumazet wrote: On Fri, 2017-06-09 at 12:56 -0700, Chenbo Feng wrote: From: Chenbo Feng This reverts commit 97a7a37a7b7b("ipv6: Initial skb->dev and skb->protocol in ip6_output") since it does not handles the skb->dev assignment inside ip6_fragment() code path pro

[PATCH net-next] Remove the redundant skb->dev initialization in ip6_fragment

2017-06-10 Thread Chenbo Feng
From: Chenbo Feng After moves the skb->dev and skb->protocol initialization into ip6_output, setting the skb->dev inside ip6_fragment is unnecessary. Fixes: 97a7a37a7b7b("ipv6: Initial skb->dev and skb->protocol in ip6_output") Signed-off-by: Chenbo Feng --- net/ipv6/ip6_output.c | 1 - 1 file

Re: [PATCH v2] brcmfmac: Fix glom_skb leak in brcmf_sdiod_recv_chain

2017-06-10 Thread Arend van Spriel
On 03-06-17 17:36, Andy Shevchenko wrote: > On Sat, Jun 3, 2017 at 1:29 AM, Peter S. Housel wrote: >> An earlier change to this function (3bdae810721b) fixed a leak in the >> case of an unsuccessful call to brcmf_sdiod_buffrw(). However, the >> glom_skb buffer, used for emulating a scattering read

Re: [PATCH v2] sh_eth: add support to change MTU

2017-06-10 Thread Sergei Shtylyov
Hello! On 06/09/2017 11:36 PM, Niklas Söderlund wrote: The hardware supports the MTU to be changed and the driver it self is somewhat prepared to support this. This patch hooks up the callbacks to be able to change the MTU from user-space. Signed-off-by: Niklas Söderlund Acked-by: Sergei Shty

[PATCH v1] net: rfkill: gpio: Switch to devm_acpi_dev_add_driver_gpios()

2017-06-10 Thread Andy Shevchenko
Switch to use managed variant of acpi_dev_add_driver_gpios() to simplify error path and fix potentially wrong assingment if ->probe() fails. Signed-off-by: Andy Shevchenko --- net/rfkill/rfkill-gpio.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/rfkill/rfkill-gpio.

Re: [PATCH net-next 6/9] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-06-10 Thread Florian Fainelli
Le 06/09/17 à 20:46, Salil Mehta a écrit : > This patch adds the support of MDIO bus interface for HNS3 driver. > Code provides various interfaces to start and stop the PHY layer > and to read and write the MDIO bus or PHY. > > Signed-off-by: Daode Huang > Signed-off-by: lipeng > Signed-off-by:

Re: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver

2017-06-10 Thread Andrew Lunn
On Sat, Jun 10, 2017 at 12:51:57PM +, Mintz, Yuval wrote: > > This adds the support of the debugfs interface to the driver for debugging > > purposes. > > > +const struct hclge_support_cmd support_cmd[] = { > > + {"send cmd", 8, hclge_dbg_send, > > + "opcode flag data0 data1 data

Re: [PATCHv2 net-next] sctp: no need to check assoc id before calling sctp_assoc_set_id

2017-06-10 Thread Marcelo Ricardo Leitner
On Sat, Jun 10, 2017 at 03:27:12PM +0800, Xin Long wrote: > sctp_assoc_set_id does the assoc id check in the beginning when > processing dupcookie, no need to do the same check before calling > it. > > v1->v2: > fix some typo errs Marcelo pointed in changelog. > > Signed-off-by: Xin Long Acke

Re: [PATCH net-next] sctp: use read_lock_bh in sctp_eps_seq_show

2017-06-10 Thread Marcelo Ricardo Leitner
On Sat, Jun 10, 2017 at 03:13:32PM +0800, Xin Long wrote: > This patch is to use read_lock_bh instead of local_bh_disable > and read_lock in sctp_eps_seq_show. > > Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner > --- > net/sctp/proc.c | 6 ++ > 1 file changed, 2 insertions(+),

Re: [PATCH net-next] sctp: fix recursive locking warning in sctp_do_peeloff

2017-06-10 Thread Marcelo Ricardo Leitner
On Sat, Jun 10, 2017 at 02:56:56PM +0800, Xin Long wrote: > Dmitry got the following recursive locking report while running syzkaller > fuzzer, the Call Trace: > __dump_stack lib/dump_stack.c:16 [inline] > dump_stack+0x2ee/0x3ef lib/dump_stack.c:52 > print_deadlock_bug kernel/locking/lockdep.c:1

Re: [PATCH net] sctp: disable BH in sctp_for_each_endpoint

2017-06-10 Thread Marcelo Ricardo Leitner
On Sat, Jun 10, 2017 at 02:48:14PM +0800, Xin Long wrote: > Now sctp holds read_lock when foreach sctp_ep_hashtable without disabling > BH. If CPU schedules to another thread A at this moment, the thread A may > be trying to hold the write_lock with disabling BH. > > As BH is disabled and CPU cann

Re: ARM GLX Khadas VIM Pro - Ethernet detected as only 10Mbps and stalled after some traffic

2017-06-10 Thread Andrew Lunn
> Also what Martin Blumenstingl wrote is following which is also crucial > for fixing the issue: > Amlogic has given their ethernet PHY driver some updates [2], it now > includes wake-on-lan, and they now have an internal_phy_read_status > which uses reset_internal_phy if there's a link and some er

Re: [PATCH net-next] ipv6: Initial skb->dev and skb->protocol in ip6_output

2017-06-10 Thread Eric Dumazet
On Fri, 2017-06-09 at 21:24 +0200, Bjørn Mork wrote: > Chenbo Feng writes: > > > This patch is still under working since it may have problem with > > ip_fragment() call, did you applied it already? Should I send a revert > > patch to you then? > > It does? I initially thought so too, but looking

Re: [PATCH net-next] Revert "ipv6: Initial skb->dev and skb->protocol in ip6_output"

2017-06-10 Thread Eric Dumazet
On Fri, 2017-06-09 at 12:56 -0700, Chenbo Feng wrote: > From: Chenbo Feng > > This reverts commit 97a7a37a7b7b("ipv6: Initial skb->dev and > skb->protocol in ip6_output") since it does not handles the > skb->dev assignment inside ip6_fragment() code path properly. > Need to rework and upload agai

Re: [PATCH net-next] ipv6: Initial skb->dev and skb->protocol in ip6_output

2017-06-10 Thread Eric Dumazet
On Fri, 2017-06-09 at 16:12 -0700, Chenbo Feng wrote: > > On 06/09/2017 12:39 PM, David Miller wrote: > > From: Chenbo Feng > > Date: Fri, 9 Jun 2017 12:13:57 -0700 > > > >> > >> On 06/09/2017 12:08 PM, David Miller wrote: > >>> From: Chenbo Feng > >>> Date: Fri, 9 Jun 2017 12:06:07 -0700 > >>>

Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-06-10 Thread Majd Dibbiny
> On Jun 10, 2017, at 1:24 AM, Doug Ledford wrote: > >> On Wed, 2017-06-07 at 13:21 -0600, Jason Gunthorpe wrote: >>> On Wed, Jun 07, 2017 at 10:13:43PM +0300, Saeed Mahameed wrote: >>> >>> No !! >>> I am just showing you that the ib_core eventually will end up >>> calling >>> mlx5_core to cre

[PATCH net-next 1/1] net: reflect mark on tcp syn ack packets

2017-06-10 Thread Jamal Hadi Salim
From: Jamal Hadi Salim SYN-ACK responses on a server in response to a SYN from a client did not get the injected skb mark that was tagged on the SYN packet. Fixes: 84f39b08d786 ("net: support marking accepting TCP sockets") Signed-off-by: Jamal Hadi Salim --- net/ipv4/ip_output.c | 3 ++- net

[PATCH v2] net: fec: Add a fec_enet_clear_ethtool_stats() stub for CONFIG_M5272

2017-06-10 Thread Fabio Estevam
From: Fabio Estevam Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on imx51") introduced fec_enet_clear_ethtool_stats(), but missed to add a stub for the CONFIG_M5272=y case, causing build failure for the m5272c3_defconfig. Add the missing empty stub to fix the build failure. Rep

RE: [PATCH] net: tipc: Fix a sleep-in-atomic bug in tipc_msg_reverse

2017-06-10 Thread Jon Maloy
Acked. ///jon > -Original Message- > From: Jia-Ju Bai [mailto:baijiaju1...@163.com] > Sent: Saturday, June 10, 2017 05:04 > To: Jon Maloy ; Ying Xue > ; da...@davemloft.net > Cc: netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...@vger.kernel.org; Jia-Ju Bai >

RE: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver

2017-06-10 Thread Mintz, Yuval
> This adds the support of the debugfs interface to the driver for debugging > purposes. > +const struct hclge_support_cmd support_cmd[] = { > + {"send cmd", 8, hclge_dbg_send, > + "opcode flag data0 data1 data2 data3 data4 data5"}, > + {"help", 4, hclge_dbg_usage, "no option

RE: [PATCH net-next 1/9] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-10 Thread Mintz, Yuval
> +static void hns3_nic_net_down(struct net_device *ndev) { > + struct hns3_nic_priv *priv = netdev_priv(ndev); > + struct hnae3_ae_ops *ops; > + int i; > + > + netif_tx_stop_all_queues(ndev); > + netif_carrier_off(ndev); > + netif_tx_disable(ndev); > + > + ops = priv->a

Re: [PATCH net-next RFC 1/1] net netlink: Add new type NLA_FLAG_BITS

2017-06-10 Thread Jamal Hadi Salim
Ping.. Following up On 17-05-02 09:52 PM, Jamal Hadi Salim wrote: On 17-05-02 03:03 PM, David Miller wrote: From: Jamal Hadi Salim Date: Sun, 30 Apr 2017 10:28:39 -0400 Generic bitflags attribute content sent to the kernel by user. With this type the user can either set or unset a flag in

veth: проблемы со скоростью

2017-06-10 Thread Алексей Болдырев
Короче, имеем ядро 4.11.4. При передаче данных через veth, мы получаем скорость примерно такую: root@containers:~# iperf3 -c 10.194.1.3 Connecting to host 10.194.1.3, port 5201 [ 4] local 10.194.1.2 port 55640 connected to 10.194.1.3 port 5201 [ ID] Interval Transfer Bandwidth

Re: [PATCH] i40evf: remove redundant null check on key

2017-06-10 Thread Dan Carpenter
This patch isn't right... On Wed, Jun 07, 2017 at 12:54:07AM +0100, Colin King wrote: > From: Colin Ian King > > key has previously been null checked so the subsequent null check > is redundant as key can never be null at that point, so remove it. > Actually, it's the reverse. "key" is alway

[PATCH] net: tipc: Fix a sleep-in-atomic bug in tipc_msg_reverse

2017-06-10 Thread Jia-Ju Bai
The kernel may sleep under a rcu read lock in tipc_msg_reverse, and the function call path is: tipc_l2_rcv_msg (acquire the lock by rcu_read_lock) tipc_rcv tipc_sk_rcv tipc_msg_reverse pskb_expand_head(GFP_KERNEL) --> may sleep tipc_node_broadcast tipc_node_xmit_skb tipc_n

[PATCH] net: caif: Fix a sleep-in-atomic bug in cfpkt_create_pfx

2017-06-10 Thread Jia-Ju Bai
The kernel may sleep under a rcu read lock in cfpkt_create_pfx, and the function call path is: cfcnfg_linkup_rsp (acquire the lock by rcu_read_lock) cfctrl_linkdown_req cfpkt_create cfpkt_create_pfx alloc_skb(GFP_KERNEL) --> may sleep cfserl_receive (acquire the lock by rcu_read

Re: [PATCHv2 net] net/flow: fix fc->percpu NULL pointer dereference

2017-06-10 Thread Xin Long
On Fri, Jun 9, 2017 at 9:09 PM, Hangbin Liu wrote: > Now we will force to do garbage collection if any policy removed in > xfrm_policy_flush(). But during xfrm_net_exit(). We call flow_cache_fini() > first and set set fc->percpu to NULL. Then after we call xfrm_policy_fini() > -> frxm_policy_flush

Re: ARM GLX Khadas VIM Pro - Ethernet detected as only 10Mbps and stalled after some traffic

2017-06-10 Thread crow
Hi, On Thu, Jun 8, 2017 at 7:30 PM, crow wrote: > Hi, > I have here two problems with Khadas VIM Pro device and Ethernet. > > 1) sometimes with the Kernel Linux 4.12-rc4 the Ethernet link is Up > but only 10Mbps. > Don't work (either SSH to device nor over serial console to ping out) > meson8b-dw

[PATCH net-next] net/packet: remove unneeded declaraion of tpacket_snd().

2017-06-10 Thread Rami Rosen
This patch removes unneeded forward declaration of tpacket_snd() in net/packet/af_packet.c. Signed-off-by: Rami Rosen --- net/packet/af_packet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 82ca49fba336..f9349a495caf 100644 --- a/net/pa

[PATCHv2 net-next] sctp: no need to check assoc id before calling sctp_assoc_set_id

2017-06-10 Thread Xin Long
sctp_assoc_set_id does the assoc id check in the beginning when processing dupcookie, no need to do the same check before calling it. v1->v2: fix some typo errs Marcelo pointed in changelog. Signed-off-by: Xin Long --- net/sctp/associola.c | 8 ++-- 1 file changed, 2 insertions(+), 6 dele

[PATCH net-next] sctp: use read_lock_bh in sctp_eps_seq_show

2017-06-10 Thread Xin Long
This patch is to use read_lock_bh instead of local_bh_disable and read_lock in sctp_eps_seq_show. Signed-off-by: Xin Long --- net/sctp/proc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/sctp/proc.c b/net/sctp/proc.c index 5a27d0f..8e34db5 100644 --- a/net/sctp/p