I don't think we've seen this issue but patch looks good.
________________________________________
From: David Ahern <dsah...@gmail.com>
Sent: 11 June 2017 11:33
To: David Miller; sha...@cumulusnetworks.com
Cc: netdev@vger.kernel.org; Thomas Winter; niko...@cumulusnetworks.com;
yot...@mellanox.com; ido...@mellanox.com; ro...@cumulusnetworks.com
Subject: Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in
vrf's
On 6/10/17 5:07 PM, David Miller wrote:
> From: Donald Sharp <sha...@cumulusnetworks.com>
> Date: Sat, 10 Jun 2017 16:30:17 -0400
>
>> This patch fixes two issues:
>>
>> 1) When forwarding on *,G mroutes that are in a vrf, the
>> kernel was dropping information about the actual incoming
>> interface when calling ip_mr_forward from ip_mr_input.
>> This caused ip_mr_forward to send the multicast packet
>> back out the incoming interface. Fix this by
>> modifying ip_mr_forward to be handed the correctly
>> resolved dev.
>>
>> 2) When a unresolved cache entry is created we store
>> the incoming skb on the unresolved cache entry and
>> upon mroute resolution from the user space daemon,
>> we attempt to forward the packet. Again we were
>> not resolving to the correct incoming device for
>> a vrf scenario, before calling ip_mr_forward.
>> Fix this by resolving to the correct interface
>> and calling ip_mr_forward with the result.
>>
>> Fixes: e58e41596811 ("net: Enable support for VRF with ipv4 multicast")
>> Signed-off-by: Donald Sharp <sha...@cumulusnetworks.com>
>
> David, please review.
>
Responded. Would be good for the Mellanox team (and Thomas) to chime in
as well.
