On Mon, May 8, 2017 at 10:34 PM, David Miller wrote:
> From: Alexandru Ardelean
> Date: Mon, 8 May 2017 14:31:18 +0300
>
>> Looking at xgmac_wait_until_done() and xgmac_wait_until_free()
>> functions, they seem to have turned out completely identical.
>>
>> Though, judging from the git history i
Bjorn Andersson writes:
> The SMD channel is not the primary WCNSS channel and must explicitly be
> closed as the device is removed, or the channel will already by open on
> a subsequent probe call in e.g. the case of reloading the kernel module.
>
> This issue was introduced because I simplified
On Sat, 6 May 2017 22:30:10 +0200
Alexander Alemayhu wrote:
> sparc64 support was added in 7a12b5031c6b (sparc64: Add eBPF JIT.,
> 2017-04-17)[0]
> and ppc64 in 156d0e290e96 (powerpc/ebpf/jit: Implement JIT compiler for
> extended BPF, 2016-06-22)[1].
>
> [0]:
> https://git.kernel.org/pub/sc
If the kernel returns more labels than iproute2 expects, none of
the labels are printed and (null) is shown instead:
$ ip -f mpls ro ls
101 as to (null) via inet 172.16.2.2 dev virt12
201 as to 202/203 via inet6 2001:db8:2::2 dev virt12
Remove the use of MPLS_MAX_LABELS and rely on buf
On Mon, 8 May 2017 19:42:46 +0200
SF Markus Elfring wrote:
> > Which issue do you mean? I dont see any issue you fix here.
>
> Are the run time characteristics a bit nicer for the function “seq_putc”
> in comparison to the function “seq_puts” for printing a single line break
> here?
>
> Rega
Since the addition of the multi queue code with commit 59d0f7465644
("net: fec: init multi queue date structure") the queue selection
has been handelt by the default transmit queue selection
implementation which tries to evenly distribute the traffic across
all available queues. This selection pres
"Gustavo A. R. Silva" writes:
> The name of an array used by itself will always return the array's address.
> So these tests will always evaluate as false and therefore the _return_
> will never be executed.
>
> Signed-off-by: Gustavo A. R. Silva
I don't understand the commit log, especially wh
On Mon, May 8, 2017 at 5:57 PM, David Ahern wrote:
> On 5/8/17 1:11 PM, David Miller wrote:
>> From: Johannes Berg
>> Date: Mon, 08 May 2017 10:55:12 +0200
>>
>>>
+static inline bool netif_is_lwd(struct net_device *dev)
+{
+ return !!(dev->priv_flags & IFF_LWT_NETDEV);
+}
>>
Hi Rob,
On Mon, May 08, 2017 at 04:12:16PM -0500, Rob Herring wrote:
> On Fri, May 5, 2017 at 9:51 AM, Adam Ford wrote:
> > On Sun, Apr 30, 2017 at 11:04 AM, Sebastian Reichel wrote:
> >> On Sun, Apr 30, 2017 at 10:14:20AM -0500, Adam Ford wrote:
> >>> On Wed, Apr 5, 2017 at 1:30 PM, Rob Herring
The SMD channel is not the primary WCNSS channel and must explicitly be
closed as the device is removed, or the channel will already by open on
a subsequent probe call in e.g. the case of reloading the kernel module.
This issue was introduced because I simplified the underlying SMD
implementation
The name of an array used by itself will always return the array's address.
So these tests will always evaluate as false and therefore the _return_
will never be executed.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ath/ath10k/wmi.c | 9 -
1 file changed, 9 deletions(-)
The name of an array used by itself will always return the array's address.
So this test will always evaluate as true.
Addresses-Coverity-ID: 1364903
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ath/ath9k/eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
2017-05-09 3:59 GMT+08:00 David Miller :
> From: Hangbin Liu
> Date: Mon, 8 May 2017 19:11:03 +0800
>
>> After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH
>> or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it.
>>
>> Signed-off-by: Hangbin Liu
>
> Your pa
From: Eric Dumazet
Date: Mon, 08 May 2017 19:18:22 -0700
> Keeping fib (and their reference to netdev) is apparently too much,
> we probably need to implement a refcount on the metrics themselves,
> being stand alone objects.
I think I see the problem, when we flush the dst cache on device
unreg
On Mon, 2017-05-08 at 21:22 -0400, David Miller wrote:
> From: Eric Dumazet
> Date: Mon, 08 May 2017 17:01:20 -0700
>
> > On Mon, 2017-05-08 at 14:35 -0400, David Miller wrote:
> >> From: Cong Wang
> >> Date: Thu, 4 May 2017 14:54:17 -0700
> >>
> >> > IPv4 dst could use fi->fib_metrics to stor
i'm using v4.11.0 release of iproute2 and kernel 3.10.105, simply
running
$ ss
Netid State Recv-Q Send-Q Local Address:Port Peer
Address:Port
tcpCLOSE-WAIT 4340 10.0.0.1:47931
65.49.18.136:https
tcpCLOSE-WAIT 4
From: Eric Dumazet
Date: Mon, 08 May 2017 17:01:20 -0700
> On Mon, 2017-05-08 at 14:35 -0400, David Miller wrote:
>> From: Cong Wang
>> Date: Thu, 4 May 2017 14:54:17 -0700
>>
>> > IPv4 dst could use fi->fib_metrics to store metrics but fib_info
>> > itself is refcnt'ed, so without taking a re
On 5/8/17 1:11 PM, David Miller wrote:
> From: Johannes Berg
> Date: Mon, 08 May 2017 10:55:12 +0200
>
>>
>>> +static inline bool netif_is_lwd(struct net_device *dev)
>>> +{
>>> + return !!(dev->priv_flags & IFF_LWT_NETDEV);
>>> +}
>>
>> Am I the only one who thinks that this "LWT_NETDEV" vs "L
| From: Alexander Duyck
| Date: Saturday, May 6, 2017 11:07 AM
|
| | From: Ding Tianhong
| | Date: Fri, May 5, 2017 at 8:08 PM
| |
| | According the suggestion, I could only think of this code:
| | ..
|
| This is a bit simplistic but it is a start.
Yes, something tells me that this is goin
On Mon, 8 May 2017, Florian Fainelli wrote:
> On 05/08/2017 04:46 PM, Julia Lawall wrote:
> >
> >
> > On Mon, 8 May 2017, Joe Perches wrote:
> >
> >> On Mon, 2017-05-08 at 20:32 +0800, Julia Lawall wrote:
> >>>
> >>> On Mon, 8 May 2017, David Laight wrote:
> >>>
> From: Christophe JAILLET
>
On 05/08/2017 04:46 PM, Julia Lawall wrote:
>
>
> On Mon, 8 May 2017, Joe Perches wrote:
>
>> On Mon, 2017-05-08 at 20:32 +0800, Julia Lawall wrote:
>>>
>>> On Mon, 8 May 2017, David Laight wrote:
>>>
From: Christophe JAILLET
> Sent: 06 May 2017 06:30
> If 'devm_kzalloc' fails, a NU
Use time_after() for time comparison with the new fix.
Signed-off-by: Karim Eshapa
---
drivers/net/wimax/i2400m/i2400m-usb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wimax/i2400m/i2400m-usb.h
b/drivers/net/wimax/i2400m/i2400m-usb.h
index 649ecad..eff4f464
On Mon, 2017-05-08 at 14:35 -0400, David Miller wrote:
> From: Cong Wang
> Date: Thu, 4 May 2017 14:54:17 -0700
>
> > IPv4 dst could use fi->fib_metrics to store metrics but fib_info
> > itself is refcnt'ed, so without taking a refcnt fi and
> > fi->fib_metrics could be freed while dst metrics s
On Mon, 8 May 2017, Joe Perches wrote:
> On Mon, 2017-05-08 at 20:32 +0800, Julia Lawall wrote:
> >
> > On Mon, 8 May 2017, David Laight wrote:
> >
> > > From: Christophe JAILLET
> > > > Sent: 06 May 2017 06:30
> > > > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced.
> > > > Return
On 5/8/17 2:26 PM, David Miller wrote:
From: Karim Eshapa
Date: Mon, 8 May 2017 18:58:02 +0200
diff --git a/drivers/net/wimax/i2400m/i2400m-usb.h
b/drivers/net/wimax/i2400m/i2400m-usb.h
index 649ecad..6fc941c 100644
--- a/drivers/net/wimax/i2400m/i2400m-usb.h
+++ b/drivers/net/wimax/i2400m/i
Use time_after kernel macro for time comparison.
Signed-off-by: Karim Eshapa
---
drivers/net/wireless/rsi/rsi_91x_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_core.c
b/drivers/net/wireless/rsi/rsi_91x_core.c
index f3d3995..68f04a7 1
Instead of a direct cross-type cast, use conatiner_of() to locate
the embedded structure, even in the face of future struct layout
randomization.
Signed-off-by: Kees Cook
---
net/decnet/dn_neigh.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/decnet/dn_neig
From: Jon Mason
Date: Mon, 8 May 2017 17:48:35 -0400
> If an error is encountered in mdio_mux_init(), the error path will call
> mdiobus_free(). Since mdiobus_register() has been called prior to
> mdio_mux_init(), the bus->state will not be MDIOBUS_UNREGISTERED. This
> causes a BUG_ON() in mdi
On 05/08/2017 02:48 PM, Jon Mason wrote:
> If an error is encountered in mdio_mux_init(), the error path will call
> mdiobus_free(). Since mdiobus_register() has been called prior to
> mdio_mux_init(), the bus->state will not be MDIOBUS_UNREGISTERED. This
> causes a BUG_ON() in mdiobus_free(). T
If an error is encountered in mdio_mux_init(), the error path will call
mdiobus_free(). Since mdiobus_register() has been called prior to
mdio_mux_init(), the bus->state will not be MDIOBUS_UNREGISTERED. This
causes a BUG_ON() in mdiobus_free(). To correct this issue, add an
error path for mdio_
On Mon, May 8, 2017 at 1:11 PM, David Miller wrote:
> From: Johannes Berg
> Date: Mon, 08 May 2017 10:55:12 +0200
>
>>
>>> +static inline bool netif_is_lwd(struct net_device *dev)
>>> +{
>>> +return !!(dev->priv_flags & IFF_LWT_NETDEV);
>>> +}
>>
>> Am I the only one who thinks that this "LWT
From: Grygorii Strashko
Date: Mon, 8 May 2017 14:21:21 -0500
> When users set flow control using ethtool the bits are set properly in the
> CPGMAC_SL MACCONTROL register, but the FIFO depth in the respective Port n
> Maximum FIFO Blocks (Pn_MAX_BLKS) registers remains set to the minimum size
> re
From: Cong Wang
Date: Mon, 8 May 2017 10:12:13 -0700
> For each netns (except init_net), we initialize its null entry
> in 3 places:
>
> 1) The template itself, as we use kmemdup()
> 2) Code around dst_init_metrics() in ip6_route_net_init()
> 3) ip6_route_dev_notify(), which is supposed to init
From: Karim Eshapa
Date: Mon, 8 May 2017 18:58:02 +0200
> diff --git a/drivers/net/wimax/i2400m/i2400m-usb.h
> b/drivers/net/wimax/i2400m/i2400m-usb.h
> index 649ecad..6fc941c 100644
> --- a/drivers/net/wimax/i2400m/i2400m-usb.h
> +++ b/drivers/net/wimax/i2400m/i2400m-usb.h
> @@ -131,7 +131,7 @
On Fri, May 5, 2017 at 9:51 AM, Adam Ford wrote:
> On Sun, Apr 30, 2017 at 11:04 AM, Sebastian Reichel wrote:
>> Hi,
>>
>> On Sun, Apr 30, 2017 at 10:14:20AM -0500, Adam Ford wrote:
>>> On Wed, Apr 5, 2017 at 1:30 PM, Rob Herring wrote:
>>> > This series adds serdev support to the HCI LL protoco
On Mon, May 8, 2017 at 4:11 AM, Hangbin Liu wrote:
> After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH
> or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it.
Are you sure we really don't need to handle NDISC_REDIRECT here?
I can't find anything in RFC 247
From: Girish Moodalbail
Date: Mon, 8 May 2017 13:08:24 -0700
> This patch adds changelink rtnl operation support for geneve devices.
> Code changes involve:
> - refactor geneve_newlink into geneve_nl2info to be used by both
> geneve_newlink and geneve_changelink
> - geneve_nl2info takes
This patch adds changelink rtnl operation support for geneve devices.
Code changes involve:
- refactor geneve_newlink into geneve_nl2info to be used by both
geneve_newlink and geneve_changelink
- geneve_nl2info takes a changelink boolean argument to isolate
changelink checks and updates
From: Johannes Berg
Date: Mon, 08 May 2017 10:55:12 +0200
>
>> +static inline bool netif_is_lwd(struct net_device *dev)
>> +{
>> +return !!(dev->priv_flags & IFF_LWT_NETDEV);
>> +}
>
> Am I the only one who thinks that this "LWT_NETDEV" vs "LWD" is a bit
> confusing?
Agreed, my old eyes ca
From: Johannes Berg
Date: Mon, 8 May 2017 16:46:21 +0200
> Thanks for merging the rate fix quickly the other day. I've got a
> few more fixes lined up, so this time as a pull request.
>
> Please pull and let me know if there's any problem.
Pulled, thanks.
From: Jim Baxter
Date: Mon, 8 May 2017 13:49:57 +0100
> The zero padding that is added to NTB's does
> not zero the memory correctly.
> This is because the skb_put modifies the value
> of skb_out->len which results in the memset
> command not setting any memory to zero as
> (ctx->tx_max - skb_out
From: Hangbin Liu
Date: Mon, 8 May 2017 19:11:03 +0800
> After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH
> or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it.
>
> Signed-off-by: Hangbin Liu
Your patches here, all seemingly due to "visual inspection"
On Mon, 2017-05-08 at 20:32 +0800, Julia Lawall wrote:
>
> On Mon, 8 May 2017, David Laight wrote:
>
> > From: Christophe JAILLET
> > > Sent: 06 May 2017 06:30
> > > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced.
> > > Return -ENOMEM instead, as done for some other memory allocatio
On 2017/05/04 22:50, Tom Herbert wrote:
> Hi,
>
> I am thinking about the possibility of using SSE in kernel for
> speeding up the kernel memcpy particularly for copy to userspace
> emeory, and maybe even using the string instructions (like if we
> supported regex in something like eBPF). AFAIK we
From: Alexandru Ardelean
Date: Mon, 8 May 2017 14:31:18 +0300
> Looking at xgmac_wait_until_done() and xgmac_wait_until_free()
> functions, they seem to have turned out completely identical.
>
> Though, judging from the git history it seems they
> initially weren't.
>
> Remove xgmac_wait_until
When users set flow control using ethtool the bits are set properly in the
CPGMAC_SL MACCONTROL register, but the FIFO depth in the respective Port n
Maximum FIFO Blocks (Pn_MAX_BLKS) registers remains set to the minimum size
reset value. When receive flow control is enabled on a port, the port's
a
From: Stephen Hemminger
Date: Mon, 8 May 2017 12:13:59 -0700
> Thanks for addressing a confusing and messy semantic. If you merge
> this then it would be good to update the documentation in
> Doucmentation/networking to describe how drivers are supposed to
> behave.
Will do.
> An alternative an
From: Andy Shevchenko
Date: Mon, 8 May 2017 17:14:18 +0300
> Due to misconfiguration of PCI driver for Intel Quark the user will get
> a kernel crash:
>
> # udhcpc -i eth0
> udhcpc: started, v1.26.2
> stmmaceth :00:14.6 eth0: device MAC address 98:4f:ee:05:ac:47
> Generic PHY stmmac-a6:01:
On Mon, 08 May 2017 12:52:43 -0400 (EDT)
David Miller wrote:
> Network devices can allocate reasources and private memory using
> netdev_ops->ndo_init(). However, the release of these resources
> can occur in one of two different places.
>
> Either netdev_ops->ndo_uninit() or netdev->destructor
From: Hangbin Liu
Date: Mon, 8 May 2017 17:57:13 +0800
> Signed-off-by: Hangbin Liu
Applied.
Hello,
On Mon, 8 May 2017 16:28:21 +0200, Giuseppe CAVALLARO wrote:
> > I just see that GMAC_CONTROL and MAC_CTRL_REG are the same, so why not
> > create a custom adjust_link for each dwmac type ?
> > This will permit to call it instead of set_ps() and remove lots of if
> > (has_gmac) and co in
From: Daniel Borkmann
Date: Mon, 8 May 2017 00:04:09 +0200
> The patch fixes two things at once:
>
> 1) It checks the env->allow_ptr_leaks and only prints the map address to
>the log if we have the privileges to do so, otherwise it just dumps 0
>as we would when kptr_restrict is enabled
Hi,
On Fri, May 05, 2017 at 09:51:33AM -0500, Adam Ford wrote:
> On Sun, Apr 30, 2017 at 11:04 AM, Sebastian Reichel wrote:
> > On Sun, Apr 30, 2017 at 10:14:20AM -0500, Adam Ford wrote:
> >> On Wed, Apr 5, 2017 at 1:30 PM, Rob Herring wrote:
> >> > This series adds serdev support to the HCI LL
From: Peter Heise
Date: Sun, 7 May 2017 17:15:26 +
> Return value of skb_put_padto is now checked as
> reported by Dan Carpenter. skb might be freed in
> case of error in skb_put_padto.
> ---
> net/hsr/hsr_device.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/n
From: Geliang Tang
Date: Sat, 6 May 2017 23:42:16 +0800
> Use memdup_user() helper instead of open-coding to simplify the code.
>
> Signed-off-by: Geliang Tang
Applied.
From: Geliang Tang
Date: Sat, 6 May 2017 23:42:22 +0800
> Use memdup_user() helper instead of open-coding to simplify the code.
>
> Signed-off-by: Geliang Tang
Applied.
From: Ganesh Goudar
Date: Sat, 6 May 2017 14:25:06 +0530
> Recent Chelsio firmware started using few port capablity bits to
> manage FEC and as driver was not aware of FEC changes those bits
> were zeroed, consequently disabling FEC.
>
> Avoid zeroing those bits and default to whatever the firm
From: Christophe JAILLET
Date: Sat, 6 May 2017 07:29:45 +0200
> If 'devm_kzalloc' fails, a NULL pointer will be dereferenced.
> Return -ENOMEM instead, as done for some other memory allocation just a
> few lines above.
>
> Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
>
> Signed-off-by: Chr
From: Hangbin Liu
Date: Sat, 6 May 2017 11:17:52 +0800
> Signed-off-by: Hangbin Liu
Changes like this neither make the code better nor worse, so please
avoid this kind of churn.
I'm not applying this.
Thank you.
From: Hangbin Liu
Date: Sat, 6 May 2017 11:17:06 +0800
> Signed-off-by: Hangbin Liu
Applied.
From: Kees Cook
Date: Fri, 5 May 2017 15:30:23 -0700
> Using memcpy() from a string that is shorter than the length copied means
> the destination buffer is being filled with arbitrary data from the kernel
> rodata segment. Instead, use strncpy() which will fill the trailing bytes
> with zeros.
>
From: Kees Cook
Date: Fri, 5 May 2017 15:34:34 -0700
> Using memcpy() from a string that is shorter than the length copied means
> the destination buffer is being filled with arbitrary data from the kernel
> rodata segment. Instead, use strncpy() which will fill the trailing bytes
> with zeros.
>
From: Kees Cook
Date: Fri, 5 May 2017 15:25:32 -0700
> Using memcpy() from a string that is shorter than the length copied means
> the destination buffer is being filled with arbitrary data from the kernel
> rodata segment. Instead, use strncpy() which will fill the trailing bytes
> with zeros.
>
From: Vladislav Yasevich
Date: Fri, 5 May 2017 16:17:41 -0400
> Vlan devices, like all other software devices, enable
> NETIF_F_HW_CSUM feature. However, unlike all the othe other
> software devices, vlans will switch to using IP|IPV6_CSUM
> features, if the underlying devices uses them. In th
From: Wei Wang
Date: Fri, 5 May 2017 12:53:23 -0700
> From: Wei Wang
>
> Congestion control modules that want full control over congestion
> control behavior do not want the cwnd modifications controlled by
> the sysctl_tcp_slow_start_after_idle code path.
> So skip those code paths for CC mod
From: Cong Wang
Date: Thu, 4 May 2017 14:54:17 -0700
> IPv4 dst could use fi->fib_metrics to store metrics but fib_info
> itself is refcnt'ed, so without taking a refcnt fi and
> fi->fib_metrics could be freed while dst metrics still points to
> it. This triggers use-after-free as reported by An
On 2017-05-07 19:13, Andy Duan wrote:
> From: Andrew Lunn Sent: Friday, May 05, 2017 8:24 PM
>>To: Andy Duan
>>Cc: Stefan Agner ; feste...@gmail.com;
>>netdev@vger.kernel.org; netdev-ow...@vger.kernel.org
>>Subject: Re: FEC on i.MX 7 transmit queue timeout
>>
>>> No, it is not workaround. As i sa
On Mon, 2017-05-08 at 15:29 +, Chiappero, Marco wrote:
> > -Original Message-
> > From: Jiri Benc [mailto:jb...@redhat.com]
> > Sent: Thursday, May 4, 2017 5:44 PM
> > To: Chiappero, Marco
> > Cc: Dan Williams ; netdev@vger.kernel.org; David S
> > .
> > Miller ; Kirsher, Jeffrey T
> >
> Which issue do you mean? I dont see any issue you fix here.
Are the run time characteristics a bit nicer for the function “seq_putc”
in comparison to the function “seq_puts” for printing a single line break here?
Regards,
Markus
On 05/06/2017 09:07 AM, David Ahern wrote:
> As I have mentioned many times[1], at ~43+kB per instance the use of
> net_devices does not scale for deployments needing 10,000+ devices. At
> netconf 1.2 there was a discussion about using a net_device_common for
> the minimal set of common attributes
On 2017-05-08 16:14, Andy Shevchenko wrote:
> Due to misconfiguration of PCI driver for Intel Quark the user will get
> a kernel crash:
>
> # udhcpc -i eth0
> udhcpc: started, v1.26.2
> stmmaceth :00:14.6 eth0: device MAC address 98:4f:ee:05:ac:47
> Generic PHY stmmac-a6:01: attached PHY drive
On 05/06/2017 09:07 AM, David Ahern wrote:
> Delay ipv4 and ipv6 initializations on lightweight netdevices until an
> address is added to the device.
>
> Skip sysctl initialization for neighbor path as well.
Yeah, thanks for including the sysctl initialization. One thing that my
earlier "L2 only"
On Fri, May 05, 2017 at 10:47:09PM -0400, David Miller wrote:
> From: David Miller
> Date: Fri, 05 May 2017 16:20:44 -0400 (EDT)
>
> > Anyways, I'll play with this design and see what happens...
> > Feedback is of course welcome.
>
> Here is a prototype that works for me with test_pkt_access.c,
From: Markus Elfring
Date: Mon, 8 May 2017 19:21:27 +0200
A bit of data was put into a sequence by separate function calls.
Print the same data together with adjusted seq_printf() calls instead.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
driver
On 05/06/2017 09:07 AM, David Ahern wrote:
> Lightweight netdevices are not added to sysfs; bypass kobject
> initialization.
I was wondering if we actually needed a flag to tell: this is a
lightweight device, but still let it show up in /sys. All use cases that
I have in mind (getting the physical
On Mon, May 08, 2017 at 12:04:09AM +0200, Daniel Borkmann wrote:
> The patch fixes two things at once:
>
> 1) It checks the env->allow_ptr_leaks and only prints the map address to
>the log if we have the privileges to do so, otherwise it just dumps 0
>as we would when kptr_restrict is enab
For each netns (except init_net), we initialize its null entry
in 3 places:
1) The template itself, as we use kmemdup()
2) Code around dst_init_metrics() in ip6_route_net_init()
3) ip6_route_dev_notify(), which is supposed to initialize it after
loopback registers
Unfortunately the last one st
Hi,
On 08.05.2017 18:42, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 8 May 2017 18:38:17 +0200
>
> A single character (line break) should be put into a sequence.
Why?
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle softwar
cast timeframe variable with (unsigned long) then
use time_after() kernel macro for time comparison.
Signed-off-by: Karim Eshapa
---
drivers/net/wimax/i2400m/i2400m-usb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wimax/i2400m/i2400m-usb.h
b/drivers/net/wima
From: Pavel Belous
Date: Thu, 4 May 2017 23:10:56 +0300
> From: Pavel Belous
>
> This patch fixes the crash that happens when driver tries to collect
> statistics
> from already released "aq_vec" object.
> If adapter is in "down" state we still allow user to see statistics from HW.
>
> V2: f
Network devices can allocate reasources and private memory using
netdev_ops->ndo_init(). However, the release of these resources
can occur in one of two different places.
Either netdev_ops->ndo_uninit() or netdev->destructor().
The decision of which operation frees the resources depends upon
wh
From: Markus Elfring
Date: Mon, 8 May 2017 18:38:17 +0200
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/net/ethernet/marvell/sky
> Several companies maintain embedded Linux
> distributions and tools to build software images. These tools provide a user
> interface that allows to select what packages go into such an image.
The tools allow you to select what binary packages are placed into the
image. You can build multiple bin
From: Markus Elfring
Date: Mon, 8 May 2017 18:10:39 +0200
Two single characters should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/net/ethernet/intel/fm10k/fm10k_deb
Hi David,
Quoting David Miller :
From: "Gustavo A. R. Silva"
Date: Thu, 4 May 2017 14:44:16 -0500
@@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk,
struct sk_buff *skb,
nlmsg_flags, unlh, net_admin);
}
+/*
+ * Ignore the position of the argum
On 05/04/2017 03:42 PM, Leon Romanovsky wrote:
On Thu, May 04, 2017 at 03:26:13PM -0400, Dennis Dalessandro wrote:
On 05/04/2017 02:45 PM, Leon Romanovsky wrote:
On Thu, May 04, 2017 at 06:30:27PM +, Bart Van Assche wrote:
On Thu, 2017-05-04 at 21:25 +0300, Leon Romanovsky wrote:
On Thu,
From: David Ahern
Date: Thu, 4 May 2017 13:41:15 -0600
> On 5/4/17 11:36 AM, Cong Wang wrote:
>> For each netns (except init_net), we initialize its null entry
>> in 3 places:
>>
>> 1) The template itself, as we use kmemdup()
>> 2) Code around dst_init_metrics() in ip6_route_net_init()
>> 3) ip6
From: "Gustavo A. R. Silva"
Date: Thu, 4 May 2017 14:44:16 -0500
> @@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, struct sk_buff
> *skb,
> nlmsg_flags, unlh, net_admin);
> }
>
> +/*
> + * Ignore the position of the arguments req->id.idiag_dport a
On Mon, 8 May 2017 15:19:28 +
Bart Van Assche wrote:
> On Sun, 2017-05-07 at 12:20 +0200, Jiri Pirko wrote:
> > Sat, May 06, 2017 at 04:40:24PM CEST, bart.vanass...@sandisk.com wrote:
> > > On Sat, 2017-05-06 at 12:40 +0200, Jiri Pirko wrote:
> > > > Thu, May 04, 2017 at 08:10:54PM CEST,
> -Original Message-
> From: Jiri Benc [mailto:jb...@redhat.com]
> Sent: Thursday, May 4, 2017 5:44 PM
> To: Chiappero, Marco
> Cc: Dan Williams ; netdev@vger.kernel.org; David S .
> Miller ; Kirsher, Jeffrey T
> ; Duyck, Alexander H
> ; Grandhi, Sainath
> ; Mahesh Bandewar
> Subject: Re
On Mon, May 8, 2017 at 7:33 AM, Ding Tianhong wrote:
>
>
> On 2017/5/7 2:07, Alexander Duyck wrote:
>> On Fri, May 5, 2017 at 8:08 PM, Ding Tianhong
>> wrote:
>>>
>>>
>>> On 2017/5/5 22:04, Alexander Duyck wrote:
On Thu, May 4, 2017 at 2:01 PM, Casey Leedom wrote:
> | From: Alexander D
On Sun, 2017-05-07 at 12:20 +0200, Jiri Pirko wrote:
> Sat, May 06, 2017 at 04:40:24PM CEST, bart.vanass...@sandisk.com wrote:
> > On Sat, 2017-05-06 at 12:40 +0200, Jiri Pirko wrote:
> > > Thu, May 04, 2017 at 08:10:54PM CEST, bart.vanass...@sandisk.com wrote:
> > > > On Thu, 2017-05-04 at 21:02 +
From: Daniel Borkmann
Date: Mon, 08 May 2017 12:49:25 +0200
> On 05/06/2017 04:47 AM, David Miller wrote:
>> From: David Miller
>> Date: Fri, 05 May 2017 16:20:44 -0400 (EDT)
>>
>>> Anyways, I'll play with this design and see what happens...
>>> Feedback is of course welcome.
>>
>> Here is a pro
On Mon, 2017-05-08 at 11:09 +0800, Hangbin Liu wrote:
> Since ip6_frag_reasm() will call __in6_dev_get(dev), which will access
> dev->ip6_ptr. We need to make sure dev is not NULL.
>
> Signed-off-by: Hangbin Liu
> ---
> net/ipv6/reassembly.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-
On Mon, 2017-05-08 at 17:57 +0800, Hangbin Liu wrote:
> I searched 4308fc58dced ("tcp: Document use of undefined variable") in
> archive list, but did not find the thread. So I'm not sure why we only
> add a description about un-initialized value.
>
> Even we don't use tmp_opt.sack_ok, I think it
On Mon, 2017-05-08 at 15:49 +0800, Shan Wei wrote:
> Indeed, HZ=250. What is the problem about autotuning with HZ=250?
>
You might look at recent patches.
commit 645f4c6f2ebd040688cc2a5f626ffc909e66ccf2
("tcp: switch rcv_rtt_est and rcvq_space to high resolution timestamps")
Thanks.
Hi Dave,
Thanks for merging the rate fix quickly the other day. I've got a
few more fixes lined up, so this time as a pull request.
Please pull and let me know if there's any problem.
Thanks,
johannes
The following changes since commit 4ac4d584886a4f47f8ff3bca0f32ff9a2987d3e5:
Merge git://
On 2017/5/7 2:07, Alexander Duyck wrote:
> On Fri, May 5, 2017 at 8:08 PM, Ding Tianhong wrote:
>>
>>
>> On 2017/5/5 22:04, Alexander Duyck wrote:
>>> On Thu, May 4, 2017 at 2:01 PM, Casey Leedom wrote:
| From: Alexander Duyck
| Sent: Wednesday, May 3, 2017 9:02 AM
| ...
|
Hello
On 5/3/2017 4:30 PM, Corentin Labbe wrote:
On Wed, May 03, 2017 at 10:13:56AM +0200, Giuseppe CAVALLARO wrote:
Hello Thomas
this was initially set by using the hw->link.port; both the core_init
and adjust callback
should invoke the hook and tuning the PS bit according to the speed and
mo
On 5/8/2017 4:14 PM, Andy Shevchenko wrote:
The commit 26d6851fd24e
("net: stmmac: set default number of rx and tx queues in stmmac_pci")
missed Intel Quark configuration. Append it here.
Fixes: 26d6851fd24e ("net: stmmac: set default number of rx and tx queues in
stmmac_pci")
Cc: Joa
1 - 100 of 153 matches
Mail list logo
