Thu, Apr 27, 2017 at 07:46:03PM CEST, xiyou.wangc...@gmail.com wrote:
>On Thu, Apr 27, 2017 at 4:12 AM, Jiri Pirko wrote:
>> Simple example:
>> $ tc qdisc add dev eth0 ingress
>> $ tc filter add dev eth0 parent : protocol ip pref 33 flower dst_mac
>> 52:54:00:3d:c7:6d action goto chain 11
>>
Fri, Apr 28, 2017 at 03:41:08AM CEST, j...@mojatatu.com wrote:
>
>Jiri,
>
>Good stuff!
>Thanks for the effort.
>
>I didnt review the details - will do. I wanted to raise one issue.
>This should work for all actions, not just gact (refer to the
>recent commit i made on the action jumping).
>
>Exampl
On Thu, Apr 27, 2017 at 09:45:57AM -0600, Logan Gunthorpe wrote:
>
>
> On 26/04/17 09:56 PM, Herbert Xu wrote:
> > On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote:
> >> Very straightforward conversion to the new function in the caam driver
> >> and shash library.
> >>
> >> Signed-
From: lipeng
In the hip06 and hip07 SoCs, the interrupt lines from the
DSAF controllers are connected to mbigen hw module.
The mbigen module is probed with module_init, and, as such,
is not guaranteed to probe before the HNS driver. So we need
to support deferred probe.
Signed-off-by: lipeng
Re
From: lipeng
This patchset add support defered dsaf probe when mdio and
mbigen module is not insmod.
For more details, please refer to individual patch.
change log:
V4 - > V5:
1. Float on net-next;
2. Delete patch "net: hns: fixed bug that skb used after kfree"
from this patchset;
V3 -> V4:
From: lipeng
In the hip06 and hip07 SoCs, phy connect to mdio bus.The mdio
module is probed with module_init, and, as such,
is not guaranteed to probe before the HNS driver. So we need
to support deferred probe.
We check for probe deferral in the mac init, so we not init DSAF
when there is no md
On Thu, 27 Apr 2017 22:49:51 -0700
Alexei Starovoitov wrote:
> On Thu, Apr 27, 2017 at 01:15:42PM +0200, Jesper Dangaard Brouer wrote:
> >
> > To provoke this bug, remember that you MUST call:
> >
> > make headers_install
> >
> > In the kernels root directory, else you will be compiling sampl
On Fri, 28 Apr 2017 11:13:33 +0530
Sricharan R wrote:
> Hi Ralph,
>
> On 4/27/2017 8:10 PM, Ralph Sennhauser wrote:
> > On Thu, 27 Apr 2017 19:05:09 +0530
> > Sricharan R wrote:
> >
> >> Hi,
> >>
> >> On 4/26/2017 9:45 PM, Ralph Sennhauser wrote:
> >>> Hi Sricharan R,
> >>>
> >>> Commit 09
On Thu, Apr 27, 2017 at 03:30:24PM -0700, Florian Fainelli wrote:
> After commit 6d684e54690c ("rhashtable: Cap total number of
> entries to 2^31"), we would be hitting a panic() in net/core/rtnetlink.c
> during initialization. The call stack would look like this:
Thanks for the patch. I think we
On Thu, Apr 27, 2017 at 01:15:42PM +0200, Jesper Dangaard Brouer wrote:
>
> To provoke this bug, remember that you MUST call:
>
> make headers_install
>
> In the kernels root directory, else you will be compiling samples/bpf/
> against the older headers previously installed.
>
> The error look
Hi Ralph,
On 4/27/2017 8:10 PM, Ralph Sennhauser wrote:
> On Thu, 27 Apr 2017 19:05:09 +0530
> Sricharan R wrote:
>
>> Hi,
>>
>> On 4/26/2017 9:45 PM, Ralph Sennhauser wrote:
>>> Hi Sricharan R,
>>>
>>> Commit 09515ef5ddad ("of/acpi: Configure dma operations at probe
>>> time for platform/amba/p
On 4/27/17 10:06 PM, John Fastabend wrote:
That is more or less what I was thinking as well. The other question
I have though is should we have a bpf_redirect() call for the simple
case where I use the ifindex directly. This will be helpful for taking
existing programs from tc_cls into xdp. I thi
On 17-04-27 04:31 PM, Alexei Starovoitov wrote:
> On 4/27/17 1:41 AM, Jesper Dangaard Brouer wrote:
>> When registering/attaching a XDP/bpf program, we would just send the
>> file-descriptor for this port-map along (like we do with the bpf_prog
>> FD). Plus, it own ingress-port number this program
On Fri, 2017-04-28 at 12:55 +1000, Daurnimator wrote:
> On 1 April 2017 at 03:52, Cong Wang wrote:
> > Please submit your patch formally and with a man page patch too.
>
> Did a patch get submitted? I had a look but couldn't see it.
Not yet.
I will probably wait for next cycle (linux-4.13), I h
Hi Ralph,
On 4/27/2017 7:05 PM, Sricharan R wrote:
> Hi,
>
> On 4/26/2017 9:45 PM, Ralph Sennhauser wrote:
>> Hi Sricharan R,
>>
>> Commit 09515ef5ddad ("of/acpi: Configure dma operations at probe time
>> for platform/amba/pci bus devices") causes a kernel panic as in the log
>> below on an armad
As Or points out in commit 423b3aecf290 ("net/mlx4: Change ENOTSUPP
to EOPNOTSUPP"), ENOTSUPP is NFS specific error. Replace it with
EOPNOTSUPP.
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/nfp_bpf_jit.c | 24 +++---
.../net/ethernet/netronome/nfp/nfp_n
We will soon allocate RX buffers for caching on XDP TX rings.
The rx_ring parameter passed to nfp_net_rx_alloc_one() is not
actually used, remove it.
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-
Reading TX queue indexes from the device memory on each interrupt
is expensive. It's doubly expensive with XDP running since we have
two TX rings to check there. If the software indexes indicate that
the TX queue is completely empty, however, we don't need to look at
the device completion index a
For legacy reasons NFP FW may be compiled to DMA packets to a constant
offset into the buffer and use the space before it for metadata. This
ensures that packets data always start at a certain offset regardless of
the amount of preceding metadata.
If rx offset is set to 0 there may still be up to
Right now the required Service Process ABI version is still tied
to max ID of known commands. For new NSP commands we are adding
we are checking if NSP version is recent enough on command-by-command
basis. The driver doesn't have to force the device to have the
very latest flash, anything newer t
On the RX path we follow the "drop if allocation of replacement
buffer fails" rule. With XDP we extended that to the TX action,
so if XDP prog returned TX but allocation of replacement RX buffer
failed, we will drop the packet.
To improve our XDP TX performance extend the idea of rings being
alwa
Hi!
This series optimizes the nfp XDP TX performance a little bit.
I run quick tests on an Intel(R) Xeon(R) CPU E5-2630 v4 @ 2.20GHz.
Single core/queue performance for both touch and drop and touch and
forward is above 20Mpps @64B packets, drop being 2Mpps faster.
I think this is max for a s
On Thu, Apr 27, 2017 at 01:10:27PM +0200, Daniel Borkmann wrote:
> On 04/27/2017 01:41 AM, Chenbo Feng wrote:
> > From: Chenbo Feng
> >
> > The description inside uapi/linux/bpf.h about bpf_get_socket_uid
> > helper function is no longer valid. It returns overflowuid rather
> > than 0 when failed
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
commit 6d684e54690caef45cf14051ddeb7c71beeb681b
Author: Herbert Xu
AuthorDate: Thu Apr 27 13:44:51 2017 +0800
Commit: David S. M
On 2017/4/28 1:38, Florian Fainelli wrote:
On 04/26/2017 07:44 PM, Yankejian wrote:
struct hns_nic_priv *priv = netdev_priv(ndev);
struct hnae_ring *ring = ring_data->ring;
@@ -361,6 +361,10 @@ int hns_nic_net_xmit_hw(struct net_device *ndev,
dev_queue = netdev_get_tx_q
On 2017/4/27 19:58, Matthias Brugger wrote:
On 27/04/17 04:44, Yankejian wrote:
From: lipeng
In the hip06 and hip07 SoCs, the interrupt lines from the
DSAF controllers are connected to mbigen hw module.
The mbigen module is probed with module_init, and, as such,
is not guaranteed to probe
From: Gao Feng
These drivers allocate kinds of resources in init routine, and free
some resources in the destructor of net_device. It may cause memleak
when some errors happen after register_netdevice invokes the init
callback. Because only the uninit callback is invoked in the error
handler of r
On 1 April 2017 at 03:52, Cong Wang wrote:
> Please submit your patch formally and with a man page patch too.
Did a patch get submitted? I had a look but couldn't see it.
On Wed, Apr 26, 2017 at 11:53:34AM -0400, Vivien Didelot wrote:
> Make the code which fetches or initializes a new VTU entry more concise.
> This allows us the get rid of the old underscore prefix naming.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Andrew
On Wed, Apr 26, 2017 at 11:53:33AM -0400, Vivien Didelot wrote:
> Now that we have chip operations for VTU accesses, mark all helpers from
> global1_vtu.c as static. Only the various implementations of the
> GetNext, LoadPurge and Flush operations need to be exposed.
>
> Signed-off-by: Vivien Dide
On Wed, Apr 26, 2017 at 11:53:32AM -0400, Vivien Didelot wrote:
> Add a new vtu_loadpurge operation to the chip info structure to differ
> the various implementations of the VTU accesses.
>
> Now that the STU handling is abstracted behind VTU operations, kill the
> obsolete MV88E6XXX_FLAG_STU flag
/backtrace):
+-+---++
| |
next-20170427 | df7008bdd5 |
+-+---++
| boot_successes | 10
| 0 |
| boo
On Wed, Apr 26, 2017 at 11:53:31AM -0400, Vivien Didelot wrote:
> Add a new vtu_getnext operation to the chip info structure to differ the
> various implementations of the VTU accesses.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Andrew
On Wed, Apr 26, 2017 at 11:53:30AM -0400, Vivien Didelot wrote:
> Now that the code writes both VTU and STU data when loading a VTU entry,
> load the corresponding STU entry at the same time.
>
> This allows us to get rid of the STU management in the
> _mv88e6xxx_vtu_new helper and thus remove the
On 4/27/17 1:42 PM, David Miller wrote:
Can you guys give me some kind of idea of how it might be nice to
represent calls and tailcalls in assembler files?
llvm prints them as 'call 1' for bpf_map_lookup
and 'call 12' for bpf_tail_call.
In the instruction stream bpf_tail_call is no different
t
Attached.
Needs some cleanup and more testing (I only tested a few of these
actions - should work, just need to vet before official submission).
cheers,
jamal
diff --git a/tc/m_connmark.c b/tc/m_connmark.c
index 295f90d..bdb6195 100644
--- a/tc/m_connmark.c
+++ b/tc/m_connmark.c
@@ -81,7 +81,7 @
Use time_before_eq for time comparison more safe and dealing
with timer wrapping to be future-proof.
Signed-off-by: Karim Eshapa
---
drivers/net/ethernet/emulex/benet/be_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
Jiri,
Good stuff!
Thanks for the effort.
I didnt review the details - will do. I wanted to raise one issue.
This should work for all actions, not just gact (refer to the
recent commit i made on the action jumping).
Example policy for policer:
#if packets destined for mac address 52:54:00:3d:c
On 17-04-27 02:30 AM, Jiri Pirko wrote:
Wed, Apr 26, 2017 at 10:07:08PM CEST, j...@mojatatu.com wrote:
On 17-04-26 09:56 AM, Jiri Pirko wrote:
Wed, Apr 26, 2017 at 03:14:38PM CEST, j...@mojatatu.com wrote:
I think to have flags at that level is useful but it
is a different hierarchy level. I
On 4/27/17 6:36 AM, Hannes Frederic Sowa wrote:
On 27.04.2017 08:24, Martin KaFai Lau wrote:
This patchset introduces the bpf_prog ID and a new bpf cmd to
iterate all bpf_prog in the system.
It is still incomplete. The idea can be extended to bpf_map.
Martin KaFai Lau (2):
bpf: Introduce bp
From: Willem de Bruijn
Avoid hashing the tx napi struct into napi_hash[], which is used for
busy polling receive queues.
Signed-off-by: Willem de Bruijn
---
drivers/net/virtio_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/v
> From: Gao Feng [mailto:gfree.w...@foxmail.com]
> Sent: Thursday, April 27, 2017 4:33 PM
> > From: Herbert Xu [mailto:herb...@gondor.apana.org.au]
> > Sent: Thursday, April 27, 2017 4:16 PM On Tue, Apr 25, 2017 at
> > 08:01:50PM +0800, gfree.w...@foxmail.com wrote:
> > > From: Gao Feng
> > >
> [.
On Thu, Apr 27, 2017 at 12:51 PM, Vlad Yasevich wrote:
> On 04/24/2017 11:14 AM, Roopa Prabhu wrote:
>> On Sun, Apr 23, 2017 at 6:07 PM, David Ahern
>> wrote:
>>>
>>> On 4/21/17 11:31 AM, Vladislav Yasevich wrote:
@@ -1276,9 +1277,40 @@ static int rtnl_xdp_fill(struct sk_buff *skb,
st
On Thu, 2017-04-27 at 16:46 -0700, Cong Wang wrote:
> On Thu, Apr 27, 2017 at 5:46 AM, Eric Dumazet wrote:
> > On Wed, 2017-04-26 at 13:55 -0700, Cong Wang wrote:
> >> After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control")
> >> we always take RTNL lock for ip_ra_control() which is the
On Thu, 27 Apr 2017 11:43:47 +0200 (CEST)
Michal Kubecek wrote:
> As noticed by one of the few users of routel script, it ends up in an
> infinite loop when they pull out the cable from the NIC used for some
> route. This is caused by its parser expecting the line of "ip route show"
> output cons
On Thu, Apr 27, 2017 at 5:46 AM, Eric Dumazet wrote:
> On Wed, 2017-04-26 at 13:55 -0700, Cong Wang wrote:
>> After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control")
>> we always take RTNL lock for ip_ra_control() which is the only place
>> we update the list ip_ra_chain, so the ip_ra_
On 4/27/17 1:41 AM, Jesper Dangaard Brouer wrote:
When registering/attaching a XDP/bpf program, we would just send the
file-descriptor for this port-map along (like we do with the bpf_prog
FD). Plus, it own ingress-port number this program is in the port-map.
It is not clear to me, in-which-data
On 27/04/17 05:20 PM, Jason Gunthorpe wrote:
> It seems the most robust: test for iomem, and jump to a slow path
> copy, otherwise inline the kmap and memcpy
>
> Every place doing memcpy from sgl will need that pattern to be
> correct.
Ok, sounds like a good place to start to me. I'll see what
On Thu, Apr 27, 2017 at 05:03:45PM -0600, Logan Gunthorpe wrote:
>
>
> On 27/04/17 04:11 PM, Jason Gunthorpe wrote:
> > On Thu, Apr 27, 2017 at 03:53:37PM -0600, Logan Gunthorpe wrote:
> > Well, that is in the current form, with more users it would make sense
> > to optimize for the single page c
Paolo Abeni wrote:
>On slave list updates, the bonding driver computes its hard_header_len
>as the maximum of all enslaved devices's hard_header_len.
>If the slave list is empty, e.g. on last enslaved device removal,
>ETH_HLEN is used.
>
>Since the bonding header_ops are set only when the first e
On 27/04/17 04:11 PM, Jason Gunthorpe wrote:
> On Thu, Apr 27, 2017 at 03:53:37PM -0600, Logan Gunthorpe wrote:
> Well, that is in the current form, with more users it would make sense
> to optimize for the single page case, eg by providing the existing
> call, providing a faster single-page-only
On Thu, Apr 27, 2017 at 07:29:34PM +0200, Paolo Abeni wrote:
> On slave list updates, the bonding driver computes its hard_header_len
> as the maximum of all enslaved devices's hard_header_len.
> If the slave list is empty, e.g. on last enslaved device removal,
> ETH_HLEN is used.
>
> Since the bo
On 04/27/2017 03:28 PM, Florian Fainelli wrote:
> After commit 6d684e54690c ("rhashtable: Cap total number of
> entries to 2^31"), we would be hitting a panic() in net/core/rtnetlink.c
> during initialization. The call stack would look like this:
>
> register_pernet_subsys()
> ...
> ops->i
After commit 6d684e54690c ("rhashtable: Cap total number of
entries to 2^31"), we would be hitting a panic() in net/core/rtnetlink.c
during initialization. The call stack would look like this:
register_pernet_subsys()
...
ops->init()
rtnetlink_net_init()
netlink_kernel_cr
After commit 6d684e54690c ("rhashtable: Cap total number of
entries to 2^31"), we would be hitting a panic() in net/core/rtnetlink.c
during initialization. The call stack would look like this:
register_pernet_subsys()
...
ops->init()
rtnetlink_net_init()
netlink_kernel_cr
On 04/27/2017 02:16 PM, Florian Fainelli wrote:
> Hi Herbert,
>
> On 04/26/2017 10:44 PM, Herbert Xu wrote:
>> On Tue, Apr 25, 2017 at 10:48:22AM -0400, David Miller wrote:
>>> From: Florian Westphal
>>> Date: Tue, 25 Apr 2017 16:17:49 +0200
>>>
I'd have less of an issue with this if we'd be
On 27 April 2017 at 04:42, Steffen Klassert
wrote:
> On Wed, Apr 26, 2017 at 10:01:34PM -0700, Cong Wang wrote:
>> (Cc'ing netdev and IPSec maintainers)
>>
>> On Tue, Apr 25, 2017 at 6:08 PM, Don Bowman wrote:
for 'esp' question, i have ' esp = aes256-sha256-modp1536!' is that
what you mean?
its
On Thu, Apr 27, 2017 at 03:53:37PM -0600, Logan Gunthorpe wrote:
> On 27/04/17 02:53 PM, Jason Gunthorpe wrote:
> > blkfront is one of the drivers I looked at, and it appears to only be
> > memcpying with the bvec_data pointer, so I wonder why it does not use
> > sg_copy_X_buffer instead..
>
> But
On 27/04/17 02:53 PM, Jason Gunthorpe wrote:
> blkfront is one of the drivers I looked at, and it appears to only be
> memcpying with the bvec_data pointer, so I wonder why it does not use
> sg_copy_X_buffer instead..
Yes, sort of...
But you'd potentially end up calling sg_copy_to_buffer multip
Initialise init_net.count to 1 for its pointer from init_nsproxy lest
someone tries to do a get_net() and a put_net() in a process in which
current->ns_proxy->net_ns points to the initial network namespace.
Signed-off-by: David Howells
---
net/core/net_namespace.c |3 ++-
1 file changed, 2
Creating a geneve link with 'udpcsum' set results in a creation of link
for which UDP checksum will NOT be computed on outbound packets, as can
be seen below.
11: gen0: mtu 1500 qdisc noop state DOWN
link/ether c2:85:27:b6:b4:15 brd ff:ff:ff:ff:ff:ff promiscuity 0
geneve id 200 remote 192
From: Kalle Valo
Date: Thu, 27 Apr 2017 12:41:37 +0300
> here's a pull request for net-next, more info in the tag below. This
> should be the last pull request to net-next for 4.12. Please let me know
> if there are any problems.
Pulled, thanks Kalle.
Hi Herbert,
On 04/26/2017 10:44 PM, Herbert Xu wrote:
> On Tue, Apr 25, 2017 at 10:48:22AM -0400, David Miller wrote:
>> From: Florian Westphal
>> Date: Tue, 25 Apr 2017 16:17:49 +0200
>>
>>> I'd have less of an issue with this if we'd be talking about
>>> something computationally expensive, but
On Thu, Apr 27, 2017 at 03:36:59PM +0200, Hannes Frederic Sowa wrote:
> It would help a lot if you could pass the prog_id back during program
> creation, otherwise it will be kind of difficult to get a hold on which
> program is where. ;)
Thanks for your feedback :). Make sense. I will look into
On Thu, Apr 27, 2017 at 09:23:18AM +0200, Alexander Alemayhu wrote:
> On Wed, Apr 26, 2017 at 11:24:49PM -0700, Martin KaFai Lau wrote:
> > Add test to exercise the bpf_prog id generation
> > and iteration.
> >
> Could test_prog_id be a function in tools/testing/selftests/bpf/test_progs.c
> instead
Here is what I have after today's work. I think I sorted out the
endianness issues.
gas can be controlled explicitly using "-EB" and "-EL" options. The
default is whatever endianness the host has. The elf names for the
two variants are "elf64-bpfbe" and "elf64-bpfle".
I fleshed out all the re
RFC 2460 (IPv6) defines hop by hop options and destination options
extension headers. Both of these carry a list of TLVs which is
only limited by the maximum length of the extension header (2048
bytes). By the spec a host must process all the TLVs in these
options, however these could be used as a
On Thu, Apr 27, 2017 at 02:19:24PM -0600, Logan Gunthorpe wrote:
>
>
> On 26/04/17 01:37 AM, Roger Pau Monné wrote:
> > On Tue, Apr 25, 2017 at 12:21:02PM -0600, Logan Gunthorpe wrote:
> >> Straightforward conversion to the new helper, except due to the lack
> >> of error path, we have to use SG_
From: Sudarsana Reddy Kalluru
Date: Wed, 26 Apr 2017 09:00:48 -0700
> From: Sudarsana Reddy Kalluru
>
> The patch series contains set of enhancements for qed/qede ptp
> implementation.
> Patches (1)-(3) adds resource locking implementation to allow
> PTP functionality only on the first detecte
From: David Ahern
Date: Wed, 26 Apr 2017 07:58:22 -0700
> Moving the loopback into a VRF breaks networking for the default VRF.
> Since the VRF device is the loopback for VRF domains, there is no
> reason to move the loopback. Given the repercussions, block attempts
> to set lo into a VRF.
>
> S
Can you guys give me some kind of idea of how it might be nice to
represent calls and tailcalls in assembler files?
And also the emission of maps.
Right now I just have the assembler looking for 32-bit immediate
values for call and tailcall instructions.
Looking at samples/bpf/sockex3_kern.c we
From: Wei Yongjun
Date: Wed, 26 Apr 2017 14:03:50 +
> From: Wei Yongjun
>
> Fix to return error code -EINVAL from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 622ec2c9d524 ("net: core: add UID to flows, rules, and routes")
> Signed-off-by: Wei Yong
From: Mike Manning
Date: Wed, 26 Apr 2017 14:48:09 +0100
> Support for l2 multicast flood control was added in commit b6cb5ac8331b
> ("net: bridge: add per-port multicast flood flag"). It allows broadcast
> as it was introduced specifically for unknown multicast flood control.
> But as broadcast
| From: Bjorn Helgaas
| Sent: Thursday, April 27, 2017 10:19 AM
|
| Are you hinting that the PCI core or arch code could actually *enable*
| Relaxed Ordering without the driver doing anything? Is it safe to do that?
| Is there such a thing as a device that is capable of using RO, but where the
|
From: gfree.w...@foxmail.com
Date: Wed, 26 Apr 2017 19:04:04 +0800
> From: Gao Feng
>
> The func fib_flush already flushes the rt cache if necessary, so it
> is not necessary to invoke rt_cache_flush again in fib_disable_ip.
>
> Signed-off-by: Gao Feng
Looks good, applied to net-next, thanks!
From: Guillaume Nault
Date: Wed, 26 Apr 2017 11:54:47 +0200
> There's no need to verify that cfg->ifname is unique at this point.
> register_netdev() will return -EEXIST if asked to create a device with
> a name that's alrealy in use.
>
> Signed-off-by: Guillaume Nault
Yep that's right, applie
From: Zhang Shengju
Date: Wed, 26 Apr 2017 17:49:38 +0800
> Since netif_carrier_on() will do nothing if device's carrier is already
> on, so it's unnecessary to do carrier status check.
>
> It's the same for netif_carrier_off().
>
> Signed-off-by: Zhang Shengju
Applied, thank you.
Hi Marco,
[auto build test ERROR on net/master]
[also build test ERROR on v4.11-rc8]
[cannot apply to net-next/master next-20170427]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Marco
From: Zhang Shengju
Date: Wed, 26 Apr 2017 11:05:12 +0800
> This patch updates the comment for netif_dormant() function to reflect
> the intended usage.
>
> Signed-off-by: Zhang Shengju
Applied, thank you.
On 26/04/17 01:37 AM, Roger Pau Monné wrote:
> On Tue, Apr 25, 2017 at 12:21:02PM -0600, Logan Gunthorpe wrote:
>> Straightforward conversion to the new helper, except due to the lack
>> of error path, we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in
>> certain cases in the future.
>>
>> S
On Wed, Apr 26, 2017 at 11:53:29AM -0400, Vivien Didelot wrote:
> Now that the code reads both VTU and STU data on VTU GetNext operation,
> fetch the STU entry data of a VTU entry at the same time.
>
> The STU data bits are masked with the VTU data bits and they are now all
> read at the same time
On 26/04/17 01:44 AM, Christoph Hellwig wrote:
> I think we'll at least need a draft of those to make sense of these
> patches. Otherwise they just look very clumsy.
Ok, what follows is a draft patch attempting to show where I'm thinking
of going with this. Obviously it will not compile because
On 4/27/17 1:43 PM, Vlad Yasevich wrote:
>> For example, NETDEV_CHANGEINFODATA is only for bonds though nothing
>> about the name suggests it is a bonding notification. This one was added
>> specifically to notify userspace (d4261e5650004), yet seems to happen
>> only during a changelink and that a
On 04/24/2017 11:14 AM, Roopa Prabhu wrote:
> On Sun, Apr 23, 2017 at 6:07 PM, David Ahern wrote:
>>
>> On 4/21/17 11:31 AM, Vladislav Yasevich wrote:
>>> @@ -1276,9 +1277,40 @@ static int rtnl_xdp_fill(struct sk_buff *skb, struct
>>> net_device *dev)
>>> return err;
>>> }
>>>
>>> +static
On Wed, Apr 26, 2017 at 11:53:28AM -0400, Vivien Didelot wrote:
> Extract the generic portion of code to issue an STU GetNext operation,
> which will be used in other implementations.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Andrew
On 04/23/2017 09:07 PM, David Ahern wrote:
> On 4/21/17 11:31 AM, Vladislav Yasevich wrote:
>> @@ -1276,9 +1277,40 @@ static int rtnl_xdp_fill(struct sk_buff *skb, struct
>> net_device *dev)
>> return err;
>> }
>>
>> +static int rtnl_fill_link_event(struct sk_buff *skb, unsigned long event
The message "Cannot bind port X, err=Y" creates only confusion. In metadata
based mode, failure of IPv6 socket creation is okay if IPv6 is disabled and
no error message should be printed. But when IPv6 tunnel was requested, such
failure is fatal. The vxlan_socket_create does not know when the error
When IPv6 is compiled but disabled at runtime, __vxlan_sock_add returns
-EAFNOSUPPORT. For metadata based tunnels, this causes failure of the whole
operation of bringing up the tunnel.
Ignore failure of IPv6 socket creation for metadata based tunnels caused by
IPv6 not being available.
Fixes: b1b
This patchset fixes a bug with metadata based tunnels when booted with
ipv6.disable=1.
Jiri Benc (2):
vxlan: correctly handle ipv6.disable module parameter
vxlan: do not output confusing error message
drivers/net/vxlan.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
--
On 04/21/2017 02:08 PM, David Ahern wrote:
> On 4/21/17 11:31 AM, Vladislav Yasevich wrote:
>> The data signaling name change is already provided at
>> the end of do_setlink(). This event handler just generates
>> a duplicate announcement. Disable it.
>>
>> CC: David Ahern
>> Signed-off-by: Vlad
On Thu, Apr 27, 2017 at 7:51 AM, Marco Chiappero
wrote:
> Currently every slave device gets assigned the same MAC address, by
> having it copied from the master interface. Since some code paths
> depend on this identity, changing the MAC address on slave interfaces
> is not supported. However iden
On Wed, Apr 26, 2017 at 11:53:27AM -0400, Vivien Didelot wrote:
> The code to access the VTU Data registers currently only supports the
> 88E6185 family and alike: 2-bit membership adjacent to 2-bit port state.
>
> Even though the 88E6352 family introduced an indirect table to program
> the VLAN S
The new wake function is only used by the suspend/resume handlers that
are defined in inside of an #ifdef, which can cause this harmless
warning:
drivers/net/ethernet/intel/igb/igb_main.c:7988:13: warning:
'igb_deliver_wake_packet' defined but not used [-Wunused-function]
Removing the #ifdef, in
Thanks for adding me to the Cc list Bjorn. Hopefully my message will make
it out to the netdev and linux-pci lists -- I'm not currently subscribed to
them. I've explicitly marked this message to be sent in plain text but
modern email agents suck with respect to this. (sigh) I have officially
be
On Wed, Apr 26, 2017 at 11:53:26AM -0400, Vivien Didelot wrote:
> Even though every switch model has a different way to access the VTU
> Data bits, the base implementation of the VTU GetNext operation remains
> the same: wait, write the first VID to iterate from, start the
> operation, and read the
> @@ -1464,13 +1457,16 @@ static int _mv88e6xxx_vtu_loadpurge(struct
> mv88e6xxx_chip *chip,
> struct mv88e6xxx_vtu_entry *entry)
> {
> u16 op = GLOBAL_VTU_OP_VTU_LOAD_PURGE;
> - u16 reg = 0;
> int err;
>
> err = mv88e6xxx_g1_vtu_op_wait(c
On Wed, Apr 26, 2017 at 1:08 PM, Andrey Konovalov wrote:
> On Wed, Apr 26, 2017 at 6:07 PM, Eric Dumazet wrote:
>> From: Eric Dumazet
>>
>> Andrey found a way to trigger the WARN_ON_ONCE(delta < len) in
>> skb_try_coalesce() using syzkaller and a filter attached to a TCP
>> socket.
>>
>> As we d
On Wed, Apr 26, 2017 at 11:53:24AM -0400, Vivien Didelot wrote:
> Add helpers to access the VTU SID register in the global1_vtu.c file.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Andrew
On Wed, Apr 26, 2017 at 11:53:23AM -0400, Vivien Didelot wrote:
> Add helpers to access the VTU FID register in the global1_vtu.c file.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Andrew
On Wed, Apr 26, 2017 at 11:53:22AM -0400, Vivien Didelot wrote:
> Move the VTU flush operation to global1_vtu.c and call it from a
> mv88e6xxx_vtu_setup helper, similarly to the ATU and PVT setup.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Andrew
1 - 100 of 230 matches
Mail list logo
