On 4/20/2017 00:15, Florian Fainelli wrote:
On 04/19/2017 01:52 AM, Neftin, Sasha wrote:
On 4/18/2017 22:05, Florian Fainelli wrote:
On 04/18/2017 12:03 PM, Eric Dumazet wrote:
On Tue, 2017-04-18 at 11:18 -0700, Florian Fainelli wrote:
Hi,
I am using NFS over a NAT with two e1000e adapters a
Function nla_nest_start() will return a NULL pointer on error, and its
return value should be validated before it is used. However, in function
queue_userspace_packet(), its return value is ignored. This may result
in NULL dereference when calling nla_nest_end(). This patch fixes the
bug.
Signed-o
Function nla_nest_start() may return a NULL pointer on error. However,
in function lwtunnel_fill_encap(), the return value of nla_nest_start()
is not validated before it is used. This patch checks the return value
of nla_nest_start() against NULL.
Signed-off-by: Pan Bian
---
net/core/lwtunnel.c
On Sat, 22 Apr 2017 20:40:22 -0700, John Fastabend wrote:
> >> @@ -9557,7 +9739,21 @@ static int ixgbe_xdp_setup(struct net_device *dev,
> >> struct bpf_prog *prog)
> >>return -EINVAL;
> >>}
> >>
> >> + if (nr_cpu_ids > MAX_XDP_QUEUES)
> >> + return -ENOMEM;
> >
On 17-04-21 11:18 AM, David Miller wrote:
> From: Jeff Kirsher
> Date: Thu, 20 Apr 2017 18:50:18 -0700
>
>> John adds XDP support (yeah!) for ixgbe.
>
> As excited and eager as I am about this, I want to see the build regression
> for PAGE_SIZE>=8192 fixed before I pull this.
>
> Thanks.
>
Da
On 17-04-22 07:24 PM, Jakub Kicinski wrote:
> On Thu, 20 Apr 2017 18:50:21 -0700, Jeff Kirsher wrote:
>> +static int ixgbe_xdp_queues(struct ixgbe_adapter *adapter)
>> +{
>> +if (nr_cpu_ids > MAX_XDP_QUEUES)
>> +return 0;
>> +
>> +return adapter->xdp_prog ? nr_cpu_ids : 0;
>> +}
The code refreshing the eth port state was trying to update state
of all ports of the card. Unfortunately to safely walk the port
list we would have to hold the port lock, which we can't due to
lock ordering constraints against rtnl.
Make the per-port sync refresh and async refresh of all ports
c
From: David Brunecz
Retrieve identifying information from the NSP. For now it only
contains versions of firmware subcomponents.
Signed-off-by: David Brunecz
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/Makefile| 1 +
drivers/net/ethernet/netronome/nfp/nfp_mai
Hi!
This series takes advantage of Alex's DMA_ATTR_SKIP_CPU_SYNC to make
XDP packet modifications "correct" from DMA API point of view. It
also allows us to parse the metadata before we run XDP at no additional
DMA sync cost. That way we can get rid of the metadata memcpy, and
remove the last
DMA unmap may destroy changes CPU made to the buffer. To make XDP
run correctly on non-x86 platforms we should use the
DMA_ATTR_SKIP_CPU_SYNC attribute.
Thanks to using the attribute we can now push the sync operation to the
common code path from XDP handler.
A little bit of variable name reshuf
Calling memcpy to shift metadata out of the way for XDP to run
seems like an overkill. The most common metadata contents are
8 bytes containing type and flow hash. Simply parse the metadata
before we run XDP.
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/nfp_net.h
XDP headroom should not be included in free list buffer size.
Fixes: 6fe0c3b43804 ("nfp: add support for xdp_adjust_head()")
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/ne
On Sat, Apr 22, 2017 at 07:12:34PM -0600, David Ahern wrote:
> On 4/22/17 4:00 PM, Martin KaFai Lau wrote:
> > On Sat, Apr 22, 2017 at 09:40:37AM -0700, David Ahern wrote:
> > [...]
> >> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> >> index 08f9e8ea7a81..97e86158bbcb 100644
> >> --- a/n
On Thu, 20 Apr 2017 18:50:21 -0700, Jeff Kirsher wrote:
> +static int ixgbe_xdp_queues(struct ixgbe_adapter *adapter)
> +{
> + if (nr_cpu_ids > MAX_XDP_QUEUES)
> + return 0;
> +
> + return adapter->xdp_prog ? nr_cpu_ids : 0;
> +}
Nit: AFAICT ixgbe_xdp_setup() will guarantee xdp
On 4/22/17 4:00 PM, Martin KaFai Lau wrote:
> On Sat, Apr 22, 2017 at 09:40:37AM -0700, David Ahern wrote:
> [...]
>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
>> index 08f9e8ea7a81..97e86158bbcb 100644
>> --- a/net/ipv6/addrconf.c
>> +++ b/net/ipv6/addrconf.c
>> @@ -3303,14 +3303,24 @
On Sat, Apr 22, 2017 at 09:40:37AM -0700, David Ahern wrote:
[...]
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 08f9e8ea7a81..97e86158bbcb 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -3303,14 +3303,24 @@ static void addrconf_gre_config(struct net_device
Add support to the tc flower classifier to match based on fields in MPLS
labels (TTL, Bottom of Stack, TC field, Label).
Signed-off-by: Benjamin LaHaise
Signed-off-by: Benjamin LaHaise
Reviewed-by: Jakub Kicinski
Cc: "David S. Miller"
Cc: Simon Horman
Cc: Jamal Hadi Salim
Cc: Cong Wang
Cc:
From: Benjamin LaHaise
This patch series adds support for parsing MPLS flows in the flow dissector
and the flower classifier. Each of the MPLS TTL, BOS, TC and Label fields
can be used for matching.
v2: incorporate style feedback, move #defines to linux/include/mpls.h
Note: this omits Jiri's re
Add support for parsing MPLS flows to the flow dissector in preparation for
adding MPLS match support to cls_flower.
Signed-off-by: Benjamin LaHaise
Signed-off-by: Benjamin LaHaise
Reviewed-by: Jakub Kicinski
Cc: "David S. Miller"
Cc: Simon Horman
Cc: Jamal Hadi Salim
Cc: Cong Wang
Cc: Jiri
On 04/22/2017 10:02 PM, David Miller wrote:
From: Daniel Borkmann
Date: Sat, 22 Apr 2017 21:46:46 +0200
On 04/22/2017 09:38 PM, David Miller wrote:
Signed-off-by: David S. Miller
LGTM, thanks!
Acked-by: Daniel Borkmann
Great, this and the sparc64 eBPF JIT are now pushed out to net-nex
On 17-04-22 12:54 PM, Stephen Hemminger wrote:
On Sat, 22 Apr 2017 12:43:50 -0400
Jamal Hadi Salim wrote:
On 17-04-22 12:18 PM, Daniel Borkmann wrote:
[..]
Anything I'm missing?
Let me get back to that machine (couple of hours) and try to see how i
created the issue.
Shouldve cutnpasted t
From: Daniel Borkmann
Date: Sat, 22 Apr 2017 21:46:46 +0200
> On 04/22/2017 09:38 PM, David Miller wrote:
>>
>> Signed-off-by: David S. Miller
>
> LGTM, thanks!
>
> Acked-by: Daniel Borkmann
Great, this and the sparc64 eBPF JIT are now pushed out to net-next.
On 04/22/2017 09:38 PM, David Miller wrote:
Signed-off-by: David S. Miller
LGTM, thanks!
Acked-by: Daniel Borkmann
Alexei, that unconditional -D__x86_64__ isn't going to work. It in
fact makes the build break on sparc because the types.h asm headers
explicitly check for things like __sparc__ && __arch64__ etc.
There are other places that want stuff like this, so let's do it
right.
In every
arch/${A
Signed-off-by: David S. Miller
---
samples/bpf/bpf_helpers.h | 19 +++
tools/build/feature/test-bpf.c | 3 +++
tools/lib/bpf/bpf.c| 2 ++
3 files changed, 24 insertions(+)
diff --git a/samples/bpf/bpf_helpers.h b/samples/bpf/bpf_helpers.h
index 52de9d8..9a9c95
Alexey Khoroshilov :
[...]
> diff --git a/drivers/net/ethernet/natsemi/ns83820.c
> b/drivers/net/ethernet/natsemi/ns83820.c
> index 729095db3e08..dfc64e1e31f9 100644
> --- a/drivers/net/ethernet/natsemi/ns83820.c
> +++ b/drivers/net/ethernet/natsemi/ns83820.c
[...]
> @@ -1183,6 +1193,32 @@ static
From: Roi Dayan
Implement the devlink e-switch encapsulation control set and get
callbacks. Apply the value set by the user on the switchdev offloads
mode when creating the fast FDB table where offloaded rules will be set.
Signed-off-by: Roi Dayan
Reviewed-by: Or Gerlitz
Signed-off-by: Saeed M
From: Or Gerlitz
Refactor the creation of the fast path FDB table that holds the
offloaded rules in SRIOV switchdev mode into it's own function.
This will be used in the next patch to be able and re-create the
table under different settings without going through legacy mode.
This patch doesn't
Hi Dave,
This series contains some updates to mlx5 driver.
Sparse and compiler warnings fixes from Stephen Hemminger.
>From Roi Dayan and Or Gerlitz, Add devlink and mlx5 support for controlling
E-Switch encapsulation mode, this knob will enable HW support for applying
encapsulation/decapsulatio
From: Stephen Hemminger
Fix sparse warnings in recent ipoib support.
The RDMA functions are not used yet, hide behind #ifdef.
Based on comment, they will eventually be local so make static.
Signed-off-by: Stephen Hemminger
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/c
From: Stephen Hemminger
Fix sparse warning about missing prototypes. The rx/tx code path
defines functions with prototypes in ipoib.h.
Signed-off-by: Stephen Hemminger
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 1 +
drivers/net/ethernet/mellanox/mlx5/c
From: Roi Dayan
This is an e-switch global knob to enable HW support for applying
encapsulation/decapsulation to VF traffic as part of SRIOV e-switch offloading.
The actual encap/decap is carried out (along with the matching and other
actions)
per offloaded e-switch rules, e.g as done when offl
From: Alexei Starovoitov
Date: Sat, 22 Apr 2017 08:32:35 -0700
> On Fri, Apr 21, 2017 at 08:17:11PM -0700, David Miller wrote:
>>
>> This is an eBPF JIT for sparc64. All major features are supported.
>>
>> All tests under tools/testing/selftests/bpf/ pass.
>>
>> Signed-off-by: David S. Miller
On Fri, Apr 14, 2017 at 12:55:52AM -0500, Larry Finger wrote:
> These files were supplied by Realtek.
>
> Signed-off-by: Larry Finger
Applied, thanks Larry.
--Kyle
On Sat, Apr 22, 2017 at 1:56 PM, Maksim Salau wrote:
> Allocate buffer on HEAP instead of STACK for a local structure
> that is to be sent using usb_control_msg().
>
> Signed-off-by: Maksim Salau
> ---
> drivers/net/can/usb/gs_usb.c | 17 -
> 1 file changed, 12 insertions(+), 5 d
Hello,
On Wed, 12 Apr 2017, Nick Moriarty wrote:
> Hi,
>
> I've experienced a problem in how traffic returning to an LVS host is
> handled in certain circumstances. Please find a bug report below - if
> there's any further information you'd like, please let me know.
>
> [1.] One line
Allocate buffer on HEAP instead of STACK for a local variable
that is to be sent using usb_control_msg().
Signed-off-by: Maksim Salau
---
drivers/net/wireless/intersil/orinoco/orinoco_usb.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wir
Allocate buffer on HEAP instead of STACK for a local structure
that is to be sent using usb_control_msg().
Signed-off-by: Maksim Salau
---
drivers/net/can/usb/gs_usb.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/ne
On Sat, 22 Apr 2017 12:43:50 -0400
Jamal Hadi Salim wrote:
> On 17-04-22 12:18 PM, Daniel Borkmann wrote:
> [..]
> >
> > Anything I'm missing?
>
>
> Let me get back to that machine (couple of hours) and try to see how i
> created the issue.
> Shouldve cutnpasted the error msg. Cant create it
Begin forwarded message:
Date: Sat, 22 Apr 2017 14:49:46 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 195495] New: unchecked return value of nla_nest_start() in
function lwtunnel_fill_encap()
https://bugzilla.kernel.org/show_bug.cgi?id=195495
Begin forwarded message:
Date: Sat, 22 Apr 2017 14:56:25 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 195503] New: tipc: unchecked return value of nlmsg_new() in
function tipc_nl_node_get_monitor()
https://bugzilla.kernel.org/show_bug.cgi?id=195
Begin forwarded message:
Date: Sat, 22 Apr 2017 14:52:46 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 195497] New: openvswitch: unchecked return value of
nla_nest_start() in function queue_userspace_packet()
https://bugzilla.kernel.org/show_bug.
On 17-04-22 12:18 PM, Daniel Borkmann wrote:
[..]
Anything I'm missing?
Let me get back to that machine (couple of hours) and try to see how i
created the issue.
Shouldve cutnpasted the error msg. Cant create it on this laptop.
cheers,
jamal
Taking down the loopback device wreaks havoc on IPv6 routes. By
extension, taking a VRF device wreaks havoc on its table.
Dmitry and Andrey both reported heap out-of-bounds reports in the IPv6
FIB code while running syzkaller fuzzer. The root cause is a dead dst
that is on the garbage list gets re
systemd-sysctl is triggering a suspicious RCU usage message when
net.ipv4.tcp_early_demux or net.ipv4.udp_early_demux is changed via
a sysctl config file:
[ 33.896184] ===
[ 33.899558] [ ERR: suspicious RCU usage. ]
[ 33.900624] 4.11.0-rc7+ #104 Not tainted
[ 3
On 04/22/2017 05:00 PM, Daniel Borkmann wrote:
On 04/22/2017 02:31 PM, Jamal Hadi Salim wrote:
I dont think is a kernel uapi - but it was failing compiling
when HAVE_ELF is false.
-
jhs@jhs-UX:~/git-trees/others/iproute-with-ck$ git diff include/bpf_util.h
diff --git a/include/bpf_util.h b/
When arp_notify is set to 1 for either a specific interface or for 'all'
interfaces, gratuitous arp requests are sent. Since ndisc_notify is the
ipv6 equivalent to arp_notify, it should follow the same semantics.
Commit 4a6e3c5def13 ("net: ipv6: send unsolicited NA on admin up") sends
the NA on adm
On Sat, 2017-04-22 at 19:43 +0530, prashantkumar dhotre wrote:
> I am observing that max netlink msg that my kernel module can send to
> user app is close to 16K.
>
> For larger sizes, genlmsg_unicast() succeeds but my app does not receive data.
>
> I have tried increasing RECV buffer size in my
On Fri, Apr 21, 2017 at 08:17:11PM -0700, David Miller wrote:
>
> This is an eBPF JIT for sparc64. All major features are supported.
>
> All tests under tools/testing/selftests/bpf/ pass.
>
> Signed-off-by: David S. Miller
...
> + /* tail call */
> + case BPF_JMP | BPF_CALL |BPF_X:
> +
On 04/22/2017 02:31 PM, Jamal Hadi Salim wrote:
I dont think is a kernel uapi - but it was failing compiling
when HAVE_ELF is false.
-
jhs@jhs-UX:~/git-trees/others/iproute-with-ck$ git diff include/bpf_util.h
diff --git a/include/bpf_util.h b/include/bpf_util.h
index 5361dab..edca339 100644
On 4/22/17 3:14 AM, Dmitry Vyukov wrote:
>> One small question. Why cmpxchg is needed instead
>> of a ip6_rt_put() and then assign?
>> Is it fixing another bug?
> cmpxchg here looks fishy.
> If there are no concurrent modifications, then it is not needed.
> If there are and cmpxchg fails, then we
I am observing that max netlink msg that my kernel module can send to
user app is close to 16K.
For larger sizes, genlmsg_unicast() succeeds but my app does not receive data.
I have tried increasing RECV buffer size in my user app but that does not help.
Regards
From: Colin Ian King
trivial fix to spelling mistake in dbg_dbg message
Signed-off-by: Colin Ian King
---
drivers/net/wireless/intersil/orinoco/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intersil/orinoco/main.c
b/drivers/net/wireless/inters
Hi Dave,
Here are some more Bluetooth patches (and one 802.15.4 patch) in the
bluetooth-next tree targeting the 4.12 kernel. Most of them are pure
fixes.
Please let me know if there are any issues pulling. Thanks.
Johan
---
The following changes since commit fb796707d7a6c9b24fdf80b9b4f24fa5ffcf
The driver does not check if mapping dma memory succeed.
The patch adds the checks and failure handling.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
---
drivers/net/ethernet/natsemi/ns83820.c | 42 +++---
1 file ch
From: Jamal Hadi Salim
Make use of 128b user cookies
Introduce optional 128-bit action cookie.
Like all other cookie schemes in the networking world (eg in protocols
like http or existing kernel fib protocol field, etc) the idea is to
save user state that when retrieved serves as a correlator. T
I dont think is a kernel uapi - but it was failing compiling
when HAVE_ELF is false.
-
jhs@jhs-UX:~/git-trees/others/iproute-with-ck$ git diff include/bpf_util.h
diff --git a/include/bpf_util.h b/include/bpf_util.h
index 5361dab..edca339 100644
--- a/include/bpf_util.h
+++ b/include/bpf_util.
-macro-name-for-page-select-register/20170422-144641
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget
https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin
From: Colin Ian King
Trivial fix to spelling mistake in dev_err message and rejoin
line.
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/ti/netcp_ethss.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/netcp_ethss.c
b/drivers/net/ethernet/t
Paul Menzel :
[...]
> The ASRock E350M1 has a Realtek ethernet controller.
>
> It takes almost three seconds for the link to become ready. This is
> noticeable after resume from suspend, where the user wants to continue
> working but first has to wait for the network.
>
> This test is done with
On Sat, Apr 22, 2017 at 12:53 AM, David Miller wrote:
> From: Jamie Bainbridge
> Date: Fri, 21 Apr 2017 21:18:00 +1000
>
>> I cannot see the use in delivering a skb with zero bytes after the
>> network header to a raw socket.
>
> Then it cannot be used to look at zero length UDP packets, which ar
On 17-04-21 02:11 PM, Jamal Hadi Salim wrote:
Please bear with me. I want to make sure to get this right.
Lets say I updated the kernel today to reject transactions with
bits it didnt understand. Lets call this "old kernel". A tc that
understands/sets these bits and nothing else. Call it "old t
Hello,
On Thu, 20 Apr 2017, Paolo Abeni wrote:
> When creating a new ipvs service, ipv6 addresses are always accepted
> if CONFIG_IP_VS_IPV6 is enabled. On dest creation the address family
> is not explicitly checked.
>
> This allows the user-space to configure ipvs services even if the
If skb_put_padto() fails then it frees the skb. I shifted that code
up a bit to make my error handling a little simpler.
Fixes: a0d2f20650e8 ("Renesas Ethernet AVB PTP clock driver")
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/ethernet/renesas/ravb_main.c
b/drivers/net/ethernet/renes
Dear Linux folks,
The ASRock E350M1 has a Realtek ethernet controller.
It takes almost three seconds for the link to become ready. This is
noticeable after resume from suspend, where the user wants to continue
working but first has to wait for the network.
This test is done with Linux 4.10.
``
On Sat, Apr 22, 2017 at 3:07 AM, Saeed Mahameed
wrote:
> On Sat, Apr 22, 2017 at 3:47 AM, Ian Kumlien wrote:
>> On Sat, Apr 22, 2017 at 2:34 AM, Saeed Mahameed
>> wrote:
>>> On Sat, Apr 22, 2017 at 2:10 AM, Ian Kumlien wrote:
Sorry,
Back again, fighting cold, hot whiskey has been
On Sat, Apr 22, 2017 at 7:57 AM, Martin KaFai Lau wrote:
> On Fri, Apr 21, 2017 at 04:40:30PM -0700, David Ahern wrote:
>> Taking down the loopback device wreaks havoc on IPv6 routes. By
>> extension, taking a VRF device wreaks havoc on its table.
>>
>> Dmitry and Andrey both reported heap out-of-
-macro-name-for-page-select-register/20170422-144641
config: i386-randconfig-x070-201716 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drive
68 matches
Mail list logo
