RE: [PATCH v4 11/19] scsi: megaraid: Replace PCI pool old API

2017-03-01 Thread Sumit Saxena
>-Original Message- >From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- >ow...@vger.kernel.org] On Behalf Of Romain Perier >Sent: Wednesday, March 01, 2017 9:25 PM >To: Dan Williams; Doug Ledford; Sean Hefty; Hal Rosenstock; >jeffrey.t.kirs...@intel.com; David S. Miller; stas.yakov.

[PULL] vhost: cleanups and fixes

2017-03-01 Thread Michael S. Tsirkin
The following changes since commit c470abd4fde40ea6a0846a2beab642a578c0b8cd: Linux 4.10 (2017-02-19 14:34:00 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to c4baad50297d84bde1a7ad45e50c7

Re: [PATCH v4] net: don't call strlen() on the user buffer in packet_bind_spkt()

2017-03-01 Thread David Miller
From: Alexander Potapenko Date: Wed, 1 Mar 2017 12:57:20 +0100 > KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of > uninitialized memory in packet_bind_spkt(): ... > This happens because addr.sa_data copied from the userspace is not > zero-terminated, and copying it with

Re: [PATCH v2] net: bridge: allow IPv6 when multicast flood is disabled

2017-03-01 Thread David Miller
From: Mike Manning Date: Wed, 1 Mar 2017 09:55:28 + > Even with multicast flooding turned off, IPv6 ND should still work so > that IPv6 connectivity is provided. Allow this by continuing to flood > multicast traffic originated by us. > > Fixes: b6cb5ac8331b ("net: bridge: add per-port multic

Re: net: use-after-free in neigh_timer_handler/sock_wfree

2017-03-01 Thread Eric Dumazet
On Wed, Mar 1, 2017 at 9:25 PM, Cong Wang wrote: > On Wed, Mar 1, 2017 at 3:15 PM, Eric Dumazet wrote: >> On Wed, Mar 1, 2017 at 3:09 PM, Cong Wang wrote: >> >>> >>> But I doubt skb_orphan() is the solution here, shouldn't we just >>> update sk->sk_wmem_alloc with skb->truesize changes? >> >> Is

Re: net: use-after-free in neigh_timer_handler/sock_wfree

2017-03-01 Thread Cong Wang
On Wed, Mar 1, 2017 at 3:15 PM, Eric Dumazet wrote: > On Wed, Mar 1, 2017 at 3:09 PM, Cong Wang wrote: > >> >> But I doubt skb_orphan() is the solution here, shouldn't we just >> update sk->sk_wmem_alloc with skb->truesize changes? > > Is it worth it ? Apart from syszkaller I mean... > > We start

Re: [PATCH v4] net: don't call strlen() on the user buffer in packet_bind_spkt()

2017-03-01 Thread Cong Wang
On Wed, Mar 1, 2017 at 3:57 AM, Alexander Potapenko wrote: > This happens because addr.sa_data copied from the userspace is not > zero-terminated, and copying it with strlcpy() in packet_bind_spkt() > results in calling strlen() on the kernel copy of that non-terminated > buffer. Very similar to

Re: [Patch net v3] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-03-01 Thread David Ahern
On 3/1/17 4:42 PM, Martin KaFai Lau wrote: > On Wed, Mar 01, 2017 at 04:07:38PM -0800, David Ahern wrote: >> On 3/1/17 3:16 PM, Martin KaFai Lau wrote: >>> [ An unrelated topic. I wonder ip -6 r del xyz::/0 would delete >>> the gateway route...] >> >> a very related question ... >> >> ip -6 r de

Re: [Patch net v2] ipv6: ignore null_entry in inet6_rtm_getroute() too

2017-03-01 Thread David Ahern
On 3/1/17 8:48 PM, Cong Wang wrote: > Like commit 1f17e2f2c8a8 ("net: ipv6: ignore null_entry on route dumps"), > we need to ignore null entry in inet6_rtm_getroute() too. > > Return -ENETUNREACH here to sync with IPv4 behavior, as suggested by David. > > Fixes: a1a22c1206 ("net: ipv6: Keep nexth

[Patch net v2] ipv6: ignore null_entry in inet6_rtm_getroute() too

2017-03-01 Thread Cong Wang
Like commit 1f17e2f2c8a8 ("net: ipv6: ignore null_entry on route dumps"), we need to ignore null entry in inet6_rtm_getroute() too. Return -ENETUNREACH here to sync with IPv4 behavior, as suggested by David. Fixes: a1a22c1206 ("net: ipv6: Keep nexthop of multipath route on admin down") Reported-b

[PATCH v1] qed: Fix copy of uninitialized memory

2017-03-01 Thread Robert Foss
In qed_ll2_start_ooo() the ll2_info variable is uninitialized and then passed to qed_ll2_acquire_connection() where it is copied into a new memory space. This shouldn't cause any issue as long as non of the copied memory is every read. But the potential for a bug being introduced by reading this m

[PATCH net] net: net_enable_timestamp() can be called from irq contexts

2017-03-01 Thread Eric Dumazet
From: Eric Dumazet It is now very clear that silly TCP listeners might play with enabling/disabling timestamping while new children are added to their accept queue. Meaning net_enable_timestamp() can be called from BH context while current state of the static key is not enabled. Lets play safe

Re: [PATCH v5 06/10] seccomp,landlock: Handle Landlock events per process hierarchy

2017-03-01 Thread Andy Lutomirski
On Wed, Mar 1, 2017 at 2:14 PM, Mickaël Salaün wrote: > > On 28/02/2017 21:01, Andy Lutomirski wrote: >> On Tue, Feb 21, 2017 at 5:26 PM, Mickaël Salaün wrote: >>> The seccomp(2) syscall can be use to apply a Landlock rule to the >>> current process. As with a seccomp filter, the Landlock rule is

Re: [Patch net v3] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-03-01 Thread Martin KaFai Lau
On Wed, Mar 01, 2017 at 04:07:38PM -0800, David Ahern wrote: > On 3/1/17 3:16 PM, Martin KaFai Lau wrote: > > [ An unrelated topic. I wonder ip -6 r del xyz::/0 would delete > > the gateway route...] > > a very related question ... > > ip -6 r del x::/0 comes down to the kernel as delete '::/0'

[PATCH] drivers: net: ethernet: remove incorrect __exit markups

2017-03-01 Thread Dmitry Torokhov
Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitr

net: sleeping function called from invalid context in net_enable_timestamp

2017-03-01 Thread Dmitry Vyukov
Hello, I've got the following report while running syzkaller fuzzer on e5d56efc97f8240d0b5d66c03949382b6d7e5570: BUG: sleeping function called from invalid context at kernel/locking/mutex.c:745 in_atomic(): 1, irqs_disabled(): 0, pid: 23233, name: syz-executor5 INFO: lockdep is turned off. CPU: 1

[PATCH net] tcp: fix potential double free issue for fastopen_req

2017-03-01 Thread Wei Wang
From: Wei Wang tp->fastopen_req could potentially be double freed if a malicious user does the following: 1. Enable TCP_FASTOPEN_CONNECT sockopt and do a connect() on the socket. 2. Call connect() with AF_UNSPEC to disconnect the socket. 3. Make this socket a listening socket by calling listen().

Re: [Patch net v3] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-03-01 Thread David Ahern
On 3/1/17 3:16 PM, Martin KaFai Lau wrote: > [ An unrelated topic. I wonder ip -6 r del xyz::/0 would delete > the gateway route...] a very related question ... ip -6 r del x::/0 comes down to the kernel as delete '::/0' (plen is 0, so cfg->fc_dst is 0). It ends up on the null_entry from fib6_

Re: [PATCH net] ipv6: orphan skbs in reassembly unit

2017-03-01 Thread Joe Stringer
On 1 March 2017 at 14:45, Eric Dumazet wrote: > From: Eric Dumazet > > Andrey reported a use-after-free in IPv6 stack. > > Issue here is that we free the socket while it still has skb > in TX path and in some queues. > > It happens here because IPv6 reassembly unit messes skb->truesize, > breakin

Re: net: use-after-free in neigh_timer_handler/sock_wfree

2017-03-01 Thread Eric Dumazet
On Wed, Mar 1, 2017 at 1:43 PM, Cong Wang wrote: >> >> This one looks very similar to a previous one: >> https://groups.google.com/forum/#!topic/syzkaller/BhyN5OFd7sQ >> >> Both happen on raw v6 sockets. >> >> For me, it seems the sk refcnt is not correct, skb should still hold >> a refcnt so it s

Re: net: use-after-free in neigh_timer_handler/sock_wfree

2017-03-01 Thread Cong Wang
On Wed, Mar 1, 2017 at 1:54 PM, Eric Dumazet wrote: > On Wed, Mar 1, 2017 at 1:43 PM, Cong Wang wrote: >>> >>> This one looks very similar to a previous one: >>> https://groups.google.com/forum/#!topic/syzkaller/BhyN5OFd7sQ >>> >>> Both happen on raw v6 sockets. >>> >>> For me, it seems the sk re

Re: [PATCH v5 06/10] seccomp,landlock: Handle Landlock events per process hierarchy

2017-03-01 Thread Mickaël Salaün
On 01/03/2017 23:20, Andy Lutomirski wrote: > On Wed, Mar 1, 2017 at 2:14 PM, Mickaël Salaün wrote: >> >> On 28/02/2017 21:01, Andy Lutomirski wrote: >>> On Tue, Feb 21, 2017 at 5:26 PM, Mickaël Salaün wrote: The seccomp(2) syscall can be use to apply a Landlock rule to the current pr

Re: [PATCH net] tcp/dccp: block BH for SYN processing

2017-03-01 Thread David Miller
From: Eric Dumazet Date: Wed, 01 Mar 2017 08:39:49 -0800 > From: Eric Dumazet > > SYN processing really was meant to be handled from BH. > > When I got rid of BH blocking while processing socket backlog > in commit 5413d1babe8f ("net: do not block BH while processing socket > backlog"), I forg

Re: [Patch net v3] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-03-01 Thread David Ahern
On 3/1/17 3:16 PM, Martin KaFai Lau wrote: > On Mon, Feb 27, 2017 at 04:14:04PM -0800, David Ahern wrote: >> On 2/27/17 4:07 PM, Cong Wang wrote: >>> Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() >>> -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is >>> because ip6_n

Re: net: use-after-free in neigh_timer_handler/sock_wfree

2017-03-01 Thread Eric Dumazet
On Wed, Mar 1, 2017 at 3:09 PM, Cong Wang wrote: > > But I doubt skb_orphan() is the solution here, shouldn't we just > update sk->sk_wmem_alloc with skb->truesize changes? Is it worth it ? Apart from syszkaller I mean... We started with something that had a real impact on real workloads. 158f

Re: [Patch net v3] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-03-01 Thread Martin KaFai Lau
On Mon, Feb 27, 2017 at 04:14:04PM -0800, David Ahern wrote: > On 2/27/17 4:07 PM, Cong Wang wrote: > > Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() > > -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is > > because ip6_null_entry is returned in this path since ip6_n

Re: [Patch net v3] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-03-01 Thread David Ahern
On 2/27/17 4:07 PM, Cong Wang wrote: > Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() > -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is > because ip6_null_entry is returned in this path since ip6_null_entry > is kinda default for a ipv6 route table root node. Quote

Re: [PATCH] bpf: update the comment about the length of analysis

2017-03-01 Thread David Miller
From: Gary Lin Date: Wed, 1 Mar 2017 16:25:51 +0800 > Commit 07016151a446 ("bpf, verifier: further improve search > pruning") increased the limit of processed instructions from > 32k to 64k, but the comment still mentioned the 32k limit. > This commit updates the comment to reflect the change. >

Re: pull-request: mac80211 2017-02-28

2017-03-01 Thread David Miller
From: Johannes Berg Date: Tue, 28 Feb 2017 10:50:18 +0100 > First round of fixes - we actually have quite a few. > > Please pull and let me know if there's any problem. Pulled, thanks Johannes. > I had another question - I have this average.h API change pending > (you saw it before). It seems

Re: [PATCH net] bridge: Fix error path in nbp_vlan_init

2017-03-01 Thread David Miller
From: Yotam Gigi Date: Wed, 1 Mar 2017 16:50:45 +0200 > Fix error path order in nbp_vlan_init, so if switchdev_port_attr_set > call failes, the vlan_hash wouldn't be destroyed before inited. > > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > CC: Roopa Prabhu > Signed-o

[PATCH net] ipv6: orphan skbs in reassembly unit

2017-03-01 Thread Eric Dumazet
From: Eric Dumazet Andrey reported a use-after-free in IPv6 stack. Issue here is that we free the socket while it still has skb in TX path and in some queues. It happens here because IPv6 reassembly unit messes skb->truesize, breaking skb_set_owner_w() badly. We fixed a similar issue for IPV4

Re: [PATCH v5 03/10] bpf: Define handle_fs and add a new helper bpf_handle_fs_get_mode()

2017-03-01 Thread Mickaël Salaün
On 01/03/2017 10:32, James Morris wrote: > On Wed, 22 Feb 2017, Mickaël Salaün wrote: > >> Add an eBPF function bpf_handle_fs_get_mode(handle_fs) to get the mode >> of a an abstract object wrapping either a file, a dentry, a path, or an >> inode. >> >> Changes since v4: >> * use a file abstractio

Re: [PATCH v5 06/10] seccomp,landlock: Handle Landlock events per process hierarchy

2017-03-01 Thread Mickaël Salaün
On 28/02/2017 21:01, Andy Lutomirski wrote: > On Tue, Feb 21, 2017 at 5:26 PM, Mickaël Salaün wrote: >> The seccomp(2) syscall can be use to apply a Landlock rule to the >> current process. As with a seccomp filter, the Landlock rule is enforced >> for all its future children. An inherited rule t

Re: [PATCH net] tcp/dccp: block BH for SYN processing

2017-03-01 Thread Soheil Hassas Yeganeh
On Wed, Mar 1, 2017 at 8:39 AM, Eric Dumazet wrote: > From: Eric Dumazet > > SYN processing really was meant to be handled from BH. > > When I got rid of BH blocking while processing socket backlog > in commit 5413d1babe8f ("net: do not block BH while processing socket > backlog"), I forgot that

Re: net: use-after-free in neigh_timer_handler/sock_wfree

2017-03-01 Thread Cong Wang
On Wed, Mar 1, 2017 at 1:24 PM, Cong Wang wrote: > On Wed, Mar 1, 2017 at 11:27 AM, Dmitry Vyukov wrote: >> Hello, >> >> I am seeing the following use-after-free report while running >> syzkaller fuzzer on >> linux-next/3e7350242c6f3d41d28e03418bd781cc1b7bad5f: >> >> =

[PATCH 1/2] dccp: Unlock sock before calling sk_free()

2017-03-01 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo The code where sk_clone() came from created a new socket and locked it, but then, on the error path didn't unlock it. This problem stayed there for a long while, till b0691c8ee7c2 ("net: Unlock sock before calling sk_free()") fixed it, but unfortunately the callers

[PATCH 2/2] net: Introduce sk_clone_lock() error path routine

2017-03-01 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo When handling problems in cloning a socket with the sk_clone_locked() function we need to perform several steps that were open coded in it and its callers, so introduce a routine to avoid this duplication: sk_free_unlock_clone(). Cc: Cong Wang Cc: Dmitry Vyukov C

Re: net: use-after-free in neigh_timer_handler/sock_wfree

2017-03-01 Thread Cong Wang
On Wed, Mar 1, 2017 at 11:27 AM, Dmitry Vyukov wrote: > Hello, > > I am seeing the following use-after-free report while running > syzkaller fuzzer on > linux-next/3e7350242c6f3d41d28e03418bd781cc1b7bad5f: > > == > BUG: KASAN: use-aft

Re: net: sleeping function called from invalid context in net_enable_timestamp

2017-03-01 Thread Eric Dumazet
On Wed, 2017-03-01 at 11:59 -0800, Eric Dumazet wrote: > On Wed, Mar 1, 2017 at 11:51 AM, Dmitry Vyukov wrote: > > > > Hello, > > > > I've got the following report while running syzkaller fuzzer on > > e5d56efc97f8240d0b5d66c03949382b6d7e5570 > > > > Right, a listener is playing fool games. >

[iproute PATCH v3 1/1] color: use "light" colors for dark background

2017-03-01 Thread Petr Vorel
COLORFGBG environment variable is used to detect dark background. Idea and a bit of code is borrowed from Vim, thanks. Signed-off-by: Petr Vorel --- Changes v2->v3: remove unnecessary cast. --- include/color.h | 1 + lib/color.c | 45 - 2 files c

Re: Passionate Partner

2017-03-01 Thread M. G
Dear Sir, Did you recieved my mail? I have sent it twice without a response. Mr Masella Giuseppe

Re: net: sleeping function called from invalid context in net_enable_timestamp

2017-03-01 Thread Eric Dumazet
On Wed, 2017-03-01 at 12:07 -0800, Eric Dumazet wrote: > On Wed, 2017-03-01 at 11:59 -0800, Eric Dumazet wrote: > > On Wed, Mar 1, 2017 at 11:51 AM, Dmitry Vyukov wrote: > > > > > > Hello, > > > > > > I've got the following report while running syzkaller fuzzer on > > > e5d56efc97f8240d0b5d66c0394

net: use-after-free in neigh_timer_handler/sock_wfree

2017-03-01 Thread Dmitry Vyukov
Hello, I am seeing the following use-after-free report while running syzkaller fuzzer on linux-next/3e7350242c6f3d41d28e03418bd781cc1b7bad5f: == BUG: KASAN: use-after-free in constant_test_bit arch/x86/include/asm/bitops.h:324 [inlin

Re: net: sleeping function called from invalid context in net_enable_timestamp

2017-03-01 Thread Eric Dumazet
On Wed, Mar 1, 2017 at 11:51 AM, Dmitry Vyukov wrote: > > Hello, > > I've got the following report while running syzkaller fuzzer on > e5d56efc97f8240d0b5d66c03949382b6d7e5570 Right, a listener is playing fool games. We need to use a work queue for all net_enable_timestamp() invocations

Re: [PATCH v4 00/19] Replace PCI pool by DMA pool API

2017-03-01 Thread Joe Perches
On Wed, 2017-03-01 at 16:55 +0100, Romain Perier wrote: > support to warn about this old API in checkpath.pl checkpatch This part isn't true anymore, but it seems sensible enough, thanks.

net/sctp: use-after-free in sctp_association_put

2017-03-01 Thread Dmitry Vyukov
Hello, I've got the following report while running syzkaller fuzzer on linux-next/8813198236a044b76e251dcae937b180dd527999: BUG: KASAN: use-after-free in sctp_association_destroy net/sctp/associola.c:416 [inline] at addr 8801c0fa415c BUG: KASAN: use-after-free in sctp_association_put+0x294/0x

Re: [PATCH net] bridge: Fix error path in nbp_vlan_init

2017-03-01 Thread Jiri Pirko
Wed, Mar 01, 2017 at 03:50:45PM CET, yot...@mellanox.com wrote: >Fix error path order in nbp_vlan_init, so if switchdev_port_attr_set >call failes, the vlan_hash wouldn't be destroyed before inited. > >Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") >CC: Roopa Prabhu >Signed-

Re: [PATCH net] bridge: Fix error path in nbp_vlan_init

2017-03-01 Thread Roopa Prabhu
On 3/1/17, 6:50 AM, Yotam Gigi wrote: > Fix error path order in nbp_vlan_init, so if switchdev_port_attr_set > call failes, the vlan_hash wouldn't be destroyed before inited. > > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > CC: Roopa Prabhu > Signed-off-by: Yotam Gigi >

Re: [iproute PATCH v2 1/1] color: use "light" colors for dark background

2017-03-01 Thread Stephen Hemminger
On Mon, 27 Feb 2017 10:55:27 +0100 Petr Vorel wrote: > +void set_color_palette(void) > +{ > + char *p = getenv("COLORFGBG"); > + > + /* > + * COLORFGBG environment variable usually contains either two or three > + * values separated by semicolons; we want the last value in eithe

Re: [PATCH net] net: route: add missing nla_policy entry for RTA_MARK attribute

2017-03-01 Thread David Miller
From: Liping Zhang Date: Mon, 27 Feb 2017 20:59:39 +0800 > From: Liping Zhang > > This will add stricter validating for RTA_MARK attribute. > > Signed-off-by: Liping Zhang Looks good, applied, thanks.

Re: [PATCH 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-01 Thread David Miller
From: Jiri Kosina Date: Sat, 25 Feb 2017 22:29:09 +0100 (CET) > @@ -1066,6 +1066,7 @@ hfsc_change_class(struct Qdisc *sch, u32 classid, u32 > parentid, > &pfifo_qdisc_ops, classid); > if (cl->qdisc == NULL) > cl->qdisc = &noop_qdisc; > +

Re: [PATCH net/ipv6] net/ipv6: avoid possible dead locking on addr_gen_mode sysctl

2017-03-01 Thread David Miller
From: Felix Jia Date: Mon, 27 Feb 2017 12:41:23 +1300 > The addr_gen_mode variable can be accessed by both sysctl and netlink. > Repleacd rtnl_lock() with rtnl_trylock() protect the sysctl operation to > avoid the possbile dead lock.` > > Signed-off-by: Felix Jia Applied and queued up for -sta

Re:Re: [drivers/net/vxlan]Why rcu_read_lock is not obtained before rculist travelling

2017-03-01 Thread Xiaobo Yan
Hi Cong, Thanks very much for your reply. It's indeeded acquired by upper layer. Thanks At 2017-03-01 05:29:17, "Cong Wang" wrote: >On Tue, Feb 28, 2017 at 6:03 AM, Xiaobo Yan wrote: >> But I don’t find any rcu_read_lock invoked before travelling fdb_head list. >> In vxlan_xmit and vxlan_s

Re: [PATCH 2/2] iproute2: add support for invisible qdisc dumping

2017-03-01 Thread Stephen Hemminger
On Sat, 25 Feb 2017 22:29:17 +0100 (CET) Jiri Kosina wrote: > From: Jiri Kosina > > Support the new TCA_DUMP_INVISIBLE netlink attribute that allows asking > kernel to perform 'full qdisc dump', as for historical reasons some of the > default qdiscs are being hidden by the kernel. > > The co

Re: [PATCH net 0/2] VXLAN/geneve RCU fixes

2017-03-01 Thread David Miller
From: Jakub Kicinski Date: Fri, 24 Feb 2017 11:43:35 -0800 > VXLAN and GENEVE need to take RCU lock explicitly because TX path > only has the _bh() flavour of RCU locked. Making the reconfiguration > path wait for both normal and _bh() RCU would be bigger hassle so > just acquire the lock, as su

Re: [PATCH v4 net] net: solve a NAPI race

2017-03-01 Thread David Miller
From: Eric Dumazet Date: Tue, 28 Feb 2017 10:34:50 -0800 > From: Eric Dumazet > > While playing with mlx4 hardware timestamping of RX packets, I found > that some packets were received by TCP stack with a ~200 ms delay... > > Since the timestamp was provided by the NIC, and my probe was added

Re: [patch] net/mlx4: && vs & typo

2017-03-01 Thread David Miller
From: Dan Carpenter Date: Tue, 28 Feb 2017 15:02:15 +0300 > Bitwise & was obviously intended here. > > Fixes: 745d8ae4622c ("net/mlx4: Spoofcheck and zero MAC can't coexist") > Signed-off-by: Dan Carpenter Applied.

Re: [patch net] mlxsw: spectrum_router: Avoid potential packets loss

2017-03-01 Thread David Miller
From: Jiri Pirko Date: Tue, 28 Feb 2017 08:55:40 +0100 > From: Ido Schimmel > > When the structure of the LPM tree changes (f.e., due to the addition of > a new prefix), we unbind the old tree and then bind the new one. This > may result in temporary packet loss. > > Instead, overwrite the old

Re: [PATCH] net: usb: asix_devices: fix missing return code check on call to asix_write_medium_mode

2017-03-01 Thread David Miller
From: Colin King Date: Tue, 28 Feb 2017 11:58:22 + > From: Colin Ian King > > The call to asix_write_medium_mode is not updating the return code ret > and yet ret is being checked for an error. Fix this by assigning ret to > the return code from the call asix_write_medium_mode. > > Detecte

Re: Page allocator order-0 optimizations merged

2017-03-01 Thread Tariq Toukan
On 01/03/2017 3:48 PM, Jesper Dangaard Brouer wrote: Hi NetDev community, I just wanted to make net driver people aware that this MM commit[1] got merged and is available in net-next. commit 374ad05ab64d ("mm, page_alloc: only use per-cpu allocator for irq-safe requests") [1] https://git.

Re: [Patch net] ipv6: ignore null_entry in inet6_rtm_getroute() too

2017-03-01 Thread Cong Wang
On Tue, Feb 28, 2017 at 2:35 PM, David Ahern wrote: > On 2/28/17 11:48 AM, Cong Wang wrote: >> On Tue, Feb 28, 2017 at 11:01 AM, David Ahern >> wrote: >>> On 2/28/17 10:44 AM, Cong Wang wrote: Like commit 1f17e2f2c8a8 ("net: ipv6: ignore null_entry on route dumps"), we need to ignore n

Re: [PATCH net] sctp: call rcu_read_lock before checking for duplicate transport nodes

2017-03-01 Thread David Miller
From: Xin Long Date: Tue, 28 Feb 2017 12:41:29 +0800 > Commit cd2b70875058 ("sctp: check duplicate node before inserting a > new transport") called rhltable_lookup() to check for the duplicate > transport node in transport rhashtable. > > But rhltable_lookup() doesn't call rcu_read_lock inside,

Re: [PATCH 1/1] rds: ib: add the static type to the variables

2017-03-01 Thread David Miller
From: Zhu Yanjun Date: Tue, 28 Feb 2017 01:45:40 -0500 > The variables rds_ib_mr_1m_pool_size and rds_ib_mr_8k_pool_size > are used only in the ib.c file. As such, the static type is > added to limit them in this file. > > Cc: Joe Jin > Cc: Junxiao Bi > Signed-off-by: Zhu Yanjun Applied.

Re: [PATCH] MAINTAINERS: Orphan usb/net/hso driver

2017-03-01 Thread David Miller
From: Baruch Siach Date: Tue, 28 Feb 2017 10:39:48 +0200 > The email address of Jan Dumon bounces, and there is not relevant information > in the linked website. > > Signed-off-by: Baruch Siach Applied.

Re: [PATCH net] rxrpc: Fix deadlock between call creation and sendmsg/recvmsg

2017-03-01 Thread David Miller
From: David Howells Date: Mon, 27 Feb 2017 15:43:06 + > All the routines by which rxrpc is accessed from the outside are serialised > by means of the socket lock (sendmsg, recvmsg, bind, > rxrpc_kernel_begin_call(), ...) and this presents a problem: ... > Fix this by: ... > This patch has t

Re: [PATCH v2 net] net: solve a NAPI race

2017-03-01 Thread Eric Dumazet
On Wed, 2017-03-01 at 08:14 -0800, Alexander Duyck wrote: > What build flags are you using? With -Os or -O2 I have seen it > convert the /b * c into a single shift. > Because b & c are unsigned in our case. I presume David tried signed integers, this is why gcc does that.

Re: net/ipv4: deadlock in ip_ra_control

2017-03-01 Thread Cong Wang
possible circular locking dependency detected ] > 4.10.0-next-20170301+ #1 Not tainted > --- > syz-executor1/3394 is trying to acquire lock: > (sk_lock-AF_INET){+.+.+.}, at: [] lock_sock > include/net/sock.h:1460

Re: [PATCH] bpf: update the comment about the length of analysis

2017-03-01 Thread Alexei Starovoitov
On Wed, Mar 01, 2017 at 04:25:51PM +0800, Gary Lin wrote: > Commit 07016151a446 ("bpf, verifier: further improve search > pruning") increased the limit of processed instructions from > 32k to 64k, but the comment still mentioned the 32k limit. > This commit updates the comment to reflect the change

commit a52ad514fdf3b8a57ca4322c92d2d8d5c6182485 net: deprecate eth_change_mtu, remove usage breaks bonding on my machine

2017-03-01 Thread Brad Campbell
G'day Jarod, I have a pair of machines that are linked by a pair of quad port e1000 cards with all 4 ports bonded. The network is configured with an mtu of 9000. Kernel 4.10 fails to bring these interfaces up as it fails when trying to set the mtu on the bond interface higher than 1500. A bi

[PATCH net] bridge: Fix error path in nbp_vlan_init

2017-03-01 Thread Yotam Gigi
Fix error path order in nbp_vlan_init, so if switchdev_port_attr_set call failes, the vlan_hash wouldn't be destroyed before inited. Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") CC: Roopa Prabhu Signed-off-by: Yotam Gigi --- net/bridge/br_vlan.c | 2 +- 1 file changed,

[PATCH net] tcp/dccp: block BH for SYN processing

2017-03-01 Thread Eric Dumazet
From: Eric Dumazet SYN processing really was meant to be handled from BH. When I got rid of BH blocking while processing socket backlog in commit 5413d1babe8f ("net: do not block BH while processing socket backlog"), I forgot that a malicious user could transition to TCP_LISTEN from a state that

Re: [PATCH v2 net] net: solve a NAPI race

2017-03-01 Thread Alexander Duyck
On Wed, Mar 1, 2017 at 2:41 AM, David Laight wrote: > From: Alexander Duyck >> Sent: 28 February 2017 17:20 > ... >> You might want to consider just using a combination AND, divide, >> multiply, and OR to avoid having to have any conditional branches >> being added due to this code path. Basicall

[PATCH v4 10/19] scsi: lpfc: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. It also updates some comments, accordingly. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/scsi/lpfc/lpfc.h | 12 ++--- drivers/scsi/

Dell Inspiron 5558/0VNM2T and suspend/resume problem with r8169

2017-03-01 Thread Diego Viola
My machine (a Dell Inspiron 5558 laptop) fails to resume from suspend unless I rmmod r8169 first. Another workaround is to do this before suspend: echo 0 > /sys/power/pm_async I've been reproducing the freeze like this: $ i3lock && systemctl suspend I would have to repeat this at least 5 times

[PATCH v4 12/19] scsi: mpt3sas: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 73 + 1 file changed, 34 in

[PATCH v4 13/19] scsi: mvsas: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/scsi/mvsas/mv_init.c | 6 +++--- drivers/scsi/mvsas/mv_sas.c | 6 +++--- 2 files changed, 6

[PATCH v4 16/19] usb: gadget: net2280: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin --- drivers/usb/gadget/udc/net2280.c | 12 ++-- drivers/usb/gadget/

[PATCH v4 19/19] PCI: Remove PCI pool macro functions

2017-03-01 Thread Romain Perier
Now that all the drivers use dma pool API, we can remove the macro functions for PCI pool. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- include/linux/pci.h | 9 - 1 file changed, 9 deletions(-) diff --git a/include/linux/pci.h b/include/linux/pci.h index 282ed32..

[PATCH v4 11/19] scsi: megaraid: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/scsi/megaraid/megaraid_mbox.c | 33 +++ drivers/scsi/megaraid/megaraid_mm.c

Re: Dell Inspiron 5558/0VNM2T and suspend/resume problem with r8169

2017-03-01 Thread Diego Viola
On Wed, Mar 1, 2017 at 12:44 PM, Diego Viola wrote: > My machine (a Dell Inspiron 5558 laptop) fails to resume from suspend > unless I rmmod r8169 first. > > Another workaround is to do this before suspend: > > echo 0 > /sys/power/pm_async > > I've been reproducing the freeze like this: > > $ i3lo

[PATCH v4 14/19] scsi: pmcraid: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin --- drivers/scsi/pmcraid.c | 10 +- drivers/scsi/pmcraid.h | 2 +-

[PATCH v4 15/19] usb: gadget: amd5536udc: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin --- drivers/usb/gadget/udc/amd5536udc.c | 8 drivers/usb/gadget/ud

[PATCH v4 18/19] usb: host: Remove remaining pci_pool in comments

2017-03-01 Thread Romain Perier
This replaces remaining occurences of pci_pool by dma_pool, as this is the new API that could be used for that purpose. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/usb/host/ehci-hcd.c | 2 +- drivers/usb/host/fotg210-hcd.c | 2 +- drivers/usb/host/oxu210hp-hc

[PATCH v4 07/19] wireless: ipw2200: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 13 +++-- 1 file changed, 7 insertions(+), 6 d

[PATCH v4 09/19] scsi: csiostor: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. It also updates the name of some variables and the content of comments, accordingly. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/scsi/csi

[PATCH v4 06/19] mlx5: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 11 ++- include/linux/mlx5/driver.h

[PATCH v4 04/19] net: e100: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin --- drivers/net/ethernet/intel/e100.c | 12 ++-- 1 file changed, 6

[PATCH v4 05/19] mlx4: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 10 +- drivers/net/

[PATCH v4 00/19] Replace PCI pool by DMA pool API

2017-03-01 Thread Romain Perier
by the dma pool API, adds support to warn about this old API in checkpath.pl and remove the defines. Changes in v4: - Rebased series onto next-20170301 - Removed patch 20/20: checks done by checkpath.pl, no longer required. Thanks to Peter and Joe for their feedbacks. - Added Reviewed-by tags

[PATCH] Bluetooth: fix assignments on error variable err

2017-03-01 Thread Colin King
From: Colin Ian King Variable err is being initialized to zero and then later being set to the error return from the call to hci_req_run_skb; hence we can remove the redundant initialization to zero. Also on two occassions err is not being set from the error return from the call to hci_req_run_s

[PATCH v4 17/19] usb: gadget: pch_udc: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/usb/gadget/udc/pch_udc.c | 31 +++ 1 file changed, 15 insertions(

[PATCH v4 08/19] scsi: be2iscsi: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin --- drivers/scsi/be2iscsi/be_iscsi.c | 6 +++--- drivers/scsi/be2iscsi/be_m

[PATCH v4 03/19] IB/mthca: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin --- drivers/infiniband/hw/mthca/mthca_av.c | 10 +- drivers/infini

[PATCH v4 01/19] block: DAC960: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin --- drivers/block/DAC960.c | 36 ++-- drive

[PATCH v4 02/19] dmaengine: pch_dma: Replace PCI pool old API

2017-03-01 Thread Romain Perier
The PCI pool API is deprecated. This commits replaces the PCI pool old API by the appropriated function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin --- drivers/dma/pch_dma.c | 12 ++-- 1 file changed, 6 insertions(+

Re: [PATCH v4] net: don't call strlen() on the user buffer in packet_bind_spkt()

2017-03-01 Thread Eric Dumazet
On Wed, 2017-03-01 at 12:57 +0100, Alexander Potapenko wrote: > KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of > uninitialized memory in packet_bind_spkt(): ... > Signed-off-by: Alexander Potapenko > --- > Changes since v3: > - addressed comments by Eric Dumazet (avoid u

[PATCH 1/2] batman-adv: Fix double free during fragment merge error

2017-03-01 Thread Simon Wunderlich
From: Sven Eckelmann The function batadv_frag_skb_buffer was supposed not to consume the skbuff on errors. This was followed in the helper function batadv_frag_insert_packet when the skb would potentially be inserted in the fragment queue. But it could happen that the next helper function batadv_

[PATCH 0/2] pull request for net: batman-adv 2017-03-01

2017-03-01 Thread Simon Wunderlich
-01-04 08:22:04 +0100) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-net-for-davem-20170301 for you to fetch changes up to 51c6b429c0c95e67edd1cb0b548c5cf6a6604763: batman-adv: Fix transmission of final, 16th fragment (2017-02-21 18:33:35 +0100

[PATCH 2/2] batman-adv: Fix transmission of final, 16th fragment

2017-03-01 Thread Simon Wunderlich
From: Linus Lüssing Trying to split and transmit a unicast packet in 16 parts will fail for the final fragment: After having sent the 15th one with a frag_packet.no index of 14, we will increase the the index to 15 - and return with an error code immediately, even though one more fragment is due

Re: net/dccp: dccp_create_openreq_child freed held lock

2017-03-01 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 01, 2017 at 10:38:54AM +0100, Dmitry Vyukov escreveu: > Hello, > > I've got the following report while running syzkaller fuzzer on > 86292b33d4b79ee03e2f43ea0381ef85f077c760: > > > It seems that dccp_create_openreq_child needs to unlock the sock if > dccp_feat_activate_values fails.

  1   2   >