On 2/27/17 4:07 PM, Cong Wang wrote: > Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() > -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is > because ip6_null_entry is returned in this path since ip6_null_entry > is kinda default for a ipv6 route table root node. Quote from > David Ahern: > > ip6_null_entry is the root of all ipv6 fib tables making it integrated > into the table ... > > We should ignore any attempt of trying to delete it, like we do in > __ip6_del_rt() path and several others. > > Reported-by: Andrey Konovalov <andreyk...@google.com> > Fixes: 0ae8133586ad ("net: ipv6: Allow shorthand delete of all nexthops in > multipath route") > Cc: David Ahern <d...@cumulusnetworks.com> > Cc: Eric Dumazet <eric.duma...@gmail.com> > Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> > --- > net/ipv6/route.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-)
Acked-by: David Ahern <d...@cumulusnetworks.com>