Re: lib: Introduce priority array area manager

2017-02-22 Thread Geert Uytterhoeven
Hi Jiri, On Wed, Feb 22, 2017 at 8:02 PM, Linux Kernel Mailing List wrote: > Web: > https://git.kernel.org/torvalds/c/44091d29f2075972aede47ef17e1e70db3d51190 > Commit: 44091d29f2075972aede47ef17e1e70db3d51190 > Parent: b862815c3ee7b49ec20a9ab25da55a5f0bcbb95e > Refname:refs/h

Re: [RFC v3 01/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) documentation

2017-02-22 Thread Vishwanathapura, Niranjana
On Wed, Feb 08, 2017 at 05:00:45PM +, Bart Van Assche wrote: On Tue, 2017-02-07 at 12:23 -0800, Vishwanathapura, Niranjana wrote: Please elaborate this section. What is a virtual Ethernet switch? Is it a software entity or something that is implemented in hardware? Also, how are these indepe

[PATCH 00/11] Omni-Path Virtual Network Interface Controller (VNIC)

2017-02-22 Thread Vishwanathapura, Niranjana
Intel Omni-Path (OPA) Virtual Network Interface Controller (VNIC) feature supports Ethernet functionality over Omni-Path fabric by encapsulating the Ethernet packets between HFI nodes. Architecture = The patterns of exchanges of Omni-Path encapsulated Ethernet packets involves one or m

[PATCH 05/11] IB/opa-vnic: VNIC statistics support

2017-02-22 Thread Vishwanathapura, Niranjana
OPA VNIC driver statistics support maintains various counters including standard netdev counters and the Ethernet manager defined counters. Add the Ethtool hook to read the counters. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Niranjana Vishwanathapura --- drivers/inf

[PATCH 04/11] IB/opa-vnic: VNIC Ethernet Management (EM) structure definitions

2017-02-22 Thread Vishwanathapura, Niranjana
Define VNIC EM MAD structures and the associated macros. These structures are used for information exchange between VNIC EM agent (EMA) on the host and the Ethernet manager. These include the virtual ethernet switch (vesw) port information, vesw port mac table, summay and error counters, vesw port

[PATCH 03/11] IB/opa-vnic: Virtual Network Interface Controller (VNIC) netdev

2017-02-22 Thread Vishwanathapura, Niranjana
OPA VNIC netdev function supports Ethernet functionality over Omni-Path fabric by encapsulating Ethernet packets inside Omni-Path packet header. It allocates a rdma netdev device and interfaces with the network stack to provide standard Ethernet network interfaces. It overrides HFI1 device's netdev

[PATCH 01/11] IB/opa-vnic: Virtual Network Interface Controller (VNIC) documentation

2017-02-22 Thread Vishwanathapura, Niranjana
Add OPA VNIC design document explaining the VNIC architecture and the driver design. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Niranjana Vishwanathapura --- Documentation/infiniband/opa_vnic.txt | 153 ++ 1 file changed, 153 insertion

[PATCH 10/11] IB/hfi1: Virtual Network Interface Controller (VNIC) HW support

2017-02-22 Thread Vishwanathapura, Niranjana
HFI1 HW specific support for VNIC functionality. Dynamically allocate a set of contexts for VNIC when the first vnic port is instantiated. Allocate VNIC contexts from user contexts pool and return them back to the same pool while freeing up. Set aside enough MSI-X interrupts for VNIC contexts and a

[PATCH 08/11] IB/opa-vnic: VNIC Ethernet Management Agent (VEMA) function

2017-02-22 Thread Vishwanathapura, Niranjana
OPA VEMA function interfaces with the Infiniband MAD stack to exchange the management information packets with the Ethernet Manager (EM). It interfaces with the OPA VNIC netdev function to SET/GET the management information. The information exchanged with the EM includes class port details, encapsu

[PATCH 02/11] IB/opa-vnic: Virtual Network Interface Controller (VNIC) interface

2017-02-22 Thread Vishwanathapura, Niranjana
Add rdma netdev interface to ib device structure allowing rdma netdev devices to be allocated by ib clients. Define OPA VNIC interface between hardware independent VNIC functionality and the hardware dependent VNIC functionality. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-

[PATCH 07/11] IB/opa-vnic: VNIC Ethernet Management Agent (VEMA) interface

2017-02-22 Thread Vishwanathapura, Niranjana
OPA VNIC EMA interface functions are the management interfaces to the OPA VNIC netdev. Add support to add and remove VNIC ports. Implement the required GET/SET management interface functions and processing of new management information. Add support to send trap notifications upon various events lik

[PATCH 09/11] IB/hfi1: OPA_VNIC RDMA netdev support

2017-02-22 Thread Vishwanathapura, Niranjana
Add support to create and free OPA_VNIC rdma netdev devices. Implement netstack interface functionality including xmit_skb, receive side NAPI etc. Also implement rdma netdev control functions. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Niranjana Vishwanathapura Signed

[PATCH 11/11] IB/hfi1: VNIC SDMA support

2017-02-22 Thread Vishwanathapura, Niranjana
HFI1 VNIC SDMA support enables transmission of VNIC packets over SDMA. Map VNIC queues to SDMA engines and support halting and wakeup of the VNIC queues. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Niranjana Vishwanathapura --- drivers/infiniband/hw/hfi1/Makefile|

[PATCH 06/11] IB/opa-vnic: VNIC MAC table support

2017-02-22 Thread Vishwanathapura, Niranjana
OPA VNIC MAC table contains the MAC address to DLID mappings provided by the Ethernet manager. During transmission, the MAC table provides the MAC address to DLID translation. Implement MAC table using simple hash list. Also provide support to update/query the MAC table by Ethernet manager. Review

[PATCH net-next v3 3/3] A Sample of using socket cookie and uid for traffic monitoring

2017-02-22 Thread Chenbo Feng
From: Chenbo Feng Add a sample program to demostrate the possible usage of get_socket_cookie and get_socket_uid helper function. The program will store bytes and packets counting of in/out traffic monitored by iptable and store the stats in a bpf map in per socket base. The owner uid of the socke

[PATCH net-next v3 0/3] net: core: Two Helper function about socket information

2017-02-22 Thread Chenbo Feng
From: Chenbo Feng Introduce two eBpf helper function to get the socket cookie and socket uid for each packet. The helper function is useful when the *sk field inside sk_buff is not empty. These helper functions can be used on socket and uid based traffic monitoring programs. Change since V2: * A

[PATCH net-next v3 1/3] Add a helper function to get socket cookie in eBPF

2017-02-22 Thread Chenbo Feng
From: Chenbo Feng Retrieve the socket cookie generated by sock_gen_cookie() from a sk_buff with a known socket. Generates a new cookie if one was not yet set.If the socket pointer inside sk_buff is NULL, 0 is returned. The helper function coud be useful in monitoring per socket networking traffic

[PATCH net-next v3 3/3] A Sample of using socket cookie and uid for traffic monitoring

2017-02-22 Thread Chenbo Feng
From: Chenbo Feng Add a sample program to demostrate the possible usage of get_socket_cookie and get_socket_uid helper function. The program will store bytes and packets counting of in/out traffic monitored by iptable and store the stats in a bpf map in per socket base. The owner uid of the socke

[PATCH net-next v3 2/3] Add a eBPF helper function to retrieve socket uid

2017-02-22 Thread Chenbo Feng
From: Chenbo Feng Returns the owner uid of the socket inside a sk_buff. This is useful to perform per-UID accounting of network traffic or per-UID packet filtering. The socket need to be a fullsock otherwise 0 is returned. Change since V2: Add a sk_to_full_sk() check before retrieving the uid. M

[PATCH net-next v3 2/3] Add a eBPF helper function to retrieve socket uid

2017-02-22 Thread Chenbo Feng
From: Chenbo Feng Returns the owner uid of the socket inside a sk_buff. This is useful to perform per-UID accounting of network traffic or per-UID packet filtering. The socket need to be a fullsock otherwise 0 is returned. Change since V2: Add a sk_to_full_sk() check before retrieving the uid. M

[PATCH net-next v3 1/3] Add a helper function to get socket cookie in eBPF

2017-02-22 Thread Chenbo Feng
From: Chenbo Feng Retrieve the socket cookie generated by sock_gen_cookie() from a sk_buff with a known socket. Generates a new cookie if one was not yet set.If the socket pointer inside sk_buff is NULL, 0 is returned. The helper function coud be useful in monitoring per socket networking traffic

[PATCH net-next v3 0/3] net: core: Two Helper function about socket information

2017-02-22 Thread Chenbo Feng
From: Chenbo Feng Introduce two eBpf helper function to get the socket cookie and socket uid for each packet. The helper function is useful when the *sk field inside sk_buff is not empty. These helper functions can be used on socket and uid based traffic monitoring programs. Change since V2: * A

Re: VXLAN RCU error

2017-02-22 Thread Jakub Kicinski
On Wed, 22 Feb 2017 14:27:45 -0800, Jakub Kicinski wrote: > Hi Roopa! Ah, sorry, it seems like this splat may be coming all the way from c6fcc4fc5f8b ("vxlan: avoid using stale vxlan socket."). > I get this RCU error on net 12d656af4e3d2781b9b9f52538593e1717e7c979: > > [ 1571.067134] ===

Re: [PATCH net-next 2/2] sctp: add support for MSG_MORE

2017-02-22 Thread Xin Long
On Tue, Feb 21, 2017 at 10:27 PM, David Laight wrote: > From: Xin Long >> Sent: 18 February 2017 17:53 >> This patch is to add support for MSG_MORE on sctp. >> >> It adds force_delay in sctp_datamsg to save MSG_MORE, and sets it after >> creating datamsg according to the send flag. sctp_packet_can

Re: [PATCH net v5] bpf: add helper to compare network namespaces

2017-02-22 Thread David Ahern
On 2/19/17 9:17 PM, Eric W. Biederman wrote: >>> @@ -2597,6 +2598,39 @@ static const struct bpf_func_proto >>> bpf_xdp_event_output_proto = { >>> .arg5_type = ARG_CONST_STACK_SIZE, >>> }; >>> >>> +BPF_CALL_3(bpf_sk_netns_cmp, struct sock *, sk, u64, ns_dev, u64, ns_ino) >>> +{ >>> +

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-22 Thread Jason Wang
On 2017年02月23日 01:17, John Fastabend wrote: On 17-02-21 12:46 AM, Jason Wang wrote: This patch switch to use build_skb() for small buffer which can have better performance for both TCP and XDP (since we can work at page before skb creation). It also remove lots of XDP codes since both mergeabl

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-22 Thread Alexander Duyck
On Wed, Feb 22, 2017 at 6:06 PM, Eric Dumazet wrote: > On Wed, 2017-02-22 at 17:08 -0800, Alexander Duyck wrote: > >> >> Right but you were talking about using both halves one after the >> other. If that occurs you have nothing left that you can reuse. That >> was what I was getting at. If you

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-22 Thread Eric Dumazet
On Wed, 2017-02-22 at 17:08 -0800, Alexander Duyck wrote: > > Right but you were talking about using both halves one after the > other. If that occurs you have nothing left that you can reuse. That > was what I was getting at. If you use up both halves you end up > having to unmap the page. >

Re: [PATCH RFC v2 02/12] sock: skb_copy_ubufs support for compound pages

2017-02-22 Thread Willem de Bruijn
>> >> - page = alloc_page(gfp_mask); >> + page = skb_frag_page(f); >> + if (page_count(page) == 1) { >> + skb_frag_ref(skb, i); > > This could be : get_page(page); Ah, indeed. Thanks. > >> + goto copy_done; >> +

Re: [PATCH] uapi: fix linux/rds.h userspace compilation errors

2017-02-22 Thread Santosh Shilimkar
On 2/22/2017 5:13 PM, Dmitry V. Levin wrote: Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:198:2: error: unknown type name 'u8' u8 rx_traces; /usr/include/linux/rds.h:199:2: error: unknown type name 'u8' u8 r

[PATCH] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors

2017-02-22 Thread Dmitry V. Levin
Include in uapi/linux/seg6.h to fix the following linux/seg6.h userspace compilation error: /usr/include/linux/seg6.h:31:18: error: array type has incomplete element type 'struct in6_addr' struct in6_addr segments[0]; Include in uapi/linux/seg6_iptunnel.h to fix the following linux/seg6_iptu

[PATCH] uapi: fix linux/rds.h userspace compilation errors

2017-02-22 Thread Dmitry V. Levin
Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:198:2: error: unknown type name 'u8' u8 rx_traces; /usr/include/linux/rds.h:199:2: error: unknown type name 'u8' u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX]; /usr/i

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-22 Thread Alexander Duyck
On Wed, Feb 22, 2017 at 10:21 AM, Eric Dumazet wrote: > On Wed, 2017-02-22 at 09:23 -0800, Alexander Duyck wrote: >> On Wed, Feb 22, 2017 at 8:22 AM, Eric Dumazet wrote: >> > On Mon, 2017-02-13 at 11:58 -0800, Eric Dumazet wrote: >> >> Use of order-3 pages is problematic in some cases. >> >> >> >

[PATCH] bpf: fix spelling mistake: "proccessed" -> "processed"

2017-02-22 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in verbose log message Signed-off-by: Colin Ian King --- kernel/bpf/verifier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index d2bded2..3fc6e39 100644 --- a/kernel/bpf/v

Re: [PATCH V5 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-02-22 Thread Martin K. Petersen
> "Chad" == Dupuis, Chad writes: Chad> The QLogic FastLinQ Driver for FCoE (qedf) is the FCoE specific Chad> module for 41000 Series Converged Network Adapters by QLogic. This Chad> patch consists of following changes: Now that Linus pulled Dave's tree I have gone ahead and merged this into

RE: create drivers/net/mdio and move mdio drivers into it

2017-02-22 Thread YUAN Linyu
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Wednesday, February 22, 2017 6:21 PM > To: YUAN Linyu > Cc: Florian Fainelli; David S . Miller; netdev@vger.kernel.org; cug...@163.com > Subject: Re: create drivers/net/mdio and move mdio drivers into it > > On Wed,

[PATCH] rtlwifi: fix spelling mistake: "conuntry" -> "country"

2017-02-22 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in RT_TRACE message Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/regd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/regd.c b/drivers/net/wireless/realtek

Re: linux-next: build failure after merge of the net-next tree

2017-02-22 Thread Stephen Rothwell
Hi all, On Tue, 10 Jan 2017 10:59:27 +1100 Stephen Rothwell wrote: > > After merging the net-next tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > net/smc/af_smc.c: In function 'smc_splice_read': > net/smc/af_smc.c:1258:39: error: passing argument 1 of > 'smc->clcso

[PATCH] net: realtek: 8139too: use new api ethtool_{get|set}_link_ksettings

2017-02-22 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/realtek/8139too.c | 14 -- 1 files c

[PATCH] uapi: fix linux/llc.h userspace compilation error

2017-02-22 Thread Dmitry V. Levin
Include to fix the following linux/llc.h userspace compilation error: /usr/include/linux/llc.h:26:27: error: 'IFHWADDRLEN' undeclared here (not in a function) unsigned char sllc_mac[IFHWADDRLEN]; Signed-off-by: Dmitry V. Levin --- include/uapi/linux/llc.h | 1 + 1 file changed, 1 insertio

[PATCH] uapi: fix linux/ip6_tunnel.h userspace compilation errors

2017-02-22 Thread Dmitry V. Levin
Include and to fix the following linux/ip6_tunnel.h userspace compilation errors: /usr/include/linux/ip6_tunnel.h:23:12: error: 'IFNAMSIZ' undeclared here (not in a function) char name[IFNAMSIZ]; /* name of tunnel device */ /usr/include/linux/ip6_tunnel.h:30:18: error: field 'laddr' has incom

VXLAN RCU error

2017-02-22 Thread Jakub Kicinski
Hi Roopa! I get this RCU error on net 12d656af4e3d2781b9b9f52538593e1717e7c979: [ 1571.067134] === [ 1571.071842] [ ERR: suspicious RCU usage. ] [ 1571.076546] 4.10.0-debug-03232-g12d656af4e3d #1 Tainted: GW O [ 1571.084166] ---

Re: Focusing the XDP project

2017-02-22 Thread Tom Herbert
On Wed, Feb 22, 2017 at 1:43 PM, Jesper Dangaard Brouer wrote: > On Wed, 22 Feb 2017 09:22:53 -0800 > Tom Herbert wrote: > >> On Wed, Feb 22, 2017 at 1:43 AM, Jesper Dangaard Brouer >> wrote: >> > >> > On Tue, 21 Feb 2017 14:54:35 -0800 Tom Herbert >> > wrote: >> >> On Tue, Feb 21, 2017 at 2:2

Re: Questions on XDP

2017-02-22 Thread Jesper Dangaard Brouer
On Wed, 22 Feb 2017 09:08:53 -0800 John Fastabend wrote: > > GSO/TSO is getting into advanced stuff I would rather not have to get > > into right now. I figure we need to take this portion one step at a > > time. To support GSO we need more information like the mss. > > > > Agreed lets get

Re: [PATCH net V2 0/5] mlx4 misc fixes

2017-02-22 Thread David Miller
From: Tariq Toukan Date: Wed, 22 Feb 2017 18:25:24 +0200 > This patchset contains misc bug fixes from Eric Dumazet and our team > to the mlx4 Core and Eth drivers. > > Series generated against net commit: > 00ea1ceebe0d ipv6: release dst on error in ip6_dst_lookup_tail > > Thanks, > Tariq. > >

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-22 Thread Tom Herbert
On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: > On Thu, Feb 16, 2017 at 11:58 PM, Andreas Schultz wrote: >> Hi Or, >> - On Feb 16, 2017, at 3:59 PM, Or Gerlitz ogerl...@mellanox.com wrote: >> >>> Generate the source udp header according to the flow represented by >>> the packet we are en

Re: [PATCH] fjes: Move fjes driver info message into fjes_acpi_add()

2017-02-22 Thread Yasuaki Ishimatsu
Thank you for quick response. I'll think of other solution. Thanks, Yasuaki Ishimatsu On 02/22/2017 03:45 PM, David Miller wrote: From: Yasuaki Ishimatsu Date: Wed, 22 Feb 2017 15:40:49 -0500 To avoid the confusion, the patch moves the message into fjes_acpi_add() so that it is shows only wh

Re: Focusing the XDP project

2017-02-22 Thread Jesper Dangaard Brouer
On Wed, 22 Feb 2017 09:22:53 -0800 Tom Herbert wrote: > On Wed, Feb 22, 2017 at 1:43 AM, Jesper Dangaard Brouer > wrote: > > > > On Tue, 21 Feb 2017 14:54:35 -0800 Tom Herbert > > wrote: > >> On Tue, Feb 21, 2017 at 2:29 PM, Saeed Mahameed > >> wrote: > > [...] > >> > The only complexi

Re: [PATCH v2 2/2] tcp: account for ts offset only if tsecr not zero

2017-02-22 Thread David Miller
From: Alexey Kodanev Date: Wed, 22 Feb 2017 13:23:56 +0300 > We can get SYN with zero tsecr, don't apply offset in this case. > > Fixes: ee684b6f2830 ("tcp: send packets with a socket timestamp") > Signed-off-by: Alexey Kodanev Applied.

Re: [PATCH v2 1/2] tcp: setup timestamp offset when write_seq already set

2017-02-22 Thread David Miller
From: Alexey Kodanev Date: Wed, 22 Feb 2017 13:23:55 +0300 > Found that when randomized tcp offsets are enabled (by default) > TCP client can still start new connections without them. Later, > if server does active close and re-uses sockets in TIME-WAIT > state, new SYN from client can be rejecte

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-22 Thread Or Gerlitz
On Thu, Feb 16, 2017 at 11:58 PM, Andreas Schultz wrote: > Hi Or, > - On Feb 16, 2017, at 3:59 PM, Or Gerlitz ogerl...@mellanox.com wrote: > >> Generate the source udp header according to the flow represented by >> the packet we are encapsulating, as done for other udp tunnels. This >> helps o

Re: [PATCH v2] net/dccp: fix use after free in tw_timer_handler()

2017-02-22 Thread David Miller
From: Andrey Ryabinin Date: Wed, 22 Feb 2017 12:35:27 +0300 > DCCP doesn't purge timewait sockets on network namespace shutdown. > So, after net namespace destroyed we could still have an active timer > which will trigger use after free in tw_timer_handler(): ... > Add .exit_batch hook to dccp_v

Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

2017-02-22 Thread David Miller
From: "Dmitry V. Levin" Date: Tue, 21 Feb 2017 23:19:14 +0300 > On Tue, Feb 21, 2017 at 12:10:22PM -0500, David Miller wrote: >> From: "Dmitry V. Levin" >> Date: Mon, 20 Feb 2017 14:58:41 +0300 >> >> > Include (guarded by ifndef __KERNEL__) to fix >> > the following linux/if.h userspace compil

Re: [PATCH net-next] l2tp: Avoid schedule while atomic in exit_net

2017-02-22 Thread David Miller
From: Ridge Kennedy Date: Wed, 22 Feb 2017 14:59:49 +1300 > While destroying a network namespace that contains a L2TP tunnel a > "BUG: scheduling while atomic" can be observed. > > Enabling lockdep shows that this is happening because l2tp_exit_net() > is calling l2tp_tunnel_closeall() (via l2tp

Re: [PATCH] fjes: Move fjes driver info message into fjes_acpi_add()

2017-02-22 Thread David Miller
From: Yasuaki Ishimatsu Date: Wed, 22 Feb 2017 15:40:49 -0500 > To avoid the confusion, the patch moves the message into > fjes_acpi_add() so that it is shows only when fjes_acpi_add() > succeeded. This change means it'll never be printed for platform driver matches, which is even worse than wha

Re: [PATCH next 0/4] bonding: winter cleanup

2017-02-22 Thread Jiri Pirko
Wed, Feb 22, 2017 at 08:23:13PM CET, mahe...@google.com wrote: >On Tue, Feb 21, 2017 at 11:58 PM, Jiri Pirko wrote: >> Wed, Feb 22, 2017 at 02:08:16AM CET, mah...@bandewar.net wrote: >>>From: Mahesh Bandewar >>> >>>Few cleanup patches that I have accumulated over some time now. >>> >>>(a) First t

Re: [PATCH RFC v2 02/12] sock: skb_copy_ubufs support for compound pages

2017-02-22 Thread Eric Dumazet
On Wed, 2017-02-22 at 11:38 -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Refine skb_copy_ubufs to support compount pages. With upcoming TCP > and UDP zerocopy sendmsg, such fragments may appear. > > These skbuffs can have both kernel and zerocopy fragments, e.g., when > corking. A

[PATCH] fjes: Move fjes driver info message into fjes_acpi_add()

2017-02-22 Thread Yasuaki Ishimatsu
The fjes driver is used only by FUJITSU servers and almost of all servers in the world never use it. But currently if ACPI PNP0C02 is defined in the ACPI table, the following message is always shown: "FUJITSU Extended Socket Network Device Driver - version 1.2 - Copyright (c) 2015 FUJITSU LIMI

Re: [PATCH] qlogic: netxen: constify bin_attribute structures

2017-02-22 Thread David Miller
From: Bhumika Goyal Date: Wed, 22 Feb 2017 00:17:48 +0530 > Declare bin_attribute structures as const as they are only passed as an > arguments to the functions device_remove_bin_file and > device_create_bin_file. These function arguments are of type const, so > bin_attribute structures having th

Re: [PATCH] qlogic: qlcnic_sysfs: constify bin_attribute structures

2017-02-22 Thread David Miller
From: Bhumika Goyal Date: Wed, 22 Feb 2017 00:11:17 +0530 > Declare bin_attribute structures as const as they are only passed as an > arguments to the functions device_remove_bin_file and > device_create_bin_file. These function arguments are of type const, so > bin_attribute structures having th

Re: [PATCH v1.1] net: emac: add support for device-tree based PHY discovery and setup

2017-02-22 Thread David Miller
From: Christian Lamparter Date: Mon, 20 Feb 2017 20:10:58 +0100 > This patch adds glue-code that allows the EMAC driver to interface > with the existing dt-supported PHYs in drivers/net/phy. > > Because currently, the emac driver maintains a small library of > supported phys for in a private phy

Re: [PATCH net 3/6] net/mlx5e: Do not reduce LRO WQE size when not using build_skb

2017-02-22 Thread Alexei Starovoitov
On Wed, Feb 22, 2017 at 7:20 AM, Saeed Mahameed wrote: > From: Tariq Toukan > > When rq_type is Striding RQ, no room of SKB_RESERVE is needed > as SKB allocation is not done via build_skb. > > Fixes: e4b85508072b ("net/mlx5e: Slightly reduce hardware LRO size") > Signed-off-by: Tariq Toukan > Si

Re: [PATCH next 0/4] bonding: winter cleanup

2017-02-22 Thread Andy Gospodarek
On Wed, Feb 22, 2017 at 2:17 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Tue, Feb 21, 2017 at 8:36 PM, Or Gerlitz wrote: >> >> On Wed, Feb 22, 2017 at 5:29 AM, David Miller wrote: >> > From: Mahesh Bandewar >> > Date: Tue, 21 Feb 2017 17:08:16 -0800 >> > >> >> Few cleanup patches that I have

Re: [PATCH next 0/4] bonding: winter cleanup

2017-02-22 Thread महेश बंडेवार
On Tue, Feb 21, 2017 at 11:58 PM, Jiri Pirko wrote: > Wed, Feb 22, 2017 at 02:08:16AM CET, mah...@bandewar.net wrote: >>From: Mahesh Bandewar >> >>Few cleanup patches that I have accumulated over some time now. >> >>(a) First two patches are basically to move the work-queue initialization >>f

Re: [PATCH next 0/4] bonding: winter cleanup

2017-02-22 Thread महेश बंडेवार
On Tue, Feb 21, 2017 at 8:36 PM, Or Gerlitz wrote: > > On Wed, Feb 22, 2017 at 5:29 AM, David Miller wrote: > > From: Mahesh Bandewar > > Date: Tue, 21 Feb 2017 17:08:16 -0800 > > > >> Few cleanup patches that I have accumulated over some time now. > > > > The net-next tree is closed, therefore

ATENCIÓN;

2017-02-22 Thread dministrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de corre

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-22 Thread Eric Dumazet
On Wed, 2017-02-22 at 09:23 -0800, Alexander Duyck wrote: > On Wed, Feb 22, 2017 at 8:22 AM, Eric Dumazet wrote: > > On Mon, 2017-02-13 at 11:58 -0800, Eric Dumazet wrote: > >> Use of order-3 pages is problematic in some cases. > >> > >> This patch might add three kinds of regression : > >> > >> 1

RE: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-22 Thread David Laight
From: Alexander Duyck > Sent: 22 February 2017 17:24 ... > So there is a problem that is being overlooked here. That is the cost > of the DMA map/unmap calls. The problem is many PowerPC systems have > an IOMMU that you have to work around, and that IOMMU comes at a heavy > cost for every map/unm

Re: [PATCH net-next v4 4/7] gtp: consolidate gtp socket rx path

2017-02-22 Thread Tom Herbert
On Tue, Feb 21, 2017 at 2:18 AM, Andreas Schultz wrote: > Add network device to gtp context in preparation for splitting > the TEID from the network device. > > Use this to rework the socker rx path. Move the common RX part > of v0 and v1 into a helper. Also move the final rx part into > that help

[BUG] vmxnet3: random freeze regression

2017-02-22 Thread Stephen Hemminger
I get the bugzilla reports for networking, and I see several reports of vmxnet3 hanging with 4.8 and later kernels. Is this a know issue? https://bugzilla.kernel.org/show_bug.cgi?id=191201

Please I want you to patiently read this offer.?

2017-02-22 Thread Mr.Hassan Habib
Hello. I know this means of communication may not be morally right to you as a person but I also have had a great thought about it and I have come to this conclusion which I am about to share with you. INTRODUCTION:I am the Credit Manager U. B. A Bank of Burkina Faso Ouagadougou and in one way

netvsc NAPI

2017-02-22 Thread Stephen Hemminger
NAPI for netvsc is ready but the merge coordination is a nuisance. Since netvsc NAPI support requires other changes that are proceeding through GregKH's char-misc tree. I would like to send the two patches after current net-next and char-misc-next are merged into Linus's tree. Need these (at a m

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-22 Thread Alexander Duyck
On Wed, Feb 22, 2017 at 8:22 AM, Eric Dumazet wrote: > On Mon, 2017-02-13 at 11:58 -0800, Eric Dumazet wrote: >> Use of order-3 pages is problematic in some cases. >> >> This patch might add three kinds of regression : >> >> 1) a CPU performance regression, but we will add later page >> recycling

Re: Focusing the XDP project

2017-02-22 Thread Tom Herbert
On Wed, Feb 22, 2017 at 1:43 AM, Jesper Dangaard Brouer wrote: > > On Tue, 21 Feb 2017 14:54:35 -0800 Tom Herbert wrote: >> On Tue, Feb 21, 2017 at 2:29 PM, Saeed Mahameed >> wrote: > [...] >> > The only complexity XDP is adding to the drivers is the constrains on >> > RX memory management and

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-22 Thread John Fastabend
On 17-02-21 12:46 AM, Jason Wang wrote: > This patch switch to use build_skb() for small buffer which can have > better performance for both TCP and XDP (since we can work at page > before skb creation). It also remove lots of XDP codes since both > mergeable and small buffer use page frag during r

Re: Questions on XDP

2017-02-22 Thread John Fastabend
On 17-02-21 09:44 AM, Alexander Duyck wrote: > On Mon, Feb 20, 2017 at 11:55 PM, Alexei Starovoitov > wrote: >> On Mon, Feb 20, 2017 at 08:00:57PM -0800, Alexander Duyck wrote: >>> >>> I assumed "toy Tx" since I wasn't aware that they were actually >>> allowing writing to the page. I think that m

[PATCH RFC v2 12/12] test: add sendmsg zerocopy tests

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn Introduce the tests uses to verify MSG_ZEROCOPY behavior: snd_zerocopy: send zerocopy fragments out over the default route. snd_zerocopy_lo: send data between a pair of local sockets and report throughput. These tests are not suitable for inclusion in /tools/testing/

[PATCH RFC v2 09/12] udp: enable sendmsg zerocopy

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn Add MSG_ZEROCOPY support to inet/dgram. This includes udplite. Tested: loopback test snd_zerocopy_lo -u -z produces without zerocopy (-u): rx=173940 (10854 MB) tx=173940 txc=0 rx=367026 (22904 MB) tx=367026 txc=0 rx=564078 (35201 MB) tx=564078 txc=0 rx

[PATCH RFC v2 11/12] packet: enable sendmsg zerocopy

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn Support MSG_ZEROCOPY on PF_PACKET transmission. Tested: pf_packet loopback test snd_zerocopy_lo -p -z produces: without zerocopy (-p): rx=0 (0 MB) tx=221696 txc=0 rx=0 (0 MB) tx=443880 txc=0 rx=0 (0 MB) tx=661056 txc=0 rx=0 (0 MB) tx=877152 txc=0 wi

[PATCH RFC v2 07/12] sock: sendmsg zerocopy limit bytes per notification

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn Zerocopy can coalesce notifications of up to 65535 send calls. Excessive coalescing increases notification latency and process working set size. Experiments showed trains of 75 syscalls holding around 8 MB of data per notification. On servers with many slower clients, this

[PATCH RFC v2 10/12] raw: enable sendmsg zerocopy with IP_HDRINCL

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn Tested: raw loopback test snd_zerocopy_lo -r -z produces: without zerocopy (-r): rx=97632 (6092 MB) tx=97632 txc=0 rx=208194 (12992 MB) tx=208194 txc=0 rx=318714 (19889 MB) tx=318714 txc=0 rx=429126 (26779 MB) tx=429126 txc=0 with zerocopy (-r -z):

[PATCH RFC v2 05/12] sock: sendmsg zerocopy notification coalescing

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn In the simple case, each sendmsg() call generates data and eventually a zerocopy ready notification N, where N indicates the Nth successful invocation of sendmsg() with the MSG_ZEROCOPY flag on this socket. TCP and corked sockets can cause sendmsg() calls to append to a si

[PATCH RFC v2 06/12] sock: sendmsg zerocopy ulimit

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn Bound the number of pages that a user may pin. Follow the lead of perf tools to maintain a per-user bound on memory locked pages commit 789f90fcf6b0 ("perf_counter: per user mlock gift") Signed-off-by: Willem de Bruijn --- include/linux/sched.h | 2 +- include/linux/s

[PATCH RFC v2 00/12] socket sendmsg MSG_ZEROCOPY

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn RFCv2: I have received a few requests for status and rebased code of this feature. We have been running this code internally, discovering and fixing various bugs. With net-next closed, now seems like a good time to share an updated patchset with fixes. The rebase from RFCv

[PATCH RFC v2 02/12] sock: skb_copy_ubufs support for compound pages

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn Refine skb_copy_ubufs to support compount pages. With upcoming TCP and UDP zerocopy sendmsg, such fragments may appear. These skbuffs can have both kernel and zerocopy fragments, e.g., when corking. Avoid unnecessary copying of fragments that have no userspace reference.

[PATCH RFC v2 04/12] sock: enable sendmsg zerocopy

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn Prepare the datapath for refcounted ubuf_info. Clone ubuf_info with skb_zerocopy_clone() wherever needed due to skb split, merge, resize or clone. Split skb_orphan_frags into two variants. The split, merge, .. paths support reference counted zerocopy buffers, so do not do

[PATCH RFC v2 01/12] sock: allocate skbs from optmem

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn Add sock_omalloc and sock_ofree to be able to allocate control skbs, for instance for looping errors onto sk_error_queue. The transmit budget (sk_wmem_alloc) is involved in transmit skb shaping, most notably in TCP Small Queues. Using this budget for control packets would

[PATCH RFC v2 08/12] tcp: enable sendmsg zerocopy

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn Enable support for MSG_ZEROCOPY to the TCP stack. Data that is sent to a remote host will be zerocopy. TSO and GSO are supported. Tested: A 10x TCP_STREAM between two hosts showed a reduction in netserver process cycles by up to 70%, depending on packet size. Systemwid

[PATCH RFC v2 03/12] sock: add generic socket zerocopy

2017-02-22 Thread Willem de Bruijn
From: Willem de Bruijn The kernel supports zerocopy sendmsg in virtio and tap. Expand the infrastructure to support other socket types. Introduce a completion notification channel over the socket error queue. Notifications are returned with ee_origin SO_EE_ORIGIN_ZEROCOPY. ee_errno is 0 to avoid

[PATCH net V2 5/5] net/mlx4_en: Use __skb_fill_page_desc()

2017-02-22 Thread Tariq Toukan
From: Eric Dumazet Or we might miss the fact that a page was allocated from memory reserves. Fixes: dceeab0e5258 ("mlx4: support __GFP_MEMALLOC for rx") Signed-off-by: Eric Dumazet Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 8 1 file changed, 4 inser

[PATCH net V2 1/5] net/mlx4: Change ENOTSUPP to EOPNOTSUPP

2017-02-22 Thread Tariq Toukan
From: Or Gerlitz As ENOTSUPP is specific to NFS, change the return error value to EOPNOTSUPP in various places in the mlx4 driver. Signed-off-by: Or Gerlitz Suggested-by: Yotam Gigi Reviewed-by: Matan Barak Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c

[PATCH net V2 4/5] net/mlx4_core: Use cq quota in SRIOV when creating completion EQs

2017-02-22 Thread Tariq Toukan
From: Jack Morgenstein When creating EQs to handle CQ completion events for the PF or for VFs, we create enough EQE entries to handle completions for the max number of CQs that can use that EQ. When SRIOV is activated, the max number of CQs a VF (or the PF) can obtain is its CQ quota (determined

[PATCH net V2 2/5] net/mlx4: Spoofcheck and zero MAC can't coexist

2017-02-22 Thread Tariq Toukan
From: Eugenia Emantayev Spoofcheck can't be enabled if VF MAC is zero. Vice versa, can't zero MAC if spoofcheck is on. Fixes: 8f7ba3ca12f6 ('net/mlx4: Add set VF mac address support') Signed-off-by: Eugenia Emantayev Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/cmd.c

[PATCH net V2 0/5] mlx4 misc fixes

2017-02-22 Thread Tariq Toukan
Hi Dave, This patchset contains misc bug fixes from Eric Dumazet and our team to the mlx4 Core and Eth drivers. Series generated against net commit: 00ea1ceebe0d ipv6: release dst on error in ip6_dst_lookup_tail Thanks, Tariq. v2: * Added Eric's fix (patch 5/5). Eric Dumazet (1): net/mlx4_en

[PATCH net V2 3/5] net/mlx4_core: Fix VF overwrite of module param which disables DMFS on new probed PFs

2017-02-22 Thread Tariq Toukan
From: Majd Dibbiny In the VF driver, module parameter mlx4_log_num_mgm_entry_size was mistakenly overwritten -- and in a manner which overrode the device-managed flow steering option encoded in the parameter. log_num_mgm_entry_size is a global module parameter which affects all ConnectX-3 PFs in

Re: [PATCH net 0/4] mlx4 misc fixes

2017-02-22 Thread Tariq Toukan
On 22/02/2017 2:33 PM, Tariq Toukan wrote: Hi Dave, This patchset contains misc bug fixes from the team to the mlx4 Core and Eth drivers. Series generated against net commit: 00ea1ceebe0d ipv6: release dst on error in ip6_dst_lookup_tail Thanks, Tariq. Please ignore this one. I am submitt

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-22 Thread Eric Dumazet
On Mon, 2017-02-13 at 11:58 -0800, Eric Dumazet wrote: > Use of order-3 pages is problematic in some cases. > > This patch might add three kinds of regression : > > 1) a CPU performance regression, but we will add later page > recycling and performance should be back. > > 2) TCP receiver could g

[PATCH net 2/6] net/mlx5e: Register/unregister vport representors on interface attach/detach

2017-02-22 Thread Saeed Mahameed
Currently vport representors are added only on driver load and removed on driver unload. Apparently we forgot to handle them when we added the seamless reset flow feature. This caused to leave the representors netdevs alive and active with open HW resources on pci shutdown and on error reset flow

[PATCH net 1/6] net/mlx5e: s390 system compilation fix

2017-02-22 Thread Saeed Mahameed
From: Mohamad Haj Yahia Add necessary headers include for s390 arch compilation. Fixes: e586b3b0baee ("net/mlx5: Ethernet Datapath files") Fixes: d605d6686dc7 ("net/mlx5e: Add support for ethtool self..") Signed-off-by: Mohamad Haj Yahia Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/

[PATCH net 5/6] net/mlx5e: Update MPWQE stride size when modifying CQE compress state

2017-02-22 Thread Saeed Mahameed
When the admin enables/disables cqe compression, updating mpwqe stride size is required: CQE compress ON ==> stride size = 256B CQE compress OFF ==> stride size = 64B This is already done on driver load via mlx5e_set_rq_type_params, all we need is just to call it on arbitrary admin change

  1   2   >