From: Jacob Keller
On Big Endian platforms we would incorrectly calculate the wrong switch
id since we did not properly convert the le16 value into CPU format.
Caught by sparse.
Change-ID: I69a2f9fa064a0a91691f7d0e6fcc206adceb8e36
Signed-off-by: Jacob Keller
Tested-by: Andrew Bowers
Signed-off
From: Harshitha Ramamurthy
There exists an intermittent bug which causes the 'Link Detected'
field reported by the 'ethtool ' command to be 'Yes' when
in fact, there is no link. This patch fixes the problem by
enabling temporary link polling when i40e_get_link_status returns
an error. This causes
From: Jacob Keller
This call is made just prior to running i40e_link_event. In
i40e_link_event, we set hw->phy.get_link_info to true just prior to
calling i40e_get_link_status, which conveniently runs
i40e_update_link_info for us. Thus, we are running i40e_update_link_info
twice, which seems like
From: Carolyn Wyborny
This patch fixes a bug introduced with the addition of the per queue
ITR feature support in ethtool. With that addition, there were
functions added which converted the ITR settings to binary values.
The IS_ENABLED macros that run on those values check whether a bit
is set o
From: Mitch Williams
When the i40evf_remove() calls netdev close, the device doesn't actually
close - it schedules the work for the watchdog to perform. Since we're
stopping the watchdog, this work doesn't get done. However, we're
resetting the part, so we can free resources after the reset reque
From: Alan Brady
This patch refactors the '%*ph' printk format specifier to instead use
the print_hex_dump function, as recommended by the '%*ph' documentation.
This produces better/more standardized output.
Change-ID: Id56700b4e8abc40ff8c04bc8379e7df04cb4d6fd
Signed-off-by: Alan Brady
Tested-b
From: Joshua Hay
This patch adds a call to the mac_address_write admin q function during
power down to update the PRTPM_SAH/SAL registers with the MC_MAG_EN bit
thus enabling multicast magic packet wakeup.
A FW workaround is needed to write the multicast magic wake up enable
bit in the PRTPM_SAH
From: Jacob Keller
This ensures that the pvid which is stored in __le16 format is converted
to the CPU format. This will fix comparison issues on Big Endian
platforms.
Change-ID: I92c80d1315dc2a0f9f095d5a0c48d461beb052ed
Signed-off-by: Jacob Keller
Tested-by: Andrew Bowers
Signed-off-by: Jeff
This series contains updates to i40e and i40evf only.
Alan fixes a bug in which the driver is unable to exit overflow
promiscuous mode after having added "too many" mac filters. Ractored
the '%*ph' printk format specifier to instead use the print_hex_dump().
Josh adds enabling multicast magic pa
From: Benjamin Poirier
The following message is logged from time to time when using i40e:
NOHZ: local_softirq_pending 08
i40e may schedule napi from a workqueue. Afterwards, softirqs are not run
in a deterministic time frame. The problem is the same as what was
described in commit ec13ee80145c (
From: Jacob Keller
Fix, or rather, avoid a sparse warning caused by the fact that
csum_replace_by_diff expects to receive a __wsum value. Since the
calculation appears to work, simply typecast the passed paylen value to
__wsum to avoid the warning.
This seems pretty fishy since __wsum was obviou
From: Carolyn Wyborny
Signed-off-by: Carolyn Wyborny
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
b/drivers/net/ethernet/intel/i40e/i40e_main
From: Mitch Williams
Add a comment to reduce confusion.
Change-ID: I3d5819c0f3f5174680442ae54398a073d4a61f4f
Signed-off-by: Mitch Williams
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/i40evf/i40evf_main.c | 5 +
1 file changed, 5 insertions(+)
diff
From: Alan Brady
There exists a bug in which the driver is unable to exit overflow
promiscuous mode after having added "too many" mac filters. It is
expected that after triggering overflow promiscuous, removing the
failed/extra filters should then disable overflow promiscuous mode.
The bug exis
On Thu, 2017-02-16 at 19:43 +0200, Sagi Grimberg wrote:
> Signed-off-by: Sagi Grimberg
> ---
> drivers/target/iscsi/iscsi_target_configfs.c | 46
>
> 1 file changed, 12 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/target/iscsi/iscsi_target_configfs.c
> b
From: "Michael S. Tsirkin"
Date: Sun, 19 Feb 2017 07:17:17 +0200
> Dave, could you merge this before 4.10? If not - I can try.
I just sent my last pull request to Linus, please merge it to
him directly.
Thanks.
On Sat, Feb 18, 2017 at 06:28:39PM +0100, Dmitry Vyukov wrote:
> On Fri, Feb 10, 2017 at 6:17 AM, Jason Wang wrote:
> >
> >
> > On 2017年02月10日 02:10, Michael S. Tsirkin wrote:
> >>
> >> On Thu, Feb 09, 2017 at 05:02:31AM -0500, Jason Wang wrote:
> >>>
> >>> - Original Message -
>
> >>
On Fri, Feb 17, 2017 at 01:10:08PM +0800, Jason Wang wrote:
>
>
> On 2017年02月17日 12:53, John Fastabend wrote:
> > On 17-02-15 01:08 AM, Jason Wang wrote:
> > > We set queues before reset which will cause a crash[1]. This is
> > > because is_xdp_raw_buffer_queue() depends on the old xdp queue pair
Resizing currently drops consumer lock. This can cause entries to be
reordered, which isn't good in itself. More importantly, consumer can
detect a false ring empty condition and block forever.
Further, nesting of consumer within producer lock is problematic for
tun, since it produces entries in
One last brown-paper-bag fix for the release. If we fail the ipv4
mapped source address check, we have to release the route. From
Willem de Bruijn.
Please pull, thanks a lot!
The following changes since commit 2763f92f858f7c4c3198335c0542726eaed07ba3:
Merge tag 'fixes-for-linus' of
git://g
From: Willem de Bruijn
Date: Sat, 18 Feb 2017 19:00:45 -0500
> From: Willem de Bruijn
>
> If ip6_dst_lookup_tail has acquired a dst and fails the IPv4-mapped
> check, release the dst before returning an error.
>
> Fixes: ec5e3b0a1d41 ("ipv6: Inhibit IPv4-mapped src address on the wire.")
> Sig
On 17-02-18 06:16 PM, Alexander Duyck wrote:
> On Sat, Feb 18, 2017 at 3:48 PM, John Fastabend
> wrote:
>> On 17-02-18 03:31 PM, Alexei Starovoitov wrote:
>>> On Sat, Feb 18, 2017 at 10:18 AM, Alexander Duyck
>>> wrote:
> XDP_DROP does not require having one page per frame.
Agr
On Sat, Feb 18, 2017 at 3:48 PM, John Fastabend
wrote:
> On 17-02-18 03:31 PM, Alexei Starovoitov wrote:
>> On Sat, Feb 18, 2017 at 10:18 AM, Alexander Duyck
>> wrote:
>>>
XDP_DROP does not require having one page per frame.
>>>
>>> Agreed.
>>
>> why do you think so?
>> xdp_drop is targeting
On Wed, 15 Feb 2017 15:23:10 +0100
Nikolay Aleksandrov wrote:
> Hi,
> This set adds support for printing link xstats per link type. Currently
> only the bridge and its ports support such call and it dumps the mcast
> stats. This model makes it easy to use the same callback for both bridge
> and b
On Tue, 14 Feb 2017 07:29:38 +0200
Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> Prior to parsing command options, the devlink tool allocates memory
> to store results. In case of early exit (wrong parameters or version
> check), this memory wasn't freed.
>
> Signed-off-by: Leon Romanovsk
On Fri, 10 Feb 2017 18:28:54 -0500
Lucas Bates wrote:
> Signed-off-by: Lucas Bates
> Signed-off-by: Jamal Hadi Salim
> Signed-off-by: Roman Mashak
Applied to master branch.
On Sat, 2017-02-18 at 19:00 -0500, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> If ip6_dst_lookup_tail has acquired a dst and fails the IPv4-mapped
> check, release the dst before returning an error.
>
> Fixes: ec5e3b0a1d41 ("ipv6: Inhibit IPv4-mapped src address on the wire.")
> Signed-
On Fri, 10 Feb 2017 06:25:44 -0500
Jamal Hadi Salim wrote:
> From: Jamal Hadi Salim
>
> Make use of 128b user cookies
>
> Introduce optional 128-bit action cookie.
> Like all other cookie schemes in the networking world (eg in protocols
> like http or existing kernel fib protocol field, etc) t
On Fri, 10 Feb 2017 06:25:43 -0500
Jamal Hadi Salim wrote:
> From: Jamal Hadi Salim
>
> hex2mem() api is useful for parsing hexstrings which are then packed in
> a stream of chars.
>
> Signed-off-by: Jamal Hadi Salim
I went ahead and applied this part since it makes sense to have it now.
The
On Thu, 9 Feb 2017 14:48:58 +0100
Simon Horman wrote:
> Hi,
>
> this short series allows the tc tool to configure masked matches on the
> ICMP code and type. Unmasked matches are already supported by the tool.
>
> This does not depend on any kernel changes as support for both masked and
> unma
On Thu, 16 Feb 2017 08:58:54 -0800
David Ahern wrote:
> More updates to ip vrf for 4.10. Major changes: handle vrf in an existing
> cgroup hierarchy and handle vrf nesting in network namespaces.
>
> Comparison of the netns in bpf code will be added once the kernel patch
> is accepted.
>
> David
On Wed, 15 Feb 2017 21:26:41 +
Asbjørn Sloth Tønnesen wrote:
> Signed-off-by: Asbjørn Sloth Tønnesen
Both applied thanks
On Thu, 9 Feb 2017 15:10:14 +0200
Or Gerlitz wrote:
> Print the skip flags when we dump a filter.
>
> Signed-off-by: Or Gerlitz
> Acked by: Yotam Gigi
Applied, thanks
On Mon, 13 Feb 2017 12:21:53 -0800
David Ahern wrote:
> iproute2 can inconsistently show the name of protocol 0 if a route with
> a custom protocol is added. For example:
> dsa@cartman:~$ ip -6 ro ls table all | egrep 'proto none|proto unspec'
> local ::1 dev lo table local proto none metr
From: Willem de Bruijn
If ip6_dst_lookup_tail has acquired a dst and fails the IPv4-mapped
check, release the dst before returning an error.
Fixes: ec5e3b0a1d41 ("ipv6: Inhibit IPv4-mapped src address on the wire.")
Signed-off-by: Willem de Bruijn
---
net/ipv6/ip6_output.c | 6 --
1 file c
On Sat, Feb 18, 2017 at 3:48 PM, John Fastabend
wrote:
>
> We are running our vswitch in userspace now for many workloads
> it would be nice to have these in kernel if possible.
...
> Maybe Alex had something else in mind but we have many virtual interfaces
> plus physical interfaces in vswitch us
On Sat, 2017-02-18 at 15:48 -0800, John Fastabend wrote:
> I'm not seeing the distinction here. If its a 4k page and
> in the stack the driver will get overrun as well.
Agree.
Using a full page per Ethernet frame does not change the attack vector.
It makes attacker job easier.
> But looks like the commit sha1 was
> ec5e3b0a1d41fbda0cc33a45bc9e54e91d9d12c7
>
> So the correct tag would be
>
> Fixes: ec5e3b0a1d41 ("ipv6: Inhibit IPv4-mapped src address on the wire.")
Thanks for catching that! I'll send a v2 with the fixed commit.
On Sat, 2017-02-18 at 18:51 -0500, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> If ip6_dst_lookup_tail has acquired a dst and fails the IPv4-mapped
> check, release the dst before returning an error.
>
> Fixes: b2e6f0c8dde5 ("ipv6: Inhibit IPv4-mapped src address on the wire.")
> Signed-
From: Willem de Bruijn
If ip6_dst_lookup_tail has acquired a dst and fails the IPv4-mapped
check, release the dst before returning an error.
Fixes: b2e6f0c8dde5 ("ipv6: Inhibit IPv4-mapped src address on the wire.")
Signed-off-by: Willem de Bruijn
---
net/ipv6/ip6_output.c | 6 --
1 file c
On 17-02-18 03:31 PM, Alexei Starovoitov wrote:
> On Sat, Feb 18, 2017 at 10:18 AM, Alexander Duyck
> wrote:
>>
>>> XDP_DROP does not require having one page per frame.
>>
>> Agreed.
>
> why do you think so?
> xdp_drop is targeting ddos where in good case
> all traffic is passed up and in bad cas
From: Colin Ian King
trivial fix to spelling mistake, en_tsu_err_exeption should
be en_tsu_err_exception
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/freescale/fman/fman_dtsec.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale
On 17-02-18 10:18 AM, Alexander Duyck wrote:
> On Sat, Feb 18, 2017 at 9:41 AM, Eric Dumazet wrote:
>> On Sat, 2017-02-18 at 17:34 +0100, Jesper Dangaard Brouer wrote:
>>> On Thu, 16 Feb 2017 14:36:41 -0800
>>> John Fastabend wrote:
>>>
On 17-02-16 12:41 PM, Alexander Duyck wrote:
> So I
On Sat, Feb 18, 2017 at 10:18 AM, Alexander Duyck
wrote:
>
>> XDP_DROP does not require having one page per frame.
>
> Agreed.
why do you think so?
xdp_drop is targeting ddos where in good case
all traffic is passed up and in bad case
most of the traffic is dropped, but good traffic still needs
t
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet/qlogic/qla3xxx.c | 29 ++
kstrtouint() can return a couple different error codes so the check for
"ret == -EINVAL" is wrong and static analysis tools correctly complain
that we can use "num" without initializing it. It's not super harmful
because we check the bounds. But it's also easy enough to fix.
Signed-off-by: Dan C
On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
Did not apply on linux-next-20170217
>
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/megaraid
On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote:
Tested all patches by compilation and checkpatch. All of them compile
fine, but patches 11 and 12 need some fixes. You can resend as
PATCH instead of RFC.
> The current PCI pool API are simple macro functions direct expanded to
> the
On Sat, Feb 18, 2017 at 09:35:48AM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
Please run checkpatch, fix the style issue and resend.
>
> Signed-off-by: Romain Perier
> ---
> driv
On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote:
Hi Romain,
Checkpatch gives some warnings you can fix related to NULL tests before
dma_pool_destroy(), and you changed indentation style in some of your
changes. Some times it is important to keep consistency within a file
even if the
From: Eric Dumazet
Since mlx4 NIC are used on PowerPC with 64K pages, we need to adapt
MLX4_EN_ALLOC_PREFER_ORDER definition.
Otherwise, a fragment sitting in an out of order TCP queue can hold
0.5 Mbytes and it is a serious OOM risk.
Fixes: 51151a16a60f ("mlx4: allow order-0 memory allocations
On Sat, Feb 18, 2017 at 9:41 AM, Eric Dumazet wrote:
> On Sat, 2017-02-18 at 17:34 +0100, Jesper Dangaard Brouer wrote:
>> On Thu, 16 Feb 2017 14:36:41 -0800
>> John Fastabend wrote:
>>
>> > On 17-02-16 12:41 PM, Alexander Duyck wrote:
>> > > So I'm in the process of working on enabling XDP for t
This patch is to add support for MSG_MORE on sctp.
It adds force_delay in sctp_datamsg to save MSG_MORE, and sets it after
creating datamsg according to the send flag. sctp_packet_can_append_data
then uses it to decide if the chunks of this msg will be sent at once or
delay it.
Note that unlike [
Le 18/02/2017 à 14:06, Greg Kroah-Hartman a écrit :
> On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote:
>> The current PCI pool API are simple macro functions direct expanded to
>> the appropriated dma pool functions. The prototypes are almost the same
>> and semantically, they are v
This patch is to add support for MSG_MORE on sctp. Patch 1/2 is an
improvement ahead of patch 2/2 to solve the close block problem
mentioned in https://patchwork.ozlabs.org/patch/372404/.
Xin Long (2):
sctp: flush out queue once assoc state falls into SHUTDOWN_PENDING
sctp: add support for MSG
This patch is to flush out queue when assoc state falls into
SHUTDOWN_PENDING if there are still chunks in it, so that the
data can be sent out as soon as possible before sending SHUTDOWN
chunk.
When sctp supports MSG_MORE flag in next patch, this improvement
can also solve the problem that the ch
On Sat, 2017-02-18 at 17:34 +0100, Jesper Dangaard Brouer wrote:
> On Thu, 16 Feb 2017 14:36:41 -0800
> John Fastabend wrote:
>
> > On 17-02-16 12:41 PM, Alexander Duyck wrote:
> > > So I'm in the process of working on enabling XDP for the Intel NICs
> > > and I had a few questions so I just thou
On Sat, Feb 18, 2017 at 6:28 PM, Dmitry Vyukov wrote:
> On Fri, Feb 10, 2017 at 6:17 AM, Jason Wang wrote:
>>
>>
>> On 2017年02月10日 02:10, Michael S. Tsirkin wrote:
>>>
>>> On Thu, Feb 09, 2017 at 05:02:31AM -0500, Jason Wang wrote:
- Original Message -
>
> Hello,
>
>
On Fri, Feb 10, 2017 at 6:17 AM, Jason Wang wrote:
>
>
> On 2017年02月10日 02:10, Michael S. Tsirkin wrote:
>>
>> On Thu, Feb 09, 2017 at 05:02:31AM -0500, Jason Wang wrote:
>>>
>>> - Original Message -
Hello,
I've got the following report while running syzkaller fuzzer on
On 02/18/2017 02:50 PM, Lino Sanfilippo wrote:
Hi,
On 17.02.2017 22:07, Pavel Belous wrote:
From: Pavel Belous
We should allocate the number of pages based on the config parameter
AQ_CFG_RX_FRAME_MAX.
Signed-off-by: Pavel Belous
do {
if (spin_trylock(&ring->head
On 02/18/2017 02:56 PM, Lino Sanfilippo wrote:
Hi,
On 17.02.2017 22:07, Pavel Belous wrote:
From: Pavel Belous
The following patchset contains improvements and fixes for aQuantia
AQtion ethernet driver from net-next tree.
Most fixes are based on the comments from Lino Sanfilippo.
Sanity te
On 02/18/2017 01:43 AM, Andrew Lunn wrote:
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
index 4c40644..0877625 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
On Thu, 16 Feb 2017 14:36:41 -0800
John Fastabend wrote:
> On 17-02-16 12:41 PM, Alexander Duyck wrote:
> > So I'm in the process of working on enabling XDP for the Intel NICs
> > and I had a few questions so I just thought I would put them out here
> > to try and get everything sorted before I p
On Sat, Feb 18, 2017 at 4:19 AM, David Miller wrote:
> From: Xin Long
> Date: Fri, 17 Feb 2017 16:35:24 +0800
>
>
>> + list = rhltable_lookup(&sctp_transport_hashtable, &arg,
>> +sctp_hash_params);
>> +
>> + rhl_for_each_entry_rcu(transport, tmp, list, node)
>>
On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote:
> The current PCI pool API are simple macro functions direct expanded to
> the appropriated dma pool functions. The prototypes are almost the same
> and semantically, they are very similar. I propose to use the DMA pool
> API directly a
In order to clarify what the module actually does, and how to use it,
let's add some basic documentation to the kernel tree, together with
pointers to related specs and projects.
Signed-off-by: Harald Welte
---
Documentation/networking/gtp.txt | 135 +++
1 fil
On Sat, Feb 18, 2017 at 09:35:37AM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
no new errors added, tested by compilation only.
> Signed-off-by: Romain Perier
> Acked-by: Peter S
Hi,
On 17.02.2017 22:07, Pavel Belous wrote:
> From: Pavel Belous
>
> The following patchset contains improvements and fixes for aQuantia
> AQtion ethernet driver from net-next tree.
>
> Most fixes are based on the comments from Lino Sanfilippo.
>
> Sanity testing was performed on real HW. No
Hi,
On 17.02.2017 22:07, Pavel Belous wrote:
> From: Pavel Belous
>
> We should allocate the number of pages based on the config parameter
> AQ_CFG_RX_FRAME_MAX.
>
> Signed-off-by: Pavel Belous
> do {
> if (spin_trylock(&ring->header.lock)) {
> - frags
Both functions aq_ring_rx_deinit() and aq_ring_tx_clean() are almost
identical aside from an additional check in the latter.
Move that check from the function into its caller and replace
aq_ring_rx_deinit() with aq_ring_rx_deinit().
By doing this also adjust the functions return value from int to
The check in ena_remove() for the pci driver data not being NULL is not
needed, since it is always set in the probe() function. Remove the
superfluous check.
Signed-off-by: Lino Sanfilippo
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/d
Hi,
On 18.02.2017 3:56, Alexey Kodanev wrote:
> Found that when random offset enabled (default) TCP client can
> still start new connections with and without random offsets. Later,
> if server does active close and re-use sockets in TIME-WAIT state,
> new SYN from client can be rejected on PAWS che
72 matches
Mail list logo
