On Mon, 13 Feb 2017 12:21:53 -0800 David Ahern <d...@cumulusnetworks.com> wrote:
> iproute2 can inconsistently show the name of protocol 0 if a route with > a custom protocol is added. For example: > dsa@cartman:~$ ip -6 ro ls table all | egrep 'proto none|proto unspec' > local ::1 dev lo table local proto none metric 0 pref medium > local fe80::225:90ff:fecb:1c18 dev lo table local proto none metric 0 > pref medium > local fe80::92e2:baff:fe5c:da5d dev lo table local proto none metric 0 > pref medium > > protocol 0 is pretty printed as "none". Add a route with a custom protocol: > dsa@cartman:~$ sudo ip -6 ro add 2001:db8:200::1/128 dev eth0 proto 123 > > And now display has switched from "none" to "unspec": > dsa@cartman:~$ ip -6 ro ls table all | egrep 'proto none|proto unspec' > local ::1 dev lo table local proto unspec metric 0 pref medium > local fe80::225:90ff:fecb:1c18 dev lo table local proto unspec metric 0 > pref medium > local fe80::92e2:baff:fe5c:da5d dev lo table local proto unspec metric 0 > pref medium > > The rt_protos file has the id to name mapping as "unspec" while > rtnl_rtprot_tab[0] has "none". The presence of a custom protocol id > triggers reading the rt_protos file and overwriting the string in > rtnl_rtprot_tab. All of this is logic from 2004 and earlier. > > Update rtnl_rtprot_tab to "unspec" to match the enum value. > > Signed-off-by: David Ahern <d...@cumulusnetworks.com> Applied, thanks.
