Re: [PATCH] net: fix incorrect original ingress device index in PKTINFO

2016-12-28 Thread David Ahern
On 12/27/16 12:03 PM, David Miller wrote: > From: Wei Zhang > Date: Tue, 27 Dec 2016 17:52:24 +0800 > >> When we send a packet for our own local address on a non-loopback >> interface (e.g. eth0), due to the change had been introduced from >> commit 0b922b7a829c ("net: original ingress device ind

Re: [PATCH] net: ethernet: ti: davinci_cpdma: fix access to uninitialized variable in cpdma_chan_set_descs()

2016-12-28 Thread Ivan Khoronzhuk
On Wed, Dec 28, 2016 at 05:42:13PM -0600, Grygorii Strashko wrote: Grygorii, > Now below code sequence causes "Unable to handle kernel NULL pointer > dereference.." exception and system crash during CPSW CPDMA initialization: > > cpsw_probe > |-cpdma_chan_create (TX channel) > |-cpdma_chan_spli

Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe

2016-12-28 Thread Florian Fainelli
On 12/28/2016 04:28 PM, Kweh, Hock Leong wrote: >> Although this is required, we can't be doing it in all circumstances, we >> need to >> mimic what stmmac_drv_remove() does. >> >> Let me submit an incremental fix which takes care of mdio bus unregistration. >> -- >> Florian > > Noted & Thanks. W

RE: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe

2016-12-28 Thread Kweh, Hock Leong
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Thursday, December 29, 2016 2:43 AM > To: Kweh, Hock Leong ; David Miller > > Cc: joao.pi...@synopsys.com; peppe.cavall...@st.com; > seraphin.bonna...@st.com; alexandre.tor...@gmail.com; > manab...@gmail.co

RE: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe

2016-12-28 Thread Kweh, Hock Leong
> -Original Message- > From: Kishan Sandeep [mailto:sandeepkishan...@gmail.com] > Sent: Wednesday, December 28, 2016 7:56 PM > To: Kweh, Hock Leong > Cc: David Miller ; f.faine...@gmail.com; > joao.pi...@synopsys.com; peppe.cavall...@st.com; > seraphin.bonna...@st.com; alexandre.tor...@gma

[PATCH net] net: stmmac: Fix error path after register_netdev move

2016-12-28 Thread Florian Fainelli
Commit 5701659004d6 ("net: stmmac: Fix race between stmmac_drv_probe and stmmac_open") re-ordered how the MDIO bus registration and the network device are registered, but missed to unwind the MDIO bus registration in case we fail to register the network device. Fixes: 5701659004d6 ("net: stmmac: F

[PATCH] net: ethernet: ti: davinci_cpdma: fix access to uninitialized variable in cpdma_chan_set_descs()

2016-12-28 Thread Grygorii Strashko
Now below code sequence causes "Unable to handle kernel NULL pointer dereference.." exception and system crash during CPSW CPDMA initialization: cpsw_probe |-cpdma_chan_create (TX channel) |-cpdma_chan_split_pool |-cpdma_chan_set_descs(for TX channels) |-cpdma_chan_set_descs(for RX chann

Re: [RFC PATCH] i40e: enable PCIe relax ordering for SPARC

2016-12-28 Thread tndave
On 12/27/2016 04:40 PM, maowenan wrote: -Original Message- From: tndave [mailto:tushar.n.d...@oracle.com] Sent: Wednesday, December 28, 2016 6:28 AM To: maowenan; jeffrey.t.kirs...@intel.com; intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org; weiyongjun (A); Dingtianhong Su

[PATCH] Bluetooth: fix spelling mistake: "advetising" -> "advertising"

2016-12-28 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in BT_ERR_RATELIMITED error message Signed-off-by: Colin Ian King --- net/bluetooth/hci_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index e17aacb..0b4dba0

Re: [PATCHv2 net-next 00/16] net: mvpp2: add basic support for PPv2.2

2016-12-28 Thread Thomas Petazzoni
Hello, On Wed, 28 Dec 2016 12:06:44 -0500 (EST), David Miller wrote: > > This series depends on the series named "net: mvpp2: misc improvements > > and preparation patches". > > Please in the future only submit one patch series at a time. > > If I've told you that a large patch series is hard

Re: [PATCH] net: wan: slic_ds26522: fix spelling mistake: "configurated" -> "configured"

2016-12-28 Thread David Miller
From: Colin King Date: Wed, 28 Dec 2016 16:44:23 + > From: Colin Ian King > > trivial fix to spelling mistake in pr_info message > > Signed-off-by: Colin Ian King Applied, thanks.

Re: [PATCH] net: atm: Fix warnings in net/atm/lec.c when !CONFIG_PROC_FS

2016-12-28 Thread David Miller
From: Augusto Mecking Caringi Date: Wed, 28 Dec 2016 16:02:05 + > This patch fixes the following warnings when CONFIG_PROC_FS is not set: > > linux/net/atm/lec.c: In function ‘lane_module_cleanup’: > linux/net/atm/lec.c:1062:27: error: ‘atm_proc_root’ undeclared (first > use in this function

Re: [PATCH] net: avoid put_cmsg() possible copy longer data than input

2016-12-28 Thread David Miller
From: yuan linyu Date: Wed, 28 Dec 2016 22:34:23 +0800 > From: yuan linyu > > if CMSG_ALIGN(sizeof(struct cmsghdr)) > sizeof(struct cmsghdr), > original (cmlen - sizeof(struct cmsghdr)) may greater than > input len. You are doing a lot of unrelated cleanups in this change. This makes it hard

Re: [PATCH net 00/12] Mellanox 100G mlx5 fixes 28-12-2016

2016-12-28 Thread David Miller
From: Saeed Mahameed Date: Wed, 28 Dec 2016 14:58:30 +0200 > Some fixes for mlx5 core and ethernet driver. > > for -stable: > net/mlx5: Check FW limitations on log_max_qp before setting it > net/mlx5: Cancel recovery work in remove flow > net/mlx5: Avoid shadowing numa_node > net

Re: [PATCH net] net/sched: cls_flower: Fix missing addr_type in classify

2016-12-28 Thread David Miller
From: Paul Blakey Date: Wed, 28 Dec 2016 14:54:47 +0200 > Since we now use a non zero mask on addr_type, we are matching on its > value (IPV4/IPV6). So before this fix, matching on enc_src_ip/enc_dst_ip > failed in SW/classify path since its value was zero. > This patch sets the proper value of a

Re: [PATCH net-next] sctp: add pr_debug for tracking asocs not found

2016-12-28 Thread David Miller
From: Marcelo Ricardo Leitner Date: Wed, 28 Dec 2016 09:51:56 -0200 > This pr_debug may help identify why the system is generating some > Aborts. It's not something a sysadmin would be expected to use. > > Signed-off-by: Marcelo Ricardo Leitner Applied.

Re: [PATCH net-next RESEND 1/1] driver: ipvlan: Remove unnecessary ipvlan NULL check in ipvlan_count_rx

2016-12-28 Thread David Miller
From: f...@ikuai8.com Date: Wed, 28 Dec 2016 16:47:42 +0800 > From: Gao Feng > > There are three functions which would invoke the ipvlan_count_rx. They > are ipvlan_process_multicast, ipvlan_rcv_frame, and ipvlan_nf_input. > The former two functions already use the ipvlan directly before > ipvla

Re: [PATCH net-next RESEND 1/1] driver: ipvlan: Define common functions to decrease duplicated codes used to add or del IP address

2016-12-28 Thread David Miller
From: f...@ikuai8.com Date: Wed, 28 Dec 2016 16:46:51 +0800 > From: Gao Feng > > There are some duplicated codes in ipvlan_add_addr6/4 and > ipvlan_del_addr6/4. Now define two common functions ipvlan_add_addr > and ipvlan_del_addr to decrease the duplicated codes. > It could be helful to maintai

Re: [PATCH v3] net: dev_weight: TX/RX orthogonality

2016-12-28 Thread David Miller
From: Matthias Tafelmeier Date: Wed, 28 Dec 2016 10:42:14 +0100 > @@ -3428,6 +3428,8 @@ EXPORT_SYMBOL(netdev_max_backlog); > int netdev_tstamp_prequeue __read_mostly = 1; > int netdev_budget __read_mostly = 300; > int weight_p __read_mostly = 64;/* old backlog weight */ > +int dev_

[PATCH net-next rfc 3/6] net-tc: extract skip classify bit from tc_verd

2016-12-28 Thread Willem de Bruijn
From: Willem de Bruijn Packets sent by the IFB device skip subsequent tc classification. A single bit governs this state. Move it out of tc_verd in anticipation of removing that __u16 completely. The new bitfield tc_skip_classify temporarily uses one bit of a hole, until tc_verd is removed compl

[PATCH net-next rfc 6/6] net-tc: convert tc_from to tc_from_ingress and tc_redirected

2016-12-28 Thread Willem de Bruijn
From: Willem de Bruijn The tc_from field fulfills two roles. It encodes whether a packet was redirected by an act_mirred device and, if so, whether act_mirred was called on ingress or egress. Split it into separate fields. The information is needed by the special IFB loop, where packets are take

[PATCH net-next rfc 2/6] net-tc: make MAX_RECLASSIFY_LOOP local

2016-12-28 Thread Willem de Bruijn
From: Willem de Bruijn This field is no longer kept in tc_verd. Remove it from the global definition of that struct. Signed-off-by: Willem de Bruijn --- include/uapi/linux/pkt_cls.h | 5 - net/sched/sch_api.c | 3 ++- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/

[PATCH net-next rfc 0/6] convert tc_verd to integer bitfields

2016-12-28 Thread Willem de Bruijn
From: Willem de Bruijn The skb tc_verd field takes up two bytes but uses far fewer bits. Convert the remaining use cases to bitfields that fit in existing holes (depending on config options) and potentially save the two bytes in struct sk_buff. This patchset is based on an earlier set by Florian

[PATCH net-next rfc 5/6] net-tc: convert tc_at to tc_at_ingress

2016-12-28 Thread Willem de Bruijn
From: Willem de Bruijn Field tc_at is used only within tc actions to distinguish ingress from egress processing. A single bit is sufficient for this purpose. Set it within tc_classify to make the scope clear and to avoid the need to clear it in skb_reset_tc. Signed-off-by: Willem de Bruijn ---

[PATCH net-next rfc 4/6] net-tc: convert tc_verd to integer bitfields

2016-12-28 Thread Willem de Bruijn
From: Willem de Bruijn Extract the remaining two fields from tc_verd and remove the __u16 completely. TC_AT and TC_FROM are converted to equivalent two-bit integer fields tc_at and tc_from. Where possible, use existing helper skb_at_tc_ingress when reading tc_at. Introduce helper skb_reset_tc to

[PATCH net-next rfc 1/6] net-tc: remove unused tc_verd fields

2016-12-28 Thread Willem de Bruijn
From: Willem de Bruijn Remove the last reference to tc_verd's munge and redirect ttl bits. These fields are no longer used. Signed-off-by: Willem de Bruijn --- include/uapi/linux/pkt_cls.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/lin

Re: [PATCH RESEND net-next 0/5] SCTP cleanups

2016-12-28 Thread David Miller
From: Marcelo Ricardo Leitner Date: Wed, 28 Dec 2016 09:26:30 -0200 > Some cleanups/simplifications I've been collecting. > Resending now with net-next open. Series applied, thanks.

Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe

2016-12-28 Thread Florian Fainelli
On 12/27/2016 09:49 PM, Kweh, Hock Leong wrote: >> -Original Message- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Wednesday, December 28, 2016 12:34 AM >> To: Kweh, Hock Leong >> Cc: joao.pi...@synopsys.com; peppe.cavall...@st.com; >> seraphin.bonna...@st.com; f.faine...@gm

[PATCH] drivers: atm: eni: rename macro DAUGTHER_ID to fix spelling mistake

2016-12-28 Thread Colin King
From: Colin Ian King Rename DAUGTHER_ID to DAUGHTER_ID to fix spelling mistake Signed-off-by: Colin Ian King --- drivers/atm/eni.c| 2 +- drivers/atm/midway.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c index 40c2d56..13fe61a

Re: [PATCHv2 net-next 00/16] net: mvpp2: add basic support for PPv2.2

2016-12-28 Thread David Miller
From: Thomas Petazzoni Date: Wed, 28 Dec 2016 17:46:16 +0100 > This series depends on the series named "net: mvpp2: misc improvements > and preparation patches". Please in the future only submit one patch series at a time. If I've told you that a large patch series is hard to review and that th

[PATCH net] rtnl: stats - add missing netlink message size checks

2016-12-28 Thread Mathias Krause
We miss to check if the netlink message is actually big enough to contain a struct if_stats_msg. Add a check to prevent userland from sending us short messages that would make us access memory beyond the end of the message. Fixes: 10c9ead9f3c6 ("rtnetlink: add new RTM_GETSTATS message to dump..."

ipv6: remove unnecessary inet6_sk check

2016-12-28 Thread Dave Jones
np is already assigned in the variable declaration of ping_v6_sendmsg. At this point, we have already dereferenced np several times, so the NULL check is also redundant. Suggested-by: Eric Dumazet Signed-off-by: Dave Jones diff --git a/net/ipv6/ping.c b/net/ipv6/ping.c index e1f8b34d7a2e..9b522

[PATCHv2 net-next 03/16] net: mvpp2: add hw_version field in "struct mvpp2"

2016-12-28 Thread Thomas Petazzoni
In preparation to the introduction for the support of PPv2.2 in the mvpp2 driver, this commit adds a hw_version field to the struct mvpp2, and uses the .data field of the DT match table to fill it in. Having the MVPP21 and MVPP22 definitions available will allow to start adding the necessary condi

[PATCHv2 net-next 09/16] net: mvpp2: adjust mvpp2_{rxq,txq}_init for PPv2.2

2016-12-28 Thread Thomas Petazzoni
In PPv2.2, the MVPP2_RXQ_DESC_ADDR_REG and MVPP2_TXQ_DESC_ADDR_REG registers have a slightly different layout, because they need to contain a 64-bit address for the RX and TX descriptor arrays. This commit adjusts those functions accordingly. Signed-off-by: Thomas Petazzoni --- drivers/net/ether

[PATCHv2 net-next 11/16] net: mvpp2: handle misc PPv2.1/PPv2.2 differences

2016-12-28 Thread Thomas Petazzoni
This commit handles a few miscellaneous differences between PPv2.1 and PPv2.2 in different areas, where code done for PPv2.1 doesn't apply for PPv2.2 or needs to be adjusted (getting the MAC address, disabling PHY polling, etc.). Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/m

[PATCHv2 net-next 05/16] net: mvpp2: introduce PPv2.2 HW descriptors and adapt accessors

2016-12-28 Thread Thomas Petazzoni
This commit adds the definition of the PPv2.2 HW descriptors, adjusts the mvpp2_tx_desc and mvpp2_rx_desc structures accordingly, and adapts the accessors to work on both PPv2.1 and PPv2.2. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 109 +++

[PATCHv2 net-next 06/16] net: mvpp2: adjust the allocation/free of BM pools for PPv2.2

2016-12-28 Thread Thomas Petazzoni
This commit adjusts the allocation and freeing of BM pools to support PPv2.2. This involves: - Checking that the number of buffer pointers is a multiple of 16, as required by the hardware. - Adjusting the size of the DMA coherent area allocated for buffer pointers. Indeed, PPv2.2 needs sp

[PATCHv2 net-next 10/16] net: mvpp2: handle register mapping and access for PPv2.2

2016-12-28 Thread Thomas Petazzoni
This commit adjusts the mvpp2 driver register mapping and access logic to support PPv2.2, to handle a number of differences. Due to how the registers are laid out in memory, the Device Tree binding for the "reg" property is different: - On PPv2.1, we had a first area for the common registers, an

[PATCHv2 net-next 07/16] net: mvpp2: adapt the mvpp2_rxq_*_pool_set functions to PPv2.2

2016-12-28 Thread Thomas Petazzoni
The MVPP2_RXQ_CONFIG_REG register has a slightly different layout between PPv2.1 and PPv2.2, so this commit adapts the functions modifying this register to accommodate for both the PPv2.1 and PPv2.2 cases. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 32

[PATCHv2 net-next 00/16] net: mvpp2: add basic support for PPv2.2

2016-12-28 Thread Thomas Petazzoni
Hello, The goal of this patch series is to add basic support for PPv2.2 in the existing mvpp2 driver. mvpp2 currently supported the PPv2.1 version of the IP, used in the 32 bits Marvell Armada 375 SoC. PPv2.2 is an evolution of this IP block, used in the 64 bits Marvell Armada 7K/8K SoCs. In orde

[PATCHv2 net-next 15/16] net: mvpp2: add support for an additional clock needed for PPv2.2

2016-12-28 Thread Thomas Petazzoni
The PPv2.2 variant of the network controller needs an additional clock, the "MG clock" in order for the IP block to operate properly. This commit adds support for this additional clock to the driver, reworking as needed the error handling path. Signed-off-by: Thomas Petazzoni --- drivers/net/eth

[PATCHv2 net-next 12/16] net: mvpp2: add AXI bridge initialization for PPv2.2

2016-12-28 Thread Thomas Petazzoni
The PPv2.2 unit is connected to an AXI bus on Armada 7K/8K, so this commit adds the necessary initialization of the AXI bridge. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 85 1 file changed, 85 insertions(+) diff --git a/drive

[PATCHv2 net-next 08/16] net: mvpp2: adapt mvpp2_defaults_set() to PPv2.2

2016-12-28 Thread Thomas Petazzoni
This commit modifies the mvpp2_defaults_set() function to not do the loopback and FIFO threshold initialization, which are not needed for PPv2.2. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-

[PATCHv2 net-next 14/16] net: mvpp2: adapt rxq distribution to PPv2.2

2016-12-28 Thread Thomas Petazzoni
In PPv2.1, we have a maximum of 8 RXQs per port, with a default of 4 RXQs per port, and we were assigning RXQs 0->3 to the first port, 4->7 to the second port, 8->11 to the third port, etc. In PPv2.2, we have a maximum of 32 RXQs per port, and we must allocate RXQs from the range of 32 RXQs availa

[PATCHv2 net-next 04/16] net: mvpp2: introduce an intermediate union for the TX/RX descriptors

2016-12-28 Thread Thomas Petazzoni
Since the format of the HW descriptors is different between PPv2.1 and PPv2.2, this commit introduces an intermediate union, with for now only the PPv2.1 descriptors. The bulk of the driver code only manipulates opaque mvpp2_tx_desc and mvpp2_rx_desc pointers, and the descriptors can only be access

[PATCHv2 net-next 16/16] net: mvpp2: finally add the PPv2.2 compatible string

2016-12-28 Thread Thomas Petazzoni
Now that the mvpp2 driver has been modified to accommodate the support for PPv2.2, we can finally advertise this support by adding the appropriate compatible string. At the same time, we update the Kconfig description of the MVPP2 driver. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet

[PATCHv2 net-next 02/16] net: mvpp2: add and use accessors for TX/RX descriptors

2016-12-28 Thread Thomas Petazzoni
The PPv2.2 IP has a different TX and RX descriptor layout compared to PPv2.1. In order to prepare for the introduction of PPv2.2 support in mvpp2, this commit adds accessors for the different fields of the TX and RX descriptors, and changes the code to use them. For now, the mvpp2_port argument pa

[PATCHv2 net-next 13/16] net: mvpp2: rework RXQ interrupt group initialization for PPv2.2

2016-12-28 Thread Thomas Petazzoni
This commit adjusts how the MVPP2_ISR_RXQ_GROUP_REG register is configured, since it changed between PPv2.1 and PPv2.2. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 45 1 file changed, 41 insertions(+), 4 deletions(-) diff --git

[PATCHv2 net-next 01/16] dt-bindings: net: update Marvell PPv2 binding for PPv2.2 support

2016-12-28 Thread Thomas Petazzoni
The Marvell PPv2 Device Tree binding was so far only used to describe the PPv2.1 network controller, used in the Marvell Armada 375. A new version of this IP block, PPv2.2 is used in the Marvell Armada 7K/8K processor. This commit extends the existing binding so that it can also be used to describ

[PATCHv2 net-next 03/11] net: mvpp2: release reference to txq_cpu[] entry after unmapping

2016-12-28 Thread Thomas Petazzoni
The mvpp2_txq_bufs_free() function is called upon TX completion to DMA unmap TX buffers, and free the corresponding SKBs. It gets the references to the SKB to free and the DMA buffer to unmap from a per-CPU txq_pcpu data structure. However, the code currently increments the pointer to the next ent

[PATCHv2 net-next 05/11] net: mvpp2: drop useless fields in mvpp2_bm_pool and related code

2016-12-28 Thread Thomas Petazzoni
This commit drops dead code from the mvpp2 driver. The 'in_use' and 'in_use_thresh' fields of 'struct mvpp2_bm_pool' are incremented/decremented/initialized in various places. But they are only used in one place: if (is_recycle && (atomic_read(&bm_pool->in_use) < bm_pool->in_use_

[PATCHv2 net-next 06/11] net: mvpp2: simplify mvpp2_bm_bufs_add()

2016-12-28 Thread Thomas Petazzoni
The mvpp2_bm_bufs_add() currently creates a fake cookie by calling mvpp2_bm_cookie_pool_set(), just to be able to call mvpp2_pool_refill(). But all what mvpp2_pool_refill() does is extract the pool ID from the cookie, and call mvpp2_bm_pool_put() with this ID. Instead of doing this convoluted thin

[PATCHv2 net-next 01/11] net: mvpp2: handle too large value handling in mvpp2_rx_pkts_coal_set()

2016-12-28 Thread Thomas Petazzoni
Currently, mvpp2_rx_pkts_coal_set() does the following to avoid setting a too large value for the RX coalescing by packet number: val = (pkts & MVPP2_OCCUPIED_THRESH_MASK); This means that if you set a value that is slightly higher the the maximum number of packets, you in fact get a very low v

[PATCHv2 net-next 02/11] net: mvpp2: handle too large value in mvpp2_rx_time_coal_set()

2016-12-28 Thread Thomas Petazzoni
When configuring the MVPP2_ISR_RX_THRESHOLD_REG with the RX coalescing time threshold, we do not check for the maximum allowed value supported by the driver, which means we might overflow and use a bogus value. This commit adds a check for this situation, and if a value higher than what is supporte

[PATCHv2 net-next 00/11] net: mvpp2: misc improvements and preparation patches

2016-12-28 Thread Thomas Petazzoni
Hello, This series contains a number of misc improvements and preparation patches for an upcoming series that adds support for the new PPv2.2 network controller to the mvpp2 driver. The most significant improvements are: - Switching to using build_skb(), which is necessary for the upcoming P

[PATCHv2 net-next 07/11] net: mvpp2: remove unused register definitions

2016-12-28 Thread Thomas Petazzoni
Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index 8174f40..edffcc1 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/drivers/net/e

[PATCHv2 net-next 08/11] net: mvpp2: fix indentation of MVPP2_EXT_GLOBAL_CTRL_DEFAULT

2016-12-28 Thread Thomas Petazzoni
Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index edffcc1..36c73dc 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/

[PATCHv2 net-next 10/11] net: mvpp2: switch to build_skb() in the RX path

2016-12-28 Thread Thomas Petazzoni
This commit adapts the mvpp2 RX path to use the build_skb() method. Not only build_skb() is now the recommended mechanism, but it also simplifies the addition of support for the PPv2.2 variant. Indeed, without build_skb(), we have to keep track for each RX descriptor of the physical address of the

[PATCHv2 net-next 04/11] net: mvpp2: remove unused 'tx_skb' field of 'struct mvpp2_tx_queue'

2016-12-28 Thread Thomas Petazzoni
This commit remove a field of 'struct mvpp2_tx_queue' that is not used anywhere. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index d098c

[PATCHv2 net-next 09/11] net: mvpp2: simplify MVPP2_PRS_RI_* definitions

2016-12-28 Thread Thomas Petazzoni
Some of the MVPP2_PRS_RI_* definitions use the ~(value) syntax, which doesn't compile nicely on 64-bit. Moreover, those definitions are in fact unneeded, since they are always used in combination with a bit mask that ensures only the appropriate bits are modified. Therefore, such definitions shoul

[PATCHv2 net-next 11/11] net: mvpp2: enable building on 64-bit platforms

2016-12-28 Thread Thomas Petazzoni
The mvpp2 is going to be extended to support the Marvell Armada 7K/8K platform, which is ARM64. As a preparation to this work, this commit enables building the mvpp2 driver on ARM64, by: - Adjusting the Kconfig dependency - Fixing the types used in the driver so that they are 32/64-bits comp

[PATCH] net: wan: slic_ds26522: fix spelling mistake: "configurated" -> "configured"

2016-12-28 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in pr_info message Signed-off-by: Colin Ian King --- drivers/net/wan/slic_ds26522.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/slic_ds26522.c b/drivers/net/wan/slic_ds26522.c index b776a0a..9d9b4e0 10

[PATCH] net: atm: Fix warnings in net/atm/lec.c when !CONFIG_PROC_FS

2016-12-28 Thread Augusto Mecking Caringi
This patch fixes the following warnings when CONFIG_PROC_FS is not set: linux/net/atm/lec.c: In function ‘lane_module_cleanup’: linux/net/atm/lec.c:1062:27: error: ‘atm_proc_root’ undeclared (first use in this function) remove_proc_entry("lec", atm_proc_root); ^ linux/ne

Re: [PATCH net] net/sched: cls_flower: Fix missing addr_type in classify

2016-12-28 Thread Jiri Pirko
Wed, Dec 28, 2016 at 01:54:47PM CET, pa...@mellanox.com wrote: >Since we now use a non zero mask on addr_type, we are matching on its >value (IPV4/IPV6). So before this fix, matching on enc_src_ip/enc_dst_ip >failed in SW/classify path since its value was zero. >This patch sets the proper value of

[PATCH] ipv6: Should use consistent conditional judgement for ip6 fragment between __ip6_append_data and ip6_finish_output

2016-12-28 Thread Zheng Li
From: Zheng Li There is an inconsistent conditional judgement between __ip6_append_data and ip6_finish_output functions, the variable length in __ip6_append_data just include the length of application's payload and udp6 header, don't include the length of ipv6 header, but in ip6_finish_output use

RE: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM.

2016-12-28 Thread Rafal Ozieblo
> From: Andrei Pistirica [mailto:andrei.pistir...@microchip.com] > Sent: 14 grudnia 2016 13:56 > Subject: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM. > > Cadence GEM provides a 102 bit time counter with 48 bits for seconds, > 30 bits for nsecs and 24 bits for sub-nsecs to c

[PATCH] net: avoid put_cmsg() possible copy longer data than input

2016-12-28 Thread yuan linyu
From: yuan linyu if CMSG_ALIGN(sizeof(struct cmsghdr)) > sizeof(struct cmsghdr), original (cmlen - sizeof(struct cmsghdr)) may greater than input len. --- include/linux/socket.h | 12 ++-- net/compat.c | 28 +++- net/core/scm.c | 10 +- n

Re: [PATCH 01/12] Make and configuration files.

2016-12-28 Thread Joe Perches
On Tue, 2016-12-27 at 05:17 -0800, David VomLehn wrote: > Patches to create the make and configuration file [] > \ No newline at end of file Not good > diff --git a/drivers/net/ethernet/aquantia/atlantic/Makefile > b/drivers/net/ethernet/aquantia/atlantic/Makefile A really atypical Makefile y

Admin

2016-12-28 Thread administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de corre

[PATCH iproute2 net-next] tc: flower: support matching flags

2016-12-28 Thread Paul Blakey
Enhance flower to support matching on flags. The 1st flag allows to match on whether the packet is an IP fragment. Example: # add a flower filter that will drop fragmented packets # (bit 0 of control flags) tc filter add dev ens4f0 protocol ip parent : \

[PATCH net 10/12] net/mlx5e: Check ets capability before initializing ets settings

2016-12-28 Thread Saeed Mahameed
From: Huy Nguyen During the initial setup, the ets command is sent to firmware without checking if the HCA supports ets. This causes the invalid command error. Add the ets capiblity check before sending firmware command to initialize ets settings. Fixes: e207b7e99176 ("net/mlx5e: ConnectX-4 firm

[PATCH net 04/12] net/mlx5: Avoid shadowing numa_node

2016-12-28 Thread Saeed Mahameed
From: Eli Cohen Avoid using a local variable named numa_node to avoid shadowing a public one. Fixes: db058a186f98 ('net/mlx5_core: Set irq affinity hints') Signed-off-by: Eli Cohen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 3 +-- 1 file changed, 1 inse

[PATCH net 07/12] net/mlx5: Prevent setting multicast macs for VFs

2016-12-28 Thread Saeed Mahameed
From: Mohamad Haj Yahia Need to check that VF mac address entered by the admin user is either zero or unicast mac. Multicast mac addresses are prohibited. Fixes: 77256579c6b4 ('net/mlx5: E-Switch, Introduce Vport administration functions') Signed-off-by: Mohamad Haj Yahia Signed-off-by: Saeed

[PATCH net 06/12] net/mlx5: Release FTE lock in error flow

2016-12-28 Thread Saeed Mahameed
From: Maor Gottlieb Release the FTE lock when adding rule to the FTE has failed. Fixes: 0fd758d6112f ('net/mlx5: Don't unlock fte while still using it') Signed-off-by: Maor Gottlieb Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c |

[PATCH net 12/12] net/mlx5e: Disable netdev after close

2016-12-28 Thread Saeed Mahameed
Disable netdev should come after it was closed, although no harm of doing it before -hence the MLX5E_STATE_DESTROYING bit- but it is more natural this way. Fixes: 26e59d8077a3 ("net/mlx5e: Implement mlx5e interface attach/detach callbacks") Signed-off-by: Saeed Mahameed Reviewed-by: Mohamad Haj

[PATCH net 09/12] Revert "net/mlx5: Add MPCNT register infrastructure"

2016-12-28 Thread Saeed Mahameed
From: Gal Pressman This reverts commit 7f503169cabd70c1f13b9279c50eca7dfb9a7d51. Fixes: 7f503169cabd ("net/mlx5: Add MPCNT register infrastructure") Signed-off-by: Gal Pressman Reported-by: Jesper Dangaard Brouer Signed-off-by: Saeed Mahameed --- include/linux/mlx5/device.h | 5 --- inclu

[PATCH net 05/12] net/mlx5: Mask destination mac value in ethtool steering rules

2016-12-28 Thread Saeed Mahameed
From: Maor Gottlieb We need to mask the destination mac value with the destination mac mask when adding steering rule via ethtool. Fixes: 1174fce8d1410 ('net/mlx5e: Support l3/l4 flow type specs in ethtool flow steering') Signed-off-by: Maor Gottlieb Signed-off-by: Saeed Mahameed --- drivers

[PATCH net 08/12] Revert "net/mlx5e: Expose PCIe statistics to ethtool"

2016-12-28 Thread Saeed Mahameed
From: Gal Pressman This reverts commit 9c7262399ba12825f3ca4b00a76d8d5e77c720f5. PCIe counters were introduced in a new firmware version, as a result users with old firmware encountered a syndrome every 200ms due to update stats work. This feature will be re-introduced later with appropriate capa

[PATCH net 11/12] net/mlx5e: Don't sync netdev state when not registered

2016-12-28 Thread Saeed Mahameed
Skip setting netdev vxlan ports and netdev rx_mode on driver load when netdev is not yet registered. Synchronizing with netdev state is needed only on reset flow where the netdev remains registered for the whole reset period. This also fixes an access before initialization of net_device.addr_list

[PATCH net 01/12] net/mlx5: Disable RoCE on the e-switch management port under switchdev mode

2016-12-28 Thread Saeed Mahameed
From: Or Gerlitz Under the switchdev/offloads mode, packets that don't match any e-switch steering rule are sent towards the e-switch management port. We use a NIC HW steering rule set per vport (uplink and VFs) to make them be received into the host OS through the respective vport representor ne

[PATCH net 03/12] net/mlx5: Cancel recovery work in remove flow

2016-12-28 Thread Saeed Mahameed
From: Daniel Jurgens If there is pending delayed work for health recovery it must be canceled if the device is being unloaded. Fixes: 05ac2c0b7438 ("net/mlx5: Fix race between PCI error handlers and health work") Signed-off-by: Daniel Jurgens Signed-off-by: Saeed Mahameed --- drivers/net/eth

[PATCH net 00/12] Mellanox 100G mlx5 fixes 28-12-2016

2016-12-28 Thread Saeed Mahameed
Hi Dave, Some fixes for mlx5 core and ethernet driver. for -stable: net/mlx5: Check FW limitations on log_max_qp before setting it net/mlx5: Cancel recovery work in remove flow net/mlx5: Avoid shadowing numa_node net/mlx5: Mask destination mac value in ethtool steering rules n

[PATCH net 02/12] net/mlx5: Check FW limitations on log_max_qp before setting it

2016-12-28 Thread Saeed Mahameed
From: Noa Osherovich When setting HCA capabilities, set log_max_qp to be the minimum between the selected profile's value and the HCA limitation. Fixes: 938fe83c8dcb ('net/mlx5_core: New device capabilities...') Signed-off-by: Noa Osherovich Signed-off-by: Saeed Mahameed --- drivers/net/ether

[PATCH v4] stmmac: enable rx queues

2016-12-28 Thread Joao Pinto
When the hardware is synthesized with multiple queues, all queues are disabled for default. This patch adds the rx queues configuration. This patch was successfully tested in a Synopsys QoS Reference design. Signed-off-by: Joao Pinto --- changes v3 -> v4 - To avoid confusing users only rx queue 0

[PATCH net] net/sched: cls_flower: Fix missing addr_type in classify

2016-12-28 Thread Paul Blakey
Since we now use a non zero mask on addr_type, we are matching on its value (IPV4/IPV6). So before this fix, matching on enc_src_ip/enc_dst_ip failed in SW/classify path since its value was zero. This patch sets the proper value of addr_type for encapsulated packets. Fixes: 970bfcd09791 ('net/sche

Re: [PATCH v3] stmmac: enable rx queues

2016-12-28 Thread Joao Pinto
Às 12:23 PM de 12/28/2016, Kishan Sandeep escreveu: > On Dec 28, 2016 5:50 PM, "Joao Pinto" wrote: >> >> Às 12:19 PM de 12/28/2016, Joao Pinto escreveu: >>> Às 12:15 PM de 12/28/2016, Kishan Sandeep escreveu: On Dec 28, 2016 5:36 PM, "Joao Pinto" wrote: > > Às 12:02 PM de 12/28/2016,

Re: [PATCH v3] stmmac: enable rx queues

2016-12-28 Thread Joao Pinto
Às 12:02 PM de 12/28/2016, Kishan Sandeep escreveu: > On Wed, Dec 28, 2016 at 5:23 PM, Joao Pinto wrote: >> Hello, >> >> Às 11:50 AM de 12/28/2016, Kishan Sandeep escreveu: >>> On Wed, Dec 28, 2016 at 4:45 PM, Joao Pinto wrote: >>> When the hardware is synthesized with multiple queues, all q

Re: [PATCH v3] stmmac: enable rx queues

2016-12-28 Thread Kishan Sandeep
On Wed, Dec 28, 2016 at 5:23 PM, Joao Pinto wrote: > Hello, > > Às 11:50 AM de 12/28/2016, Kishan Sandeep escreveu: >> On Wed, Dec 28, 2016 at 4:45 PM, Joao Pinto wrote: >> >>> When the hardware is synthesized with multiple queues, all queues are >>> disabled for default. This patch adds the rx q

[PATCH net-next] sctp: add pr_debug for tracking asocs not found

2016-12-28 Thread Marcelo Ricardo Leitner
This pr_debug may help identify why the system is generating some Aborts. It's not something a sysadmin would be expected to use. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/input.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/net/sctp/input.c b/

Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe

2016-12-28 Thread Kishan Sandeep
On Wed, Dec 28, 2016 at 7:10 AM, Kweh, Hock Leong wrote: >> -Original Message- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Wednesday, December 28, 2016 12:34 AM >> To: Kweh, Hock Leong >> Cc: joao.pi...@synopsys.com; peppe.cavall...@st.com; >> seraphin.bonna...@st.com; f.f

Re: [PATCH v3] stmmac: enable rx queues

2016-12-28 Thread Joao Pinto
Hello, Às 11:50 AM de 12/28/2016, Kishan Sandeep escreveu: > On Wed, Dec 28, 2016 at 4:45 PM, Joao Pinto wrote: > >> When the hardware is synthesized with multiple queues, all queues are >> disabled for default. This patch adds the rx queues configuration. >> This patch was successfully tested i

[PATCH RESEND net-next 4/5] sctp: remove return value from sctp_packet_init/config

2016-12-28 Thread Marcelo Ricardo Leitner
There is no reason to use this cascading. It doesn't add anything. Let's remove it and simplify. Signed-off-by: Marcelo Ricardo Leitner --- include/net/sctp/structs.h | 7 +++ net/sctp/output.c | 14 +- net/sctp/sm_statefuns.c| 5 +++-- 3 files changed, 11 insertio

[PATCH RESEND net-next 3/5] sctp: simplify addr copy

2016-12-28 Thread Marcelo Ricardo Leitner
Make it a bit easier to read. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/ipv6.c | 16 +++- net/sctp/protocol.c | 18 +++--- 2 files changed, 14 insertions(+), 20 deletions(-) diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c index 176af3080a2b8f8ffc56b55f3ccb1

[PATCH RESEND net-next 1/5] sctp: reduce indent level at sctp_sf_tabort_8_4_8

2016-12-28 Thread Marcelo Ricardo Leitner
Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/sm_statefuns.c | 44 +--- 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index 8ec20a64a3f8055a0c3576627c5ec5dad7e99ca8..32587b1f84e72922

[PATCH RESEND net-next 2/5] sctp: reduce indent level in sctp_sf_shut_8_4_5

2016-12-28 Thread Marcelo Ricardo Leitner
Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/sm_statefuns.c | 58 - 1 file changed, 28 insertions(+), 30 deletions(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index 32587b1f84e729221965e270607fea7ef93a7430..a95915ef9db

[PATCH RESEND net-next 5/5] sctp: sctp_chunk_length_valid should return bool

2016-12-28 Thread Marcelo Ricardo Leitner
Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/sm_statefuns.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index 9a223d5b2314ff166be0446462c33219b7eec1b9..3382ef254e7b41ae4723f2e72e5aca30d46a4a8e 10064

[PATCH RESEND net-next 0/5] SCTP cleanups

2016-12-28 Thread Marcelo Ricardo Leitner
Some cleanups/simplifications I've been collecting. Resending now with net-next open. Marcelo Ricardo Leitner (5): sctp: reduce indent level at sctp_sf_tabort_8_4_8 sctp: reduce indent level in sctp_sf_shut_8_4_5 sctp: simplify addr copy sctp: remove return value from sctp_packet_init/conf

[PATCH v3] stmmac: enable rx queues

2016-12-28 Thread Joao Pinto
When the hardware is synthesized with multiple queues, all queues are disabled for default. This patch adds the rx queues configuration. This patch was successfully tested in a Synopsys QoS Reference design. Signed-off-by: Joao Pinto --- changes v2 -> v3 (Seraphin Bonnaffe): - GMAC_RX_QUEUE_CLEAR

Re: George's crazy full state idea (Re: HalfSipHash Acceptable Usage)

2016-12-28 Thread George Spelvin
Hannes Frederic Sowa wrote: > We call extract_crng when we run out of batched entropy and reseed. How > often we call down to extract_crng depends on how much entropy we > extracted by calls to get_random_int/long, so the number of calls into > those functions matter. > > In extract_crng we have a

[PATCH 1/2] ipv4: Namespaceify tcp_tw_recycle and tcp_max_tw_buckets knob

2016-12-28 Thread Haishuang Yan
Different namespace application might require fast recycling TIME-WAIT sockets independently of the host. Signed-off-by: Haishuang Yan --- include/net/inet_timewait_sock.h | 13 + include/net/netns/ipv4.h | 11 +++ include/net/tcp.h| 1 - net/ipv4/af_

  1   2   >