net: stmmac: Meson GXBB: attempting to execute userspace memory

2016-11-25 Thread Heinrich Schuchardt
For Odroid C2 I have compiled kernel 4.9.0-rc6-next-20161124-1-gbf7e142 with one additional patch https://github.com/xypron/kernel-odroid-c2/blob/master/patch/0001-stmmac-RTL8211F-Meson-GXBB-TX-throughput-problems.patch I repeatedly see faults like the one below: [ 2557.400796] Unhandled faul

[PATCH net-next] cgroup, bpf: remove unnecessary #include

2016-11-25 Thread Alexei Starovoitov
this #include is unnecessary and brings whole set of other headers into cgroup-defs.h. Remove it. Fixes: 3007098494be ("cgroup: add support for eBPF programs") Signed-off-by: Alexei Starovoitov --- include/linux/bpf-cgroup.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/bpf-cg

Xmas Offer

2016-11-25 Thread Mrs Julie Leach
You are a recipient to Mrs Julie Leach Donation of $3 million USD. Contact ( julieleac...@gmail.com ) for claims.

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

2016-11-25 Thread Cong Wang
On Thu, Nov 24, 2016 at 7:20 AM, Daniel Borkmann wrote: > > Ok, strange, qdisc_destroy() calls into ops->destroy(), where ingress > drops its entire chain via tcf_destroy_chain(), so that will be NULL > eventually. The tps are freed by call_rcu() as well as qdisc itself > later on via qdisc_rcu_fr

Re: Crash due to mutex genl_lock called from RCU context

2016-11-25 Thread subashab
Oh well, this wont work, since sk->sk_destruct will be called from RCU callback. Grabbing the mutex should not be done from netlink_sock_destruct() but from netlink_release() Maybe this patch would be better : diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 62bea4591054..

Re: Crash due to mutex genl_lock called from RCU context

2016-11-25 Thread Eric Dumazet
On Fri, 2016-11-25 at 20:11 -0800, Eric Dumazet wrote: > On Fri, 2016-11-25 at 19:15 -0700, subas...@codeaurora.org wrote: > > We are seeing a crash due to gen_lock mutex being acquired in RCU > > context. > > Crash is seen on a 4.4 based kernel ARM64 device. This occurred in a > > regression rack

Re: Crash due to mutex genl_lock called from RCU context

2016-11-25 Thread Eric Dumazet
On Fri, 2016-11-25 at 19:15 -0700, subas...@codeaurora.org wrote: > We are seeing a crash due to gen_lock mutex being acquired in RCU > context. > Crash is seen on a 4.4 based kernel ARM64 device. This occurred in a > regression rack, so unfortunately I don't have steps for a reproducer. > > It l

Xmas Offer

2016-11-25 Thread Mrs Julie Leach
You are a recipient to Mrs Julie Leach Donation of $3 million USD. Contact ( julieleac...@gmail.com ) for claims.

Re: [PATCH net 1/1] tipc: resolve connection flow control compatibility problem

2016-11-25 Thread David Miller
From: Jon Maloy Date: Thu, 24 Nov 2016 18:47:07 -0500 > In commit 10724cc7bb78 ("tipc: redesign connection-level flow control") > we replaced the previous message based flow control with one based on > 1k blocks. In order to ensure backwards compatibility the mechanism > falls back to using messa

Re: [patch net-next 00/19] mlxsw: traps, trap groups and policers

2016-11-25 Thread David Miller
From: Jiri Pirko Date: Fri, 25 Nov 2016 10:33:28 +0100 > From: Jiri Pirko > > Nogah says: > > For a packet to be sent from the HW to the cpu, it needs to be trapped. > For a trap to be activate it should be assigned to a trap group. > Those trap groups can have policers, to limit the packet ra

Crash due to mutex genl_lock called from RCU context

2016-11-25 Thread subashab
We are seeing a crash due to gen_lock mutex being acquired in RCU context. Crash is seen on a 4.4 based kernel ARM64 device. This occurred in a regression rack, so unfortunately I don't have steps for a reproducer. It looks like freeing socket in RCU was brought in through commit 21e4902aea80ef3

Re: [PATCH net] mvpp2: use correct size for memset

2016-11-25 Thread David Miller
From: Arnd Bergmann Date: Thu, 24 Nov 2016 17:28:12 +0100 > gcc-7 detects a short memset in mvpp2, introduced in the original > merge of the driver: > > drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_cls_init': > drivers/net/ethernet/marvell/mvpp2.c:3296:2: error: 'memset' used with le

Re: [PATCH] irda: fix overly long udelay()

2016-11-25 Thread David Miller
From: Arnd Bergmann Date: Thu, 24 Nov 2016 17:26:22 +0100 > irda_get_mtt() returns a hardcoded '1' in some cases, > and with gcc-7, we get a build error because this triggers a > compile-time check in udelay(): > > drivers/net/irda/w83977af_ir.o: In function `w83977af_hard_xmit': > w83977af_

Re: [PATCH V3 net-next 05/15] smc: CLC handshake (incl. preparation steps)

2016-11-25 Thread David Miller
From: Ursula Braun Date: Thu, 24 Nov 2016 16:06:35 +0100 > +struct smc_clc_msg_hdr { /* header1 of clc messages */ > + u8 eyecatcher[4]; /* eye catcher */ > + u8 type;/* proposal / accept / confirm / decline */ > + __be16 length; > +#if defined(__BIG_ENDIAN_B

Re: [PATCH V3 net-next 03/15] smc: establish pnet table management

2016-11-25 Thread David Miller
From: Ursula Braun Date: Thu, 24 Nov 2016 16:06:33 +0100 > Connection creation with SMC-R starts through an internal > TCP-connection. The Ethernet interface for this TCP-connection is not > restricted to the Ethernet interface of a RoCE device. Any existing > Ethernet interface belonging to the

Re: [PATCH V3 net-next 02/15] smc: establish new socket family

2016-11-25 Thread David Miller
From: Ursula Braun Date: Thu, 24 Nov 2016 16:06:32 +0100 > +static struct sock *smc_sock_alloc(struct net *net, struct socket *sock) > +{ > + struct smc_sock *smc; > + struct sock *sk; > + > + sk = sk_alloc(net, PF_SMC, GFP_KERNEL, &smc_proto, 0); > + if (!sk) > + retu

Re: [PATCH V3 net-next 01/15] net: introduce keepalive function in struct proto

2016-11-25 Thread David Miller
From: Ursula Braun Date: Thu, 24 Nov 2016 16:06:31 +0100 > diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c > index 3ea1cf8..9b1602a 100644 > --- a/net/ipv4/tcp_timer.c > +++ b/net/ipv4/tcp_timer.c > @@ -617,6 +617,7 @@ void tcp_set_keepalive(struct sock *sk, int val) > else if (!va

Re: [PATCH] net/mlx5: drop duplicate header delay.h

2016-11-25 Thread David Miller
From: Geliang Tang Date: Thu, 24 Nov 2016 21:58:33 +0800 > Drop duplicate header delay.h from mlx5/core/main.c. > > Signed-off-by: Geliang Tang Applied.

Re: [PATCH] net: ieee802154: drop duplicate header delay.h

2016-11-25 Thread David Miller
From: Geliang Tang Date: Thu, 24 Nov 2016 21:58:32 +0800 > Drop duplicate header delay.h from adf7242.c. > > Signed-off-by: Geliang Tang Applied.

Re: [PATCH] ibmvnic: drop duplicate header seq_file.h

2016-11-25 Thread David Miller
From: Geliang Tang Date: Thu, 24 Nov 2016 21:58:29 +0800 > Drop duplicate header seq_file.h from ibmvnic.c. > > Signed-off-by: Geliang Tang Applied.

Re: [patch] fsl/fman: fix a leak in tgec_free()

2016-11-25 Thread David Miller
From: Dan Carpenter Date: Thu, 24 Nov 2016 14:20:43 +0300 > We set "tgec->cfg" to NULL before passing it to kfree(). There is no > need to set it to NULL at all. Let's just delete it. > > Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support") > Signed-off-by: Dan Carpenter Applied.

Re: [patch] net/mlx5: remove a duplicate condition

2016-11-25 Thread David Miller
From: Dan Carpenter Date: Thu, 24 Nov 2016 14:03:45 +0300 > We verified that MLX5_FLOW_CONTEXT_ACTION_COUNT was set on the first > line of the function so we don't need to check again here. > > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH] net: ethtool: don't require CAP_NET_ADMIN for ETHTOOL_GLINKSETTINGS

2016-11-25 Thread David Miller
From: Miroslav Lichvar Date: Thu, 24 Nov 2016 10:55:06 +0100 > The ETHTOOL_GLINKSETTINGS command is deprecating the ETHTOOL_GSET > command and likewise it shouldn't require the CAP_NET_ADMIN capability. > > Signed-off-by: Miroslav Lichvar Good catch, applied, thanks.

Re: [PATCH 0/4] net: thunderx: Support for 80xx, RED, PFC e.t.c

2016-11-25 Thread David Miller
From: sunil.kovv...@gmail.com Date: Thu, 24 Nov 2016 14:47:59 +0530 > This patch series adds support for SLM modules present on 80xx > silicon, enables ramdom early discard, backpressure generation, > PFC and some ethtool changes to display supported link modes e.t.c. Series applied to net-next.

Re: [net-next] neigh: fix the loop index error in neigh dump

2016-11-25 Thread David Miller
From: Zhang Shengju Date: Thu, 24 Nov 2016 13:25:09 +0800 > Loop index in neigh dump function is not updated correctly under some > circumstances, this patch will fix it. > > Signed-off-by: Zhang Shengju If this bug is also in the 'net' tree you should target this patch there. Also, you must

Re: [PATCH net 1/1] tipc: improve sanity check for received domain records

2016-11-25 Thread David Miller
From: Jon Maloy Date: Wed, 23 Nov 2016 23:46:09 -0500 > In commit 35c55c9877f8 ("tipc: add neighbor monitoring framework") we > added a data area to the link monitor STATE messages under the > assumption that previous versions did not use any such data area. > > For versions older than Linux 4.3

Re: [PATCH net 1/1] tipc: fix compatibility bug in link monitoring

2016-11-25 Thread David Miller
From: Jon Maloy Date: Wed, 23 Nov 2016 21:05:26 -0500 > commit 817298102b0b ("tipc: fix link priority propagation") introduced a > compatibility problem between TIPC versions newer than Linux 4.6 and > those older than Linux 4.4. In versions later than 4.4, link STATE > messages only contain a no

Re: [PATCH net] net: ethernet: mvneta: Remove IFF_UNICAST_FLT which is not implemented

2016-11-25 Thread David Miller
From: Andrew Lunn Date: Thu, 24 Nov 2016 00:08:13 +0100 > The mvneta driver advertises it supports IFF_UNICAST_FLT. However, it > actually does not. The hardware probably does support it, but there is > no code to configure the filter. As a quick and simple fix, remove the > flag. This will cause

Re: [PATCH v2 net] phy: fix error case of phy_led_triggers_(un)register

2016-11-25 Thread David Miller
From: Date: Wed, 23 Nov 2016 23:10:33 + > From: Woojung Huh > > When phy_init_hw() fails at phy_attach_direct(); > - phy_detach() calls phy_led_triggers_unregister() without > previous call of phy_led_triggers_register(). > - still call phy_led_triggers_register() and cause memory leak. >

Re: [PATCH net-next 1/2] sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver

2016-11-25 Thread kbuild test robot
Hi Edward, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Edward-Cree/sfc-split-out-Falcon-driver/20161126-033439 config: i386-randconfig-h1-11260702 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the a

Re: [PATCH net-next v2 0/2] Add support for the MV88e6097

2016-11-25 Thread David Miller
From: Stefan Eichenberger Date: Wed, 23 Nov 2016 21:59:50 +0100 > This patchset will add support for the MV88E6097 DSA switch and enable > EDSA on MV88E6097 family devices. > > Changes since v1: > - Add missing g1_irqs = 8 > - Add missing comment after mv88e6097_ops > - Change patch order This

Re: [PATCH net-next] net: properly flush delay-freed skbs

2016-11-25 Thread David Miller
From: Eric Dumazet Date: Wed, 23 Nov 2016 08:44:56 -0800 > From: Eric Dumazet > > Typical NAPI drivers use napi_consume_skb(skb) at TX completion time. > This put skb in a percpu special queue, napi_alloc_cache, to get bulk > frees. > > It turns out the queue is not flushed and hits the NAPI_S

[PATCH net-next 6/6] bpf: fix multiple issues in selftest suite and samples

2016-11-25 Thread Daniel Borkmann
1) The test_lru_map and test_lru_dist fails building on my machine since the sys/resource.h header is not included. 2) test_verifier fails in one test case where we try to call an invalid function, since the verifier log output changed wrt printing function names. 3) Current selftest sui

[PATCH net-next 4/6] bpf: add owner_prog_type and accounted mem to array map's fdinfo

2016-11-25 Thread Daniel Borkmann
Allow for checking the owner_prog_type of a program array map. In some cases bpf(2) can return -EINVAL /after/ the verifier passed and did all the rewrites of the bpf program. The reason that lets us fail at this late stage is that program array maps are incompatible. Allow users to inspect this e

[PATCH net-next 5/6] bpf: allow for mount options to specify permissions

2016-11-25 Thread Daniel Borkmann
Since we recently converted the BPF filesystem over to use mount_nodev(), we now have the possibility to also hold mount options in sb's s_fs_info. This work implements mount options support for specifying permissions on the sb's inode, which will be used by tc when it manually needs to mount the f

[PATCH net-next 3/6] bpf: reuse dev_is_mac_header_xmit for redirect

2016-11-25 Thread Daniel Borkmann
Commit dcf800344a91 ("net/sched: act_mirred: Refactor detection whether dev needs xmit at mac header") added dev_is_mac_header_xmit(); since it's also useful elsewhere, move it to if_arp.h and reuse it for BPF. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- include/linux/if_arp

[PATCH net-next 1/6] bpf: drop unnecessary context cast from BPF_PROG_RUN

2016-11-25 Thread Daniel Borkmann
Since long already bpf_func is not only about struct sk_buff * as input anymore. Make it generic as void *, so that callers don't need to cast for it each time they call BPF_PROG_RUN(). Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- drivers/net/ethernet/netronome/nfp/nfp_net_co

[PATCH net-next 2/6] bpf: drop useless bpf_fd member from cls/act

2016-11-25 Thread Daniel Borkmann
After setup we don't need to keep user space fd number around anymore, as it also has no useful meaning for anyone, just remove it. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- net/sched/act_bpf.c | 7 --- net/sched/cls_bpf.c | 9 + 2 files changed, 1 insertion(+)

[PATCH net-next 0/6] BPF cleanups and misc updates

2016-11-25 Thread Daniel Borkmann
This patch set adds couple of cleanups in first few patches, exposes owner_prog_type for array maps as well as mlocked mem for maps in fdinfo, allows for mount permissions in fs and fixes various outstanding issues in selftests and samples. Thanks! Daniel Borkmann (6): bpf: drop unnecessary con

Re: [PATCH v9 0/6] Add eBPF hooks for cgroups

2016-11-25 Thread David Miller
From: Daniel Mack Date: Wed, 23 Nov 2016 16:52:24 +0100 > This is v9 of the patch set to allow eBPF programs for network > filtering and accounting to be attached to cgroups, so that they apply > to all sockets of all tasks placed in that cgroup. The logic also > allows to be extendeded for other

Re: [PATCH net-next 1/5] net: mvneta: Use cacheable memory to store the rx buffer virtual address

2016-11-25 Thread kbuild test robot
Hi Gregory, [auto build test ERROR on ] url: https://github.com/0day-ci/linux/commits/Gregory-CLEMENT/Support-Armada-37xx-SoC-ARMv8-64-bits-in-mvneta-driver/20161126-050621 base: config: parisc-allmodconfig (attached as .config) compiler: hppa-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705

Re: [PATCH net-next 4/5] net/socket: add helpers for recvmmsg

2016-11-25 Thread Eric Dumazet
On Fri, 2016-11-25 at 16:39 +0100, Paolo Abeni wrote: > _skb_try_recv_datagram_batch dequeues multiple skb's from the > socket's receive queue, and runs the bulk_destructor callback under > the receive queue lock. ... > + last = (struct sk_buff *)queue; > + first = (struct sk_buff *)queue

Cash Grant

2016-11-25 Thread Mrs Julie Leach
You are a recipient to Mrs Julie Leach Donation of $3 million USD. Contact (julieleac...@gmail.com ) for claims.

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Christian Borntraeger
On 11/25/2016 10:08 PM, Michael S. Tsirkin wrote: > On Fri, Nov 25, 2016 at 05:49:45PM +0100, Christian Borntraeger wrote: >> On 11/25/2016 05:17 PM, Peter Zijlstra wrote: >>> On Fri, Nov 25, 2016 at 04:10:04PM +, Mark Rutland wrote: On Fri, Nov 25, 2016 at 04:21:39PM +0100, Dmitry Vyukov

Re: [PATCH] cxgb4: fix memory leak on txq_info

2016-11-25 Thread Colin Ian King
On 25/11/16 21:10, David Miller wrote: > From: Colin King > Date: Wed, 23 Nov 2016 11:02:44 + > >> From: Colin Ian King >> >> Currently if txq_info->uldtxq cannot be allocated then >> txq_info->txq is being kfree'd (which is redundant because it >> is NULL) instead of txq_info. Fix this by i

Re: [net-next PATCH v2 3/5] virtio_net: Add XDP support

2016-11-25 Thread John Fastabend
On 16-11-22 06:58 AM, Michael S. Tsirkin wrote: > On Tue, Nov 22, 2016 at 12:27:03AM -0800, John Fastabend wrote: >> On 16-11-21 03:20 PM, Michael S. Tsirkin wrote: >>> On Sat, Nov 19, 2016 at 06:50:33PM -0800, John Fastabend wrote: From: Shrijeet Mukherjee This adds XDP support to

Re: [PATCH] drivers: net: davinci_mdio: use builtin_platform_driver

2016-11-25 Thread David Miller
From: Geliang Tang Date: Wed, 23 Nov 2016 22:45:43 +0800 > @@ -536,11 +536,7 @@ static struct platform_driver davinci_mdio_driver = { > .remove = davinci_mdio_remove, > }; > > -static int __init davinci_mdio_init(void) > -{ > - return platform_driver_register(&davinci_mdio_driver); >

Re: pull-request: can 2016-11-23

2016-11-25 Thread David Miller
From: Marc Kleine-Budde Date: Wed, 23 Nov 2016 15:34:29 +0100 > this is a pull request for net/master. > > The patch by Oliver Hartkopp for the broadcast manager (bcm) fixes the CAN-FD > support, which may cause an out-of-bounds access otherwise. Pulled, thanks.

Re: [PATCH net-next 0/5] net: add protocol level recvmmsg support

2016-11-25 Thread Eric Dumazet
On Fri, 2016-11-25 at 16:39 +0100, Paolo Abeni wrote: > The goal of recvmmsg() is to amortize the syscall overhead on a possible > long messages batch, but for most networking protocols, e.g. udp the > syscall overhead is negligible compared to the protocol specific operations > like dequeuing. Pr

Re: [PATCH] dwc_eth_qos: drop duplicate headers

2016-11-25 Thread David Miller
From: Geliang Tang Date: Wed, 23 Nov 2016 22:24:35 +0800 > Drop duplicate headers types.h and delay.h from dwc_eth_qos.c. > > Signed-off-by: Geliang Tang Applied.

Re: [PATCH] cxgb4: fix memory leak on txq_info

2016-11-25 Thread David Miller
From: Colin King Date: Wed, 23 Nov 2016 11:02:44 + > From: Colin Ian King > > Currently if txq_info->uldtxq cannot be allocated then > txq_info->txq is being kfree'd (which is redundant because it > is NULL) instead of txq_info. Fix this by instead kfree'ing > txq_info. > > Signed-off-by:

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Michael S. Tsirkin
On Fri, Nov 25, 2016 at 05:49:45PM +0100, Christian Borntraeger wrote: > On 11/25/2016 05:17 PM, Peter Zijlstra wrote: > > On Fri, Nov 25, 2016 at 04:10:04PM +, Mark Rutland wrote: > >> On Fri, Nov 25, 2016 at 04:21:39PM +0100, Dmitry Vyukov wrote: > > > >>> What are use cases for such primiti

Re: [PATCH RFC v1] ethtool: implement helper to get flow_type value

2016-11-25 Thread David Miller
From: Jacob Keller Date: Tue, 22 Nov 2016 15:44:53 -0800 > @@ -880,6 +880,14 @@ struct ethtool_rx_flow_spec { > __u32 location; > }; > > +/* Flag to enable additional fields in struct ethtool_rx_flow_spec */ > +#define FLOW_EXT0x8000 > +#define FLOW_MAC_EX

Re: [PATCH net-next 4/5] net/socket: add helpers for recvmmsg

2016-11-25 Thread kbuild test robot
Hi Paolo, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Paolo-Abeni/net-add-protocol-level-recvmmsg-support/20161126-033729 config: i386-randconfig-s0-201647 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # s

Re: [PATCH net-next 4/5] net/socket: add helpers for recvmmsg

2016-11-25 Thread kbuild test robot
Hi Paolo, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Paolo-Abeni/net-add-protocol-level-recvmmsg-support/20161126-033729 config: i386-randconfig-i1-201647 (attached as .config) compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4 reproduce: # save t

Re: net/arp: ARP cache aging failed.

2016-11-25 Thread Julian Anastasov
Hello, On Fri, 25 Nov 2016, Hannes Frederic Sowa wrote: > On 25.11.2016 09:18, Julian Anastasov wrote: > > > > Another option would be to add similar bit to > > struct sock (sk_dst_pending_confirm), may be ip_finish_output2 > > can propagate it to dst_neigh_output via new arg and th

Re: Aw: Re: [PATCH] mlx4: give precise rx/tx bytes/packets counters

2016-11-25 Thread Eric Dumazet
On Fri, 2016-11-25 at 17:30 +0100, Lino Sanfilippo wrote: > Hi, > > > > > > The READ_ONCE() are documenting the fact that no lock is taken to fetch > > the stats, while another cpus might being changing them. > > > > I had no answer yet from https://patchwork.ozlabs.org/patch/698449/ > > > > S

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

2016-11-25 Thread Jason Gunthorpe
On Thu, Nov 24, 2016 at 06:13:50PM -0800, Vishwanathapura, Niranjana wrote: > In order to be truely device independent the hfi_vnic ULP should not depend > on a device exported symbol. Instead device should register its functions > with the ULP. Hence the approaches a) and b). It is not device in

Re: net/netlink: null-ptr-deref in netlink_dump/lock_acquire

2016-11-25 Thread Dmitry Vyukov
On Thu, Nov 3, 2016 at 6:21 PM, Andrey Konovalov wrote: > Hi, > > Another report that looks related: > > [ INFO: possible circular locking dependency detected ] > 4.9.0-rc3+ #344 Not tainted > --- > syz-executor/25526 is trying to acquire lock: >

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Linus Torvalds
On Fri, Nov 25, 2016 at 10:07 AM, Mark Rutland wrote: > On Fri, Nov 25, 2016 at 09:52:50AM -0800, Linus Torvalds wrote: >> READ/WRITE_ONCE() are atomic *WHEN*THAT*IS*POSSIBLE*. > >> But sometimes it's not going to be atomic. > > That's the problem. It has never really been much of a problem, and

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Christian Borntraeger
On 11/25/2016 06:28 PM, Mark Rutland wrote: > On Fri, Nov 25, 2016 at 05:49:45PM +0100, Christian Borntraeger wrote: >> On 11/25/2016 05:17 PM, Peter Zijlstra wrote: >>> On Fri, Nov 25, 2016 at 04:10:04PM +, Mark Rutland wrote: On Fri, Nov 25, 2016 at 04:21:39PM +0100, Dmitry Vyukov wrote:

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Mark Rutland
On Fri, Nov 25, 2016 at 09:52:50AM -0800, Linus Torvalds wrote: > READ/WRITE_ONCE() are atomic *WHEN*THAT*IS*POSSIBLE*. > But sometimes it's not going to be atomic. That's the problem. Common code may rely on something being atomic when that's only true on a subset of platforms. On others, it's

ATENCIÓN;

2016-11-25 Thread Sistemas administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de corre

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Linus Torvalds
On Fri, Nov 25, 2016 at 9:28 AM, Dmitry Vyukov wrote: On Fri, Nov 25, 2016 at 5:17 PM, Peter Zijlstra wrote: >> >> IE, they are strictly stronger than {READ,WRITE}_ONCE(). No, they are strictly bullshit. Stop this idiocy. We went through this once already. > Uh, so, READ/WRITE_ONCE are non-ato

[PATCH net-next 0/2] sfc: split out Falcon driver

2016-11-25 Thread Edward Cree
This series splits out support for the obsolescent SFC4000 family into its own driver, sfc-falcon. See patch #1 for rationale. Edward Cree (2): sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver sfc: remove obvious Falcon-related code drivers/net/ethernet/Kconfig

Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-25 Thread Florian Fainelli
On 11/25/2016 03:13 AM, Sebastian Frias wrote: > On 24/11/16 19:55, Florian Fainelli wrote: >> Le 24/11/2016 à 09:05, Martin Blumenstingl a écrit : >>> On Thu, Nov 24, 2016 at 4:56 PM, Jerome Brunet wrote: On Thu, 2016-11-24 at 15:34 +0100, Martin Blumenstingl wrote: > Currently the dwmac

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Mark Rutland
On Fri, Nov 25, 2016 at 06:28:53PM +0100, Dmitry Vyukov wrote: > On Fri, Nov 25, 2016 at 5:17 PM, Peter Zijlstra wrote: > >> > What are use cases for such primitive that won't be OK with "read once > >> > _and_ atomically"? > >> > >> I have none to hand. > > > > Whatever triggers the __builtin_mem

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Peter Zijlstra
On Fri, Nov 25, 2016 at 05:28:01PM +, Mark Rutland wrote: > On Fri, Nov 25, 2016 at 05:49:45PM +0100, Christian Borntraeger wrote: > > On 11/25/2016 05:17 PM, Peter Zijlstra wrote: > > There were several cases that I found during writing the *ONCE stuff. > > For example there are some 32bit pp

Re: [PATCH net-next 0/5] net: add protocol level recvmmsg support

2016-11-25 Thread Jesper Dangaard Brouer
On Fri, 25 Nov 2016 16:39:51 +0100 Paolo Abeni wrote: > The goal of recvmmsg() is to amortize the syscall overhead on a possible > long messages batch, but for most networking protocols, e.g. udp the > syscall overhead is negligible compared to the protocol specific operations > like dequeuing.

RE: [PATCH net v2 4/5] net: fsl/fman: fix fixed-link-phydev reference leak

2016-11-25 Thread Madalin-Cristian Bucur
> -Original Message- > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold > Sent: Thursday, November 24, 2016 8:22 PM > > Make sure to drop the reference taken by of_phy_find_device() when > looking up a fixed-link phydev during probe. > > Fixes: 57ba4c9b56d8 ("fsl/fm

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Dmitry Vyukov
On Fri, Nov 25, 2016 at 5:17 PM, Peter Zijlstra wrote: >> > What are use cases for such primitive that won't be OK with "read once >> > _and_ atomically"? >> >> I have none to hand. > > Whatever triggers the __builtin_memcpy() paths, and even the size==8 > paths on 32bit. > > You could put a WARN

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Mark Rutland
On Fri, Nov 25, 2016 at 05:49:45PM +0100, Christian Borntraeger wrote: > On 11/25/2016 05:17 PM, Peter Zijlstra wrote: > > On Fri, Nov 25, 2016 at 04:10:04PM +, Mark Rutland wrote: > >> On Fri, Nov 25, 2016 at 04:21:39PM +0100, Dmitry Vyukov wrote: > > > >>> What are use cases for such primiti

Re: [PATCH net-next 5/5] udp: add recvmmsg implementation

2016-11-25 Thread Hannes Frederic Sowa
On 25.11.2016 16:39, Paolo Abeni wrote: > skbs are extracted from the receive queue in burts, and a single > sk_rmem_alloc/forward allocated memory update is performed for > each burst. > MSG_PEEK and MSG_ERRQUEUE are not supported to keep the implementation > as simple as possible. > > Signed-off

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-25 Thread David Miller
From: Mark Lord Date: Fri, 25 Nov 2016 07:49:35 -0500 > On 16-11-25 04:53 AM, Greg KH wrote: >> On Thu, Nov 24, 2016 at 10:49:33PM -0500, Mark Lord wrote: >>> There is no possibility for them to be used for anything other than >>> USB receive buffers, for this driver only. Nothing in the driver

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Christian Borntraeger
On 11/25/2016 05:17 PM, Peter Zijlstra wrote: > On Fri, Nov 25, 2016 at 04:10:04PM +, Mark Rutland wrote: >> On Fri, Nov 25, 2016 at 04:21:39PM +0100, Dmitry Vyukov wrote: > >>> What are use cases for such primitive that won't be OK with "read once >>> _and_ atomically"? >> >> I have none to h

Re: [PATCH] net: stmmac: enable tx queue 0 for gmac4 IPs synthesized with multiple TX queues

2016-11-25 Thread Niklas Cassel
On 11/25/2016 04:40 PM, Alexandre Torgue wrote: > Hi Niklas > > On 11/25/2016 01:14 PM, Niklas Cassel wrote: >> On 11/25/2016 01:10 PM, Niklas Cassel wrote: >>> On 11/24/2016 07:11 PM, Alexandre Torgue wrote: Hi Niklas, >>> Hello Alexandre >>> On 11/24/2016 03:36 PM, Niklas Cassel wrote:

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Mark Rutland
On Fri, Nov 25, 2016 at 05:17:09PM +0100, Peter Zijlstra wrote: > On Fri, Nov 25, 2016 at 04:10:04PM +, Mark Rutland wrote: > > On Fri, Nov 25, 2016 at 04:21:39PM +0100, Dmitry Vyukov wrote: > > > > What are use cases for such primitive that won't be OK with "read once > > > _and_ atomically"?

Aw: Re: [PATCH] mlx4: give precise rx/tx bytes/packets counters

2016-11-25 Thread Lino Sanfilippo
Hi, > > The READ_ONCE() are documenting the fact that no lock is taken to fetch > the stats, while another cpus might being changing them. > > I had no answer yet from https://patchwork.ozlabs.org/patch/698449/ > > So I thought it was not needed to explain this in the changelog, given > that i

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Mark Rutland
On Fri, Nov 25, 2016 at 04:21:39PM +0100, Dmitry Vyukov wrote: > > READ/WRITE_ONCE imply atomicity. Even if their names don't spell it (a > function name doesn't have to spell all of its guarantees). Most of > the uses of READ/WRITE_ONCE will be broken if they are not atomic. In practice, this is

Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-25 Thread Peter Zijlstra
On Fri, Nov 25, 2016 at 04:10:04PM +, Mark Rutland wrote: > On Fri, Nov 25, 2016 at 04:21:39PM +0100, Dmitry Vyukov wrote: > > What are use cases for such primitive that won't be OK with "read once > > _and_ atomically"? > > I have none to hand. Whatever triggers the __builtin_memcpy() paths

Re: [PATCH] mlx4: give precise rx/tx bytes/packets counters

2016-11-25 Thread Eric Dumazet
On Fri, 2016-11-25 at 16:03 +, David Laight wrote: > From: Of Eric Dumazet > > Sent: 25 November 2016 15:46 > > mlx4 stats are chaotic because a deferred work queue is responsible > > to update them every 250 ms. > > > > Even sampling stats every one second with "sar -n DEV 1" gives > > variat

Re: [PATCH] net: dsa: fix unbalanced dsa_switch_tree reference counting

2016-11-25 Thread Andrew Lunn
On Fri, Nov 25, 2016 at 07:08:53PM +0300, Nikita Yushchenko wrote: > _dsa_register_switch() gets a dsa_switch_tree object either via > dsa_get_dst() or via dsa_add_dst(). Former path does not increase kref > in returned object (resulting into caller not owning a reference), > while later path does

Re: [patch v2 net-next] sfc: remove unneeded variable

2016-11-25 Thread Edward Cree
On 25/11/16 10:43, Dan Carpenter wrote: > We don't use ->heap_buf after commit 46d1efd852cc ("sfc: remove Software > TSO") so let's remove the last traces. > > Signed-off-by: Dan Carpenter Acked-by: Edward Cree > diff --git a/drivers/net/ethernet/sfc/net_driver.h > b/drivers/net/ethernet/sfc/net

[PATCH] net: dsa: fix unbalanced dsa_switch_tree reference counting

2016-11-25 Thread Nikita Yushchenko
_dsa_register_switch() gets a dsa_switch_tree object either via dsa_get_dst() or via dsa_add_dst(). Former path does not increase kref in returned object (resulting into caller not owning a reference), while later path does create a new object (resulting into caller owning a reference). The rest o

RE: [PATCH] mlx4: give precise rx/tx bytes/packets counters

2016-11-25 Thread David Laight
From: Of Eric Dumazet > Sent: 25 November 2016 15:46 > mlx4 stats are chaotic because a deferred work queue is responsible > to update them every 250 ms. > > Even sampling stats every one second with "sar -n DEV 1" gives > variations like the following : ... > This patch allows rx/tx bytes/packets

[PATCH] mlx4: give precise rx/tx bytes/packets counters

2016-11-25 Thread Eric Dumazet
From: Eric Dumazet mlx4 stats are chaotic because a deferred work queue is responsible to update them every 250 ms. Even sampling stats every one second with "sar -n DEV 1" gives variations like the following : lpaa23:~# sar -n DEV 1 10 | grep eth0 | cut -c1-65 07:39:22 eth0 146877.00 3

Re: [PATCH] net: stmmac: enable tx queue 0 for gmac4 IPs synthesized with multiple TX queues

2016-11-25 Thread Alexandre Torgue
Hi Niklas On 11/25/2016 01:14 PM, Niklas Cassel wrote: On 11/25/2016 01:10 PM, Niklas Cassel wrote: On 11/24/2016 07:11 PM, Alexandre Torgue wrote: Hi Niklas, Hello Alexandre On 11/24/2016 03:36 PM, Niklas Cassel wrote: From: Niklas Cassel The dwmac4 IP can synthesized with 1-8 number of

[PATCH net-next 5/5] ARM64: dts: marvell: Add network support for Armada 3700

2016-11-25 Thread Gregory CLEMENT
Add neta nodes for network support both in device tree for the SoC and the board. Signed-off-by: Gregory CLEMENT --- arch/arm64/boot/dts/marvell/armada-3720-db.dts | 23 +++- arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 23 +++- 2 files changed, 46 insertions(

[PATCH net-next 5/5] udp: add recvmmsg implementation

2016-11-25 Thread Paolo Abeni
skbs are extracted from the receive queue in burts, and a single sk_rmem_alloc/forward allocated memory update is performed for each burst. MSG_PEEK and MSG_ERRQUEUE are not supported to keep the implementation as simple as possible. Signed-off-by: Sabrina Dubroca Signed-off-by: Paolo Abeni ---

[PATCH net-next 3/5] net/udp: factor out main skb processing routine

2016-11-25 Thread Paolo Abeni
we will reuse it later for mmsg implementation Signed-off-by: Sabrina Dubroca Signed-off-by: Paolo Abeni --- net/ipv4/udp.c | 67 - net/ipv6/udp.c | 73 -- 2 files changed, 86 insertions(

[PATCH net-next 4/5] net/socket: add helpers for recvmmsg

2016-11-25 Thread Paolo Abeni
_skb_try_recv_datagram_batch dequeues multiple skb's from the socket's receive queue, and runs the bulk_destructor callback under the receive queue lock. recvmmsg_ctx_from_user retrieves msghdr information from userspace, and sets up the kernelspace context for processing one datagram. recvmmsg_c

[PATCH net-next 1/5] net/socket: factor out msghdr manipulation helpers

2016-11-25 Thread Paolo Abeni
so that they can be later used for recvmmsg refactor Signed-off-by: Sabrina Dubroca Signed-off-by: Paolo Abeni --- include/net/sock.h | 18 ++ net/socket.c | 97 +- 2 files changed, 70 insertions(+), 45 deletions(-) diff --git a

[PATCH net-next 2/5] net/socket: add per protocol mmesg support

2016-11-25 Thread Paolo Abeni
proto->recvmmsg allows leveraging per protocol optimization, amortizing the protocol/locking overhead on multiple packets. This commit introduces the procotol level callbacks and change to generic implementation to use them. We explicitly pass down to the protocol level both 'timeout' and 'end_ti

[PATCH net-next 0/5] net: add protocol level recvmmsg support

2016-11-25 Thread Paolo Abeni
The goal of recvmmsg() is to amortize the syscall overhead on a possible long messages batch, but for most networking protocols, e.g. udp the syscall overhead is negligible compared to the protocol specific operations like dequeuing. Moreover, the current recvmmsg() implementation has a long-stand

[PATCH net 1/1] tipc: fix link statistics counter errors

2016-11-25 Thread Jon Maloy
In commit e4bf4f76962b ("tipc: simplify packet sequence number handling") we changed the internal representation of the packet sequence number counters from u32 to u16, reflecting what is really sent over the wire. Since then some link statistics counters have been displaying incorrect values, par

[PATCH 0/2] net: phy: realtek: fix RTL8211F TX-delay handling

2016-11-25 Thread Martin Blumenstingl
The RTL8211F PHY driver currently enables the TX-delay only when the phy-mode is PHY_INTERFACE_MODE_RGMII. This is incorrect, because there are three RGMII variations of the phy-mode which explicitly request the PHY to enable the RX and/or TX delay, while PHY_INTERFACE_MODE_RGMII specifies that the

[PATCH net-next 4/5] net: mvneta: Add network support for Armada 3700 SoC

2016-11-25 Thread Gregory CLEMENT
From: Marcin Wojtas Armada 3700 is a new ARMv8 SoC from Marvell using same network controller as older Armada 370/38x/XP. There are however some differences that needed taking into account when adding support for it: * open default MBUS window to 4GB of DRAM - Armada 3700 SoC's Mbus configurat

[PATCH net-next 3/5] net: mvneta: Only disable mvneta_bm for 64-bits

2016-11-25 Thread Gregory CLEMENT
Actually only the mvneta_bm support is not 64-bits compatible. The mvneta code itself can run on 64-bits architecture. Signed-off-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/Kconfi

[PATCH net-next 1/5] net: mvneta: Use cacheable memory to store the rx buffer virtual address

2016-11-25 Thread Gregory CLEMENT
Until now the virtual address of the received buffer were stored in the cookie field of the rx descriptor. However, this field is 32-bits only which prevents to use the driver on a 64-bits architecture. With this patch the virtual address is stored in an array not shared with the hardware (no more

[PATCH net-next 2/5] net: mvneta: Convert to be 64 bits compatible

2016-11-25 Thread Gregory CLEMENT
From: Marcin Wojtas Prepare the mvneta driver in order to be usable on the 64 bits platform such as the Armada 3700. [gregory.clem...@free-electrons.com]: this patch was extract from a larger one to ease review and maintenance. Signed-off-by: Marcin Wojtas Signed-off-by: Gregory CLEMENT ---

  1   2   >