Re: [PATCH] genetlink: fix unsigned int comparison with less than zero

2016-11-12 Thread Johannes Berg
> > I suppose it could be, since family IDs are allocated in a 16-bit > > range > > anyway. But family IDs can also never actually be negative, so > > having > > an unsigned int in the struct makes sense too. > > All idr_* API's accept int, rather than unsigned int. This is my > point. Sure, but

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-12 Thread kbuild test robot
Hi Lino, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161113-125131 config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20

Re: [iproute PATCH v2 1/2] include: Add linux/sctp.h

2016-11-12 Thread Stephen Hemminger
On Wed, 9 Nov 2016 12:12:23 +0100 Phil Sutter wrote: > Add sanitized UAPI linux/sctp.h header file. > > Signed-off-by: Phil Sutter Applied both patches.

Re: [PATCH iproute2 1/1] tc: print raw qdisc handle.

2016-11-12 Thread Stephen Hemminger
On Thu, 10 Nov 2016 10:06:32 -0500 Roman Mashak wrote: > Resending patch after fixing indentation and spaces. > > Signed-off-by: Roman Mashak > Signed-off-by: Jamal Hadi Salim iproute2 uses kernel coding style. This patch fails basic checkpatch. WARNING: suspect code indent for conditional

Re: [PATCH] net: bpqether.h: remove if_ether.h guard

2016-11-12 Thread David Miller
From: Baruch Siach Date: Thu, 10 Nov 2016 13:21:42 +0200 > __LINUX_IF_ETHER_H is not defined anywhere, and if_ether.h can keep itself > from > double inclusion, though it uses a single underscore prefix. > > Signed-off-by: Baruch Siach Applied.

Re: [PATCH net-next v1 00/11] amd-xgbe: AMD XGBE driver updates 2016-11-10

2016-11-12 Thread David Miller
From: Tom Lendacky Date: Thu, 10 Nov 2016 17:09:17 -0600 > This patch series is targeted at adding support for a new PCI version > of the hardware. As part of the new PCI device, there is a new PCS/PHY > interaction, ECC support, I2C sideband communication, SFP+ support and > more. > > The follo

Re: [PATCH net-next v13 0/8] openvswitch: support for layer 3 encapsulated packets

2016-11-12 Thread David Miller
From: Jiri Benc Date: Thu, 10 Nov 2016 16:28:16 +0100 > At the core of this patch set is removing the assumption in Open vSwitch > datapath that all packets have Ethernet header. > > The implementation relies on the presence of pop_eth and push_eth actions > in datapath flows to facilitate addin

Re: [PATCH net-next 00/11] Start adding support for mv88e6390 family

2016-11-12 Thread David Miller
From: Andrew Lunn Date: Fri, 11 Nov 2016 03:53:32 +0100 > This is the first patchset implementing support for the mv88e6390 > family. This is a new generation of switch devices and has numerous > incompatible changes to the registers. These patches allow the switch > to the detected during probe

Re: [PATCH] genetlink: fix unsigned int comparison with less than zero

2016-11-12 Thread Cong Wang
On Sat, Nov 12, 2016 at 1:37 PM, Johannes Berg wrote: > On Thu, 2016-11-10 at 09:11 -0800, Cong Wang wrote: >> On Thu, Nov 10, 2016 at 7:57 AM, Colin King > > wrote: >> > >> > From: Colin Ian King >> > >> > family->id is unsigned, so the less than zero check for >> > failure return from idr_alloc

Re: [PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-12 Thread David Miller
From: David Miller Date: Sun, 13 Nov 2016 00:20:55 -0500 (EST) > From: David Lebrun > Date: Thu, 10 Nov 2016 13:26:53 +0100 > >> v2: fix conditional compilation for seg6_iptunnel.o in Makefile >> >> This patch compiles SR lwtunnels support only if CONFIG_LWTUNNEL=y. >> >> If IPv6 is enabled a

Re: [PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-12 Thread David Miller
From: David Lebrun Date: Thu, 10 Nov 2016 13:26:53 +0100 > v2: fix conditional compilation for seg6_iptunnel.o in Makefile > > This patch compiles SR lwtunnels support only if CONFIG_LWTUNNEL=y. > > If IPv6 is enabled and CONFIG_LWTUNNEL=n, then seg6_iptunnel_init() > fails with EOPNOTSUPP whic

[PATCH v2 1/2] Revert "bnx2: Reset device during driver initialization"

2016-11-12 Thread Baoquan He
This reverts commit 3e1be7ad2d38c6bd6aeef96df9bd0a7822f4e51c. When people build bnx2 driver into kernel, it will fail to detect and load firmware because firmware is contained in initramfs and initramfs has not been uncompressed yet during do_initcalls. So revert commit 3e1be7a and work out a new

[PATCH v2 0/2] bnx2: Wait for in-flight DMA to complete at probe stage

2016-11-12 Thread Baoquan He
This is v2 post. In commit 3e1be7a ("bnx2: Reset device during driver initialization"), firmware requesting code was moved from open stage to probe stage. The reason is in kdump kernel hardware iommu need device be reset in driver probe stage, otherwise those in-flight DMA from 1st kernel will con

[PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage

2016-11-12 Thread Baoquan He
In-flight DMA from 1st kernel could continue going in kdump kernel. New io-page table has been created before bnx2 does reset at open stage. We have to wait for the in-flight DMA to complete to avoid it look up into the newly created io-page table at probe stage. Suggested-by: Michael Chan Signed

Re: [PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage

2016-11-12 Thread Baoquan He
On 11/12/16 at 11:40pm, David Miller wrote: > From: Baoquan He > Date: Sun, 13 Nov 2016 12:15:24 +0800 > > > In-flight DMA from 1st kernel could continue going in kdump kernel. > > New io-page table has been created before bnx2 does reset at open stage. > > We have to wait for the in-flight DMA t

[net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-12 Thread Lino Sanfilippo
Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer interface control) technology. The driver provides basic support without SLIC for the following devices: - Mojave cards (single port PCI Gigabit) both copper and fiber - Oasis cards (single and dual port PCI-x Gigabit) coppe

[net-next 2/2] MAINTAINERS: add entry for slicoss ethernet driver

2016-11-12 Thread Lino Sanfilippo
Add myself as maintainer for the slicoss ethernet driver. Signed-off-by: Lino Sanfilippo --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6781a3f..bb9af28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,11 @@ T: git git://linuxtv.

Gigabit ethernet driver for Alacritechs SLIC devices

2016-11-12 Thread Lino Sanfilippo
Hi, this is a rework of the slicoss gigabit ethernet driver from Alacritech that is currently part of the staging area. The driver is supposed to support Mojave, Oasis and Kalahari cards, for both copper and fiber. If this code is accepted the staging version can be removed (as Greg told me by

Re: linux-next: manual merge of the net-next tree with the netfilter tree

2016-11-12 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 10 Nov 2016 01:31:17 +0100 > I think I cannot help to address this conflict myself. > > 8fbfef7f505b is in my nf tree, while 489111e5c25b is in net-next. So > you will hit this conflict by when you pull net into net-next. > > So please keep this patch from Ste

Re: [PATCH net] net: __skb_flow_dissect() must cap its return value

2016-11-12 Thread David Miller
From: Eric Dumazet Date: Wed, 09 Nov 2016 16:04:46 -0800 > From: Eric Dumazet > > After Tom patch, thoff field could point past the end of the buffer, > this could fool some callers. > > If an skb was provided, skb->len should be the upper limit. > If not, hlen is supposed to be the upper limi

Re: [PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage

2016-11-12 Thread David Miller
From: Baoquan He Date: Sun, 13 Nov 2016 12:15:24 +0800 > In-flight DMA from 1st kernel could continue going in kdump kernel. > New io-page table has been created before bnx2 does reset at open stage. > We have to wait for the in-flight DMA to complete to avoid it look up > into the newly created

Re: [PATCH net 0/2] bpf: Fix bpf_redirect to an ipip/ip6tnl dev

2016-11-12 Thread David Miller
From: Martin KaFai Lau Date: Wed, 9 Nov 2016 15:36:32 -0800 > This patch set fixes a bug in bpf_redirect(dev, flags) when dev is an > ipip/ip6tnl. The current problem is IP-EthHdr-IP is sent out instead of > IP-IP. > > Patch 1 adds a dev->type test similar to dev_is_mac_header_xmit() > in act_m

Re: [PATCHv2 net] igmp: do not remove igmp souce list info when set link down

2016-11-12 Thread David Miller
From: Hangbin Liu Date: Wed, 9 Nov 2016 11:16:40 +0800 > In commit 24cf3af(igmp: call ip_mc_clear_src...), we forgot to remove > igmpv3_clear_delrec() in ip_mc_down(), which also called ip_mc_clear_src(). > This make us clear all IGMPv3 source filter info after NETDEV_DOWN. > Move igmpv3_clear_d

Re: [PATCH net-next] bpf, mlx4: fix prog refcount in mlx4_en_try_alloc_resources error path

2016-11-12 Thread David Miller
From: Daniel Borkmann Date: Wed, 9 Nov 2016 22:02:34 +0100 > Commit 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings > scheme") added a bug in that the prog's reference count is not dropped > in the error path when mlx4_en_try_alloc_resources() is failing from > mlx4_xdp_set(). > >

[PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage

2016-11-12 Thread Baoquan He
In-flight DMA from 1st kernel could continue going in kdump kernel. New io-page table has been created before bnx2 does reset at open stage. We have to wait for the in-flight DMA to complete to avoid it look up into the newly created io-page table at probe stage. Suggested-by: Michael Chan Signed

Re: [PATCH 0/2] bnx2: Hard reset bnx2 chip at probe stage

2016-11-12 Thread Baoquan He
Hi Michael, On 11/11/16 at 09:37am, Michael Chan wrote: > On Fri, Nov 11, 2016 at 6:02 AM, Baoquan He wrote: > > On 11/11/16 at 09:46pm, Baoquan He wrote: > >> Hi bnx2 experts, > >> > >> In commit 3e1be7a ("bnx2: Reset device during driver initialization"), > >> firmware requesting code was move

Re: Debugging Ethernet issues

2016-11-12 Thread Andrew Lunn
> When connected to a Gigabit switch > 3.4 negotiates a LAN DHCP setup instantly > 4.7 requires over 5 seconds to do so When you run tcpdump on the DHCP server, are you noticing the first request is missing? What can happen is the dhclient gets started immediately and sends out its first request

Re: [PATCH] net: ethernet: ti: davinci_cpdma: free memory while channel destroy

2016-11-12 Thread David Miller
From: Ivan Khoronzhuk Date: Tue, 8 Nov 2016 15:16:05 +0200 > While create/destroy channel operation memory is not freed. It was > supposed that memory is freed while driver remove. But a channel > can be created and destroyed many times while changing number of > channels with ethtool. > > Base

Re: [PATCH] r8169: Module parameter for opt-in of ASPM

2016-11-12 Thread David Miller
From: Kast Bernd Date: Fri, 4 Nov 2016 00:33:06 +0100 > This patch adds a module parameter in order to activate ASPM. By that > the CPU can enter deep sleep modes (PC6) and power consumption can be > reduced (for example from 13W to 8W on my notebook with a Haswell CPU). > Basically, it reapplies

Re: Source address fib invalidation on IPv6

2016-11-12 Thread Jason A. Donenfeld
Hi Hannes, On Sun, Nov 13, 2016 at 1:51 AM, Hannes Frederic Sowa wrote: > You probably need some combination of ipv6_chk_addr and/or > ipv6_check_addr_and_flags (where dev can also be NULL). Be careful if a > IFA_HOST or IFA_LINK address switches from one interface to another. I can confirm this

Re: Source address fib invalidation on IPv6

2016-11-12 Thread Jason A. Donenfeld
On Sun, Nov 13, 2016 at 1:43 AM, Jason A. Donenfeld wrote: > In perusing through the v6 FIB code, I don't even see an analog of > __ip_dev_find... Hm? Of all places, the iscsi code actually has a nice side-by-side comparison. So far as I can see, the other protocols just omit this check in the v6

Re: Source address fib invalidation on IPv6

2016-11-12 Thread Hannes Frederic Sowa
On Sun, Nov 13, 2016, at 01:43, Jason A. Donenfeld wrote: > On Sat, Nov 12, 2016 at 8:08 PM, Jason A. Donenfeld > wrote: > >> Gotcha. I don't see any checks that the saddr is valid similar to what > >> IPv4 does. > >> > >> I think the right place to add a check is in ip6_dst_lookup_tail(): > >>

Re: Source address fib invalidation on IPv6

2016-11-12 Thread Jason A. Donenfeld
On Sat, Nov 12, 2016 at 8:08 PM, Jason A. Donenfeld wrote: >> Gotcha. I don't see any checks that the saddr is valid similar to what IPv4 >> does. >> >> I think the right place to add a check is in ip6_dst_lookup_tail(): >> if (!ipv6_addr_any(&fl6->saddr)) { >> // saddr is valid for L

Debugging Ethernet issues

2016-11-12 Thread Mason
Hello everyone, In a past thread ("Ethernet not working on a different SoC with same eth HW") I was struggling getting Ethernet to work at all on a new board using a recent 4.7 kernel. After much hair-pulling, it turned out that *some* of the breakage was caused by a local patch which should have

Re: [PATCH net-next v13 5/8] openvswitch: add processing of L3 packets

2016-11-12 Thread Pravin Shelar
On Thu, Nov 10, 2016 at 7:28 AM, Jiri Benc wrote: > Support receiving, extracting flow key and sending of L3 packets (packets > without an Ethernet header). > > Note that even after this patch, non-Ethernet interfaces are still not > allowed to be added to bridges. Similarly, netlink interface for

Re: [PATCH net-next v13 7/8] openvswitch: add Ethernet push and pop actions

2016-11-12 Thread Pravin Shelar
On Thu, Nov 10, 2016 at 7:28 AM, Jiri Benc wrote: > It's not allowed to push Ethernet header in front of another Ethernet > header. > > It's not allowed to pop Ethernet header if there's a vlan tag. This > preserves the invariant that L3 packet never has a vlan tag. > > Based on previous versions

[PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-12 Thread Alexandru Gagniuc
With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The VSC8601 can handle this internally. While the VSC8601 can set more fine-grained delays, the standard skew settings work out of the box. The same heuristic is used to determine when this skew should be enabled as in vsc824x_conf

[PATCH] net: atheros: atl1e: use new api ethtool_{get|set}_link_ksettings

2016-11-12 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. The previous implementation of set_settings was modifying the value of advertising, but with the new API, it's not possible. The structure ethtool_link_ksettings is defined as const. Signed-

Re: [PATCH] genetlink: fix unsigned int comparison with less than zero

2016-11-12 Thread Johannes Berg
On Thu, 2016-11-10 at 09:11 -0800, Cong Wang wrote: > On Thu, Nov 10, 2016 at 7:57 AM, Colin King > wrote: > > > > From: Colin Ian King > > > > family->id is unsigned, so the less than zero check for > > failure return from idr_alloc is never true and so the error exit > > is never handled.  In

Re: Source address fib invalidation on IPv6

2016-11-12 Thread Jason A. Donenfeld
Hi David, On Sat, Nov 12, 2016 at 7:14 PM, David Ahern wrote: > I believe that is coming from __ip_route_output_key_hash(), line 2232 with > __ip_dev_find not finding a device with that address. It's possible we simply are looking at different source trees, but I have the -EINVAL return in 4.8

Re: Source address fib invalidation on IPv6

2016-11-12 Thread David Ahern
On 11/12/16 8:40 AM, Jason A. Donenfeld wrote: > Hi again, > > I've done some pretty in depth debugging now to determine exactly what > the behavior of ipv6_stub->ipv6_dst_lookup is. First I'll start with > ip_route_output_flow, which I believe to be well behaved, and then > I'll show ipv6_stub->i

[PATCH] net: ethernet: ixp4xx_eth: fix spelling mistake in debug message

2016-11-12 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake "successed" to "succeeded" in debug message. Also unwrap multi-line literal string. Signed-off-by: Colin Ian King --- drivers/net/ethernet/xscale/ixp4xx_eth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net

[PATCH] ps3_gelic: fix spelling mistake in debug message

2016-11-12 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake "unmached" to "unmatched" in debug message. Signed-off-by: Colin Ian King --- drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wirele

[PATCH] net: atheros: atl1c: use new api ethtool_{get|set}_link_ksettings

2016-11-12 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/atheros/atl1c/atl1c_ethtool.c | 54 +++- 1 files changed, 30 insertions(+), 24 deletions(-) diff --git a/drivers/n

Re: Spurious code in commit 1bf40ada6290 ("amd-xgbe: Add support for clause 37 auto-negotiation"

2016-11-12 Thread Tom Lendacky
On 11/12/2016 8:34 AM, Marion & Christophe JAILLET wrote: > Hi, > > in commit 1bf40ada6290 ("amd-xgbe: Add support for clause 37 > auto-negotiation"), we can find: > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-common.h > b/drivers/net/ethernet/amd/xgbe/xgbe-common.h > index 695e982..8bcf4ef

Re: Source address fib invalidation on IPv6

2016-11-12 Thread Jason A. Donenfeld
Hi again, I've done some pretty in depth debugging now to determine exactly what the behavior of ipv6_stub->ipv6_dst_lookup is. First I'll start with ip_route_output_flow, which I believe to be well behaved, and then I'll show ipv6_stub->ipv6_dst_lookup, which seems ill-behaved: Userspace: ip

Spurious code in commit 1bf40ada6290 ("amd-xgbe: Add support for clause 37 auto-negotiation"

2016-11-12 Thread Marion & Christophe JAILLET
Hi, in commit 1bf40ada6290 ("amd-xgbe: Add support for clause 37 auto-negotiation"), we can find: diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-common.h b/drivers/net/ethernet/amd/xgbe/xgbe-common.h index 695e982..8bcf4ef 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-common.h +++ b/drive

I Hope You Get My Message This Time

2016-11-12 Thread Mr Friedrich Mayrhofer
-- This is the second time i am sending you this mail. I, Friedrich Mayrhofer Donate $ 1,000,000.00 to You, Email Me personally for more details. Regards. Friedrich Mayrhofer

Re: [PATCH net 2/2] r8152: rx descriptor check

2016-11-12 Thread Mark Lord
On 16-11-11 07:13 AM, Francois Romieu wrote: > Hayes Wang : >> For some platforms, the data in memory is not the same with the one >> from the device. That is, the data of memory is unbelievable. The >> check is used to find out this situation. > > Invalid packet size corrupted receive descriptor

did you receive my previous email ?

2016-11-12 Thread Friedrich Mayrhofer
-- This is the second time i am sending you this mail. I, Friedrich Mayrhofer Donate $ 1,000,000.00 to You, Email Me personally for more details. Regards. Friedrich Mayrhofer

Re: net/sctp: BUG: KASAN: stack-out-of-bounds in memcmp

2016-11-12 Thread Baozeng Ding
On 2016/11/10 13:48, Xin Long wrote: > On Sat, Oct 15, 2016 at 4:28 PM, Baozeng Ding wrote: >> Hello Xin Long, >> >> On 2016/10/14 19:13, Xin Long wrote: >>> On Sat, Aug 20, 2016 at 3:51 PM, Baozeng Ding wrote: Hello all, The following program triggers stack-out-of-bounds in memcmp.

I Hope You Get My Message This Time

2016-11-12 Thread Mr Friedrich Mayrhofer
-- This is the second time i am sending you this mail. I, Friedrich Mayrhofer Donate $ 1,000,000.00 to You, Email Me personally for more details. Regards. Friedrich Mayrhofer

I Hope You Get My Message This Time

2016-11-12 Thread Mr Friedrich Mayrhofer
-- This is the second time i am sending you this mail. I, Friedrich Mayrhofer Donate $ 1,000,000.00 to You, Email Me personally for more details. Regards. Friedrich Mayrhofer

I Hope You Get My Message This Time

2016-11-12 Thread Mr Friedrich Mayrhofer
-- This is the second time i am sending you this mail. I, Friedrich Mayrhofer Donate $ 1,000,000.00 to You, Email Me personally for more details. Regards. Friedrich Mayrhofer