Re: [RFC net-next iproute2 1/2] libnetlink: Add test for error code returned from netlink reply

2016-10-26 Thread Cyrill Gorcunov
On Wed, Oct 26, 2016 at 08:52:56PM -0700, Stephen Hemminger wrote: > On Wed, 26 Oct 2016 22:30:07 +0300 > Cyrill Gorcunov wrote: > > > > > if (h->nlmsg_type == NLMSG_DONE) { > > + int len; > > + > > +

Re: [PATCH] net: avoid uninitialized variable

2016-10-26 Thread zhong jiang
On 2016/10/27 12:02, Gao Feng wrote: > On Thu, Oct 27, 2016 at 11:56 AM, zhongjiang wrote: >> From: zhong jiang >> >> when I compiler the newest kernel, I hit the following error with >> Werror=may-uninitalized. >> >> net/core/flow_dissector.c: In function ?._skb_flow_dissect? >> include/uapi/lin

RE: [v12, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

2016-10-26 Thread Y.B. Lu
Hi Scott, > -Original Message- > From: Scott Wood [mailto:o...@buserror.net] > Sent: Thursday, October 27, 2016 1:06 AM > To: Y.B. Lu; linux-...@vger.kernel.org; ulf.hans...@linaro.org; Arnd > Bergmann > Cc: linuxppc-...@lists.ozlabs.org; devicet...@vger.kernel.org; linux-arm- > ker...@li

Re: [PATCH] net: avoid uninitialized variable

2016-10-26 Thread Gao Feng
On Thu, Oct 27, 2016 at 11:56 AM, zhongjiang wrote: > From: zhong jiang > > when I compiler the newest kernel, I hit the following error with > Werror=may-uninitalized. > > net/core/flow_dissector.c: In function ?._skb_flow_dissect? > include/uapi/linux/swab.h:100:46: error: ?.lan?.may be used un

[PATCH] net: avoid uninitialized variable

2016-10-26 Thread zhongjiang
From: zhong jiang when I compiler the newest kernel, I hit the following error with Werror=may-uninitalized. net/core/flow_dissector.c: In function ?._skb_flow_dissect? include/uapi/linux/swab.h:100:46: error: ?.lan?.may be used uninitialized in this function [-Werror=maybe-uninitialized] net/c

Re: [RFC net-next iproute2 1/2] libnetlink: Add test for error code returned from netlink reply

2016-10-26 Thread Stephen Hemminger
On Wed, 26 Oct 2016 22:30:07 +0300 Cyrill Gorcunov wrote: > > if (h->nlmsg_type == NLMSG_DONE) { > + int len; > + > + /* > + * The kernel reports if there i

Re: [PATCH v7 0/6] Add eBPF hooks for cgroups

2016-10-26 Thread Alexei Starovoitov
On Wed, Oct 26, 2016 at 09:59:33PM +0200, Pablo Neira Ayuso wrote: > On Tue, Oct 25, 2016 at 12:14:08PM +0200, Daniel Mack wrote: > [...] > > Dumping programs once they are installed is problematic because of > > the internal optimizations done to the eBPF program during its > > lifetime. Als

Re: [PATCH net] MAINTAINERS: Update qlogic networking drivers

2016-10-26 Thread David Miller
From: Yuval Mintz Date: Mon, 24 Oct 2016 08:48:09 +0300 > Following Cavium's acquisition of qlogic we need to update all the qlogic > drivers maintainer's entries to point to our new e-mail addresses, > as well as update some of the driver's maintainers as those are no longer > working for Cavium

Re: [PATCH net] netvsc: fix incorrect receive checksum offloading

2016-10-26 Thread David Miller
From: Stephen Hemminger Date: Sun, 23 Oct 2016 21:32:47 -0700 > From: Stephen Hemminger > > The Hyper-V netvsc driver was looking at the incorrect status bits > in the checksum info. It was setting the receive checksum unnecessary > flag based on the IP header checksum being correct. The checks

Re: [PATCH net-next]ldmvsw: tx queue stuck in stopped state after LDC reset

2016-10-26 Thread David Miller
From: Aaron Young Date: Wed, 26 Oct 2016 20:15:22 -0400 >From: Aaron Young > >The following patch fixes an issue with the ldmvsw driver where >the network connection of a guest domain becomes non-functional after >a guest domain has panic'd and rebooted (resulting in a LDC reset

Re: [PATCH v2 2/5] kconfig: introduce the "suggest" keyword

2016-10-26 Thread Nicolas Pitre
On Thu, 27 Oct 2016, Paul Bolle wrote: > On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote: > > Similar to "imply" but with no added restrictions on the target symbol's > > value. Useful for providing a default value to another symbol. > > > > Suggested by Edward Cree. > > > > Signed-off-by

[PATCH net-next v2 1/1] driver: tun: Use new macro SOCK_IOC_TYPE instead of literal number 0x89

2016-10-26 Thread fgao
From: Gao Feng The current codes use _IOC_TYPE(cmd) == 0x89 to check if the cmd is one socket ioctl command like SIOCGIFHWADDR. But the literal number 0x89 may confuse readers. So create one macro SOCK_IOC_TYPE to enhance the readability. Signed-off-by: Gao Feng --- v2: Rename the macro SOCK_I

[PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-10-26 Thread David Ahern
Code move only and rename only; no functional change intended. v2 - fix bpf_prog_run_clear_cb to bpf_prog_run_save_cb as caught by Daniel - rename BPF_PROG_TYPE_CGROUP_SKB and its cg_skb functions to BPF_PROG_TYPE_CGROUP and cgroup Signed-off-by: David Ahern --- include/uapi/linux/bpf.h

[PATCH net-next 4/5] samples: bpf: Add prog_subtype to bpf_prog_load

2016-10-26 Thread David Ahern
Add bpf_prog_subtype argument to bpf_prog_load. If arg is non-NULL, it is added to the attr passed to the bpf system call. Signed-off-by: David Ahern --- samples/bpf/bpf_load.c | 2 +- samples/bpf/fds_example.c | 2 +- samples/bpf/libbpf.c | 5 - samples/bpf/libbpf.h | 3 ++-

[PATCH v2 net-next 3/5] bpf: Add new cgroup attach type to enable sock modifications

2016-10-26 Thread David Ahern
Allow BPF_PROG_TYPE_CGROUP programs with cgroup.sock subtype to modify sk_bound_dev_if for newly created AF_INET or AF_INET6 sockets. The program can be attached to a cgroup using attach type BPF_CGROUP_INET_SOCK. The cgroup verifier ops are updated to handle the sock offsets as well as the existin

[PATCH net-next 2/5] bpf: Add eBPF program subtype and is_valid_subtype() verifier

2016-10-26 Thread David Ahern
The program subtype's goal is to be able to have different static fine-grained verifications for a unique program type. The struct bpf_verifier_ops gets a new optional function: is_valid_subtype(). This new verifier is called at the begening of the eBPF program verification to check if the (option

[PATCH v2 net-next 0/5] Add bpf support to set sk_bound_dev_if

2016-10-26 Thread David Ahern
The recently added VRF support in Linux leverages the bind-to-device API for programs to specify an L3 domain for a socket. While SO_BINDTODEVICE has been around for ages, not every ipv4/ipv6 capable program has support for it. Even for those programs that do support it, the API requires processes

[PATCH v2 net-next 5/5] samples: bpf: add userspace example for modifying sk_bound_dev_if

2016-10-26 Thread David Ahern
Add a simple program to demonstrate the ability to attach a bpf program to a cgroup that sets sk_bound_dev_if for AF_INET{6} sockets when they are created. v2 - removed bpf_sock_store_u32 references - changed BPF_CGROUP_INET_SOCK_CREATE to BPF_CGROUP_INET_SOCK - remove BPF_PROG_TYPE_CGROUP_SOCK pr

[PATCH net-next]ldmvsw: tx queue stuck in stopped state after LDC reset

2016-10-26 Thread Aaron Young
From: Aaron Young The following patch fixes an issue with the ldmvsw driver where the network connection of a guest domain becomes non-functional after a guest domain has panic'd and rebooted (resulting in a LDC reset). The root cause was determined to be from the following series

Re: [PATCH v2 2/5] kconfig: introduce the "suggest" keyword

2016-10-26 Thread Paul Bolle
On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote: > Similar to "imply" but with no added restrictions on the target symbol's > value. Useful for providing a default value to another symbol. > > Suggested by Edward Cree. > > Signed-off-by: Nicolas Pitre As far as I can see this series does

Re: [PATCH v2 0/5] make POSIX timers optional with some Kconfig help

2016-10-26 Thread Paul Bolle
On Wed, 2016-10-26 at 19:41 -0400, Nicolas Pitre wrote: > On Thu, 27 Oct 2016, Paul Bolle wrote: > > If you'll have to send another update don't bother including Yann. Yann > > hasn't be heard of in years. MAINTAINERS doesn't reflect reality for > > kconfig. > > What about updating it then? I don

Re: [PATCH v2 1/5] kconfig: introduce the "imply" keyword

2016-10-26 Thread Nicolas Pitre
On Thu, 27 Oct 2016, Paul Bolle wrote: > On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote: > > SUBSYSTEM_X can still be configured out, and it can be set as a > > module when none of the drivers are selected or all of them are also > > modular. > > Short note, to highlight a pet peeve: "s

Re: [PATCH v2 0/5] make POSIX timers optional with some Kconfig help

2016-10-26 Thread Nicolas Pitre
On Thu, 27 Oct 2016, Paul Bolle wrote: > On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote: > > From: Nicolas Pitre > > Subject: [PATCH v2 0/5] make POSIX timers optional with some Kconfig help > > This doesn't work. I received this message with an empty subject. Hmmm... must have dome som

Re: [PATCH v2 1/5] kconfig: introduce the "imply" keyword

2016-10-26 Thread Paul Bolle
On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote: > SUBSYSTEM_X can still be configured out, and it can be set as a > module when none of the drivers are selected or all of them are also > modular. Short note, to highlight a pet peeve: "select" (and therefor "selected") has a special meani

Re: [PATCH v2 0/5] make POSIX timers optional with some Kconfig help

2016-10-26 Thread Paul Bolle
On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote: > From: Nicolas Pitre > Subject: [PATCH v2 0/5] make POSIX timers optional with some Kconfig help This doesn't work. I received this message with an empty subject. If you'll have to send another update don't bother including Yann. Yann hasn

Re: [PATCH] drivers/net/usb/r8152 fix broken rx checksums

2016-10-26 Thread Mark Lord
On 16-10-26 06:36 PM, Mark Lord wrote: The r8152 driver has been broken since (approx) 3.6.16, Correction: broken since 3.16.xx. when support was added for hardware rx checksum on newer chip versions. Symptoms include random segfaults and silent data corruption over NFS. This does not work

Re: [PATCH v2 5/5] posix-timers: make it configurable

2016-10-26 Thread Nicolas Pitre
On Wed, 26 Oct 2016, Richard Cochran wrote: > On Wed, Oct 26, 2016 at 09:56:13AM -0400, Nicolas Pitre wrote: > > So if my Fedora usage doesn't need them, we can infer that > > the number of embedded systems also not needing them might tend towards > > a high percentage. > > (I wouldn't call Fed

[PATCH] drivers/net/usb/r8152 fix broken rx checksums

2016-10-26 Thread Mark Lord
The r8152 driver has been broken since (approx) 3.6.16, when support was added for hardware rx checksum on newer chip versions. Symptoms include random segfaults and silent data corruption over NFS. This does not work on the VER_02 dongle I have here when used with a slow embedded system CPU. Goo

Re: iproute: ss truncates abstract unix domain socket embedding null

2016-10-26 Thread Stephen Hemminger
On Wed, 26 Oct 2016 21:49:35 +0300 Isaac Boukris wrote: > Hi Stephen, thanks for looking into this. > > On Wed, Oct 26, 2016 at 8:15 PM, Stephen Hemminger > wrote: > > On Tue, 18 Oct 2016 21:46:48 +0300 > > Isaac Boukris wrote: > > > >> Hi again, > >> > >> On Sun, Oct 16, 2016 at 11:43 PM, I

Re: [PATCH 4/5] net: ethernet: bgmac: add NS2 support

2016-10-26 Thread Florian Fainelli
On 10/26/2016 12:36 PM, Jon Mason wrote: > Add support for the variant of amac hardware present in the Broadcom > Northstar2 based SoCs. Northstar2 requires an additional register to be > configured with the port speed/duplexity (NICPM). This can be added to > the link callback to hide it from th

Re: [PATCH net] sctp: fix the panic caused by route update

2016-10-26 Thread David Miller
From: Xin Long Date: Mon, 24 Oct 2016 01:01:09 +0800 > Commit 7303a1475008 ("sctp: identify chunks that need to be fragmented > at IP level") made the chunk be fragmented at IP level in the next round > if it's size exceed PMTU. > > But there still is another case, PMTU can be updated if transpo

Re: [PATCH net-next 2/2] firewire: net: set initial MTU = 1500 unconditionally, fix IPv6 on some CardBus cards

2016-10-26 Thread David Miller
From: Stefan Richter Date: Sun, 23 Oct 2016 16:30:56 +0200 > firewire-net, like the older eth1394 driver, reduced the initial MTU to > less than 1500 octets if the local link layer controller's asynchronous > packet reception limit was lower. > > This is bogus, since this reception limit does no

Re: [PATCH net] udp: fix IP_CHECKSUM handling

2016-10-26 Thread David Miller
From: Eric Dumazet Date: Sun, 23 Oct 2016 18:03:06 -0700 > From: Eric Dumazet > > First bug was added in commit ad6f939ab193 ("ip: Add offset parameter to > ip_cmsg_recv") : Tom missed that ipv4 udp messages could be received on > AF_INET6 socket. ip_cmsg_recv(msg, skb) should have been replace

Re: [PATCH net] doc: update docbook annotations for socket and skb

2016-10-26 Thread David Miller
From: Stephen Hemminger Date: Sun, 23 Oct 2016 09:28:29 -0700 > From: Stephen Hemminger > > The skbuff and sock structure both had missing parameter annotation > values. > > Signed-off-by: Stephen Hemminger Applied, thanks.

Re: [patch net-next] devlink: Prevent port_type_set() callback when it's not needed

2016-10-26 Thread David Miller
From: Jiri Pirko Date: Sun, 23 Oct 2016 17:43:05 +0200 > From: Elad Raz > > When a port_type_set() is been called and the new port type set is the same > as the old one, just return success. > > Signed-off-by: Elad Raz > Signed-off-by: Jiri Pirko Applied, thanks.

Re: [PATCH net-next 1/2] firewire: net: fix maximum possible MTU

2016-10-26 Thread David Miller
From: Stefan Richter Date: Sun, 23 Oct 2016 16:29:03 +0200 > Commit b3e3893e1253 ("net: use core MTU range checking in misc drivers") > mistakenly introduced an upper limit for firewire-net's MTU based on the > local link layer controller's reception capability. Revert this. Neither > RFC 2734

Re: [PATCH v1 1/1] ISDN: eicon: replace custom hex_dump_to_buffer()

2016-10-26 Thread David Miller
From: Andy Shevchenko Date: Sat, 22 Oct 2016 20:37:05 +0300 > Instead of custom approach re-use generic helper to convert bytes to hex > format. > > The output is slightly changed, namely string starts from the first dword > value. > > Signed-off-by: Andy Shevchenko This adds a warning. Real

Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

2016-10-26 Thread David Miller
From: Sven Eckelmann Date: Sat, 22 Oct 2016 09:46:24 +0200 > The maximum MTU is defined via the slave devices of an batman-adv > interface. Thus it is not possible to calculate the max_mtu during the > creation of the batman-adv device when no slave devices are attached. Doing > so would for exam

Re: [PATCH -next] net: netcp: drop kfree for memory allocated with devm_kzalloc

2016-10-26 Thread David Miller
None of your patches apply to the net-next tree. I'm getting extremely troubled by the quality of your submissions and the effort you are not putting into making sure you submit patches which will apply cleanly against the net-next tree. I think I'm at the point where it is extremely fair for me

Re: [PATCH -next] rocker: fix error return code in rocker_world_check_init()

2016-10-26 Thread David Miller
From: Jiri Pirko Date: Sat, 22 Oct 2016 17:34:29 +0200 > Sat, Oct 22, 2016 at 04:31:06PM CEST, weiyj...@gmail.com wrote: >>From: Wei Yongjun >> >>Fix to return error code -EINVAL from the error handling >>case instead of 0, as done elsewhere in this function. >> >>Signed-off-by: Wei Yongjun >

Re: [PATCH 0/2] Broadcom BCM54612E support

2016-10-26 Thread David Miller
From: Xo Wang Date: Fri, 21 Oct 2016 10:20:11 -0700 > This series is based on tip of torvalds/master. > > The first patch adds register definitions from Broadcom docs. > > The second patch adds the BCM54612E PHY ID, flags, and device-specific > RGMII internal delay initialization. > > I tested

Re: [PATCH net-next] sch_htb: do not report fake rate estimators

2016-10-26 Thread David Miller
From: Eric Dumazet Date: Fri, 21 Oct 2016 09:02:43 -0700 > From: Eric Dumazet > > When I prepared commit d250a5f90e53 ("pkt_sched: gen_estimator: Dont > report fake rate estimators"), htb still had an implicit rate estimator > for all its classes. > > Then later, I made this rate estimator opt

Re: [PATCH] net: bonding: use new api ethtool_{get|set}_link_ksettings

2016-10-26 Thread Philippe Reynes
Hi Jay, On Wed, Oct 26, 2016 at 8:00 PM, Jay Vosburgh wrote: > Philippe Reynes wrote: > >>The ethtool api {get|set}_settings is deprecated. >>We move this driver to new api {get|set}_link_ksettings. > > This is just an API change, i.e., no change to functionality? Yes, it's juste an API

Re: [PATCH net-next] net: dev: Fix non-RCU based lower dev walker

2016-10-26 Thread Ido Schimmel
On Wed, Oct 26, 2016 at 01:21:33PM -0700, David Ahern wrote: > netdev_walk_all_lower_dev is not properly walking the lower device > list. Commit 1a3f060c1a47 made netdev_walk_all_lower_dev similar > to netdev_walk_all_upper_dev_rcu and netdev_walk_all_lower_dev_rcu > but failed to update its netde

Re: [PATCH net-next 2/3] bpf: Add new cgroups prog type to enable sock modifications

2016-10-26 Thread David Ahern
On 10/26/16 2:31 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > The hook insertion in sk_alloc() may not solve all control-path checks as not > much can be done (probably apart for changing sk_bound_dev_if) during > allocation but hooks in bind(), listen(), setsockopt() etc. (not a complete > list)

[PATCH net-next] net: dev: Fix non-RCU based lower dev walker

2016-10-26 Thread David Ahern
netdev_walk_all_lower_dev is not properly walking the lower device list. Commit 1a3f060c1a47 made netdev_walk_all_lower_dev similar to netdev_walk_all_upper_dev_rcu and netdev_walk_all_lower_dev_rcu but failed to update its netdev_next_lower_dev iterator. This patch fixes that. Fixes: 1a3f060c1a4

Re: [PATCH v2 5/5] posix-timers: make it configurable

2016-10-26 Thread Richard Cochran
On Wed, Oct 26, 2016 at 09:56:13AM -0400, Nicolas Pitre wrote: > So if my Fedora usage doesn't need them, we can infer that > the number of embedded systems also not needing them might tend towards > a high percentage. (I wouldn't call Fedora an embedded distro, but heh...) > But let's be conse

Re: [kernel-hardening] [RFC v4 03/18] bpf,landlock: Add a new arraymap type to deal with (Landlock) handles

2016-10-26 Thread Jann Horn
On Wed, Oct 26, 2016 at 10:03:09PM +0200, Mickaël Salaün wrote: > On 26/10/2016 21:01, Jann Horn wrote: > > On Wed, Oct 26, 2016 at 08:56:39AM +0200, Mickaël Salaün wrote: > >> This new arraymap looks like a set and brings new properties: > >> * strong typing of entries: the eBPF functions get the

Re: [kernel-hardening] [RFC v4 03/18] bpf,landlock: Add a new arraymap type to deal with (Landlock) handles

2016-10-26 Thread Mickaël Salaün
On 26/10/2016 21:01, Jann Horn wrote: > On Wed, Oct 26, 2016 at 08:56:39AM +0200, Mickaël Salaün wrote: >> This new arraymap looks like a set and brings new properties: >> * strong typing of entries: the eBPF functions get the array type of >> elements instead of CONST_PTR_TO_MAP (e.g. >> CON

Re: [PATCH v7 0/6] Add eBPF hooks for cgroups

2016-10-26 Thread Pablo Neira Ayuso
On Tue, Oct 25, 2016 at 12:14:08PM +0200, Daniel Mack wrote: [...] > Dumping programs once they are installed is problematic because of > the internal optimizations done to the eBPF program during its > lifetime. Also, the references to maps etc. would need to be > restored during the dump.

Re: [PATCH net-next] tcp/dccp: drop SYN packets if accept queue is full

2016-10-26 Thread Yuchung Cheng
On Wed, Oct 26, 2016 at 11:39 AM, Neal Cardwell wrote: > > On Wed, Oct 26, 2016 at 12:27 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > Per listen(fd, backlog) rules, there is really no point accepting a SYN, > > sending a SYNACK, and dropping the following ACK packet if accept queue > >

[PATCH 3/5] net: ethernet: bgmac: device tree phy enablement

2016-10-26 Thread Jon Mason
Change the bgmac driver to allow for phy's defined by the device tree Signed-off-by: Jon Mason --- drivers/net/ethernet/broadcom/bgmac-bcma.c | 48 drivers/net/ethernet/broadcom/bgmac-platform.c | 48 +++- drivers/net/ethernet/broadcom/bgmac.c

[PATCH 0/5] add NS2 support to bgmac

2016-10-26 Thread Jon Mason
Add support for the amac found in the Broadcom Northstar2 SoC to the bgmac driver. This necessitates adding support to connect to an externally defined phy (as described in the device tree) in the driver. These phy changes are in addition to the changes necessary to get NS2 working. This series (

[PATCH 2/5] Documentation: devicetree: net: add NS2 bindings to amac

2016-10-26 Thread Jon Mason
Signed-off-by: Jon Mason --- Documentation/devicetree/bindings/net/brcm,amac.txt | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/brcm,amac.txt b/Documentation/devicetree/bindings/net/brcm,amac.txt index ba5ecc1..f92caee 100644 ---

[PATCH 4/5] net: ethernet: bgmac: add NS2 support

2016-10-26 Thread Jon Mason
Add support for the variant of amac hardware present in the Broadcom Northstar2 based SoCs. Northstar2 requires an additional register to be configured with the port speed/duplexity (NICPM). This can be added to the link callback to hide it from the instances that do not use this. Also, the bgmac

[PATCH 1/5] net: phy: broadcom: Add BCM54810 phy entry

2016-10-26 Thread Jon Mason
From: Vikas Soni Add BCM54810 phy entry Signed-off-by: Vikas Soni Signed-off-by: Jon Mason --- drivers/net/phy/Kconfig| 2 +- drivers/net/phy/broadcom.c | 65 ++ include/linux/brcmphy.h| 7 + 3 files changed, 73 insertions(+), 1 deleti

[PATCH 5/5] arm64: dts: NS2: add AMAC ethernet support

2016-10-26 Thread Jon Mason
Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device tree Signed-off-by: Jon Mason --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 + arch/arm64/boot/dts/broadcom/ns2.dtsi| 12 2 files changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/broadcom/

[RFC net-next iproute2 1/2] libnetlink: Add test for error code returned from netlink reply

2016-10-26 Thread Cyrill Gorcunov
In case if some diag module is not present in the system, say the kernel is not modern enough, we simply skip the error code reported. Instead we should check for data length in NLMSG_DONE and process unsupported case. Signed-off-by: Cyrill Gorcunov --- lib/libnetlink.c | 21

[RFC net-next iproute2 2/2] ss: Add inet raw sockets information gathering via netlink diag interface

2016-10-26 Thread Cyrill Gorcunov
unix, tcp, udp[lite], packet, netlink sockets already support diag interface for their collection and killing. Now with commit XXX this facility is implemented for raw sockets. Signed-off-by: Cyrill Gorcunov --- include/linux/inet_diag.h | 15 +++ misc/ss.c | 20 +

[RFC net-next iproute2 0/2] Add support for operating raw sockest via diag interface

2016-10-26 Thread Cyrill Gorcunov
The diag interface for raw sockets is now in linux-net-next http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=432490f9d455fb842d70219f22d9d2c812371676 so here is early patches for misc/ss While "showing" action works as expected, I see some weird effects on "kill" socket ac

Re: [PATCH net v2] packet: on direct_xmit, limit tso and csum to supported devices

2016-10-26 Thread Daniel Borkmann
On 10/26/2016 05:23 PM, Willem de Bruijn wrote: From: Willem de Bruijn When transmitting on a packet socket with PACKET_VNET_HDR and PACKET_QDISC_BYPASS, validate device support for features requested in vnet_hdr. Drop TSO packets sent to devices that do not support TSO or have the feature dis

Re: [PATCH net-next 2/3] bpf: Add new cgroups prog type to enable sock modifications

2016-10-26 Thread Thomas Graf
On 10/26/16 at 10:08am, David Ahern wrote: > On 10/26/16 2:41 AM, Thomas Graf wrote: > > On 10/25/16 at 03:30pm, David Ahern wrote: > >> @@ -171,6 +177,9 @@ int __cgroup_bpf_run_filter(struct sock *sk, > >>case BPF_CGROUP_INET_EGRESS: > >>ret = __cgroup_bpf_run_filte

Re: [kernel-hardening] [RFC v4 03/18] bpf,landlock: Add a new arraymap type to deal with (Landlock) handles

2016-10-26 Thread Jann Horn
On Wed, Oct 26, 2016 at 08:56:39AM +0200, Mickaël Salaün wrote: > This new arraymap looks like a set and brings new properties: > * strong typing of entries: the eBPF functions get the array type of > elements instead of CONST_PTR_TO_MAP (e.g. > CONST_PTR_TO_LANDLOCK_HANDLE_FS); > * force seque

[PATCH net] ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context

2016-10-26 Thread Thomas Falcon
Schedule these XPORT event tasks in the shared workqueue so that IRQs are not freed in an interrupt context when sub-CRQs are released. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 35 --- drivers/net/ethernet/ibm/ibmvnic.h | 1 + 2 files

Re: iproute: ss truncates abstract unix domain socket embedding null

2016-10-26 Thread Isaac Boukris
Hi Stephen, thanks for looking into this. On Wed, Oct 26, 2016 at 8:15 PM, Stephen Hemminger wrote: > On Tue, 18 Oct 2016 21:46:48 +0300 > Isaac Boukris wrote: > >> Hi again, >> >> On Sun, Oct 16, 2016 at 11:43 PM, Isaac Boukris wrote: >> > Hello, >> > >> > The unix(7) man page says that null h

Re: [PATCH net-next] tcp/dccp: drop SYN packets if accept queue is full

2016-10-26 Thread Neal Cardwell
On Wed, Oct 26, 2016 at 12:27 PM, Eric Dumazet wrote: > From: Eric Dumazet > > Per listen(fd, backlog) rules, there is really no point accepting a SYN, > sending a SYNACK, and dropping the following ACK packet if accept queue > is full, because application is not draining accept queue fast enough

Re: [PATCH iproute2 net-next] tc: m_mirred: Fix parsing of 'index' optional argument

2016-10-26 Thread Stephen Hemminger
On Fri, 21 Oct 2016 23:01:15 +0300 Shmulik Ladkani wrote: > Code in parse_mirred() suggests "index" argument can be placed either > after the "egress" clause, or as the first argument (after "action mirred"). > > However, parse_egress() fails to correctly parse "index" if it's the > first argume

Re: [PATCH iproute2 net-next] tc: m_mirred: Add support for ingress redirect/mirror

2016-10-26 Thread Stephen Hemminger
On Wed, 19 Oct 2016 17:14:09 +0300 Shmulik Ladkani wrote: > So far, only the 'egress' direction was implemented. > > Allow specifying 'ingress' as the direction packet appears on the target > interface. > > For example, this takes incoming 802.1q frames on veth0 and redirects > them for input o

Re: nfs NULL-dereferencing in net-next

2016-10-26 Thread Anna Schumaker
On 10/26/2016 02:08 PM, Jakub Kicinski wrote: > On Wed, 26 Oct 2016 16:15:24 +, Yotam Gigi wrote: >>> -Original Message- >>> From: Anna Schumaker [mailto:anna.schuma...@netapp.com] >>> Sent: Wednesday, October 26, 2016 5:40 PM >>> To: Yotam Gigi ; Jakub Kicinski ; Andy >>> Adamson ; Ann

Re: [PATCH v3] iproute2: macvlan: add "source" mode

2016-10-26 Thread Stephen Hemminger
On Sun, 25 Sep 2016 21:08:55 +0200 Michael Braun wrote: > Adjusting iproute2 utility to support new macvlan link type mode called > "source". > > Example of commands that can be applied: > ip link add link eth0 name macvlan0 type macvlan mode source > ip link set link dev macvlan0 type macvl

Re: nfs NULL-dereferencing in net-next

2016-10-26 Thread Jakub Kicinski
On Wed, 26 Oct 2016 16:15:24 +, Yotam Gigi wrote: > >-Original Message- > >From: Anna Schumaker [mailto:anna.schuma...@netapp.com] > >Sent: Wednesday, October 26, 2016 5:40 PM > >To: Yotam Gigi ; Jakub Kicinski ; Andy > >Adamson ; Anna Schumaker > >; linux-...@vger.kernel.org > >Cc: net

Re: [PATCH] net: mv643xx_eth: Fetch the phy connection type from DT

2016-10-26 Thread Florian Fainelli
On 10/26/2016 10:47 AM, Jason Gunthorpe wrote: > The MAC is capable of RGMII mode and that is probably a more typical > connection type than GMII today (eg it is used by Marvell Reference > designs for several SOCs). Let DT users specify the standard > >phy-connection-type = "rgmii-id"; > > O

Re: [PATCH] net: bonding: use new api ethtool_{get|set}_link_ksettings

2016-10-26 Thread Jay Vosburgh
Philippe Reynes wrote: >The ethtool api {get|set}_settings is deprecated. >We move this driver to new api {get|set}_link_ksettings. This is just an API change, i.e., no change to functionality? -J >Signed-off-by: Philippe Reynes >--- > drivers/net/bonding/bond_main.c | 16 ++

Re: [PATCH iproute2 2/2] tc filters: fix filters to display handle when deleted even when no option

2016-10-26 Thread Stephen Hemminger
On Mon, 17 Oct 2016 05:34:45 -0400 Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > Fix a few stylistic things that hurt my eyes while at it. > > Signed-off-by: Jamal Hadi Salim This patch has whitespace issues, please fix and resubmit. ARNING: suspect code indent for conditional state

[PATCH] i40e: fix panic on SPARC while changing num of desc

2016-10-26 Thread Tushar Dave
On SPARC, writel() should not be used to write directly to memory address but only to memory mapped I/O address otherwise it causes data access exception. Commit 147e81ec75689 ("i40e: Test memory before ethtool alloc succeeds") introduced a code that uses memory address to fake the HW tail address

[PATCH] net: mv643xx_eth: Fetch the phy connection type from DT

2016-10-26 Thread Jason Gunthorpe
The MAC is capable of RGMII mode and that is probably a more typical connection type than GMII today (eg it is used by Marvell Reference designs for several SOCs). Let DT users specify the standard phy-connection-type = "rgmii-id"; On a phy node. Signed-off-by: Jason Gunthorpe --- .../devic

Re: [v12, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

2016-10-26 Thread Scott Wood
On Wed, 2016-09-21 at 14:57 +0800, Yangbo Lu wrote: > diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig > new file mode 100644 > index 000..b99764c > --- /dev/null > +++ b/drivers/soc/fsl/Kconfig > @@ -0,0 +1,19 @@ > +# > +# Freescale SOC drivers > +# > + > +source "drivers/soc/fsl

Re: [RFC v4 00/18] Landlock LSM: Unprivileged sandboxing

2016-10-26 Thread Mickaël Salaün
On 26/10/2016 18:56, Mickaël Salaün wrote: > > On 26/10/2016 16:52, Jann Horn wrote: >> On Wed, Oct 26, 2016 at 08:56:36AM +0200, Mickaël Salaün wrote: >>> The loaded Landlock eBPF programs can be triggered by a seccomp filter >>> returning RET_LANDLOCK. In addition, a cookie (16-bit value) can be

[PATCH net] Revert "hv_netvsc: report vmbus name in ethtool"

2016-10-26 Thread Stephen Hemminger
From: Stephen Hemminger This reverts commit e3f74b841d48 ("hv_netvsc: report vmbus name in ethtool")' because of problem introduced by commit f9a56e5d6a0ba ("Drivers: hv: make VMBus bus ids persistent"). This changed the format of the vmbus name and this new format is too long to fit in the bus_i

Re: [Intel-wired-lan] [net-next PATCH 25/27] igb: Update driver to make use of DMA_ATTR_SKIP_CPU_SYNC

2016-10-26 Thread Jeff Kirsher
On Tue, 2016-10-25 at 11:39 -0400, Alexander Duyck wrote: > The ARM architecture provides a mechanism for deferring cache line > invalidation in the case of map/unmap.  This patch makes use of this > mechanism to avoid unnecessary synchronization. > > A secondary effect of this change is that the

Re: [Intel-wired-lan] [net-next PATCH 27/27] igb: Revert "igb: Revert support for build_skb in igb"

2016-10-26 Thread Jeff Kirsher
On Tue, 2016-10-25 at 11:39 -0400, Alexander Duyck wrote: > This reverts commit f9d40f6a9921 ("igb: Revert support for build_skb in > igb") and adds a few changes to update it to work with the latest version > of igb. We are now able to revert the removal of this due to the fact > that with the rec

Re: [Intel-wired-lan] [net-next PATCH 26/27] igb: Update code to better handle incrementing page count

2016-10-26 Thread Jeff Kirsher
On Tue, 2016-10-25 at 11:39 -0400, Alexander Duyck wrote: > This patch updates the driver code so that we do bulk updates of the page > reference count instead of just incrementing it by one reference at a > time. > The advantage to doing this is that we cut down on atomic operations and > this in

Re: iproute: ss truncates abstract unix domain socket embedding null

2016-10-26 Thread Stephen Hemminger
On Tue, 18 Oct 2016 21:46:48 +0300 Isaac Boukris wrote: > Hi again, > > On Sun, Oct 16, 2016 at 11:43 PM, Isaac Boukris wrote: > > Hello, > > > > The unix(7) man page says that null have no special meaning in > > abstract unix domain socket address (the length is specified > > therefore). > > >

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-26 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 26 Oct 2016 20:07:19 +0300 > On Wed, Oct 26, 2016 at 12:52:45PM -0400, David Miller wrote: >> From: "Michael S. Tsirkin" >> Date: Wed, 26 Oct 2016 19:36:45 +0300 >> >> > On Wed, Oct 26, 2016 at 03:52:02PM +0200, Jesper Dangaard Brouer wrote: >> >> On Sat, 2

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-26 Thread Eric Dumazet
On Wed, 2016-10-26 at 18:53 +0200, Abdelrhman Ahmed wrote: > I think it's at the right place as the current one is a little different from > the > commit e1f165032c8bade3a6bdf546f8faf61fda4dd01c. > > In the next lines, skb_push is called after copying the hardware header and > there > is no chan

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-26 Thread Michael S. Tsirkin
On Wed, Oct 26, 2016 at 12:52:45PM -0400, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Wed, 26 Oct 2016 19:36:45 +0300 > > > On Wed, Oct 26, 2016 at 03:52:02PM +0200, Jesper Dangaard Brouer wrote: > >> On Sat, 22 Oct 2016 04:07:23 + > >> Shrijeet Mukherjee wrote: > >> > >> > Thi

Re: [RFC v4 00/18] Landlock LSM: Unprivileged sandboxing

2016-10-26 Thread Mickaël Salaün
On 26/10/2016 16:52, Jann Horn wrote: > On Wed, Oct 26, 2016 at 08:56:36AM +0200, Mickaël Salaün wrote: >> The loaded Landlock eBPF programs can be triggered by a seccomp filter >> returning RET_LANDLOCK. In addition, a cookie (16-bit value) can be passed >> from >> a seccomp filter to eBPF progr

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-26 Thread Abdelrhman Ahmed
I think it's at the right place as the current one is a little different from the commit e1f165032c8bade3a6bdf546f8faf61fda4dd01c. In the next lines, skb_push is called after copying the hardware header and there is no change to the data pointer inside the retry loop. We only need to reset befor

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-26 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 26 Oct 2016 19:36:45 +0300 > On Wed, Oct 26, 2016 at 03:52:02PM +0200, Jesper Dangaard Brouer wrote: >> On Sat, 22 Oct 2016 04:07:23 + >> Shrijeet Mukherjee wrote: >> >> > This patch adds support for xdp ndo and also inserts the xdp program >> > call in

[PATCH next] flow_dissector: __skb_get_hash_symmetric arg can be const

2016-10-26 Thread Florian Westphal
Signed-off-by: Florian Westphal --- include/linux/skbuff.h| 2 +- net/core/flow_dissector.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 601258f6e621..663fda2887f7 100644 --- a/include/linux/skbuff.h +++ b/include

Re: [PATCH net] bpf: fix samples to add fake KBUILD_MODNAME

2016-10-26 Thread Alexei Starovoitov
On Wed, Oct 26, 2016 at 09:01:48AM +0200, Daniel Borkmann wrote: > On 10/26/2016 03:17 AM, Alexei Starovoitov wrote: > >On Wed, Oct 26, 2016 at 12:37:53AM +0200, Daniel Borkmann wrote: > >>Some of the sample files are causing issues when they are loaded with tc > >>and cls_bpf, meaning tc bails out

[PATCH net-next] net: phy: at803x: Add a definition for PHY ID mask

2016-10-26 Thread Fabio Estevam
Add a definition for PHY ID mask for improving code readability. Signed-off-by: Fabio Estevam --- drivers/net/phy/at803x.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index f279a89..dd47b69 100644 --- a/dri

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-26 Thread Michael S. Tsirkin
On Wed, Oct 26, 2016 at 03:52:02PM +0200, Jesper Dangaard Brouer wrote: > On Sat, 22 Oct 2016 04:07:23 + > Shrijeet Mukherjee wrote: > > > This patch adds support for xdp ndo and also inserts the xdp program > > call into the merged RX buffers and big buffers paths > > I really appreciate yo

[PATCH net] Revert "hv_netvsc: report vmbus name in ethtool"

2016-10-26 Thread Stephen Hemminger
From: Stephen Hemminger This reverts commit e3f74b841d48 ("hv_netvsc: report vmbus name in ethtool")' because of problem introduced by commit f9a56e5d6a0ba ("Drivers: hv: make VMBus bus ids persistent"). This changed the format of the vmbus name and this new format is too long to fit in the bus_i

[PATCH net-next] tcp/dccp: drop SYN packets if accept queue is full

2016-10-26 Thread Eric Dumazet
From: Eric Dumazet Per listen(fd, backlog) rules, there is really no point accepting a SYN, sending a SYNACK, and dropping the following ACK packet if accept queue is full, because application is not draining accept queue fast enough. This behavior is fooling TCP clients that believe they establ

Re: [PATCH net v2] packet: on direct_xmit, limit tso and csum to supported devices

2016-10-26 Thread Eric Dumazet
On Wed, 2016-10-26 at 11:23 -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > When transmitting on a packet socket with PACKET_VNET_HDR and > PACKET_QDISC_BYPASS, validate device support for features requested > in vnet_hdr. Acked-by: Eric Dumazet

[PATCH 2/3] batman-adv: Add BATADV_DBG_TP_METER to BATADV_DBG_ALL

2016-10-26 Thread Simon Wunderlich
From: Sven Eckelmann The BATADV_DBG_ALL has to contain the bit of BATADV_DBG_TP_METER to really support all available debug messages. Fixes: 33a3bb4a3345 ("batman-adv: throughput meter implementation") Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/log.h | 2

Re: [PATCH v2 0/9] net: add support for IPv6 Segment Routing

2016-10-26 Thread David Lebrun
On 10/26/2016 05:54 PM, David Lebrun wrote: > struct ipv6_sr_hdr { > __u8nexthdr; > __u8hdrlen; > __u8type; > __u8segments_left; > __u8first_segment; > __be16 flags; > __u8reserved; > > struct in6_addr segment

[PATCH 1/3] batman-adv: Modify neigh_list only with rcu-list functions

2016-10-26 Thread Simon Wunderlich
From: Sven Eckelmann The batadv_hard_iface::neigh_list is accessed via rcu based primitives. Thus all operations done on it have to fulfill the requirements by RCU. So using non-RCU mechanisms like hlist_add_head is not allowed because it misses the barriers required to protect concurrent readers

Re: [PATCH net-next 2/3] bpf: Add new cgroups prog type to enable sock modifications

2016-10-26 Thread David Ahern
On 10/26/16 2:41 AM, Thomas Graf wrote: > On 10/25/16 at 03:30pm, David Ahern wrote: >> @@ -171,6 +177,9 @@ int __cgroup_bpf_run_filter(struct sock *sk, >> case BPF_CGROUP_INET_EGRESS: >> ret = __cgroup_bpf_run_filter_skb(skb, prog); >> break;

  1   2   >