Re: [PATCH iproute2 2/2] tc filters: fix filters to display handle when deleted even when no option

[Stephen Hemminger]

On Mon, 17 Oct 2016 05:34:45 -0400
Jamal Hadi Salim <j...@mojatatu.com> wrote:

> From: Jamal Hadi Salim <j...@mojatatu.com>
> 
> Fix a few stylistic things that hurt my eyes while at it.
> 
> Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com>

This patch has whitespace issues, please fix and resubmit.


ARNING: suspect code indent for conditional statements (16, 19)
#127: FILE: tc/f_fw.c:126:
+               if (tb[TCA_FW_MASK]) {
+                  __u32 tmask = rta_getattr_u32(tb[TCA_FW_MASK]);

WARNING: Statements should start on a tabstop
#131: FILE: tc/f_fw.c:129:
+                  if (tmask != 0xFFFFFFFF)

WARNING: suspect code indent for conditional statements (19, 27)
#131: FILE: tc/f_fw.c:129:
+                  if (tmask != 0xFFFFFFFF)
+                          mask = tmask;