Re: [PATCH] fib_trie: Fix the description of pos and bits

2016-08-18 Thread David Miller
From: Xunlei Pang Date: Thu, 18 Aug 2016 12:33:28 +0800 > 1) Fix one typo: s/tn/tp/ > 2) Fix the description about the "u" bits. > > Signed-off-by: Xunlei Pang Applied.

Re: [PATCH] atm: fore200e: Do not drop const qualifier

2016-08-18 Thread David Miller
From: LABBE Corentin Date: Wed, 17 Aug 2016 15:56:45 +0200 > The data member of structure firmware is const and this constness is > dropped by some cast. > This patch add some const for keeping the const information. > > Signed-off-by: LABBE Corentin Applied.

Re: [PATCH net-next 0/4] BPF helper improvements and cleanups

2016-08-18 Thread David Miller
From: Daniel Borkmann Date: Thu, 18 Aug 2016 01:00:37 +0200 > This set adds various improvements to BPF helpers, a cleanup to use > skb_pkt_type_ok() helper, addition of bpf_skb_change_tail(), a follow > up for event output helper and removing ifdefs around the cgroupv2 > helper bits. For details

RE: [PATCH] net: macb: add phy-handle support for the macb

2016-08-18 Thread Appana Durga Kedareswara Rao
Hi Andrew, Thanks for the review... > > > Agree with you my intention is if there is a MDIO bus on the > > device-tree The MAC driver should create PHY/MDIO devices using > of_mdiobus_register(). > > What you suggest is better, and is similar to what other drivers use. > > In order to

Re: [PATCH net-next] tcp: refine tcp_prune_ofo_queue() to not drop all packets

2016-08-18 Thread David Miller
From: Eric Dumazet Date: Wed, 17 Aug 2016 14:17:09 -0700 > From: Eric Dumazet > > Over the years, TCP BDP has increased a lot, and is typically > in the order of ~10 Mbytes with help of clever Congestion Control > modules. > > In presence of packet losses, TCP stores incoming packets into an o

Re: [PATCH net-next] net: bgmac: make it clear when setting interface type to RMII

2016-08-18 Thread David Miller
From: Rafał Miłecki Date: Wed, 17 Aug 2016 23:11:52 +0200 > From: Rafał Miłecki > > It doesn't really change anything as BGMAC_CHIPCTL_1_IF_TYPE_RMII is > equal to 0. It make code a bit clener, so far when reading it one could > think we forgot to set a proper mode. It also keeps this mode code

Re: [PATCH net-next] net: bgmac: support Ethernet core on BCM53573 SoCs

2016-08-18 Thread David Miller
From: Rafał Miłecki Date: Wed, 17 Aug 2016 23:00:30 +0200 > From: Rafał Miłecki > > BCM53573 is a new series of Broadcom's SoCs. It's based on ARM and can > be found in two packages (versions): BCM53573 and BCM47189. It shares > some code with the Northstar family, but also requires some new qu

[PATCH net-next] qed: utilize FW 8.10.10.0

2016-08-18 Thread Yuval Mintz
This new firmware for the qed* adpaters fixes several issues: - Better blocking of malicious VFs. - After FLR, Tx-switching [internal routing] of packets might be incorrect. - Deletion of unicast MAC filters would sometime have side-effect of corrupting the MAC filters configred for a devi

Re: [PATCH net] tcp: fix use after free in tcp_xmit_retransmit_queue()

2016-08-18 Thread David Miller
From: Eric Dumazet Date: Wed, 17 Aug 2016 05:56:26 -0700 > From: Eric Dumazet > > When tcp_sendmsg() allocates a fresh and empty skb, it puts it at the > tail of the write queue using tcp_add_write_queue_tail() > > Then it attempts to copy user data into this fresh skb. > > If the copy fails,

Re: [PATCH] net: ethernet: nuvoton: fix spelling mistake: "aligment" -> "alignment"

2016-08-18 Thread David Miller
From: Colin King Date: Wed, 17 Aug 2016 18:31:35 +0100 > From: Colin Ian King > > trivial fix to spelling mistake in dev_err message > > Signed-off-by: Colin Ian King Applied to net-next.

Re: [PATCH net-next] xen-netback: create a debugfs node for hash information

2016-08-18 Thread David Miller
From: Paul Durrant Date: Wed, 17 Aug 2016 16:13:29 +0100 > It is useful to be able to see the hash configuration when running tests. > This patch adds a debugfs node for that purpose. > > Signed-off-by: Paul Durrant Applied.

Re: [PATCH net-next] sfc: avoid division by zero

2016-08-18 Thread David Miller
From: Edward Cree Date: Wed, 17 Aug 2016 16:00:10 +0100 > The division is already being done properly in efx_ef10_get_timer_config > which returns zero-on-success, unlike the old efx_ef10_get_sysclk_freq. > > Fixes: d95e329a55ba ("sfc: get timer configuration from adapter") > Signed-off-by: Edwa

Re: [PATCH net-next] tcp: defer sacked assignment

2016-08-18 Thread David Miller
From: Eric Dumazet Date: Wed, 17 Aug 2016 07:48:36 -0700 > From: Eric Dumazet > > While chasing tcp_xmit_retransmit_queue() kasan issue, I found > that we could avoid reading sacked field of skb that we wont send, > possibly removing one cache line miss. > > Very minor change in slow path, but

Re: [PATCH net] net: bgmac: fix reversed check for MII registration error

2016-08-18 Thread David Miller
From: Rafał Miłecki Date: Wed, 17 Aug 2016 15:37:14 +0200 > From: Rafał Miłecki > > It was failing on successful registration returning meaningless errors. > > Signed-off-by: Rafał Miłecki > Fixes: 55954f3bfdac ("net: ethernet: bgmac: move BCMA MDIO Phy code into a > separate file") Applied

Re: [PATCH v2 0/2]fixes to kaweth in response to Umap2 testing

2016-08-18 Thread David Miller
From: Oliver Neukum Date: Wed, 17 Aug 2016 15:51:54 +0200 > These patches fix an oops in firmware downloading and an oops due > to a memory allocation failure Series applied, thanks Oliver.

Re: [PATCH net-next 0/2] net: bridge: export vlan stats per-port with flags

2016-08-18 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 17 Aug 2016 12:53:08 +0200 > This set adds the ability to export vlan stats per-port. Patch 01 makes > that possible by consolidating the bridge and port linkxstats calls. Then > patch 02 allows to dump the vlan entry flags in order to be able to > distinguish

Re: [PATCHv3 net-next 3/4] chcr: Support for Chelsio's Crypto Hardware

2016-08-18 Thread Herbert Xu
On Wed, Aug 17, 2016 at 12:33:05PM +0530, Hariprasad Shenai wrote: > The Chelsio's Crypto Hardware can perform the following operations: > SHA1, SHA224, SHA256, SHA384 and SHA512, HMAC(SHA1), HMAC(SHA224), > HMAC(SHA256), HMAC(SHA384), HAMC(SHA512), AES-128-CBC, AES-192-CBC, > AES-256-CBC, AES-128-

Re: [PATCHv3 net-next 0/4] crypto/chcr: Add support for Chelsio Crypto Driver

2016-08-18 Thread Herbert Xu
On Thu, Aug 18, 2016 at 11:11:01PM -0700, David Miller wrote: > From: Hariprasad Shenai > Date: Wed, 17 Aug 2016 12:33:02 +0530 > > > This patch series adds support for Chelsio Crypto driver. > > Herbert, what do you want to do with this? I can push it via > net-next if you like. Sure thing,

Re: [PATCH net-next V2 0/5] net_sched, flow_dissector, flower: Introduce vlan tag support

2016-08-18 Thread David Miller
From: Hadar Hen Zion Date: Wed, 17 Aug 2016 13:36:09 +0300 > This patchset introduce vlan tag support to the flower classifier and the flow > dissector. In addition to adding vlan priority to act vlan. > > The first 2 patches are dealing with flow-dissector: > - The first patch is a fix, in cas

Re: [PATCHv3 net-next 0/4] crypto/chcr: Add support for Chelsio Crypto Driver

2016-08-18 Thread David Miller
From: Hariprasad Shenai Date: Wed, 17 Aug 2016 12:33:02 +0530 > This patch series adds support for Chelsio Crypto driver. Herbert, what do you want to do with this? I can push it via net-next if you like.

Re: [PATCH net] cxgb4: Fixes resource allocation for ULD's in kdump kernel

2016-08-18 Thread David Miller
From: Hariprasad Shenai Date: Wed, 17 Aug 2016 14:09:28 +0530 > At present the code to check in kdump kernel was not disabling > allocation of resources when CONFIG_CHELSIO_T4_DCB is defined, move the > code outside #defines so that it gets disabled irrespective of #define, > when in kdump kernel

Re: [PATCH net-next 0/2] qed*: Fix ethtool issues relating to link

2016-08-18 Thread David Miller
From: Yuval Mintz Date: Fri, 19 Aug 2016 08:34:56 +0300 > This series addresses two issues that were introduced when adding > support for ethtool's link_ksettings support - the first fixes a > regression and second incorrect functionallity in the submission. > > Although these are fixes, as the

[net-next 2/4] ixgbevf: change hw_dbg to use netdev_dbg

2016-08-18 Thread Jeff Kirsher
From: Emil Tantilov Instead of the home brewed macro make use of netdev_dbg same as the ixgbe driver. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 11 --- drivers/net/ethernet/intel/ixgbevf/i

[net-next 1/4] ixgbe: only check Tx queue enablement when debugging

2016-08-18 Thread Jeff Kirsher
From: Emil Tantilov Following a write the TXDCTL.ENABLE bit is set only when the Tx queue is actually enabled, which may not happen during the configure phase even if we waited for it. Make this check debug only since this is causing confusion with users who notice the warning in dmesg. Signed-o

[net-next 0/4][pull request] 10GbE Intel Wired LAN Driver Updates 2016-08-18

2016-08-18 Thread Jeff Kirsher
This series contains updates to ixgbe and ixgbevf. Emil cleans up confusing amongst the users by making an error message into a debug message, since the TXDCTL.ENABLE (and comparable VFTXDCTL.ENABLE for ixgbevf) bit is set only when the transmit queue is actually enabled, which may not happen duri

Re: [net-next 0/4][pull request] 1GbE Intel Wired LAN Driver Updates 2016-08-18

2016-08-18 Thread David Miller
From: Jeff Kirsher Date: Thu, 18 Aug 2016 22:30:46 -0700 > This series contains updates to igb only. Pulled, thanks Jeff.

[net-next 3/4] ixgbevf: only check Tx queue enablement when debugging

2016-08-18 Thread Jeff Kirsher
From: Emil Tantilov Following a write the VFTXDCTL.ENABLE bit is set only when the Tx queue is actually enabled, which may not happen during the configure phase even if we waited for it. Make this check debug only since this is causing confusion with users who notice the warning in dmesg. Signed

[net-next 4/4] ixgbe: use atomic bitwise operations when handling reset requests

2016-08-18 Thread Jeff Kirsher
From: Emil Tantilov Use atomic bitwise operations when setting and checking reset requests. This should help with possible races in the service task. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +- d

Re: [PATCH] smc91c92_cs : add a spinlock to avoid race condition

2016-08-18 Thread David Miller
From: Vaishali Thakkar Date: Fri, 19 Aug 2016 10:11:32 +0530 > > > On Friday 19 August 2016 09:37 AM, David Miller wrote: >> From: Pavel Andrianov >> Date: Tue, 16 Aug 2016 16:39:06 +0300 >> >>> smc_reset may be executed in parallel with timer function media_check. >>> To avoid data race in s

[PATCH 1/1] l2tp: Fix the connect status check in pppol2tp_getname

2016-08-18 Thread fgao
From: Gao Feng The sk->sk_state is bits flag, so need use bit operation check instead of value check. Signed-off-by: Gao Feng --- net/l2tp/l2tp_ppp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c index d9560aa..232cb92 100644 ---

[PATCH net-next 0/2] qed*: Fix ethtool issues relating to link

2016-08-18 Thread Yuval Mintz
This series addresses two issues that were introduced when adding support for ethtool's link_ksettings support - the first fixes a regression and second incorrect functionallity in the submission. Although these are fixes, as the feature currently exists only in 'next-next' I'm aiming them for it.

[PATCH net-next 1/2] qed*: Fix pause setting

2016-08-18 Thread Yuval Mintz
When moving into using ethtool's link_ksetting, qed started supplying its own bitmask of speed/capabilities, but qede is still checking for the SUPPORTED value to determine whether it supports pause. Fixes: 054c67d1c82a ("qed*: Add support for ethtool link_ksettings callbacks") Signed-off-by: Yuva

[PATCH net-next 2/2] qede: Fix forcing high speeds

2016-08-18 Thread Yuval Mintz
While '0xdead' and '0xbeef' are "great" values, we should use the correct SPEED_* values instead. Fixes: 054c67d1c82a ("qed*: Add support for ethtool link_ksettings callbacks") Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+

[net-next 4/4] igb: fix error code in igb_add_ethtool_nfc_entry()

2016-08-18 Thread Jeff Kirsher
From: Gangfeng Huang Use error "rmgr: Cannot insert RX class rule: Operation not supported" is more meaningful than "rmgr: Cannot insert RX class rule: Unknown error 524" Signed-off-by: Gangfeng Huang Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_e

[net-next 2/4] igb: support RX flow classification by ethertype

2016-08-18 Thread Jeff Kirsher
From: Gangfeng Huang This patch is meant to allow for RX network flow classification to insert and remove ethertype filter by ethtool Example: Add an ethertype filter: $ ethtool -N eth0 flow-type ether proto 0x88F8 action 2 Show all filters: $ ethtool -n eth0 4 RX rings available Total 1 rules

[net-next 1/4] igb: add support of RX network flow classification

2016-08-18 Thread Jeff Kirsher
From: Gangfeng Huang This patch is meant to allow for RX network flow classification to insert and remove Rx filter by ethtool. Ethtool interface has it's own rules manager Show all filters: $ ethtool -n eth0 4 RX rings available Total 2 rules Signed-off-by: Ruhao Gao Signed-off-by: Gangfeng H

[net-next 3/4] igb: support RX flow classification by VLAN priority

2016-08-18 Thread Jeff Kirsher
From: Gangfeng Huang This patch is meant to allow for RX network flow classification to insert and remove VLAN priority filter by ethtool Example: Add an VLAN priority filter: $ ethtool -N eth0 flow-type ether vlan 0x6000 vlan-mask 0x1FFF action 2 loc 1 Show all filters: $ ethtool -n eth0 4 RX

[net-next 0/4][pull request] 1GbE Intel Wired LAN Driver Updates 2016-08-18

2016-08-18 Thread Jeff Kirsher
This series contains updates to igb only. Gangfeng Huang provides all the changes in the series to update the igb driver to support advanced receive side filters that direct receive packets by flows to different hardware queues. This enables a tight control on routing a flow in the platform. Firs

Re: [PATCH] smc91c92_cs : add a spinlock to avoid race condition

2016-08-18 Thread Vaishali Thakkar
On Friday 19 August 2016 09:37 AM, David Miller wrote: > From: Pavel Andrianov > Date: Tue, 16 Aug 2016 16:39:06 +0300 > >> smc_reset may be executed in parallel with timer function media_check. >> To avoid data race in smc_set_xcvr a spinlock was added. >> >> Found by Linux Driver Verification

Re: [PATCH net-next 0/3] qed*: Add support for additional statistics.

2016-08-18 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Tue, 16 Aug 2016 10:51:00 -0400 > The patch series adds qed/qede support for new statistics. > Patch (1) adds couple of statistcs for "ethtool -S" display. > Patch (2) adds support for per-queue statistics to ethtool display. > Patch (3) adds qed support for NC

[PATCH net-next 0/5] net: dsa: bcm_sf2: Platform conversion

2016-08-18 Thread Florian Fainelli
Hi all, This patch series converts the bcm_sf2 driver from a traditional DSA driver into a platform_device driver and makes it use the new DSA binding that Andrew introduced in the latest merge window. Prior attempts used to coerce the code in net/dsa/dsa2.c to accept the old binding, while reall

Re: [PATCH] fib_trie: Fix the description of pos and bits

2016-08-18 Thread Alexander Duyck
On Wed, Aug 17, 2016 at 9:33 PM, Xunlei Pang wrote: > 1) Fix one typo: s/tn/tp/ > 2) Fix the description about the "u" bits. > > Signed-off-by: Xunlei Pang > --- > net/ipv4/fib_trie.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_

Re: [PATCH next-next 0/2] qdisc-hashtable fixes

2016-08-18 Thread David Miller
From: Jiri Kosina Date: Tue, 16 Aug 2016 23:52:08 +0200 (CEST) > The following two patches fix all the issues that have been reported > against the conversion of qdisc linked list to hashtable (currently in > net-next) so far. > > First patch adjusts handling of singleton qdiscs to the new sem

Re: [RFC PATCH] net: diag: support SOCK_DESTROY for UDP sockets

2016-08-18 Thread Eric Dumazet
On Thu, 2016-08-18 at 19:29 -0700, David Ahern wrote: > This implements SOCK_DESTROY for UDP sockets similar to what was done > for TCP with commit c1e64e298b8ca ("net: diag: Support destroying TCP > sockets.") A process with a UDP socket targeted for destroy is awakened > and recvmsg fails with EC

Re: [PATCH] net: thunderx: Fix OOPs with ethtool --register-dump

2016-08-18 Thread David Miller
From: David Daney Date: Tue, 16 Aug 2016 12:28:17 -0700 > From: David Daney > > The ethtool_ops .get_regs function attempts to read the nonexistent > register NIC_QSET_SQ_0_7_CNM_CHG, which produces a "bus error" type > OOPs. > > Fix by not attempting to read, and removing the definition of, >

Re: [PATCH net-next 0/2] tipc: bearer and link improvements

2016-08-18 Thread David Miller
From: Jon Maloy Date: Tue, 16 Aug 2016 11:53:49 -0400 > The first commit makes it possible to set and check the 'blocked' state > of a bearer from the generic bearer layer. The second commit is a small > improvement to the link congestion mechanism. Applied, thanks.

Re: [PATCH net] qede: Fix Tx timeout due to xmit_more

2016-08-18 Thread David Miller
From: Yuval Mintz Date: Tue, 16 Aug 2016 18:40:18 +0300 > Driver uses netif_tx_queue_stopped() to make sure the xmit_more > indication will be honored, but that only checks for DRV_XOFF. > > At the same time, it's possible that during transmission the DQL will > close the transmission queue with

Re: [PATCH] samples/bpf: Add tunnel set/get tests.

2016-08-18 Thread David Miller
From: William Tu Date: Tue, 16 Aug 2016 07:03:01 -0700 > The patch creates sample code exercising bpf_skb_{set,get}_tunnel_key, > and bpf_skb_{set,get}_tunnel_opt for GRE, VXLAN, and GENEVE. A native > tunnel device is created in a namespace to interact with a lwtunnel > device out of the namesp

Re: [PATCH 0/2] ipv6: fix stuck RA-derived route in container after migration with criu

2016-08-18 Thread David Miller
The indentation of both of your patches are incorrect. You must indent each basic block by a full TAB character. You must also line up multi-line function calls, such that the second and subsequent lines start precisely at the first column after the opennning parenthesis of the function call its

Re: [PATCH] smc91c92_cs : add a spinlock to avoid race condition

2016-08-18 Thread David Miller
From: Pavel Andrianov Date: Tue, 16 Aug 2016 16:39:06 +0300 > smc_reset may be executed in parallel with timer function media_check. > To avoid data race in smc_set_xcvr a spinlock was added. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Pavel Andrianov

Re: [PATCH] net: atm: remove redundant null pointer check on dev->name

2016-08-18 Thread David Miller
From: Colin King Date: Tue, 16 Aug 2016 12:08:42 +0100 > From: Colin Ian King > > dev->name is a char array of IFNAMSIZ elements, hence can never be > null, so the null pointer check is redundant. Remove it. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCHv3] net: ethernet: macb: Add support for rx_clk

2016-08-18 Thread David Miller
From: Shubhrajyoti Datta Date: Tue, 16 Aug 2016 10:14:50 +0530 > Some of the platforms like zynqmp ultrascale+ has a > separate clock gate for the rx clock. Add an optional > rx_clk so that the clock can be enabled. > > Signed-off-by: Shubhrajyoti Datta Applied to net-next.

Re: [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2016-08-18

2016-08-18 Thread David Miller
From: Jeff Kirsher Date: Thu, 18 Aug 2016 14:57:21 -0700 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff.

RE: [PATCH v6 3/3] net: phy: Add gmiitorgmii converter support

2016-08-18 Thread Appana Durga Kedareswara Rao
Hi Andrew, Thanks for the review... > > > +static int xgmiitorgmii_read_status(struct phy_device *phydev) { > > + struct gmii2rgmii *priv = phydev->priv; > > + u16 val = 0; > > + > > + priv->phy_drv->read_status(phydev); > > This can return an error, in which case phydev->speed sh

[PATCH] netfilter: fix spelling mistake: "delimitter" -> "delimiter"

2016-08-18 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in pr_debug message Signed-off-by: Colin Ian King --- net/netfilter/nf_conntrack_ftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_conntrack_ftp.c b/net/netfilter/nf_conntrack_ftp.c index 4314700..b69

Re: [PATCH iproute2 1/1] tc classifiers: Modernize tcindex classifier

2016-08-18 Thread Stephen Hemminger
On Wed, 17 Aug 2016 07:16:53 -0400 Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > Signed-off-by: Jamal Hadi Salim > --- The is ok for the parsing of config, but you are still using print_police for display.

[net-next 03/15] i40e/i40evf: Reset VLAN filter count when resetting

2016-08-18 Thread Jeff Kirsher
From: Catherine Sullivan When we do a reset, all the VLAN filters get added again. Therefore we also want to reset the VLAN count to 0 or we quickly run out of filters. Change-ID: I459f26851e22204dc8b828ad87cde8170119 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by

Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

2016-08-18 Thread Arend van Spriel
On 18-08-16 21:29, Javier Martinez Canillas wrote: > Hello Arend, > > Thanks a lot for your feedback. > > On 08/18/2016 03:14 PM, Arend van Spriel wrote: >> On 18-08-16 16:17, Javier Martinez Canillas wrote: >>> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message >>> is pri

Re: [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS

2016-08-18 Thread Stephen Hemminger
On Wed, 17 Aug 2016 14:39:21 -0700 Eric Dumazet wrote: > From: Eric Dumazet > > kernel support for these attributes was added in linux-4.6 > > Signed-off-by: Eric Dumazet What about setting them?

[PATCH net] net: ipv4: fix sparse error in fib_good_nh()

2016-08-18 Thread Eric Dumazet
From: Eric Dumazet Fixes following sparse errors : net/ipv4/fib_semantics.c:1579:61: warning: incorrect type in argument 2 (different base types) net/ipv4/fib_semantics.c:1579:61:expected unsigned int [unsigned] [usertype] key net/ipv4/fib_semantics.c:1579:61:got restricted __be32 const

Re: [PATCH net-next] dsa: mv88e6xxx: Timeout based on iterations

2016-08-18 Thread Andrew Lunn
> > static int mv88e6xxx_wait(struct mv88e6xxx_chip *chip, int addr, int reg, > > u16 mask) > > { > > - unsigned long timeout = jiffies + HZ / 10; > > + int i; > > > > - while (time_before(jiffies, timeout)) { > > + for (i = 0; i < 16; i++) { > > u16 va

[PATCH net-next 5/5] net: dsa: bcm_sf2: Remove probing through old DSA binding

2016-08-18 Thread Florian Fainelli
Remove our dsa_switch_driver::drv_probe callback to prevent probing through the old DSA binding, not that this could happen anymore now that we have moved the matching compatible string from net/dsa/dsa.c to drivers/net/dsa/bcm_sf2.c, so this is essentially dead code. Signed-off-by: Florian Fainel

[net-next 15/15] i40e: Expose 'trust' flag to userspace via ndo_get_vf_config.

2016-08-18 Thread Jeff Kirsher
From: Sridhar Samudrala This enables ip -d l to indicate if trust is on or off for VFs. Signed-off-by: Sridhar Samudrala Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dri

[net-next 11/15] i40e: fix memory leak

2016-08-18 Thread Jeff Kirsher
From: Mitch Williams When we allocate memory, we must free it. It's simple courtesy. Change-ID: Id007294096fb53344f1a8b9a0f78eddf9853c5d6 Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 1 + 1 file ch

[net-next 10/15] i40e: fix lookup table when RSS disabled/enabled

2016-08-18 Thread Jeff Kirsher
From: Alan Brady This patch fixes the bug which causes RSS to continue to work after being disabled. After disabling RSS, traffic would continue to be assigned to different queues instead of falling back to a single queue. Without this patch, attempting to disable RSS would not work as expected.

Re: [PATCH net] net: ipv4: fix sparse error in fib_good_nh()

2016-08-18 Thread David Ahern
On 8/18/16 11:19 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Fixes following sparse errors : > > net/ipv4/fib_semantics.c:1579:61: warning: incorrect type in argument 2 > (different base types) > net/ipv4/fib_semantics.c:1579:61:expected unsigned int [unsigned] > [usertype] key > net/ip

Re: [PATCH net-next 1/2] net: phy: Sort Makefile and Kconfig

2016-08-18 Thread Florian Fainelli
On 08/18/2016 02:56 PM, Andrew Lunn wrote: > Sort the files to reduce merge conflicts and to make it easier to find > drivers by name. Also separate the MDIO bus drivers from the PHY > drivers, again to help find what you need. > > Signed-off-by: Andrew Lunn > --- > drivers/net/phy/Kconfig | 42

[net-next 08/15] i40e: Force register writes to mitigate sync issues with iwarp VF driver

2016-08-18 Thread Jeff Kirsher
From: Avinash Dayanand This patch is a fix for the bug i.e. unable to create iwarp device in VF. This is a sync issue and the iwarp device open is called even before the PCI register writes are done. Forcing the PCI register writes to happen just before it exits the function. Change-ID: I60c6a2

Re: [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS

2016-08-18 Thread Eric Dumazet
On Thu, 2016-08-18 at 14:52 -0700, Stephen Hemminger wrote: > On Wed, 17 Aug 2016 14:39:21 -0700 > Eric Dumazet wrote: > > > From: Eric Dumazet > > > > kernel support for these attributes was added in linux-4.6 > > > > Signed-off-by: Eric Dumazet > > > What about setting them? This is not

[RFC PATCH] net: diag: support SOCK_DESTROY for UDP sockets

2016-08-18 Thread David Ahern
This implements SOCK_DESTROY for UDP sockets similar to what was done for TCP with commit c1e64e298b8ca ("net: diag: Support destroying TCP sockets.") A process with a UDP socket targeted for destroy is awakened and recvmsg fails with ECONNABORTED giving the process notice that it should close the

[PATCH net] sit: ipip6_valid_ip_proto() is static

2016-08-18 Thread Eric Dumazet
From: Eric Dumazet Fixes this sparse error : net/ipv6/sit.c:1129:6: warning: symbol 'ipip6_valid_ip_proto' was not declared. Should it be static? Fixes: 49dbe7ae2168b ("sit: support MPLS over IPv4") Signed-off-by: Eric Dumazet --- net/ipv6/sit.c |2 +- 1 file changed, 1 insertion(+), 1 de

[net-next 06/15] i40e: Fix static analysis tool warning

2016-08-18 Thread Jeff Kirsher
From: Dave Ertman This patch fixes a problem where a static analysis tool generates a warning for "INVARIANT_CONDITION: Expression 'enabled_tc' used in the condition always yields the same result." Without this patch, the driver will not pass the static analysis tool checks without generating wa

Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

2016-08-18 Thread Javier Martinez Canillas
Hello Arend, On 08/18/2016 03:49 PM, Arend van Spriel wrote: > > > On 18-08-16 21:29, Javier Martinez Canillas wrote: >> Hello Arend, >> >> Thanks a lot for your feedback. >> >> On 08/18/2016 03:14 PM, Arend van Spriel wrote: >>> On 18-08-16 16:17, Javier Martinez Canillas wrote: If request

Re: [RFC 1/3] tcp: randomize tcp timestamp offsets for each connection

2016-08-18 Thread Florian Westphal
Eric Dumazet wrote: > On Thu, 2016-08-18 at 14:48 +0200, Florian Westphal wrote: > > commit ceaa1fef65a7c2e ("tcp: adding a per-socket timestamp offset") > > added the main infrastructure that is needed for per-connection > > randomization, in particular writing/reading the on-wire tcp header > >

[PATCH net] udp: include addrconf.h

2016-08-18 Thread Eric Dumazet
From: Eric Dumazet Include ipv4_rcv_saddr_equal() definition to avoid this sparse error : net/ipv4/udp.c:362:5: warning: symbol 'ipv4_rcv_saddr_equal' was not declared. Should it be static? Signed-off-by: Eric Dumazet --- net/ipv4/udp.c |1 + 1 file changed, 1 insertion(+) diff --git a/n

Re: [PATCH net-next 2/2] net: phy: Kconfig: Remove redundant "Support for"

2016-08-18 Thread Florian Fainelli
On 08/18/2016 02:56 PM, Andrew Lunn wrote: > Remove the redundant "Support for" and "Drivers for" from the Kconfig > short description. This makes the manufacture much more prominent in > the list and makes the shortcut keys useful. > > Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli --

Re: [PATCH iproute2] ip route: restore_handler should check tb[RTA_PREFSRC] for local networks

2016-08-18 Thread Stephen Hemminger
On Sun, 7 Aug 2016 17:12:30 +0800 Xin Long wrote: > Prior to this patch, If one route entry's RTA_PREFSRC and RTA_GATEWAY > both were NULL, it was supposed to be restored ONLY as a local address. > > But as it didn't check tb[RTA_PREFSRC] when restoring local networks, > rtattr_cmp would return

Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

2016-08-18 Thread Arend van Spriel
On 18-08-16 16:17, Javier Martinez Canillas wrote: > If request_irq() fails in mwifiex_sdio_probe_of(), only an error message > is printed but the actual error is not propagated to the caller function. Hmm. The caller function, ie. mwifiex_sdio_probe(), does not seem to care. The device may still

Re: [PATCH net] sctp: fix a success return may hide an error

2016-08-18 Thread 'Marcelo Ricardo Leitner'
On Wed, Aug 17, 2016 at 09:01:38AM +, David Laight wrote: > From: Marcelo Ricardo Leitner > > Sent: 16 August 2016 18:25 > ... > > > That doesn't seem a good idea. > > > You don't want to abort the association if there is a transient > > > memory allocation failure. > > > You also can't drop da

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-08-18 Thread David Ahern
On 8/18/16 8:37 AM, Alexander Duyck wrote: > Thought I would go through and do a second pass since it sounds like > the inner_mac_header idea isn't going to fly. If we can't push this > as an L2 encapsulation there are few tweaks we probably need in order > to make this work as an L3. I have incl

Re: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

2016-08-18 Thread John W. Linville
Ping? On Tue, Aug 02, 2016 at 03:49:57PM -0400, John W. Linville wrote: > Are these revised patches still on their way? > > John > > On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati wrote: > > Yuval, > > I will try to resubmit the patches this week with updated comments > > >

Re: [PATCH 0/2] wireless: Use complete() instead complete_all()

2016-08-18 Thread Luis R. Rodriguez
On Thu, Aug 18, 2016 at 03:12:04PM +0200, Daniel Wagner wrote: > This series ignores all complete_all() usages in the firmware loading > path. They will be hopefully address by Luis' sysdata patches [0]. > That leaves a couple of complete_all() calls. I had not considered this as a gain, but glad

[PATCH net-next 1/3] dsa: mv88e6xxx: Timeout based on iterations, not time

2016-08-18 Thread Andrew Lunn
The mv88e6xxx driver times out operations on the switch based on looping until an elapsed wall clock time is reached. However, if usleep_range() sleeps much longer than expected, it could timeout with an error without actually checking to see if the devices has completed the operation. So replace t

[PATCH net-next 0/2] PHY Kconfig and Makefile cleanup

2016-08-18 Thread Andrew Lunn
The Ethernet PHY directory has slowly been getting more entries. Split the entries in the Makefile and Kconfig into MDIO bus drivers and PHYs. Within these two groups, sort them. This should reduce merge conflicts and aid finding what one searches for. The Kconfig text contains redundant "Driver f

[PATCH net-next 0/3] Fix mv88e6xxx wait function

2016-08-18 Thread Andrew Lunn
The mv88e6xxx wait function can be upset of the system has nots of other things to do and a sleep takes a lot longer than expected. Fix this be using a fixed number of iterations, rather than a fixed walkclock time. Witht that change made, it is possible to consoliate another wait function. A wai

[PATCH net-next 3/3] dsa: mv88e6xxx: Make mv88e6xxx_wait() timeout verbose

2016-08-18 Thread Andrew Lunn
When mv88e6xxx_wait() returns a timeout, something bad has happened. Make sure it is noticed by logging an error. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.

Re: [RFC PATCH 3/5] bpf: add BPF_PROG_ATTACH and BPF_PROG_DETACH commands

2016-08-18 Thread Daniel Mack
On 08/17/2016 08:10 PM, Alexei Starovoitov wrote: > On Wed, Aug 17, 2016 at 09:16:02AM -0700, Eric Dumazet wrote: >> On Wed, 2016-08-17 at 16:00 +0200, Daniel Mack wrote: >> >>> + progp = is_ingress ? &cgrp->bpf_ingress : &cgrp->bpf_egress; >>> + >>> + rcu_read_lock(); >>> +

Your Urgent Response

2016-08-18 Thread Mr Hassan Umra
Dear Friend, I am Mr Hassan Umra, the director in charge of auditing and accounting section of Bank of Africa (BOA) West-Africa. I would like you to indicate your interest to receive the transfer of $12.5 Million Dollars. I will like you to stand as the next of kin to our late customer whose ac

Re: [PATCH v1 1/1] l2tp: Use existing macros instead of literal number

2016-08-18 Thread Guillaume Nault
On Thu, Aug 18, 2016 at 03:05:19PM +0800, f...@ikuai8.com wrote: > From: Gao Feng > > 1. Use PPP_ALLSTATIONS/PPP_UI instead of literal 0xff/0x03; > 2. Use one static const global fixed_ppphdr instead of two same > static variable ppph in two different functions; > 3. Use SEND_SHUTDOWN instead of

[PATCH net-next 2/2] net: phy: Kconfig: Remove redundant "Support for"

2016-08-18 Thread Andrew Lunn
Remove the redundant "Support for" and "Drivers for" from the Kconfig short description. This makes the manufacture much more prominent in the list and makes the shortcut keys useful. Signed-off-by: Andrew Lunn --- drivers/net/phy/Kconfig | 70 - 1

[PATCH net-next 1/2] net: phy: Sort Makefile and Kconfig

2016-08-18 Thread Andrew Lunn
Sort the files to reduce merge conflicts and to make it easier to find drivers by name. Also separate the MDIO bus drivers from the PHY drivers, again to help find what you need. Signed-off-by: Andrew Lunn --- drivers/net/phy/Kconfig | 427 --- driver

[PATCH net-next 2/3] dsa: mv88e6xxx: Use mv88e6xx_wait in mv88e6xxx_update()

2016-08-18 Thread Andrew Lunn
Now that mv88e6xx_wait() iterated on a counter than a fixed time interval, it implements the same mechanism as mv88e6xxx_update() uses. So use it in mv88e6xx_wait(). Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 16 1 file changed, 4 insertions(+), 12 deletio

Re: [PATCH 0/6] Netfilter fixes for net

2016-08-18 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 18 Aug 2016 19:29:02 +0200 > The following patchset contains Netfilter updates for your net tree, > they are: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks a lot Pablo.

[net-next 13/15] i40e/i40evf-Bump version from 1.6.11 to 1.6.12

2016-08-18 Thread Jeff Kirsher
From: Bimmy Pujari Signed-off-by: Bimmy Pujari Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/et

[net-next 09/15] i40e: Don't notify client of VF reset during VF creation

2016-08-18 Thread Jeff Kirsher
From: Avinash Dayanand VF goes through reset path during VF creation which happens to also have notification of VF reset to client. Adding conditional check to avoid wrongly notifying VF reset during VF creation. Also changing the call order of VF enable, calling it after VF creation rather than

Re: [PATCH 2/2] net: sched: avoid duplicates in qdisc dump

2016-08-18 Thread Cong Wang
On Tue, Aug 16, 2016 at 2:53 PM, Jiri Kosina wrote: > From: Jiri Kosina > > tc_dump_qdisc() performs dumping of the per-device qdiscs in two phases; > first, the "standard" dev->qdisc is being dumped. Second, if there is/are > ingress queue(s), they are being dumped as well. > > After conversion

[PATCH net 02/10] net/mlx5e: Optimization for MTU change

2016-08-18 Thread Saeed Mahameed
From: Tariq Toukan Avoid unnecessary interface down/up operations upon an MTU change when it does not affect the rings configuration. Fixes: 461017cb006a ("net/mlx5e: Support RX multi-packet WQE (Striding RQ)") Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet

[PATCH net 07/10] net/mlx5e: Retrieve the switchdev id from the firmware only once

2016-08-18 Thread Saeed Mahameed
From: Hadar Hen Zion Avoid firmware command execution each time the switchdev HW ID attr get call is made. We do that by reading the ID (PF NIC MAC) only once at load time and store it on the representor structure. Signed-off-by: Hadar Hen Zion Signed-off-by: Saeed Mahameed --- drivers/net/et

[PATCH net 10/10] net/mlx5: E-Switch, Avoid ACLs in the offloads mode

2016-08-18 Thread Saeed Mahameed
From: Or Gerlitz When we are in the switchdev/offloads mode, HW matching is done as dictated by the offloaded rules and hence we don't need to enable the ACLs mechanism used by the legacy mode. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

2016-08-18 Thread Timur Tabi
Florian Fainelli wrote: There is a helper function to obtain the platform device associated with a device_node: of_find_device_by_node. Thank you, this is exactly what I needed. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, In

  1   2   >