Re: GSO packets on lower MTU retaining gso_size?

2016-06-06 Thread Du, Fan
On 2016/6/7 14:05, Yuval Mintz wrote: While experimenting with Vxlan tunnels, I've reached a topology where the Vxlan interface's MTU was 1500 while base-interface was smaller [600]. While 'regular' packets broke via ip-fragmentation, GSO SKBs passing from the vxlan interface to the base inter

Re: [PATCH net-next 2/2] tcp: add NV congestion control

2016-06-06 Thread David Miller
From: Lawrence Brakmo Date: Tue, 7 Jun 2016 01:04:06 + > The reason why this may be necessary, is that under some conditions > NV flows competing with more aggressive flows will perform > poorly. People may be more willing to test NV if there is a quick > and simple way to revert if necessary

[PATCH] brcmfmac: include required headers in cfg80211.h

2016-06-06 Thread Rafał Miłecki
Without this including cfg80211.h in a wrong order could result in: drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h:122:24: error: array type has incomplete element type struct brcmf_wsec_key key[BRCMF_MAX_DEFAULT_KEYS]; ^ drivers/net/wireless/broadcom/brcm80

GSO packets on lower MTU retaining gso_size?

2016-06-06 Thread Yuval Mintz
While experimenting with Vxlan tunnels, I've reached a topology where the Vxlan interface's MTU was 1500 while base-interface was smaller [600]. While 'regular' packets broke via ip-fragmentation, GSO SKBs passing from the vxlan interface to the base interface remained whole, and their `gso_size'

[PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

2016-06-06 Thread vidya
From: Vidya Sagar Ravipati This patch provides macro definitions for maximum possible memory map size of QSFP+/QSFP28 EEPROMs as per SFF-8436/SFF-8636 According to SFF-8436/SFF-8636 specs, the common memory map for managing external cable interfaces is arranged into a single lower page address s

[PATCH net-next v2 1/4] bpf: fix missing header inclusion

2016-06-06 Thread Zi Shen Lim
Commit 0fc174dea545 ("ebpf: make internal bpf API independent of CONFIG_BPF_SYSCALL ifdefs") introduced usage of ERR_PTR() in bpf_prog_get(), however did not include linux/err.h. Without this patch, when compiling arm64 BPF without CONFIG_BPF_SYSCALL: ... In file included from arch/arm64/net/bpf_j

[PATCH net-next v2 4/4] arm64: bpf: optimize LD_ABS, LD_IND

2016-06-06 Thread Zi Shen Lim
Remove superfluous stack frame, saving us 3 instructions for every LD_ABS or LD_IND. Signed-off-by: Zi Shen Lim --- arch/arm64/net/bpf_jit_comp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c index 7ae304e..b2fc97a 100644 ---

[PATCH net-next v2 3/4] arm64: bpf: optimize JMP_CALL

2016-06-06 Thread Zi Shen Lim
Remove superfluous stack frame, saving us 3 instructions for every JMP_CALL. Signed-off-by: Zi Shen Lim --- arch/arm64/net/bpf_jit_comp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c index 51abc97..7ae304e 100644 --- a/arch/a

[PATCH net-next v2 0/4] arm64 BPF JIT updates

2016-06-06 Thread Zi Shen Lim
Updates for arm64 eBPF JIT. The main addition here is implementation of bpf_tail_call. #1: Fix missing header inclusion in linux/bpf.h. #2: Add bpf_tail_call for arm64. #3,4: Optimizations to reduce instruction count for jitted code. Changes since v1: - Added patch #1 to address build error due

Re: [PATCH net-next 2/3] arm64: bpf: optimize JMP_CALL

2016-06-06 Thread Z Lim
Hi Will, On Mon, Jun 6, 2016 at 10:05 AM, Will Deacon wrote: > On Sat, Jun 04, 2016 at 03:00:29PM -0700, Zi Shen Lim wrote: >> Remove superfluous stack frame, saving us 3 instructions for >> every JMP_CALL. >> >> Signed-off-by: Zi Shen Lim >> --- >> arch/arm64/net/bpf_jit_comp.c | 3 --- >> 1 f

[PATCH net-next v2 0/3] net: vrf: Add support for local traffic to local addresses

2016-06-06 Thread David Ahern
Add support for locally originated traffic to VRF-local addresses, be it addresses on enslaved devices or addresses on the VRF device: $ ip addr show dev red 33: red: mtu 65536 qdisc pfifo_fast state UP group default qlen 1000 link/ether be:00:53:b5:e4:25 brd ff:ff:ff:ff:ff:ff inet 1.1.1

[PATCH net-next 2/3] net: vrf: ipv4 support for local traffic to local addresses

2016-06-06 Thread David Ahern
Add support for locally originated traffic to VRF-local addresses. If destination device for an skb is the loopback or VRF device then set its dst to a local version of the VRF cached dst_entry and call netif_rx to insert the packet onto the rx queue - similar to what is done for loopback. This pat

[PATCH net-next 1/3] net: vrf: Minor refactoring for local address patches

2016-06-06 Thread David Ahern
Move the stripping of the ethernet header from is_ip_tx_frame into the ipv4 and ipv6 outbound functions and collapse vrf_send_v4_prep into vrf_process_v4_outbound. Signed-off-by: David Ahern --- drivers/net/vrf.c | 45 ++--- 1 file changed, 18 insertions(+

[PATCH net-next v2 3/3] net: vrf: ipv6 support for local traffic to local addresses

2016-06-06 Thread David Ahern
Add support for locally originated traffic to VRF-local IPv6 addresses. Similar to IPv4 a local dst is set on the skb and the packet is reinserted with a call to netif_rx. With this patch, ping, tcp and udp packets to a local IPv6 address are successfully routed: $ ip addr show dev eth1 4:

[PATCH net-next v4 2/2] net: vrf: Add l3mdev rules on first device create

2016-06-06 Thread David Ahern
Add l3mdev rule per address family when the first VRF device is created. The rules are installed with a default preference of 1000. Users can replace the default rule as desired. Signed-off-by: David Ahern --- v4 - removed module parameter for pref - changed num_vrfs to add_fib_rules and only add

[PATCH net-next v4 0/2] net: vrf: Improve use of FIB rules

2016-06-06 Thread David Ahern
Currently, VRFs require 1 oif and 1 iif rule per address family per VRF. As the number of VRF devices increases it brings scalability issues with the increasing rule list. All of the VRF rules have the same format with the exception of the specific table id to direct the lookup. Since the table id

[PATCH net-next v4 1/2] net: Add l3mdev rule

2016-06-06 Thread David Ahern
Currently, VRFs require 1 oif and 1 iif rule per address family per VRF. As the number of VRF devices increases it brings scalability issues with the increasing rule list. All of the VRF rules have the same format with the exception of the specific table id to direct the lookup. Since the table id

Re: [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-06 Thread Simon Horman
On Thu, Jun 02, 2016 at 03:01:47PM -0700, pravin shelar wrote: > On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman > wrote: > > * Set skb protocol based on contents of packet. I have observed this is > > necessary to get actual protocol of a packet when it is injected into an > > internal device e

[PATCH v3 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

2016-06-06 Thread thloh
From: Tien Hock Loh This adds support for TSE PCS that uses SGMII adapter when the phy-mode of the dwmac is set to sgmii Signed-off-by: Tien Hock Loh --- v2: - Refactored the TSE PCS out from the dwmac-socfpga.c file - Added binding documentation for TSE PCS sgmii adapter v3: - Added missing l

Re: [PATCH net-next v10 3/5] openvswitch: add support to push and pop mpls for layer3 packets

2016-06-06 Thread Simon Horman
On Thu, Jun 02, 2016 at 03:02:00PM -0700, pravin shelar wrote: > On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman > wrote: > > Allow push and pop mpls actions to act on layer 3 packets by teaching > > them not to access non-existent L2 headers of such packets. > > > > Signed-off-by: Simon Horman > >

Re: [PATCH net-next v10 4/5] openvswitch: add layer 3 flow/port support

2016-06-06 Thread Simon Horman
On Thu, Jun 02, 2016 at 03:02:18PM -0700, pravin shelar wrote: > On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman > wrote: [...] > > diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c > > index 15f130e4c22b..5567529904fa 100644 > > --- a/net/openvswitch/actions.c > > +++ b/net/openv

Re: [PATCH net-next 1/3] arm64: bpf: implement bpf_tail_call() helper

2016-06-06 Thread Zi Shen Lim
On Mon, Jun 6, 2016 at 1:11 AM, Daniel Borkmann wrote: > On 06/06/2016 06:56 AM, Z Lim wrote: > [...] >> >> How about the attached patch? Fixes compilation error on build >> !CONFIG_BPF_SYSCALL. >> >> Also, should this patch be sent to net or net-next (along with this >> series)? > > > Looks good,

RE: [PATCH][V2] net: fec: fix spelling mistakes and add missing newline

2016-06-06 Thread Fugang Duan
From: Colin King Sent: Monday, June 06, 2016 4:22 PM > To: Fugang Duan ; netdev@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > Subject: [PATCH][V2] net: fec: fix spelling mistakes and add missing newline > > From: Colin Ian King > > trivial fix to spelling mistakes and add missing newline

RE: [PATCH v2 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround

2016-06-06 Thread Fugang Duan
From: Holger Schurig Sent: Monday, June 06, 2016 7:04 PM > To: Fugang Duan ; Lucas Stach > ; Shawn Guo > Cc: devicet...@vger.kernel.org; netdev@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; ker...@pengutronix.de; patchwork- > l...@pengutronix.de > Subject: RE: [PATCH v2 1/2] ARM: imx

Re: [PATCH] net: ethernet: cavium: liquidio: response_manager: Remove create_workqueue

2016-06-06 Thread David Miller
From: Bhaktipriya Shridhar Date: Sat, 4 Jun 2016 20:21:40 +0530 > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitem viz > (&cwq->wk.work which maps to oct_poll_req_completion) is involved > in normal device operation. WQ_MEM_RECLAI

Re: [PATCH] net: ethernet: cavium: liquidio: request_manager: Remove create_workqueue

2016-06-06 Thread David Miller
From: Bhaktipriya Shridhar Date: Sat, 4 Jun 2016 20:54:00 +0530 > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitem viz > (&db_wq->wk.work which maps to check_db_timeout) is involved > in normal device operation. WQ_MEM_RECLAIM has

Re: [Patch net] net_sched: keep backlog updated with qlen

2016-06-06 Thread David Miller
From: Cong Wang Date: Fri, 3 Jun 2016 15:05:57 -0700 > For gso_skb we only update qlen, backlog should be updated too. > > Note, it is correct to just update these stats at one layer, > because the gso_skb is cached there. > > Reported-by: Stas Nichiporovich > Fixes: 2f5fb43f ("net_sched:

Re: [PATCH v3] virtio-net: Add initial MTU advice feature

2016-06-06 Thread David Miller
From: Aaron Conole Date: Fri, 3 Jun 2016 16:57:12 -0400 > This commit adds the feature bit and associated mtu device entry for the > virtio network device. When a virtio device comes up, it checks the > feature bit for the VIRTIO_NET_F_MTU feature. If such feature bit is > enabled, the driver

Re: [PATCH net-next 2/2] tcp: add NV congestion control

2016-06-06 Thread Lawrence Brakmo
On 6/6/16, 4:01 PM, "David Miller" wrote: >From: Lawrence Brakmo >Date: Fri, 3 Jun 2016 13:37:58 -0700 > >> +module_param(nv_enable, int, 0644); >> +MODULE_PARM_DESC(nv_enable, "enable NV (congestion avoidance) >>behavior"); >> +module_param(nv_pad, int, 0644); >> +MODULE_PARM_DESC(nv_pad, "extr

Re: [ovs-dev] [PATCH net-next] NSH(Network Service Header) implementation

2016-06-06 Thread pravin shelar
On Mon, Jun 6, 2016 at 2:34 AM, Yi Yang wrote: > IETF defined NSH(Network Service Header) for Service > Function Chaining, this is an IETF draft > > https://tools.ietf.org/html/draft-ietf-sfc-nsh-05 > > It will be a IETF standard shortly, this patch implemented > NSH for Open vSwitch. > > Signed-o

Re: [PATCH net-next v2 5/5] net: dsa: bcm_sf2: Register our slave MDIO bus

2016-06-06 Thread Andrew Lunn
On Mon, Jun 06, 2016 at 04:14:55PM -0700, Florian Fainelli wrote: > Register a slave MDIO bus which allows us to divert problematic > read/writes towards conflicting pseudo-PHY address (30). Do no longer > rely on DSA's slave_mii_bus, but instead provide our own implementation > which offers more f

Re: [PATCH net-next v2 4/5] net: dsa: Initialize CPU port ethtool ops per tree

2016-06-06 Thread Andrew Lunn
On Mon, Jun 06, 2016 at 04:14:54PM -0700, Florian Fainelli wrote: > Now that we can properly support multiple distinct trees in the system, > using a global variable: dsa_cpu_port_ethtool_ops is getting clobbered > as soon as the second switch tree gets probed, and we don't want that. > > We need

Re: [PATCH net-next v2 2/5] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask

2016-06-06 Thread Andrew Lunn
> @@ -304,6 +312,18 @@ static int dsa_ds_apply(struct dsa_switch_tree *dst, > struct dsa_switch *ds) > if (err < 0) > return err; > > + if (!ds->slave_mii_bus && ds->drv->phy_read) { > + ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev); > + if (!ds-

Re: [PATCH net-next 2/2] net: sched: do not acquire qdisc spinlock in qdisc/class stats dump

2016-06-06 Thread Eric Dumazet
On Mon, 2016-06-06 at 16:15 -0700, Cong Wang wrote: > On Mon, Jun 6, 2016 at 9:37 AM, Eric Dumazet wrote: > > void > > -__gnet_stats_copy_basic(struct gnet_stats_basic_packed *bstats, > > +__gnet_stats_copy_basic(const seqcount_t *running, > > + struct gnet_stats_basic_packe

Re: [PATCH net-next v3 0/2] net: vrf: Improve use of FIB rules

2016-06-06 Thread David Ahern
On 6/6/16 4:47 PM, David Miller wrote: I hate module parameters. And you don't even need one in this situation, just use a default preference of 1000 and add a newlink netlink attribute that can change it. The intent is to generate default rules similar to what is done for local and main tab

Re: [PATCH][RT] netpoll: Always take poll_lock when doing polling

2016-06-06 Thread Alison Chaiken
Steven Rostedt suggests in reference to "[PATCH][RT] netpoll: Always take poll_lock when doing polling" >> >> [ Alison, can you try this patch ] >> Sebastian follows up: >> >Alison, did you try it? I wrote: >> I did try that patch, but it hasn't made much difference. Let me >> back up and resta

Re: [PATCH net-next 2/2] net: sched: do not acquire qdisc spinlock in qdisc/class stats dump

2016-06-06 Thread Cong Wang
On Mon, Jun 6, 2016 at 9:37 AM, Eric Dumazet wrote: > void > -__gnet_stats_copy_basic(struct gnet_stats_basic_packed *bstats, > +__gnet_stats_copy_basic(const seqcount_t *running, > + struct gnet_stats_basic_packed *bstats, > struct gnet_stats_basic_c

[PATCH net-next v2 0/5] net: dsa: misc improvements

2016-06-06 Thread Florian Fainelli
Hi all, This patch series builds on top of Andrew's "New DSA bind, switches as devices" patch set and does the following: - add a few helper functions/goodies for net/dsa/dsa2.c to be as close as possible from net/dsa/dsa.c in terms of what drivers can expect, in particular the slave MDIO b

[PATCH net-next v2 1/5] net: dsa: Provide unique DSA slave MII bus names

2016-06-06 Thread Florian Fainelli
In case we have multiples trees and switches with the same index, we need to add another discriminating id: the switch tree. Reviewed-by: Andrew Lunn Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

[PATCH net-next v2 4/5] net: dsa: Initialize CPU port ethtool ops per tree

2016-06-06 Thread Florian Fainelli
Now that we can properly support multiple distinct trees in the system, using a global variable: dsa_cpu_port_ethtool_ops is getting clobbered as soon as the second switch tree gets probed, and we don't want that. We need to move this to be dynamically allocated, and since we can't really be compa

[PATCH net-next v2 3/5] net: dsa: Add initialization helper for CPU port ethtool_ops

2016-06-06 Thread Florian Fainelli
Add a helper function: dsa_cpu_port_ethtool_init() which initializes a custom ethtool_ops structure with custom DSA ethtool operations for CPU ports. This is a preliminary change to move the initialization outside of net/dsa/slave.c. Signed-off-by: Florian Fainelli --- net/dsa/dsa_priv.h | 1 +

[PATCH net-next v2 5/5] net: dsa: bcm_sf2: Register our slave MDIO bus

2016-06-06 Thread Florian Fainelli
Register a slave MDIO bus which allows us to divert problematic read/writes towards conflicting pseudo-PHY address (30). Do no longer rely on DSA's slave_mii_bus, but instead provide our own implementation which offers more flexibility as to what to do, and when to register it. We need to register

[PATCH net-next v2 2/5] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask

2016-06-06 Thread Florian Fainelli
Some drivers rely on these two bitmasks to contain the correct values for them to successfully probe and initialize at drv->setup() time, calculate correct values to put in both masks as early as possible in dsa_get_ports_dn(). Signed-off-by: Florian Fainelli --- net/dsa/dsa2.c | 27

[PATCH net-next] gue: Implement direction IP encapsulation

2016-06-06 Thread Tom Herbert
This patch implements direct encapsulation of IPv4 and IPv6 packets in UDP. This is done a version "1" of GUE and as explained in I-D draft-ietf-nvo3-gue-03. Changes here are only in the receive path, fou with IPxIPx already supports the transmit side. Both the normal receive path and GRO path are

Re: [PATCH net-next 0/3] net: vrf: Add support for local traffic to local addresses

2016-06-06 Thread David Ahern
On 6/6/16 4:56 PM, David Miller wrote: From: David Miller Date: Mon, 06 Jun 2016 15:12:28 -0700 (PDT) From: David Ahern Date: Thu, 2 Jun 2016 13:15:09 -0700 Add support for locally originated traffic to VRF-local addresses, be it addresses on enslaved devices or addresses on the VRF device

Re: [PATCH net-next 2/2] tcp: add NV congestion control

2016-06-06 Thread David Miller
From: Lawrence Brakmo Date: Fri, 3 Jun 2016 13:37:58 -0700 > +module_param(nv_enable, int, 0644); > +MODULE_PARM_DESC(nv_enable, "enable NV (congestion avoidance) behavior"); > +module_param(nv_pad, int, 0644); > +MODULE_PARM_DESC(nv_pad, "extra packets above congestion level"); > +module_param(n

Re: [PATCH net-next 0/3] net: vrf: Add support for local traffic to local addresses

2016-06-06 Thread David Miller
From: David Miller Date: Mon, 06 Jun 2016 15:12:28 -0700 (PDT) > From: David Ahern > Date: Thu, 2 Jun 2016 13:15:09 -0700 > >> Add support for locally originated traffic to VRF-local addresses, >> be it addresses on enslaved devices or addresses on the VRF device: > ... > > Series applied, b

Re: [PATCH -next] cbq: remove only caller of qdisc->drop()

2016-06-06 Thread Florian Westphal
Eric Dumazet wrote: > > static void cbq_ovl_drop(struct cbq_class *cl) > > { > > - if (cl->q->ops->drop) > > - if (cl->q->ops->drop(cl->q)) > > - cl->qdisc->q.qlen--; > > + struct sk_buff *skb = cl->q->ops->dequeue(cl->q); > > + > > + if (skb) { > > +

Re: [PATCH net-next v3 0/2] net: vrf: Improve use of FIB rules

2016-06-06 Thread David Miller
From: David Ahern Date: Fri, 3 Jun 2016 12:36:54 -0700 > Currently, VRFs require 1 oif and 1 iif rule per address family per > VRF. As the number of VRF devices increases it brings scalability > issues with the increasing rule list. All of the VRF rules have the > same format with the exception

[PATCH 2/2] ipvs: update real-server binding of outgoing connections in SIP-pe

2016-06-06 Thread Pablo Neira Ayuso
From: Marco Angaroni Previous patch that introduced handling of outgoing packets in SIP persistent-engine did not call ip_vs_check_template() in case packet was matching a connection template. Assumption was that real-server was healthy, since it was sending a packet just in that moment. There a

[PATCH 1/2] netfilter: x_tables: don't reject valid target size on some architectures

2016-06-06 Thread Pablo Neira Ayuso
From: Florian Westphal Quoting John Stultz: In updating a 32bit arm device from 4.6 to Linus' current HEAD, I noticed I was having some trouble with networking, and realized that /proc/net/ip_tables_names was suddenly empty. Digging through the registration process, it seems we're catchin

[PATCH 0/2] Netfilter/IPVS fixes for net

2016-06-06 Thread Pablo Neira Ayuso
Hi David, The following patchset contains two Netfilter/IPVS fixes for your net tree, they are: 1) Fix missing alignment in next offset calculation for standard targets, introduced in the previous merge window, patch from Florian Westphal. 2) Fix to correct the handling of outgoing connect

Re: [PATCH net-next] cxgb4: Reduce resource allocation in kdump kernel

2016-06-06 Thread David Miller
From: Yuval Mintz Date: Sat, 4 Jun 2016 13:24:43 + >> When is_kdump_kernel() is true, reduce our memory footprint by only using a >> single "Queue Set" and Forcing Master so we can reinitialize the >> Firmware/Chip. >> >> Signed-off-by: Hariprasad Shenai > ... >> if (q10g > netif_g

Re: [PATCH] netfilter/nflog: nflog-range does not truncate packets

2016-06-06 Thread Pablo Neira Ayuso
On Wed, Jun 01, 2016 at 08:23:54PM -0400, Vishwanath Pai wrote: > netfilter/nflog: nflog-range does not truncate packets > > The --nflog-range parameter from userspace is ignored in the kernel and > the entire packet is sent to the userspace. The per-instance parameter > copy_range still works, wi

Re: [PATCH v2] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF

2016-06-06 Thread David Miller
From: Helge Deller Date: Fri, 3 Jun 2016 23:49:17 +0200 > Commit 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") > missed to add the compat case for the SO_ATTACH_REUSEPORT_CBPF option. > > Signed-off-by: Helge Deller Applied.

Re: [PATCH] soreuseport: Fix reuseport_bpf testcase on 32bit architectures

2016-06-06 Thread David Miller
From: Helge Deller Date: Fri, 3 Jun 2016 19:19:20 +0200 > This fixes the following compiler warnings when compiling the > reuseport_bpf testcase on a 32 bit platform: > > reuseport_bpf.c: In function ‘attach_ebpf’: > reuseport_bpf.c:114:15: warning: cast from pointer to integer of ifferent > si

Re: [PATCH net-next 00/15] net/smc: Shared Memory Communications - RDMA

2016-06-06 Thread David Miller
From: Ursula Braun Date: Fri, 3 Jun 2016 17:26:59 +0200 > It is transparent to most existing TCP connection load balancers > that are commonly used in the enterprise data center environment for > multi-tier application workloads. I think a better word would be "bypass". And likewise the data s

Re: [PATCH -next] cbq: remove only caller of qdisc->drop()

2016-06-06 Thread Eric Dumazet
On Mon, 2016-06-06 at 23:20 +0200, Florian Westphal wrote: > since initial revision of cbq in 2004 iproute2 never implemented > support for TCA_CBQ_OVL_STRATEGY, which is what needs to be set to > activate the class->drop() call (TC_CBQ_OVL_DROP strategy must be > set by userspace). > > So lets re

Re: [PATCH net-next 0/3] net: vrf: Add support for local traffic to local addresses

2016-06-06 Thread David Miller
From: David Ahern Date: Thu, 2 Jun 2016 13:15:09 -0700 > Add support for locally originated traffic to VRF-local addresses, > be it addresses on enslaved devices or addresses on the VRF device: ... Series applied, but I've been wondering what happens to hw offloads when these VRF devices sit i

[PATCH net] tcp: record TLP and ER timer stats in v6 stats

2016-06-06 Thread Yuchung Cheng
The v6 tcp stats scan do not provide TLP and ER timer information correctly like the v4 version . This patch fixes that. Fixes: 6ba8a3b19e76 ("tcp: Tail loss probe (TLP)") Fixes: eed530b6c676 ("tcp: early retransmit") Signed-off-by: Yuchung Cheng Signed-off-by: Neal Cardwell --- net/ipv6/tcp_ip

[PATCH -next] cbq: remove only caller of qdisc->drop()

2016-06-06 Thread Florian Westphal
since initial revision of cbq in 2004 iproute2 never implemented support for TCA_CBQ_OVL_STRATEGY, which is what needs to be set to activate the class->drop() call (TC_CBQ_OVL_DROP strategy must be set by userspace). So lets remove this. We can even do this in a backwards compatible way by switch

Re: [PATCH] netlabel: add address family checks to netlbl_{sock, req}_delattr()

2016-06-06 Thread David Miller
From: Paul Moore Date: Mon, 6 Jun 2016 15:37:56 -0400 > On Mon, Jun 6, 2016 at 3:35 PM, Paul Moore wrote: >> From: Paul Moore >> >> It seems risky to always rely on the caller to ensure the socket's >> address family is correct before passing it to the NetLabel kAPI, >> especially since we see

[PATCH] brcmfmac: drop unused pm_block vif attribute

2016-06-06 Thread Rafał Miłecki
This attribute was added 3 years ago by commit 3eacf866559c ("brcmfmac: introduce brcmf_cfg80211_vif structure") but it remains unused since then. It seems we can safely drop it. Signed-off-by: Rafał Miłecki --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 9 +++-- drivers/n

Re: [PATCH] net: stmmac: dwmac-rk: keep PHY up for WoL

2016-06-06 Thread Vincent Palatin
On Mon, Jun 6, 2016 at 1:45 PM, Heiko Stübner wrote: > Hi, > > Am Freitag, 3. Juni 2016, 10:29:20 schrieb Vincent Palatin: >> Do not shutdown the PHY if Wake-on-Lan is enabled, else it cannot wake >> us up. >> >> Signed-off-by: Vincent Palatin >> --- >> drivers/net/ethernet/stmicro/stmmac/dwmac-

[PATCH net] net: sched: fix tc_should_offload for specific clsact classes

2016-06-06 Thread Daniel Borkmann
When offloading classifiers such as u32 or flower to hardware, and the qdisc is clsact (TC_H_CLSACT), then we need to differentiate its classes, since not all of them handle ingress, therefore we must leave those in software path. Add a .tcf_cl_offload() callback, so we can generically handle them,

Re: [PATCH] net: stmmac: dwmac-rk: keep PHY up for WoL

2016-06-06 Thread Heiko Stübner
Hi, Am Freitag, 3. Juni 2016, 10:29:20 schrieb Vincent Palatin: > Do not shutdown the PHY if Wake-on-Lan is enabled, else it cannot wake > us up. > > Signed-off-by: Vincent Palatin > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 8 > 1 file changed, 8 insertions(+) > > diff -

linux-next: UBSAN whine and BUG in net/ipv4/fib_trie.c

2016-06-06 Thread Valdis Kletnieks
Seeing this in next-20160606 (next-20160530 is fine), does it ring any bells before I spend a long evening doing a bisect? The Google doesn't seem to have seen this traceback in the past week [ 226.9

Re: [PATCH net-next] net, cls: allow for deleting all filters for given parent

2016-06-06 Thread Daniel Borkmann
On 06/06/2016 09:52 PM, Cong Wang wrote: On Mon, Jun 6, 2016 at 12:25 PM, Daniel Borkmann wrote: On 06/06/2016 07:12 PM, Cong Wang wrote: On Sat, Jun 4, 2016 at 9:24 AM, Daniel Borkmann wrote: + if (n->nlmsg_type == RTM_DELTFILTER && prio == 0) { + tcf_destroy_chain(cha

Re: [PATCH net-next 2/9] net: dsa: Add support for parsing the old binding

2016-06-06 Thread Florian Fainelli
On 06/05/2016 08:19 PM, Andrew Lunn wrote: >> How much support do we want to have for the old binding for in tree >> platforms? Is the plan to migrate them all to the new binding? > > I think there are three cases to consider. > > 1) There are some old boards using setup.c files which have a plat

Re: [RFC PATCH 0/4] Make inotify instance/watches be accounted per userns

2016-06-06 Thread Eric W. Biederman
Nikolay Borisov writes: > On 06/03/2016 11:41 PM, Eric W. Biederman wrote: >> Nikolay Borisov writes: >> >>> On 06/02/2016 07:58 PM, Eric W. Biederman wrote: Nikolay please see my question for you at the end. >> [snip] All of that said there is definitely a practical question th

Re: [PATCH net-next] net, cls: allow for deleting all filters for given parent

2016-06-06 Thread Cong Wang
On Mon, Jun 6, 2016 at 12:25 PM, Daniel Borkmann wrote: > On 06/06/2016 07:12 PM, Cong Wang wrote: >> >> On Sat, Jun 4, 2016 at 9:24 AM, Daniel Borkmann >> wrote: >>> >>> + if (n->nlmsg_type == RTM_DELTFILTER && prio == 0) { >>> + tcf_destroy_chain(chain); >>> +

Re: [PATCH] netlabel: add address family checks to netlbl_{sock, req}_delattr()

2016-06-06 Thread Paul Moore
On Mon, Jun 6, 2016 at 3:35 PM, Paul Moore wrote: > From: Paul Moore > > It seems risky to always rely on the caller to ensure the socket's > address family is correct before passing it to the NetLabel kAPI, > especially since we see at least one LSM which didn't. Add address > family checks to t

[PATCH] netlabel: add address family checks to netlbl_{sock, req}_delattr()

2016-06-06 Thread Paul Moore
From: Paul Moore It seems risky to always rely on the caller to ensure the socket's address family is correct before passing it to the NetLabel kAPI, especially since we see at least one LSM which didn't. Add address family checks to the *_delattr() functions to help prevent future problems. Cc:

Re: [PATCH net-next] net, cls: allow for deleting all filters for given parent

2016-06-06 Thread Daniel Borkmann
On 06/06/2016 07:12 PM, Cong Wang wrote: On Sat, Jun 4, 2016 at 9:24 AM, Daniel Borkmann wrote: + if (n->nlmsg_type == RTM_DELTFILTER && prio == 0) { + tcf_destroy_chain(chain); + err = 0; + goto errout; + } We need to notify users we remo

Re: [EDT][Patch 1/1] socket family check in netlabel APIs

2016-06-06 Thread Paul Moore
On Thu, May 7, 2015 at 1:53 AM, Maninder Singh wrote: > EP-E68D5E24548545C9BBB607A98ADD61E6 > > Hi Paul, > >>On Monday, March 30, 2015 11:09:00 AM Maninder Singh wrote: >>> Dear All, >>> we found One Kernel Crash issue in cipso_v4_sock_delattr :- >>> As Cipso supports only inet sockets so cipso_v4

Re: [PATCH net 3/3] RDS: TCP: fix race windows in send-path quiescence by rds_tcp_accept_one()

2016-06-06 Thread Santosh Shilimkar
On 6/4/2016 2:00 PM, Sowmini Varadhan wrote: The send path needs to be quiesced before resetting callbacks from rds_tcp_accept_one(), and commit eb192840266f ("RDS:TCP: Synchronize rds_tcp_accept_one with rds_send_xmit when resetting t_sock") achieves this using the c_state and RDS_IN_XMIT bit fo

Re: [PATCH net 2/3] RDS: TCP: Retransmit half-sent datagrams when switching sockets in rds_tcp_reset_callbacks

2016-06-06 Thread Santosh Shilimkar
On 6/4/2016 1:59 PM, Sowmini Varadhan wrote: When we switch a connection's sockets in rds_tcp_rest_callbacks, any partially sent datagram must be retransmitted on the new socket so that the receiver can correctly reassmble the RDS datagram. Use rds_send_reset() which is designed for this purpose.

Re: [PATCH net 1/3] RDS: TCP: Add/use rds_tcp_reset_callbacks to reset tcp socket safely

2016-06-06 Thread Santosh Shilimkar
On 6/4/2016 1:59 PM, Sowmini Varadhan wrote: When rds_tcp_accept_one() has to replace the existing tcp socket with a newer tcp socket (duelling-syn resolution), it must lock_sock() to suppress the rds_tcp_data_recv() path while callbacks are being changed. Also, existing RDS datagram reassembly

Re: [PATCH net v2] sfc: report supported link speeds on SFP connections

2016-06-06 Thread Jarod Wilson
On Mon, Jun 06, 2016 at 05:29:30PM +0100, Bert Kenward wrote: > 7000-series SFC NICs connected with an SFP+ module currently fail to > report any supported link speeds. > > Reported-by: Jarod Wilson > Signed-off-by: Bert Kenward Had a feeling my cut might not have been quite right. Looks good t

ATTENTION ! ATTENTION !! ATTENTION !!!

2016-06-06 Thread Mr Kamal Ali Mohamed
Greetings Dear Friend, I never want to disturb you at all but will like you give me your attention. I need a matured and capable hand in a business deal of $8, 500, 000.00 (Eight Million Five Hundred Thousand USA Dollars).I belief you are suitable to handle such project perfectly .I will give

Re: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support

2016-06-06 Thread Florian Fainelli
On 06/06/2016 05:41 AM, Pramod Kumar wrote: > Add PCI Phy support for Broadcom Northstar2 SoCs. This driver uses the > interface from the iproc mdio mux driver to enable the devices > respective phys. > > Reviewed-by: Andrew Lunn > Signed-off-by: Jon Mason > Signed-off-by: Pramod Kumar > --- >

Re: [PATCH v4 5/7] net: mdio-mux: Add MDIO mux driver for iProc SoCs

2016-06-06 Thread Florian Fainelli
On 06/06/2016 05:41 AM, Pramod Kumar wrote: > iProc based SoCs supports the integrated mdio multiplexer which > has the bus selection as well as mdio transaction generation logic > inside. > > This multiplexer has child buses for PCIe, SATA, USB and ETH. These > buses could be internal or external

Re: [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node

2016-06-06 Thread Florian Fainelli
On 06/06/2016 05:41 AM, Pramod Kumar wrote: > Add integrated MDIO multiplexer driver node which contains > two mux PCIe bus and one ethernet bus along with phys > lying on these bus. > > Signed-off-by: Pramod Kumar > --- > + mdio_mux_iproc: mdio-mux@6602023c { > +

Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus multiplexer

2016-06-06 Thread Florian Fainelli
On 06/06/2016 05:41 AM, Pramod Kumar wrote: > Add DT binding doc for Broadcom MDIO bus multiplexer driver. > > Reviewed-by: Andrew Lunn > Signed-off-by: Pramod Kumar Reviewed-by: Florian Fainelli > +for example: > + mdio_mux_iproc: mdio-mux@6602023c { I think Rob wanted you to d

Re: [PATCH v4 1/7] mdio: mux: Enhanced MDIO mux framework for integrated multiplexers

2016-06-06 Thread Florian Fainelli
On 06/06/2016 05:41 AM, Pramod Kumar wrote: > An integrated multiplexer uses same address space for > "muxed bus selection" and "generation of mdio transaction" > hence its good to register parent bus from mux driver. > > Hence added a mechanism where mux driver could register a > parent bus and p

Re: [PATCH net-next] tcp: accept RST if SEQ matches right edge of right-most SACK block

2016-06-06 Thread Neal Cardwell
The functionality seems OK to me, though there are some style/formatting issues, which checkpatch.pl picks up: > ./scripts/checkpatch.pl > net-next-tcp-accept-RST-if-SEQ-matches-right-edge-of-right-most-SACK-block.patch WARNING: line over 80 characters #73: FILE: net/ipv4/tcp_input.c:5199: +

Re: [PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-06 Thread Florian Fainelli
On 06/03/2016 02:56 AM, LABBE Corentin wrote: > This patch add support for sun8i-emac ethernet MAC hardware. > It could be found in Allwinner H3/A83T/A64 SoCs. > > It supports 10/100/1000 Mbit/s speed with half/full duplex. > It can use an internal PHY (MII 10/100) or an external PHY > via RGMII/R

[PATCH v3 3/5] drivers: net: phy: Add MDIO driver

2016-06-06 Thread Iyappan Subramanian
Currently, SGMII based 1G rely on the hardware registers for link state and sometimes it's not reliable. To get most accurate link state, this interface has to use the MDIO bus to poll the PHY. In X-Gene SoC, MDIO bus is shared across RGMII and SGMII based 1G interfaces, so adding this driver to

[PATCH v3 2/5] drivers: net: xgene: Backward compatibility with older firmware

2016-06-06 Thread Iyappan Subramanian
This patch looks for CONFIG_MDIO_XGENE and based on phy-handle DT/ACPI fields, sets the mdio_driver flag. The rest of the driver uses the this flag for any MDIO management, in the case of backward compatibility. Also, some code clean up done around mdio configuration/remove. Signed-off-by: Iyappa

[PATCH v3 5/5] drivers: net: xgene: Fix module load/unload crash

2016-06-06 Thread Iyappan Subramanian
When the driver is configured as kernel module and when it gets unloaded and reloaded, kernel crash was observed, due to incomplete hardware cleanup. This patch addresses this issue with the following changes, - Reordered mac enable and disable - Added hardware prefetch buffer cleanup - Added Tx

[PATCH v3 0/5] drivers: net: xgene: Fix 1G hot-plug and module support

2016-06-06 Thread Iyappan Subramanian
This patchset addresses the following issues, 1. hot-plug issue on the SGMII 1G interface - by adding a driver for MDIO management 2. fixes the kernel crash when the driver loaded as an kernel module - by fixing hardware cleanups and rearrange kernel API calls Signed-off-by: Iyapp

[PATCH v3 4/5] dtb: xgene: Add MDIO node

2016-06-06 Thread Iyappan Subramanian
Added mdio node for mdio driver. Also added phy-handle reference to the ethernet nodes. Removed unused mdio subnode within storm menet ethernet node. Removed unused clock node from storm sgenet1. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias

[PATCH v3 1/5] drivers: net: xgene: MAC and PHY configuration changes

2016-06-06 Thread Iyappan Subramanian
This patch fixes MAC configuration to support 10/100GbE for SGMII and link_state call back. It also sets pdata->mdio_driver flag based on ethernet mdio subnode and prepare for MDIO driver support. In summary, following are the changes, - Added set_speed function pointer in mac_ops - Changed link_

Re: [PATCH 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-06-06 Thread Corentin LABBE
Le 06/06/2016 16:14, Rob Herring a écrit : > On Fri, Jun 03, 2016 at 11:56:28AM +0200, LABBE Corentin wrote: >> This patch adds documentation for Device-Tree bindings for the >> Allwinner sun8i-emac driver. >> >> Signed-off-by: LABBE Corentin >> --- >> .../bindings/net/allwinner,sun8i-emac.txt

RE: [EXT] [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Mario_Limonciello
> -Original Message- > From: Konstantin Shkolnyy [mailto:konstantin.shkol...@silabs.com] > Sent: Monday, June 6, 2016 12:43 PM > To: Limonciello, Mario ; > hayesw...@realtek.com > Cc: LKML ; Netdev > ; Linux USB ; > pali.ro...@gmail.com; anthony.w...@canonical.com; Greg KH > > Subject: RE:

Re: [net-next PATCH 1/1] net sched: indentation and other OCD stylistic fixes

2016-06-06 Thread Cong Wang
On Sun, Jun 5, 2016 at 7:41 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > Signed-off-by: Jamal Hadi Salim Looks good, Acked-by: Cong Wang Thanks!

RE: [EXT] [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Konstantin Shkolnyy
> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Mario Limonciello > Sent: Monday, June 06, 2016 12:19 > To: hayesw...@realtek.com > Cc: LKML; Netdev; Linux USB; pali.ro...@gmail.com; > anthony.w...@canonical.com; Greg KH;

Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Greg KH
On Mon, Jun 06, 2016 at 05:24:57PM +, mario_limoncie...@dell.com wrote: > That said, I would be highly surprised if Realtek decided to implement > with another OEM differently. It would increase their code complexity > on Windows as well since this is part of the generic driver. Ah, it's refr

Re: [PATCH v2 net-next 0/3] net sched action timestamp improvements

2016-06-06 Thread Cong Wang
On Mon, Jun 6, 2016 at 3:32 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > Various aggregations of duplicated code, fixes and introduction of firstused > timestamp > > v2: add const for source time info per suggestion from Cong For this whole series, Acked-by: Cong Wang Thanks!

Re: [PATCH net 2/2] net: cls_u32: be more strict about skip-sw flag

2016-06-06 Thread Samudrala, Sridhar
On 6/6/2016 8:16 AM, Jakub Kicinski wrote: Return an error if user requested skip-sw and the underlaying hardware cannot handle tc offloads (or offloads are disabled). Signed-off-by: Jakub Kicinski looks good. I think we need similar checks in u32_replace_hw_knode() too. --- net/sched/

  1   2   >