On Mon, Jun 6, 2016 at 12:25 PM, Daniel Borkmann <dan...@iogearbox.net> wrote:
> On 06/06/2016 07:12 PM, Cong Wang wrote:
>>
>> On Sat, Jun 4, 2016 at 9:24 AM, Daniel Borkmann <dan...@iogearbox.net>
>> wrote:
>>>
>>> + if (n->nlmsg_type == RTM_DELTFILTER && prio == 0) {
>>> + tcf_destroy_chain(chain);
>>> + err = 0;
>>> + goto errout;
>>> + }
>>
>>
>> We need to notify users we removed which filters, right?
>
>
> As far as I know, most such use cases that listen on this are bypasses
> that mirror kernel configs from user space ... but well, sure, I can add
> a notification if people care. Would do this as a separate patch.
This is fundamental for libnl to update caches.
I don't understand why it should be separated, since notification is
not a feature, we already have notifications in other paths.
>
> Looking into this, I would probably make this a single notification that
> denotes this 'wild-card' removal for that parent instead of calling
> tfilter_notify() for each filter separately (which allocs skb, dumps it,
> etc), qdisc del doesn't loop through it either, so probably fine this way.
Makes sense.
Thanks.
