Re: [PATCH net-next] vxlan: set mac_header correctly in GPE mode

2016-05-11 Thread Shmulik Ladkani
Hi Jiri, On Wed, 11 May 2016 15:55:06 +0200 Jiri Benc wrote: > For VXLAN-GPE, the interface is ARPHRD_NONE, thus we need to reset > mac_header after pulling the outer header. > > Fixes: e1e5314de08b ("vxlan: implement GPE") > Signed-off-by: Jiri Benc > --- > drivers/net/vxlan.c | 2 ++ > 1 fil

Re: networking/ip-sysctl.txt: SRR or SSRR

2016-05-11 Thread Christian Kujau
On Tue, 10 May 2016, David Miller wrote: > Every single variable name and function name dealing with this IP > option uses "srr", therefore I don't think we should adjust the > documentation either. > > "srr" covers both the loose source route option and the strict source > route option. Now that

Re: [net-next PATCH] udp: Resolve NULL pointer dereference

2016-05-11 Thread Cong Wang
On Wed, May 11, 2016 at 7:24 PM, Alexander Duyck wrote: > While testing an OpenStack configuration using VXLANs I saw the following > call trace: ... > > I believe the trace is pointing to the call to dev_net(dev) in > udp4_lib_lookup_skb. If I am not mistaken I believe it is possible for us > to

Re: [PATCH net-next 2/2] net: cls_u32: Add support for skip-sw flag to tc u32 classifier.

2016-05-11 Thread David Miller
From: "Samudrala, Sridhar" Date: Wed, 11 May 2016 16:44:55 -0700 > > On 5/11/2016 4:23 PM, David Miller wrote: >> This is a core semantic issue, and we have to make sure all amongst us >> that we are all comfortable with exporting the offloadability controls >> in the way you are implementing th

Re: [PATCH net 0/2] bnxt_en: Add workaround to detect bad opaque in rx completion.

2016-05-11 Thread David Miller
From: Michael Chan Date: Tue, 10 May 2016 19:17:58 -0400 > 2-part workaround for this hardware bug. Series applied.

Re: [patch -mainline] qlcnic: potential NULL dereference in qlcnic_83xx_get_minidump_template()

2016-05-11 Thread David Miller
From: Dan Carpenter Date: Tue, 10 May 2016 22:20:04 +0300 > If qlcnic_fw_cmd_get_minidump_temp() fails then "fw_dump->tmpl_hdr" is > NULL or possibly freed. It can lead to an oops later. > > Fixes: d01a6d3c8ae1 ('qlcnic: Add support to enable capability to extend > minidump for iSCSI') > Signe

Re: [GIT] [4.6] NFC update

2016-05-11 Thread David Miller
From: Samuel Ortiz Date: Wed, 11 May 2016 11:11:28 +0200 > This is the first NFC pull request for 4.7. With this one we > mainly have: Pulled, thanks.

Re: [net-next PATCH] udp: Resolve NULL pointer dereference

2016-05-11 Thread Eric Dumazet
On Wed, 2016-05-11 at 19:24 -0700, Alexander Duyck wrote: > While testing an OpenStack configuration using VXLANs I saw the following > call trace: > > I believe the trace is pointing to the call to dev_net(dev) in > udp4_lib_lookup_skb. If I am not mistaken I believe it is possible for us > to

[net-next PATCH] udp: Resolve NULL pointer dereference

2016-05-11 Thread Alexander Duyck
While testing an OpenStack configuration using VXLANs I saw the following call trace: RIP: 0010:[] udp4_lib_lookup_skb+0x49/0x80 RSP: 0018:88103867bc50 EFLAGS: 00010286 RAX: 88103269bf00 RBX: 88103269bf00 RCX: RDX: 4300 RSI: RDI: 8

Re: [patch V4 23/31] ethernet: use parity8 in sun/niu.c

2016-05-11 Thread David Miller
From: zengzhao...@163.com Date: Wed, 11 May 2016 17:22:17 +0800 > From: Zhaoxiu Zeng > > Signed-off-by: Zhaoxiu Zeng > Acked-by: Michal Nazarewicz Acked-by: David S. Miller

Re: [patch V4 29/31] ethernet: use parity8 in broadcom/tg3.c

2016-05-11 Thread David Miller
From: zengzhao...@163.com Date: Wed, 11 May 2016 17:24:33 +0800 > From: Zhaoxiu Zeng > > Signed-off-by: Zhaoxiu Zeng > Acked-by: Siva Reddy Kallam Acked-by: David S. Miller

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-11 Thread David Miller
From: Ard Biesheuvel Date: Wed, 11 May 2016 09:47:49 +0200 > The current logic around the 'use_dac' module parameter prevents the > r81969 driver from being loadable on 64-bit systems without any RAM > below 4 GB when the parameter is left at its default value. > So introduce a new default value

linux-next: manual merge of the net-next tree with the net tree

2016-05-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv4/ip_gre.c between commit: e271c7b4420d ("gre: do not keep the GRE header around in collect medata mode") from the net tree and commit: 244a797bdcf1 ("gre: move iptunnel_pull_header down to ipgre_rcv") from

Re: [PATCH -next 3/4] net: w5100: increase TX timeout period

2016-05-11 Thread David Miller
From: Akinobu Mita Date: Wed, 11 May 2016 15:30:26 +0900 > This increases TX timeout period from one second to 5 seconds which is > default value defined in net/sched/sch_generic.c. > > The one second timeout is too short for W5100 with SPI interface mode > which doesn't support burst READ/WRITE

Re: [PATCH net-next 2/2] net: cls_u32: Add support for skip-sw flag to tc u32 classifier.

2016-05-11 Thread Samudrala, Sridhar
On 5/11/2016 4:23 PM, David Miller wrote: From: Sridhar Samudrala Date: Mon, 9 May 2016 12:18:44 -0700 On devices that support TC U32 offloads, this flag enables a filter to be added only to HW. skip-sw and skip-hw are mutually exclusive flags. By default without any flags, the filter is add

Re: [PATCH net-next 0/3] Mellanox 100G mlx5 CQE compression

2016-05-11 Thread David Miller
From: Saeed Mahameed Date: Wed, 11 May 2016 00:29:13 +0300 > Introducing ConnectX-4 CQE (Completion Queue Entry) compression > feature for mlx5 etherent driver. Seires applied, thanks.

Re: [PATCH v1 net-next 0/7] More enabler patches for DSA probing

2016-05-11 Thread David Miller
From: Andrew Lunn Date: Tue, 10 May 2016 23:27:18 +0200 > The complete set of patches for the reworked DSA probing is too big to > post as once. These subset contains some enablers which are easy to > review. > > Eventually, the Marvell driver will instantiate its own internal MDIO > bus, rather

Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: abstract VTU/STU data access

2016-05-11 Thread David Miller
From: Vivien Didelot Date: Tue, 10 May 2016 15:44:28 -0400 > Both VTU and STU operations use the same routine to access their > (common) data registers, with a different offset. > > Add VTU and STU specific read and write functions to the data registers > to abstract the required offset. > > Si

Re: [PATCH net-next v4 0/2] net: vrf: Fixup PKTINFO to return enslaved device index

2016-05-11 Thread David Miller
From: David Ahern Date: Tue, 10 May 2016 11:19:49 -0700 > Applications such as OSPF and BFD need the original ingress device not > the VRF device; the latter can be derived from the former. To that end > move the packet intercept from an rx handler that is invoked by > __netif_receive_skb_core to

Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: add STU capability

2016-05-11 Thread David Miller
From: Vivien Didelot Date: Tue, 10 May 2016 15:44:29 -0400 > Some switch models have a STU (per VLAN port state database). Add a new > capability flag to switches info, instead of checking their family. > > Also if the 6165 family has an STU, it must have a VTU, so add the > MV88E6XXX_FLAG_VTU t

Re: [PATCH net] drivers: net: Don't print unpopulated net_device name

2016-05-11 Thread David Miller
From: Harvey Hunt Date: Tue, 10 May 2016 17:43:21 +0100 > @@ -1686,8 +1686,7 @@ dm9000_probe(struct platform_device *pdev) > } > > if (!is_valid_ether_addr(ndev->dev_addr)) { > - dev_warn(db->dev, "%s: Invalid ethernet MAC address. Please " > - "set

Re: [PATCH net-next] ipv6: fix 4in6 tunnel receive path

2016-05-11 Thread David Miller
From: Nicolas Dichtel Date: Tue, 10 May 2016 16:08:17 +0200 > Protocol for 4in6 tunnel is IPPROTO_IPIP. This was wrongly changed by > the last cleanup. > > CC: Tom Herbert > Fixes: 0d3c703a9d17 ("ipv6: Cleanup IPv6 tunnel receive path") > Signed-off-by: Nicolas Dichtel Applied, thanks.

Re: [PATCH net-next 2/2] net: cls_u32: Add support for skip-sw flag to tc u32 classifier.

2016-05-11 Thread David Miller
From: Sridhar Samudrala Date: Mon, 9 May 2016 12:18:44 -0700 > On devices that support TC U32 offloads, this flag enables a filter to be > added only to HW. skip-sw and skip-hw are mutually exclusive flags. By > default without any flags, the filter is added to both HW and SW, but no > error che

[PATCH net-next 1/1] tipc: eliminate risk of double link_up events

2016-05-11 Thread Jon Maloy
When an ACTIVATE or data packet is received in a link in state ESTABLISHING, the link does not immediately change state to ESTABLISHED, but does instead return a LINK_UP event to the caller, which will execute the state change in a different lock context. This non-atomic approach incurs a low risk

Re: [RFC PATCH 0/2] net: threadable napi poll loop

2016-05-11 Thread Hannes Frederic Sowa
On 11.05.2016 16:45, Eric Dumazet wrote: > On Wed, May 11, 2016 at 7:38 AM, Paolo Abeni wrote: > >> Uh, we have likely the same issue in the net_rx_action() function, which >> also execute with bh disabled and check for jiffies changes even on >> single core hosts ?!? > > That is why we have a l

Re: [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

2016-05-11 Thread Simon Horman
On Wed, May 11, 2016 at 04:09:28PM +0200, Jiri Benc wrote: > On Wed, 11 May 2016 12:06:35 +0900, Simon Horman wrote: > > Is this close to what you had in mind? > > Yes but see below. > > > @@ -739,17 +729,17 @@ int ovs_flow_key_extract(const struct ip_tunnel_info > > *tun_info, > > key->phy.

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-11 Thread Dean Jenkins
Hi John, I have purchased a "uGreen" USB Ethernet Adaptor which was reported as showing the issue: lsusb shows: ID 0b95:772b ASIX Electronics Corp. AX88772B dmesg shows: [119591.413298] usb 2-1: new high-speed USB device number 12 using ci_hdrc [119591.576970] usb 2-1: New USB device found, i

Re: [RFC PATCH 0/2] net: threadable napi poll loop

2016-05-11 Thread Eric Dumazet
On Wed, 2016-05-11 at 08:55 +0200, Peter Zijlstra wrote: > On Tue, May 10, 2016 at 03:51:37PM -0700, Eric Dumazet wrote: > > diff --git a/kernel/softirq.c b/kernel/softirq.c > > index 17caf4b63342..22463217e3cf 100644 > > --- a/kernel/softirq.c > > +++ b/kernel/softirq.c > > @@ -56,6 +56,7 @@ EXPOR

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-11 Thread Francois Romieu
Ard Biesheuvel : > On 11 May 2016 at 22:31, Francois Romieu wrote: [...] > It has little to do with f*cking legacy 32-bits-only-devices if DRAM > simply starts at 0x80__. This is on an AMD arm64 chip. The lack of IOMMU surprizes me. [...] > OK, if you prefer. Should I send a v2? Don't

Re: [PATCH net-next] phy: micrel: Use MICREL_PHY_ID_MASK definition

2016-05-11 Thread Andrew Lunn
On Wed, May 11, 2016 at 05:02:05PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Replace the hardcoded mask 0x00f0 with MICREL_PHY_ID_MASK for > better readability. > > Suggested-by: Andrew Lunn > Signed-off-by: Fabio Estevam Reviewed-by: Andrew Lunn Thanks Andrew

Re: [PATCH net-next] phy: micrel: Use MICREL_PHY_ID_MASK definition

2016-05-11 Thread Florian Fainelli
On 05/11/2016 01:02 PM, Fabio Estevam wrote: > From: Fabio Estevam > > Replace the hardcoded mask 0x00f0 with MICREL_PHY_ID_MASK for > better readability. > > Suggested-by: Andrew Lunn > Signed-off-by: Fabio Estevam Acked-by: Florian Fainelli -- Florian

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-11 Thread Ard Biesheuvel
On 11 May 2016 at 22:31, Francois Romieu wrote: > Ard Biesheuvel : >> The current logic around the 'use_dac' module parameter prevents the >> r81969 driver from being loadable on 64-bit systems without any RAM >> below 4 GB when the parameter is left at its default value. >> So introduce a new de

Re: [PATCH] r8169: default to 64-bit DMA on systems without memory below 4 GB

2016-05-11 Thread Francois Romieu
Ard Biesheuvel : > The current logic around the 'use_dac' module parameter prevents the > r81969 driver from being loadable on 64-bit systems without any RAM > below 4 GB when the parameter is left at its default value. > So introduce a new default value -1 which indicates that 64-bit DMA > should

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-05-11 Thread Timur Tabi
Timur Tabi wrote: I think the problem is that the current driver seems to be too eager to start/stop the MAC. Please take a look at emac_work_thread_link_check() at https://lkml.org/lkml/2016/4/13/670. Every time the PHY link goes up, it does this: Never mind, I figured out the problem. I st

[PATCH] net: mvneta: bm: fix dependencies again

2016-05-11 Thread Arnd Bergmann
I tried to fix this before, but my previous fix was incomplete and we can still get the same link error in randconfig builds because of the way that Kconfig treats the default y if MVNETA=y && MVNETA_BM_ENABLE line that does not actually trigger when MVNETA_BM_ENABLE=m, unlike I intended.

[PATCH net-next] phy: micrel: Use MICREL_PHY_ID_MASK definition

2016-05-11 Thread Fabio Estevam
From: Fabio Estevam Replace the hardcoded mask 0x00f0 with MICREL_PHY_ID_MASK for better readability. Suggested-by: Andrew Lunn Signed-off-by: Fabio Estevam --- drivers/net/phy/micrel.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

Fw: [GIT] Networking

2016-05-11 Thread David Miller
Sorry, forgot to CC: the lists on the initial send. --- Begin Message --- Hopefully the last round of fixes this release, fingers crossed :) 1) Initialize static nf_conntrack_locks_all_lock properly, from Florian Westphal. 2) Need to cancel pending work when destroying IDLETIMER entries, fro

Re: [PATCH v4 net-next] tcp: replace cnt & rtt with struct in pkts_acked()

2016-05-11 Thread David Miller
From: Lawrence Brakmo Date: Wed, 11 May 2016 10:02:13 -0700 > Replace 2 arguments (cnt and rtt) in the congestion control modules' > pkts_acked() function with a struct. This will allow adding more > information without having to modify existing congestion control > modules (tcp_nv in particular

Re: [PATCH net] gre: do not keep the GRE header around in collect medata mode

2016-05-11 Thread David Miller
From: Jiri Benc Date: Wed, 11 May 2016 15:53:57 +0200 > For ipgre interface in collect metadata mode, it doesn't make sense for the > interface to be of ARPHRD_IPGRE type. The outer header of received packets > is not needed, as all the information from it is present in metadata_dst. We > already

Re: [PATCHv2 net] openvswitch: Fix cached ct with helper.

2016-05-11 Thread David Miller
From: Joe Stringer Date: Wed, 11 May 2016 10:29:26 -0700 > When using conntrack helpers from OVS, a common configuration is to > perform a lookup without specifying a helper, then go through a > firewalling policy, only to decide to attach a helper afterwards. > > In this case, the initial looku

Re: [v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb inrtl_pci_reset_trx_ring

2016-05-11 Thread Kalle Valo
wang yanqing wrote: > We can't use kfree_skb in irq disable context, because spin_lock_irqsave > make sure we are always in irq disable context, use dev_kfree_skb_irq > instead of kfree_skb is better than dev_kfree_skb_any. > > This patch fix below kernel warning: > [ 7612.095528] [ c

Re: [v2] rtlwifi: Remove double check for cnt_after_linked

2016-05-11 Thread Kalle Valo
wang yanqing wrote: > rtl_lps_enter does two successive check for cnt_after_linked > to make sure some time has elapsed after linked. The second > check isn't necessary, because if cnt_after_linked is bigger > than 5, it is bigger than 2 of course! > > This patch remove the second check code. >

Re: rtlwifi: rtl818x: silence uninitialized variable warning

2016-05-11 Thread Kalle Valo
Dan Carpenter wrote: > What about if "rtlphy->pwrgroup_cnt" is 2? In that case we would use an > uninitialized "chnlgroup" variable and probably crash. Maybe that can't > happen for some reason which is not obvious but in that case this patch > is harmless. > > Setting it to zero seems like a s

Re: [v2] rtlwifi: Fix logic error in enter/exit power-save mode

2016-05-11 Thread Kalle Valo
wang yanqing wrote: > In commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and > rtl_lps_enter() to use work queue"), the tests for enter/exit > power-save mode were inverted. With this change applied, the > wifi connection becomes much more stable. > > Fixes: a269913c52ad ("rtlwifi: Rework r

Re: rtlwifi: rtl818x: constify rtl_intf_ops structures

2016-05-11 Thread Kalle Valo
Julia Lawall wrote: > The rtl_intf_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Thanks, 1 patch applied to wireless-drivers-next.git: 1bfcfdcca142 rtlwifi: rtl818x: constify rtl_intf_ops structures -- Sent

Re: [PATCH (net.git) 2/3] Revert "stmmac: Fix 'eth0: No PHY found' regression"

2016-05-11 Thread Marc Haber
On Wed, Apr 13, 2016 at 05:44:25PM +0200, Marc Haber wrote: > On Fri, Apr 01, 2016 at 09:07:15AM +0200, Giuseppe Cavallaro wrote: > > This reverts commit 88f8b1bb41c6208f81b6a480244533ded7b59493. > > due to problems on GeekBox and Banana Pi M1 board when > > connected to a real transceiver instead

Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support

2016-05-11 Thread Dan Williams
On Wed, 2016-05-11 at 13:03 +0800, Wei-Ning Huang wrote: > On Fri, May 6, 2016 at 4:19 PM, Wei-Ning Huang > wrote: > > > > On Fri, May 6, 2016 at 12:07 AM, Dan Williams > > wrote: > > > > > > > > > On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote: > > > > > > > > Recent new hardware ha

Re: [RFC PATCH 0/2] net: threadable napi poll loop

2016-05-11 Thread Eric Dumazet
On Tue, 2016-05-10 at 14:53 -0700, Eric Dumazet wrote: > On Tue, 2016-05-10 at 17:35 -0400, Rik van Riel wrote: > > > You might need another one of these in invoke_softirq() > > > > Excellent. > > I gave it a quick try (without your suggestion), and host seems to > survive a stress test. Well,

[PATCHv2 net] openvswitch: Fix cached ct with helper.

2016-05-11 Thread Joe Stringer
When using conntrack helpers from OVS, a common configuration is to perform a lookup without specifying a helper, then go through a firewalling policy, only to decide to attach a helper afterwards. In this case, the initial lookup will cause a ct entry to be attached to the skb, then the later com

[PATCH v4 net-next] tcp: replace cnt & rtt with struct in pkts_acked()

2016-05-11 Thread Lawrence Brakmo
Replace 2 arguments (cnt and rtt) in the congestion control modules' pkts_acked() function with a struct. This will allow adding more information without having to modify existing congestion control modules (tcp_nv in particular needs bytes in flight when packet was sent). As proposed by Neal Card

[PATCH net-next 11/13] ip6_tunnel: Add support for fou/gue encapsulation

2016-05-11 Thread Tom Herbert
Add netlink and setup for encapsulation Signed-off-by: Tom Herbert --- net/ipv6/ip6_tunnel.c | 72 +++ 1 file changed, 72 insertions(+) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 66e3a63..52792f9 100644 --- a/net/ipv6/ip6_tun

[PATCH net-next 04/13] fou: Split out {fou,gue}_build_header

2016-05-11 Thread Tom Herbert
Create __fou_build_header and __gue_build_header. These implement the protocol generic parts of building the fou and gue header. fou_build_header and gue_build_header implement the IPv4 specific functions and call the __*_build_header functions. Signed-off-by: Tom Herbert --- include/net/fou.h |

[PATCH net-next 12/13] ip6ip6: Support for GSO/GRO

2016-05-11 Thread Tom Herbert
Signed-off-by: Tom Herbert --- net/ipv6/ip6_offload.c | 24 +--- net/ipv6/ip6_tunnel.c | 3 +++ 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c index 787e55f..332d6a0 100644 --- a/net/ipv6/ip6_offload.c +++ b/ne

[PATCH net-next 10/13] ip6_gre: Add support for fou/gue encapsulation

2016-05-11 Thread Tom Herbert
Add netlink and setup for encapsulation Signed-off-by: Tom Herbert --- net/ipv6/ip6_gre.c | 77 +++--- 1 file changed, 74 insertions(+), 3 deletions(-) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index ee62ec4..4110189 100644 --- a/net/ip

[PATCH net-next 02/13] net: define gso types for IPx over IPv4 and IPv6

2016-05-11 Thread Tom Herbert
This patch defines two new GSO definitions SKB_GSO_IPXIP4 and SKB_GSO_IPXIP6 along with corresponding NETIF_F_GSO_IPXIP4 and NETIF_F_GSO_IPXIP6. These are used to described IP in IP tunnel and what the outer protocol is. The inner protocol can be deduced from other GSO types (e.g. SKB_GSO_TCPV4 and

[PATCH net-next 13/13] ip4ip6: Support for GSO/GRO

2016-05-11 Thread Tom Herbert
Signed-off-by: Tom Herbert --- include/net/inet_common.h | 5 + net/ipv4/af_inet.c| 12 +++- net/ipv6/ip6_offload.c| 33 - net/ipv6/ip6_tunnel.c | 5 - 4 files changed, 48 insertions(+), 7 deletions(-) diff --git a/include/net/ine

[PATCH net-next 06/13] ipv6: Fix nexthdr for reinjection

2016-05-11 Thread Tom Herbert
In ip6_input_finish the protocol handle returns a value greater than zero the packet needs to be resubmitted using the returned protocol. The returned protocol is being ignored and each time through resubmit nexthdr is taken from an offest in the packet. This patch fixes that so that nexthdr is tak

[PATCH net-next 03/13] fou: Call setup_udp_tunnel_sock

2016-05-11 Thread Tom Herbert
Use helper function to set up UDP tunnel related information for a fou socket. Signed-off-by: Tom Herbert --- net/ipv4/fou.c | 50 -- 1 file changed, 16 insertions(+), 34 deletions(-) diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index eeec7d6..6cb

[PATCH net-next 08/13] fou: Support IPv6 in fou

2016-05-11 Thread Tom Herbert
This patch adds receive path support for IPv6 with fou. - Add address family to fou structure for open sockets. This supports AF_INET and AF_INET6. Lookups for fou ports are performed on both the port number and family. - In fou and gue receive adjust tot_len in IPv4 header or payload_len ba

[PATCH net-next 07/13] ipv6: Change "final" protocol processing for encapsulation

2016-05-11 Thread Tom Herbert
When performing foo-over-UDP, UDP packets are processed by the encapsulation handler which returns another protocol to process. This may result in processing two (or more) protocols in the loop that are marked as INET6_PROTO_FINAL. The actions taken for hitting a final protocol, in particular the s

[PATCH net-next 00/13] ipv6: Enable GUEoIPv6 and more fixes for v6 tunneling

2016-05-11 Thread Tom Herbert
This patch set: - Adds support for GSO and GRO for ip6ip6 and ip4ip6 - Add support for FOU and GUE in IPv6 - Support GRE, ip6ip6 and ip4ip6 over FOU/GUE - Fixes ip6_input to deal with UDP encapsulations - Some other minor fixes v2: - Removed a check of GSO types in MPLS - Define GSO

[PATCH net-next 01/13] gso: Remove arbitrary checks for unsupported GSO

2016-05-11 Thread Tom Herbert
In several gso_segment functions there are checks of gso_type against a seemingly arbitrary list of SKB_GSO_* flags. This seems like an attempt to identify unsupported GSO types, but since the stack is the one that set these GSO types in the first place this seems unnecessary to do. If a combinatio

[PATCH net-next 05/13] fou: Add encap ops for IPv6 tunnels

2016-05-11 Thread Tom Herbert
This patch adds IP tunnel encapsulation operations for IPv6. This includes the infrastructure to add and delete operations. IPv6 variants of fou6_build_header and gue6_build_header are added in a new fou6 module. These encapsulation operations for fou and gue are automatically added when the fou6 m

[PATCH net-next 09/13] ip6_tun: Add infrastructure for doing encapsulation

2016-05-11 Thread Tom Herbert
Add encap_hlen and ip_tunnel_encap structure to ip6_tnl. Add functions for getting encap hlen, setting up encap on a tunnel, performing encapsulation operation. Signed-off-by: Tom Herbert --- include/net/ip6_tunnel.h | 8 +- net/ipv6/ip6_tunnel.c | 36 ++ net/

[PATCH v10 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-05-11 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other d

[PATCH v10 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

2016-05-11 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other d

Re: [PATCH net-next v3 1/4] xen-netback: add control ring boilerplate

2016-05-11 Thread Wei Liu
On Wed, May 11, 2016 at 04:33:34PM +0100, Paul Durrant wrote: > My recent patch to include/xen/interface/io/netif.h defines a new shared > ring (in addition to the rx and tx rings) for passing control messages > from a VM frontend driver to a backend driver. > > This patch adds the necessary code

Re: [PATCH net-next v3 2/4] xen-netback: add control protocol implementation

2016-05-11 Thread Wei Liu
On Wed, May 11, 2016 at 04:33:35PM +0100, Paul Durrant wrote: > My recent patch to include/xen/interface/io/netif.h defines a new shared > ring (in addition to the rx and tx rings) for passing control messages > from a VM frontend driver to a backend driver. > > A previous patch added the necessar

[PATCH net-next v3 4/4] xen-netback: use hash value from the frontend

2016-05-11 Thread Paul Durrant
My recent patch to include/xen/interface/io/netif.h defines a new extra info type that can be used to pass hash values between backend and guest frontend. This patch adds code to xen-netback to use the value in a hash extra info fragment passed from the guest frontend in a transmit-side (i.e. netb

Re: [RFC PATCH 0/2] net: threadable napi poll loop

2016-05-11 Thread Eric Dumazet
On Wed, 2016-05-11 at 07:40 -0700, Eric Dumazet wrote: > On Wed, May 11, 2016 at 6:13 AM, Hannes Frederic Sowa > wrote: > > > This looks racy to me as the ksoftirqd could be in the progress to stop > > and we would miss another softirq invocation. > > Looking at smpboot_thread_fn(), it looks fin

[PATCH net-next v3 0/4] xen-netback: support for control ring

2016-05-11 Thread Paul Durrant
My recent patch to import an up-to-date include/xen/interface/io/netif.h from the Xen Project brought in the necessary definitions to support the new control shared ring and protocol. This patch series updates xen-netback to support the new ring. Patch #1 adds the necessary boilerplate to map the

[PATCH net-next v3 3/4] xen-netback: pass hash value to the frontend

2016-05-11 Thread Paul Durrant
My recent patch to include/xen/interface/io/netif.h defines a new extra info type that can be used to pass hash values between backend and guest frontend. This patch adds code to xen-netback to pass hash values calculated for guest receive-side packets (i.e. netback transmit side) to the frontend.

[PATCH net-next v3 1/4] xen-netback: add control ring boilerplate

2016-05-11 Thread Paul Durrant
My recent patch to include/xen/interface/io/netif.h defines a new shared ring (in addition to the rx and tx rings) for passing control messages from a VM frontend driver to a backend driver. This patch adds the necessary code to xen-netback to map this new shared ring, should it be created by a fr

[PATCH net-next v3 2/4] xen-netback: add control protocol implementation

2016-05-11 Thread Paul Durrant
My recent patch to include/xen/interface/io/netif.h defines a new shared ring (in addition to the rx and tx rings) for passing control messages from a VM frontend driver to a backend driver. A previous patch added the necessary boilerplate for mapping the control ring from the frontend, should it

[PATCH nf V2] netfilter: fix oops in nfqueue during netns error unwinding

2016-05-11 Thread Florian Westphal
Under full load (unshare() in loop -> OOM conditions) we can get kernel panic: BUG: unable to handle kernel NULL pointer dereference at 0008 IP: [] nfqnl_nf_hook_drop+0x35/0x70 [..] task: 88012dfa3840 ti: 88012dffc000 task.ti: 88012dffc000 RIP: 0010:[] [] nfqnl_nf_hook_dr

RE: [PATCH net-next v2 2/4] xen-netback: add control protocol implementation

2016-05-11 Thread Paul Durrant
> -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 11 May 2016 16:16 > To: xen-de...@lists.xenproject.org; netdev@vger.kernel.org > Cc: Paul Durrant; Wei Liu > Subject: [PATCH net-next v2 2/4] xen-netback: add control protocol > implementation > > My recent

[PATCH net-next v2 1/4] xen-netback: add control ring boilerplate

2016-05-11 Thread Paul Durrant
My recent patch to include/xen/interface/io/netif.h defines a new shared ring (in addition to the rx and tx rings) for passing control messages from a VM frontend driver to a backend driver. This patch adds the necessary code to xen-netback to map this new shared ring, should it be created by a fr

[PATCH net-next v2 0/4] xen-netback: support for control ring

2016-05-11 Thread Paul Durrant
My recent patch to import an up-to-date include/xen/interface/io/netif.h from the Xen Project brought in the necessary definitions to support the new control shared ring and protocol. This patch series updates xen-netback to support the new ring. Patch #1 adds the necessary boilerplate to map the

[PATCH net-next v2 4/4] xen-netback: use hash value from the frontend

2016-05-11 Thread Paul Durrant
My recent patch to include/xen/interface/io/netif.h defines a new extra info type that can be used to pass hash values between backend and guest frontend. This patch adds code to xen-netback to use the value in a hash extra info fragment passed from the guest frontend in a transmit-side (i.e. netb

[PATCH net-next v2 2/4] xen-netback: add control protocol implementation

2016-05-11 Thread Paul Durrant
My recent patch to include/xen/interface/io/netif.h defines a new shared ring (in addition to the rx and tx rings) for passing control messages from a VM frontend driver to a backend driver. A previous patch added the necessary boilerplate for mapping the control ring from the frontend, should it

[PATCH net-next v2 3/4] xen-netback: pass hash value to the frontend

2016-05-11 Thread Paul Durrant
My recent patch to include/xen/interface/io/netif.h defines a new extra info type that can be used to pass hash values between backend and guest frontend. This patch adds code to xen-netback to pass hash values calculated for guest receive-side packets (i.e. netback transmit side) to the frontend.

Re: [RFC PATCH 0/2] net: threadable napi poll loop

2016-05-11 Thread Rik van Riel
On Wed, 2016-05-11 at 07:40 -0700, Eric Dumazet wrote: > On Wed, May 11, 2016 at 6:13 AM, Hannes Frederic Sowa > wrote: > > > This looks racy to me as the ksoftirqd could be in the progress to > > stop > > and we would miss another softirq invocation. > > Looking at smpboot_thread_fn(), it looks

Re: [RFC PATCH 0/2] net: threadable napi poll loop

2016-05-11 Thread Eric Dumazet
On Wed, May 11, 2016 at 7:38 AM, Paolo Abeni wrote: > Uh, we have likely the same issue in the net_rx_action() function, which > also execute with bh disabled and check for jiffies changes even on > single core hosts ?!? That is why we have a loop break after netdev_budget=300 packets. And a sys

Re: [RFC PATCH 0/2] net: threadable napi poll loop

2016-05-11 Thread Eric Dumazet
On Wed, May 11, 2016 at 6:13 AM, Hannes Frederic Sowa wrote: > This looks racy to me as the ksoftirqd could be in the progress to stop > and we would miss another softirq invocation. Looking at smpboot_thread_fn(), it looks fine : if (!ht->thread_should_run(td->cpu)) {

Re: [RFC PATCH 0/2] net: threadable napi poll loop

2016-05-11 Thread Paolo Abeni
On Wed, 2016-05-11 at 06:08 -0700, Eric Dumazet wrote: > On Wed, 2016-05-11 at 11:48 +0200, Paolo Abeni wrote: > > Hi Eric, > > On Tue, 2016-05-10 at 15:51 -0700, Eric Dumazet wrote: > > > On Wed, 2016-05-11 at 00:32 +0200, Hannes Frederic Sowa wrote: > > > > > > > Not only did we want to present

Re: [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

2016-05-11 Thread Jiri Benc
On Wed, 11 May 2016 12:28:14 +0900, Simon Horman wrote: > I think that at this stage I would prefer to prohibit push_eth() acting > on a packet which already has an ethernet header. Indeed that is what > my patch-set already does in its modifications of __ovs_nla_copy_actions(). > > The reason tha

Re: [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

2016-05-11 Thread Jiri Benc
On Wed, 11 May 2016 12:06:35 +0900, Simon Horman wrote: > Is this close to what you had in mind? Yes but see below. > @@ -739,17 +729,17 @@ int ovs_flow_key_extract(const struct ip_tunnel_info > *tun_info, > key->phy.skb_mark = skb->mark; > ovs_ct_fill_key(skb, key); > key->ovs

[PATCH iproute2] ip link: Add support for kernel side filtering

2016-05-11 Thread David Ahern
Kernel gained support for filtering link dumps with commit dc599f76c22b ("net: Add support for filtering link dump by master device and kind"). Add support to ip link command. If a user passes master device or kind to ip link command they are added to the link dump request message. Signed-off-by:

Re: [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

2016-05-11 Thread Jiri Benc
On Wed, 11 May 2016 10:50:12 +0900, Simon Horman wrote: > On Tue, May 10, 2016 at 02:01:06PM +0200, Jiri Benc wrote: > > We have two options here: > > > > 1. As for metadata tunnels all the info is in metadata_dst and we > >don't need the IP/GRE header for anything, we can make the ipgre > >

[PATCH net-next] vxlan: set mac_header correctly in GPE mode

2016-05-11 Thread Jiri Benc
For VXLAN-GPE, the interface is ARPHRD_NONE, thus we need to reset mac_header after pulling the outer header. Fixes: e1e5314de08b ("vxlan: implement GPE") Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxla

[PATCH net] gre: do not keep the GRE header around in collect medata mode

2016-05-11 Thread Jiri Benc
For ipgre interface in collect metadata mode, it doesn't make sense for the interface to be of ARPHRD_IPGRE type. The outer header of received packets is not needed, as all the information from it is present in metadata_dst. We already don't set ipgre_header_ops for collect metadata interfaces, whi

Re: [RFC PATCH 0/2] net: threadable napi poll loop

2016-05-11 Thread Hannes Frederic Sowa
On 11.05.2016 15:39, Hannes Frederic Sowa wrote: > I am fine with that. It is us to show clear benefits or use cases for > that. If we fail with that, no problem at all that the patches get > rejected, we don't want to add bloat to the kernel, for sure! At this > point I still think a possibility t

Re: [RFC PATCH 0/2] net: threadable napi poll loop

2016-05-11 Thread Hannes Frederic Sowa
Hi all, On 11.05.2016 15:08, Eric Dumazet wrote: > On Wed, 2016-05-11 at 11:48 +0200, Paolo Abeni wrote: >> Hi Eric, >> On Tue, 2016-05-10 at 15:51 -0700, Eric Dumazet wrote: >>> On Wed, 2016-05-11 at 00:32 +0200, Hannes Frederic Sowa wrote: >>> Not only did we want to present this solely as

[PATCH net-next v2 12/14] qed*: IOV support spoof-checking

2016-05-11 Thread Yuval Mintz
Add support in `ndo_set_vf_spoofchk' for allowing PF control over its VF spoof-checking configuration. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 4 ++ drivers/net/ethernet/qlogic/qed/qed_l2.h | 2 + drivers/net/ethernet/qlogic/qed/qed_sriov.c | 91 +

[PATCH net-next v2 08/14] qede: Add VF support

2016-05-11 Thread Yuval Mintz
Adding a PCI callback for `sriov_configure' and a new PCI device id for the VF [+ Some minor changes to accomodate differences between PF and VF at the qede]. Following this, VF creation should be possible and the entire subset of existing PF functionality that's allow to VFs should be supported.

[PATCH net-next v2 11/14] qed*: IOV link control

2016-05-11 Thread Yuval Mintz
This adds support in 2 ndo that allow PF to tweak the VF's view of the link - `ndo_set_vf_link_state' to allow it a view independent of the PF's, and `ndo_set_vf_rate' which would allow the PF to limit the VF speed. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed.h|

[PATCH net-next v2 14/14] qed*: Tx-switching configuration

2016-05-11 Thread Yuval Mintz
Device should be configured by default to VEB once VFs are active. This changes the configuration of both PFs' and VFs' vports into enabling tx-switching once sriov is enabled. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 3 ++- drivers/net/ethernet/qlogic/

[PATCH net-next v2 06/14] qed: Bulletin and Link

2016-05-11 Thread Yuval Mintz
Up to this point, VF and PF communication always originates from VF. As a result, VF cannot be notified of any async changes, and specifically cannot be informed of the current link state. This introduces the bulletin board, the mechanism through which the PF is going to communicate async notifica

[PATCH net-next v2 10/14] qed*: Support forced MAC

2016-05-11 Thread Yuval Mintz
Allows the PF to enforce the VF's mac. i.e., by using `ip link ... vf mac '. While a MAC is forced, PF would prevent the VF from configuring any other MAC. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 9 ++ drivers/net/ethernet/qlogic/qed/qed_sriov.c | 120 +

[PATCH net-next v2 13/14] qed*: support ndo_get_vf_config

2016-05-11 Thread Yuval Mintz
Allows the user to view the VF configuration by observing the PF's device. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_sriov.c | 93 drivers/net/ethernet/qlogic/qede/qede_main.c | 12 include/linux/qed/qed_iov_if.h | 3 + 3

  1   2   >