On Wed, 11 May 2016 10:50:12 +0900, Simon Horman wrote: > On Tue, May 10, 2016 at 02:01:06PM +0200, Jiri Benc wrote: > > We have two options here: > > > > 1. As for metadata tunnels all the info is in metadata_dst and we > > don't need the IP/GRE header for anything, we can make the ipgre > > interface ARPHRD_NONE in metadata based mode. > > > > 2. We can fix this up in ovs after receiving the packet from > > ARPHRD_IPGRE interface. > > > > I think the first option is the correct one. We already don't assign > > dev->header_ops in metadata mode. I'll prepare a patch. > > I agree that 1. seems to be the better approach.
I just sent a patch that fixes this. And we have the same bug in VXLAN-GPE, I sent a patch, too. > Sure, if that is your preference I think it should be simple enough to > implement. I agree that netdev_port_receive() looks like a good place for > this. Great, thanks! Jiri
