Johannes Berg wrote:
>
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 215fc08c02ab..330ebd600f25 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -688,7 +688,7 @@ static int netlink_release(struct socket *sock)
>
>skb_queue_purge(&s
Julian Calaby writes:
> Hi Kalle,
>
> On Sat, Apr 16, 2016 at 4:25 AM, Kalle Valo wrote:
>> Byeoungwook Kim writes:
>>
>>> rtl_*_delay() functions were reused same codes about addr variable.
>>> So i have converted to rtl_addr_delay() from code about addr variable.
>>>
>>> Signed-off-by: Byeoun
From: Roopa Prabhu
This patch passes netlink attr data ptr directly to dev_get_stats
thus elimiating a stats copy.
Suggested-by: David Miller
Signed-off-by: Roopa Prabhu
---
net/core/rtnetlink.c | 23 ---
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/net/c
From: Roopa Prabhu
This patch adds a new RTM_GETSTATS message to query stats via netlink
from the kernel. RTM_NEWLINK also dumps link stats today, but RTM_NEWLINK
returns a lot more than just stats and is expensive in some cases when
frequent polling for stats from userspace is a common operation
From: Roopa Prabhu
This patch is an example of adding af stats in
RTM_GETSTATS. It adds a new nested IFLA_STATS_LINK_INET6
attribute for ipv6 af stats. stats attributes inside
IFLA_STATS_LINK_INET6 nested attribute use the existing ipv6
stats attributes from ipv6 IFLA_PROTINFO
Signed-off-by: Roo
From: Roopa Prabhu
This patch adds a new RTM_GETSTATS message to query stats via
netlink from the kernel. RTM_NEWLINK also dumps links stats today, but
RTM_NEWLINK returns a lot more than just stats and is expensive in some
cases when frequent polling for stats from userspace is a common operatio
From: Daniel Borkmann
Date: Sat, 16 Apr 2016 02:27:58 +0200
> When __vlan_insert_tag() fails from skb_vlan_push() path due to the
> skb_cow_head(), we need to undo the __skb_push() in the error path
> as well that was done earlier to move skb->data pointer to mac header.
>
> Moreover, I noticed
f1705ec197e7 added the option to retain user configured addresses on an
admin down. A comment to one of the later revisions suggested using the
IFA_F_PERMANENT flag rather than adding a user_managed boolean to the
ifaddr struct. A side effect of this change is that link local and
loopback addresses
Hi Kalle,
On Sat, Apr 16, 2016 at 4:25 AM, Kalle Valo wrote:
> Byeoungwook Kim writes:
>
>> rtl_*_delay() functions were reused same codes about addr variable.
>> So i have converted to rtl_addr_delay() from code about addr variable.
>>
>> Signed-off-by: Byeoungwook Kim
>> Reviewed-by: Julian C
> -Original Message-
> From: KY Srinivasan
> Sent: Friday, April 15, 2016 9:01 AM
> To: 'Alexander Duyck'
> Cc: David Miller ; Netdev
> ; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; Robo Bot
> ; Jason Wang ;
> e...@mellanox.com; ja...@mellanox.com; yevge
When __vlan_insert_tag() fails from skb_vlan_push() path due to the
skb_cow_head(), we need to undo the __skb_push() in the error path
as well that was done earlier to move skb->data pointer to mac header.
Moreover, I noticed that when in the non-error path the __skb_pull()
is done and the origina
From: Weidong Wang
Date: Thu, 14 Apr 2016 15:43:52 +0800
> When tested the PHY SGMII Loopback:
> 1.set the LOOPBACK bit,
> 2.set the autoneg to AUTONEG_DISABLE, it calls the
> genphy_setup_forced which will clear the bit.
>
> The BMCR_LOOPBACK bit should be preserved.
>
> As Florian pointed out
On Fri, Apr 15, 2016 at 07:21:28PM -0400, Vivien Didelot wrote:
> ps->id is not needed anymore, so remove it as well as the related
> defined values.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Thanks
Andrew
On Fri, Apr 15, 2016 at 07:21:27PM -0400, Vivien Didelot wrote:
> Add the number of databases to the info structure.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Thanks
Andrew
On Fri, Apr 15, 2016 at 07:21:26PM -0400, Vivien Didelot wrote:
> Drop the ps->num_ports variable for a new member of the info structure.
> This removes the need to assign it at setup time.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Thanks
Andrew
On Fri, Apr 15, 2016 at 07:21:25PM -0400, Vivien Didelot wrote:
> Add an mv88e6xxx_family enum to the info structure for better family
> indentification.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Andrew
> + for (i = 0, info = &table[i]; i < num; info = &table[++i])
> + if (info->prod_num == (id & 0xfff0) >> 4)
> + goto found;
>
> return NULL;
> -}
>
> -char *mv88e6xxx_drv_probe(struct device *dsa_dev, struct device *host_dev,
> -
On Fri, 2016-04-15 at 16:05 -0700, Michael Ma wrote:
> Would definitely appreciate that. If you can share the patch it will
> be helpful as well. Let me know if I can help with this...
Sure, here is what I am going to test :
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_
On Fri, Apr 15, 2016 at 07:21:23PM -0400, Vivien Didelot wrote:
> There is no point in having special case for the revision when probing a
> switch model. The code gets cluttered with unnecessary defines, and
> leads to errors when code such as mv88e6131_setup compares
> PORT_SWITCH_ID_6131_B2 to p
On Fri, Apr 15, 2016 at 07:21:22PM -0400, Vivien Didelot wrote:
> Every driver assigns ps->ds even though it gets assigned in the shared
> mv88e6xxx_setup_common function. Kill redundancy.
>
> Signed-off-by: Vivien Didelot
Reviewed-by: Andrew Lunn
Thanks
Andrew
> ---
> drivers/net/ds
This patchset factorizes the mv88e6xxx code by sharing a new extendable
info structure to store static data such as switch family, product
number, number of ports, number of databases and the name.
The next step is to add a "flags" bitmap member to the info structure in
order to simplify the share
Add the number of databases to the info structure.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6123.c | 3 +++
drivers/net/dsa/mv88e6131.c | 4
drivers/net/dsa/mv88e6171.c | 4
drivers/net/dsa/mv88e6352.c | 6 ++
drivers/net/dsa/mv88e6xxx.c | 19 +--
ps->id is not needed anymore, so remove it as well as the related
defined values.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6xxx.c | 3 ---
drivers/net/dsa/mv88e6xxx.h | 32
2 files changed, 35 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx.c
Add an mv88e6xxx_family enum to the info structure for better family
indentification.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6123.c | 3 ++
drivers/net/dsa/mv88e6131.c | 4 +++
drivers/net/dsa/mv88e6171.c | 4 +++
drivers/net/dsa/mv88e6352.c | 6
drivers/net/dsa/mv88e6xx
Drop the ps->num_ports variable for a new member of the info structure.
This removes the need to assign it at setup time.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6123.c | 16 +++-
drivers/net/dsa/mv88e6131.c | 22 +-
drivers/net/dsa/mv88e6171.c | 7
Add a new switch info structure which will be later extended to store
switch models static information, such as product number, name, number
of ports, number of databases, etc.
Merge the lookup function in the probing code, so that we avoid multiple
checking of the MII bus, as well a multiple ID r
Every driver assigns ps->ds even though it gets assigned in the shared
mv88e6xxx_setup_common function. Kill redundancy.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6123.c | 2 --
drivers/net/dsa/mv88e6131.c | 2 --
drivers/net/dsa/mv88e6171.c | 2 --
drivers/net/dsa/mv88e6352.c | 2 -
There is no point in having special case for the revision when probing a
switch model. The code gets cluttered with unnecessary defines, and
leads to errors when code such as mv88e6131_setup compares
PORT_SWITCH_ID_6131_B2 to ps->id which mask the revision.
Drop every revision definitions, add a p
2016-04-15 15:54 GMT-07:00 Eric Dumazet :
> On Fri, 2016-04-15 at 15:46 -0700, Michael Ma wrote:
>> 2016-04-08 7:19 GMT-07:00 Eric Dumazet :
>> > On Thu, 2016-03-31 at 16:48 -0700, Michael Ma wrote:
>> >> I didn't really know that multiple qdiscs can be isolated using MQ so
>> >> that each txq can
On Fri, 2016-04-15 at 15:46 -0700, Michael Ma wrote:
> 2016-04-08 7:19 GMT-07:00 Eric Dumazet :
> > On Thu, 2016-03-31 at 16:48 -0700, Michael Ma wrote:
> >> I didn't really know that multiple qdiscs can be isolated using MQ so
> >> that each txq can be associated with a particular qdisc. Also we d
On 15/04/16 04:50, Fugang Duan wrote:
From: Philippe Reynes Sent: Friday, April 15, 2016 6:35 AM
To: da...@davemloft.net; de...@googlers.com; f.faine...@gmail.com; Fugang
Duan
Cc: linux-ker...@vger.kernel.org; netdev@vger.kernel.org; Philippe Reynes
Subject: [PATCH 2/3] phy: add generic functi
2016-04-08 7:19 GMT-07:00 Eric Dumazet :
> On Thu, 2016-03-31 at 16:48 -0700, Michael Ma wrote:
>> I didn't really know that multiple qdiscs can be isolated using MQ so
>> that each txq can be associated with a particular qdisc. Also we don't
>> really have multiple interfaces...
>>
>> With this MQ
On 16/04/2016 at 00:30:26 +0200, Andrew Lunn wrote :
> On Sat, Apr 16, 2016 at 12:17:11AM +0200, Alexandre Belloni wrote:
> > On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote :
> > > > Trace without my patch:
> > > > libphy: MACB_mii_bus: probed
> > > > macb f802.ethernet eth0: Cadence GEM re
On 04/15/2016 02:02 PM, Butler, Peter wrote:
(Please keep me CC'd to all comments/responses)
I've tried a kernel upgrade from 3.4.2 to 4.4.0 and see a marked drop
in networking performance. Nothing was changed on the test systems,
other than the kernel itself (and kernel modules). The identica
On Fri, 2016-04-15 at 21:02 +, Butler, Peter wrote:
> (Please keep me CC'd to all comments/responses)
>
> I've tried a kernel upgrade from 3.4.2 to 4.4.0 and see a marked drop in
> networking performance. Nothing was changed on the test systems, other than
> the kernel itself (and kernel mo
On Sat, Apr 16, 2016 at 12:17:11AM +0200, Alexandre Belloni wrote:
> On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote :
> > > Trace without my patch:
> > > libphy: MACB_mii_bus: probed
> > > macb f802.ethernet eth0: Cadence GEM rev 0x00020120 at 0xf802 irq
> > > 27 (fc:c2:3d:0c:6e:05)
>
On 15/04/16 15:17, Alexandre Belloni wrote:
> On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote :
>>> Trace without my patch:
>>> libphy: MACB_mii_bus: probed
>>> macb f802.ethernet eth0: Cadence GEM rev 0x00020120 at 0xf802 irq
>>> 27 (fc:c2:3d:0c:6e:05)
>>> Micrel KSZ8081 or KSZ8091 f80
On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote :
> > Trace without my patch:
> > libphy: MACB_mii_bus: probed
> > macb f802.ethernet eth0: Cadence GEM rev 0x00020120 at 0xf802 irq
> > 27 (fc:c2:3d:0c:6e:05)
> > Micrel KSZ8081 or KSZ8091 f802.etherne:01: attached PHY driver [Micrel
(Please keep me CC'd to all comments/responses)
I've tried a kernel upgrade from 3.4.2 to 4.4.0 and see a marked drop in
networking performance. Nothing was changed on the test systems, other than
the kernel itself (and kernel modules). The identical .config used to build
the 3.4.2 kernel was
> Trace without my patch:
> libphy: MACB_mii_bus: probed
> macb f802.ethernet eth0: Cadence GEM rev 0x00020120 at 0xf802 irq 27
> (fc:c2:3d:0c:6e:05)
> Micrel KSZ8081 or KSZ8091 f802.etherne:01: attached PHY driver [Micrel
> KSZ8081 or KSZ8091] (mii_bus:phy_addr=f802.etherne:01, i
On Fri, Apr 15, 2016 at 05:00:50PM -0400, Vivien Didelot wrote:
> Hi Andrew,
>
> Andrew Lunn writes:
>
>
>
> >> -#define PORT_SWITCH_ID_6350 0x3710
> >> -#define PORT_SWITCH_ID_6351 0x3750
> >> -#define PORT_SWITCH_ID_6352 0x3520
> >
> > NACK
> >
> > These numbers are not obv
On 15.04.2016 22:36, David Miller wrote:
From: Hannes Frederic Sowa
Date: Fri, 8 Apr 2016 22:55:01 +0200
@@ -1053,7 +1052,9 @@ static void __vxlan_sock_release(struct vxlan_sock *vs)
vxlan_notify_del_rx_port(vs);
spin_unlock(&vn->sock_lock);
- queue_work(vxlan_wq, &vs->
Em 15-04-2016 17:58, Stephen Hemminger escreveu:
On Sat, 09 Apr 2016 01:55:06 +0200
Hannes Frederic Sowa wrote:
On Sat, Apr 9, 2016, at 01:24, Cong Wang wrote:
On Fri, Apr 8, 2016 at 1:55 PM, Hannes Frederic Sowa
wrote:
Due to the fact that the udp socket is destructed asynchronously in a
From: Xin Long
Date: Thu, 14 Apr 2016 15:35:29 +0800
> This patchset will add sctp_diag module to implement diag interface on
> sctp in kernel.
...
Looks good to me, series applied, thanks.
Please follow up on the suggestion to use jiffies_to_ms(), thanks.
From: Xin Long
Date: Thu, 14 Apr 2016 15:35:30 +0800
> sctp_diag will dump some important details of sctp's assoc or ep, we use
> sctp_info to describe them, sctp_get_sctp_info to get them, and export
> it to sctp_diag.ko.
>
> v2->v3:
> - we will not use list_for_each_safe in sctp_get_sctp_info
From: Saeed Mahameed
Date: Fri, 15 Apr 2016 20:10:07 +0300
> On Wed, Apr 13, 2016 at 7:11 PM, Saeed Mahameed wrote:
>> Hi Dave and Doug
>>
>> Changes form V0:
>> - 2nd patch commit message fixes.
>>
>> This series include mlx5_core updates for both net-next and rdma
>> trees for 4.7 kern
From: Marcelo Ricardo Leitner
Date: Wed, 13 Apr 2016 19:12:29 -0300
> SCTP already serializes access to rcvbuf through its sock lock:
> sctp_recvmsg takes it right in the start and release at the end, while
> rx path will also take the lock before doing any socket processing. On
> sctp_rcv() it w
From: Manish Chopra
Date: Thu, 14 Apr 2016 01:38:28 -0400
> This patch series adds support for VXLAN, GRE and GENEVE tunnels
> to be used over this driver. With this support, adapter can perform
> TSO offload, inner/outer checksums offloads on TX and RX for
> encapsulated packets.
>
> V1->V2 [ C
From: Peter Heise
Date: Wed, 13 Apr 2016 13:52:22 +0200
> This patch adds support for the newer version 1 of the HSR
> networking standard. Version 0 is still default and the new
> version has to be selected via iproute2.
>
> Main changes are in the supervision frame handling and its
> ethertype
Vivien Didelot writes:
>>> + { MV88E6XXX_INFO(6165, 0x165, "Marvell 88E6165") },
>>
>> I think
>>
>>> + { MV88E6XXX_INFO(MV88E6XXX_FAMILY_6165, 0x165, "Marvell 88E6165") },
>>
>> is clearer. It is hard to know what these values mean unless you go
>> look at the macro.
>
> Same goes for the M
Hi Andrew,
Andrew Lunn writes:
>> -#define PORT_SWITCH_ID_6350 0x3710
>> -#define PORT_SWITCH_ID_6351 0x3750
>> -#define PORT_SWITCH_ID_6352 0x3520
>
> NACK
>
> These numbers are not obvious. PORT_SWITCH_ID_6320 i can
> understand. 0x1150 i have no idea what it is.
0x1150 is not even correct.
On Sat, 09 Apr 2016 01:55:06 +0200
Hannes Frederic Sowa wrote:
>
>
> On Sat, Apr 9, 2016, at 01:24, Cong Wang wrote:
> > On Fri, Apr 8, 2016 at 1:55 PM, Hannes Frederic Sowa
> > wrote:
> > > Due to the fact that the udp socket is destructed asynchronously in a
> > > work queue, we have some no
On 15/04/2016 at 13:10:12 -0700, Florian Fainelli wrote :
> On 15/04/16 12:56, Alexandre Belloni wrote:
> > Commit d5c3d84657db ("net: phy: Avoid polling PHY with
> > PHY_IGNORE_INTERRUPTS") removed the last polling done on the phy. Since
> > then, the last actual poll done on the phy happens PHY_S
From: Eric Dumazet
Date: Wed, 13 Apr 2016 22:05:38 -0700
> In the first patch, I remove the costly association of SYNACK+COOKIES
> to a listener. I believe other parts of the stack should be ready.
>
> The second patch removes a useless write into listener socket
> in tcp_rcv_state_process(), in
From: Amitoj Kaur Chawla
Date: Sat, 9 Apr 2016 17:27:45 +0530
> Replace deprecated create_singlethread_workqueue with
> alloc_ordered_workqueue.
>
> Work items include getting tx/rx frame sizes, resetting MPI processor,
> setting asic recovery bit so ordering seems necessary as only one work
> i
From: Hannes Frederic Sowa
Date: Fri, 8 Apr 2016 22:55:01 +0200
> @@ -1053,7 +1052,9 @@ static void __vxlan_sock_release(struct vxlan_sock *vs)
> vxlan_notify_del_rx_port(vs);
> spin_unlock(&vn->sock_lock);
>
> - queue_work(vxlan_wq, &vs->del_work);
> + synchronize_net();
>
Support checksum neutral ILA as described in the ILA draft. The low
order 16 bits of the identifier are used to contain the checksum
adjustment value.
The csum-mode parameter is added to described checksum processing. There
are three values:
- adjust transport checksum (previous behavior)
- do c
Change model of xlat to be used only for input where lookup is done on
the locator part of an address (comparing to locator_match as key
in rhashtable). This is needed for checksum neutral translation
which obfuscates the low order 16 bits of the identifier. It also
permits hosts to be in muliple I
This patch set updates ILA to support draft-herbert-nvo3-ila-02. The
primary addition is support checksum neutral ILA translation.
This allows address to be performed and still keep any transport
layer checksums that include the addresses in their pseudo header to
still be correct without the trans
Add structures for identifiers, locators, and an ila address which
is composed of a locator and identifier and in6_addr can be cast to
it. This includes a three bit type field and enums for the types defined
in ILA I-D.
In ILA lwt don't allow user to set a translation for a non-ILA
address (type o
On Fri, Apr 15, 2016 at 04:24:26PM -0400, Vivien Didelot wrote:
> Hi Andrew,
>
> Andrew Lunn writes:
>
> > On Fri, Apr 15, 2016 at 02:25:49PM -0400, Vivien Didelot wrote:
> >> Move the number of databases to the info structure.
> >
> > Isn't the number of databases a property of the family?
>
>
Hi Andrew,
Andrew Lunn writes:
> On Fri, Apr 15, 2016 at 02:25:49PM -0400, Vivien Didelot wrote:
>> Move the number of databases to the info structure.
>
> Isn't the number of databases a property of the family?
No.
We've seen [1] for instance that 6061 and 6065 are both part of the 6065
famil
On 15/04/16 12:56, Alexandre Belloni wrote:
> Commit d5c3d84657db ("net: phy: Avoid polling PHY with
> PHY_IGNORE_INTERRUPTS") removed the last polling done on the phy. Since
> then, the last actual poll done on the phy happens PHY_STATE_TIME seconds
> (that is actually one second) after registerin
From: Jon Maloy
Date: Fri, 15 Apr 2016 13:33:02 -0400
> This series addresses some smaller issues regarding the link setup
> algorithm. The first commit fixes a rare bug we have discovered during
> testing; the second one may have some future impact on cluster
> scalabilty, while remaining ones
Commit d5c3d84657db ("net: phy: Avoid polling PHY with
PHY_IGNORE_INTERRUPTS") removed the last polling done on the phy. Since
then, the last actual poll done on the phy happens PHY_STATE_TIME seconds
(that is actually one second) after registering the phy. If the interface
is not UP by that time,
Hi Mel,
I did an experiment that you might find interesting. Using Brenden's
early drop with eBPF in the mxl4 driver. I changed the mlx4 driver to
use order-0 pages. It usually use order-3 pages to amortize the cost
of calling the page allocator (which is problematic for other reasons,
like mem
> --- a/drivers/net/dsa/mv88e6xxx.c
> +++ b/drivers/net/dsa/mv88e6xxx.c
> @@ -2663,11 +2663,15 @@ int mv88e6xxx_setup_ports(struct dsa_switch *ds)
> int mv88e6xxx_setup_common(struct dsa_switch *ds)
> {
> struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
> + int id;
>
> ps->ds =
On Fri, Apr 15, 2016 at 02:25:50PM -0400, Vivien Didelot wrote:
> We already have the product number and revision stored in the info
> structure and the switch private state.
>
> It is not necessary to clutter the header file with shifted product
> number for devices that we don't even support yet
On Fri, Apr 15, 2016 at 02:25:49PM -0400, Vivien Didelot wrote:
> Move the number of databases to the info structure.
Isn't the number of databases a property of the family?
I would add a table indexed by family.
Andrew
From: Govindarajulu Varadarajan <_gov...@gmx.com>
Driver sets vlan_feature to netdev->features as hardware supports all of
them on vlan interface.
Signed-off-by: Govindarajulu Varadarajan <_gov...@gmx.com>
---
drivers/net/ethernet/cisco/enic/enic_main.c | 1 +
1 file changed, 1 insertion(+)
dif
On Fri, Apr 15, 2016 at 02:25:46PM -0400, Vivien Didelot wrote:
> Add a new switch info structure which will be later extended to store
> switch models static information, such as product number, name, number
> of ports, number of databases, etc.
>
> Merge the lookup function in the probing code,
On Fri, Apr 15, 2016 at 02:25:47PM -0400, Vivien Didelot wrote:
> Add an mv88e6xxx_family enum to the info structure for better family
> indentification.
>
> Signed-off-by: Vivien Didelot
> ---
> drivers/net/dsa/mv88e6123.c | 6 ++--
> drivers/net/dsa/mv88e6131.c | 8 ++---
> drivers/net/dsa/m
Hi my name is Mitchell H Peacock. I'm an American soldier currently in Syria
fighting IS. This might be a little strange for you but Its very lonely out
here. I miss normal human interaction and being loved by someone so I would
love to get to know you and keep in touch with you. I'm loving, Fun
On Fri, Apr 15, 2016 at 12:41:05PM +0200, Daniel Borkmann wrote:
> Hi Quentin,
>
> On 04/15/2016 12:07 PM, Quentin Monnet wrote:
> >When a new BPF traffic control filter or action is set up with tc, the
> >bytecode is sent back to userspace through a netlink socket for cBPF, but
> >not for eBPF (t
Add an mv88e6xxx_family enum to the info structure for better family
indentification.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6123.c | 6 ++--
drivers/net/dsa/mv88e6131.c | 8 ++---
drivers/net/dsa/mv88e6171.c | 8 ++---
drivers/net/dsa/mv88e6352.c | 12
drivers/net/ds
This patchset factorizes drastically the mv88e6xxx code by sharing a new
extendable info structure to store static data such as switch family,
product number, number of ports, number of databases and the name.
The next step is to add a "features" bitmap member to the info structure
in order to sim
Add a new switch info structure which will be later extended to store
switch models static information, such as product number, name, number
of ports, number of databases, etc.
Merge the lookup function in the probing code, so that we avoid multiple
checking of the MII bus, as well a multiple ID r
Every driver assigns ps->ds even though it gets assigned in the shared
mv88e6xxx_setup_common function. Kill redundancy.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6123.c | 2 --
drivers/net/dsa/mv88e6131.c | 2 --
drivers/net/dsa/mv88e6171.c | 2 --
drivers/net/dsa/mv88e6352.c | 2 -
Move the number of databases to the info structure.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6123.c | 6 +++---
drivers/net/dsa/mv88e6131.c | 8
drivers/net/dsa/mv88e6171.c | 8
drivers/net/dsa/mv88e6352.c | 12 ++--
drivers/net/dsa/mv88e6xxx.c | 19 +--
Drop the ps->num_ports variable for a new member of the info structure.
This removes the need to assign it at setup time.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6123.c | 19 +++
drivers/net/dsa/mv88e6131.c | 26 +-
drivers/net/dsa/mv88e6171
We already have the product number and revision stored in the info
structure and the switch private state.
It is not necessary to clutter the header file with shifted product
number for devices that we don't even support yet. Remove them.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6
There is no point in having special case for the revision when probing a
switch model. The code gets cluttered with unnecessary defines, and
leads to errors when code such as mv88e6131_setup compares
PORT_SWITCH_ID_6131_B2 to ps->id which mask the revision.
Drop every revision definitions, add a p
Byeoungwook Kim writes:
> rtl_*_delay() functions were reused same codes about addr variable.
> So i have converted to rtl_addr_delay() from code about addr variable.
>
> Signed-off-by: Byeoungwook Kim
> Reviewed-by: Julian Calaby
Doesn't apply:
Applying: rtlwifi: Fix reusable codes in core.c
Bjorn Andersson wrote:
Your driver is a platform driver and it's being probed from DT. As such
all this is already taken care of for you, by the core.
The listing is for your reference to know why the dma-ranges property
would affect your device.
Ah, sorry. I misunderstood what you meant by "y
[+cc Hannes, Ariel, LKML]
On Thu, Apr 14, 2016 at 11:42:05PM +0530, Hariprasad Shenai wrote:
> commit 104daa71b396 ("PCI: Determine actual VPD size on first access")
> introduced a regression in cxgb4 driver and used to fail in pci probe.
>
> The problem is stemming from the fact that the Chelsio
| From: Steve Wise
| Sent: Friday, April 15, 2016 9:12 AM
|
| On 4/14/2016 1:35 PM, Steve Wise wrote:
| >> The fix is to add a PCI helper function to set the VPD size, so the
| >> driver can expicitly set the exact size of the VPD.
| >>
| >> Fixes commit 104daa71b396 ("PCI: Determine actual VPD si
From: Craig Gallek
With the SO_REUSEPORT socket option, it is possible to create sockets
in the AF_INET and AF_INET6 domains which are bound to the same IPv4 address.
This is only possible with SO_REUSEPORT and when not using IPV6_V6ONLY on
the AF_INET6 sockets.
Prior to the commits referenced b
From: Eric Dumazet
On 64bit kernels, device stats are 64bit wide, not 32bit.
Fixes: 1c1008c793fa4 ("net: bcmgenet: add main driver file")
Signed-off-by: Eric Dumazet
Cc: Florian Fainelli
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c |6 +-
1 file changed, 5 insertions(+), 1 delet
According to the link FSM, a received traffic packet can take a link
from state ESTABLISHING to ESTABLISHED, but the link can still not be
fully set up in one atomic operation. This means that even if the the
very first packet on the link is a traffic packet with sequence number
1 (one), it has to
When a link endpoint is going down locally, e.g., because its interface
is being stopped, it will spontaneously send out a RESET message to
its peer, informing it about this fact. This saves the peer from
detecting the failure via probing, and hence gives both speedier and
less resource consuming f
The function tipc_link_timeout() is unnecessary complex, and can
easily be made more readable.
We do that with this commit. The only functional change is that we
remove a redundant test for whether the broadcast link is up or not.
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/link.c
When a link is down, it will continuously try to re-establish contact
with the peer by sending out a RESET or an ACTIVATE message at each
timeout interval. The default value for this interval is currently
375 ms. This is wasteful, and may become a problem in very large
clusters with dozens or hundr
In some link establishment scenarios we see that packet #2 may be sent
out before packet #1, forcing the receiver to demand retransmission of
the missing packet. This is harmless, but may cause confusion among
people tracing the packet flow.
Since this is extremely easy to fix, we do so by adding
This series addresses some smaller issues regarding the link setup
algorithm. The first commit fixes a rare bug we have discovered during
testing; the second one may have some future impact on cluster
scalabilty, while remaining ones can be regarded as cosmetic in
a wider sense of the word.
Jon
On Fri 15 Apr 10:00 PDT 2016, Timur Tabi wrote:
> Bjorn Andersson wrote:
> >For platform devices being populated via from DT you will pass:
> >of_platform_bus_create()
> > of_platform_device_create_pdata()
> > of_dma_configure()
> >
> >Which calls of_dma_get_range() to acquire this informati
Cc: Jakub Sitnicki
Signed-off-by: Phil Sutter
---
drivers/staging/rtl8188eu/os_dep/mon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mon.c
b/drivers/staging/rtl8188eu/os_dep/mon.c
index 63bb87593af0c..d976e5e18d50e 100644
--- a/drivers/st
From: Eric Dumazet
Date: Fri, 15 Apr 2016 07:58:48 -0700
> Having some hidden qdiscs is the real problem here.
+1
Rob Herring wrote:
You may only care about the size, but the binding has to handle the
more complex case. Here's an example
<0x0 0x2 0x0 0x1 0x0>
dma address 0 (cell 0) maps to cpu (parent) address 0x2_ (cell
1-2) and the range/size is 4G (cell 3-4).
If you have the same base address,
The following series converts two further drivers away from setting
'tx_queue_len = 0' to adding IFF_NO_QUEUE to priv_flags instead.
The first one, rtl8188eu in staging didn't exist back when all drivers
were converted. The second one, openvswitch seems to have slipped through
my grep'ing back the
Cc: Pravin Shelar
Signed-off-by: Phil Sutter
---
net/openvswitch/vport-internal_dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/openvswitch/vport-internal_dev.c
b/net/openvswitch/vport-internal_dev.c
index 7c8b90bf0e540..2ee48e447b724 100644
--- a/net/openvswitch
1 - 100 of 149 matches
Mail list logo
