From: Francois Romieu
Date: Fri, 25 Mar 2016 23:53:25 +0100
> Been there. Such requests are usually left unanswered. :o(
Due to this patch submitters continued anti-social and anti-community
behavior, I have been completely ignoring their patches.
I will continue to mark all of their patch subm
On 03/25/2016 06:58 PM, Patrick Uiterwijk wrote:
On Sat, Mar 26, 2016 at 2:45 AM, Guenter Roeck wrote:
On 03/25/2016 05:10 PM, Patrick Uiterwijk wrote:
Add versions of the phy_page_read and _write functions to
be used in a context where the SMI mutex is held.
Signed-off-by: Patrick Uiterwijk
On Sat, Mar 26, 2016 at 2:45 AM, Guenter Roeck wrote:
> On 03/25/2016 05:10 PM, Patrick Uiterwijk wrote:
>>
>> Add versions of the phy_page_read and _write functions to
>> be used in a context where the SMI mutex is held.
>>
>> Signed-off-by: Patrick Uiterwijk
>> ---
>> drivers/net/dsa/mv88e6xx
On Fri, Mar 25, 2016 at 03:29:24PM -0700, Eric Dumazet wrote:
> Tom Herbert would like to avoid touching UDP socket refcnt for encapsulated
> traffic. For this to happen, we need to use normal RCU rules, with a grace
> period before freeing a socket. UDP sockets are not short lived in the
> high us
On 03/25/2016 05:10 PM, Patrick Uiterwijk wrote:
Add versions of the phy_page_read and _write functions to
be used in a context where the SMI mutex is held.
Signed-off-by: Patrick Uiterwijk
---
drivers/net/dsa/mv88e6xxx.c | 42 --
1 file changed, 32 in
Fix variable assignment inside if statement. It is error-prone and hard to read.
Signed-off-by: Cosmin-Gabriel Samoila
---
drivers/isdn/hisax/isac.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/isdn/hisax/isac.c b/drivers/isdn/hisax/isac.c
index 7f
On Fri, Mar 25, 2016 at 04:55:27PM -0700, Martin KaFai Lau wrote:
> void ip6_sk_update_pmtu(struct sk_buff *skb, struct sock *sk, __be32 mtu)
> {
> + struct dst_entry *odst;
> +
> + odst = sk_dst_get(sk);
> +
> ip6_update_pmtu(skb, sock_net(sk), mtu,
> sk->sk_b
Add versions of the phy_page_read and _write functions to
be used in a context where the SMI mutex is held.
Signed-off-by: Patrick Uiterwijk
---
drivers/net/dsa/mv88e6xxx.c | 42 --
1 file changed, 32 insertions(+), 10 deletions(-)
diff --git a/drivers/ne
Some of the vendor-specific bootloaders set up this part
of the initialization for us, so this was never added.
However, since upstream bootloaders don't initialize the
chip specifically, they leave the fiber MII's PDOWN flag
set, which means that the CPU port doesn't connect.
This patch checks wh
On Fri, Mar 25, 2016 at 3:29 PM, Eric Dumazet wrote:
> We want a generic way to insert an RCU grace period before socket
> freeing for cases where RCU_SLAB_DESTROY_BY_RCU is adding too
> much overhead.
>
> SLAB_DESTROY_BY_RCU strict rules force us to take a reference
> on the socket sk_refcnt, and
On Fri, Mar 25, 2016 at 3:29 PM, Eric Dumazet wrote:
> Tom Herbert would like to avoid touching UDP socket refcnt for encapsulated
> traffic. For this to happen, we need to use normal RCU rules, with a grace
> period before freeing a socket. UDP sockets are not short lived in the
> high usage case
On Wed, Mar 23, 2016 at 04:57:22PM -0700, Wei Wang wrote:
> What about something like this:
>
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index ed44663..21b4102 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -1394,6 +1394,19 @@ static void ip6_rt_update_pmtu(struct dst_entry
On Fri, Mar 25, 2016 at 11:53:25PM +0100, Francois Romieu wrote:
> Phil Sutter :
> [...]
> > Your patch submissions are getting better, also good to see you're
> > finally using git-send-email. A few things need to be corrected though:
> >
>
> #define BMCR_RESV 0x003f /* Unused...
On 03/25/2016 04:03 PM, Vijay Pandurangan wrote:
On Fri, Mar 25, 2016 at 6:23 PM, Ben Greear wrote:
On 03/25/2016 02:59 PM, Vijay Pandurangan wrote:
consider two scenarios, where process a sends raw ethernet frames
containing UDP packets to b
I) process a --> veth --> process b
II) process
On Thu, Mar 24, 2016 at 6:39 PM, Willem de Bruijn
wrote:
>
> > This patch allows the user process to use MSG_EOR during
> > tcp_sendmsg to tell the kernel that it is the last byte
> > of an application response message.
> >
> > The user process can use the new SOF_TIMESTAMPING_TX_EOR to
> > ask th
On Fri, Mar 25, 2016 at 6:23 PM, Ben Greear wrote:
> On 03/25/2016 02:59 PM, Vijay Pandurangan wrote:
>>
>> consider two scenarios, where process a sends raw ethernet frames
>> containing UDP packets to b
>>
>> I) process a --> veth --> process b
>>
>> II) process a -> eth -> wire -> eth -> proces
Phil Sutter :
[...]
> Your patch submissions are getting better, also good to see you're
> finally using git-send-email. A few things need to be corrected though:
>
#define BMCR_RESV 0x003f /* Unused... */
#define BMCR_SPEED1000 0x0040 /* MSB of Speed (
On Fri, 2016-03-25 at 16:40 -0400, David Miller wrote:
> From: Tom Herbert
> Date: Wed, 23 Mar 2016 15:36:52 -0700
>
> > +{
> > + struct udp_sock *up = udp_sk(sk);
> > + int is_udplite = IS_UDPLITE(sk);
> > +
> > + int (*encap_rcv)(struct sock *sk, struct sk_buff *skb);
> > +
>
> Sma
Tom Herbert would like to avoid touching UDP socket refcnt for encapsulated
traffic. For this to happen, we need to use normal RCU rules, with a grace
period before freeing a socket. UDP sockets are not short lived in the
high usage case, so the added cost of call_rcu() should not be a concern.
Th
We want a generic way to insert an RCU grace period before socket
freeing for cases where RCU_SLAB_DESTROY_BY_RCU is adding too
much overhead.
SLAB_DESTROY_BY_RCU strict rules force us to take a reference
on the socket sk_refcnt, and it is a performance problem for UDP
encapsulation, or TCP synflo
Add a generic facility for sockets to be freed afer an RCU grace period.
Then UDP is changed to no longer use SLAB_DESTROY_BY_RCU,
in order to speedup rx processing for traffic encapsulated in UDP.
I prepared a patch to convert TCP listeners to this infrastructure,
but will post it later, since T
On 03/25/2016 12:25 AM, Tom Herbert wrote:
> On Wed, Mar 16, 2016 at 6:19 AM, Gilberto Bertin
> wrote:
>> This is my second attempt to submit an RFC for this patch.
>>
>> Some arguments for and against it since the first submission:
>> * SO_BINDTOSUBNET is an arbitrary option and can be seens as n
On 03/25/2016 02:59 PM, Vijay Pandurangan wrote:
consider two scenarios, where process a sends raw ethernet frames
containing UDP packets to b
I) process a --> veth --> process b
II) process a -> eth -> wire -> eth -> process b
I believe (I) is the simplest setup we can create that will replic
On Fri, Mar 25, 2016 at 2:59 PM, Vijay Pandurangan wrote:
> consider two scenarios, where process a sends raw ethernet frames
> containing UDP packets to b
>
> I) process a --> veth --> process b
>
> II) process a -> eth -> wire -> eth -> process b
>
> I believe (I) is the simplest setup we can cr
On Fri, Mar 25, 2016 at 1:56 PM, Ben Greear wrote:
> On 03/24/2016 10:33 PM, Cong Wang wrote:
>
>> Here we go:
>>
>> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
>> index 1ecfa71..ab66080 100644
>> --- a/net/packet/af_packet.c
>> +++ b/net/packet/af_packet.c
>> @@ -1925,6 +1925,7 @
From: Eric Dumazet
Blocking BH in __inet{6}_lookup() is not correct, as the lookups
are done using RCU protection.
It matters only starting from Lorenzo Colitti patches to destroy
a TCP socket, since rcu_read_lock() is already held by other users
of these functions.
This can be backported to al
On 03/25/2016 02:43 PM, Matthias Schiffer wrote:
We've tried your patch, and it changes the symptoms a bit, but doesn't fix
the panic. I've attached kernel logs of the crash both before and after
applying the patch.
One note: I did not reproduce this issue myself, it was first reported in
[1], a
From: Steve Shih
This patch fixes the issues for disabling auto-negotiation and forcing
speed and duplex settings for the fiber media.
For fiber media, e1000_get_settings should return ETH_TP_MDI_INVALID for
eth_tp_mdix_ctrl instead of ETH_TP_MDI_AUTO so subsequent e1000_set_settings
call would
consider two scenarios, where process a sends raw ethernet frames
containing UDP packets to b
I) process a --> veth --> process b
II) process a -> eth -> wire -> eth -> process b
I believe (I) is the simplest setup we can create that will replicate this bug.
If process a sends frames that conta
On Fri, Mar 25, 2016 at 10:35 AM, Ben Greear wrote:
>
>
> On 03/24/2016 10:24 PM, Vijay Pandurangan wrote:
>>
>> On Fri, Mar 25, 2016 at 1:07 AM, Ben Greear
>> wrote:
>>>
>>> On 03/24/2016 09:45 PM, Vijay Pandurangan wrote:
Actually, maybe they should be set to CHECKSUM_PARTIAL if
On 03/24/2016 10:33 PM, Cong Wang wrote:
Here we go:
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 1ecfa71..ab66080 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -1925,6 +1925,7 @@ static int packet_sendmsg_spkt(struct socket
*sock, struct msghdr *msg,
On 02/23/2016 11:29 PM, Andrew Collins wrote:
> I'm running into a relatively easily reproducible kernel panic related to
> the all_adj_list handling for netdevs
> in recent kernels.
>
> The following sequence of commands will reproduce the issue:
>
> ip link add link eth0 name eth0.100 type vlan
From: Tom Herbert
Date: Wed, 23 Mar 2016 15:36:52 -0700
> +{
> + struct udp_sock *up = udp_sk(sk);
> + int is_udplite = IS_UDPLITE(sk);
> +
> + int (*encap_rcv)(struct sock *sk, struct sk_buff *skb);
> +
Small nit, please put this encap_rcv function pointer declaration at
the top of
Hello Benjamin,
On 03/22/2016 09:28 AM, Benjamin Poirier wrote:
> "IP_LEAVE_GROUP" does not exist. It was perhaps a confusion with
> MCAST_LEAVE_GROUP. Change the text to IP_DROP_MEMBERSHIP which has the same
> function as MCAST_LEAVE_GROUP and is documented in the ip.7 man page.
>
> Reference:
>
From: Bjorn Helgaas
Date: Fri, 25 Mar 2016 11:46:39 -0500
> You're right, there is an issue here. I reproduced a problem with a
> bond device. bond_netpoll_setup() calls __netpoll_setup() directly
> (not netpoll_setup()). I'll debug it more; just wanted to let you
> know there *is* a problem w
From: Vivien Didelot
Date: Fri, 25 Mar 2016 13:20:30 -0400
> David, please ignore this patch for the moment.
Ok.
From: Ben Greear
Date: Fri, 25 Mar 2016 10:14:46 -0700
> Anyway, you know the stack and drivers better than me, so if you
> think Cong's patch is valid, then I'll test it and make sure it
> works in my setups at least.
It probably is, I'm just waiting to see if Tom Herbert will give
some feedbac
On Fri, Mar 25, 2016 at 1:00 PM, Eric Dumazet wrote:
> On Fri, 2016-03-25 at 12:31 -0400, Craig Gallek wrote:
>
>> I believe the issue here is that closing the listen sockets will drop
>> any connections that are in the listen queue but have not been
>> accepted yet. In the case of reuseport, you
On Fri, Mar 25, 2016 at 12:30:32PM -0500, Bjorn Helgaas wrote:
> Hi Neil,
>
> Since we're looking at netpoll, here's another question (or two).
> 0790bbb68f9d ("netpoll: cleanup sparse warnings") adds this:
>
> @@ -1236,7 +1236,11 @@ void __netpoll_cleanup(struct netpoll *np)
> struct net
On Fri, 2016-03-25 at 10:17 -0700, Cong Wang wrote:
> 1) sock lock protects the whole update: the whole check, update, recheck,
> set logic, to make sure another CPU will not do the same to the same socket
> at the same time.
>
> 2) the dst itself is safe, because it is always refcounted, and we
Hi Neil,
Since we're looking at netpoll, here's another question (or two).
0790bbb68f9d ("netpoll: cleanup sparse warnings") adds this:
@@ -1236,7 +1236,11 @@ void __netpoll_cleanup(struct netpoll *np)
struct netpoll_info *npinfo;
unsigned long flags;
- npinfo = np->dev->n
Hi,
Vivien Didelot writes:
> The 88E6185 switch also has a MapDA bit in its Port Control 2 register.
> When this bit is cleared, all frames are sent out to the CPU port.
>
> Set this bit to rely on ATU hits and direct the frame out of the correct
> ports, and thus enable hardware bridging.
>
> S
On Thu, Mar 24, 2016 at 6:51 PM, Eric Dumazet wrote:
> On Thu, 2016-03-24 at 17:15 -0700, Cong Wang wrote:
>
>> My understanding is that bh_lock_sock() prevents concurrent
>> access to sock struct. Since this is in softirq context, multiple
>> CPU's could call this function concurrently, the whole
On 03/25/2016 09:44 AM, David Miller wrote:
From: Ben Greear
Date: Fri, 25 Mar 2016 09:10:58 -0700
I am suspicious that this will break at least some drivers. I
grepped around for ip_summed, and found this, for instance:
davicom/dm9000.c
/* The DM9000 is not smart enough to leave
The 88E6185 switch also has a MapDA bit in its Port Control 2 register.
When this bit is cleared, all frames are sent out to the CPU port.
Set this bit to rely on ATU hits and direct the frame out of the correct
ports, and thus enable hardware bridging.
Signed-off-by: Vivien Didelot
---
drivers
On Fri, 2016-03-25 at 12:31 -0400, Craig Gallek wrote:
> I believe the issue here is that closing the listen sockets will drop
> any connections that are in the listen queue but have not been
> accepted yet. In the case of reuseport, you could in theory drain
> those queues into the non-closed so
On Fri, Mar 25, 2016 at 07:33:42AM -0400, Neil Horman wrote:
> On Thu, Mar 24, 2016 at 09:56:21PM -0500, Bjorn Helgaas wrote:
> > netpoll_setup() does a dev_hold() on np->dev, the netpoll device. If it
> > fails, it correctly does a dev_put() but leaves np->dev set. If we call
> > netpoll_cleanup
From: Cong Wang
Date: Fri, 25 Mar 2016 09:32:23 -0700
> So I believe dm9000 needs to fix.
+1
From: Ben Greear
Date: Fri, 25 Mar 2016 09:10:58 -0700
> I am suspicious that this will break at least some drivers. I
> grepped around for ip_summed, and found this, for instance:
>
> davicom/dm9000.c
>
> /* The DM9000 is not smart enough to leave fragmented packets
An really old (ci
On Fri, Mar 25, 2016 at 9:10 AM, Ben Greear wrote:
> I am suspicious that this will break at least some drivers. I grepped
> around
> for ip_summed, and found this, for instance:
>
> davicom/dm9000.c
>
> /* The DM9000 is not smart enough to leave fragmented packets alone.
> */
> i
On Fri, Mar 25, 2016 at 12:21 PM, Alexei Starovoitov
wrote:
> On Fri, Mar 25, 2016 at 11:29:10AM -0400, Craig Gallek wrote:
>> On Thu, Mar 24, 2016 at 2:00 PM, Willy Tarreau wrote:
>> > The pattern is :
>> >
>> > t0 : unprivileged processes 1 and 2 are listening to the same port
>> >(so
From: David Decotigny
History:
v7
added ref to related kernel commit in netlink ioctl patch description
v6
re-added last patch, to use AF_NETLINK when AF_INET not available
v5
rebased main patch, removed last patch "use AF_LOCAL when AF_INET
not available"
v4
review Be
From: David Decotigny
To benefit from this, kernel commit 025c68186e07 ("netlink: add support
for NIC driver ioctls") is needed.
Signed-off-by: David Decotigny
---
configure.ac | 2 +-
ethtool.c| 7 +++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/confi
On Fri, Mar 25, 2016 at 11:29:10AM -0400, Craig Gallek wrote:
> On Thu, Mar 24, 2016 at 2:00 PM, Willy Tarreau wrote:
> > The pattern is :
> >
> > t0 : unprivileged processes 1 and 2 are listening to the same port
> >(sock1@pid1) (sock2@pid2)
> ><-- listening -->
> >
> >
From: David Decotigny
More info with kernel commit 8d3f2806f8fb ("Merge branch
'ethtool-ksettings'").
Note: The new features implemented in this patch depend on kernel
commit 793cf87de9d1 ("Set cmd field in ETHTOOL_GLINKSETTINGS response to
wrong nwords").
Signed-off-by: David Decotigny
---
On 03/24/2016 10:33 PM, Cong Wang wrote:
On Thu, Mar 24, 2016 at 10:13 PM, Ben Greear wrote:
On 03/24/2016 10:06 PM, Cong Wang wrote:
On Thu, Mar 24, 2016 at 9:34 PM, Ben Greear
wrote:
On 03/24/2016 06:44 PM, Vijay Pandurangan wrote:
Oops, I think my last email didn't go through d
On Fri, Mar 25, 2016 at 04:29:52PM +0200, Corcodel Marian wrote:
> This patch add support for half duplex on MDI chips.
>
> Signed-off-by: Corcodel Marian
> ---
> drivers/net/ethernet/realtek/r8169.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/eth
From: Cyrille Pitchen
Date: Fri, 25 Mar 2016 10:37:34 +0100
> This patch removes two BUG_ON() used to notify about RX queue corruptions
> on macb (not gem) hardware without actually handling the error.
>
> The new code skips corrupted frames but still processes faultless frames.
> Then it resets
From: Manish Chopra
Date: Fri, 25 Mar 2016 07:14:09 -0400
> Just updating version as many fixes got
> accumulated over 1.00.00.34
>
> Signed-off-by: Manish Chopra
Applied, but it is the 'net' tree that fixes et al. like this
should be targetting as 'net-next' is closed.
From: Jaedon Shin
Date: Fri, 25 Mar 2016 12:46:54 +0900
> Add PHY entries for the Broadcom BCM7346 and BCM7362 chips, these are
> 40nm generation Ethernet PHY.
>
> Fixes: 815717d1473e ("net: phy: bcm7xxx: Remove wildcard entries")
> Signed-off-by: Jaedon Shin
Applied, thank you.
From: Daniel Borkmann
Date: Fri, 25 Mar 2016 00:30:25 +0100
> Add map_flags attribute to bpf_map_show_fdinfo(), so that tools like
> tc can check for them when loading objects from a pinned entry, e.g.
> if user intent wrt allocation (BPF_F_NO_PREALLOC) is different to the
> pinned object, it can
Hi Jeff,
Any chance to get an opinion on that?
Thanks,
On Nov27 11:05, William Dauchy wrote:
> Hello Jeff,
>
> I faced the problem described in commit 7e3f5c8:
> ixgbe: fix bounds checking in ixgbe_setup_tc for 82598
>
> This patch resolves an issue where users were not able to dynamically
> s
On Thu, Mar 24, 2016 at 2:00 PM, Willy Tarreau wrote:
> The pattern is :
>
> t0 : unprivileged processes 1 and 2 are listening to the same port
>(sock1@pid1) (sock2@pid2)
><-- listening -->
>
> t1 : new processes are started to replace the old ones
>(sock1@pid1)
From: Bjorn Helgaas
Date: Thu, 24 Mar 2016 21:56:21 -0500
> netpoll_setup() does a dev_hold() on np->dev, the netpoll device. If it
> fails, it correctly does a dev_put() but leaves np->dev set. If we call
> netpoll_cleanup() after the failure, np->dev is still set so we do another
> dev_put(),
Hi,
On 03/25/2016 04:11 PM, David Miller wrote:
It is absolutely not appropriate to submit new feature patches
at this time.
Please resubmit this after the net-next tree opens back out.
No pb, I will wait and resend.
Regards
Alex
Thank you.
It is absolutely not appropriate to submit new feature patches
at this time.
Please resubmit this after the net-next tree opens back out.
Thank you.
On 03/24/2016 10:24 PM, Vijay Pandurangan wrote:
On Fri, Mar 25, 2016 at 1:07 AM, Ben Greear wrote:
On 03/24/2016 09:45 PM, Vijay Pandurangan wrote:
Actually, maybe they should be set to CHECKSUM_PARTIAL if we want veth
to drop the packets if they have bad checksums before they hit the
appl
This patch add support for half duplex on MDI chips.
Signed-off-by: Corcodel Marian
---
drivers/net/ethernet/realtek/r8169.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers/net/ethernet/realtek/r8169.c
index 77c5efb..7f6f
On Fri, 25 Mar 2016 14:46:03 +0300
Sergei Shtylyov wrote:
> Hello.
>
> On 3/25/2016 1:25 PM, Corcodel Marian wrote:
>
> > Add definitions from mii and inhibit 0 to advertise.
> >
> > Signed-off-by: Corcodel Marian
> > ---
> > drivers/net/ethernet/realtek/r8169.c | 22 ++
On Fri, 25 Mar 2016 14:33:02 +0100
Phil Sutter wrote:
> Hi,
>
> Your patch submissions are getting better, also good to see you're
> finally using git-send-email. A few things need to be corrected
> though:
>
> Subject line:
> - The 'vNN' part in brackets is supposed to be the reroll-count (see
Hi,
Your patch submissions are getting better, also good to see you're
finally using git-send-email. A few things need to be corrected though:
Subject line:
- The 'vNN' part in brackets is supposed to be the reroll-count (see
'git format-patch -h' for details), not kernel version. You're
supp
On Fri, 2016-03-25 at 12:21 +0100, Yann Ylavic wrote:
> Not my intention, you guys know what's the better for the kernel and its APIs.
> My concern is (was) admittedly due to my own lack of knowledge of
> (e)BPF, hence how much of kernel internals I'd need to know to make
> the SO_REUSEPORT work i
This patch correct value on MII_BMCR register ald value 0
have target on reserved register first 2 bytes from MII_BMCR
speed 10 is flipped value on BMCR_SPEED100
Signed-off-by: Corcodel Marian
---
drivers/net/ethernet/realtek/r8169.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Just updating version as many fixes got
accumulated over 1.00.00.34
Signed-off-by: Manish Chopra
---
drivers/net/ethernet/qlogic/qlge/qlge.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge.h
b/drivers/net/ethernet/qlogic/qlge/qlge.h
inde
Hello.
On 3/25/2016 1:25 PM, Corcodel Marian wrote:
Add definitions from mii and inhibit 0 to advertise.
Signed-off-by: Corcodel Marian
---
drivers/net/ethernet/realtek/r8169.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/drivers/net/etherne
Hi all,
I am using a HP DL360p server with broadcom BCM5719 ethernet card
handled by tg3 driver.
When the link is renegotiated on one ethernet port, out packets get
lost on other ethernet ports. The problem is easily reproducible by
looping on switch port up/down.
Instrumenting the driver, I observ
On Thu, Mar 24, 2016 at 09:56:21PM -0500, Bjorn Helgaas wrote:
> netpoll_setup() does a dev_hold() on np->dev, the netpoll device. If it
> fails, it correctly does a dev_put() but leaves np->dev set. If we call
> netpoll_cleanup() after the failure, np->dev is still set so we do another
> dev_put
On Fri, Mar 25, 2016 at 9:53 AM, Willy Tarreau wrote:
>
> On Thu, Mar 24, 2016 at 11:49:41PM -0700, Eric Dumazet wrote:
>> Everything is possible, but do not complain because BPF went in the
>> kernel before your changes.
>
> Don't get me wrong, I'm not complaining, I'm more asking for help to
> tr
Add definitions from mii and inhibit 0 to advertise.
Signed-off-by: Corcodel Marian
---
drivers/net/ethernet/realtek/r8169.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers/net/ethernet/realtek/r8169.c
i
This patch removes two BUG_ON() used to notify about RX queue corruptions
on macb (not gem) hardware without actually handling the error.
The new code skips corrupted frames but still processes faultless frames.
Then it resets the RX queue before restarting the reception from a clean
state.
This
Signed-off-by: Alexandre TORGUE
diff --git a/MAINTAINERS b/MAINTAINERS
index b70294e..394e233 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3293,6 +3293,7 @@ F:Documentation/powerpc/cxlflash.txt
STMMAC ETHERNET DRIVER
M: Giuseppe Cavallaro
+M: Alexandre Torgue
L: netde
To avoid lot of check in stmmac_main for display ring management
and support the GMAC4 chip, the display_ring function is moved
into dedicated descriptor file.
Signed-off-by: Alexandre TORGUE
Signed-off-by: Giuseppe Cavallaro
diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h
b/drivers/
DMA behavior is linked to descriptor management:
-descriptor mechanism (Tx for example, but it is exactly the same for RX):
-useful registers:
-DMA_CH#_TxDesc_Ring_Len: length of transmit descriptor ring
-DMA_CH#_TxDesc_List_Address: start address of the ring
-DMA_CH#_TxDesc_Tail_Pointer:
For gmac3, the MMC addr map is: 0x100 - 0x2fc
For gmac4, the MMC addr map is: 0x700 - 0x8fc
So instead of adding 0x600 to the IO address when setup the mmc,
the RMON base address is saved inside the private structure and
then used to manage the counters.
Signed-off-by: Giuseppe Cavallaro
Signed-
This is to support the snps,dwmac-4.00 and snps,dwmac-4.10a
and related features on the platform driver.
See binding doc for further details.
Signed-off-by: Giuseppe Cavallaro
Signed-off-by: Alexandre TORGUE
diff --git a/Documentation/devicetree/bindings/net/stmmac.txt
b/Documentation/devicetr
One of main changes of GMAC 4.xx IP is descriptors management.
-descriptors are only used in ring mode.
-A descriptor is composed of 4 32bits registers (no more extended
descriptors)
-descriptor mechanism (Tx for example, but it is exactly the same for RX):
-useful registers:
-DMA_CH#_TxDe
This patch adds the whole GMAC4 support inside the
stmmac d.d. now able to use the new HW and some new features
i.e.: TSO.
It is missing the multi-queue and split Header support at this
stage.
This patch also updates the driver version and the stmmac.txt.
Signed-off-by: Alexandre TORGUE
Signed-of
This patch just updates the driver to the version fully
tested on STi platforms. This version is Jan_2016.
Signed-off-by: Alexandre TORGUE
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
index 317ce35..ff67506 100644
--- a/drivers/net/eth
This is the main header file to define all the
macro used for GMAC4 DMA and CORE parts.
Signed-off-by: Alexandre TORGUE
Signed-off-by: Giuseppe Cavallaro
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4.h
b/drivers/net/ethernet/stmicro/stmmac/dwmac4.h
new file mode 100644
index 000.
This is the initial support for GMAC4 that includes
the main callbacks to setup the core module: including
Csum, basic filtering, mac address and interrupt (MMC,
MTL, PMT) No LPI added.
Signed-off-by: Alexandre TORGUE
Signed-off-by: Giuseppe Cavallaro
diff --git a/drivers/net/ethernet/stmicro/s
synopsys_uid is only used once after setup, to get synopsys_id
by using shitf/mask operation. It's no longer used then.
So, remove this temporary variable and directly compute
synopsys_id from setup routine.
Acked-by: Giuseppe Cavallaro
Signed-off-by: Fabrice Gasnier
Signed-off-by: Alexandre TOR
Update stmmac driver documentation according to new GMAC 4.x family.
Signed-off-by: Alexandre TORGUE
diff --git a/Documentation/networking/stmmac.txt
b/Documentation/networking/stmmac.txt
index d64a147..671fe3d 100644
--- a/Documentation/networking/stmmac.txt
+++ b/Documentation/networking/stmm
This is a subset of patch to enhance current stmmac driver to support
new GMAC4.x chips. New set of callbacks is defined to support this new
family: descriptors, dma, core.
One of main changes of GMAC 4.xx IP is descriptors management.
-descriptors are only used in ring mode.
-A descriptor is co
On next GMAC IP generation (4.xx), the way to get hw feature
is not the same than on previous 3.xx. As it is hardware
dependent, the way to get hw capabilities should be defined in dma ops of
each MAC IP. It will avoid also a huge computation of hw capabilities in
stmmac_main.
Signed-off-by: Alexa
Hello,
On Thu, 24 Mar 2016, David Ahern wrote:
> On 3/24/16 4:33 PM, Julian Anastasov wrote:
> > But for multipath routes we can also consider the
> > nexthops as "alternatives", so it depends on how one uses
> > the multipath mechanism. The ability to fallback to
> > another nexthop
Hi Eric,
On Thu, Mar 24, 2016 at 11:49:41PM -0700, Eric Dumazet wrote:
> Everything is possible, but do not complain because BPF went in the
> kernel before your changes.
Don't get me wrong, I'm not complaining, I'm more asking for help to
try to elaborate the alternate solution. I understood wel
On 3/24/2016 6:01 PM, John Keeping wrote:
On Thu, 24 Mar 2016 13:56:02 +0100, Giuseppe CAVALLARO wrote:
This should be fixed by some work done some days
ago and not yet committed.
Pls see "stmmac: MDIO fixes" patch-set and let me know
if ok on your side.
Yes, that works for me.
thx John fo
> -Original Message-
> From: Scott Wood
> Sent: Saturday, March 19, 2016 6:55 AM
> To: Yangbo Lu; devicet...@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org; linux-ker...@vger.kernel.org; linuxppc-
> d...@lists.ozlabs.org; linux-...@vger.kernel.org; linux-
> i...@vger.kernel.org; i
98 matches
Mail list logo
