Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-04 Thread Cyrill Gorcunov
On Fri, Mar 04, 2016 at 11:11:09PM -0500, David Miller wrote: > From: Eric Dumazet > Date: Fri, 04 Mar 2016 16:08:30 -0800 > > > __inet_del_ifa() should probably take into account in_dev->dead (no > > promotion, no list scan...) > > Indeed, that is the real problem: Oh, this email dropped into

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-04 Thread Cyrill Gorcunov
On Fri, Mar 04, 2016 at 05:50:32PM -0500, David Miller wrote: > > Arbitrary limits are... arbitrary. > > If the freeing loop is the issue, splice the list at teardown and > process that list asynchronously via a workqueue or similar. Thanks! I'll try.

[PATCH v2 net] net: hns: fix the bug about loopback

2016-03-04 Thread Kejian Yan
It will always be passed if the soc is tested the loopback cases. This patch will fix this bug. Signed-off-by: Kejian Yan --- change log: PATCH v2: - This patch fixes the comments provided by Andy Shevchenko PATCH v1: - first submit Link: https://lkml.org/lkml/2016/3/3/266 --- drivers/net/

Re: [9/9] powerpc: optimise csum_partial() call when len is constant

2016-03-04 Thread Scott Wood
On Tue, Sep 22, 2015 at 04:34:36PM +0200, Christophe Leroy wrote: > +/* > + * computes the checksum of a memory block at buff, length len, > + * and adds in "sum" (32-bit) > + * > + * returns a 32-bit number suitable for feeding into itself > + * or csum_tcpudp_magic > + * > + * this function must

Re: [net-next v2 0/4] use reset to set header pointers

2016-03-04 Thread David Miller
From: Zhang Shengju Date: Thu, 3 Mar 2016 01:16:53 + > This patch series replace set function with reset when offset is zero. > > Changes since v1: > - fix typo in commit message Series applied, thanks.

Re: [PATCH v4 2/4] Documentation: Bindings: Add STM32 DWMAC glue

2016-03-04 Thread Rob Herring
On Fri, Mar 04, 2016 at 04:58:04PM +0100, Alexandre TORGUE wrote: > Signed-off-by: Alexandre TORGUE > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt > b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > new file mode 100644 > index 000..fd3566f > --- /dev/null > +

Re: [PATCH V3 1/4] net-next: mediatek: document MediaTek SoC ethernet binding

2016-03-04 Thread Rob Herring
On Thu, Mar 03, 2016 at 09:02:38PM +0100, John Crispin wrote: > This adds the binding documentation for the MediaTek Ethernet > controller. > > Signed-off-by: John Crispin > Cc: devicet...@vger.kernel.org > --- > .../devicetree/bindings/net/mediatek-net.txt | 77 > >

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-04 Thread Rob Herring
On Thu, Mar 03, 2016 at 03:38:35PM +, Ramesh Shanmugasundaram wrote: > This patch adds support for the CAN FD controller found in Renesas R-Car > SoCs. The controller operates in CAN FD mode by default. > > CAN FD mode supports both Classical CAN & CAN FD frame formats. The > controller suppor

Re: [4/9] powerpc: inline ip_fast_csum()

2016-03-04 Thread Scott Wood
On Tue, Sep 22, 2015 at 04:34:25PM +0200, Christophe Leroy wrote: > @@ -137,6 +130,45 @@ static inline __wsum csum_add(__wsum csum, __wsum addend) > #endif > } > > +/* > + * This is a version of ip_compute_csum() optimized for IP headers, > + * which always checksum on 4 octet boundaries. ihl

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-04 Thread David Miller
From: Eric Dumazet Date: Fri, 04 Mar 2016 16:08:30 -0800 > __inet_del_ifa() should probably take into account in_dev->dead (no > promotion, no list scan...) Indeed, that is the real problem: diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 8c3df2c..7412feb 100644 --- a/net/ipv4/devine

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2016-03-04 Thread kbuild test robot
Hi Arnd, [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.5-rc6 next-20160304] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/isdn-icn-remove

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-03-04 Thread Diego Viola
On Fri, Mar 4, 2016 at 1:32 AM, Diego Viola wrote: > On Thu, Mar 3, 2016 at 6:19 PM, Diego Viola wrote: >> On Thu, Mar 3, 2016 at 6:14 PM, Diego Viola wrote: >>> On Thu, Mar 3, 2016 at 2:55 AM, Diego Viola wrote: On Thu, Mar 3, 2016 at 12:19 AM, Diego Viola wrote: > On Wed, Mar 2, 201

Re: [iproute PATCH 12/12] doc: Add my article about tc, filters and actions

2016-03-04 Thread Phil Sutter
On Fri, Mar 04, 2016 at 05:40:13PM -0800, Alexei Starovoitov wrote: > On Fri, Mar 04, 2016 at 01:11:47PM +0100, Phil Sutter wrote: > > Signed-off-by: Phil Sutter > > great to see TC doc! > Few comments: Thanks for cross-reading! I'll wait a few days to allow for further reviews, then respin inco

Re: [iproute PATCH 12/12] doc: Add my article about tc, filters and actions

2016-03-04 Thread Alexei Starovoitov
On Fri, Mar 04, 2016 at 01:11:47PM +0100, Phil Sutter wrote: > Signed-off-by: Phil Sutter great to see TC doc! Few comments: > +TC, the Traffic Control utility, has been there for a very long time - > forever > +in my humble perception. It is still (and has ever been if I'm not mistaken) > the

Re: [iproute PATCH] libnetlink: Double the dump buffer size

2016-03-04 Thread Phil Sutter
On Fri, Mar 04, 2016 at 03:35:53PM -0800, Stephen Hemminger wrote: > On Fri, 4 Mar 2016 18:57:28 + > Phil Sutter wrote: > > > There have been reports about 'ip addr' printing "Message truncated" on > > systems with large numbers of VFs. Although I haven't been able to get > > my hands on hard

[ethtool PATCH v3 02/12] ethtool.c: don't ignore fread() return value

2016-03-04 Thread David Decotigny
From: David Decotigny This addresses: ethtool.c:1116:8: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: David Decotigny --- ethtool.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ethtool.c b/e

[ethtool PATCH v3 08/12] ethtool-copy.h: sync with net-next

2016-03-04 Thread David Decotigny
From: David Decotigny This cover changes up to: commit 3f1ac7a700d039c61d8d8b99f28d605d489a60cf Author: David Decotigny Date: Wed Feb 24 10:57:59 2016 -0800 net: ethtool: add new ETHTOOL_xLINKSETTINGS API Signed-off-by: David Decotigny --- ethtool-copy.h | 485 +++

[ethtool PATCH v3 09/12] internal.h: fix build for latest ethtool-copy.h

2016-03-04 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- internal.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/internal.h b/internal.h index 5f8504d..5df8124 100644 --- a/internal.h +++ b/internal.h @@ -13,6 +13,7 @@ #ifdef HAVE_CONFIG_H #include "ethtool-config.h

[ethtool PATCH v3 10/12] internal.h: TRUE/FALSE macros

2016-03-04 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- internal.h | 8 1 file changed, 8 insertions(+) diff --git a/internal.h b/internal.h index 5df8124..7c44d0e 100644 --- a/internal.h +++ b/internal.h @@ -42,6 +42,14 @@ typedef int32_t s32; #include "ethtool-copy.h" #include "

[ethtool PATCH v3 11/12] ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls

2016-03-04 Thread David Decotigny
From: David Decotigny More info with kernel SHA1: 8d3f2806f8fbd9b22 "Merge branch 'ethtool-ksettings'". Signed-off-by: David Decotigny --- ethtool.c | 682 +++-- internal.h | 66 ++ test-cmdline.c | 12 + 3 files changed, 601

[ethtool PATCH v3 05/12] marvell.c: fix strict alias warnings

2016-03-04 Thread David Decotigny
From: Maciej Żenczykowski Addresses the following warnings: marvell.c:426:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] marvell.c:427:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasin

[ethtool PATCH v3 07/12] test-features.c: add braces around array initialization

2016-03-04 Thread David Decotigny
From: Maciej Żenczykowski This fixes: test-features.c:21:1: error: missing braces around initializer [-Werror=missing-braces] cmd_gssetinfo = { { ETHTOOL_GSSET_INFO, 0, 1ULL << ETH_SS_FEATURES }, 34 }; ^ Signed-off-by: Maciej Żenczykowski Signed-off-by: David Decotigny --- test-feat

[ethtool PATCH v3 12/12] ethtool.c: use v6 socket when v4 is not available

2016-03-04 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- ethtool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ethtool.c b/ethtool.c index e1acf09..4daf538 100644 --- a/ethtool.c +++ b/ethtool.c @@ -4618,6 +4618,9 @@ opt_found: /* Open control socket. */

[ethtool PATCH v3 04/12] ethtool.c: do_seeprom checks for params & stdin sanity

2016-03-04 Thread David Decotigny
From: David Decotigny Tested: On qemu e1000: $ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 9 too much data from stdin $ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 11 not enough data from stdin $ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length

[ethtool PATCH v3 06/12] test-common.c: fix test_realloc(NULL, ...)

2016-03-04 Thread David Decotigny
From: Maciej Żenczykowski This fixes: test-common.c: In function 'test_realloc': test-common.c:109:8: error: 'block' may be used uninitialized in this function [-Werror=maybe-uninitialized] block = realloc(block, sizeof(*block) + size); ^ Signed-off-by: Maciej Żenczykowski S

[ethtool PATCH v3 03/12] ethtool.c: fix dump_regs heap corruption

2016-03-04 Thread David Decotigny
From: David Decotigny The 'regs' pointer is owned by do_gregs(), but updated internally inside dump_regs() without propagating it back to do_gregs(): later free(regs) in do_gregs() reclaims the wrong area. This commit moves the realloc() inside do_gregs(). Signed-off-by: David Decotigny --- e

[ethtool PATCH v3 01/12] internal.h: change to new sane powerpc64 kernel headers

2016-03-04 Thread David Decotigny
From: Maciej Żenczykowski This fixes: In file included from ethtool-copy.h:22:0, from internal.h:32, from ethtool.c:29: .../include/linux/types.h:32:25: error: conflicting types for '__be64' typedef __u64 __bitwise __be64; ^

[ethtool PATCH v3 00/12] add support for new ETHTOOL_xLINKSETTINGS ioctls

2016-03-04 Thread David Decotigny
From: David Decotigny This adds support for the new ETHTOOL_xLINKSETTINGS ioctls. This also fixes a few compilation warnings as well as a heap corruption bug. History: v3 TRUE/FALSE obvious-ification v2 added do_seeprom patch added netdev@ as recipient v1 initial submission

Re: [RFC PATCH net-next] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-04 Thread Eric Dumazet
On ven., 2016-03-04 at 15:57 -0800, Martin KaFai Lau wrote: > diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c > index 4c8d58d..c9b576f 100644 > --- a/net/ipv4/tcp_ipv4.c > +++ b/net/ipv4/tcp_ipv4.c > @@ -1540,6 +1540,7 @@ int tcp_v4_rcv(struct sk_buff *skb) > const struct iphdr *iph;

Re: [PATCH v5 net-next] net: Implement fast csum_partial for x86_64

2016-03-04 Thread Alexander Duyck
On Fri, Mar 4, 2016 at 2:38 AM, David Laight wrote: > From: Linus Torvalds >> Sent: 03 March 2016 18:44 >> >> On Thu, Mar 3, 2016 at 8:12 AM, David Laight wrote: >> > >> > Did you try the asm loop that used 'leax %rcx..., jcxz... jmps..' >> > without any unrolling? >> >> Is that actually supposed

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-04 Thread Eric Dumazet
On ven., 2016-03-04 at 17:50 -0500, David Miller wrote: > From: Cyrill Gorcunov > Date: Sat, 5 Mar 2016 00:39:20 +0300 > > > Currenlty all the kernels (including vanilla) free ifa > > list under rtln_lock() taken which takes a huge time > > to release all entries when we stop the container. > > M

[PATCH net 2/2] jme: Fix device PM wakeup API usage

2016-03-04 Thread cooldavid
From: Guo-Fu Tseng According to Documentation/power/devices.txt The driver should not use device_set_wakeup_enable() which is the policy for user to decide. Using device_init_wakeup() to initialize dev->power.should_wakeup and dev->power.can_wakeup on driver initialization. And use device_may_

[PATCH net 1/2] jme: Do not enable NIC WoL functions on S0

2016-03-04 Thread cooldavid
From: Guo-Fu Tseng Otherwise it might be back on resume right after going to suspend in some hardware. Reported-by: Diego Viola Signed-off-by: Guo-Fu Tseng --- drivers/net/ethernet/jme.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/net/etherne

[RFC PATCH net-next] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-04 Thread Martin KaFai Lau
Per RFC4898, they count segments sent/received containing a positive length data segment (that includes retransmission segments carrying data). Unlike tcpi_segs_out/in, tcpi_data_segs_out/in excludes segments carrying no data (e.g. pure ack). The patch also updates the segs_in in tcp_fastopen_add

Re: [iproute PATCH 0/5] Misc minor documentation fixes

2016-03-04 Thread Stephen Hemminger
On Fri, 4 Mar 2016 12:52:36 +0100 Phil Sutter wrote: > The following five patches contain minor changes to documentation at > various places. They are all unrelated, but being lazy as I am, I > submit them in one go. > > Phil Sutter (5): > tc: pedit: document branch control in help output >

Re: [iproute PATCH 0/2] ip-neighbour: Add missing nud state descriptions

2016-03-04 Thread Stephen Hemminger
On Fri, 4 Mar 2016 19:07:19 + Phil Sutter wrote: > The following aims at documenting all nud states 'ip neigh' supports, not just > the most common ones. This includes describing them in the relevant man page > as > well as extending 'ip neigh help' output. > > Phil Sutter (2): > man: ip-

Re: [iproute PATCH] libnetlink: Double the dump buffer size

2016-03-04 Thread Stephen Hemminger
On Fri, 4 Mar 2016 18:57:28 + Phil Sutter wrote: > There have been reports about 'ip addr' printing "Message truncated" on > systems with large numbers of VFs. Although I haven't been able to get > my hands on hardware suitable to reproduce this, increasing the dump > buffer has been reported

Re: [PATCH 00/13] RxRPC: Rewrite part 1

2016-03-04 Thread David Miller
From: David Howells Date: Fri, 04 Mar 2016 22:33:38 + > David Miller wrote: > >> Can you go through and use "unsigned int" instead of just plain >> "unsigned" in the RxRPC code? > > Do you mind if I leave it to after the rewrite? I don't particularly want to > have to rejig all the patche

Re: Possible double-free in the usbnet driver

2016-03-04 Thread Andrey Konovalov
On Sat, Mar 5, 2016 at 2:00 AM, Andrey Konovalov wrote: > On Sat, Mar 5, 2016 at 1:42 AM, Oliver Neukum wrote: >> On Sat, 2016-03-05 at 01:26 +0300, Andrey Konovalov wrote: >>> and when I run the vm and connect the device I get: >>> >>> [ 23.672662] cdc_ncm 1-1:1.6: bind() failure >>> [ 23.67

Re: [PATCH] vmxnet3: avoid calling pskb_may_pull with interrupts disabled

2016-03-04 Thread Shrikrishna Khare
On Fri, 4 Mar 2016, Neil Horman wrote: > vmxnet3 has a function vmxnet3_parse_and_copy_hdr which, among other > operations, > uses pskb_may_pull to linearize the header portion of an skb. That operation > eventually uses local_bh_disable/enable to ensure that it doesn't race with > the > driv

Suspicious code in tun_flow_update()

2016-03-04 Thread Alexey Khoroshilov
Hello, If tun_flow_find() successfully finds tun_flow_entry, tun_flow_update() updates the entry in place. Is such usage of RCU safe here? Found by Linux Driver Verification project (linuxtesting.org). -- Alexey Khoroshilov Linux Verification Center, ISPRAS

Re: Possible double-free in the usbnet driver

2016-03-04 Thread Andrey Konovalov
On Sat, Mar 5, 2016 at 1:42 AM, Oliver Neukum wrote: > On Sat, 2016-03-05 at 01:26 +0300, Andrey Konovalov wrote: >> and when I run the vm and connect the device I get: >> >> [ 23.672662] cdc_ncm 1-1:1.6: bind() failure >> [ 23.673447] usbnet_probe(): freeing netdev: 88006ab48000 >> [ 23

Re: Possible double-free in the usbnet driver

2016-03-04 Thread Andrey Konovalov
On Sat, Mar 5, 2016 at 1:43 AM, Linus Torvalds wrote: > On Fri, Mar 4, 2016 at 2:26 PM, Andrey Konovalov wrote: >> >> and when I run the vm and connect the device I get: >> >> [ 23.672662] cdc_ncm 1-1:1.6: bind() failure >> [ 23.673447] usbnet_probe(): freeing netdev: 88006ab48000 >> [

Re: [RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-04 Thread David Miller
From: Cyrill Gorcunov Date: Sat, 5 Mar 2016 00:39:20 +0300 > Currenlty all the kernels (including vanilla) free ifa > list under rtln_lock() taken which takes a huge time > to release all entries when we stop the container. > Moreover it's allowed to create unlimited number > of addresses from in

[PATCH] udp6: fix UDP/IPv6 encap resubmit path

2016-03-04 Thread Bill Sommerfeld
IPv4 interprets a negative return value from a protocol handler as a request to redispatch to a new protocol. In contrast, IPv6 interprets a negative value as an error, and interprets a positive value as a request for redispatch. UDP for IPv6 was unaware of this difference. Change __udp6_lib_rcv

Re: Possible double-free in the usbnet driver

2016-03-04 Thread Oliver Neukum
On Sat, 2016-03-05 at 01:26 +0300, Andrey Konovalov wrote: > and when I run the vm and connect the device I get: > > [ 23.672662] cdc_ncm 1-1:1.6: bind() failure > [ 23.673447] usbnet_probe(): freeing netdev: 88006ab48000 > [ 23.675822] usbnet_probe(): freeing netdev: 88006ab48000 >

Re: Possible double-free in the usbnet driver

2016-03-04 Thread Linus Torvalds
On Fri, Mar 4, 2016 at 2:26 PM, Andrey Konovalov wrote: > > and when I run the vm and connect the device I get: > > [ 23.672662] cdc_ncm 1-1:1.6: bind() failure > [ 23.673447] usbnet_probe(): freeing netdev: 88006ab48000 > [ 23.675822] usbnet_probe(): freeing netdev: 88006ab48000 > >

Re: [PATCH 00/13] RxRPC: Rewrite part 1

2016-03-04 Thread David Howells
David Miller wrote: > Can you go through and use "unsigned int" instead of just plain > "unsigned" in the RxRPC code? Do you mind if I leave it to after the rewrite? I don't particularly want to have to rejig all the patches I have. David

Re: Possible double-free in the usbnet driver

2016-03-04 Thread Andrey Konovalov
On Sat, Mar 5, 2016 at 12:26 AM, Linus Torvalds wrote: > [ Moving this to proper lists ] > > On Thu, Mar 3, 2016 at 4:19 PM, Andrey Konovalov wrote: >> >> I found another double-free, this time in the usbnet driver. > > Hmm. It doesn't look like a double free to me, at least from the logs > you a

Re: [PATCH 00/13] RxRPC: Rewrite part 1

2016-03-04 Thread David Miller
ion stage. > > The patches can be found here also: > > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite > > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrit

Re: [Intel-wired-lan] [PATCH net-next] net: ixgbe: Fix cls_u32 offload support for ports and fields with masks.

2016-03-04 Thread Samudrala, Sridhar
On 3/4/2016 2:10 PM, Jeff Kirsher wrote: On Fri, 2016-03-04 at 11:47 -0800, Sridhar Samudrala wrote: Fix support for 16 bit source/dest port matches in ixgbe model. u32 uses a single 32-bit key value for both source and destination ports starting at offset 0. So replace the 2 functions with a

Re: [PATCH next 3/3] net: Use l3_dev instead of skb->dev for L3 processing

2016-03-04 Thread Mahesh Bandewar
On Fri, Mar 4, 2016 at 9:30 AM, Cong Wang wrote: > On Thu, Mar 3, 2016 at 5:42 PM, Mahesh Bandewar wrote: > As you mentioned logically we should be able to pass the skb in master's > ns > until L3 processing is completed. This patch series attempts to do that by > disassociating t

Re: [PATCH net-next v3 0/3] NSH and VxLAN-GPE

2016-03-04 Thread David Miller
From: Brian Russell Date: Fri, 4 Mar 2016 15:38:47 + > So it seems reasonable to have a hook to hang metadata > interpretation on? Nope.

Re: [Intel-wired-lan] [PATCH net-next] net: ixgbe: Fix cls_u32 offload support for ports and fields with masks.

2016-03-04 Thread Jeff Kirsher
On Fri, 2016-03-04 at 11:47 -0800, Sridhar Samudrala wrote: > Fix support for 16 bit source/dest port matches in ixgbe model. > u32 uses a single 32-bit key value for both source and destination > ports > starting at offset 0. So replace the 2 functions with a single > function > that takes this ke

[RFC] net: ipv4 -- Introduce ifa limit per net

2016-03-04 Thread Cyrill Gorcunov
Currenlty all the kernels (including vanilla) free ifa list under rtln_lock() taken which takes a huge time to release all entries when we stop the container. Moreover it's allowed to create unlimited number of addresses from inside of net-namespace if CAP-NET_ADMIN granted (which is common for con

[PATCH V2 1/1] be2net: Don't leak iomapped memory on removal.

2016-03-04 Thread Douglas Miller
The adapter->pcicfg resource is either mapped via pci_iomap() or derived from adapter->db. During be_remove() this resource was ignored and so could remain mapped after remove. Add a flag to track whether adapter->pcicfg was mapped or not, then use that flag in be_unmap_pci_bars() to unmap if requ

[PATCH V2 0/1] be2net: Don't leak iomapped memory on removal.

2016-03-04 Thread Douglas Miller
The adapter->pcicfg resource is either mapped via pci_iomap() or derived from adapter->db. During be_remove() this resource was ignored and so could remain mapped after remove. Add a flag to track whether adapter->pcicfg was mapped or not, then use that flag in be_unmap_pci_bars() to unmap if

Re: [PATCH net-next v3 3/4] drm/vmwgfx: remove userland definition of DIV_ROUND_UP

2016-03-04 Thread Emil Velikov
Hi Nicolas, On 4 March 2016 at 10:52, Nicolas Dichtel wrote: > Let's use __KERNEL_DIV_ROUND_UP, which is defined in uapi/linux/kernel.h. > > Signed-off-by: Nicolas Dichtel > --- > .../drm/vmwgfx/device_include/svga3d_surfacedefs.h | 20 > +++- > 1 file changed, 11 insertions(

Re: [PATCH] stmmac: fix noderef.cocci warnings

2016-03-04 Thread David Miller
From: Alexandre Torgue Date: Fri, 4 Mar 2016 13:45:40 +0100 > Hi, > > On 03/03/2016 02:55 AM, kbuild test robot wrote: >> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:115:15-21: >> ERROR: application of sizeof to pointer >> >> sizeof when applied to a pointer typed expression gives th

[PATCH net-next] hv_netvsc: Move subchannel waiting to rndis_filter_device_remove()

2016-03-04 Thread Haiyang Zhang
During hot add, vmbus_device_register() is called from vmbus_onoffer(), on the same workqueue as the subchannel offer message work-queue, so subchannel offer won't be processed until the vmbus_device_register()/... /netvsc_probe() is done. Also, vmbus_device_register() is called with channel_mutex

Re: Possible double-free in the usbnet driver

2016-03-04 Thread Linus Torvalds
[ Moving this to proper lists ] On Thu, Mar 3, 2016 at 4:19 PM, Andrey Konovalov wrote: > > I found another double-free, this time in the usbnet driver. Hmm. It doesn't look like a double free to me, at least from the logs you attached. > Whenever the `bind()` function fails (drivers/net/usb/us

Re: [Intel-wired-lan] [PATCH net-next] net: ixgbe: Fix cls_u32 offload support for ports and fields with masks.

2016-03-04 Thread Samudrala, Sridhar
On 3/4/2016 12:41 PM, John Fastabend wrote: On 16-03-04 11:47 AM, Sridhar Samudrala wrote: Fix support for 16 bit source/dest port matches in ixgbe model. u32 uses a single 32-bit key value for both source and destination ports starting at offset 0. So replace the 2 functions with a single funct

Re: Backport patch from 4.2 to 3.18

2016-03-04 Thread Sasha Levin
On 03/04/2016 03:40 PM, Andrei Sharaev wrote: > Hi Sasha, > > Can you backport this patch for "inet-frag-fixes" to linux kernel 3.18 LTS? > http://kernel.suse.com/cgit/kernel/commit/?h=v4.2-rc5&id=64b892ad2326348a5b8314167590d240e3bcc69e > > I get 1-5 kernel panics in month for linux kernels 3.18

Re: [PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition

2016-03-04 Thread David Miller
From: Nicolas Dichtel Date: Fri, 4 Mar 2016 11:52:15 +0100 > The inital goal was to consolidate ethtool.h uapi header. But I took the > opportunity to remove all duplicate definitions of DIV_ROUND_UP. > > v3: add patch #2 and #3 > > v2: split the patch > define DIV_ROUND_UP in uapi Series

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 19:18:49 i...@linux-pingi.de wrote: > Am 04.03.2016 um 16:24 schrieb Arnd Bergmann: > > On Thursday 03 March 2016 09:30:38 i...@linux-pingi.de wrote: > >> Hi Arnd, > >> I fully agree and ack. > >> Thanks for the work. > >> > > > > I actually did more patches that I ended up

Re: Sending short raw packets using sendmsg() broke

2016-03-04 Thread Willem de Bruijn
On Fri, Mar 4, 2016 at 11:33 AM, Willem de Bruijn wrote: > On Fri, Mar 4, 2016 at 10:54 AM, Alan Cox wrote: >>> > A quick search for ethhdr in drivers/net/ethernet shows, for >>> > instance, >>> > bnx2x_select_queue casting skb->data to an ethernet header. Reading >>> > nonsense in that particula

[PATCH net 1/3] net: validate variable length ll headers

2016-03-04 Thread Willem de Bruijn
From: Willem de Bruijn Netdevice parameter hard_header_len is variously interpreted both as an upper and lower bound on link layer header length. The field is used as upper bound when reserving room at allocation, as lower bound when validating user input in PF_PACKET. Clarify the definition to

[PATCH net 2/3] packet: validate variable length ll headers

2016-03-04 Thread Willem de Bruijn
From: Willem de Bruijn Replace link layer header validation check ll_header_truncate with more generic dev_validate_header. Validation based on hard_header_len incorrectly drops valid packets in variable length protocols, such as AX25. dev_validate_header calls header_ops.validate for such proto

[PATCH net 3/3] ax25: add link layer header validation function

2016-03-04 Thread Willem de Bruijn
From: Willem de Bruijn As variable length protocol, AX25 fails link layer header validation tests based on a minimum length. header_ops.validate allows protocols to validate headers that are shorter than hard_header_len. Implement this callback for AX25. Compile tested only. See also http://com

[PATCH net 0/3] validate variable length ll headers

2016-03-04 Thread Willem de Bruijn
From: Willem de Bruijn Allow device-specific validation of link layer headers. Existing checks drop all packets shorter than hard_header_len. For variable length protocols, such packets can be valid. patch 1 adds header_ops.validate and dev_validate_header patch 2 replaces ll_header_truncated wi

Re: [Intel-wired-lan] [PATCH net-next] net: ixgbe: Fix cls_u32 offload support for ports and fields with masks.

2016-03-04 Thread John Fastabend
On 16-03-04 11:47 AM, Sridhar Samudrala wrote: > Fix support for 16 bit source/dest port matches in ixgbe model. > u32 uses a single 32-bit key value for both source and destination ports > starting at offset 0. So replace the 2 functions with a single function > that takes this key value/mask to p

[PATCH net-next] net: ixgbe: Fix cls_u32 offload support for ports and fields with masks.

2016-03-04 Thread Sridhar Samudrala
Fix support for 16 bit source/dest port matches in ixgbe model. u32 uses a single 32-bit key value for both source and destination ports starting at offset 0. So replace the 2 functions with a single function that takes this key value/mask to program both source and dest ports. Remove the incorrec

Re: pull-request: can 2016-03-04

2016-03-04 Thread David Miller
From: Marc Kleine-Budde Date: Fri, 4 Mar 2016 08:55:54 +0100 > Hello David, > > this is a pull request for net/master. > > There is one patch from Ed Spiridonov, which increases the performance of the > mcp251x SPI CAN driver, by avoiding to write to error flag register if it's > unnecessary.

Re: [PATCH] stmmac: Fix type of local variable in stmmac_xmit

2016-03-04 Thread David Miller
From: Andrzej Hajda Date: Fri, 04 Mar 2016 08:19:04 +0100 > Variable entry holds result of jumbo_frm callback. It can be negative, > so the variable should be signed. The patch changes also type of related > first_entry variable to make code compact and coherent. > > The problem has been detecte

Re: [PATCH net-next] net: ixgbe: fix error handling in tc cls_u32 offload routines.

2016-03-04 Thread David Miller
From: Jeff Kirsher Date: Thu, 03 Mar 2016 15:37:52 -0800 > On Thu, 2016-03-03 at 15:19 -0800, Sridhar Samudrala wrote: >> Check for handle ids when adding/deleting hash nodes OR >> adding/deleting >> filter entries and limit them to max number of links or header nodes >> supported(IXGBE_MAX_LINK_

Re: [net-next PATCH 0/7] net: bulk alloc side and more bulk free drivers

2016-03-04 Thread Jesper Dangaard Brouer
On Fri, 4 Mar 2016 08:36:44 -0800 Alexei Starovoitov wrote: > On Fri, Mar 04, 2016 at 02:01:14PM +0100, Jesper Dangaard Brouer wrote: > > This patchset use the bulk ALLOC side of the kmem_cache bulk APIs, for > > SKB allocations. The bulk free side got enabled in merge commit > > 3134b9f019f2 ("

Re: [PATCH net-next] nfp: remove Rolf Neugebauer as co-maintainer

2016-03-04 Thread David Miller
From: Simon Horman Date: Fri, 4 Mar 2016 15:58:07 +0900 > Rolf is no longer in his previous role at Netronome and as far as I know no > longer working on the NFP driver. Thus it does not seem appropriate for him > to be a co-maintainer anymore. > > Reviewed-by: Dinan Gunawardena > Signed-off-b

[iproute PATCH 1/2] man: ip-neighbour.8: Document all known nud states

2016-03-04 Thread Phil Sutter
Not sure how useful they are in practice, but as 'ip neigh' supports setting them all, they deserve to be described as well. While at it, also add a missing layer of indentation to the subordinate nud state list. Signed-off-by: Phil Sutter --- man/man8/ip-neighbour.8 | 22 +-

[iproute PATCH 2/2] ipneigh: List all nud states in help output

2016-03-04 Thread Phil Sutter
To not make the output overly confusing, list them in a definition of the STATE placeholder which is already used in the show/flush syntax but wasn't explained before. Signed-off-by: Phil Sutter --- ip/ipneigh.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/ip/ipne

Re: [PATCH net-next V2 13/16] net: fec: print more debug info in fec_timeout

2016-03-04 Thread Troy Kisky
On 3/4/2016 10:35 AM, Joe Perches wrote: > On Fri, 2016-03-04 at 09:05 -0700, Troy Kisky wrote: >> On 3/4/2016 3:06 AM, Fugang Duan wrote: >>> From: Troy Kisky Sent: Thursday, February >>> 25, 2016 8:37 AM > [] Print the current interrupt flags and mask and the interrupt state during t

[iproute PATCH 0/2] ip-neighbour: Add missing nud state descriptions

2016-03-04 Thread Phil Sutter
The following aims at documenting all nud states 'ip neigh' supports, not just the most common ones. This includes describing them in the relevant man page as well as extending 'ip neigh help' output. Phil Sutter (2): man: ip-neighbour.8: Document all known nud states ipneigh: List all nud sta

[iproute PATCH] libnetlink: Double the dump buffer size

2016-03-04 Thread Phil Sutter
There have been reports about 'ip addr' printing "Message truncated" on systems with large numbers of VFs. Although I haven't been able to get my hands on hardware suitable to reproduce this, increasing the dump buffer has been reported to resolve the issue. For want of a better idea, just double t

[PATCH] vmxnet3: avoid calling pskb_may_pull with interrupts disabled

2016-03-04 Thread Neil Horman
vmxnet3 has a function vmxnet3_parse_and_copy_hdr which, among other operations, uses pskb_may_pull to linearize the header portion of an skb. That operation eventually uses local_bh_disable/enable to ensure that it doesn't race with the drivers bottom half handler. Unfortunately, vmxnet3 preform

Re: [PATCH net-next V2 03/10] net/sched: Macro instead of CONFIG_NET_CLS_ACT ifdef

2016-03-04 Thread Cong Wang
On Thu, Mar 3, 2016 at 11:51 AM, Amir Vadai wrote: > On Thu, Mar 03, 2016 at 09:45:28AM -0800, Cong Wang wrote: >> >> So why? > The struct will not be used, and without exposing it, the compiler will > complain on code like I have in patch 9/10 ("net/mlx5e: Support offload > cls_flower with drop a

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2016-03-04 Thread isdn
Am 04.03.2016 um 16:24 schrieb Arnd Bergmann: > On Thursday 03 March 2016 09:30:38 i...@linux-pingi.de wrote: >> Hi Arnd, >> I fully agree and ack. >> Thanks for the work. >> > > I actually did more patches that I ended up not submitting: > > * move hisax to staging > * remove i4l support from gi

[PATCH net-next 0/2] qed/qede: Add hardware GRO support

2016-03-04 Thread Manish Chopra
Hi David, This patch series enables hardware GRO and add support for handling HW aggregated TCP packets in driver receive flow by skipping software GRO handling in stack. Please consider applying this series to net-next. Thanks, Manish Manish Chopra (2): qed/qede: Add infrastructure support f

[PATCH net-next 2/2] qede: Add slowpath/fastpath support and enable hardware GRO

2016-03-04 Thread Manish Chopra
This patch configures hardware to use GRO and adds support for fastpath APIs to handle HW aggregated packets. Signed-off-by: Yuval Mintz Signed-off-by: Manish Chopra --- drivers/net/ethernet/qlogic/qede/qede.h | 22 ++ drivers/net/ethernet/qlogic/qede/qede_main.c | 367 +

[PATCH net-next 1/2] qed/qede: Add infrastructure support for hardware GRO

2016-03-04 Thread Manish Chopra
This patch adds mainly structures and APIs prototype changes in order to give support for qede slowpath/fastpath support for the same. Signed-off-by: Yuval Mintz Signed-off-by: Manish Chopra --- drivers/net/ethernet/qlogic/qed/qed_hsi.h| 14 - drivers/net/ethernet/qlogic/qed/qed_l2.c

[PATCH RFC/RFT v2 2/2] ath9k: use mac80211 intermediate software queues

2016-03-04 Thread Tim Shepard
This patch leaves the code for ath9k's internal per-node per-tid queues in place and just modifies the driver to also pull from the new mac80211 intermediate software queues, and implements the .wake_tx_queue method, which will cause mac80211 to deliver packets to be sent via the new intermediate

[PATCH RFC/RFT v2 1/2] ath9k: rename struct ath_txq to struct ath_hwq

2016-03-04 Thread Tim Shepard
Also use hwq instead of txq to refer to it throughout ath9k/*. This is prep work for using mac80211's new intermediate queues, which are called txq, and it would be too confusing if both are called txq. Signed-off-by: Tim Shepard --- drivers/net/wireless/ath/ath9k/ath9k.h | 50 +-- drive

[PATCH RFC/RFT v2 0/2] ath9k: use mac80211 intermediate software queues

2016-03-04 Thread Tim Shepard
[ v2: fixed compile errors in first patch when config includes ATH9K_TX99 or ATH9K_CHANNEL_CONTEXT. Also added signed-off-by to both patches. ] Here is a patch in two parts to have ath9k make use the new intermediate queues in mac80211. It seems to work for me, but it clearly nee

Re: [PATCH next 3/3] net: Use l3_dev instead of skb->dev for L3 processing

2016-03-04 Thread Cong Wang
On Thu, Mar 3, 2016 at 5:42 PM, Mahesh Bandewar wrote: As you mentioned logically we should be able to pass the skb in master's ns until L3 processing is completed. This patch series attempts to do that by disassociating this logic from skb->dev and adding it to l3_dev. This >>

Re: [PATCH net-next V2 13/16] net: fec: print more debug info in fec_timeout

2016-03-04 Thread Joe Perches
On Fri, 2016-03-04 at 09:05 -0700, Troy Kisky wrote: > On 3/4/2016 3:06 AM, Fugang Duan wrote: > > From: Troy Kisky Sent: Thursday, February > > 25, 2016 8:37 AM [] > > > Print the current interrupt flags and mask and the interrupt state during > > > the last > > > interrupt in fec_timeout. [] >

Re: [PATCH net-next V2 06/16] net: fec: don't clear all rx queue bits when just one is being checked

2016-03-04 Thread Troy Kisky
On 3/4/2016 9:38 AM, Russell King - ARM Linux wrote: > On Fri, Mar 04, 2016 at 09:18:19AM -0700, Troy Kisky wrote: >> On 3/4/2016 2:11 AM, Fugang Duan wrote: >>> From: Troy Kisky Sent: Thursday, February >>> 25, 2016 8:37 AM To: netdev@vger.kernel.org; da...@davemloft.net; b38...@freescale.co

Re: [PATCH net-next v3 0/3] NSH and VxLAN-GPE

2016-03-04 Thread Tom Herbert
On Tue, Mar 1, 2016 at 3:11 AM, Brian Russell wrote: > These patches add a new module to support encap/decap of Network > Service Header (NSH) as defined in: > > https://tools.ietf.org/html/draft-ietf-sfc-nsh-01 > > Both NSH Type 1 and Type 2 metadata are supported with a simple registration > hoo

Re: pull-request: wireless-drivers 2016-02-18

2016-03-04 Thread Larry Finger
On 03/04/2016 09:29 AM, Kalle Valo wrote: (Adding Larry) Geert Uytterhoeven writes: On Thu, Feb 18, 2016 at 4:28 PM, Kalle Valo wrote: rtlwifi * fix broken VHT (802.11ac) support, reported by Linus That's commit d76d65fd26951498144029c24852c4d54ee512d9 drivers/net/wireless/realtek/rtlw

Re: [PATCH net-next V2 01/10] net/flower: Introduce hardware offload support

2016-03-04 Thread John Fastabend
On 16-03-03 06:55 AM, Amir Vadai wrote: > This patch is based on a patch made by John Fastabend. > It adds support for offloading cls_flower. > when NETIF_F_HW_TC is on: > flags = 0 => Rule will be processed twice - by hardware, and if > still relevant, by software. >

Re: [PATCH net-next V2 02/10] net/flow_dissector: Make dissector_uses_key() and skb_flow_dissector_target() public

2016-03-04 Thread John Fastabend
On 16-03-03 06:55 AM, Amir Vadai wrote: > Will be used in a following patch to query if a key is being used, and > what it's value in the target object. > > Signed-off-by: Amir Vadai > --- Acked-by: John Fastabend Looks like you might roll a v3 feel free to pull these acks forward as well.

Re: [PATCH net-next V2 03/10] net/sched: Macro instead of CONFIG_NET_CLS_ACT ifdef

2016-03-04 Thread John Fastabend
On 16-03-03 06:55 AM, Amir Vadai wrote: > Introduce the macros tc_no_actions and tc_for_each_action to make code > clearer. > > Suggested-by: Jiri Pirko > Signed-off-by: Amir Vadai > --- Acked-by: John Fastabend This should clean up the driver implementation a bit thanks.

[PATCH 02/13] rxrpc: Convert call flag and event numbers into enums

2016-03-04 Thread David Howells
Convert call flag and event numbers into enums and move their definitions outside of the struct. Also move the call state enum outside of the struct and add an extra element to count the number of states. Signed-off-by: David Howells --- net/rxrpc/ar-ack.c |3 + net/rxrpc/ar-call.c

  1   2   3   >