Re: [net-next v2 00/15][pull request] 1GbE Intel Wired LAN Driver Updates 2016-02-24

2016-02-24 Thread Or Gerlitz
On Thu, Feb 25, 2016 at 4:14 AM, Jeff Kirsher wrote: > v2: Dropped patches 6-10 in the original series. Patch 6-7 added support > for character device for AVB and based on community feedback, we do not > want to do this. Patches 8-10 provided fixes to the problematic code > added in

Re: [PATCH v2 net] nfc: close a race condition in llcp_sock_getname()

2016-02-24 Thread Samuel Ortiz
Hi Cong, On Fri, Jan 29, 2016 at 11:37:40AM -0800, Cong Wang wrote: > llcp_sock_getname() checks llcp_sock->dev to make sure > llcp_sock is already connected or bound, however, we could > be in the middle of llcp_sock_bind() where llcp_sock->dev > is bound and llcp_sock->service_name_len is set, >

Re: [PATCH v2 net] nfc: use GFP_USER for user-controlled kmalloc

2016-02-24 Thread Samuel Ortiz
Hi Cong, On Fri, Jan 29, 2016 at 11:24:24AM -0800, Cong Wang wrote: > These two functions are called in sendmsg path, and the > 'len' is passed from user-space, so we should not allow > malicious users to OOM kernel on purpose. > > Reported-by: Dmitry Vyukov > Cc: Lauro Ramos Venancio > Cc: Alo

[PATCH 4/4] net: sctp: Convert log timestamps to be y2038 safe

2016-02-24 Thread Deepa Dinamani
SCTP probe log timestamps use struct timespec which is not y2038 safe. Use struct timespec64 which is 2038 safe instead. Use monotonic time instead of real time as only time differences are logged. Signed-off-by: Deepa Dinamani Cc: Vlad Yasevich Cc: Neil Horman Cc: "David S. Miller" Cc: linux

[PATCH 2/4] net: ipv4: Use y2038 safe functions and data structures

2016-02-24 Thread Deepa Dinamani
ICMP timestamp messages and IP source route options require timestamps to be in milliseconds modulo 24 hours from midnight UT format. Timestamps are calculated from realtime by making a call to getnstimeofday() which uses struct timespec. timespec is not y2038 safe. Replace the above calls with y2

[PATCH 3/4] net: ipv4: tcp_probe: Replace timespec with timespec64

2016-02-24 Thread Deepa Dinamani
TCP probe log timestamps use struct timespec which is not y2038 safe. Even though timespec might be good enough here as it is used to represent delta time, the plan is to get rid of all uses of timespec in the kernel. Replace with struct timespec64 which is y2038 safe. Prints still use unsigned lo

[PATCH 1/4] kernel: time: Add current_nw_timestamp() for network timestamps

2016-02-24 Thread Deepa Dinamani
ICMP timestamp messages and IP source route options require timestamps to be in milliseconds modulo 24 hours from midnight UTC format. Add a time function to support this. The function returns the required timestamp in network byte order. The function also uses y2038 safe time functions and data

[PATCH 0/4] Convert network timestamps to be y2038 safe

2016-02-24 Thread Deepa Dinamani
Introduction: The series is aimed at transitioning network timestamps to being y2038 safe. All patches can be reviewed and merged independently, except for the [PATCH 2/4], which is dependent on the [PATCH 1/4]. Socket timestamps and ioctl calls will be handled separately. Thanks to Arnd Bergman

RE: [PATCH net v4] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-24 Thread Hau
> Fine with me. > > Is there any chance for the set of chipset dependent registers that are safe > to > be read when in D3 state to be documented ? > I think except registers in PCI configuration, all other registers should be read in D0 state. --Please consider the environment before pri

Re: [PATCH net-next RFC] rtnetlink: add new RTM_GETSTATS to dump link stats

2016-02-24 Thread roopa
On 2/24/16, 1:40 PM, David Miller wrote: > From: Roopa Prabhu > Date: Mon, 22 Feb 2016 22:01:33 -0800 > >> From: Roopa Prabhu >> >> This patch adds a new RTM_GETSTATS message to query link stats via netlink >> from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns >> a >> l

[PATCH] net: ndo_fdb_dump should report -EMSGSIZE to rtnl_fdb_dump.

2016-02-24 Thread MINOURA Makoto / 箕浦 真
When the send skbuff reaches the end, nlmsg_put and friends returns -EMSGSIZE but it is silently thrown away in ndo_fdb_dump. It is called within a for_each_netdev loop and the first fdb entry of a following netdev could fit in the remaining skbuff. This breaks the mechanism of cb->args[0] and id

Re: [net-next PATCH v3] ibmvnic: map L2/L3/L4 header descriptors to firmware

2016-02-24 Thread David Miller
From: Thomas Falcon Date: Wed, 24 Feb 2016 21:34:43 -0600 > + > +static union sub_crq *build_hdr_descs_arr(struct sk_buff *skb, > + int *num_entries, > + union sub_crq subcrq, u8 hdr_field) > +{ > + unsigned char *hdr

Re: [PATCH net-next RFC] rtnetlink: add new RTM_GETSTATS to dump link stats

2016-02-24 Thread roopa
On 2/23/16, 1:26 AM, Rosen, Rami wrote: > Hi, > > + if (!dev) > + return -ENODEV; > + > + nskb = nlmsg_new(if_nlmsg_stats_size(dev), GFP_KERNEL); > + if (!nskb) > + return -ENOBUFS; > + > + err = rtnl_fill_statsinfo(nskb, dev, RTM_NEWSTATS, > +

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-02-24 Thread David Miller
From: Diego Viola Date: Tue, 23 Feb 2016 12:04:04 -0300 > The JMC260 network card fails to suspend/resume because the call to > jme_start_irq() was too early, moving the call to jme_start_irq() after > the call to jme_reset_link() makes it work. > > Prior this change suspend/resume would fail un

Re: [PATCH net-next] ppp: clarify parsing of user supplied data in ppp_set_compress()

2016-02-24 Thread David Miller
From: Guillaume Nault Date: Tue, 23 Feb 2016 13:59:43 +0100 > * Split big conditional statement. > * Check (data.length <= CCP_MAX_OPTION_LENGTH) only once. > * Don't read ccp_option[1] if not initialised. > > Reading uninitialised ccp_option[1] was harmless, because this could > only happ

Re: wlcore: Fix regression in wlcore_set_partition()

2016-02-24 Thread Ross Green
On Thu, Feb 25, 2016 at 1:13 PM, Ross Green wrote: > On Thu, Feb 25, 2016 at 11:11 AM, Emil Goode wrote: >> Hello Ross >> >> On Wed, Feb 24, 2016 at 04:40:50PM +1100, Ross Green wrote: >>> On Wed, Feb 17, 2016 at 4:34 PM, Ross Green wrote: >>> > Appreciate your efforts! >>> > >>> > Just trying t

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-24 Thread John Fastabend
On 16-02-24 01:29 AM, Jiri Benc wrote: > On Wed, 24 Feb 2016 00:55:55 -0800, John Fastabend wrote: >> The flags however likely stays with with TCA_U32_FLAGS until there is >> some better way to group common attributes in 'tc' framework. > > That's pretty bad, as this is uAPI and will need to be su

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-24 Thread John Fastabend
On 16-02-24 05:31 AM, Jamal Hadi Salim wrote: > On 16-02-23 02:03 PM, John Fastabend wrote: >> In the initial implementation the only way to stop a rule from being >> inserted into the hardware table was via the device feature flag. >> However this doesn't work well when working on an end host syst

Re: [PATCH net] net/8021q: Check the correct vlan filter capability

2016-02-24 Thread John Fastabend
On 16-02-24 01:48 PM, David Miller wrote: > From: Saeed Mahameed > Date: Wed, 24 Feb 2016 22:27:16 +0200 > Netdev features can be changed dynamically to off after vlan_vid_add was called, thus vlan_vid_del will skip ndo_vlan_rx_kill_vid and will leave the device driver with un-free

Re: [PATCH] bnx2x: add a separate GENEVE Kconfig symbol

2016-02-24 Thread David Miller
From: Yuval Mintz Date: Tue, 23 Feb 2016 18:33:10 + >> When CONFIG_GENEVE is built as a loadable module, and bnx2x is built-in, >> we get this link error: > >> drivers/net/built-in.o: In function `bnx2x_open': >> :(.text+0x33322): undefined reference to `geneve_get_rx_port' >> drivers/net/bu

Re: pull-request: mac80211 2016-02-23

2016-02-24 Thread David Miller
From: Johannes Berg Date: Tue, 23 Feb 2016 10:52:06 +0100 > Unfortunately I neglected to send you a pull request last week, > so it's here now. We gave a number of fairly important fixes > (two found by KASAN, the wext thing that for some reason people > have started seeing issues with) so it'd b

[net-next PATCH v3] ibmvnic: map L2/L3/L4 header descriptors to firmware

2016-02-24 Thread Thomas Falcon
Allow the VNIC driver to provide descriptors containing L2/L3/L4 headers to firmware. This feature is needed for greater hardware compatibility and enablement of offloading technologies for some backing hardware. Signed-off-by: Thomas Falcon --- v2: Fixed typo error caught by kbuild test bot v3:

Re: [PATCH net-next V2 00/16] net: fec: cleanup and fixes

2016-02-24 Thread Joshua Clayton
Hello Troy, I'm replying here instead of to a particular commit because several of the commit messages seem inadequate. The first line summaries all look good. The descriptions should each also include the "user visible impact" of the patch and the justification for it (i.e. why you made the chan

[net-next v2 02/15] e1000e: Increase PHY PLL clock gate timing

2016-02-24 Thread Jeff Kirsher
From: Raanan Avargil Several packet loss issues were reported for which the root cause for them was an incorrect configuration of internal HW PHY clock gating mechanism by SW. This patch provides the correct mechanism. Signed-off-by: Raanan Avargil Tested-by: Aaron Brown Signed-off-by: Jeff Ki

[net-next v2 07/15] igb: constify e1000_phy_operations structure

2016-02-24 Thread Jeff Kirsher
From: Julia Lawall This e1000_phy_operations structure is never modified, so declare it as const. Other structures of this type are already const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel

[net-next v2 14/15] igb: Fix VLAN tag stripping on Intel i350

2016-02-24 Thread Jeff Kirsher
From: Corinna Vinschen Problem: When switching off VLAN offloading on an i350, the VLAN interface gets unusable. For testing, set up a VLAN on an i350 and some remote machine, e.g.: $ ip link add link eth0 name eth0.42 type vlan id 42 $ ip addr add 192.168.42.1/24 dev eth0.42 $ ip link se

[net-next v2 00/15][pull request] 1GbE Intel Wired LAN Driver Updates 2016-02-24

2016-02-24 Thread Jeff Kirsher
This series contains updates to e1000e, igb and igbvf. Raanan provides updates for e1000e, first increases the ULP timer since it now takes longer for the ULP exit to complete on Skylake. Fixes the configuration of the internal hardware PHY clock gating mechanism, which was causing packet loss du

[net-next v2 01/15] e1000e: Increase ULP timer

2016-02-24 Thread Jeff Kirsher
From: Raanan Avargil Due to system level changes introduced in Skylake, ULP exit takes significantly longer to occur. Therefore, driver must wait longer for. Signed-off-by: Raanan Avargil Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 4

[net-next v2 04/15] e1000e: Clear ULP configuration register on ULP exit

2016-02-24 Thread Jeff Kirsher
From: Raanan Avargil There have been bugs caused by HW ULP configuration settings not being properly cleared after cable connect in V-Pro capable systems. This caused HW to get out of sync occasionally. The fix ensures that ULP settings are cleared in HW after LAN cable re-connect. Signed-off-by

[net-next v2 08/15] igb: enable WoL for OEM devices regardless of EEPROM setting

2016-02-24 Thread Jeff Kirsher
From: Todd Fujinaka Override EEPROM settings for specific OEM devices. Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_main.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/ethernet/

[net-next v2 11/15] igb: Add support for generic Tx checksums

2016-02-24 Thread Jeff Kirsher
From: Alexander Duyck This patch adds support for generic Tx checksums to the igb driver. It turns out this is actually pretty easy after going over the datasheet as we were doing a number of steps we didn't need to. In order to perform a Tx checksum for an L4 header we need to fill in the foll

[net-next v2 15/15] igb: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-24 Thread Jeff Kirsher
From: Stefan Assmann Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the curr

[net-next v2 03/15] e1000e: Set HW FIFO minimum pointer gap for non-gig speeds

2016-02-24 Thread Jeff Kirsher
From: Raanan Avargil Based on feedback from HW team, the configured value of the internal PHY HW FIFO pointer gap was incorrect for non-gig speeds. This patch provides the correct configuration. Signed-off-by: Raanan Avargil Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/

[net-next v2 13/15] igbvf: remove "link is Up" message when registering mcast address

2016-02-24 Thread Jeff Kirsher
From: Jon Maxwell A similar issue was addressed a few years ago in the following thread: http://www.spinics.net/lists/netdev/msg245877.html At that time there were concerns that removing this statement may cause other side effects. However the submitter addressed those concerns. But the dialogu

[net-next v2 06/15] igb: When GbE link up, wait for Remote receiver status condition

2016-02-24 Thread Jeff Kirsher
From: Takuma Ueba I210 device IPv6 autoconf test sometimes fails, because DAD NS for link-local is not transmitted. This packet is silently dropped. This problem is seen only GbE environment. igb_watchdog_task link up detection continues to the following process. The following cases are observed

[net-next v2 10/15] igb: rename igb define to be more generic

2016-02-24 Thread Jeff Kirsher
From: Todd Fujinaka E1000_MRQC_ENABLE_RSS_4Q enables 4 and 8 queues depending on the part so rename to be generic. Similarly, E1000_MRQC_ENABLE_VMDQ_RSS_2Q has no numeric meaning so rename to be more generic. Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher ---

[net-next v2 12/15] igbvf: Add support for generic Tx checksums

2016-02-24 Thread Jeff Kirsher
From: Alexander Duyck This patch adds support for generic Tx checksums to the igbvf driver. It turns out this is actually pretty easy after going over the datasheet as we were doing a number of steps we didn't need to. In order to perform a Tx checksum for an L4 header we need to fill in the fo

[net-next v2 09/15] igb: add conditions for I210 to generate periodic clock output

2016-02-24 Thread Jeff Kirsher
From: Roland Hii In general case the maximum supported half cycle time of the synchronized output clock is 70msec. Slower half cycle time than 70msec can be programmed also as long as the output clock is synchronized to whole seconds, useful specifically for generating a 1Hz clock. Permitted val

[net-next v2 05/15] e1000e: Initial support for KabeLake

2016-02-24 Thread Jeff Kirsher
From: Raanan Avargil i219 (4) and i219 (5) are the next LOM generations that will be available on the next Intel platform (KabeLake). This patch provides the initial support for the devices. Signed-off-by: Raanan Avargil Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethe

Re: wlcore: Fix regression in wlcore_set_partition()

2016-02-24 Thread Ross Green
On Thu, Feb 25, 2016 at 11:11 AM, Emil Goode wrote: > Hello Ross > > On Wed, Feb 24, 2016 at 04:40:50PM +1100, Ross Green wrote: >> On Wed, Feb 17, 2016 at 4:34 PM, Ross Green wrote: >> > Appreciate your efforts! >> > >> > Just trying to make sure it does not get lost. >> > Introduced in rc1, not

Re: [PATCH][net-next][v2] bridge: allow the maximum mtu to 64k

2016-02-24 Thread Li RongQing
On Thu, Feb 25, 2016 at 5:44 AM, Stephen Hemminger wrote: >> This is especially annoying for the virtualization case because the >> KVM's tap driver will by default adopt the bridge's MTU on startup >> making it impossible (without the workaround) to use a large MTU on the >> guest VMs. >> >> http

[net-next PATCH] GSO: Provide software checksum of tunneled UDP fragmentation offload

2016-02-24 Thread Alexander Duyck
On reviewing the code I realized that GRE and UDP tunnels could cause a kernel panic if we used GSO to segment a large UDP frame that was sent through the tunnel with an outer checksum and hardware offloads were not available. In order to correct this we need to update the feature flags that are p

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-02-24 Thread Diego Viola
On Tue, Feb 23, 2016 at 1:34 PM, Diego Viola wrote: > On Tue, Feb 23, 2016 at 12:04 PM, Diego Viola wrote: >> The JMC260 network card fails to suspend/resume because the call to >> jme_start_irq() was too early, moving the call to jme_start_irq() after >> the call to jme_reset_link() makes it wor

[PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-02-24 Thread Troy Kisky
queue_id is the qid member of struct bufdesc_prop. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c

[PATCH net-next V2 01/16] net: fec: only check queue 0 if RXF_0/TXF_0 interrupt is set

2016-02-24 Thread Troy Kisky
Before queue 0 was always checked if any queue caused an interrupt. It is better to just mark queue 0 if queue 0 has caused an interrupt. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/et

[PATCH net-next V2 11/16] net: fec: dump all tx queues in fec_dump

2016-02-24 Thread Troy Kisky
Dump all tx queues, not just queue 0. Also, disable fec interrupts first. The interrupts will be reenabled in fec_restart. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 40 +-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a

[PATCH net-next V2 07/16] net: fec: set cbd_sc without relying on previous value

2016-02-24 Thread Troy Kisky
Relying on the wrap bit to stay valid once initialized when the controller also writes to this byte seems undesirable since we can easily know what the value should be. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 38 +-- 1 file changed, 1

[PATCH net-next V2 06/16] net: fec: don't clear all rx queue bits when just one is being checked

2016-02-24 Thread Troy Kisky
FEC_ENET_RXF is 3 separate bits, we only check one queue at a time. So, when the last queue is being checked, it is bad to remove the interrupt on the 1st queue. Also, since this is now done in the napi routine and not the interrupt, it is not needed. Signed-off-by: Troy Kisky --- drivers/net/e

[PATCH net-next V2 10/16] net: fec: clear cbd_sc after transmission to help with debugging

2016-02-24 Thread Troy Kisky
When the tx queue is dumped, it is easier to see that this entry is idle. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 190

[PATCH net-next V2 12/16] net: fec: detect tx int lost

2016-02-24 Thread Troy Kisky
If a tx int is lost, no need to reset the fec. Just mark the event and call napi_schedule. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 38 ++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fe

[PATCH net-next V2 13/16] net: fec: print more debug info in fec_timeout

2016-02-24 Thread Troy Kisky
Print the current interrupt flags and mask and the interrupt state during the last interrupt in fec_timeout. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 1 + drivers/net/ethernet/freescale/fec_main.c | 4 2 files changed, 5 insertions(+) diff --git a/drivers/n

[PATCH net-next V2 05/16] net: fec: split off napi routine with 3 queues

2016-02-24 Thread Troy Kisky
If we only have 1 tx/rx queue, we need not check the other queues. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net

[PATCH net-next V2 14/16] net: fec: create subroutine reset_tx_queue

2016-02-24 Thread Troy Kisky
This creates one place to release any queued tx skbs. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 50 +++ 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/fr

[PATCH net-next V2 08/16] net: fec: eliminate calls to fec_enet_get_prevdesc

2016-02-24 Thread Troy Kisky
This shrinks the code a little. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 37 +-- 1 file changed, 11 insertions(+), 26 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c ind

[PATCH net-next V2 15/16] net: fec: call dma_unmap_single on mapped tx buffers at restart

2016-02-24 Thread Troy Kisky
Make sure any pending tx buffers are unmapped when the fec is restarted. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/frees

[PATCH net-next V2 16/16] net: fec: don't set cbd_bufaddr unless no mapping error

2016-02-24 Thread Troy Kisky
Not assigning cbd_bufaddr on error will prevent trying to unmap the error in case the FEC is reset. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/

[PATCH net-next V2 09/16] net: fec: move restart test for efficiency

2016-02-24 Thread Troy Kisky
This saves 1 comparison. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index b5ed287..1902897 100644 -

[PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-02-24 Thread Troy Kisky
By clearing the NAPI interrupts in the NAPI routine and not in the interrupt handler, we can reduce the number of interrupts. We also don't need any status variables as the registers are still valid. Also, notice that if budget pkts are received, the next call to fec_enet_rx_napi will now continue

[PATCH net-next V2 02/16] net: fec: pass rxq to fec_enet_rx_queue instead of queue_id

2016-02-24 Thread Troy Kisky
The queue_id is the qid member of struct bufdesc_prop. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c

[PATCH net-next V2 00/16] net: fec: cleanup and fixes

2016-02-24 Thread Troy Kisky
V2 is a rebase on top of johannes endian-safe patch and this set is only the next 16 patches. The testing for this series was done on a nitrogen6x. The base commit was commit f5461c27631672b9e95282812ee521c53f502eca Merge branch 'dsa-pass-bridge-to-drivers' Testing showed no change in performa

Re: wlcore: Fix regression in wlcore_set_partition()

2016-02-24 Thread Emil Goode
Hello Ross On Wed, Feb 24, 2016 at 04:40:50PM +1100, Ross Green wrote: > On Wed, Feb 17, 2016 at 4:34 PM, Ross Green wrote: > > Appreciate your efforts! > > > > Just trying to make sure it does not get lost. > > Introduced in rc1, not fixed by ... rc4. > > > > Anyway, I will continue to test, lot

Re: [PATCH v8 5/8] time: Add history to cross timestamp interface supporting slower devices

2016-02-24 Thread John Stultz
On Wed, Feb 24, 2016 at 2:56 AM, Thomas Gleixner wrote: > On Mon, 22 Feb 2016, Christopher S. Hall wrote: >> +{ >> + struct timekeeper *tk = &tk_core.timekeeper; >> + bool interp_forward; >> + u64 corr_raw, corr_real; >> + int ret; > > Once more: > > struct timekeeper *tk =

Re: 4.4.1 skb_warn_bad_offload+0xc5/0x110

2016-02-24 Thread Hannes Frederic Sowa
On 24.02.2016 02:46, Wakko Warner wrote: Please keep me in CC. Wakko Warner wrote: Hannes Frederic Sowa wrote: [full-quote for netdev] Hello, On 16.02.2016 01:08, Wakko Warner wrote: I've been seeing the following on some of my VMs ran under qemu. The VMs do not have internet connectivity

Re: [PATCH] ipv4: in new netns initialize sysctls in net.ipv4.conf.* with defaults

2016-02-24 Thread Eric W. Biederman
David Miller writes: > From: Konstantin Khlebnikov > Date: Sun, 21 Feb 2016 10:11:02 +0300 > >> Currently initial net.ipv4.conf.all.* and net.ipv4.conf.default.* are >> copied from init network namespace because static structures are used >> for init_net. This makes no sense because new netns mi

Re: [PATCH net-next v2 0/3] gianfar: xmit() improvements

2016-02-24 Thread David Miller
From: Claudiu Manoil Date: Tue, 23 Feb 2016 11:48:36 +0200 > Remove redundant operations, improve code locality and maintainability. > Thanks. > > V2: Updated first patch to not touch existing wmb(). Series applied, thanks.

[net-next PATCH v2] ibmvnic: map L2/L3/L4 header descriptors to firmware

2016-02-24 Thread Thomas Falcon
From: root Allow the VNIC driver to provide descriptors containing L2/L3/L4 headers to firmware. This feature is needed for greater hardware compatibility and enablement of offloading technologies for some backing hardware. Signed-off-by: Thomas Falcon --- v2: Fixed typo error caught by kbuild

Re: [PATCH net v4] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-24 Thread Francois Romieu
Chunhao Lin : [...] Fine with me. Is there any chance for the set of chipset dependent registers that are safe to be read when in D3 state to be documented ? -- Ueimor

Re: [net-next 07/20] igb: add a character device to support AVB

2016-02-24 Thread Jeff Kirsher
On Wed, 2016-02-24 at 16:45 -0500, David Miller wrote: > From: Or Gerlitz > Date: Wed, 24 Feb 2016 22:06:25 +0200 > > > On Wed, Feb 24, 2016 at 6:26 AM, Jeff Kirsher > > wrote: > >> From: Gangfeng Huang > >  > >> This patch create a character device for Intel I210 Ethernet > controller, > >  >

Re: [PATCH net] net/8021q: Check the correct vlan filter capability

2016-02-24 Thread David Miller
From: Saeed Mahameed Date: Wed, 24 Feb 2016 22:35:16 +0200 > BTW we choose the first option since the "buggy" function is called > "vlan_hw_filter_capable" which lead us to decide that the function > should be looking for ->hw_features and not ->features. > and i think this way it makes more sens

Re: [PATCH net] net/8021q: Check the correct vlan filter capability

2016-02-24 Thread David Miller
From: Saeed Mahameed Date: Wed, 24 Feb 2016 22:27:16 +0200 >>> Netdev features can be changed dynamically to off after vlan_vid_add >>> was called, thus vlan_vid_del will skip ndo_vlan_rx_kill_vid and will >>> leave the device driver with un-freed resources. >> >> Are you sure the fix isn't to ma

Re: [net-next 07/20] igb: add a character device to support AVB

2016-02-24 Thread David Miller
From: Or Gerlitz Date: Wed, 24 Feb 2016 22:06:25 +0200 > On Wed, Feb 24, 2016 at 6:26 AM, Jeff Kirsher > wrote: >> From: Gangfeng Huang > >> This patch create a character device for Intel I210 Ethernet controller, > > wait, do we want L2 network driver to create char devices > >> it can be u

Re: [PATCH][net-next][v2] bridge: allow the maximum mtu to 64k

2016-02-24 Thread Stephen Hemminger
On Tue, 23 Feb 2016 09:00:56 +0800 roy.qing...@gmail.com wrote: > This is especially annoying for the virtualization case because the > KVM's tap driver will by default adopt the bridge's MTU on startup > making it impossible (without the workaround) to use a large MTU on the > guest VMs. > > htt

Re: [PATCH net-next RFC] rtnetlink: add new RTM_GETSTATS to dump link stats

2016-02-24 Thread David Miller
From: Roopa Prabhu Date: Mon, 22 Feb 2016 22:01:33 -0800 > From: Roopa Prabhu > > This patch adds a new RTM_GETSTATS message to query link stats via netlink > from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a > lot more than just stats and is expensive in some cases

Re: [PATCH net] bpf: fix csum setting for bpf_set_tunnel_key

2016-02-24 Thread David Miller
From: Daniel Borkmann Date: Tue, 23 Feb 2016 02:05:26 +0100 > The fix in 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be correctly > controlled.") changed behavior for bpf_set_tunnel_key() when in use with > IPv6 and thus uncovered a bug that TUNNEL_CSUM needed to be set but wasn't. > As a

Re: [PATCH][net-next][v2] bridge: allow the maximum mtu to 64k

2016-02-24 Thread David Miller
From: roy.qing...@gmail.com Date: Tue, 23 Feb 2016 09:00:56 +0800 > This is especially annoying for the virtualization case because the > KVM's tap driver will by default adopt the bridge's MTU on startup > making it impossible (without the workaround) to use a large MTU on the > guest VMs. So if

[PATCH v5 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-02-24 Thread Bendik Rønning Opstad
Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing the latency for applications sending time-dependent data. Latency-sensitive applications or services, such as online games and remote desktop, produce traffic with thin-stream characteristics, characterized by small packets and

[PATCH v5 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-24 Thread Bendik Rønning Opstad
Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing the latency for applications sending time-dependent data. Latency-sensitive applications or services, such as online games, remote control systems, and VoIP, produce traffic with thin-stream characteristics, characterized by sm

[PATCH v5 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism

2016-02-24 Thread Bendik Rønning Opstad
The existing mechanism for detecting thin streams, tcp_stream_is_thin(), is based on a static limit of less than 4 packets in flight. This treats streams differently depending on the connection's RTT, such that a stream on a high RTT link may never be considered thin, whereas the same application w

Re: [net-next PATCH] ibmvnic: map L2/L3/L4 header descriptors to firmware

2016-02-24 Thread kbuild test robot
Hi Thomas, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Thomas-Falcon/ibmvnic-map-L2-L3-L4-header-descriptors-to-firmware/20160225-033734 config: powerpc-allmodconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/k

Re: [PATCH net-next V2 7/8] net: fec: don't transfer ownership until descriptor write is complete

2016-02-24 Thread Troy Kisky
On 2/6/2016 4:52 AM, Sergei Shtylyov wrote: > Hello. > > On 2/6/2016 12:52 AM, Troy Kisky wrote: > >> If you don't own it, you shouldn't write to it. >> >> Signed-off-by: Troy Kisky >> --- >> drivers/net/ethernet/freescale/fec_main.c | 14 +- >> 1 file changed, 13 insertions(+), 1

Re: [PATCH net-next V2 7/8] net: fec: don't transfer ownership until descriptor write is complete

2016-02-24 Thread Troy Kisky
On 2/5/2016 6:03 PM, Joshua Clayton wrote: > On Fri, 5 Feb 2016 14:52:49 -0700 > Troy Kisky wrote: > >> If you don't own it, you shouldn't write to it. >> >> Signed-off-by: Troy Kisky >> --- >> drivers/net/ethernet/freescale/fec_main.c | 14 +- >> 1 file changed, 13 insertions(+),

Re: [PATCH net] net/8021q: Check the correct vlan filter capability

2016-02-24 Thread Saeed Mahameed
On Wed, Feb 24, 2016 at 10:27 PM, Saeed Mahameed wrote: >>> Netdev features can be changed dynamically to off after vlan_vid_add >>> was called, thus vlan_vid_del will skip ndo_vlan_rx_kill_vid and will >>> leave the device driver with un-freed resources. >> >> Are you sure the fix isn't to make v

Re: [PATCH net-next] bgmac: support Ethernet device on BCM47094 SoC

2016-02-24 Thread David Miller
From: Rafał Miłecki Date: Mon, 22 Feb 2016 22:51:13 +0100 > It needs very similar workarounds to the one on BCM4707. It was tested > on D-Link DIR-885L home router. > > Signed-off-by: Rafał Miłecki Applied, thanks.

Re: [PATCH net 1/5] ppp: lock ppp structure before modifying mru in ppp_ioctl()

2016-02-24 Thread David Miller
From: Guillaume Nault Date: Mon, 22 Feb 2016 20:47:13 +0100 > PPP's Tx and Rx paths read ppp->mru under protection of ppp_xmit_lock() > and ppp_recv_lock() respectively. > Therefore ppp_ioctl() must hold the xmit and recv locks before > concurrently updating ppp->mru. > > Signed-off-by: Guillaum

Re: [PATCH net] net/8021q: Check the correct vlan filter capability

2016-02-24 Thread Saeed Mahameed
>> Netdev features can be changed dynamically to off after vlan_vid_add >> was called, thus vlan_vid_del will skip ndo_vlan_rx_kill_vid and will >> leave the device driver with un-freed resources. > > Are you sure the fix isn't to make vlan_vid_add() check ->features instead > of ->hw_features. Th

Re: [PATCH net-next 0/2] be2net patches

2016-02-24 Thread David Miller
From: Ajit Khaparde Date: Tue, 23 Feb 2016 00:35:15 +0530 > Please consider applying to net-next Series applied, thanks.

Re: [PATCH v8 8/8] net: e1000e: Adds hardware supported cross timestamp on e1000e nic

2016-02-24 Thread Jeff Kirsher
On Mon, 2016-02-22 at 03:15 -0800, Christopher S. Hall wrote: > Modern Intel systems supports cross timestamping of the network > device > clock and Always Running Timer (ART) in hardware.  This allows the > device time and system time to be precisely correlated. The timestamp > pair is returned th

Re: [net-next 07/20] igb: add a character device to support AVB

2016-02-24 Thread Or Gerlitz
On Wed, Feb 24, 2016 at 6:26 AM, Jeff Kirsher wrote: > From: Gangfeng Huang > This patch create a character device for Intel I210 Ethernet controller, wait, do we want L2 network driver to create char devices > it can be used for developing Audio/Video Bridging applications,Industrial > Ethern

[PATCH net-next 1/2] net: l3mdev: address selection should only consider devices in L3 domain

2016-02-24 Thread David Ahern
David Lamparter noted a use case where the source address selection fails to pick an address from a VRF interface - unnumbered interfaces. Relevant commands from his script: ip addr add 9.9.9.9/32 dev lo ip link set lo up ip link add name vrf0 type vrf table 101 ip rule add oif vr

[PATCH net-next v3 2/2] net: l3mdev: prefer VRF master for source address selection

2016-02-24 Thread David Ahern
From: David Lamparter When selecting an address in context of a VRF, the vrf master should be preferred for address selection. If it isn't, the user has a hard time getting the system to select to their preference - the code will pick the address off the first in-VRF interface it can find, which

[PATCH net-next v3 0/2] net: l3mdev: Fix source address for unnumbered deployments

2016-02-24 Thread David Ahern
David Lamparter noted a use case where the source address selection fails to pick an address from a VRF interface - unnumbered interfaces. The use case has the VRF device as the VRF local loopback with addresses and interfaces enslaved without an address themselves. e.g, ip addr add 9.9.9.9/32

[net-next PATCH] ibmvnic: map L2/L3/L4 header descriptors to firmware

2016-02-24 Thread Thomas Falcon
Allow the VNIC driver to provide descriptors containing L2/L3/L4 headers to firmware. This feature is needed for greater hardware compatibility and enablement of offloading technologies for some backing hardware. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 238

Re: [PATCH net-next v2 2/2] net: l3mdev: prefer VRF master for source address selection

2016-02-24 Thread David Miller
From: David Ahern Date: Mon, 22 Feb 2016 10:23:51 -0800 > From: David Lamparter > > When selecting an address in context of a VRF, the vrf master should be > preferred for address selection. If it isn't, the user has a hard time > getting the system to select to their preference - the code wil

Re: [PATCH net] ipv4: only create late gso-skb if skb is already set up with CHECKSUM_PARTIAL

2016-02-24 Thread David Miller
From: Hannes Frederic Sowa Date: Mon, 22 Feb 2016 18:43:25 +0100 > Otherwise we break the contract with GSO to only pass CHECKSUM_PARTIAL > skbs down. This can easily happen with UDP+IPv4 sockets with the first > MSG_MORE write smaller than the MTU, second write is a sendfile. > > Returning -EOP

[PATCH net-next v9 03/16] net: ethtool: add new ETHTOOL_xLINKSETTINGS API

2016-02-24 Thread David Decotigny
From: David Decotigny This patch defines a new ETHTOOL_GLINKSETTINGS/SLINKSETTINGS API, handled by the new get_link_ksettings/set_link_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 4064 bits, variable length), and

[PATCH net-next v9 06/16] net: bonding: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/bonding/bond_main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index a6527d5..b6236ff 100644 --- a/drivers/net/bonding/b

[PATCH net-next v9 07/16] net: ipvlan: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ipvlan/ipvlan_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index a7ca1c5..5802b90 100644 --- a/drivers/net/ipvlan/ipvlan

[PATCH net-next v9 02/16] net: usnic: use __ethtool_get_settings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index ea003ec..1cf19a3 100644 --

[PATCH net-next v9 08/16] net: macvlan: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/macvlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 426a2cc..6e953e3 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -940,

[PATCH net-next v9 05/16] net: usnic: use __ethtool_get_ksettings

2016-02-24 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 1cf19a3..a5bfbba 1

  1   2   3   >