Re: Variable download speed

2016-02-23 Thread sdrb
On Tue, 23 Feb 2016, Neal Cardwell wrote: On Tue, Feb 23, 2016 at 8:57 AM, wrote: I published example pcap file under following link: https://www.dropbox.com/s/v8375ub16seyt1a/test7.pcap?dl=0 I hope it is possible to download it without creating dropbox account. Thanks for the trace. It

Re: [PATCH 00/33] Compile-time stack metadata validation

2016-02-23 Thread Ingo Molnar
* Josh Poimboeuf wrote: > Hi Ingo, > > On Tue, Feb 23, 2016 at 09:14:06AM +0100, Ingo Molnar wrote: > > So I tried out this latest stacktool series and it looks mostly good for an > > upstream merge. > > > > To help this effort move forward I've applied the preparatory/fix patches > > that a

Re: [PATCH can-next v2 1/2] CAN: rcar: add gen[12] fallback compatibility strings

2016-02-23 Thread Geert Uytterhoeven
On Wed, Feb 24, 2016 at 2:56 AM, Simon Horman wrote: > Add fallback compatibility string for R-Car Gen 1 and Gen2. > > In the case of Renesas R-Car hardware we know that there are generations of > SoCs, e.g. Gen 1 and Gen 2. But beyond that its not clear what the > relationship between IP blocks m

Re: [PATCH can-next v2 2/2] CAN: rcar: add device tree support for r8a779[234]

2016-02-23 Thread Geert Uytterhoeven
On Wed, Feb 24, 2016 at 2:56 AM, Simon Horman wrote: > Simply document new compatibility string. > As a previous patch adds a generic R-Car Gen2 compatibility string > there appears to be no need for a driver updates. > > By documenting these compat stings they may be used in DTSs shipped, for > e

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-23 Thread John Fastabend
On 16-02-23 10:11 PM, Simon Horman wrote: > On Tue, Feb 23, 2016 at 11:03:21AM -0800, John Fastabend wrote: >> In the initial implementation the only way to stop a rule from being >> inserted into the hardware table was via the device feature flag. >> However this doesn't work well when working on

Re: [patch net-next v2 1/9] Introduce devlink infrastructure

2016-02-23 Thread Jiri Pirko
Tue, Feb 23, 2016 at 10:19:48PM CET, ja...@redhat.com wrote: >On Tue, Feb 23, 2016 at 04:51:26PM +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Introduce devlink infrastructure for drivers to register and expose to >> userspace via generic Netlink interface. >> >> There are two basic objects

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Jiri Pirko
Tue, Feb 23, 2016 at 06:31:39PM CET, step...@networkplumber.org wrote: >On Tue, 23 Feb 2016 12:26:00 +0100 >Hannes Frederic Sowa wrote: > >> Hi Jiri, >> >> On 22.02.2016 19:31, Jiri Pirko wrote: >> > From: Jiri Pirko >> > >> > So far, there has been an mlx4-specific sysfs file allowing user to >

RE: [patch net-next 1/9] Introduce devlink infrastructure

2016-02-23 Thread Yuval Mintz
> + * An overall lock guarding every operation comming from userspace. > + * If also guards devlink devices list and it is taken when > + * driver registers/unregisters it. Several typos in comment. > +static void devlink_notify(struct devlink *devlink, enum > +devlink_command cmd) { ... > + W

Re: net: memory leak in mkiss_open

2016-02-23 Thread Cong Wang
On Mon, Feb 22, 2016 at 2:05 AM, Dmitry Vyukov wrote: > unreferenced object 0x8800628991d8 (size 4096): > comm "a.out", pid 7081, jiffies 4294920662 (age 35.917s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 61 78 30 00 00 00 00 00 ax0. > 00 00 00 00 00 00 00

[PATCH net v4] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-23 Thread Chunhao Lin
There will be a log spam when there is no cable plugged. Please refer to following links. https://bugzilla.kernel.org/show_bug.cgi?id=104351 https://bugzilla.kernel.org/show_bug.cgi?id=107421 This issue is caused by runtime power management. When there is no cable plugged, the driver will be suspe

Re: [net-next PATCH 1/4] net: sched: consolidate offload decision in cls_u32

2016-02-23 Thread Simon Horman
On Tue, Feb 23, 2016 at 11:02:33AM -0800, John Fastabend wrote: > The offload decision was originally very basic and tied to if the dev > implemented the appropriate ndo op hook. The next step is to allow > the user to more flexibly define if any paticular rule should be > offloaded or not. In orde

Re: [net-next PATCH 2/4] net: cls_u32: move TC offload feature bit into cls_u32 offload logic

2016-02-23 Thread Simon Horman
On Tue, Feb 23, 2016 at 11:02:56AM -0800, John Fastabend wrote: > In the original series drivers would get offload requests for cls_u32 > rules even if the feature bit is disabled. This meant the driver had > to do a boiler plate check on the feature bit before adding/deleting > the rule. > > This

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-23 Thread Simon Horman
On Tue, Feb 23, 2016 at 11:03:21AM -0800, John Fastabend wrote: > In the initial implementation the only way to stop a rule from being > inserted into the hardware table was via the device feature flag. > However this doesn't work well when working on an end host system > where packets are expect t

Re: [net-next PATCH v2 1/5] introduce IFE action

2016-02-23 Thread Simon Horman
On Tue, Feb 23, 2016 at 05:12:34PM +0100, Daniel Borkmann wrote: > On 02/23/2016 03:39 PM, Jamal Hadi Salim wrote: > >On 16-02-23 08:32 AM, Daniel Borkmann wrote: > >>On 02/23/2016 01:49 PM, Jamal Hadi Salim wrote: > >>>From: Jamal Hadi Salim > >>> > >>>This action allows for a sending side to enc

Re: wlcore: Fix regression in wlcore_set_partition()

2016-02-23 Thread Ross Green
On Wed, Feb 17, 2016 at 4:34 PM, Ross Green wrote: > Appreciate your efforts! > > Just trying to make sure it does not get lost. > Introduced in rc1, not fixed by ... rc4. > > Anyway, I will continue to test, lots of other things still to chase > even in rc4! > > Regards, > > Ross Green > > On Wed

Re: [PATCH] ipv4: in new netns initialize sysctls in net.ipv4.conf.* with defaults

2016-02-23 Thread Konstantin Khlebnikov
On Wed, Feb 24, 2016 at 2:21 AM, David Miller wrote: > From: Konstantin Khlebnikov > Date: Sun, 21 Feb 2016 10:11:02 +0300 > >> Currently initial net.ipv4.conf.all.* and net.ipv4.conf.default.* are >> copied from init network namespace because static structures are used >> for init_net. This make

Re: [net-next RFC 0/4] SO_BINDTOSUBNET

2016-02-23 Thread Tom Herbert
On Tue, Feb 23, 2016 at 7:27 AM, Gilberto Bertin wrote: > This series introduces support for the SO_BINDTOSUBNET socket option, which > allows a listener socket to bind to a subnet instead of * or a single address. > > Motivation: > consider a set of servers, each one with thousands and thousands

Re: [net-next 13/15] i40e/i40evf: use logical operators, not bitwise

2016-02-23 Thread Jeff Kirsher
On Mon, 2016-02-22 at 08:33 -0800, Alexander Duyck wrote: > On Wed, Feb 17, 2016 at 7:38 PM, Jeff Kirsher > wrote: > > From: Mitch Williams > > > > Mr. Spock would certainly raise an eyebrow to see us using bitwise > > operators, when we should clearly be relying on logic. Fascinating. > > > > Ch

[net-next 01/20] e1000e: Increase ULP timer

2016-02-23 Thread Jeff Kirsher
From: Raanan Avargil Due to system level changes introduced in Skylake, ULP exit takes significantly longer to occur. Therefore, driver must wait longer for. Signed-off-by: Raanan Avargil Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 4

[net-next 17/20] igbvf: Add support for generic Tx checksums

2016-02-23 Thread Jeff Kirsher
From: Alexander Duyck This patch adds support for generic Tx checksums to the igbvf driver. It turns out this is actually pretty easy after going over the datasheet as we were doing a number of steps we didn't need to. In order to perform a Tx checksum for an L4 header we need to fill in the fo

[net-next 02/20] e1000e: Increase PHY PLL clock gate timing

2016-02-23 Thread Jeff Kirsher
From: Raanan Avargil Several packet loss issues were reported for which the root cause for them was an incorrect configuration of internal HW PHY clock gating mechanism by SW. This patch provides the correct mechanism. Signed-off-by: Raanan Avargil Tested-by: Aaron Brown Signed-off-by: Jeff Ki

[net-next 08/20] igb: fix compare_const_fl.cocci warnings

2016-02-23 Thread Jeff Kirsher
From: Julia Lawall Kernel code typically uses == NULL. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Gangfeng Huang Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_cdev.c |

[net-next 14/20] igb: add conditions for I210 to generate periodic clock output

2016-02-23 Thread Jeff Kirsher
From: Roland Hii In general case the maximum supported half cycle time of the synchronized output clock is 70msec. Slower half cycle time than 70msec can be programmed also as long as the output clock is synchronized to whole seconds, useful specifically for generating a 1Hz clock. Permitted val

[net-next 04/20] e1000e: Clear ULP configuration register on ULP exit

2016-02-23 Thread Jeff Kirsher
From: Raanan Avargil There have been bugs caused by HW ULP configuration settings not being properly cleared after cable connect in V-Pro capable systems. This caused HW to get out of sync occasionally. The fix ensures that ULP settings are cleared in HW after LAN cable re-connect. Signed-off-by

[net-next 06/20] igb: add function to set I210 transmit mode

2016-02-23 Thread Jeff Kirsher
From: Gangfeng Huang I210 supports two transmit modes, legacy and QAV. The transmit mode is configured in TQAVCTRL.QavMode register. Before this patch igb driver only support legacy mode. This patch makes it possible to configure the transmit mode. Example: Get the transmit mode: $ echo /sys/cla

[net-next 05/20] e1000e: Initial support for KabeLake

2016-02-23 Thread Jeff Kirsher
From: Raanan Avargil i219 (4) and i219 (5) are the next LOM generations that will be available on the next Intel platform (KabeLake). This patch provides the initial support for the devices. Signed-off-by: Raanan Avargil Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethe

[net-next 12/20] igb: constify e1000_phy_operations structure

2016-02-23 Thread Jeff Kirsher
From: Julia Lawall This e1000_phy_operations structure is never modified, so declare it as const. Other structures of this type are already const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel

[net-next 03/20] e1000e: Set HW FIFO minimum pointer gap for non-gig speeds

2016-02-23 Thread Jeff Kirsher
From: Raanan Avargil Based on feedback from HW team, the configured value of the internal PHY HW FIFO pointer gap was incorrect for non-gig speeds. This patch provides the correct configuration. Signed-off-by: Raanan Avargil Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/

[net-next 15/20] igb: rename igb define to be more generic

2016-02-23 Thread Jeff Kirsher
From: Todd Fujinaka E1000_MRQC_ENABLE_RSS_4Q enables 4 and 8 queues depending on the part so rename to be generic. Similarly, E1000_MRQC_ENABLE_VMDQ_RSS_2Q has no numeric meaning so rename to be more generic. Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher ---

[net-next 07/20] igb: add a character device to support AVB

2016-02-23 Thread Jeff Kirsher
From: Gangfeng Huang This patch create a character device for Intel I210 Ethernet controller, it can be used for developing Audio/Video Bridging applications,Industrial Ethernet applications which require precise timing control over frame transmission, or test harnesses for measuring system laten

[net-next 18/20] igbvf: remove "link is Up" message when registering mcast address

2016-02-23 Thread Jeff Kirsher
From: Jon Maxwell A similar issue was addressed a few years ago in the following thread: http://www.spinics.net/lists/netdev/msg245877.html At that time there were concerns that removing this statement may cause other side effects. However the submitter addressed those concerns. But the dialogu

[net-next 00/20][pull request] 1GbE Intel Wired LAN Driver Updates 2016-02-23

2016-02-23 Thread Jeff Kirsher
This series contains updates to e1000e, igb and igbvf. Raanan provides updates for e1000e, first increases the ULP timer since it now takes longer for the ULP exit to complete on Skylake. Fixes the configuration of the internal hardware PHY clock gating mechanism, which was causing packet loss du

[net-next 20/20] igb: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-23 Thread Jeff Kirsher
From: Stefan Assmann Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the curr

[net-next 16/20] igb: Add support for generic Tx checksums

2016-02-23 Thread Jeff Kirsher
From: Alexander Duyck This patch adds support for generic Tx checksums to the igb driver. It turns out this is actually pretty easy after going over the datasheet as we were doing a number of steps we didn't need to. In order to perform a Tx checksum for an L4 header we need to fill in the foll

[net-next 19/20] igb: Fix VLAN tag stripping on Intel i350

2016-02-23 Thread Jeff Kirsher
From: Corinna Vinschen Problem: When switching off VLAN offloading on an i350, the VLAN interface gets unusable. For testing, set up a VLAN on an i350 and some remote machine, e.g.: $ ip link add link eth0 name eth0.42 type vlan id 42 $ ip addr add 192.168.42.1/24 dev eth0.42 $ ip link se

[net-next 11/20] igb: When GbE link up, wait for Remote receiver status condition

2016-02-23 Thread Jeff Kirsher
From: Takuma Ueba I210 device IPv6 autoconf test sometimes fails, because DAD NS for link-local is not transmitted. This packet is silently dropped. This problem is seen only GbE environment. igb_watchdog_task link up detection continues to the following process. The following cases are observed

[net-next 13/20] igb: enable WoL for OEM devices regardless of EEPROM setting

2016-02-23 Thread Jeff Kirsher
From: Todd Fujinaka Override EEPROM settings for specific OEM devices. Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_main.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/ethernet/

[net-next 10/20] igb: fix semicolon.cocci warnings

2016-02-23 Thread Jeff Kirsher
From: Julia Lawall Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Gangfeng Huang Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_cdev.c | 2 +- 1 file ch

[net-next 09/20] igb: fix itnull.cocci warnings

2016-02-23 Thread Jeff Kirsher
From: Julia Lawall The index variable of list_for_each_entry_safe should never be NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci CC: Gangfeng Huang Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/eth

Vr headset,vr box,Vr glasses,$6/pc from the original factory

2016-02-23 Thread Raymond
Dear Happy 2016, Hottest VR box,for mobile phone,Watch 3D movie and vr video,Play vr games Price only $6/pc now,only from the arcpeaks factory Alibaba link,http://arcpeaks.en.alibaba.com/product/60401287002-802634136/2016_hottest_product_virtual_reality_3d_games_and_video_3d_vr_glasses.html Ple

[PATCHv3] net: fix bridge multicast packet checksum validation

2016-02-23 Thread Linus Lüssing
We need to update the skb->csum after pulling the skb, otherwise an unnecessary checksum (re)computation can ocure for IGMP/MLD packets in the bridge code. Additionally this fixes the following splats for network devices / bridge ports with support for and enabled RX checksum offloading: [...] [

Re: [PATCH RFC 0/6] NCSI Support

2016-02-23 Thread Gavin Shan
On Mon, Nov 09, 2015 at 11:10:00AM +1100, Gavin Shan wrote: Hello David, did you get time to go through this series? It has been there for a while. Looking forward to your comments and feedback :-) Thanks, Gavin >This series of patches are prototype requesting for comments. Please focus on >the

[PATCH can-next v2 2/2] CAN: rcar: add device tree support for r8a779[234]

2016-02-23 Thread Simon Horman
Simply document new compatibility string. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. By documenting these compat stings they may be used in DTSs shipped, for example as part of ROMs. They must be used in conjunction with the

[PATCH can-next v2 0/2] CAN: rcar: add fallback and r8a779[234] bindings

2016-02-23 Thread Simon Horman
Hi, this series adds fallback bindings for R-Car Gen 1 and Gen 2 SoCs and SoC-specific bindings for the r8a779[234] SoCs which are R-Car Gen 2 SoCs. The aim is to provide consistent bindings for R-Car Gen 1 and Gen 2 SoCs in a maner consistent with that progressively being used for drivers for ot

[PATCH can-next v2 1/2] CAN: rcar: add gen[12] fallback compatibility strings

2016-02-23 Thread Simon Horman
Add fallback compatibility string for R-Car Gen 1 and Gen2. In the case of Renesas R-Car hardware we know that there are generations of SoCs, e.g. Gen 1 and Gen 2. But beyond that its not clear what the relationship between IP blocks might be. For example, I believe that r8a7779 is older than r8a7

Re: 4.4.1 skb_warn_bad_offload+0xc5/0x110

2016-02-23 Thread Wakko Warner
Please keep me in CC. Wakko Warner wrote: > > Hannes Frederic Sowa wrote: > > [full-quote for netdev] > > > > Hello, > > > > On 16.02.2016 01:08, Wakko Warner wrote: > > >I've been seeing the following on some of my VMs ran under qemu. The VMs > > >do > > >not have internet connectivity. Thi

Re: [PATCHv2] net: fix bridge multicast packet checksum validation

2016-02-23 Thread kbuild test robot
Hi Linus, [auto build test ERROR on net/master] [also build test ERROR on v4.5-rc5 next-20160223] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Linus-L-ssing/net-fix-bridge-multicast-packet

[PATCHv2] net: fix bridge multicast packet checksum validation

2016-02-23 Thread Linus Lüssing
We need to update the skb->csum after pulling the skb, otherwise an unnecessary checksum (re)computation can ocure for IGMP/MLD packets in the bridge code. Additionally this fixes the following splats for network devices / bridge ports with support for and enabled RX checksum offloading: [...] [

Re: 4.4.1 skb_warn_bad_offload+0xc5/0x110

2016-02-23 Thread Wakko Warner
Please keep me in CC. Hannes Frederic Sowa wrote: > [full-quote for netdev] > > Hello, > > On 16.02.2016 01:08, Wakko Warner wrote: > >I've been seeing the following on some of my VMs ran under qemu. The VMs do > >not have internet connectivity. This happened when some files were accessed > >v

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-23 Thread Tom Herbert
> [ I really hope we can figure out a way not to change IP IDs, because I think > an inverted version of Tom's generic TSO could also work as a generic h/w GRO > accelerator. In its simplest form, the hardware just remembers the previous > packet, then gives us the length of the common prefix. If

Re: Invalid sk_policy[] access

2016-02-23 Thread David Miller
From: Sowmini Varadhan Date: Tue, 23 Feb 2016 18:59:46 -0500 > But then it's odd that the struct sizes (esp of things like > request_sock, which are not config dependant) are not the same. Every structure that has a lock, or something that contains a lock (such as a timer or whatever), has a la

Re: [PATCH net] bnxt_en: Fix zero padding of tx push data.

2016-02-23 Thread David Miller
From: Michael Chan Date: Mon, 22 Feb 2016 02:10:26 -0500 > The arithmetic to zero pad the last 64-bit word in the push buffer is not > correct. > > 1. It should be pdata + length to get to the end. > 2. 'pdata' is void pointer and passing it to PTR_ALIGN() will cast the > aligned pointer to void

Re: [PATCH v3] tunnel: Clear IPCB(skb)->opt before dst_link_failure called

2016-02-23 Thread David Miller
From: Bernie Harris Date: Mon, 22 Feb 2016 12:58:05 +1300 > IPCB may contain data from previous layers (in the observed case the > qdisc layer). In the observed scenario, the data was misinterpreted as > ip header options, which later caused the ihl to be set to an invalid > value (<5). This resu

Re: [PATCH] tcp: convert cached rtt from usec to jiffies when feeding initial rto

2016-02-23 Thread David Miller
From: Konstantin Khlebnikov Date: Sun, 21 Feb 2016 10:12:39 +0300 > Currently it's converted into msecs, thus HZ=1000 intact. > > Signed-off-by: Konstantin Khlebnikov > Fixes: 740b0f1841f6 ("tcp: switch rtt estimations to usec resolution") Applied and queued up for -stable, thanks.

Re: Invalid sk_policy[] access

2016-02-23 Thread Sowmini Varadhan
> > Since there are no config-dependent difference in the struct, maybe it's > > a compiler version difference for padding/optimization instead? > > Changing the layout of a structure would break ABI, so unlikely. > > I've never used crash, so I have no idea where it gets it's > information from

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-23 Thread John Fastabend
On 16-02-23 02:29 PM, Samudrala, Sridhar wrote: > > > On 2/23/2016 11:03 AM, John Fastabend wrote: >> In the initial implementation the only way to stop a rule from being >> inserted into the hardware table was via the device feature flag. >> However this doesn't work well when working on an end

Re: [PATCH] ipv4: in new netns initialize sysctls in net.ipv4.conf.* with defaults

2016-02-23 Thread David Miller
From: Konstantin Khlebnikov Date: Sun, 21 Feb 2016 10:11:02 +0300 > Currently initial net.ipv4.conf.all.* and net.ipv4.conf.default.* are > copied from init network namespace because static structures are used > for init_net. This makes no sense because new netns might be created > from any netns

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-23 Thread David Miller
From: Edward Cree Date: Tue, 23 Feb 2016 20:20:50 + > So VJ implementations that can't handle it really are buggy, not > just exhibiting a difference of opinion. Buggy or not, they exist, and we have to cope with them.

Re: Invalid sk_policy[] access

2016-02-23 Thread David Miller
From: Sowmini Varadhan Date: Tue, 23 Feb 2016 15:53:29 -0500 > On (02/23/16 22:51), mr...@linux.ee wrote: >> Since there are no config-dependent difference in the struct, maybe it's >> a compiler version difference for padding/optimization instead? > > possibly. The v440 is using a Debian 4.6.

Re: Invalid sk_policy[] access

2016-02-23 Thread David Miller
From: mr...@linux.ee Date: Tue, 23 Feb 2016 22:51:01 +0200 (EET) >> > Indeed, the kernel is 64-bit in both cases. >> > And the userland bit-arity has no relevance whatsoever for this bug. >> >> hang on; The sizeof (and offsetof) values I listed were obtained either >> from /usr/bin/crash (on the

Re: [PATCH net v3] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-23 Thread Francois Romieu
Chunhao Lin : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 537974c..404be51 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c [...] > @@ -7853,6 +7859,11 @@ static int rtl8169_runtime_susp

Re: [PATCH v2 2/4] Documentation: Bindings: Add STM32 DWMAC glue

2016-02-23 Thread Joachim Eastwood
Hi Alexandre, You should copy 'devicet...@vger.kernel.org' on bindings doc. Adding cc here. On 23 February 2016 at 16:10, Alexandre TORGUE wrote: > Signed-off-by: Alexandre TORGUE > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt > b/Documentation/devicetree/bindings/net/s

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-23 Thread Samudrala, Sridhar
On 2/23/2016 11:03 AM, John Fastabend wrote: In the initial implementation the only way to stop a rule from being inserted into the hardware table was via the device feature flag. However this doesn't work well when working on an end host system where packets are expect to hit both the hardware

RESEND: Easily reproducible kernel panic due to netdev all_adj_list refcnt handling

2016-02-23 Thread Andrew Collins
I'm running into a relatively easily reproducible kernel panic related to the all_adj_list handling for netdevs in recent kernels. The following sequence of commands will reproduce the issue: ip link add link eth0 name eth0.100 type vlan id 100 ip link add link eth0 name eth0.200 type vlan id 2

Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

2016-02-23 Thread Cong Wang
On Tue, Feb 23, 2016 at 5:14 AM, Jamal Hadi Salim wrote: > On 16-02-22 06:57 PM, Cong Wang wrote: > > [..] > >> >> diff --git a/include/net/act_api.h b/include/net/act_api.h >> index 8c4e3ff..342be6c 100644 >> --- a/include/net/act_api.h >> +++ b/include/net/act_api.h >> @@ -7,6 +7,8 @@ >> >> #i

Re: [PATCH v2 1/4] net: ethernet: dwmac: add Ethernet glue logic for stm32 chip

2016-02-23 Thread Joachim Eastwood
Hi Alexandre, On 23 February 2016 at 16:10, Alexandre TORGUE wrote: > stm324xx family chips support Synopsys MAC 3.510 IP. > This patch adds settings for logical glue logic: > -clocks > -mode selection MII or RMII. > > Signed-off-by: Alexandre TORGUE > > diff --git a/drivers/net/ethernet/stmicro

Re: [net-next PATCH v2 1/5] introduce IFE action

2016-02-23 Thread Cong Wang
On Tue, Feb 23, 2016 at 4:49 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > This action allows for a sending side to encapsulate arbitrary metadata > which is decapsulated by the receiving end. > The sender runs in encoding mode and the receiver in decode mode. > Both sender and receive

Re: [PATCHv2 09/10] rfkill: Userspace control for airplane mode

2016-02-23 Thread Pavel Machek
On Tue 2016-02-23 21:55:14, Johannes Berg wrote: > On Tue, 2016-02-23 at 21:45 +0100, Pavel Machek wrote: > > > So... you add LED trigger to display the state of the airplane > > mode. Ok, why not. > > Yes. However, consider that "the airplane mode" isn't a well-defined > concept; some systems ma

Re: [net-next PATCH v2 1/5] introduce IFE action

2016-02-23 Thread Cong Wang
On Tue, Feb 23, 2016 at 8:12 AM, Daniel Borkmann wrote: > On 02/23/2016 03:39 PM, Jamal Hadi Salim wrote: >> >> On 16-02-23 08:32 AM, Daniel Borkmann wrote: >>> >>> On 02/23/2016 01:49 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim This action allows for a sending side to

Re: [patch net-next v2 1/9] Introduce devlink infrastructure

2016-02-23 Thread Jarod Wilson
On Tue, Feb 23, 2016 at 04:51:26PM +0100, Jiri Pirko wrote: > From: Jiri Pirko > > Introduce devlink infrastructure for drivers to register and expose to > userspace via generic Netlink interface. > > There are two basic objects defined: > devlink - one instance for every "parent device", for ex

PCIe 1Gbps NIC card with Linux driver support

2016-02-23 Thread Murali Karicheri
All, I have to integrate and test a PCIe RC on one of our SoC using a 1Gpbs PCIe NIC card that has driver support available in v4.4.x kernel. Can someone recommend one? I see few listed below which seems to have driver. I have indicated the driver I could find in the kernel source tree. If the

[PATCH net] Propagate MAC address changes to VLANs

2016-02-23 Thread Mike Manning
The MAC address of the physical interface is only copied to the VLAN when it is first created, resulting in an inconsistency after MAC address changes of only newly created VLANs having an up-to-date MAC. Continuing to inherit the MAC address unless explicitly changed for the VLAN allows IPv6 EUI

Re: [PATCHv2 09/10] rfkill: Userspace control for airplane mode

2016-02-23 Thread Johannes Berg
On Tue, 2016-02-23 at 21:45 +0100, Pavel Machek wrote: > So... you add LED trigger to display the state of the airplane > mode. Ok, why not. Yes. However, consider that "the airplane mode" isn't a well-defined concept; some systems may want to light up that LED even when wifi is still enabled, si

Re: Invalid sk_policy[] access

2016-02-23 Thread mroos
> > Indeed, the kernel is 64-bit in both cases. > > And the userland bit-arity has no relevance whatsoever for this bug. > > hang on; The sizeof (and offsetof) values I listed were obtained either > from /usr/bin/crash (on the T5) or from simple printk's of the structures > in the case of the v440

Re: Invalid sk_policy[] access

2016-02-23 Thread Sowmini Varadhan
On (02/23/16 22:51), mr...@linux.ee wrote: > Since there are no config-dependent difference in the struct, maybe it's > a compiler version difference for padding/optimization instead? possibly. The v440 is using a Debian 4.6.3-14 gcc, while the T5 is using "4.4.7 20120313 (Red Hat 4.4.7-4)" But

Re: [PATCHv2 09/10] rfkill: Userspace control for airplane mode

2016-02-23 Thread Pavel Machek
Hi! [BTW you should probably Cc people responsible for LED subsystem...] > Provide an interface for the airplane-mode indicator be controlled from > userspace. User has to first acquire the control through > RFKILL_OP_AIRPLANE_MODE_ACQUIRE and keep the fd open for the whole time > it wants to be

Re: [PATCHv2 04/10] rfkill: Move "state" sysfs file back to stable

2016-02-23 Thread Pavel Machek
On Mon 2016-02-22 11:36:35, João Paulo Rechi Vita wrote: > There is still quite a bit of code using this interface, so we can't > just remove it. Hopefully it will be possible in the future, but since > its scheduled removal date is past 2 years already, we are better having > the documentation ref

Re: Invalid sk_policy[] access (was Re: Recent spontaneous reboots on multiple machines)

2016-02-23 Thread Meelis Roos
> > However, I have not succeeded in reproducing the problem at will - git > > checkout of another release + subsequent compile still does not trigger > > it. But if it is the same problem, it seems to go int triple fault or > > something similar for me to cause it reboot with no trace in the >

Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio

2016-02-23 Thread Johannes Berg
On Tue, 2016-02-23 at 16:06 +0100, Arnd Bergmann wrote: >  > Does rfkill always have a separate device in the Linux driver model? Yes, the rfkill core code registers and adds one in the rfkill class. > johannes

Re: Invalid sk_policy[] access

2016-02-23 Thread mroos
> > Indeed, the kernel is 64-bit in both cases. > > And the userland bit-arity has no relevance whatsoever for this bug. > > hang on; The sizeof (and offsetof) values I listed were obtained either > from /usr/bin/crash (on the T5) or from simple printk's of the structures > in the case of the v440

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-23 Thread Edward Cree
On 23/02/16 18:08, David Miller wrote: > From: Edward Cree > Date: Tue, 23 Feb 2016 17:38:28 + > >> "The IPv4 ID field MUST NOT be used for purposes other than fragmentation >> and reassembly."(§4.1) >> "Originating sources MAY set the IPv4 ID field of atomic datagrams to any >> value."(§4.1

Re: Invalid sk_policy[] access

2016-02-23 Thread Sowmini Varadhan
On (02/23/16 15:20), David Miller wrote: > Indeed, the kernel is 64-bit in both cases. > And the userland bit-arity has no relevance whatsoever for this bug. hang on; The sizeof (and offsetof) values I listed were obtained either from /usr/bin/crash (on the T5) or from simple printk's of the struc

Re: Invalid sk_policy[] access

2016-02-23 Thread David Miller
From: Meelis Roos Date: Tue, 23 Feb 2016 21:36:24 +0200 (EET) > Sorry, I do not understand - what is 32-bit on V440? The kernel should > be 64-bit since it's sun4u. Indeed, the kernel is 64-bit in both cases. And the userland bit-arity has no relevance whatsoever for this bug.

Re: [PATCH net-next 0/4] net: dsa: pass bridge device to drivers

2016-02-23 Thread David Miller
From: Vivien Didelot Date: Fri, 12 Feb 2016 12:09:37 -0500 > This patchset simplifies the DSA layer. > > A switch may support multiple bridges with the same hardware VLAN. Thus a > check > such as dsa_bridge_check_vlan_range must be moved from the DSA layer to the > concerned driver. > > The f

Re: pull request [net-next]: batman-adv 20160223

2016-02-23 Thread David Miller
From: Antonio Quartulli Date: Tue, 23 Feb 2016 14:08:03 +0800 > This is another pull request intended for net-next and it is > basically all cleanup work, mostly by Sven Eckelmann. > > First the BATADV_BONDING_TQ_THRESHOLD > constant gets removed as it was defined but not used anywhere, > then a

Re: Invalid sk_policy[] access (was Re: Recent spontaneous reboots on multiple machines)

2016-02-23 Thread Meelis Roos
> I figured out what's the root-cause of my panics. Great! > sizeof 32-bit64-bit > --- > request_sock 256 312 > inet_request_sock 272 328 > sock 688 1216 > > And offsetof sk_p

Re: Invalid sk_policy[] access (was Re: Recent spontaneous reboots on multiple machines)

2016-02-23 Thread Sowmini Varadhan
On (02/23/16 21:36), Meelis Roos wrote: > Sorry, I do not understand - what is 32-bit on V440? The kernel should > be 64-bit since it's sun4u. v440# getconf LONG_BIT 32 v440# uname -a Linux v440 4.4.0-rc3-roos-00790-g264a4ac-dirty #200 SMP Mon Feb 22 19:06:21 PST 2016 sparc64 GNU/Linux > Howe

Re: [net-next PATCH 5/5] Support to encoding decoding skb queue map on IFE action

2016-02-23 Thread John Fastabend
On 16-02-23 04:17 AM, Jamal Hadi Salim wrote: > On 16-02-22 04:03 PM, John Fastabend wrote: >> On 16-02-22 05:21 AM, Jamal Hadi Salim wrote: >>> From: Jamal Hadi Salim >>> >>> hard code static value of 10 for qmap >>> mark of 12 >>> prio of 13 >>> and hashid of 11 >>> >>> sudo tc filter add dev $E

[PATCH 2/2] net: qca_spi: clear IFF_TX_SKB_SHARING

2016-02-23 Thread Stefan Wahren
ether_setup sets IFF_TX_SKB_SHARING but this is not supported by qca_spi as it modifies the skb on xmit. Signed-off-by: Stefan Wahren Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet over SPI driver for QCA7000) --- drivers/net/ethernet/qualcomm/qca_spi.c |1 + 1 file changed, 1 insertion(+)

[PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST

2016-02-23 Thread Stefan Wahren
Currently qcaspi_netdev_setup accidentally clears IFF_BROADCAST. So fix this by keeping the flags from ether_setup. Reported-by: Michael Heimpold Signed-off-by: Stefan Wahren Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet over SPI driver for QCA7000) --- drivers/net/ethernet/qualcomm/qca_spi.

Re: [PATCH net-next 5/5] veth: implement ndo_set_rx_headroom

2016-02-23 Thread pravin shelar
On Tue, Feb 23, 2016 at 4:53 AM, Paolo Abeni wrote: > The rx headroom for veth dev is the peer device needed_headroom. > Avoid ping-pong updates setting the private flag IFF_PHONY_HEADROOM. > > This avoids skb head reallocation when forwarding from a veth dev > towards a device adding some kind of

Re: [PATCH net-next 3/5] ovs: propagate per dp max headroom to all vports

2016-02-23 Thread pravin shelar
On Tue, Feb 23, 2016 at 4:53 AM, Paolo Abeni wrote: > This patch implements bookkeeping support to compute the maximum > headroom for all the devices in each datapath. When said value > changes, the underlying devs are notified via the > ndo_set_rx_headroom method. > > This also increases the inte

Re: [PATCH net-next 1/5] netdev: introduce ndo_set_rx_headroom

2016-02-23 Thread pravin shelar
On Tue, Feb 23, 2016 at 4:53 AM, Paolo Abeni wrote: > This method allows the controlling device (i.e. the bridge) to specify > additional headroom to be allocated for skb head on frame reception. > > Signed-off-by: Paolo Abeni > --- > include/linux/netdevice.h | 20 > 1 file

Re: [PATCH net-next 2/5] bridge: notify ensabled devices of headroom changes

2016-02-23 Thread pravin shelar
On Tue, Feb 23, 2016 at 4:53 AM, Paolo Abeni wrote: > On bridge needed_headroom changes, the enslaved devices are > notified via the ndo_set_rx_headroom method > > Signed-off-by: Paolo Abeni > --- > net/bridge/br_if.c | 36 ++-- > 1 file changed, 34 insertions(+),

[PATCH 1/1] phy: marvell: Fix 88E1510 initialization

2016-02-23 Thread Clemens Gruber
A bug was introduced in the merge commit b633353115e3 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net") The generic marvell_config_init (and therefore marvell_of_reg_init) is not called anymore for the Marvell 88E1510 (in net-next). This patch calls marvell_config_init and moves th

[PATCH 0/1] net and net-next merge conflict bug

2016-02-23 Thread Clemens Gruber
Hi Dave, in your merge commit b633353115e3 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net"), you merged net into net-next and commit 930b37ee8d84 ("net: phy: Add SGMII support for Marvell 88E1510/1512/1514/1518") overwrote a fix from commit 79be1a1c9090 ("phy: marvell: Fix and uni

Re: [PATCH] bnx2x: add a separate GENEVE Kconfig symbol

2016-02-23 Thread Yuval Mintz
> When CONFIG_GENEVE is built as a loadable module, and bnx2x is built-in, > we get this link error: > drivers/net/built-in.o: In function `bnx2x_open': > :(.text+0x33322): undefined reference to `geneve_get_rx_port' > drivers/net/built-in.o: In function `bnx2x_sp_rtnl_task': > :(.text+0x3e632): u

[net-next PATCH 4/4] net: sched: create hardware only classifier filter

2016-02-23 Thread John Fastabend
If users want to run filters specifically in hardware without software running the classifiers we need to use a special handler for this. By using a new classifier list we are able to add filters in hardware and keep all the same semantics in the core module. So the core code will continue to block

[net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-23 Thread John Fastabend
In the initial implementation the only way to stop a rule from being inserted into the hardware table was via the device feature flag. However this doesn't work well when working on an end host system where packets are expect to hit both the hardware and software datapaths. For example we can imag

[net-next PATCH 2/4] net: cls_u32: move TC offload feature bit into cls_u32 offload logic

2016-02-23 Thread John Fastabend
In the original series drivers would get offload requests for cls_u32 rules even if the feature bit is disabled. This meant the driver had to do a boiler plate check on the feature bit before adding/deleting the rule. This patch lifts the check into the core code and removes it from the driver spe

  1   2   3   >