From: Julia Lawall <julia.law...@lip6.fr>
The index variable of list_for_each_entry_safe should never be NULL.
Generated by: scripts/coccinelle/iterators/itnull.cocci
CC: Gangfeng Huang <gangfeng.hu...@ni.com>
Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang...@intel.com>
Tested-by: Aaron Brown <aaron.f.br...@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
---
drivers/net/ethernet/intel/igb/igb_cdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_cdev.c
b/drivers/net/ethernet/intel/igb/igb_cdev.c
index 28fafec..5e6579c 100644
--- a/drivers/net/ethernet/intel/igb/igb_cdev.c
+++ b/drivers/net/ethernet/intel/igb/igb_cdev.c
@@ -411,8 +411,7 @@ static int igb_close_file(struct inode *inode, struct file
*file)
list_for_each_entry_safe(userpage, tmp,
&adapter->user_page_list, page_node) {
- if (userpage)
- igb_free_page(adapter, userpage);
+ igb_free_page(adapter, userpage);
}
}
mutex_unlock(&adapter->user_page_mutex);
--
2.5.0
