> Code Style: pointer is declared wrong
>
> Signed-off-by: Paul McQuade
> Acked-by: Helmut Schaa
This patch didn't apply, so please resend.
Kalle
> Removed empty spaces before/after parenthesis
>
> Signed-off-by: Paul McQuade
> Acked-by: Helmut Schaa
Thanks, 2 patches applied to wireless-drivers-next.git:
b2cc2dd8ebb8 net: wireless: rt2x00: Space issue
5b451715e94d net: wireless: rt2x00: Space Required
1 patches skipped:
[2/3] net: w
> Removed empty spaces before/after parenthesis
>
> Signed-off-by: Paul McQuade
> Acked-by: Helmut Schaa
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
On Sat, Feb 6, 2016 at 10:58 AM, Julian Anastasov wrote:
>
> I now see that we should split the loop
> here, so that NETDEV_DOWN_BATCH is called only once per net:
>
> bool down = false;
>
> for_each_netdev(net, dev) {
> if (dev == l
On Fri, Feb 5, 2016 at 8:04 AM, Sergei Shtylyov
wrote:
> On 02/05/2016 02:35 AM, Salam Noureddine wrote:
>>
>> if (event == NETDEV_UNREGISTER) {
>> - fib_disable_ip(dev, event, true);
>> + if (fib_sync_down_dev(dev, event, true))
>> + net-
The return value of kzalloc on failure of allocation of memory should
be -ENOMEM and not -1.
Found using Coccinelle. A simplified version of the semantic patch
used is:
//
@@
expression *e;
@@
e = kzalloc(...);
if (e == NULL) {
...
return
- -1
+ -ENOMEM
;
}
//
The single call site only checks t
The nft_counter_init() and nft_counter_clone() functions should return
negative error value -ENOMEM instead of positive ENOMEM.
Signed-off-by: Anton Protopopov
---
net/netfilter/nft_counter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/nft_counter.c b/ne
With a bit larger, branchy eBPF programs f.e. already ~BPF_MAXINSNS/7 in
size, it happens rather quickly that bpf(2) rejects also valid programs
when only the verifier log buffer size we have in tc is too small.
Change that, so by default we don't do any logging, and only in error
case we retry wi
Don't reimplement them and rather use the macros from the gelf header,
that is, GELF_ST_BIND()/GELF_ST_TYPE().
Signed-off-by: Daniel Borkmann
---
tc/tc_bpf.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tc/tc_bpf.c b/tc/tc_bpf.c
index 5e80d0f..6a94894 100644
--- a/t
Add a couple of improvements to tc's BPF api, that facilitate program
development.
Signed-off-by: Daniel Borkmann
---
examples/bpf/bpf_cyclic.c | 4 +---
examples/bpf/bpf_graft.c| 13 +++
examples/bpf/bpf_prog.c | 26 ++---
examples/bpf/bpf_shared.c | 3 +--
Provide some more hints to the user/developer when relos have been found
that don't point to ld64 imm instruction. Ran couple of times into relos
generated by clang [1], where the compiler tried to uninline inlined
functions with eBPF and emitted BPF_JMP | BPF_CALL opcodes. If this seems
the case,
Couple of minor updates on tc frontend.
Resending with no changes and with John's Acked-by kept, orignal
version got set to 'Changes requested' by mistake.
Thanks!
Daniel Borkmann (4):
tc, bpf, examples: further bpf_api improvements
tc, bpf: improve verifier logging
tc, bpf: give some more
The dm9000 driver doesn't work in at least one device-tree
configuration, spitting an error message on irq resource :
[1.062495] dm9000 800.ethernet: insufficient resources
[1.068439] dm9000 800.ethernet: not found (-2).
[1.073451] dm9000: probe of 800.ethernet failed with e
From: Eric Dumazet
Date: Sat, 06 Feb 2016 11:16:28 -0800
> From: Eric Dumazet
>
> When we acknowledge a FIN, it is not enough to ack the sequence number
> and queue the skb into receive queue. We also have to call tcp_fin()
> to properly update socket state and send proper poll() notifications.
Le 05/02/2016 15:13, Andrew F. Davis a écrit :
> The TI TLK10x Ethernet PHYs are similar in the interrupt relevant
> registers and so are compatible with the DP83848x devices already
> supported. Add these and re-order code to support additional PHYs.
This looks fine, but this could also be broken
The smc91x driver doesn't honor the probe deferral mechanism when the
interrupt source is not yet available, such as one provided by a gpio
controller not probed.
Fix this by propagating the platform_get_irq() error code as the probe
return value.
Signed-off-by: Robert Jarzmik
Cc: Sergei Shtylyo
Hi David,
These two patches are cleanups to the BCM7xxx internal PHY driver:
- fix a constant name missing a X (as in BCM7XXX)
- add a macro to reduce the amount of code duplication to add new entries
Thanks!
Florian Fainelli (2):
net: phy: bcm7xxx: Make MII_BCM7XX_64CLK_MDIO naming consisten
The driver is BCM7xxx, we were missing an additional X in the constant naming,
fix that to be consistent.
Signed-off-by: Florian Fainelli
---
drivers/net/phy/bcm7xxx.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.
Introduce a macro which helps adding new 40NM EPHY entries and reduces the
amount of boilerplate code.
Signed-off-by: Florian Fainelli
---
drivers/net/phy/bcm7xxx.c | 54 +++--
1 files changed, 18 insertions(+), 36 deletions(-)
diff --git a/drivers/net/
On Fri, Feb 5, 2016 at 3:28 PM, Alexander Duyck wrote:
> This patch enables us to use inner checksum offloads if provided by
> hardware with outer checksums computed by software.
>
> It basically reduces encap_hdr_csum to an advisory flag for now, but based
> on the fact that SCTP may be getting s
The PHY entries for BCM7425/29/35 declare the 40nm Ethernet PHY as being
10/100/1000 capable, while this is just a 10/100 capable PHY device, fix that.
Fixes: d068b02cfdfc2 ("net: phy: add BCM7425 and BCM7429 PHYs")
Fixes: 9458ceab4917 ("net: phy: bcm7xxx: Add entry for BCM7435")
Signed-off-by: Fl
Since we were wrongly advertising gigabit features for these 10/100 only
Ethernet PHYs, bcm7xxx_config_init() which is supposed to apply workaround
would have not run since the check would be true, now that we have fixed the
PHY features, remove that check since it has no reasoning to be there anym
Remove the two wildcard entries, they serve no purpose and will match way too
many devices, some of them being covered by the driver in
drivers/net/phy/broadcom.c. Remove the now unused bcm7xxx_dummy_config_init()
function which would produce a warning.
Fixes: b560a58c45c6 ("net: phy: add Broadcom
On Fri, Feb 5, 2016 at 3:28 PM, Alexander Duyck wrote:
> The segmentation code was having to do a bunch of work to pull the
> skb->len and strip the udp header offset before the value could be used to
> adjust the checksum. Instead of doing all this work we can just use the
> value that goes into
From: Florian Fainelli
Hi David,
Here is a collection of fixes for the 40nm Ethernet PHY supported
by the 7xxx PHY driver, please also queue these fixes for stable.
Changes in v2:
- dropped the cleanup patch, not appropriate
- added another patch removing bogus wildcard entries
Thanks!
Flori
The clear and set masks in the call to phy_set_clr_bits() called from
bcm7xxx_config_init() are inverted. We need to fix this by swapping the two
arguments, that is, set 0 bits, but clear the shade mode 2 enable bit.
Fixes: b560a58c45c66 ("net: phy: add Broadcom BCM7xxx internal PHY driver")
Signe
On Fri, Feb 5, 2016 at 3:28 PM, Alexander Duyck wrote:
> This patch goes though and cleans up the logic related to several of the
> control flags used in UDP segmentation. Specifically the use of dont_encap
> isn't really needed as we can just check the skb for CHECKSUM_PARTIAL and
> if it isn't
On Fri, Feb 5, 2016 at 3:28 PM, Alexander Duyck wrote:
> Instead of parsing headers to determine the inner protocol we can just pull
> the value from inner_proto.
>
> Signed-off-by: Alexander Duyck
> ---
> net/ipv4/gre_offload.c |6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
On Fri, Feb 5, 2016 at 3:28 PM, Alexander Duyck wrote:
> This patch updates the gre checksum path to follow something much closer to
> the UDP checksum path. By doing this we can avoid needing to do as much
> header inspection and can just make use of the fields we were already
> reading in the s
On Fri, Feb 5, 2016 at 3:27 PM, Alexander Duyck wrote:
> The call skb_has_shared_frag is used in the GRE path and skb_checksum_help
> to verify that no frags can be modified by an external entity. This check
> really doesn't belong in the GRE path but in the skb_segment function
> itself. This w
On Fri, Feb 5, 2016 at 3:27 PM, Alexander Duyck wrote:
> This patch addresses two main issues.
>
> First in the case of remote checksum offload we were avoiding dealing with
> scatter-gather issues. As a result it would be possible to assemble a
> series of frames that used frags instead of being
On Fri, Feb 5, 2016 at 3:27 PM, Alexander Duyck wrote:
> This patch moves the checksum maintained by GSO out of skb->csum and into
> the GSO context block in order to allow for us to work on outer checksums
> while maintaining the inner checksum offsets in the case of the inner
> checksum being of
On Fri, Feb 5, 2016 at 3:27 PM, Alexander Duyck wrote:
> The enc_features variable isn't necessary since features isn't used
> anywhere after we create enc_features so instead just use a destructive AND
> on features itself and save ourselves the variable declaration.
>
> Signed-off-by: Alexander
Fri, Feb 05, 2016 at 06:38:42PM CET, alexei.starovoi...@gmail.com wrote:
>On Fri, Feb 05, 2016 at 11:01:22AM +0100, Hannes Frederic Sowa wrote:
>>
>> Okay. I see it more as changing mode of operation of hardware and thus has
>> not really anything to do with networking. If you say you change ether
From: Eric Dumazet
When we acknowledge a FIN, it is not enough to ack the sequence number
and queue the skb into receive queue. We also have to call tcp_fin()
to properly update socket state and send proper poll() notifications.
It seems we also had the problem if we received a SYN packet with t
Hello,
On Thu, 4 Feb 2016, Salam Noureddine wrote:
> @@ -1572,12 +1583,17 @@ rollback:
> call_netdevice_notifier(nb, NETDEV_GOING_DOWN,
> dev);
> call_netdevice_notifier(nb,
On Sat, 2016-02-06 at 03:13 -0500, David Miller wrote:
> From: Eric Dumazet
> Date: Mon, 1 Feb 2016 21:03:06 -0800
>
> > Implements RFC 7413 (TCP Fast Open) 4.2.2, accepting payload and/or FIN
> > in SYNACK messages, and prepare removal of SYN flag in tcp_recvmsg()
>
> Series applied, thanks Er
Robert Shearman writes:
> It is sometimes desirable to present an MPLS transport network as a
> single hop to traffic transiting it because it prevents confusion when
> diagnosing failures. An example of where confusion can be generated is
> when addresses used in the provider network overlap wit
On Fri, Feb 05, 2016 at 02:07:14PM -0500, Vivien Didelot wrote:
> BRIDGE_VLAN_FILTERING automatically adds a newly bridged port to the
> VLAN with the bridge's default_pvid.
>
> The mv88e6xxx driver currently reserves VLANs 4000+ for unbridged ports
> isolation. When a port joins a bridge, it leav
On Fri, Feb 05, 2016 at 02:04:39PM -0500, Vivien Didelot wrote:
> The current bridge code calls switchdev_port_obj_del on a VLAN port even
> if the corresponding switchdev_port_obj_add call returned -EOPNOTSUPP.
>
> If the DSA driver doesn't return -EOPNOTSUPP for a software port VLAN in
> its por
When adding support for the R-Car gen3 gPTP active in configuration mode,
some call sites of ravb_ptp_{init|stop}() were missed due to an oversight.
Add checks for the R-Car gen2 SoCs around these...
Fixes: f5d7837f96e5 ("ravb: ptp: Add CONFIG mode support")
Signed-off-by: Sergei Shtylyov
---
When adding support for the R-Car gen3 gPTP active in configuration mode,
the code setting the CCC.CSEL field was duplicated due to an oversight.
For R-Car gen 2 it's just redundant and for R-Car gen3 the write at this
time is probably ignored due to CCC.GAC bit being already set...
Fixes: f
Hello.
Here's a set of 2 patches against DaveM's 'net.git' repo fixing up the
incomplete commit f5d7837f96e5 ("ravb: ptp: Add CONFIG mode support").
I'm proposing these as fixes but they can be merged as cleanups as well...
[1/2] ravb: kill duplicate setting of CCC.CSEL
[2/2] ravb: skip gPTP s
On Sat, 2016-02-06 at 02:39 -0500, David Miller wrote:
> From: Corcodel Marian
> Date: Sat, 6 Feb 2016 08:31:26 +0200
>
> > @@ -8262,8 +8262,9 @@ static int rtl_init_one(struct pci_dev *pdev,
> const struct pci_device_id *ent)
> > rtl_hw_reset(tp);
> >
> > rtl_ack_events(tp, 0x
Hello.
On 2/4/2016 2:49 PM, Jeff Kirsher wrote:
From: Anjali Singhai Jain
Add write-back on interrupt throttle rate timer expiration support
for the i40evf driver, when running on X722 devices.
Signed-off-by: Anjali Singhai Jain
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
[...]
> The driver reads a value from hfa384x_from_bap(), which may fail,
> and then assigns the value to a local variable. gcc detects that
> in in the failure case, the 'rlen' variable now contains
> uninitialized data:
>
> In file included from
> ../drivers/net/wireless/intersil/hostap/hostap_pci.c
> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems
> the card responds very quickly most of the time, unfortunately during
> initialisation it sometimes seems to take just a bit over 2 seconds to
> respond.
>
> This results intialization failing with message like:
> brcm
Hello.
On 2/6/2016 12:52 AM, Troy Kisky wrote:
If you don't own it, you shouldn't write to it.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.
> On Fri, Feb 05, 2016 at 09:42:24AM +0800, 张胜举 wrote:
> > > On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote:
> > > > Replace 'goto' with 'return' to remove unnecessary check at label:
> > > > err_undo_flags.
> > >
> > > I think you're going to have to explain how you came to the
> >
Robert Shearman :
[...]
> diff --git a/net/mpls/Makefile b/net/mpls/Makefile
> index 9ca923625016..6fdd61b9eae3 100644
> --- a/net/mpls/Makefile
> +++ b/net/mpls/Makefile
[...]
> @@ -98,6 +94,29 @@ bool mpls_pkt_too_big(const struct sk_buff *skb, unsigned
> int mtu)
> }
> EXPORT_SYMBOL_GPL(mpls
Michael McConville :
> My analysis in the below mail applies, although the second part is
> unnecessary because i isn't used in arithmetic operations here:
>
> https://marc.info/?l=openbsd-tech&m=145377854103866&w=2
>
> Thanks for your time.
Acked-by: Francois Romieu
For all practical matters
David Miller writes:
> From: Robert Jarzmik
> Date: Fri, 05 Feb 2016 22:44:56 +0100
>
>> Apart from Alberto who answered he cannot test it by lack of hardware, the
>> others didn't answer.
>>
>> So how can I move forward ? Would you want me to amend the KConfig to add a
>> "&&
>> !ARCH_PXA" on
From: Parthasarathy Bhuvaragan
Date: Tue, 2 Feb 2016 10:52:07 +0100
> This series contains topology server cleanups, fixes and improvements.
>
> Cleanups in #1-#4:
> We remove duplicate data structures and aligin the rest of the code
> accordingly.
>
> Fixes in #5-#8:
> The bugs occur either d
From: Rabin Vincent
Date: Tue, 2 Feb 2016 09:39:02 +0100
> From: Rabin Vincent
>
> The hardware reset is currently done after phy_start() is called,
> leading to a race where we can lose the link status if the phy state
> machine calls dwceqos_adjust_link() before we reset the MAC registers.
>
From: Zhang Shengju
Date: Tue, 2 Feb 2016 08:32:55 +
> netdev_dbg() will add bond device name, it will be helpful if we print
> slave device name.
>
> Signed-off-by: Zhang Shengju
Applied.
From: Rafał Miłecki
Date: Tue, 2 Feb 2016 07:47:14 +0100
> Chipsets with BCM4707 / BCM53018 ID require special handling at a few
> places in the code. It's likely there will be more IDs to check in the
> future. To simplify it add this trivial helper.
>
> Signed-off-by: Rafał Miłecki
Applied.
From: Alexei Starovoitov
Date: Mon, 1 Feb 2016 22:39:52 -0800
> We've started to use bpf to trace every packet and atomic add
> instruction (event JITed) started to show up in perf profile.
> The solution is to do per-cpu counters.
> For PERCPU_(HASH|ARRAY) map the existing bpf_map_lookup() helpe
From: Kim Jones
Date: Tue, 2 Feb 2016 03:51:16 +
> netdev_rss_key is written to once and thereafter is read by
> drivers when they are initialising. The fact that it is mostly
> read and not written to makes it a candidate for a __read_mostly
> declaration.
>
> Signed-off-by: Kim Jones
> S
From: Eric Dumazet
Date: Mon, 1 Feb 2016 21:03:06 -0800
> Implements RFC 7413 (TCP Fast Open) 4.2.2, accepting payload and/or FIN
> in SYNACK messages, and prepare removal of SYN flag in tcp_recvmsg()
Series applied, thanks Eric.
From: subas...@codeaurora.org
Date: Tue, 2 Feb 2016 02:11:10 -
> A rcu stall with the following backtrace was seen on a system with
> forwarding, optimistic_dad and use_optimistic set. To reproduce,
> set these flags and allow ipv6 autoconf.
>
> This occurs because the device write_lock is ac
From: Jarod Wilson
Date: Mon, 1 Feb 2016 18:51:03 -0500
...
> It seems additional counters never came to fruition, so this is a first
> attempt at creating one of them, so that we stop calling these drops,
> which for users monitoring rx_dropped, causes great alarm, and renders the
> counter mu
61 matches
Mail list logo
